OSDN Git Service

android-x86/system-bt.git
3 years agoDecl-def event bta/gatt/bta_gattc_act:bta_gattc_close am: 13a538260b am: 067fc4560d...
Chris Manton [Thu, 13 May 2021 23:23:34 +0000 (23:23 +0000)]
Decl-def event bta/gatt/bta_gattc_act:bta_gattc_close am: 13a538260b am: 067fc4560d am: cdb4c69a09

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700655

Change-Id: Icd5b0cff9ba205bb4a1d79bc610de33331394d59

3 years agoDecl-def event bta/gatt/bta_gattc_act:bta_gattc_close am: 13a538260b am: 067fc4560d
Chris Manton [Thu, 13 May 2021 23:05:07 +0000 (23:05 +0000)]
Decl-def event bta/gatt/bta_gattc_act:bta_gattc_close am: 13a538260b am: 067fc4560d

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700655

Change-Id: I652bd509a2d373990d9ad6674a2d546f6a607e9f

3 years agoDecl-def event bta/gatt/bta_gattc_act:bta_gattc_close am: 13a538260b
Chris Manton [Thu, 13 May 2021 22:49:55 +0000 (22:49 +0000)]
Decl-def event bta/gatt/bta_gattc_act:bta_gattc_close am: 13a538260b

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700655

Change-Id: I1ebfb0a6afc250ad1e7c1bbb52cc535ed255dae1

3 years agoavdt_scb: fix dereferences of NULL
George Burgess IV [Thu, 13 May 2021 19:20:24 +0000 (12:20 -0700)]
avdt_scb: fix dereferences of NULL

A recent change to this code added `int` in this for loop's first clause
(good, since that's way more common than declaring `i` outside of the
loop). Unfortunately, this caused the `*p_err_code = 0` to be
interpreted as "create a new int* called p_err_code and set it to 0,"
rather than "set the value pointed to by p_err_code to 0."

Caught by clang's static analyzer:

> system/bt/stack/avdt/avdt_scb.cc:936:19: warning: Dereference of null
pointer (loaded from variable 'p_err_code')
[clang-analyzer-core.NullDereference]>
system/bt/stack/avdt/avdt_scb.cc:941:19: warning: Dereference of null
pointer (loaded from variable 'p_err_code')
[clang-analyzer-core.NullDereference] >
system/bt/stack/avdt/avdt_scb.cc:946:19: warning: Dereference of null
pointer (loaded from variable 'p_err_code')
[clang-analyzer-core.NullDereference] >
system/bt/stack/avdt/avdt_scb.cc:955:23: warning: Dereference of null
pointer (loaded from variable 'p_err_code')
[clang-analyzer-core.NullDereference] >
system/bt/stack/avdt/avdt_scb.cc:963:23: warning: Dereference of null
pointer (loaded from variable 'p_err_code')
[clang-analyzer-core.NullDereference]

Bug: 180421437
Test: TreeHugger
Change-Id: I834032e22da0ed558c25355c9d1cf20c11c8c530

3 years agoDecl-def event bta/gatt/bta_gattc_act:bta_gattc_close
Chris Manton [Sat, 8 May 2021 23:48:04 +0000 (16:48 -0700)]
Decl-def event bta/gatt/bta_gattc_act:bta_gattc_close

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I90abbd76e89d1d395859eaa19555c65112f31987

3 years agoMerge "Fix potential null dereferences in btif_rc.cc" into sc-dev
Jakub Pawlowski [Thu, 13 May 2021 18:04:58 +0000 (18:04 +0000)]
Merge "Fix potential null dereferences in btif_rc.cc" into sc-dev

3 years agoRemove useless #def bta/hh/bta_hh_int::BTA_HH_MAX_RPT_CHARS am: c8b751d164 am: cae8c9...
Chris Manton [Thu, 13 May 2021 17:48:25 +0000 (17:48 +0000)]
Remove useless #def bta/hh/bta_hh_int::BTA_HH_MAX_RPT_CHARS am: c8b751d164 am: cae8c9c79a am: e91aea7f06

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700654

Change-Id: I5a524c181b07ecf05ab74faa75d8d8885b1bccca

3 years agoRemove useless #def bta/hh/bta_hh_int::BTA_HH_MAX_RPT_CHARS am: c8b751d164 am: cae8c9c79a
Chris Manton [Thu, 13 May 2021 17:23:45 +0000 (17:23 +0000)]
Remove useless #def bta/hh/bta_hh_int::BTA_HH_MAX_RPT_CHARS am: c8b751d164 am: cae8c9c79a

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700654

Change-Id: I8cb7e2a62184df48b3494ff88329b2cb2821a308

3 years agoRemove useless #def bta/hh/bta_hh_int::BTA_HH_MAX_RPT_CHARS am: c8b751d164
Chris Manton [Thu, 13 May 2021 17:00:36 +0000 (17:00 +0000)]
Remove useless #def bta/hh/bta_hh_int::BTA_HH_MAX_RPT_CHARS am: c8b751d164

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700654

Change-Id: I9e4ba18aa80bd0f0c1d112dcc91e33bfbf2a0657

3 years agoFix potential null dereferences in btif_rc.cc
Jakub Pawlowski [Thu, 13 May 2021 16:10:08 +0000 (18:10 +0200)]
Fix potential null dereferences in btif_rc.cc

Test: compilation
Bug: 182163258
Change-Id: I2450962736f067db28d4b1657ae632f77ada6afe

3 years agoMerge "CTKD: Fix role change bug on legacy BT stack" am: 672131f257 am: 85fc6e6012...
Treehugger Robot [Thu, 13 May 2021 16:01:10 +0000 (16:01 +0000)]
Merge "CTKD: Fix role change bug on legacy BT stack" am: 672131f257 am: 85fc6e6012 am: dfb71cfc7e

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1697087

Change-Id: I106656f327b0cc1ae5b0c997f8096bf4cfd7c5e2

3 years agoMerge "CTKD: Fix role change bug on legacy BT stack" am: 672131f257 am: 85fc6e6012
Treehugger Robot [Thu, 13 May 2021 15:44:33 +0000 (15:44 +0000)]
Merge "CTKD: Fix role change bug on legacy BT stack" am: 672131f257 am: 85fc6e6012

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1697087

Change-Id: I523f6f26dfbde72fae38b639ef65aa4985d6186f

3 years agoMerge "CTKD: Fix role change bug on legacy BT stack" am: 672131f257
Treehugger Robot [Thu, 13 May 2021 15:29:44 +0000 (15:29 +0000)]
Merge "CTKD: Fix role change bug on legacy BT stack" am: 672131f257

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1697087

Change-Id: I78e80cddb072543e1995585cb03d4e46631f4773

3 years agoRemove useless #def bta/hh/bta_hh_int::BTA_HH_MAX_RPT_CHARS
Chris Manton [Sat, 8 May 2021 23:41:47 +0000 (16:41 -0700)]
Remove useless #def bta/hh/bta_hh_int::BTA_HH_MAX_RPT_CHARS

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I4b5501ecf96f67c451e86323752ae07ad88940bb

3 years agoMerge "CTKD: Fix role change bug on legacy BT stack"
Treehugger Robot [Thu, 13 May 2021 15:11:25 +0000 (15:11 +0000)]
Merge "CTKD: Fix role change bug on legacy BT stack"

3 years agoCTKD: Fix role change bug on legacy BT stack
Animesh Fatehpuria [Wed, 5 May 2021 07:51:21 +0000 (15:51 +0800)]
CTKD: Fix role change bug on legacy BT stack

If a role switch happens before connection complete, we incorrectly
ignore the information. This can sometimes cause CTKD to not function
properly.

Bug: 186367778
Tag: #refactor
Test: atest net_test_main_shim, presubmit, manual role change testing
(with and without gd enabled)

Change-Id: I619376d35051a9b5ead74608a66fae1c5ea32c2b

3 years agoMerge "remove unused fields" am: eec6ea121c am: 5a8ca9cddc am: 6490206211
Treehugger Robot [Thu, 13 May 2021 05:48:03 +0000 (05:48 +0000)]
Merge "remove unused fields" am: eec6ea121c am: 5a8ca9cddc am: 6490206211

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700653

Change-Id: If60c71778021d9781d65c4164a035a23eb78e37c

3 years agoMerge "remove unused fields" am: eec6ea121c am: 5a8ca9cddc
Treehugger Robot [Thu, 13 May 2021 05:24:57 +0000 (05:24 +0000)]
Merge "remove unused fields" am: eec6ea121c am: 5a8ca9cddc

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700653

Change-Id: Id81e08e65b5cdde6274b92e67a7eac8fa05bdcae

3 years agoMerge "remove unused fields" am: eec6ea121c
Treehugger Robot [Thu, 13 May 2021 05:08:11 +0000 (05:08 +0000)]
Merge "remove unused fields" am: eec6ea121c

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700653

Change-Id: I76d36c558384e7529528234d4ddc1773650dd903

3 years agoMerge "remove unused fields"
Treehugger Robot [Thu, 13 May 2021 04:50:42 +0000 (04:50 +0000)]
Merge "remove unused fields"

3 years agoMerge "Separate End, Reset, and Quit" am: 702c9941ad am: 23e25f722c am: ebf688bb93
Treehugger Robot [Thu, 13 May 2021 04:32:59 +0000 (04:32 +0000)]
Merge "Separate End, Reset, and Quit" am: 702c9941ad am: 23e25f722c am: ebf688bb93

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1705639

Change-Id: I4fc7eae2cc3a31c10fe6af169ba267b21998088f

3 years agoEnum-ify tBTA_HH_INT_EVT am: d2af009d02 am: 0a9d0252c3 am: 54c7a88e0f
Chris Manton [Thu, 13 May 2021 04:32:47 +0000 (04:32 +0000)]
Enum-ify tBTA_HH_INT_EVT am: d2af009d02 am: 0a9d0252c3 am: 54c7a88e0f

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700652

Change-Id: I67543d24fc5f6d2b22fd9320cb2b5afb6a7fe54f

3 years agoRemove useless #def bta/hh/bta_hh_int::BTA_HH_ am: e3e69be13d am: 926e6ac72a am:...
Chris Manton [Thu, 13 May 2021 04:32:45 +0000 (04:32 +0000)]
Remove useless #def bta/hh/bta_hh_int::BTA_HH_ am: e3e69be13d am: 926e6ac72a am: c5c36be70f

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700651

Change-Id: I3d7015bd2234d796ebe8cf24faba63ec1981a3fa

3 years agoRemove useless #def bta/hh/bta_hh_::BTA_HH_FST_BTE_TRANS_EVT am: 3567c1c062 am: 68e1c...
Chris Manton [Thu, 13 May 2021 04:32:41 +0000 (04:32 +0000)]
Remove useless #def bta/hh/bta_hh_::BTA_HH_FST_BTE_TRANS_EVT am: 3567c1c062 am: 68e1c2d253 am: 9a9bdf1e12

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700650

Change-Id: Ifafea3b8724ac820afb46b9cedf79e1d4016cd89

3 years agoMerge "Separate End, Reset, and Quit" am: 702c9941ad am: 23e25f722c
Treehugger Robot [Thu, 13 May 2021 03:29:36 +0000 (03:29 +0000)]
Merge "Separate End, Reset, and Quit" am: 702c9941ad am: 23e25f722c

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1705639

Change-Id: Ifb852a09ea30714f54db75550ae5cd0fa2798beb

3 years agoEnum-ify tBTA_HH_INT_EVT am: d2af009d02 am: 0a9d0252c3
Chris Manton [Thu, 13 May 2021 03:29:25 +0000 (03:29 +0000)]
Enum-ify tBTA_HH_INT_EVT am: d2af009d02 am: 0a9d0252c3

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700652

Change-Id: I0315ec56e540d777fe617a2e47f508c38dbb2d61

3 years agoRemove useless #def bta/hh/bta_hh_int::BTA_HH_ am: e3e69be13d am: 926e6ac72a
Chris Manton [Thu, 13 May 2021 03:29:24 +0000 (03:29 +0000)]
Remove useless #def bta/hh/bta_hh_int::BTA_HH_ am: e3e69be13d am: 926e6ac72a

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700651

Change-Id: Ie4712f317aea8967c7d68b36b54f299b589606ca

3 years agoRemove useless #def bta/hh/bta_hh_::BTA_HH_FST_BTE_TRANS_EVT am: 3567c1c062 am: 68e1c...
Chris Manton [Thu, 13 May 2021 03:29:23 +0000 (03:29 +0000)]
Remove useless #def bta/hh/bta_hh_::BTA_HH_FST_BTE_TRANS_EVT am: 3567c1c062 am: 68e1c2d253

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700650

Change-Id: Icc1f1a72cac25ee60e1f75973c632adcb7432755

3 years agoMerge "Separate End, Reset, and Quit" am: 702c9941ad
Treehugger Robot [Thu, 13 May 2021 03:16:03 +0000 (03:16 +0000)]
Merge "Separate End, Reset, and Quit" am: 702c9941ad

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1705639

Change-Id: I51f6b74794b840a8daded0991e2497f559e76961

3 years agoMerge "Separate End, Reset, and Quit"
Treehugger Robot [Thu, 13 May 2021 03:09:20 +0000 (03:09 +0000)]
Merge "Separate End, Reset, and Quit"

3 years agoEnum-ify tBTA_HH_INT_EVT am: d2af009d02
Chris Manton [Thu, 13 May 2021 03:06:12 +0000 (03:06 +0000)]
Enum-ify tBTA_HH_INT_EVT am: d2af009d02

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700652

Change-Id: Ic1753c7bd0f27c6225e815b607fa78555b049fc4

3 years agoRemove useless #def bta/hh/bta_hh_int::BTA_HH_ am: e3e69be13d
Chris Manton [Thu, 13 May 2021 03:06:09 +0000 (03:06 +0000)]
Remove useless #def bta/hh/bta_hh_int::BTA_HH_ am: e3e69be13d

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700651

Change-Id: I75e478625cae718a5a558038c2af9e6cd7e26c43

3 years agoRemove useless #def bta/hh/bta_hh_::BTA_HH_FST_BTE_TRANS_EVT am: 3567c1c062
Chris Manton [Thu, 13 May 2021 03:05:26 +0000 (03:05 +0000)]
Remove useless #def bta/hh/bta_hh_::BTA_HH_FST_BTE_TRANS_EVT am: 3567c1c062

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700650

Change-Id: I30b22df76e4dae927bc065cd82e606b0a8e6ac37

3 years agoMerge changes If5f6b231,I8c5eb4bb,I01aa1955 am: 8577c8e621 am: fe5cf7cbf1 am: 6ff137977a
Chris Manton [Thu, 13 May 2021 02:44:26 +0000 (02:44 +0000)]
Merge changes If5f6b231,I8c5eb4bb,I01aa1955 am: 8577c8e621 am: fe5cf7cbf1 am: 6ff137977a

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700649

Change-Id: Id79d482cd724a78cd1b5b220925854ca5870f3ae

3 years agoMerge changes If5f6b231,I8c5eb4bb,I01aa1955 am: 8577c8e621 am: fe5cf7cbf1
Chris Manton [Thu, 13 May 2021 02:01:02 +0000 (02:01 +0000)]
Merge changes If5f6b231,I8c5eb4bb,I01aa1955 am: 8577c8e621 am: fe5cf7cbf1

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700649

Change-Id: I90e5368a798e24b5270437642640827b5d31a989

3 years agoMerge changes If5f6b231,I8c5eb4bb,I01aa1955 am: 8577c8e621
Chris Manton [Thu, 13 May 2021 01:25:19 +0000 (01:25 +0000)]
Merge changes If5f6b231,I8c5eb4bb,I01aa1955 am: 8577c8e621

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700649

Change-Id: Iba49f3d4d1fa8afa9efb14987d629c16ba3b4fa4

3 years agoremove unused fields
Chris Manton [Sat, 8 May 2021 21:41:23 +0000 (14:41 -0700)]
remove unused fields

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: Ief8a8daf8f5e2a6c75f1a460d95a6e205ad3bc96

3 years agoEnum-ify tBTA_HH_INT_EVT
Chris Manton [Sat, 8 May 2021 20:45:48 +0000 (13:45 -0700)]
Enum-ify tBTA_HH_INT_EVT

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: Iae765a7240ad61db3abfa8398b8e7d087f586afd

3 years agoRemove useless #def bta/hh/bta_hh_int::BTA_HH_
Chris Manton [Sat, 8 May 2021 20:39:39 +0000 (13:39 -0700)]
Remove useless #def bta/hh/bta_hh_int::BTA_HH_

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I520cccf0607bd9191802bdc6f362de48227b5132

3 years agoRemove useless #def bta/hh/bta_hh_::BTA_HH_FST_BTE_TRANS_EVT
Chris Manton [Sat, 8 May 2021 20:37:58 +0000 (13:37 -0700)]
Remove useless #def bta/hh/bta_hh_::BTA_HH_FST_BTE_TRANS_EVT

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I25d547b6870863d4b0a6fa3a2d12d626e043e62b

3 years agoInitial commit for rusty BluetoothManager am: 2dc4fc3188 am: 7beaf545d9 am: cc2cfb3fcc
Hansong Zhang [Thu, 13 May 2021 01:12:00 +0000 (01:12 +0000)]
Initial commit for rusty BluetoothManager am: 2dc4fc3188 am: 7beaf545d9 am: cc2cfb3fcc

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1662963

Change-Id: Ibd814462ed51c97f1aaf8aae55454f6e113a6a24

3 years agoMerge changes If5f6b231,I8c5eb4bb,I01aa1955
Chris Manton [Thu, 13 May 2021 01:11:33 +0000 (01:11 +0000)]
Merge changes If5f6b231,I8c5eb4bb,I01aa1955

* changes:
  Remove useless #def bta/hh/bta_hh_::BTA_HH_FST_TRANS_CB_EVT
  Streamline bta_hh_read_ssr_param
  Streamline BTM_GetLinkSuperTout

3 years agoInitial commit for rusty BluetoothManager am: 2dc4fc3188 am: 7beaf545d9
Hansong Zhang [Thu, 13 May 2021 00:55:05 +0000 (00:55 +0000)]
Initial commit for rusty BluetoothManager am: 2dc4fc3188 am: 7beaf545d9

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1662963

Change-Id: Ia80b7cd591daaf42e4cf92c863b8be57e27e4fbe

3 years agoInitial commit for rusty BluetoothManager am: 2dc4fc3188
Hansong Zhang [Thu, 13 May 2021 00:31:47 +0000 (00:31 +0000)]
Initial commit for rusty BluetoothManager am: 2dc4fc3188

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1662963

Change-Id: I528838ef9f1b5f4e7f35b2cce66128c242c87951

3 years agoSeparate End, Reset, and Quit
Myles Watson [Wed, 12 May 2021 23:49:13 +0000 (16:49 -0700)]
Separate End, Reset, and Quit

Bug: 187371955
Test: cert/run
Tag: #testing
Change-Id: I99b5181df1781545026cd25b659b399e86add71c

3 years agoInitial commit for rusty BluetoothManager
Hansong Zhang [Fri, 2 Apr 2021 21:24:08 +0000 (14:24 -0700)]
Initial commit for rusty BluetoothManager

Add the basic state machine (without timeout so far), basic DBUS API,
and basic unit test for state machine.

Bug: 179719629
Test: cargo test
Change-Id: I0aafc8e9e84defc5c19d1c235ed1c935cf6691cb

3 years agoRemove unused #defs bta/hh/bta_hh_utils am: 2c22338448 am: 945ac3ba5a am: d5cd1e01d0
Chris Manton [Wed, 12 May 2021 21:44:03 +0000 (21:44 +0000)]
Remove unused #defs bta/hh/bta_hh_utils am: 2c22338448 am: 945ac3ba5a am: d5cd1e01d0

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700646

Change-Id: I24876036cfb1e7f41869d66093b3182e8b72b6a3

3 years agoRemove unused funcs bta/hh::bta_hh_parse_ am: 83ae09b5fd am: ebd12c15dc am: d90bd3c013
Chris Manton [Wed, 12 May 2021 21:44:01 +0000 (21:44 +0000)]
Remove unused funcs bta/hh::bta_hh_parse_ am: 83ae09b5fd am: ebd12c15dc am: d90bd3c013

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700645

Change-Id: Ie26914c1b4b64789a56622eae5c09c61387550bf

3 years agoAdd name component to GATT client API am: 20ecfc4d9e am: 43f111a869 am: 34802ce23b
Chris Manton [Wed, 12 May 2021 21:43:59 +0000 (21:43 +0000)]
Add name component to GATT client API am: 20ecfc4d9e am: 43f111a869 am: 34802ce23b

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698157

Change-Id: Ic8b5534272db973681282bf049b3350fca838fe1

3 years agoRe-write bta/hh/bta_hh_le::bta_hh_le_close am: 0d27935218 am: 8b570f8471 am: 22fa770437
Chris Manton [Wed, 12 May 2021 21:43:18 +0000 (21:43 +0000)]
Re-write bta/hh/bta_hh_le::bta_hh_le_close am: 0d27935218 am: 8b570f8471 am: 22fa770437

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698151

Change-Id: I9c001f15744c341be1742d30e0193563411384a2

3 years agolog: Polish security record logging structures am: ed9b10a6c3 am: 67687658ad am:...
Chris Manton [Wed, 12 May 2021 21:43:15 +0000 (21:43 +0000)]
log: Polish security record logging structures am: ed9b10a6c3 am: 67687658ad am: d00b362393

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698160

Change-Id: Ibe043d47c58283abf0323544a060e44bcc3c91c0

3 years agoRemove unused #defs bta/hh/bta_hh_utils am: 2c22338448 am: 945ac3ba5a
Chris Manton [Wed, 12 May 2021 21:26:48 +0000 (21:26 +0000)]
Remove unused #defs bta/hh/bta_hh_utils am: 2c22338448 am: 945ac3ba5a

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700646

Change-Id: I505d875ecba0c606bf8f93d18d10e269c40eff77

3 years agoRemove unused funcs bta/hh::bta_hh_parse_ am: 83ae09b5fd am: ebd12c15dc
Chris Manton [Wed, 12 May 2021 21:26:47 +0000 (21:26 +0000)]
Remove unused funcs bta/hh::bta_hh_parse_ am: 83ae09b5fd am: ebd12c15dc

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700645

Change-Id: Ib34f7ac403875cfd044600e81f566bcf66dc5f74

3 years agoAdd name component to GATT client API am: 20ecfc4d9e am: 43f111a869
Chris Manton [Wed, 12 May 2021 21:26:46 +0000 (21:26 +0000)]
Add name component to GATT client API am: 20ecfc4d9e am: 43f111a869

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698157

Change-Id: Ieb771b09cf1a9ed3486aa4154e596fb96824c19e

3 years agoRe-write bta/hh/bta_hh_le::bta_hh_le_close am: 0d27935218 am: 8b570f8471
Chris Manton [Wed, 12 May 2021 21:26:38 +0000 (21:26 +0000)]
Re-write bta/hh/bta_hh_le::bta_hh_le_close am: 0d27935218 am: 8b570f8471

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698151

Change-Id: I286b87d867526bafb372c6af366d436757fc442f

3 years agolog: Polish security record logging structures am: ed9b10a6c3 am: 67687658ad
Chris Manton [Wed, 12 May 2021 21:26:36 +0000 (21:26 +0000)]
log: Polish security record logging structures am: ed9b10a6c3 am: 67687658ad

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698160

Change-Id: Idba368066d313db907ea8e9fca054f0fcdefaea5

3 years agoRemove unused #defs bta/hh/bta_hh_utils am: 2c22338448
Chris Manton [Wed, 12 May 2021 21:05:18 +0000 (21:05 +0000)]
Remove unused #defs bta/hh/bta_hh_utils am: 2c22338448

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700646

Change-Id: I9ef871dee016f1b624adb82918f637e1f6e5a35f

3 years agoRemove unused funcs bta/hh::bta_hh_parse_ am: 83ae09b5fd
Chris Manton [Wed, 12 May 2021 21:05:15 +0000 (21:05 +0000)]
Remove unused funcs bta/hh::bta_hh_parse_ am: 83ae09b5fd

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1700645

Change-Id: Ia3b7aa19f992f461ee8460f71e354c80fd661fd0

3 years agoAdd name component to GATT client API am: 20ecfc4d9e
Chris Manton [Wed, 12 May 2021 21:04:22 +0000 (21:04 +0000)]
Add name component to GATT client API am: 20ecfc4d9e

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698157

Change-Id: Ifddebd78a0472549cdbd23a7462a87bf6457e4ed

3 years agoFix potential null dereference in avdt_scb_verify
Jakub Pawlowski [Tue, 11 May 2021 17:05:58 +0000 (19:05 +0200)]
Fix potential null dereference in avdt_scb_verify

Bug: 180421437
Change-Id: If576aaf302ede63d6bbb13c32c96ac3eea44abf6

3 years agoGATT: initialize the notif completely
Richard Smith [Sun, 14 Feb 2021 10:49:21 +0000 (10:49 +0000)]
GATT: initialize the notif completely

Bug: 180418662
Change-Id: I71c1c2038b62c554490d38fdb0febf1217108992

3 years agoFix potential null dereference in avdt_ccb_hdl_getcap_cmd
Jakub Pawlowski [Tue, 11 May 2021 19:33:07 +0000 (21:33 +0200)]
Fix potential null dereference in avdt_ccb_hdl_getcap_cmd

Bug: 180421044
Change-Id: I1fccaa1cff055badaa2f156f880a6c6d9c28737a

3 years agoFix potential null dereference after call to read_command_complete_header
Jakub Pawlowski [Wed, 12 May 2021 09:39:59 +0000 (11:39 +0200)]
Fix potential null dereference after call to read_command_complete_header

Bug: 180421035
Test: compilation
Change-Id: I3606bb08f514d376087a454c482f28c6e4eadb59

3 years agoRe-write bta/hh/bta_hh_le::bta_hh_le_close am: 0d27935218
Chris Manton [Wed, 12 May 2021 18:59:17 +0000 (18:59 +0000)]
Re-write bta/hh/bta_hh_le::bta_hh_le_close am: 0d27935218

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698151

Change-Id: Ie539a7ccf331c314d52ae56436ed42aa998b68ec

3 years agolog: Polish security record logging structures am: ed9b10a6c3
Chris Manton [Wed, 12 May 2021 18:58:19 +0000 (18:58 +0000)]
log: Polish security record logging structures am: ed9b10a6c3

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698160

Change-Id: I00dd06ba5cd3ab68cf564a4cd476a88c8410ba62

3 years agoMerge changes I72f919a9,Ie6b989cd,Ifc867c33 am: 8ecad99e65 am: 783ba01f45 am: 7f9052c542
Treehugger Robot [Wed, 12 May 2021 18:25:02 +0000 (18:25 +0000)]
Merge changes I72f919a9,Ie6b989cd,Ifc867c33 am: 8ecad99e65 am: 783ba01f45 am: 7f9052c542

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698146

Change-Id: I60d5be8dd3a284670c3899a0eecdbe07d766c825

3 years agoMerge changes I72f919a9,Ie6b989cd,Ifc867c33 am: 8ecad99e65 am: 783ba01f45
Treehugger Robot [Wed, 12 May 2021 18:00:10 +0000 (18:00 +0000)]
Merge changes I72f919a9,Ie6b989cd,Ifc867c33 am: 8ecad99e65 am: 783ba01f45

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698146

Change-Id: I9bc4233434cd5c8db7b3718d946ce860a01d3d8f

3 years agoMerge changes I72f919a9,Ie6b989cd,Ifc867c33 am: 8ecad99e65
Treehugger Robot [Wed, 12 May 2021 17:28:59 +0000 (17:28 +0000)]
Merge changes I72f919a9,Ie6b989cd,Ifc867c33 am: 8ecad99e65

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698146

Change-Id: I6114e75f5387d84db81c409fb696594d13ce7dd3

3 years agoRemove useless #def bta/hh/bta_hh_::BTA_HH_FST_TRANS_CB_EVT
Chris Manton [Sat, 8 May 2021 20:37:10 +0000 (13:37 -0700)]
Remove useless #def bta/hh/bta_hh_::BTA_HH_FST_TRANS_CB_EVT

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: If5f6b231d08785ce10b3356d01ae83fa3ce1bbc7

3 years agoRemove unused #defs bta/hh/bta_hh_utils
Chris Manton [Sat, 8 May 2021 20:02:28 +0000 (13:02 -0700)]
Remove unused #defs bta/hh/bta_hh_utils

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I862bf32f11a82ecff1209d9ba5ef6233b8921e11

3 years agoRemove unused funcs bta/hh::bta_hh_parse_
Chris Manton [Sat, 8 May 2021 19:59:10 +0000 (12:59 -0700)]
Remove unused funcs bta/hh::bta_hh_parse_

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I3804de80d85d564b64dd533c92c3c6289bda66e7

3 years agoAdd name component to GATT client API
Chris Manton [Mon, 3 May 2021 06:14:26 +0000 (23:14 -0700)]
Add name component to GATT client API

Bug: 183374320
Test: gd/cert/run
Tag: #refactor
No-Typo-Check: Legacy code mocks

Change-Id: If6f3bd253391ff41cfcdde2d67325b06bfa58993

3 years agoStreamline bta_hh_read_ssr_param
Chris Manton [Sat, 8 May 2021 20:32:03 +0000 (13:32 -0700)]
Streamline bta_hh_read_ssr_param

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I8c5eb4bbab2c3a1f83ac8d2ac5eebc2c321c2d41

3 years agoStreamline BTM_GetLinkSuperTout
Chris Manton [Sat, 8 May 2021 20:31:39 +0000 (13:31 -0700)]
Streamline BTM_GetLinkSuperTout

Bug: 163134718
Test: gd/cert/run
Tag: #refactor

Change-Id: I01aa19551a404b1c6d0bad4021d7d7b982309ff5

3 years agoRe-write bta/hh/bta_hh_le::bta_hh_le_close
Chris Manton [Sat, 1 May 2021 06:39:08 +0000 (23:39 -0700)]
Re-write bta/hh/bta_hh_le::bta_hh_le_close

Bug: 183374320
Test: gd/cert/run
Tag: #refactor

Change-Id: Id76ec9557538231c28cd9ea235e1d522be5a531b

3 years agolog: Polish security record logging structures
Chris Manton [Mon, 3 May 2021 23:39:12 +0000 (16:39 -0700)]
log: Polish security record logging structures

Bug: 183374320
Test: gd/cert/run
Tag: #refactor

Change-Id: If22f738ca7aae645007b72512b25d8ad11a45620

3 years agoMerge changes I72f919a9,Ie6b989cd,Ifc867c33
Treehugger Robot [Wed, 12 May 2021 17:03:30 +0000 (17:03 +0000)]
Merge changes I72f919a9,Ie6b989cd,Ifc867c33

* changes:
  Const-ify bta/gatt/:: Api data param
  Introduce bta_gatt_test
  Properly initialize tGATT control block

3 years agoConst-ify bta/gatt/:: Api data param
Chris Manton [Tue, 4 May 2021 22:24:20 +0000 (15:24 -0700)]
Const-ify bta/gatt/:: Api data param

Towards immutable code

Bug: 187830698
Test: gd/cert/run
Tag: #refactor

Change-Id: I72f919a9e19e3f7ca05ad36f4a0ca267e8bd5dfc

3 years agoIntroduce bta_gatt_test
Chris Manton [Fri, 7 May 2021 16:45:55 +0000 (09:45 -0700)]
Introduce bta_gatt_test

Towards unregressive code

Bug: 187825293
Test: gd/cert/run
Tag: #refactor

Change-Id: Ie6b989cd2e55fd8188f8fcb7601342654fb84593

3 years agoProperly initialize tGATT control block
Chris Manton [Mon, 3 May 2021 16:37:29 +0000 (09:37 -0700)]
Properly initialize tGATT control block

Bug: 187827452
Test: gd/cert/run
Tag: #refactor

Change-Id: Ifc867c333aac184457c6bdecca7373c6fa48b0a1

3 years agoMerge "gd: Implement vendor specific event manager" am: 6ef21313f3 am: c06892163e...
Treehugger Robot [Wed, 12 May 2021 15:26:53 +0000 (15:26 +0000)]
Merge "gd: Implement vendor specific event manager" am: 6ef21313f3 am: c06892163e am: 277c378f0c

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1695546

Change-Id: Ib9be74a0297eed1dc3e1a1af4f7306313234ae1f

3 years agoMerge "gd: Implement vendor specific event manager" am: 6ef21313f3 am: c06892163e
Treehugger Robot [Wed, 12 May 2021 15:11:36 +0000 (15:11 +0000)]
Merge "gd: Implement vendor specific event manager" am: 6ef21313f3 am: c06892163e

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1695546

Change-Id: I4ef8edd8be1efb67110232debd4cfb0cfb4adb03

3 years agoMerge "gd: Implement vendor specific event manager" am: 6ef21313f3
Treehugger Robot [Wed, 12 May 2021 14:41:28 +0000 (14:41 +0000)]
Merge "gd: Implement vendor specific event manager" am: 6ef21313f3

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1695546

Change-Id: Ib5b2a63d7a199a94db6fd186767d2868cbc70bff

3 years agoMerge "gd: Implement vendor specific event manager"
Treehugger Robot [Wed, 12 May 2021 13:31:10 +0000 (13:31 +0000)]
Merge "gd: Implement vendor specific event manager"

3 years agogd: Implement vendor specific event manager
Chienyuan [Tue, 4 May 2021 13:54:04 +0000 (21:54 +0800)]
gd: Implement vendor specific event manager

Tag: #gd-refactor
Bug: 186234480
Test: gd/cert/run
Test: bluetooth_test_gd
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I62ce950d2944014d2e14f5b0a68933c499d4a4ac

3 years agoMerge "gd: Prevent erroneous fail connection on acceptlist change" am: aa48544e4a...
Treehugger Robot [Tue, 11 May 2021 22:26:57 +0000 (22:26 +0000)]
Merge "gd: Prevent erroneous fail connection on acceptlist change" am: aa48544e4a am: a2cf5a102c am: 168cc285c6

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1702565

Change-Id: I6f6852dc2caadbeefbde5ca6055b307f171b9ff8

3 years agoFix incorrect enum comparison of LE close reason am: d9709f256a am: b6f964e073 am...
Abhishek Pandit-Subedi [Tue, 11 May 2021 22:26:46 +0000 (22:26 +0000)]
Fix incorrect enum comparison of LE close reason am: d9709f256a am: b6f964e073 am: ed49a2caaa

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1703785

Change-Id: I1d4545afa285a43a5dfabe4d1e7ff485d0f2993e

3 years agoMerge "gd: Prevent erroneous fail connection on acceptlist change" am: aa48544e4a...
Treehugger Robot [Tue, 11 May 2021 22:05:45 +0000 (22:05 +0000)]
Merge "gd: Prevent erroneous fail connection on acceptlist change" am: aa48544e4a am: a2cf5a102c

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1702565

Change-Id: Ie76ec97bd9482ca83e139931c027c6fb16d08d21

3 years agoFix incorrect enum comparison of LE close reason am: d9709f256a am: b6f964e073
Abhishek Pandit-Subedi [Tue, 11 May 2021 22:05:32 +0000 (22:05 +0000)]
Fix incorrect enum comparison of LE close reason am: d9709f256a am: b6f964e073

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1703785

Change-Id: Ia6b929c9825e41ef8fdd2768f1cc127375e70faf

3 years agoMerge "gd: Prevent erroneous fail connection on acceptlist change" am: aa48544e4a
Treehugger Robot [Tue, 11 May 2021 21:45:20 +0000 (21:45 +0000)]
Merge "gd: Prevent erroneous fail connection on acceptlist change" am: aa48544e4a

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1702565

Change-Id: Ie9b00ef4ebb75241416406c5176e8c5fa6c379d2

3 years agoFix incorrect enum comparison of LE close reason am: d9709f256a
Abhishek Pandit-Subedi [Tue, 11 May 2021 21:44:39 +0000 (21:44 +0000)]
Fix incorrect enum comparison of LE close reason am: d9709f256a

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1703785

Change-Id: Ibb2d71d0c78b3764478d8dfa1870a92295cd4a45

3 years agoMerge "gd: Prevent erroneous fail connection on acceptlist change"
Treehugger Robot [Tue, 11 May 2021 21:28:48 +0000 (21:28 +0000)]
Merge "gd: Prevent erroneous fail connection on acceptlist change"

3 years agoMerge "Print errors if acceptlist events are too small" am: c607a04361 am: 469f9f00f4...
Treehugger Robot [Tue, 11 May 2021 21:20:02 +0000 (21:20 +0000)]
Merge "Print errors if acceptlist events are too small" am: c607a04361 am: 469f9f00f4 am: b5a4c7b368

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1702425

Change-Id: Ic5e7e3540f6231b9252002ea3d13ea78d832118c

3 years agoMerge "Print errors if acceptlist events are too small" am: c607a04361 am: 469f9f00f4
Treehugger Robot [Tue, 11 May 2021 21:02:36 +0000 (21:02 +0000)]
Merge "Print errors if acceptlist events are too small" am: c607a04361 am: 469f9f00f4

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1702425

Change-Id: I253140b0ece83ee10d879c2b7f45f0ca2f79d8c3

3 years agoMerge "Print errors if acceptlist events are too small" am: c607a04361
Treehugger Robot [Tue, 11 May 2021 20:32:16 +0000 (20:32 +0000)]
Merge "Print errors if acceptlist events are too small" am: c607a04361

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1702425

Change-Id: I637e7763d68496ea0af60aa7aa952931dec74ed1

3 years agoAdd missing dependency on proto_logging am: 1a7b868996 am: b71684906b am: 6de8656e13
Abhishek Pandit-Subedi [Tue, 11 May 2021 20:05:48 +0000 (20:05 +0000)]
Add missing dependency on proto_logging am: 1a7b868996 am: b71684906b am: 6de8656e13

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1703505

Change-Id: I7fdd912465f8a30f73b5b07ef569e43c353ff6fa

3 years agoIntroduce stack_gatt_test am: ab6a940be3 am: fe49762695 am: 7ccb16ccf8
Chris Manton [Tue, 11 May 2021 20:05:45 +0000 (20:05 +0000)]
Introduce stack_gatt_test am: ab6a940be3 am: fe49762695 am: 7ccb16ccf8

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698932

Change-Id: I4e0bfd6cb616f2f01d93c8cdc9ae9a9d30810f6d

3 years agoAdd crypto toolbox mocks am: 8673f2d243 am: c594d999a0 am: 18a1a4aa04
Chris Manton [Tue, 11 May 2021 20:05:43 +0000 (20:05 +0000)]
Add crypto toolbox mocks am: 8673f2d243 am: c594d999a0 am: 18a1a4aa04

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698931

Change-Id: I879102e80016cfac73cd95946666730e9c6fc489

3 years agoFix incorrect enum comparison of LE close reason
Abhishek Pandit-Subedi [Tue, 11 May 2021 17:20:36 +0000 (17:20 +0000)]
Fix incorrect enum comparison of LE close reason

The LE close reason is tGATT_DISCONN_REASON but it's compared against
tHCI_ERROR_CODE. Besides just being different types, they are also
backed by different primitives (u16 for gatt vs u8 for hci). This fails
in stricter build environments (i.e. ChromeOS).

Bug: 187836537
Tag: #floss
Test: atest --host bluetooth_test_gd
Change-Id: I0f926b6fad9f20adde5e1e7ff89bcc7c8da01f93

3 years agoPoint stack_btm_test to use common test/mocks am: 27c8011064 am: df22462621 am: 1cfea...
Chris Manton [Tue, 11 May 2021 20:05:28 +0000 (20:05 +0000)]
Point stack_btm_test to use common test/mocks am: 27c8011064 am: df22462621 am: 1cfea26300

Original change: https://android-review.googlesource.com/c/platform/system/bt/+/1698145

Change-Id: I2caaf99f894cc37a1f70f7ba79dfe76621f64d58