OSDN Git Service
Magnus Hagander [Mon, 19 Jan 2009 15:34:23 +0000 (15:34 +0000)]
Use the new text domain names ("postgres-8.4" instead of "postgres")
Hiroshi Inoue
Peter Eisentraut [Mon, 19 Jan 2009 14:24:13 +0000 (14:24 +0000)]
Avoid regression test cases that fail in locales that sort "v" and "w"
equally (in glibc: et_EE, sv_SE, tk_TM). It turns out that this was
already taken care of previously by select_1.out, which I had forgotten to
update for an unrelated change. But might as well avoid the issue
altogether.
Peter Eisentraut [Mon, 19 Jan 2009 13:38:47 +0000 (13:38 +0000)]
Alter regression test cases that rely on the sort order of "aa". Some
locales (da_DK, fo_FO, kl_GL, nb_NO, nn_NO in glibc) sort "aa" after "z".
Peter Eisentraut [Mon, 19 Jan 2009 12:02:29 +0000 (12:02 +0000)]
Alter the regression test cases that rely on the sort order of "ch" between
"cg" and "ci". This eliminates a test failure on the following glibc
locales: br_FR, cs_CZ, cy_GB, es_EC, es_US, hsb_DE, ig_NG, ik_CA, sk_SK.
Peter Eisentraut [Mon, 19 Jan 2009 08:59:13 +0000 (08:59 +0000)]
Message wordsmithing
Tom Lane [Sun, 18 Jan 2009 20:44:45 +0000 (20:44 +0000)]
Fix a pg_dump output ordering problem introduced in 8.3 by the addition of
array types for composite types. Although pg_dump understood it wasn't
supposed to dump these array types as separate objects, it must include
them in the dependency ordering analysis, and it was improperly assigning them
the same relatively-high sort priority as regular types. This resulted in
effectively moving composite types and tables up to that same high priority,
which broke any ordering requirements that weren't explicitly enforced by
dependencies. In particular user-defined operator classes, which should come
out before tables, failed to do so. Per report from Brendan Jurd.
In passing, also fix an ill-considered decision to give text search objects
the same sort priority as functions and operators --- the sort result looks
a lot nicer if different object types are kept separate. The recent
foreign-data patch had copied that decision, making the sort ordering even
messier :-(
Neil Conway [Sat, 17 Jan 2009 04:29:00 +0000 (04:29 +0000)]
Fix an ungrammatical statement.
Neil Conway [Sat, 17 Jan 2009 04:24:41 +0000 (04:24 +0000)]
Fix typo.
Peter Eisentraut [Fri, 16 Jan 2009 20:29:48 +0000 (20:29 +0000)]
Manual attempt to update this file.
Peter Eisentraut [Fri, 16 Jan 2009 20:21:46 +0000 (20:21 +0000)]
plpython_error.out is for Python 2.4, plpython_error_3.out is for Python 2.5,
as it was previously.
Heikki Linnakangas [Fri, 16 Jan 2009 13:27:24 +0000 (13:27 +0000)]
Add vacuum_freeze_table_age GUC option, to control when VACUUM should
ignore the visibility map and scan the whole table, to advance
relfrozenxid.
Peter Eisentraut [Fri, 16 Jan 2009 09:15:03 +0000 (09:15 +0000)]
Wordsmithing
Peter Eisentraut [Thu, 15 Jan 2009 22:33:19 +0000 (22:33 +0000)]
Remove period from primary error message.
Heikki Linnakangas [Thu, 15 Jan 2009 18:19:58 +0000 (18:19 +0000)]
Change explanation of pg_switch_xlog()'s return value to match code.
Teodor Sigaev [Thu, 15 Jan 2009 16:33:59 +0000 (16:33 +0000)]
Fix URL generation in headline. Only tag lexeme will be replaced by space.
Per http://archives.postgresql.org/pgsql-bugs/2008-12/msg00013.php
Teodor Sigaev [Thu, 15 Jan 2009 16:33:28 +0000 (16:33 +0000)]
Fix generation too long headline with ShortWords.
Per http://archives.postgresql.org/pgsql-hackers/2008-09/msg01088.php
Peter Eisentraut [Thu, 15 Jan 2009 13:49:57 +0000 (13:49 +0000)]
Cleanup pass over PL/Python NLS. Add translation support to PLy_elog and
PLy_exception_set, and clarify some error messages.
Peter Eisentraut [Thu, 15 Jan 2009 12:59:11 +0000 (12:59 +0000)]
Remove unneeded GETTEXT_TRIGGERS.
Peter Eisentraut [Thu, 15 Jan 2009 11:52:55 +0000 (11:52 +0000)]
NLS cleanup in ecpglib
Replace leftover instances of _() by ecpg_gettext(), the latter being the
correct way to refer to the library's message catalog, instead of the one of
the program using the library.
Drop NLS support for ecpg_log(), which is a debugging instrument similar to
elog() in the backend.
We cannot support NLS in the ecpg compatlib, because that requires
ecpg_gettext, which is in ecpglib, which is not a dependency of compatlib. It
doesn't seem worthwhile to worry about this, since the only translatable
string is "out of memory", and gettext probably won't be able to do much
without memory either.
Adjust messages to project style.
Peter Eisentraut [Thu, 15 Jan 2009 09:30:20 +0000 (09:30 +0000)]
Build needed things in src/test/regress/ first. And some build rules
normalization.
Peter Eisentraut [Thu, 15 Jan 2009 09:01:24 +0000 (09:01 +0000)]
Make .pot files depend on the makefiles, so that they are updated when the
file or trigger function lists are changed.
Bruce Momjian [Thu, 15 Jan 2009 01:53:49 +0000 (01:53 +0000)]
Modify distdir rule to skip .git directory.
Bruce Momjian [Thu, 15 Jan 2009 00:34:25 +0000 (00:34 +0000)]
Add documentation mention that full page writes have to be enabled for
full pages to be restored during recovery.
Per private report from Michael Renner
Bruce Momjian [Wed, 14 Jan 2009 21:59:19 +0000 (21:59 +0000)]
Make 'find' syntax consistent; add .git exclusion to make_ctags.
Peter Eisentraut [Wed, 14 Jan 2009 21:28:32 +0000 (21:28 +0000)]
Avoid version-control system directories when creating TAGS. Besides
being wasteful, this can collide with repostory metadata on case-insensitive
file sytems.
Bruce Momjian [Wed, 14 Jan 2009 21:18:30 +0000 (21:18 +0000)]
Remove empty #ifdef block.
Peter Eisentraut [Wed, 14 Jan 2009 21:12:09 +0000 (21:12 +0000)]
Make the columns is_insertable_into and is_updatable behave uniformly
correctly. They are supposed to examine which kinds of rules are present,
which they did in some of the info schema views but not in others.
Peter Eisentraut [Wed, 14 Jan 2009 20:01:52 +0000 (20:01 +0000)]
Make error messages match backend style.
Bruce Momjian [Wed, 14 Jan 2009 18:10:21 +0000 (18:10 +0000)]
Check nsl library for gethostbyname_r() on all platforms (HP-UX uses it
too).
Bruce Momjian [Wed, 14 Jan 2009 16:39:58 +0000 (16:39 +0000)]
Renable threading build for Solaris 2.5, per report from Andrew Chernow
Peter Eisentraut [Wed, 14 Jan 2009 14:54:35 +0000 (14:54 +0000)]
misc.o depends on pg_config_paths.h when --enable-nls is used.
Heikki Linnakangas [Wed, 14 Jan 2009 09:53:51 +0000 (09:53 +0000)]
Remove broken Assertions that failed if a statement executed in PL/pgSQL is
rewritten into another kind of statement, for example if an INSERT is
rewritten into an UPDATE.
Back-patch to 8.3 and 8.2. For HEAD, Tom suggested inventing a new
SPI_OK_REWRITTEN return code, but that's not a backportable solution. I'll
do that as a separate patch, this patch will do as a stopgap measure for HEAD
too in the meanwhile.
Peter Eisentraut [Tue, 13 Jan 2009 19:32:29 +0000 (19:32 +0000)]
Remove useless (and insecure) temp file handling.
Magnus Hagander [Tue, 13 Jan 2009 11:44:56 +0000 (11:44 +0000)]
Throw an error when using -C and -1 at the same time in pg_restore.
It's not possible to do CREATE DATABASE inside a transaction, so previously
we just got a server error instead.
Backpatch to 8.2, which is where the -1 feature appeared.
Magnus Hagander [Tue, 13 Jan 2009 10:43:21 +0000 (10:43 +0000)]
Remove special-handling of usernames with Kerberos authentication. We will
now always use the system username as the default, and not try to pick it up
from the kerberos ticket.
This fixes the spurious error messages that show up on kerberos-enabled builds
when not actually using kerberos, and puts it in line with how other authentication
methods work.
Bruce Momjian [Tue, 13 Jan 2009 00:54:11 +0000 (00:54 +0000)]
Document how pglesslog can be used to reduce the storage requirements of PITR.
Alvaro Herrera [Mon, 12 Jan 2009 21:02:15 +0000 (21:02 +0000)]
Simplify the writing of amoptions routines by introducing a convenience
fillRelOptions routine that stores the parsed values in the struct using a
table-based approach. Per Tom suggestion. Also remove the "continue"
in HANDLE_*_RELOPTION macros, which were useless and in spirit they were
assuming too much of how the macros were going to be used. (Note that these
macros are now unused, but the intention is to introduce some usage in a
future autovacuum patch, which is why they weren't completely removed.)
Also, do not call the string validation routine when not validating. It seems
less error-prone this way, per commentary on the amoptions SGML docs.
Tom Lane [Mon, 12 Jan 2009 16:00:41 +0000 (16:00 +0000)]
Tweak order of operations in BitmapHeapNext() to avoid the case of prefetching
the same page we are nanoseconds away from reading for real. There should be
something left to do on the current page before we consider issuing a prefetch.
Peter Eisentraut [Mon, 12 Jan 2009 14:06:20 +0000 (14:06 +0000)]
Add some minimal documentation that the SQL standard requires parentheses
after ONLY.
Peter Eisentraut [Mon, 12 Jan 2009 09:38:30 +0000 (09:38 +0000)]
Use qualified_name instead of relation_expr for commands that have no
business with inheritance recursion: ALTER INDEX, ALTER SEQUENCE, ALTER
TRIGGER, ALTER VIEW. They would just silently ignore the ONLY.
ALTER TABLE has mixed behavior and cannot be dealt with this way because
of the resulting shift/reduce conflicts.
Peter Eisentraut [Mon, 12 Jan 2009 08:54:27 +0000 (08:54 +0000)]
Add ONLY support to LOCK and TRUNCATE. By default, these commands are now
recursive.
=> Note this incompatibility in the release notes.
Tom Lane [Mon, 12 Jan 2009 05:10:45 +0000 (05:10 +0000)]
Implement prefetching via posix_fadvise() for bitmap index scans. A new
GUC variable effective_io_concurrency controls how many concurrent block
prefetch requests will be issued.
(The best way to handle this for plain index scans is still under debate,
so that part is not applied yet --- tgl)
Greg Stark
Tom Lane [Sun, 11 Jan 2009 18:02:17 +0000 (18:02 +0000)]
Re-enable the old code in xlog.c that tried to use posix_fadvise(), so that
we can get some buildfarm feedback about whether that function is still
problematic. (Note that the planned async-preread patch will not really
prove anything one way or the other in buildfarm testing, since it will
be inactive with default GUC settings.)
Peter Eisentraut [Sun, 11 Jan 2009 09:41:45 +0000 (09:41 +0000)]
Make tests pass with or without locale.
Tom Lane [Sat, 10 Jan 2009 21:08:36 +0000 (21:08 +0000)]
Revise the TIDBitmap API to support multiple concurrent iterations over a
bitmap. This is extracted from Greg Stark's posix_fadvise patch; it seems
worth committing separately, since it's potentially useful independently of
posix_fadvise.
Bruce Momjian [Sat, 10 Jan 2009 20:14:30 +0000 (20:14 +0000)]
Modify libpq environment variable documentation to point to the relevant
connection options documentation section, per idea from Magnus.
Bruce Momjian [Sat, 10 Jan 2009 16:58:39 +0000 (16:58 +0000)]
Update link guidelines.
Bruce Momjian [Sat, 10 Jan 2009 16:03:15 +0000 (16:03 +0000)]
Add guidelines section.
Bruce Momjian [Sat, 10 Jan 2009 04:40:08 +0000 (04:40 +0000)]
Add file to explain SGML linking options, for use by SGML document
writers.
Tom Lane [Fri, 9 Jan 2009 19:27:14 +0000 (19:27 +0000)]
A further attempt at clarifying the \distv business.
Tom Lane [Fri, 9 Jan 2009 18:50:03 +0000 (18:50 +0000)]
Fix libpq so that it reports PGRES_EMPTY_QUERY not PGRES_COMMAND_OK when an
empty query string is passed to PQexecParams and related functions. Its
handling of the NoData response to Describe messages was subtly incorrect.
Per my report of yesterday.
Although I consider this a bug, it's a behavioral change that might affect
applications, so not back-patched.
In passing fix a second issue in the same code: it didn't react well to an
out-of-memory failure while trying to make the PGresult object.
Tom Lane [Fri, 9 Jan 2009 15:46:11 +0000 (15:46 +0000)]
Arrange for function default arguments to be processed properly in expressions
that are set up for execution with ExecPrepareExpr rather than going through
the full planner process. By introducing an explicit notion of "expression
planning", this patch also lays a bit of groundwork for maybe someday
allowing sub-selects in standalone expressions.
Bruce Momjian [Fri, 9 Jan 2009 15:02:22 +0000 (15:02 +0000)]
Remove tabs from SGML docs.
Peter Eisentraut [Fri, 9 Jan 2009 14:50:00 +0000 (14:50 +0000)]
Remove fairly useless mixed-case identifier test that causes locale
dependencies.
Magnus Hagander [Fri, 9 Jan 2009 14:07:00 +0000 (14:07 +0000)]
Code review of strftime patch, per comments from Tom:
* Use correct buffer size MAX_L10N_DATA
* Use strlcpy instead of StrNCpy
Peter Eisentraut [Fri, 9 Jan 2009 13:37:18 +0000 (13:37 +0000)]
Change chapter titles thus:
III. Server Administration
15. Installation from Source Code
16. Installation from Source Code on Windows
17. Server Setup and Operation
to give users of binary installations a better idea where to start reading.
suggested by Nikolay Samokhvalov
Magnus Hagander [Fri, 9 Jan 2009 13:03:55 +0000 (13:03 +0000)]
Fix strftime usage on Win32 when trying to fetch the locale-aware
parts of a time string so it properly handles different encodings.
Original patch by Hiroshi Saito, heavily reworked by me and
ITAGAKI Takahiro.
Peter Eisentraut [Fri, 9 Jan 2009 12:37:37 +0000 (12:37 +0000)]
More portable use of "find".
Peter Eisentraut [Fri, 9 Jan 2009 10:54:08 +0000 (10:54 +0000)]
Rewrite update-po target, so that it works less like a shell script and more
like a makefile with real dependencies.
Instead of overwriting the old po file, write the new one to .po.new. This is
less annoying and integrates better with the NLS web site.
Also, we can now merge languages that don't have a po file yet, by merging
against all other po files of that language, to pick up recurring translations
automatically. This previously only worked when a po file already existed.
Magnus Hagander [Fri, 9 Jan 2009 10:13:19 +0000 (10:13 +0000)]
Make krb_realm and krb_server_hostname be pg_hba options only, and remove
their GUCs.
In passing, noted that the pg_hba options for krb5 authentication weren't
listed at all - so add this.
Andrew Dunstan [Fri, 9 Jan 2009 01:53:10 +0000 (01:53 +0000)]
Document values for pg_constraint confupdtype, confdeltype and confmatchtype columns.
Bruce Momjian [Fri, 9 Jan 2009 01:47:02 +0000 (01:47 +0000)]
Update release notes for 8.3.5, 8.2.11, and 8.1.15 to mention the need
to reindex GiST indexes:
If you were running a previous 8.X.X release, REINDEX all GiST
indexes after the upgrade.
Bruce Momjian [Thu, 8 Jan 2009 20:09:06 +0000 (20:09 +0000)]
Fix memory leak for file name if expect file name contains a dot, per
report from dvice_null@yahoo.com.
Alvaro Herrera [Thu, 8 Jan 2009 19:34:41 +0000 (19:34 +0000)]
A couple further reloptions improvements, per KaiGai Kohei: add a validation
function to the string type and add a couple of macros for string handling.
In passing, fix an off-by-one bug of mine.
Bruce Momjian [Thu, 8 Jan 2009 14:46:50 +0000 (14:46 +0000)]
Document that txid_visible_in_snapshot() cannot be used with
subtransaction ids.
Tom Lane [Thu, 8 Jan 2009 13:42:33 +0000 (13:42 +0000)]
Defend against null input in analyze_requires_snapshot(), per report
from Rushabh Lathia.
Peter Eisentraut [Thu, 8 Jan 2009 12:47:58 +0000 (12:47 +0000)]
Add note that not all SQL commands support ONLY in the same way.
Bruce Momjian [Thu, 8 Jan 2009 00:44:18 +0000 (00:44 +0000)]
Document current_query() as being the _client_ query.
Bruce Momjian [Thu, 8 Jan 2009 00:13:22 +0000 (00:13 +0000)]
Revert current_query() change to use debug_query_string again; add comment.
Bruce Momjian [Wed, 7 Jan 2009 22:54:45 +0000 (22:54 +0000)]
Add comment about why BETWEEN uses operator strings and not opclasses,
with URL pointing to email discussion.
Tom Lane [Wed, 7 Jan 2009 22:40:49 +0000 (22:40 +0000)]
Create a third option named "partition" for constraint_exclusion, and make it
the default. This setting enables constraint exclusion checks only for
appendrel members (ie, inheritance children and UNION ALL arms), which are
the cases in which constraint exclusion is most likely to be useful. Avoiding
the overhead for simple queries that are unlikely to benefit should bring
the cost down to the point where this is a reasonable default setting.
Per today's discussion.
Bruce Momjian [Wed, 7 Jan 2009 21:48:15 +0000 (21:48 +0000)]
Have current_query() use ActivePortal->sourceText rather than
debug_query_string; this allows current_query() to be more accurate;
docs updated; per idea from Tom
Tom Lane [Wed, 7 Jan 2009 20:38:56 +0000 (20:38 +0000)]
Insert conditional SPI_push/SPI_pop calls into InputFunctionCall,
OutputFunctionCall, and friends. This allows SPI-using functions to invoke
datatype I/O without concern for the possibility that a SPI-using function
will be called (which could be either the I/O function itself, or a function
used in a domain check constraint). It's a tad ugly, but not nearly as ugly
as what'd be needed to make this work via retail insertion of push/pop
operations in all the PLs.
This reverts my patch of 2007-01-30 that inserted some retail SPI_push/pop
calls into plpgsql; that approach only fixed plpgsql, and not any other PLs.
But the other PLs have the issue too, as illustrated by a recent gripe from
Christian Schröder.
Back-patch to 8.2, which is as far back as this solution will work. It's
also as far back as we need to worry about the domain-constraint case, since
earlier versions did not attempt to check domain constraints within datatype
input. I'm not aware of any old I/O functions that use SPI themselves, so
this should be sufficient for a back-patch.
Bruce Momjian [Wed, 7 Jan 2009 19:51:21 +0000 (19:51 +0000)]
Add comment that it is difficult to access the more accurate
'query_string' from current_query().
Bruce Momjian [Wed, 7 Jan 2009 19:35:43 +0000 (19:35 +0000)]
Update comment associated with 'debug_query_string'.
Andrew Dunstan [Wed, 7 Jan 2009 13:51:04 +0000 (13:51 +0000)]
define HAVE_FSEEKO for MSVC
Tom Lane [Wed, 7 Jan 2009 13:44:37 +0000 (13:44 +0000)]
Fix executor/spi.h to follow our usual conventions for include files, ie,
not include postgres.h nor anything else it doesn't directly need. Add
#includes to calling files as needed to compensate. Per my proposal of
yesterday.
This should be noted as a source code change in the 8.4 release notes,
since it's likely to require changes in add-on modules.
Magnus Hagander [Wed, 7 Jan 2009 13:09:21 +0000 (13:09 +0000)]
Add hba parameter include_realm to krb5, gss and sspi authentication, used
to pass the full username@realm string to the authentication instead of
just the username. This makes it possible to use pg_ident.conf to authenticate
users from multiple realms as different database users.
Magnus Hagander [Wed, 7 Jan 2009 12:38:11 +0000 (12:38 +0000)]
Allow krb_realm (krb5, gssapi and sspi) and krb_server_hostname (krb5 only)
authentication options to be set in pg_hba.conf on a per-line basis, to
override the defaults set in postgresql.conf.
Magnus Hagander [Wed, 7 Jan 2009 12:21:47 +0000 (12:21 +0000)]
Add appropriate text for SIGHUP parameters instead of just removing it
like previous patch did.
Per note from Tom Lane
Magnus Hagander [Wed, 7 Jan 2009 12:02:46 +0000 (12:02 +0000)]
Don't require pqGetHomeDirectory to succeed if the user has specified
hardcoded paths for SSL rootcert/crl/clientcert/key.
As noted by Andrew Chernow
Peter Eisentraut [Wed, 7 Jan 2009 10:38:44 +0000 (10:38 +0000)]
Produce a full version string for Sun Studio.
from Zdenek
Bruce Momjian [Wed, 7 Jan 2009 04:51:34 +0000 (04:51 +0000)]
Break out \distv into four separate lines in the psql documentation, for
clarity.
Bruce Momjian [Wed, 7 Jan 2009 04:26:46 +0000 (04:26 +0000)]
Make the log output of 'vxid' between csvlog and stderr/syslog
consistent. Currently, in csvlog, vxid of an auxiliary process isn't
displayed. On the other hand, in stderr/syslog, invalid vxid (-1/0) of
that is displayed.
Fujii Masao
Bruce Momjian [Wed, 7 Jan 2009 03:39:33 +0000 (03:39 +0000)]
Update MinGW so it handles fseeko() similar to Unix.
Bruce Momjian [Wed, 7 Jan 2009 03:05:26 +0000 (03:05 +0000)]
Removeduplicate \dd psql help mention.
Bruce Momjian [Wed, 7 Jan 2009 00:05:28 +0000 (00:05 +0000)]
Add spaces around psql \d* columns, per idea from Joshua Drake.
Tom Lane [Tue, 6 Jan 2009 23:46:06 +0000 (23:46 +0000)]
Clarify a confusing comment about MCVs vs histogram entries.
Per Nathan Boley.
Bruce Momjian [Tue, 6 Jan 2009 23:09:56 +0000 (23:09 +0000)]
Improve \z psql \? help display.
Bruce Momjian [Tue, 6 Jan 2009 23:01:57 +0000 (23:01 +0000)]
Add documentation for new \d*S* patch, and clean up some of the docs.
Fix \do and trigger display for the patch too.
Bruce Momjian [Tue, 6 Jan 2009 21:10:30 +0000 (21:10 +0000)]
This makes all the \dX commands (most importantly to most: \df) work
like \dt does, in that it requires a \dXS to see system items.
Greg Sabino Mullane
Bruce Momjian [Tue, 6 Jan 2009 19:42:57 +0000 (19:42 +0000)]
Document that Cygwin does not support OpenSSL.
Magnus Hagander [Tue, 6 Jan 2009 18:37:50 +0000 (18:37 +0000)]
Make the MSVC build output "32-bit" at the end of the version string, the
same way the unix build now does.
Bruce Momjian [Tue, 6 Jan 2009 18:01:57 +0000 (18:01 +0000)]
Make pg_dump and pg_dumpall --clean options match the SGML docs, for consistency.
Tom Lane [Tue, 6 Jan 2009 17:27:06 +0000 (17:27 +0000)]
Remove references to pgsql-ports and pgsql-patches mailing lists from
various documentation, since those lists are now dead/deprecated.
Point to pgsql-bugs and/or pgsql-hackers as appropriate.
Bruce Momjian [Tue, 6 Jan 2009 17:18:11 +0000 (17:18 +0000)]
Update pg_restore --help text to match the SGML documentation.
Tom Lane [Tue, 6 Jan 2009 16:39:52 +0000 (16:39 +0000)]
Change a couple of ill-advised uses of INFO elog level to WARNINGs; in
particular this allows EmitWarningsOnPlaceholders messages to show up in the
postmaster log by default. Update elog.h comment to make it clearer what INFO
is for, and fix one example in the SGML docs that was misusing it. Per my
gripe of yesterday.
Tom Lane [Tue, 6 Jan 2009 15:51:38 +0000 (15:51 +0000)]
Revert the default toast compression strategy to the former behavior
where there's no limit on the size of datum we'll try to compress.
Other 8.4 tweaks to the behavior remain in place. Per discussion.
Tom Lane [Tue, 6 Jan 2009 15:38:44 +0000 (15:38 +0000)]
Doesn't seem like a good idea to be doing AC_CHECK_SIZEOF(void *) so much
earlier than all the other sizeof checks, and it certainly fails to follow
the order suggested at the file head. Rearrange.
Heikki Linnakangas [Tue, 6 Jan 2009 14:55:37 +0000 (14:55 +0000)]
Fix logic in lazy vacuum to decide if it's worth trying to truncate the heap.
If the table was smaller than REL_TRUNCATE_FRACTION (= 16) pages, we always
tried to acquire AccessExclusiveLock on it even if there was no empty pages
at the end.
Report by Simon Riggs. Back-patch all the way to 7.4.