OSDN Git Service
Tom Lane [Sat, 23 Jul 2005 21:05:48 +0000 (21:05 +0000)]
Simple constraint exclusion. For now, only child tables of inheritance
scans are candidates for exclusion; this should be fixed eventually.
Simon Riggs, with some help from Tom Lane.
Bruce Momjian [Sat, 23 Jul 2005 15:31:16 +0000 (15:31 +0000)]
Remove unintended code addition.
Bruce Momjian [Sat, 23 Jul 2005 15:29:47 +0000 (15:29 +0000)]
Macro alignment cleanup.
Bruce Momjian [Sat, 23 Jul 2005 14:53:21 +0000 (14:53 +0000)]
Improve computations of interval_div to prevent rounding problem on AIX.
Bruce Momjian [Sat, 23 Jul 2005 14:25:34 +0000 (14:25 +0000)]
Andrew pointed out that the current fix didn't handle dates that were
near daylight savings time boudaries. This handles it properly, e.g.
test=> select '2005-04-03 04:00:00'::timestamp at time zone
'America/Los_Angeles';
timezone
------------------------
2005-04-03 07:00:00-04
(1 row)
Tom Lane [Sat, 23 Jul 2005 14:18:57 +0000 (14:18 +0000)]
In the stats test, delay for the stats collector to catch up using a
function that actually sleeps, instead of busy-waiting. Perhaps this
will resolve some of the intermittent stats failures we keep seeing.
Bruce Momjian [Sat, 23 Jul 2005 02:02:27 +0000 (02:02 +0000)]
Fix AT TIME ZONE for timestamps without time zones:
test=> select (CURRENT_DATE + '05:00'::time)::timestamp at time zone
'Canada/Pacific';
timezone
------------------------
2005-07-22 08:00:00-04
(1 row)
Bruce Momjian [Fri, 22 Jul 2005 21:16:15 +0000 (21:16 +0000)]
Fix AT TIME ZONE for timestamps without time zones:
test=> select ('2005-07-20 00:00:00'::timestamp without time zone) at
time zone 'Europe/Paris';
timezone
------------------------
2005-07-19 22:00:00-04
Udpate documentation.
Tom Lane [Fri, 22 Jul 2005 19:55:50 +0000 (19:55 +0000)]
Fix insufficient check for overflow in tm2abstime(), per report from jw.
Tom Lane [Fri, 22 Jul 2005 19:12:02 +0000 (19:12 +0000)]
Fix compare_fuzzy_path_costs() to behave a bit more sanely. The original
coding would ignore startup cost differences of less than 1% of the
estimated total cost; which was OK for normal planning but highly not OK
if a very small LIMIT was applied afterwards, so that startup cost becomes
the name of the game. Instead, compare startup and total costs fuzzily
but independently. This changes the plan selected for two queries in the
regression tests; adjust expected-output files for resulting changes in
row order. Per reports from Dawid Kuroczko and Sam Mason.
Bruce Momjian [Fri, 22 Jul 2005 19:00:55 +0000 (19:00 +0000)]
More removal of unneeded parentheses.
Bruce Momjian [Fri, 22 Jul 2005 15:15:38 +0000 (15:15 +0000)]
More spacing adjustments
Bruce Momjian [Fri, 22 Jul 2005 05:08:26 +0000 (05:08 +0000)]
Update date/time comments.
Bruce Momjian [Fri, 22 Jul 2005 05:03:09 +0000 (05:03 +0000)]
More minor spacing improvements.
Bruce Momjian [Fri, 22 Jul 2005 03:46:34 +0000 (03:46 +0000)]
Code spacing improvement, particularly *tm spacing.
Bruce Momjian [Thu, 21 Jul 2005 20:37:21 +0000 (20:37 +0000)]
More comment update of time macros.
Bruce Momjian [Thu, 21 Jul 2005 18:06:13 +0000 (18:06 +0000)]
Update DAYS_PER_MONTH comment.
Add SECS_PER_YEAR and MINS_PER_HOUR macros.
Bruce Momjian [Thu, 21 Jul 2005 15:16:30 +0000 (15:16 +0000)]
Add comment about void* use in MemSet.
Bruce Momjian [Thu, 21 Jul 2005 13:43:16 +0000 (13:43 +0000)]
Add:
<
> * Research storing disk pages with no alignment/padding
Bruce Momjian [Thu, 21 Jul 2005 05:18:26 +0000 (05:18 +0000)]
Fix integer timestamp build for macro changes.
Bruce Momjian [Thu, 21 Jul 2005 04:48:42 +0000 (04:48 +0000)]
Add comment marking non-exact time conversion macros.
Bruce Momjian [Thu, 21 Jul 2005 04:41:43 +0000 (04:41 +0000)]
Remove unnecessary parentheses in assignments.
Add spaces where needed.
Reference time interval variables as tinterval.
Tom Lane [Thu, 21 Jul 2005 04:15:04 +0000 (04:15 +0000)]
Fix storage size for btree_gist interval indexes. Fix penalty
calculations for interval and time/timetz to behave sanely for both
integer and float timestamps; up to now I think it's been doing
something pretty strange...
Bruce Momjian [Thu, 21 Jul 2005 03:56:25 +0000 (03:56 +0000)]
Add time/date macros for code clarity:
#define DAYS_PER_YEAR 365.25
#define MONTHS_PER_YEAR 12
#define DAYS_PER_MONTH 30
#define HOURS_PER_DAY 24
Tom Lane [Wed, 20 Jul 2005 23:57:46 +0000 (23:57 +0000)]
Fix breakage of INSTALL document build.
Bruce Momjian [Wed, 20 Jul 2005 18:17:39 +0000 (18:17 +0000)]
/contrib/btree_gist adjustments for new 'day' interval value.
Bruce Momjian [Wed, 20 Jul 2005 17:24:39 +0000 (17:24 +0000)]
Update catalog version for INTERVAL day addition.
Bruce Momjian [Wed, 20 Jul 2005 16:42:32 +0000 (16:42 +0000)]
Add 'day' field to INTERVAL so 1 day interval can be distinguished from
24 hours. This is very helpful for daylight savings time:
select '2005-05-03 00:00:00 EST'::timestamp with time zone + '24 hours';
?column?
----------------------
2005-05-04 01:00:00-04
select '2005-05-03 00:00:00 EST'::timestamp with time zone + '1 day';
?column?
----------------------
2005-05-04 01:00:00-04
Michael Glaesemann
Bruce Momjian [Wed, 20 Jul 2005 03:50:24 +0000 (03:50 +0000)]
Fix interval division and multiplication, before:
test=> select '4 months'::interval / 5;
?column?
---------------
1 mon -6 days
(1 row)
after:
test=> select '4 months'::interval / 5;
?column?
----------
24 days
(1 row)
The problem was the use of rint() to round, and then find the remainder,
causing the negative values.
Neil Conway [Tue, 19 Jul 2005 01:27:59 +0000 (01:27 +0000)]
Documentation tweak: make <command>CREATE OPERATOR CLASS</command> into
an <xref/>.
Tom Lane [Mon, 18 Jul 2005 22:34:14 +0000 (22:34 +0000)]
Fix some bogosities in geometric-function documentation: add an entry
for circle(polygon), which was missing; remove bogus entry for
point(lseg, lseg), which does not exist, and the documentation seemed to
describe lseg_interpt, which we already document as an operator not a
function. Also remove entry for box_intersect, which likewise is
preferentially used via the operator #.
Bruce Momjian [Mon, 18 Jul 2005 20:57:53 +0000 (20:57 +0000)]
\pset numericsep -> numericlocale.
Bruce Momjian [Mon, 18 Jul 2005 19:27:37 +0000 (19:27 +0000)]
Fix len so decimal length is only added when a period appears in the output.
Tom Lane [Mon, 18 Jul 2005 19:12:09 +0000 (19:12 +0000)]
Avoid use of E'', and thereby creating an unnecessary version-dependency,
by using LIKE...ESCAPE instead. Per suggestion by andrew@supernews.
Tom Lane [Mon, 18 Jul 2005 19:09:09 +0000 (19:09 +0000)]
Avoid need for E'' construct by using regexp instead of LIKE. More
readable, and more like the other places in this file.
Bruce Momjian [Mon, 18 Jul 2005 18:58:45 +0000 (18:58 +0000)]
Fix numiericsep length computations.
Eugen Nedelcu
Tom Lane [Mon, 18 Jul 2005 17:40:14 +0000 (17:40 +0000)]
Adjust psql describe queries so that any pg_foo_is_visible() condition
is applied last, after other constraints such as name patterns. This
is useful first because the pg_foo_is_visible() functions are relatively
expensive, and second because it minimizes the prospects for race
conditions. The change is fragile though since it makes unwarranted
assumptions about planner behavior, ie, that WHERE clauses will be
executed in the original order if there's not reason to change it.
This should fix ... or at least hide ... an intermittent failure in the
prepared_xacts regression test, while we think about what else to do.
Tom Lane [Mon, 18 Jul 2005 17:17:12 +0000 (17:17 +0000)]
pgcrypto documentation update. Marko Kreen
Tom Lane [Mon, 18 Jul 2005 17:12:54 +0000 (17:12 +0000)]
Fortuna fixes. Marko Kreen
Tom Lane [Mon, 18 Jul 2005 17:09:01 +0000 (17:09 +0000)]
Small cleanups for pgcrypto. Marko Kreen
Tom Lane [Mon, 18 Jul 2005 16:35:06 +0000 (16:35 +0000)]
Fix C++-style comments, per Rocco Altier.
Tom Lane [Mon, 18 Jul 2005 15:53:28 +0000 (15:53 +0000)]
MemSet() must not cast its pointer argument to int32* until after it has
checked that the pointer is actually word-aligned. Casting a non-aligned
pointer to int32* is technically illegal per the C spec, and some recent
versions of gcc actually generate bad code for the memset() when given
such a pointer. Per report from Andrew Morrow.
Tom Lane [Sun, 17 Jul 2005 18:28:45 +0000 (18:28 +0000)]
Make pg_regress accept a command-line option for the temporary installation's
port number, and use a default value for it that is dependent on the
configuration-time DEF_PGPORT. Should make the world safe for running
parallel 'make check' in different branches. Back-patch as far as 7.4
so that this actually is useful.
Tom Lane [Fri, 15 Jul 2005 22:02:51 +0000 (22:02 +0000)]
Fix create_unique_plan() so it doesn't generate useless entries in the
output targetlist of the Unique or HashAgg plan. This code was OK when
written, but subsequent changes to use "physical tlists" where possible
had broken it: given an input subplan that has extra variables added to
avoid a projection step, it would copy those extra variables into the
upper tlist, which is pointless since a projection has to happen anyway.
Bruce Momjian [Fri, 15 Jul 2005 19:02:12 +0000 (19:02 +0000)]
Fix SGML spacing.
Tom Lane [Fri, 15 Jul 2005 18:39:59 +0000 (18:39 +0000)]
Check for out-of-range varoattno in deparse_context_for_subplan.
I have seen this case in CVS tip due to new "physical tlist" optimization
for subqueries. I believe it probably can't happen in existing releases,
but the check is not going to hurt anything, so backpatch to 8.0 just
in case.
Tom Lane [Fri, 15 Jul 2005 17:09:26 +0000 (17:09 +0000)]
Fix overenthusiastic optimization of 'x IN (SELECT DISTINCT ...)' and related
cases: we can't just consider whether the subquery's output is unique on its
own terms, we have to check whether the set of output columns we are going to
use will be unique. Per complaint from Luca Pireddu and test case from
Michael Fuhr.
Tom Lane [Thu, 14 Jul 2005 21:46:30 +0000 (21:46 +0000)]
Adjust permissions checking for ALTER OWNER commands: instead of
requiring superuserness always, allow an owner to reassign ownership
to any role he is a member of, if that role would have the right to
create a similar object. These three requirements essentially state
that the would-be alterer has enough privilege to DROP the existing
object and then re-CREATE it as the new role; so we might as well
let him do it in one step. The ALTER TABLESPACE case is a bit
squirrely, but the whole concept of non-superuser tablespace owners
is pretty dubious anyway. Stephen Frost, code review by Tom Lane.
Bruce Momjian [Thu, 14 Jul 2005 21:12:41 +0000 (21:12 +0000)]
Enable multi-byte thousands_sep and decimal_point for numericsep.
Bruce Momjian [Thu, 14 Jul 2005 15:54:21 +0000 (15:54 +0000)]
Make better thousands_sep default based on decimal marker value.
Bruce Momjian [Thu, 14 Jul 2005 08:42:37 +0000 (08:42 +0000)]
Change numericsep to a boolean, and make it locale-aware.
Bruce Momjian [Thu, 14 Jul 2005 07:32:01 +0000 (07:32 +0000)]
Add numeric separator support for latex and troff output methods.
Neil Conway [Thu, 14 Jul 2005 07:12:27 +0000 (07:12 +0000)]
Mark xml2 CREATE FUNCTIONs as IMMUTABLE, and use the "STRICT" syntax
rather than the deprecated "WITH (isStrict)" syntax. Patch from Ilia
Kantor, minor editorializing by Neil Conway.
Bruce Momjian [Thu, 14 Jul 2005 06:49:58 +0000 (06:49 +0000)]
barebones variable name -> tuples_only, for consistency.
Bruce Momjian [Thu, 14 Jul 2005 06:46:17 +0000 (06:46 +0000)]
Fix malloc length for new numeric separator patch.
Centralize malloc into function.
Neil Conway [Thu, 14 Jul 2005 06:17:36 +0000 (06:17 +0000)]
This doc patch replaces all inappropriate references to SQL:1999 when it
is used as if it were the latest (and/or still valid) SQL standard.
SQL:2003 is used in its place. Patch from Simon Riggs.
Tom Lane [Thu, 14 Jul 2005 05:13:45 +0000 (05:13 +0000)]
Integrate autovacuum functionality into the backend. There's still a
few loose ends to be dealt with, but it seems to work. Alvaro Herrera,
based on the contrib code by Matthew O'Connor.
Tom Lane [Wed, 13 Jul 2005 22:46:09 +0000 (22:46 +0000)]
Fix a couple of bogus comments, per Alvaro.
Tom Lane [Wed, 13 Jul 2005 17:12:56 +0000 (17:12 +0000)]
Remove extraneous space after -L ... it confuses SHLIB_LINK filter -L
hack.
Tom Lane [Wed, 13 Jul 2005 17:00:44 +0000 (17:00 +0000)]
Fix unwanted side-effects of recent SHLIB_LINK -L patch on existing
hacking of SHLIB_LINK for HPUX.
Bruce Momjian [Wed, 13 Jul 2005 15:59:32 +0000 (15:59 +0000)]
Fix #elif spacing too.
Tom Lane [Wed, 13 Jul 2005 15:25:55 +0000 (15:25 +0000)]
Fix libpq memory leak during PQreset() --- closePGconn() was not
freeing all transient state of the PGconn object.
Bruce Momjian [Wed, 13 Jul 2005 04:44:42 +0000 (04:44 +0000)]
Fix pgindent to not have blank line before #else in variable definition
section of a function.
Bruce Momjian [Wed, 13 Jul 2005 04:00:28 +0000 (04:00 +0000)]
Add backslashes to parentheses in awk regex because if not, they are
treated as regex groups.
Bruce Momjian [Wed, 13 Jul 2005 02:11:57 +0000 (02:11 +0000)]
Move -L flag around for shared builds:
I wrote:
> So either we code up some intelligence to put the "C" in the right
> position or we have to pass down "A B" and "D" separately from the
> main makefile.
The following patch might just do the former. Please try it out.
Peter E.
Neil Conway [Wed, 13 Jul 2005 02:10:42 +0000 (02:10 +0000)]
Documentation for some new PL/Perl features. Patch from David Fetter,
various editorialization from Neil Conway.
Tom Lane [Tue, 12 Jul 2005 23:06:48 +0000 (23:06 +0000)]
Hack around the discrepancy between default library search paths for
gcc and for HP's ld on HPUX. There may be better ways to do this,
but this seems to work for me...
Tom Lane [Tue, 12 Jul 2005 20:35:42 +0000 (20:35 +0000)]
Fix plperl crash with list value return for an array result type.
Reported by Michael Fuhr, fixed by Andrew Dunstan.
Tom Lane [Tue, 12 Jul 2005 20:27:45 +0000 (20:27 +0000)]
More pgcrypto fixes: handle long messages correctly, suppress
compiler warnings. Marko Kreen and Kris Jurka.
Bruce Momjian [Tue, 12 Jul 2005 16:05:12 +0000 (16:05 +0000)]
Improve comments for AdjustIntervalForTypmod.
Blank line adjustments.
Bruce Momjian [Tue, 12 Jul 2005 15:17:44 +0000 (15:17 +0000)]
Change 5e0 to 5.0, for consistency.
Tom Lane [Tue, 12 Jul 2005 01:16:22 +0000 (01:16 +0000)]
Fix plperl to do recursion safely, and fix a problem with array results.
Add suitable regression tests. Andrew Dunstan
Tom Lane [Mon, 11 Jul 2005 19:06:46 +0000 (19:06 +0000)]
Further tweaking of Win32-specific random code. Marko Kreen
Tom Lane [Mon, 11 Jul 2005 17:00:03 +0000 (17:00 +0000)]
I forgot to update win32 code when doing a renaming in random.c.
Marko Kreen
Tom Lane [Mon, 11 Jul 2005 15:40:38 +0000 (15:40 +0000)]
Avoid bzero/bxopy in favor of more standard library routines.
Marko Kreen
Tom Lane [Mon, 11 Jul 2005 15:07:59 +0000 (15:07 +0000)]
More pgcrypto fixes: avoid bogus alignment assumptions in sha2,
be more wary about having a value for BYTE_ORDER, clean up randomly-
chosen ways of including Postgres core headers.
Marko Kreen and Tom Lane
Tom Lane [Mon, 11 Jul 2005 14:38:05 +0000 (14:38 +0000)]
Add support for AES cipher with older OpenSSL libraries.
Marko Kreen
Tom Lane [Sun, 10 Jul 2005 21:36:21 +0000 (21:36 +0000)]
Missed adding extra argument to array_recv in a couple of places
(harmless, actually, but let's be tidy).
Tom Lane [Sun, 10 Jul 2005 21:14:00 +0000 (21:14 +0000)]
Change typreceive function API so that receive functions get the same
optional arguments as text input functions, ie, typioparam OID and
atttypmod. Make all the datatypes that use typmod enforce it the same
way in typreceive as they do in typinput. This fixes a problem with
failure to enforce length restrictions during COPY FROM BINARY.
Bruce Momjian [Sun, 10 Jul 2005 18:32:55 +0000 (18:32 +0000)]
> One more failure:
>
> I think this is because we don't have -lz in SHLIB_LINK.
> Following patch fixes it.
Marko Kreen
Bruce Momjian [Sun, 10 Jul 2005 18:31:59 +0000 (18:31 +0000)]
Add extra argument for new pg_regexec API.
Tom Lane [Sun, 10 Jul 2005 17:22:54 +0000 (17:22 +0000)]
Suppress compile warning.
Bruce Momjian [Sun, 10 Jul 2005 16:13:13 +0000 (16:13 +0000)]
Rename xmalloc to pg_malloc for consistency with psql usage.
Add missing plperl include.
Bruce Momjian [Sun, 10 Jul 2005 15:53:42 +0000 (15:53 +0000)]
Reverse pg_malloc patch because psql/print.c is used in scripts files
that don't have pg_malloc.
Bruce Momjian [Sun, 10 Jul 2005 15:48:14 +0000 (15:48 +0000)]
Use failure-safe pg_malloc consistently in psql/print.c.
Bruce Momjian [Sun, 10 Jul 2005 15:37:03 +0000 (15:37 +0000)]
Remove #include <openssl/bn.h> as compile fix.
Marko Kreen
Bruce Momjian [Sun, 10 Jul 2005 15:32:47 +0000 (15:32 +0000)]
Following up a previous thought I had, yesterday I realised how to
return arays nicely without having to make the plperl programmer aware
of anything. The attached patch allows plperl to return an arrayref
where the function returns an array type. It silently calls a perl
function to stringify the array before passing it to the pg array
parser. Non-array returns are handled as before (i.e. passed through
this process) so it is backwards compatible. I will presently submit
regression tests and docs.
example:
andrew=# create or replace function blah() returns text[][] language
plperl as $$ return [['a"b','c,d'],['e\\f','g']]; $$;
CREATE FUNCTION
andrew=# select blah();
blah
-----------------------------
{{"a\"b","c,d"},{"e\\f",g}}
This would complete half of the TODO item:
. Pass arrays natively instead of as text between plperl and postgres
(The other half is translating pg array arguments to perl arrays - that
will have to wait for 8.1).
Some of this patch is adapted from a previously submitted patch from
Sergej Sergeev. Both he and Abhijit Menon-Sen have looked it over
briefly and tentatively said it looks ok.
Andrew Dunstan
Bruce Momjian [Sun, 10 Jul 2005 15:19:43 +0000 (15:19 +0000)]
The attached patch implements spi_query() and spi_fetchrow() functions
for PL/Perl, to avoid loading the entire result set into memory as the
existing spi_exec_query() function does.
Here's how one might use the new functions:
$x = spi_query("select ...");
while (defined ($y = spi_fetchrow($x))) {
...
return_next(...);
}
The changes do not affect the spi_exec_query() interface in any way.
Abhijit Menon-Sen
Bruce Momjian [Sun, 10 Jul 2005 15:08:52 +0000 (15:08 +0000)]
Add --encoding to pg_dump.
The Problem: Occassionally a DBA needs to dump a database to a new
encoding. In instances where the current encoding, (or lack of an
encoding, like SQL_ASCII) is poorly supported on the target database
server, it can be useful to dump into a particular encoding. But,
currently the only way to set the encoding of a pg_dump file is to
change client_encoding in postgresql.conf and restart postmaster.
This is more than a little awkward for production systems.
Magnus Hagander
Bruce Momjian [Sun, 10 Jul 2005 14:26:30 +0000 (14:26 +0000)]
This patch implements putting language handlers for the optional PLs
into pg_catalog rather than public, and supports dumping languages whose
handlers are found there. This will make it easier to drop the public
schema if desired.
Unlike the previous patch, the comments have been updated and I have
reformatted some code to meet Alvarro's request to stick to 80 cols. (I
actually aghree with this - it makes printing the code much nicer).
I think I did the right thing w.r.t versions earlier than 7.3, but I
have no real way of checking, so that should be checked by someone with
more/older knowledge than me ;-)
Andrew Dunstan
Bruce Momjian [Sun, 10 Jul 2005 13:54:34 +0000 (13:54 +0000)]
As Kris Jurka found out, pgcrypto does not work with
OpenSSL 0.9.6x. The DES functions use the older 'des_'
API, but the newer 3DES functions use the 0.9.7x-only
'DES_' API.
I think I just used /usr/include/openssl/des.h for reference
when implementing them, and had upgraded OpenSSL in the
meantime.
Following patch converts DES also to newer API and provides
compatibility functions for OpenSSL < 0.9.7.
I chose this route because:
- openssl.c uses few DES functions.
- compatibility for old 'des_' API is going away at some point
of time from OpenSSL.
- as seen from macros, new API is saner
- Thus pgcrypto supports any OpenSSL version from 0.9.5 to 1.0
Tested with OpenSSL 0.9.6c and 0.9.7e.
Marko Kreen
Bruce Momjian [Sun, 10 Jul 2005 13:46:29 +0000 (13:46 +0000)]
Add missing pgcrypto files from previous commit.
Bruce Momjian [Sun, 10 Jul 2005 05:06:42 +0000 (05:06 +0000)]
Update.
< computations should adjust based on the time zone rules, e.g.
< adding 24 hours to a timestamp would yield a different result from
< adding one day.
<
> computations should adjust based on the time zone rules.
Bruce Momjian [Sun, 10 Jul 2005 04:56:55 +0000 (04:56 +0000)]
This patch addresses the problem mentioned in the "process crash
when a plpython function returns unicode" thread:
http://archives.postgresql.org/pgsql-bugs/2005-06/msg00105.php
In several places PL/Python was calling PyObject_Str() and then
PyString_AsString() without checking if the former had returned
NULL to indicate an error. PyString_AsString() doesn't expect a
NULL argument, so passing one causes a segmentation fault. This
patch adds checks for NULL and raises errors via PLy_elog(), which
prints details of the underlying Python exception. The patch also
adds regression tests for these checks. All tests pass on my
Solaris 9 box running HEAD and Python 2.4.1.
In one place the patch doesn't call PLy_elog() because that could
cause infinite recursion; see the comment I added. I'm not sure
how to test that particular case or whether it's even possible to
get an error there: the value that the code should check is the
Python exception type, so I wonder if a NULL value "shouldn't
happen." This patch converts NULL to "Unknown Exception" but I
wonder if an Assert() would be appropriate.
The patch is against HEAD but the same changes should be applied
to earlier versions because they have the same problem. The patch
might not apply cleanly against earlier versions -- will the committer
take care of little differences or should I submit different versions
of the patch?
Michael Fuhr
Bruce Momjian [Sun, 10 Jul 2005 04:54:33 +0000 (04:54 +0000)]
I made the patch that implements regexp_replace again.
The specification of this function is as follows.
regexp_replace(source text, pattern text, replacement text, [flags
text])
returns text
Replace string that matches to regular expression in source text to
replacement text.
- pattern is regular expression pattern.
- replacement is replace string that can use '\1'-'\9', and '\&'.
'\1'-'\9': back reference to the n'th subexpression.
'\&' : entire matched string.
- flags can use the following values:
g: global (replace all)
i: ignore case
When the flags is not specified, case sensitive, replace the first
instance only.
Atsushi Ogawa
Bruce Momjian [Sun, 10 Jul 2005 03:57:55 +0000 (03:57 +0000)]
Major pgcrypto changes:
of password-based encryption from RFC2440 (OpenPGP).
The goal of this code is to be more featureful encryption solution
than current encrypt(), which only functionality is running cipher
over data.
Compared to encrypt(), pgp_encrypt() does following:
* It uses the equvialent of random Inital Vector to get cipher
into random state before it processes user data
* Stores SHA-1 of the data into result so any modification
will be detected.
* Remembers if data was text or binary - thus it can decrypt
to/from text data. This was a major nuisance for encrypt().
* Stores info about used algorithms with result, so user needs
not remember them - more user friendly!
* Uses String2Key algorithms (similar to crypt()) with random salt
to generate full-length binary key to be used for encrypting.
* Uses standard format for data - you can feed it to GnuPG, if needed.
Optional features (off by default):
* Can use separate session key - user data will be encrypted
with totally random key, which will be encrypted with S2K
generated key and attached to result.
* Data compression with zlib.
* Can convert between CRLF<->LF line-endings - to get fully
RFC2440-compliant behaviour. This is off by default as
pgcrypto does not know the line-endings of user data.
Interface is simple:
pgp_encrypt(data text, key text) returns bytea
pgp_decrypt(data text, key text) returns text
pgp_encrypt_bytea(data bytea, key text) returns bytea
pgp_decrypt_bytea(data bytea, key text) returns bytea
To change parameters (cipher, compression, mdc):
pgp_encrypt(data text, key text, parms text) returns bytea
pgp_decrypt(data text, key text, parms text) returns text
pgp_encrypt_bytea(data bytea, key text, parms text) returns bytea
pgp_decrypt_bytea(data bytea, key text, parms text) returns bytea
Parameter names I lifted from gpg:
pgp_encrypt('message', 'key', 'compress-algo=1,cipher-algo=aes256')
For text data, pgp_encrypt simply encrypts the PostgreSQL internal data.
This maps to RFC2440 data type 't' - 'extenally specified encoding'.
But this may cause problems if data is dumped and reloaded into database
which as different internal encoding. My next goal is to implement data
type 'u' - which means data is in UTF-8 encoding by converting internal
encoding to UTF-8 and back. And there wont be any compatibility
problems with current code, I think its ok to submit this without UTF-8
encoding by converting internal encoding to UTF-8 and back. And there
wont be any compatibility problems with current code, I think its ok to
submit this without UTF-8 support.
Here is v4 of PGP encrypt. This depends on previously sent
Fortuna-patch, as it uses the px_add_entropy function.
- New function: pgp_key_id() for finding key id's.
- Add SHA1 of user data and key into RNG pools. We need to get
randomness from somewhere, and it is in user best interests
to contribute.
- Regenerate pgp-armor test for SQL_ASCII database.
- Cleanup the key handling so that the pubkey support is less
hackish.
Marko Kreen
Bruce Momjian [Sun, 10 Jul 2005 03:55:28 +0000 (03:55 +0000)]
- Add Fortuna PRNG to pgcrypto.
- Move openssl random provider to openssl.c and builtin provider
to internal.c
- Make px_random_bytes use Fortuna, instead of giving error.
- Retarget random.c to aquiring system randomness, for initial seeding
of Fortuna. There is ATM 2 functions for Windows,
reader from /dev/urandom and the regular time()/getpid() silliness.
Marko Kreen
Bruce Momjian [Sun, 10 Jul 2005 03:52:56 +0000 (03:52 +0000)]
This patch adds implementation of SHA2 to pgcrypto.
New hashes: SHA256, SHA384, SHA512.
Marko Kreen
Bruce Momjian [Sun, 10 Jul 2005 03:46:13 +0000 (03:46 +0000)]
Add psql \pset numericsep to allow output numbers like 100,000.0 or
100.000,0.
Eugen Nedelcu
Tom Lane [Sat, 9 Jul 2005 01:53:22 +0000 (01:53 +0000)]
Fix inadequate error checking: you can't assume that fcinfo->resultinfo
is a ReturnSetInfo unless you've tested it with IsA.