OSDN Git Service
Tom Lane [Fri, 10 Aug 2007 03:16:04 +0000 (03:16 +0000)]
Fix uninitialized-memory bug in plpython proargnames patch. Per bug #3523
Tom Lane [Fri, 10 Aug 2007 00:39:31 +0000 (00:39 +0000)]
Fix unintended change of output format for createlang/droplang -l. Missed
these uses of printQuery() in FETCH_COUNT patch a year ago :-(. Per report
from Tomoaki Sato.
Tom Lane [Thu, 9 Aug 2007 02:33:58 +0000 (02:33 +0000)]
Fix search for SGML stylesheets to include the place where Gentoo keeps them.
Brendan Jurd
Tom Lane [Thu, 9 Aug 2007 01:18:43 +0000 (01:18 +0000)]
Revise postmaster startup/shutdown logic to eliminate the problem that a
constant flow of new connection requests could prevent the postmaster from
completing a shutdown or crash restart. This is done by labeling child
processes that are "dead ends", that is, we know that they were launched only
to tell a client that it can't connect. These processes are managed
separately so that they don't confuse us into thinking that we can't advance
to the next stage of a shutdown or restart sequence, until the very end
where we must wait for them to drain out so we can delete the shmem segment.
Per discussion of a misbehavior reported by Keaton Adams.
Since this code was baroque already, and my first attempt at fixing the
problem made it entirely impenetrable, I took the opportunity to rewrite it
in a state-machine style. That eliminates some duplicated code sections and
hopefully makes everything a bit clearer.
Neil Conway [Wed, 8 Aug 2007 18:07:05 +0000 (18:07 +0000)]
Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation
hash table is allocated in a child context of the agg node's memory
context, MemoryContextReset() will reset but *not* delete the child
context. Since ExecReScanAgg() proceeds to build a new hash table
from scratch (in a new sub-context), this results in leaking the
header for the previous memory context. Therefore, use
MemoryContextResetAndDeleteChildren() instead.
Credit: My colleague Sailesh Krishnamurthy at Truviso for isolating
the cause of the leak.
Tom Lane [Wed, 8 Aug 2007 16:00:46 +0000 (16:00 +0000)]
Fix thinko in multi-autovac-workers code: validity checks made by
GUC assign hooks are supposed to be made whether doit is true or not.
Neil Conway [Tue, 7 Aug 2007 06:25:14 +0000 (06:25 +0000)]
Adjust the output of MemoryContextStats() so that the stats for a
child memory contexts is indented two spaces to the right of its
parent context. This should make it easier to deduce the memory
context hierarchy from the output of MemoryContextStats().
Magnus Hagander [Mon, 6 Aug 2007 07:58:06 +0000 (07:58 +0000)]
Fix incorrect URI for cvs rsync
Tom Lane [Mon, 6 Aug 2007 01:38:15 +0000 (01:38 +0000)]
Fix pg_restore to guard against unexpected EOF while reading an archive file.
Per report and partial patch from Chad Wagner.
Tom Lane [Sun, 5 Aug 2007 15:43:00 +0000 (15:43 +0000)]
Adjust configure so that it sets CFLAGS properly for Intel's icc
even if the compiler is not defining __GNUC__. Per report from
Dirk Tilger that it is possible for icc to not do that.
Tom Lane [Sun, 5 Aug 2007 15:11:40 +0000 (15:11 +0000)]
Apparently icc doesn't always define __ICC, and it's more correct to
check for __INTEL_COMPILER. Per report from Dirk Tilger.
Not back-patched since I don't fully trust it yet ...
Tom Lane [Sat, 4 Aug 2007 21:53:00 +0000 (21:53 +0000)]
Fix up bad layout of some comments (probably pg_indent's fault), and
improve grammar a tad. Per Greg Stark.
Neil Conway [Sat, 4 Aug 2007 21:01:09 +0000 (21:01 +0000)]
Tweak for initdb: if more command-line arguments were specified than
expected, exit with an error, rather than complaining about the error
on stderr but continuing onward.
Tom Lane [Sat, 4 Aug 2007 19:29:25 +0000 (19:29 +0000)]
Fix crash caused by log_timezone patch if we attempt to emit any elog messages
between the setting of log_line_prefix and the setting of log_timezone. We
can't realistically set log_timezone any earlier than we do now, so the best
behavior seems to be to use GMT zone if any timestamps are to be logged during
early startup. Create a dummy zone variable with a minimal definition of GMT
(in particular it will never know about leap seconds), so that we can set it
up without reference to any external files.
Tom Lane [Sat, 4 Aug 2007 03:15:49 +0000 (03:15 +0000)]
Fix a problem in my recent patch to initialize cancel_key for autovac workers
as well as regular backends: if no regular backend launches before the autovac
launcher tries to start an autovac worker, the postmaster would get an Assert
fault due to calling PostmasterRandom before random_seed was initialized.
Cleanest solution seems to be to take the initialization of random_seed out
of ServerLoop and let PostmasterRandom do it for itself.
Tom Lane [Sat, 4 Aug 2007 01:26:54 +0000 (01:26 +0000)]
Switch over to using the src/timezone functions for formatting timestamps
displayed in the postmaster log. This avoids Windows-specific problems with
localized time zone names that are in the wrong encoding, and generally seems
like a good idea to forestall other potential platform-dependent issues.
To preserve the existing behavior that all backends will log in the same time
zone, create a new GUC variable log_timezone that can only be changed on a
system-wide basis, and reference log-related calculations to that zone instead
of the TimeZone variable.
This fixes the issue reported by Hiroshi Saito that timestamps printed by
xlog.c startup could be improperly localized on Windows. We still need a
simpler patch for that problem in the back branches, however.
Tom Lane [Fri, 3 Aug 2007 20:06:50 +0000 (20:06 +0000)]
Fix some sloppiness in the recent multiple-autovacuum-worker patch. It was
not bothering to initialize is_autovacuum for regular backends, meaning there
was a significant chance of the postmaster prematurely sending them SIGTERM
during database shutdown. Also, leaving the cancel key unset for an autovac
worker meant that any client could send it SIGINT, which doesn't sound
especially good either.
Magnus Hagander [Fri, 3 Aug 2007 10:47:11 +0000 (10:47 +0000)]
Update supported standalone VC++ version to 7.1+ only, and fix
some bad data leftover in win32.mak.
Per request from Hiroshi Saito.
Andrew Dunstan [Thu, 2 Aug 2007 23:39:45 +0000 (23:39 +0000)]
Move session_start out of MyProcPort stucture and make it a global called MyStartTime,
so that we will be able to create a cookie for all processes for CSVlogs.
It is set wherever MyProcPid is set. Take the opportunity to remove the now
unnecessary session-only restriction on the %s and %c escapes in log_line_prefix.
Andrew Dunstan [Thu, 2 Aug 2007 23:15:27 +0000 (23:15 +0000)]
Make sure syslogPipe runs in binary mode on Windows to avoid corrupting the pipe chunking protocol. Backport to 8.0
Neil Conway [Thu, 2 Aug 2007 17:48:52 +0000 (17:48 +0000)]
Fix a memory leak in tuplestore_end(). Unlikely to be significant during
normal operation, but tuplestore_end() ought to do what it claims to do.
Bruce Momjian [Wed, 1 Aug 2007 23:13:31 +0000 (23:13 +0000)]
Done:
< * Allow buffered WAL writes and fsync
Tom Lane [Wed, 1 Aug 2007 22:45:09 +0000 (22:45 +0000)]
Support an optional asynchronous commit mode, in which we don't flush WAL
before reporting a transaction committed. Data consistency is still
guaranteed (unlike setting fsync = off), but a crash may lose the effects
of the last few transactions. Patch by Simon, some editorialization by Tom.
Bruce Momjian [Wed, 1 Aug 2007 22:24:32 +0000 (22:24 +0000)]
Fix strange quoting.
Bruce Momjian [Wed, 1 Aug 2007 22:23:01 +0000 (22:23 +0000)]
Fix script quoting problem.
Bruce Momjian [Wed, 1 Aug 2007 00:24:55 +0000 (00:24 +0000)]
Remove links to old Win32 source code ports.
Tom Lane [Tue, 31 Jul 2007 19:53:37 +0000 (19:53 +0000)]
Fix a bug in the original implementation of redundant-join-clause removal:
clauses in which one side or the other references both sides of the join
cannot be removed as redundant, because that expression won't have been
constrained below the join. Per report from Sergey Burladyan.
CVS HEAD does not contain this bug due to EquivalenceClass rewrite, but it
seems wise to include the regression test for it anyway.
Tom Lane [Tue, 31 Jul 2007 16:36:07 +0000 (16:36 +0000)]
If we're gonna use ExecRelationIsTargetRelation here, might as well
simplify a bit further.
Tom Lane [Tue, 31 Jul 2007 15:49:49 +0000 (15:49 +0000)]
Fix security definer functions with polymorphic arguments. This case has
never worked because fmgr_security_definer() neglected to pass the fn_expr
information through. Per report from Viatcheslav Kalinin.
Neil Conway [Fri, 27 Jul 2007 19:09:04 +0000 (19:09 +0000)]
Slight refactor for ExecOpenScanRelation(): we can use
ExecRelationIsTargetRelation() to check if the relation is a target
rel, rather than scanning through the result relation array ourselves.
Peter Eisentraut [Fri, 27 Jul 2007 10:37:52 +0000 (10:37 +0000)]
Update conformance information about bigint type
found by Michael Glaesemann
Tom Lane [Thu, 26 Jul 2007 15:15:18 +0000 (15:15 +0000)]
Remove FileUnlink(), which wasn't being used anywhere and interacted poorly
with the recent patch to log temp file sizes at removal time. Doesn't seem
worth fixing since it's unused.
In passing, make a few elog messages conform to the message style guide.
Tom Lane [Wed, 25 Jul 2007 22:16:18 +0000 (22:16 +0000)]
Arrange to put TOAST tables belonging to temporary tables into special schemas
named pg_toast_temp_nnn, alongside the pg_temp_nnn schemas used for the temp
tables themselves. This allows low-level code such as the relcache to
recognize that these tables are indeed temporary, which enables various
optimizations such as not WAL-logging changes and using local rather than
shared buffers for access. Aside from obvious performance benefits, this
provides a solution to bug #3483, in which other backends unexpectedly held
open file references to temporary tables. The scheme preserves the property
that TOAST tables are not in any schema that's normally in the search path,
so they don't conflict with user table names.
initdb forced because of changes in system view definitions.
Tom Lane [Wed, 25 Jul 2007 19:58:56 +0000 (19:58 +0000)]
Suppress warning when compiling with -DPROFILE_PID_DIR: sys/stat.h is
supposed to be included when using mkdir().
Tom Lane [Wed, 25 Jul 2007 17:22:37 +0000 (17:22 +0000)]
Adjust horology test to avoid join-plan-dependent result ordering in
a few queries. Should fix buildfarm failures arising from new,
more aggressive autovac settings.
Michael Meskes [Wed, 25 Jul 2007 16:10:41 +0000 (16:10 +0000)]
Synced parser
Magnus Hagander [Wed, 25 Jul 2007 12:22:54 +0000 (12:22 +0000)]
Rename DLLIMPORT macro to PGDLLIMPORT to avoid conflict with
third party includes (like tcl) that define DLLIMPORT.
Magnus Hagander [Wed, 25 Jul 2007 11:37:25 +0000 (11:37 +0000)]
Fix standalone win32 makefile (MSVC6) for SSPI and GSSAPI.
Hiroshi Saito
Magnus Hagander [Wed, 25 Jul 2007 10:51:03 +0000 (10:51 +0000)]
Disable warning 4090 = different const qualifiers on msvc since it
warns about things that aren't wrong.
Magnus Hagander [Wed, 25 Jul 2007 10:17:46 +0000 (10:17 +0000)]
Silence compiler warnings on mingw
Neil Conway [Wed, 25 Jul 2007 04:19:09 +0000 (04:19 +0000)]
Implement RETURN QUERY for PL/PgSQL. This provides some convenient syntax
sugar for PL/PgSQL set-returning functions that want to return the result
of evaluating a query; it should also be more efficient than repeated
RETURN NEXT statements. Based on an earlier patch from Pavel Stehule.
Tom Lane [Tue, 24 Jul 2007 17:22:07 +0000 (17:22 +0000)]
Fix predicate-proving logic to cope with binary-compatibility cases when
checking whether an IS NULL/IS NOT NULL clause is implied or refuted by
a strict function. Per example from Dawid Kuroczko.
Backpatch to 8.2 since this is arguably a performance bug.
Magnus Hagander [Tue, 24 Jul 2007 11:16:36 +0000 (11:16 +0000)]
Silence compiler warning on mingw
Magnus Hagander [Tue, 24 Jul 2007 09:00:27 +0000 (09:00 +0000)]
Make it possible, and default, for MingW to build with SSPI support
by dynamically loading the function that's missing from the MingW
headers and library.
Tom Lane [Tue, 24 Jul 2007 04:54:09 +0000 (04:54 +0000)]
Create a new dedicated Postgres process, "wal writer", which exists to write
and fsync WAL at convenient intervals. For the moment it just tries to
offload this work from backends, but soon it will be responsible for
guaranteeing a maximum delay before asynchronously-committed transactions
will be flushed to disk.
This is a portion of Simon Riggs' async-commit patch, committed to CVS
separately because a background WAL writer seems like it might be a good idea
independently of the async-commit feature. I rebased walwriter.c on
bgwriter.c because it seemed like a more appropriate way of handling signals;
while the startup/shutdown logic in postmaster.c is more like autovac because
we want walwriter to quit before we start the shutdown checkpoint.
Alvaro Herrera [Tue, 24 Jul 2007 01:53:56 +0000 (01:53 +0000)]
Set a default autovacuum vacuum_cost_delay value of 20ms, to avoid excessive
I/O utilization, per discussion.
While at it, lower the autovacuum vacuum and analyze threshold values to 50
tuples. It is a bit higher (i.e. more conservative) than what I originally
proposed but much better than the old values for small tables.
Tom Lane [Mon, 23 Jul 2007 18:59:50 +0000 (18:59 +0000)]
Just noticed that libpq thinks the maximum command tag length is 40,
whereas in the backend it's been 64 for some time. Hasn't mattered
because no actual tags exceed 40 bytes, but for consistency they should
be alike.
Magnus Hagander [Mon, 23 Jul 2007 17:52:06 +0000 (17:52 +0000)]
Use PQExpBuffer for error message in fe-auth.c.
In passing, change functions that passedin both PGconn and
parts of it to just pass in the PGconn.
Alvaro Herrera [Mon, 23 Jul 2007 17:22:00 +0000 (17:22 +0000)]
Reword paragraph about the autovacuum_max_workers setting. Patch from
Jim Nasby.
Magnus Hagander [Mon, 23 Jul 2007 10:57:36 +0000 (10:57 +0000)]
Stupid typo.
Magnus Hagander [Mon, 23 Jul 2007 10:16:54 +0000 (10:16 +0000)]
SSPI authentication on Windows. GSSAPI compatible client when doing Kerberos
against a Unix server, and Windows-specific server-side authentication
using SSPI "negotiate" method (Kerberos or NTLM).
Only builds properly with MSVC for now.
Tom Lane [Sat, 21 Jul 2007 22:12:04 +0000 (22:12 +0000)]
Fix elog.c to avoid infinite recursion (leading to backend crash) when
log_min_error_statement is active and there is some problem in logging the
current query string; for example, that it's too long to include in the log
message without running out of memory. This problem has existed since the
log_min_error_statement feature was introduced. No doubt the reason it
wasn't detected long ago is that 8.2 is the first release that defaults
log_min_error_statement to less than PANIC level.
Per report from Bill Moran.
Tom Lane [Sat, 21 Jul 2007 04:02:41 +0000 (04:02 +0000)]
Provide a bit more high-level documentation for the GEQO planner.
Per request from Luca Ferrari.
Peter Eisentraut [Fri, 20 Jul 2007 16:38:38 +0000 (16:38 +0000)]
Fix regression tests for PL/pgSQL error message changes
Tom Lane [Fri, 20 Jul 2007 16:29:53 +0000 (16:29 +0000)]
Fix WAL replay of truncate operations to cope with the possibility that the
truncated relation was deleted later in the WAL sequence. Since replay
normally auto-creates a relation upon its first reference by a WAL log entry,
failure is seen only if the truncate entry happens to be the first reference
after the checkpoint we're restarting from; which is a pretty unusual case but
of course not impossible. Fix by making truncate entries auto-create like
the other ones do. Per report and test case from Dharmendra Goyal.
Peter Eisentraut [Fri, 20 Jul 2007 16:23:34 +0000 (16:23 +0000)]
Capitalize language key words in error messages
Tom Lane [Thu, 19 Jul 2007 21:58:12 +0000 (21:58 +0000)]
On second thought, the tests for what to do with stderr output are a
lot more sensible if we check the chunk-output case first. Not
back-patched since it's just a cosmetic improvement.
Tom Lane [Thu, 19 Jul 2007 20:34:20 +0000 (20:34 +0000)]
Make replace(), split_part(), and string_to_array() behave somewhat sanely
when handed an invalidly-encoded pattern. The previous coding could get
into an infinite loop if pg_mb2wchar_with_len() returned a zero-length
string after we'd tested for nonempty pattern; which is exactly what it
will do if the string consists only of an incomplete multibyte character.
This led to either an out-of-memory error or a backend crash depending
on platform. Per report from Wiktor Wodecki.
Andrew Dunstan [Thu, 19 Jul 2007 19:13:43 +0000 (19:13 +0000)]
Only use the pipe chunking protocol if we know the syslogger should
be catching stderr output, and we are not ourselves the
syslogger. Otherwise, go directly to stderr.
Bug noticed by Tom Lane.
Backpatch as far as 8.0.
Tom Lane [Thu, 19 Jul 2007 17:15:30 +0000 (17:15 +0000)]
Adjust configure script to print the bison and flex versions in use.
Minor rearrangements to make a few tests in a more logical order.
Tom Lane [Wed, 18 Jul 2007 21:40:57 +0000 (21:40 +0000)]
Fix an old thinko in SS_make_initplan_from_plan, which is used when optimizing
a MIN or MAX aggregate call into an indexscan: the initplan is being made at
the current query nesting level and so we shouldn't increment query_level.
Though usually harmless, this mistake could lead to bogus "plan should not
reference subplan's variable" failures on complex queries. Per bug report
from David Sanchez i Gregori.
Alvaro Herrera [Wed, 18 Jul 2007 21:19:17 +0000 (21:19 +0000)]
Cast NULL to a pointer type in the execl() call, to avoid a compiler warning on
some platforms and possibly a bug. Per report from Stefan and subsequent
discussion.
Magnus Hagander [Wed, 18 Jul 2007 12:00:47 +0000 (12:00 +0000)]
GSSAPI documentation
Bruce Momjian [Wed, 18 Jul 2007 03:39:01 +0000 (03:39 +0000)]
Document that 'deleted' is also tracked by autovacuum.
Bruce Momjian [Wed, 18 Jul 2007 03:13:13 +0000 (03:13 +0000)]
Properly adjust age() seconds to match the sign of the larger units.
Patch from Tom.
Bruce Momjian [Wed, 18 Jul 2007 03:12:42 +0000 (03:12 +0000)]
Document that age() adds days, then full months.
Bruce Momjian [Wed, 18 Jul 2007 00:16:21 +0000 (00:16 +0000)]
Add:
>
> o Allow GLOBAL temporary tables to exist as empty by default in
> all sessions
>
> http://archives.postgresql.org/pgsql-hackers/2007-07/msg00006.php
>
Tom Lane [Tue, 17 Jul 2007 17:45:28 +0000 (17:45 +0000)]
Fix incorrect optimization of foreign-key checks. When an UPDATE on the
referencing table does not change the tuple's FK column(s), we don't bother
to check the PK table since the constraint was presumably already valid.
However, the check is still necessary if the tuple was inserted by our own
transaction, since in that case the INSERT trigger will conclude it need not
make the check (since its version of the tuple has been deleted). We got this
right for simple cases, but not when the insert and update are in different
subtransactions of the current top-level transaction; in such cases the FK
check would never be made at all. (Hence, problem dates back to 8.0 when
subtransactions were added --- it's actually the subtransaction version of a
bug fixed in 7.3.5.) Fix, and add regression test cases. Report and fix by
Affan Salman.
Bruce Momjian [Tue, 17 Jul 2007 05:03:55 +0000 (05:03 +0000)]
Remove benchmarkresources.com, no longer resolves to a
meaningful site.
Neil Conway [Tue, 17 Jul 2007 05:02:03 +0000 (05:02 +0000)]
Implement CREATE TABLE LIKE ... INCLUDING INDEXES. Patch from NikhilS,
based in part on an earlier patch from Trevor Hardcastle, and reviewed
by myself.
Bruce Momjian [Tue, 17 Jul 2007 01:52:34 +0000 (01:52 +0000)]
Add CVS Wiki URL to docs.
Tom Lane [Tue, 17 Jul 2007 01:21:43 +0000 (01:21 +0000)]
Fix outfuncs.c to dump A_Const nodes representing NULLs correctly. This has
been broken since forever, but was not noticed because people seldom look
at raw parse trees. AFAIK, no impact on users except that debug_print_parse
might fail; but patch it all the way back anyway. Per report from Jeff Ross.
Bruce Momjian [Tue, 17 Jul 2007 00:07:54 +0000 (00:07 +0000)]
Add:
> * Allow multiple indexes to be created concurrently, ideally via a
> single heap scan, and have a restore of a pg_dump somehow use it
>
> http://archives.postgresql.org/pgsql-general/2007-05/msg01274.php
Small blank line additions.
Bruce Momjian [Mon, 16 Jul 2007 22:20:51 +0000 (22:20 +0000)]
Update docs that GNU tar versions >=1.16 exit with 1 on files changed, 2
on other errors.
Tom Lane [Mon, 16 Jul 2007 21:20:36 +0000 (21:20 +0000)]
Fix pg_buffercache to release buffer partition locks in reverse order,
and add a note about why. This is not tremendously important right now,
probably, but it will get more urgent if NUM_BUFFER_PARTITIONS is increased
as much as proposed.
Tom Lane [Mon, 16 Jul 2007 21:09:50 +0000 (21:09 +0000)]
Add comments spelling out why it's a good idea to release multiple
partition locks in reverse order.
Neil Conway [Mon, 16 Jul 2007 17:38:48 +0000 (17:38 +0000)]
With the native compiler on Unixware, disable optimization if
--enable-debug is used, to avoid complaints about debugging and
optimization being mutually exclusive. Patch from Stefan Kaltenbrunner.
Tom Lane [Mon, 16 Jul 2007 17:01:11 +0000 (17:01 +0000)]
Allow plpgsql function parameter names to be qualified with the function's
name. With this patch, it is always possible for the user to qualify a
plpgsql variable name if needed to avoid ambiguity. While there is much more
work to be done in this area, this simple change removes one unnecessary
incompatibility with Oracle. Per discussion.
Tom Lane [Mon, 16 Jul 2007 14:02:22 +0000 (14:02 +0000)]
Hmm, so evidently _check_lock and _clear_lock take an argument of type
int not unsigned int. Third try to get grebe building without warnings...
Magnus Hagander [Mon, 16 Jul 2007 08:40:52 +0000 (08:40 +0000)]
Quote pathnames so pg_standby works with paths that have
spaces in them.
ISHIDA Akio
Tom Lane [Mon, 16 Jul 2007 04:57:57 +0000 (04:57 +0000)]
So our reward for including <sys/atomic_op.h> seems to be a bunch of
nattering about casting away volatile. Losers.
Tom Lane [Mon, 16 Jul 2007 02:03:14 +0000 (02:03 +0000)]
On AIX, include <sys/atomic_op.h> so that the functions we use for
TAS support are properly declared.
Tom Lane [Sun, 15 Jul 2007 23:57:13 +0000 (23:57 +0000)]
Get rid of overly cute, unportable, probably not very efficient substitute
for 'bool'. Per buildfarm warnings.
Tom Lane [Sun, 15 Jul 2007 23:46:20 +0000 (23:46 +0000)]
Fix CHECK_RELATION_BLOCK_RANGE macro, which was not merely producing
a warning but was outright wrong.
Tom Lane [Sun, 15 Jul 2007 23:30:19 +0000 (23:30 +0000)]
Fix a passel of signed vs unsigned char warnings.
Tom Lane [Sun, 15 Jul 2007 23:09:26 +0000 (23:09 +0000)]
Silence a rather odd compiler warning. In passing, make this file's
error messages look at least a little bit like the message style
guidelines say.
Tom Lane [Sun, 15 Jul 2007 22:57:48 +0000 (22:57 +0000)]
Avoid possibly-unportable initializer, per buildfarm warning.
Tom Lane [Sun, 15 Jul 2007 22:54:21 +0000 (22:54 +0000)]
Change a couple of exit(0) to return 0 to suppress complaints from
not-too-bright compilers. Per buildfarm results.
Tom Lane [Sun, 15 Jul 2007 22:49:36 +0000 (22:49 +0000)]
Silence Solaris compiler warnings, per buildfarm.
Tom Lane [Sun, 15 Jul 2007 22:43:40 +0000 (22:43 +0000)]
Silence Solaris compiler warning, per buildfarm.
Tom Lane [Sun, 15 Jul 2007 22:40:28 +0000 (22:40 +0000)]
Fix compile warning on Solaris, per buildfarm. (Why have we got
three slightly different copies of this file?)
Tom Lane [Sun, 15 Jul 2007 22:34:26 +0000 (22:34 +0000)]
Fix possible portability problem, per buildfarm warnings.
Tom Lane [Sun, 15 Jul 2007 22:32:53 +0000 (22:32 +0000)]
Fix unportable use of isspace(), per buildfarm results.
Tom Lane [Sun, 15 Jul 2007 22:18:24 +0000 (22:18 +0000)]
Because plpgsql's scanner uses %option case-insensitive, flex's results could
theoretically vary depending on what the compile-time locale setting is.
Hence, force it to see LC_CTYPE=C to ensure consistent build results.
(It's likely that this makes no difference in practice, since our
specification for "identifier" surely includes both ends of any possible
uppercase/lowercase pair anyway. But it should silence warnings about
ambiguous character classes that are reported by some buildfarm members.)
Tom Lane [Sun, 15 Jul 2007 02:15:04 +0000 (02:15 +0000)]
Reject zero or negative BY step in plpgsql integer FOR-loops, and behave
sanely if the loop value overflows int32 on the way to the end value.
Avoid useless computation of "SELECT 1" when BY is omitted. Avoid some
type-punning between Datum and int4 that dates from the original coding.
Tom Lane [Sun, 15 Jul 2007 00:45:16 +0000 (00:45 +0000)]
Note incompatibility with Oracle's version of FOR ... REVERSE, per
Andrew Dunstan. Minor other improvements in documentation of integer
FOR loops.
Tom Lane [Sat, 14 Jul 2007 23:02:25 +0000 (23:02 +0000)]
Editorial overhaul of plpgsql documentation. Provide detailed documentation
of variable substitution and plan caching behavior in dedicated sections.
(A lot of this material existed already, but was scattered in various places
in the chapter.) Reorganize material a little bit, mostly to try to avoid
diving into deep details in the first introductory sections. Document some
fine points that had escaped treatment before, notably the ability to qualify
plpgsql variable names with block labels. Some minor wordsmithing here and
there.
Magnus Hagander [Sat, 14 Jul 2007 11:13:28 +0000 (11:13 +0000)]
Support for finding gssapi functions in the library "gss", as required
by Solaris 10 and possibly others.
Stefan Kaltenbrunner
Tom Lane [Fri, 13 Jul 2007 04:57:59 +0000 (04:57 +0000)]
Volatile-qualify a dozen variables in plpython.c to eliminate warnings
from old versions of gcc. It's not clear to me that this is really
necessary for correctness, but less warnings are always good.
Per buildfarm results and local testing.
Tom Lane [Fri, 13 Jul 2007 03:43:23 +0000 (03:43 +0000)]
Fix map_sql_typecoll_to_xmlschema_types() to not fail on dropped
columns, per my gripe earlier today. Make it look a bit less like
someone's first effort at backend coding.