OSDN Git Service

android-x86/frameworks-av.git
9 years agoam 42bd61d7: am d9a9a324: am 10ef7f75: am b0924c63: am 7af634e1: am 8ec119d2: am...
Wei Jia [Tue, 4 Aug 2015 18:28:58 +0000 (18:28 +0000)]
am 42bd61d7: am d9a9a324: am 10ef7f75: am b0924c63: am 7af634e1: am 8ec119d2: am d138024f: am b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.

* commit '42bd61d73e8b4d0b1101e73324a59fde51077112':
  SampleTable: fix integer overflow checks.

9 years agoam d9a9a324: am 10ef7f75: am b0924c63: am 7af634e1: am 8ec119d2: am d138024f: am...
Wei Jia [Tue, 4 Aug 2015 18:19:37 +0000 (18:19 +0000)]
am d9a9a324: am 10ef7f75: am b0924c63: am 7af634e1: am 8ec119d2: am d138024f: am b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.

* commit 'd9a9a324766b26be2ff0d10537ea0b215b0261e3':
  SampleTable: fix integer overflow checks.

9 years agoam 10ef7f75: am b0924c63: am 7af634e1: am 8ec119d2: am d138024f: am b32957db: am...
Wei Jia [Tue, 4 Aug 2015 18:00:56 +0000 (18:00 +0000)]
am 10ef7f75: am b0924c63: am 7af634e1: am 8ec119d2: am d138024f: am b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.

* commit '10ef7f7514bdf6d9c38c93d9bb0194c0920d152f':
  SampleTable: fix integer overflow checks.

9 years agoam b0924c63: am 7af634e1: am 8ec119d2: am d138024f: am b32957db: am a9d7c917: am...
Wei Jia [Tue, 4 Aug 2015 17:51:22 +0000 (17:51 +0000)]
am b0924c63: am 7af634e1: am 8ec119d2: am d138024f: am b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.

* commit 'b0924c631cfccd10c1f95d6ae44c8cd852e14a9f':
  SampleTable: fix integer overflow checks.

9 years agoam 7af634e1: am 8ec119d2: am d138024f: am b32957db: am a9d7c917: am a99d3d83: am...
Wei Jia [Tue, 4 Aug 2015 17:29:31 +0000 (17:29 +0000)]
am 7af634e1: am 8ec119d2: am d138024f: am b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.

* commit '7af634e131361862d2e47fb344278e31ed05be4f':
  SampleTable: fix integer overflow checks.

9 years agoam 8ec119d2: am d138024f: am b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleT...
Wei Jia [Tue, 4 Aug 2015 17:20:14 +0000 (17:20 +0000)]
am 8ec119d2: am d138024f: am b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.

* commit '8ec119d2f033221e4cb0fd2b2948e780581b3d35':
  SampleTable: fix integer overflow checks.

9 years agoam d138024f: am b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix...
Wei Jia [Tue, 4 Aug 2015 17:09:44 +0000 (17:09 +0000)]
am d138024f: am b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.

* commit 'd138024f94fe01934be700ce16aa84418fbe1827':
  SampleTable: fix integer overflow checks.

9 years agoam b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow...
Wei Jia [Tue, 4 Aug 2015 16:59:31 +0000 (16:59 +0000)]
am b32957db: am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.

* commit 'b32957dbf4527251ad3b2bbda4ccc5fff4df0718':
  SampleTable: fix integer overflow checks.

9 years agoam a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.
Wei Jia [Tue, 4 Aug 2015 16:54:23 +0000 (16:54 +0000)]
am a9d7c917: am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.

* commit 'a9d7c917d3a76d0bef9b8afe7ade206534be68a4':
  SampleTable: fix integer overflow checks.

9 years agoam a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.
Wei Jia [Tue, 4 Aug 2015 16:47:48 +0000 (16:47 +0000)]
am a99d3d83: am 738a753a: SampleTable: fix integer overflow checks.

* commit 'a99d3d8327d60c8f8ef3e34fc4b81ef382e9e6d2':
  SampleTable: fix integer overflow checks.

9 years agoam 738a753a: SampleTable: fix integer overflow checks.
Wei Jia [Tue, 4 Aug 2015 16:40:31 +0000 (16:40 +0000)]
am 738a753a: SampleTable: fix integer overflow checks.

* commit '738a753a3ca7bf8f9f608ca941575626265294e4':
  SampleTable: fix integer overflow checks.

9 years agoam 98ee4c01: am 712090a6: am cfc12112: am ac7cb990: am b417986c: am d1c08d6b: am...
Joshua J. Drake [Tue, 4 Aug 2015 05:38:27 +0000 (05:38 +0000)]
am 98ee4c01: am 712090a6: am cfc12112: am ac7cb990: am b417986c: am d1c08d6b: am efa73c2e: am 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing

* commit '98ee4c01d3843c1973c399404b7166431eadedb9':
  Fix integer underflow in ESDS processing

9 years agoam 10f6b17a: am d053da7b: am a9f1e993: am 134dc311: am 80a6d9f3: am e10c2e62: am...
Joshua J. Drake [Tue, 4 Aug 2015 05:38:25 +0000 (05:38 +0000)]
am 10f6b17a: am d053da7b: am a9f1e993: am 134dc311: am 80a6d9f3: am e10c2e62: am 74ebcd65: am 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit '10f6b17a29f7d39303b4779929d15c540ee87290':
  Fix integer overflow during MP4 atom processing

9 years agoam 63e7ae97: am 45c12368: am b77a6189: am 4837e90f: am 9c5578c1: am 36617c67: am...
Joshua J. Drake [Tue, 4 Aug 2015 05:38:23 +0000 (05:38 +0000)]
am 63e7ae97: am 45c12368: am b77a6189: am 4837e90f: am 9c5578c1: am 36617c67: am 7374360f: am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks

* commit '63e7ae97369bf8b06337c51f8287654a94d11076':
  Fix several ineffective integer overflow checks

9 years agoSampleTable: fix integer overflow checks.
Wei Jia [Thu, 4 Jun 2015 17:40:23 +0000 (10:40 -0700)]
SampleTable: fix integer overflow checks.

Bug: 20139950
Bug: 22935234
(cherry picked from commit a105482ae577852ffd08ce88ae5d1ba81db875ac)

Change-Id: I408d261de1a6dd5c4343bcf3a7dfd8a259e0e2f3

9 years agoam 712090a6: am cfc12112: am ac7cb990: am b417986c: am d1c08d6b: am efa73c2e: am...
Joshua J. Drake [Tue, 4 Aug 2015 05:30:59 +0000 (05:30 +0000)]
am 712090a6: am cfc12112: am ac7cb990: am b417986c: am d1c08d6b: am efa73c2e: am 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing

* commit '712090a60253a2879e0c7d21a33f43534ffb51fc':
  Fix integer underflow in ESDS processing

9 years agoam d053da7b: am a9f1e993: am 134dc311: am 80a6d9f3: am e10c2e62: am 74ebcd65: am...
Joshua J. Drake [Tue, 4 Aug 2015 05:30:58 +0000 (05:30 +0000)]
am d053da7b: am a9f1e993: am 134dc311: am 80a6d9f3: am e10c2e62: am 74ebcd65: am 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit 'd053da7b4bb60290bf51052cc7abe070fd819479':
  Fix integer overflow during MP4 atom processing

9 years agoam 45c12368: am b77a6189: am 4837e90f: am 9c5578c1: am 36617c67: am 7374360f: am...
Joshua J. Drake [Tue, 4 Aug 2015 05:30:57 +0000 (05:30 +0000)]
am 45c12368: am b77a6189: am 4837e90f: am 9c5578c1: am 36617c67: am 7374360f: am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks

* commit '45c12368f1ced4c6783195432fdffdc7a3e36cca':
  Fix several ineffective integer overflow checks

9 years agoam cfc12112: am ac7cb990: am b417986c: am d1c08d6b: am efa73c2e: am 2e24d091: am...
Joshua J. Drake [Tue, 4 Aug 2015 04:55:58 +0000 (04:55 +0000)]
am cfc12112: am ac7cb990: am b417986c: am d1c08d6b: am efa73c2e: am 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing

* commit 'cfc121128aef10a98e5ad9162f43e3f368abd103':
  Fix integer underflow in ESDS processing

9 years agoam a9f1e993: am 134dc311: am 80a6d9f3: am e10c2e62: am 74ebcd65: am 272f4056: am...
Joshua J. Drake [Tue, 4 Aug 2015 04:55:55 +0000 (04:55 +0000)]
am a9f1e993: am 134dc311: am 80a6d9f3: am e10c2e62: am 74ebcd65: am 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit 'a9f1e993fa7849bc658d89a2faa58344faa88a5f':
  Fix integer overflow during MP4 atom processing

9 years agoam b77a6189: am 4837e90f: am 9c5578c1: am 36617c67: am 7374360f: am 4e44b2ee: am...
Joshua J. Drake [Tue, 4 Aug 2015 04:55:50 +0000 (04:55 +0000)]
am b77a6189: am 4837e90f: am 9c5578c1: am 36617c67: am 7374360f: am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks

* commit 'b77a6189a468a90fe74fafca862a31c3bf899ceb':
  Fix several ineffective integer overflow checks

9 years agoam ac7cb990: am b417986c: am d1c08d6b: am efa73c2e: am 2e24d091: am a59d5e66: am...
Joshua J. Drake [Tue, 4 Aug 2015 04:45:44 +0000 (04:45 +0000)]
am ac7cb990: am b417986c: am d1c08d6b: am efa73c2e: am 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing

* commit 'ac7cb990cc4c8a59a945ce36e5702e0adb213db4':
  Fix integer underflow in ESDS processing

9 years agoam 134dc311: am 80a6d9f3: am e10c2e62: am 74ebcd65: am 272f4056: am 52302d91: am...
Joshua J. Drake [Tue, 4 Aug 2015 04:45:42 +0000 (04:45 +0000)]
am 134dc311: am 80a6d9f3: am e10c2e62: am 74ebcd65: am 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit '134dc3110c401544e4d3a3a1deab1c131fb77720':
  Fix integer overflow during MP4 atom processing

9 years agoam 4837e90f: am 9c5578c1: am 36617c67: am 7374360f: am 4e44b2ee: am 4534ec1a: am...
Joshua J. Drake [Tue, 4 Aug 2015 04:45:41 +0000 (04:45 +0000)]
am 4837e90f: am 9c5578c1: am 36617c67: am 7374360f: am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks

* commit '4837e90fd1d3fa127ef99652d314ad70f4776221':
  Fix several ineffective integer overflow checks

9 years agoam b417986c: am d1c08d6b: am efa73c2e: am 2e24d091: am a59d5e66: am 8ef5da3d: am...
Joshua J. Drake [Tue, 4 Aug 2015 03:35:37 +0000 (03:35 +0000)]
am b417986c: am d1c08d6b: am efa73c2e: am 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing

* commit 'b417986c3a3a6bb9ca33657385a3433ff54090b2':
  Fix integer underflow in ESDS processing

9 years agoam 80a6d9f3: am e10c2e62: am 74ebcd65: am 272f4056: am 52302d91: am f354c48e: am...
Joshua J. Drake [Tue, 4 Aug 2015 03:35:36 +0000 (03:35 +0000)]
am 80a6d9f3: am e10c2e62: am 74ebcd65: am 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit '80a6d9f37571c89905b8ae4074529a960a5f2194':
  Fix integer overflow during MP4 atom processing

9 years agoam 9c5578c1: am 36617c67: am 7374360f: am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am...
Joshua J. Drake [Tue, 4 Aug 2015 03:35:34 +0000 (03:35 +0000)]
am 9c5578c1: am 36617c67: am 7374360f: am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks

* commit '9c5578c1a3bb00623d6ee99340ce0ce290e6c5a1':
  Fix several ineffective integer overflow checks

9 years agoam d1c08d6b: am efa73c2e: am 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix...
Joshua J. Drake [Tue, 4 Aug 2015 03:25:53 +0000 (03:25 +0000)]
am d1c08d6b: am efa73c2e: am 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing

* commit 'd1c08d6bff6d1936cf0e9cbfa5054128f5280ef3':
  Fix integer underflow in ESDS processing

9 years agoam e10c2e62: am 74ebcd65: am 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix...
Joshua J. Drake [Tue, 4 Aug 2015 03:25:52 +0000 (03:25 +0000)]
am e10c2e62: am 74ebcd65: am 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit 'e10c2e621a0a49618c9d69a7dd09400c23464ced':
  Fix integer overflow during MP4 atom processing

9 years agoam 36617c67: am 7374360f: am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix...
Joshua J. Drake [Tue, 4 Aug 2015 03:25:51 +0000 (03:25 +0000)]
am 36617c67: am 7374360f: am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks

* commit '36617c67a9c29d7f9798972b6514086b22b731f8':
  Fix several ineffective integer overflow checks

9 years agoam efa73c2e: am 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflo...
Joshua J. Drake [Tue, 4 Aug 2015 03:15:46 +0000 (03:15 +0000)]
am efa73c2e: am 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing

* commit 'efa73c2e5f5a4eb7c420b5920e00de5a69f525af':
  Fix integer underflow in ESDS processing

9 years agoam 74ebcd65: am 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow...
Joshua J. Drake [Tue, 4 Aug 2015 03:15:45 +0000 (03:15 +0000)]
am 74ebcd65: am 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit '74ebcd65d1833879944a496739da6983b1d18235':
  Fix integer overflow during MP4 atom processing

9 years agoam 7374360f: am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffect...
Joshua J. Drake [Tue, 4 Aug 2015 03:15:44 +0000 (03:15 +0000)]
am 7374360f: am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks

* commit '7374360f60999bfeabe0fb24e985073b7d8f47e8':
  Fix several ineffective integer overflow checks

9 years agoam 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS...
Joshua J. Drake [Tue, 4 Aug 2015 03:03:53 +0000 (03:03 +0000)]
am 2e24d091: am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing

* commit '2e24d0911ee585cbd447efe6150bafaaf8f9ef66':
  Fix integer underflow in ESDS processing

9 years agoam 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4...
Joshua J. Drake [Tue, 4 Aug 2015 03:03:52 +0000 (03:03 +0000)]
am 272f4056: am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit '272f4056162e119db61fb304b01f0152c07b8e02':
  Fix integer overflow during MP4 atom processing

9 years agoam 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer...
Joshua J. Drake [Tue, 4 Aug 2015 03:03:51 +0000 (03:03 +0000)]
am 4e44b2ee: am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks

* commit '4e44b2ee286bd993210aa81ad20ebbf1d1a816c6':
  Fix several ineffective integer overflow checks

9 years agoam a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing
Joshua J. Drake [Tue, 4 Aug 2015 02:56:01 +0000 (02:56 +0000)]
am a59d5e66: am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing

* commit 'a59d5e6692d0b0dc0924144f596d09e7dd2b193c':
  Fix integer underflow in ESDS processing

9 years agoam 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing
Joshua J. Drake [Tue, 4 Aug 2015 02:55:59 +0000 (02:55 +0000)]
am 52302d91: am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit '52302d917b06b11625b9de686153d1e2520f42cd':
  Fix integer overflow during MP4 atom processing

9 years agoam 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks
Joshua J. Drake [Tue, 4 Aug 2015 02:55:56 +0000 (02:55 +0000)]
am 4534ec1a: am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks

* commit '4534ec1a552c125ef7eea0990a84fcefb58335b9':
  Fix several ineffective integer overflow checks

9 years agoam 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing
Joshua J. Drake [Tue, 4 Aug 2015 02:50:52 +0000 (02:50 +0000)]
am 8ef5da3d: am 4dd7cb69: Fix integer underflow in ESDS processing

* commit '8ef5da3ddddd1bb4356d9cc6df4d52ad8afc4459':
  Fix integer underflow in ESDS processing

9 years agoam f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing
Joshua J. Drake [Tue, 4 Aug 2015 02:50:51 +0000 (02:50 +0000)]
am f354c48e: am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit 'f354c48e386d1405d67882c382e26e3e4598e797':
  Fix integer overflow during MP4 atom processing

9 years agoam 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks
Joshua J. Drake [Tue, 4 Aug 2015 02:50:45 +0000 (02:50 +0000)]
am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks

* commit '4a5fbf74b493eb293918c41a5b5f60dd7b8ebb58':
  Fix several ineffective integer overflow checks

9 years agoam 4dd7cb69: Fix integer underflow in ESDS processing
Joshua J. Drake [Tue, 4 Aug 2015 02:41:32 +0000 (02:41 +0000)]
am 4dd7cb69: Fix integer underflow in ESDS processing

* commit '4dd7cb699f49b56f94a32080fdac7f0ec8237ff4':
  Fix integer underflow in ESDS processing

9 years agoam 5c4428f6: Fix integer overflow during MP4 atom processing
Joshua J. Drake [Tue, 4 Aug 2015 02:41:31 +0000 (02:41 +0000)]
am 5c4428f6: Fix integer overflow during MP4 atom processing

* commit '5c4428f6391478ae983e1fcf7c42c832aa1a5e69':
  Fix integer overflow during MP4 atom processing

9 years agoam 3cc11bfc: Fix several ineffective integer overflow checks
Joshua J. Drake [Tue, 4 Aug 2015 02:41:30 +0000 (02:41 +0000)]
am 3cc11bfc: Fix several ineffective integer overflow checks

* commit '3cc11bfc00cbb3ed87a4464777a75606b4973b51':
  Fix several ineffective integer overflow checks

9 years agoFix integer underflow in ESDS processing
Joshua J. Drake [Thu, 9 Apr 2015 04:53:10 +0000 (23:53 -0500)]
Fix integer underflow in ESDS processing

Several arithmetic operations within parseESDescriptor could underflow, leading
to an out-of-bounds read operation. Ensure that subtractions from 'size' do not
cause it to wrap around.

Bug: 20139950
Change-Id: I0d1b136ce68fd7c6f606ce66714bf644cfb2961c
(cherry picked from commit 07c0f59d6c48874982d2b5c713487612e5af465a)

9 years agoFix integer overflow during MP4 atom processing
Joshua J. Drake [Thu, 9 Apr 2015 04:44:57 +0000 (23:44 -0500)]
Fix integer overflow during MP4 atom processing

A few sample table related FourCC values are handled by the
setSampleToChunkParams function. An integer overflow exists within this
function. Validate that mNumSampleToChunkOffets will not cause an integer
overflow.

Bug: 20139950
Change-Id: I1972cc185fce5e058afa143ad5eabcc269ad324d
(cherry picked from commit c24607c29c96f939aed9e33bfa702b1dd79da4b7)

9 years agoFix several ineffective integer overflow checks
Joshua J. Drake [Thu, 9 Apr 2015 04:23:55 +0000 (23:23 -0500)]
Fix several ineffective integer overflow checks

Commit edd4a76 (which addressed bugs 153287081534261515342751) added
several integer overflow checks. Unfortunately, those checks fail to take into
account integer promotion rules and are thus themselves subject to an integer
overflow. Cast the sizeof() operator to a uint64_t to force promotion while
multiplying.

Bug: 20139950
Change-Id: Ieb29a170edb805c722fc5658935f2390003e5260
(cherry picked from commit e2e812e58e8d2716b00d7d82db99b08d3afb4b32)

9 years agoam e6ca5b2d: am 566c70ca: Guard against codecinfo overflow
Marco Nelissen [Mon, 3 Aug 2015 20:12:12 +0000 (20:12 +0000)]
am e6ca5b2d: am 566c70ca: Guard against codecinfo overflow

* commit 'e6ca5b2d97f61e96af35fabed8c2ba352b8b5b99':
  Guard against codecinfo overflow

9 years agoam 566c70ca: Guard against codecinfo overflow
Marco Nelissen [Mon, 3 Aug 2015 20:03:38 +0000 (20:03 +0000)]
am 566c70ca: Guard against codecinfo overflow

* commit '566c70caff87c710e659c5aaad0692e031d93ded':
  Guard against codecinfo overflow

9 years agoGuard against codecinfo overflow
Marco Nelissen [Wed, 29 Jul 2015 23:15:55 +0000 (16:15 -0700)]
Guard against codecinfo overflow

Bug: 21296336
Change-Id: I78be5141b3108142f12d7cb94839fa50f776d84a

9 years agoam c655561b: (-s ours) am 29b83cbb: DO NOT MERGE - audio effects: fix heap overflow
Eric Laurent [Tue, 30 Jun 2015 18:21:44 +0000 (18:21 +0000)]
am c655561b: (-s ours) am 29b83cbb: DO NOT MERGE - audio effects: fix heap overflow

* commit 'c655561b3580ae7ba3a721e69ac240606e11fab8':
  DO NOT MERGE - audio effects: fix heap overflow

9 years agoam 13c925ca: am 6ff53b96: Merge "Prevent integer overflow when processing covr MPEG4...
Wei Jia [Tue, 30 Jun 2015 18:21:32 +0000 (18:21 +0000)]
am 13c925ca: am 6ff53b96: Merge "Prevent integer overflow when processing covr MPEG4 atoms" into klp-dev

* commit '13c925cab2decaed6786b0642f2b5a9f8516e71a':
  Prevent integer overflow when processing covr MPEG4 atoms

9 years agoam 29b83cbb: DO NOT MERGE - audio effects: fix heap overflow
Eric Laurent [Tue, 23 Jun 2015 01:32:08 +0000 (01:32 +0000)]
am 29b83cbb: DO NOT MERGE - audio effects: fix heap overflow

* commit '29b83cbb9018e53a18cf6e0fb34893f9774dcb96':
  DO NOT MERGE - audio effects: fix heap overflow

9 years agoDO NOT MERGE - audio effects: fix heap overflow
Eric Laurent [Fri, 19 Jun 2015 22:33:57 +0000 (15:33 -0700)]
DO NOT MERGE - audio effects: fix heap overflow

Check consistency of effect command reply sizes before
copying to reply address.

Also add null pointer check on reply size.
Also remove unused parameter warning.

Bug: 21953516.
Change-Id: I4cf00c12eaed696af28f3b7613f7e36f47a160c4

9 years agoaudio effects: fix heap overflow
Eric Laurent [Fri, 19 Jun 2015 22:33:57 +0000 (15:33 -0700)]
audio effects: fix heap overflow

Check consistency of effect command reply sizes before
copying to reply address.

Also add null pointer check on reply size.
Also remove unused parameter warning.

Bug: 21953516.
Change-Id: I4cf00c12eaed696af28f3b7613f7e36f47a160c4
(cherry picked from commit 0f714a464d2425afe00d6450535e763131b40844)

9 years agoresolved conflicts for merge of 1f44d837 to lmp-dev
Wei Jia [Sat, 6 Jun 2015 00:43:52 +0000 (17:43 -0700)]
resolved conflicts for merge of 1f44d837 to lmp-dev

Change-Id: Id60c2470ec2afebdbc1c0c995b90e294c9c879eb

9 years agoam f0e1fb59: am 4a492bf2: Fix integer underflow in covr MPEG4 processing
Joshua J. Drake [Fri, 5 Jun 2015 16:43:45 +0000 (16:43 +0000)]
am f0e1fb59: am 4a492bf2: Fix integer underflow in covr MPEG4 processing

* commit 'f0e1fb59f3ea24ce4f7f10d156bf8470a7236445':
  Fix integer underflow in covr MPEG4 processing

9 years agoam 6ff53b96: Merge "Prevent integer overflow when processing covr MPEG4 atoms" into...
Wei Jia [Fri, 5 Jun 2015 16:32:42 +0000 (16:32 +0000)]
am 6ff53b96: Merge "Prevent integer overflow when processing covr MPEG4 atoms" into klp-dev

* commit '6ff53b96235bf99cdc1023b99d44f1c4cade1c0a':
  Prevent integer overflow when processing covr MPEG4 atoms

9 years agoam 82e90e10: Merge "Fix integer overflow when handling MPEG4 tx3g atom" into klp-dev
Wei Jia [Fri, 5 Jun 2015 16:32:41 +0000 (16:32 +0000)]
am 82e90e10: Merge "Fix integer overflow when handling MPEG4 tx3g atom" into klp-dev

* commit '82e90e10481c334bb5f2cecf1621cb8f9308c21c':
  Fix integer overflow when handling MPEG4 tx3g atom

9 years agoam 4a492bf2: Fix integer underflow in covr MPEG4 processing
Joshua J. Drake [Fri, 5 Jun 2015 16:32:40 +0000 (16:32 +0000)]
am 4a492bf2: Fix integer underflow in covr MPEG4 processing

* commit '4a492bf2ac47b9844d2527e1fcdf0064c3d8d52e':
  Fix integer underflow in covr MPEG4 processing

9 years agoMerge "Prevent reading past the end of the buffer in 3GPP" into lmp-dev
Wei Jia [Fri, 5 Jun 2015 16:14:26 +0000 (16:14 +0000)]
Merge "Prevent reading past the end of the buffer in 3GPP" into lmp-dev

9 years agoMerge "Prevent integer overflow when processing covr MPEG4 atoms" into klp-dev
Wei Jia [Fri, 5 Jun 2015 16:13:54 +0000 (16:13 +0000)]
Merge "Prevent integer overflow when processing covr MPEG4 atoms" into klp-dev

9 years agoMerge "Fix integer overflow when handling MPEG4 tx3g atom" into klp-dev
Wei Jia [Fri, 5 Jun 2015 16:13:39 +0000 (16:13 +0000)]
Merge "Fix integer overflow when handling MPEG4 tx3g atom" into klp-dev

9 years agoPrevent integer underflow if size is below 6
Joshua J. Drake [Mon, 4 May 2015 22:57:24 +0000 (17:57 -0500)]
Prevent integer underflow if size is below 6

When processing 3GPP metadata, a subtraction operation may underflow and
lead to a rather large linear byteswap operation in the subsequent
framedata decoding code. Bound the 'size' value to prevent this from
occurring.

Bug: 20923261
Change-Id: I35dfbc8878c6b65cfe8b8adb7351a77ad4d604e5
(cherry picked from commit 9458e715d391ee8fe455fc31f07ff35ce12e0531)

9 years agoPrevent reading past the end of the buffer in 3GPP
Joshua J. Drake [Mon, 4 May 2015 22:33:49 +0000 (17:33 -0500)]
Prevent reading past the end of the buffer in 3GPP

Metadata processed within the parse3GPPMetaData function may not be NUL
terminated and thus calling setCString may read out of bounds. Ensure
proper NUL termination, but take care not to interfere with other special
cases (ie, albm).

Bug: 20923261
Change-Id: Ie93b3038b534b4c4460571a68f4d734cff7ad324
(cherry picked from commit 5cea0155cfc41f67e91343c342f44251c03fde3a)

9 years agoPrevent integer overflow when processing covr MPEG4 atoms
Joshua J. Drake [Mon, 4 May 2015 23:36:35 +0000 (18:36 -0500)]
Prevent integer overflow when processing covr MPEG4 atoms

If the 'chunk_data_size' value is SIZE_MAX, an integer overflow will occur
and cause an undersized buffer to be allocated. The following processing
then overfills the resulting memory and creates a potentially exploitable
condition. Ensure that integer overflow does not occur.

Bug: 20923261
Change-Id: I75cce323aec04a612e5a230ecd7c2077ce06035f

9 years agoFix integer overflow when handling MPEG4 tx3g atom
Joshua J. Drake [Mon, 4 May 2015 23:29:08 +0000 (18:29 -0500)]
Fix integer overflow when handling MPEG4 tx3g atom

When the sum of the 'size' and 'chunk_size' variables is larger than 2^32,
an integer overflow occurs. Using the result value to allocate memory
leads to an undersized buffer allocation and later a potentially
exploitable heap corruption condition. Ensure that integer overflow does
not occur.

Bug: 20923261
Change-Id: Id050a36b33196864bdd98b5ea24241f95a0b5d1f

9 years agoFix integer underflow in covr MPEG4 processing
Joshua J. Drake [Mon, 4 May 2015 22:14:11 +0000 (17:14 -0500)]
Fix integer underflow in covr MPEG4 processing

When the 'chunk_data_size' variable is less than 'kSkipBytesOfDataBox', an
integer underflow can occur. This causes an extraordinarily large value to
be passed to MetaData::setData, leading to a buffer overflow.

Bug: 20923261
Change-Id: Icd28f63594ad941eabb3a12c750a4a2d5d2bf94b

9 years agoIOMX: Clear buffer id for arm32
Andy Hung [Wed, 27 May 2015 21:18:26 +0000 (14:18 -0700)]
IOMX: Clear buffer id for arm32

Initial counter needs to be cleared for ease of debugging.

Bug: 20634516
Change-Id: I4131d759b9cc296bbecf25a53433d42b22ef228f
(cherry picked from commit 9113c1e619fd78fe53b548180fdc02300d33303d)

9 years agoam 9d038ba4: (-s ours) am 0e27e080: DO NOT MERGE - IOMX: Add buffer range check to...
Andy Hung [Wed, 27 May 2015 02:23:57 +0000 (02:23 +0000)]
am 9d038ba4: (-s ours) am 0e27e080: DO NOT MERGE - IOMX: Add buffer range check to emptyBuffer

* commit '9d038ba466df9179f1ec0d2b58dcabf19761bf24':
  DO NOT MERGE - IOMX: Add buffer range check to emptyBuffer

9 years agoam 0e27e080: DO NOT MERGE - IOMX: Add buffer range check to emptyBuffer
Andy Hung [Wed, 27 May 2015 02:10:59 +0000 (02:10 +0000)]
am 0e27e080: DO NOT MERGE - IOMX: Add buffer range check to emptyBuffer

* commit '0e27e080c255b23b4b0e19cb3bc9519cc162b73f':
  DO NOT MERGE - IOMX: Add buffer range check to emptyBuffer

9 years agoMerge "IOMX: Enable buffer ptr to buffer id translation for arm32" into lmp-dev
Andy Hung [Wed, 27 May 2015 01:31:28 +0000 (01:31 +0000)]
Merge "IOMX: Enable buffer ptr to buffer id translation for arm32" into lmp-dev

9 years agoDO NOT MERGE - IOMX: Add buffer range check to emptyBuffer
Andy Hung [Tue, 26 May 2015 18:14:36 +0000 (11:14 -0700)]
DO NOT MERGE - IOMX: Add buffer range check to emptyBuffer

Bug: 20634516
Change-Id: If351dbd573bb4aeb6968bfa33f6d407225bc752c

9 years agoIOMX: Enable buffer ptr to buffer id translation for arm32
Andy Hung [Tue, 26 May 2015 18:32:13 +0000 (11:32 -0700)]
IOMX: Enable buffer ptr to buffer id translation for arm32

Bug: 20634516
Change-Id: Iac9eac3cb251eccd9bbad5df7421a07edc21da0c
(cherry picked from commit 2d6b6601743c3c6960c6511a2cb774ef902759f4)

9 years agoIOMX: Add buffer range check to emptyBuffer
Andy Hung [Tue, 26 May 2015 18:14:36 +0000 (11:14 -0700)]
IOMX: Add buffer range check to emptyBuffer

Bug: 20634516
Change-Id: If351dbd573bb4aeb6968bfa33f6d407225bc752c
(cherry picked from commit d971df0eb300356b3c995d533289216f43aa60de)

9 years agoam 96a41a2b: (-s ours) am dbe6c320: HDCP: buffer over flow check -- DO NOT MERGE
Chong Zhang [Thu, 14 May 2015 23:31:16 +0000 (23:31 +0000)]
am 96a41a2b: (-s ours) am dbe6c320: HDCP: buffer over flow check -- DO NOT MERGE

* commit '96a41a2ba5985aeb9163923f54d84cdaa3d0363d':
  HDCP: buffer over flow check -- DO NOT MERGE

9 years agoam dbe6c320: HDCP: buffer over flow check -- DO NOT MERGE
Chong Zhang [Thu, 14 May 2015 23:17:08 +0000 (23:17 +0000)]
am dbe6c320: HDCP: buffer over flow check -- DO NOT MERGE

* commit 'dbe6c320b414d8139c46aaf880d5f154ef4f9af8':
  HDCP: buffer over flow check -- DO NOT MERGE

9 years agoHDCP: buffer over flow check -- DO NOT MERGE
Chong Zhang [Tue, 28 Apr 2015 01:38:17 +0000 (18:38 -0700)]
HDCP: buffer over flow check -- DO NOT MERGE

bug: 20222489
Change-Id: I3a64a5999d68ea243d187f12ec7717b7f26d93a3
(cherry picked from commit 532cd7b86a5fdc7b9a30a45d8ae2d16ef7660a72)

9 years agoHDCP: buffer over flow check -- DO NOT MERGE
Chong Zhang [Tue, 28 Apr 2015 01:38:17 +0000 (18:38 -0700)]
HDCP: buffer over flow check -- DO NOT MERGE

bug: 20222489
Change-Id: I3a64a5999d68ea243d187f12ec7717b7f26d93a3
(cherry picked from commit 532cd7b86a5fdc7b9a30a45d8ae2d16ef7660a72)

9 years agoMerge "Add AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes" into...
Lajos Molnar [Tue, 12 May 2015 21:45:35 +0000 (21:45 +0000)]
Merge "Add AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes" into lmp-dev

9 years agoam a3e8f60f: (-s ours) am 7acac10a: Merge "DO NOT MERGE: Add AUtils::isInRange, and...
Robert Shih [Mon, 11 May 2015 11:19:37 +0000 (11:19 +0000)]
am a3e8f60f: (-s ours) am 7acac10a: Merge "DO NOT MERGE: Add AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes" into klp-dev

* commit 'a3e8f60f5e409f65f12636df5fad7f20ff736df5':
  DO NOT MERGE: Add AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes

9 years agoam 7acac10a: Merge "DO NOT MERGE: Add AUtils::isInRange, and use it to detect malform...
Robert Shih [Mon, 11 May 2015 11:10:36 +0000 (11:10 +0000)]
am 7acac10a: Merge "DO NOT MERGE: Add AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes" into klp-dev

* commit '7acac10aae34da5ae4d628c5a270e7e3e94f7598':
  DO NOT MERGE: Add AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes

9 years agoMerge "DO NOT MERGE: Add AUtils::isInRange, and use it to detect malformed MPEG4...
Robert Shih [Mon, 11 May 2015 03:00:49 +0000 (03:00 +0000)]
Merge "DO NOT MERGE: Add AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes" into klp-dev

9 years agoam 5a75b421: am 30d77e2c: Fix potential buffer overrun
Marco Nelissen [Thu, 7 May 2015 15:33:19 +0000 (15:33 +0000)]
am 5a75b421: am 30d77e2c: Fix potential buffer overrun

* commit '5a75b4215821d633af18dd8dae2495299c070bf0':
  Fix potential buffer overrun

9 years agoam 30d77e2c: Fix potential buffer overrun
Marco Nelissen [Thu, 7 May 2015 15:02:30 +0000 (15:02 +0000)]
am 30d77e2c: Fix potential buffer overrun

* commit '30d77e2c75c1973f9fb363717af92cf640685da3':
  Fix potential buffer overrun

9 years agoFix potential buffer overrun
Marco Nelissen [Fri, 1 May 2015 23:18:26 +0000 (16:18 -0700)]
Fix potential buffer overrun

The "samples" parameter indicates the max number of sample tuples, not
the max number of samples.

Bug: 16183063
Change-Id: I5347497bbbe65910b8489d354e985ebc90d65516

9 years agoDO NOT MERGE: Add AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes
Lajos Molnar [Thu, 2 Apr 2015 02:32:25 +0000 (19:32 -0700)]
DO NOT MERGE: Add AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes

Bug: 19641538
Change-Id: I5aae3f100846c125decc61eec7cd6563e3f33777

9 years agoAdd AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes
Lajos Molnar [Thu, 2 Apr 2015 02:32:25 +0000 (19:32 -0700)]
Add AUtils::isInRange, and use it to detect malformed MPEG4 nal sizes

Bug: 19641538
Change-Id: I5aae3f100846c125decc61eec7cd6563e3f33777

9 years agoAdd some sanity checks
Marco Nelissen [Mon, 20 Apr 2015 18:08:59 +0000 (11:08 -0700)]
Add some sanity checks

Bug: 19400722
Change-Id: Ib3afdf73fd4647eeea5721c61c8b72dbba0647f6

9 years agoam b919a3a3: am 64290793: Merge "Fix integer underflow in ESDS processing" into klp-dev
Nick Kralevich [Fri, 10 Apr 2015 23:44:36 +0000 (23:44 +0000)]
am b919a3a3: am 64290793: Merge "Fix integer underflow in ESDS processing" into klp-dev

* commit 'b919a3a3d38c4b1cbb378c38cc6154a81ebe01c7':
  Fix integer underflow in ESDS processing

9 years agoam 47759307: am 17b625b7: Merge "Fix integer overflow during MP4 atom processing...
Nick Kralevich [Fri, 10 Apr 2015 23:44:35 +0000 (23:44 +0000)]
am 47759307: am 17b625b7: Merge "Fix integer overflow during MP4 atom processing" into klp-dev

* commit '4775930799bd9a9fbad8efe5d338e890dd7444ed':
  Fix integer overflow during MP4 atom processing

9 years agoam 4a131250: am 030d8d0a: Fix several ineffective integer overflow checks
Joshua J. Drake [Fri, 10 Apr 2015 23:44:30 +0000 (23:44 +0000)]
am 4a131250: am 030d8d0a: Fix several ineffective integer overflow checks

* commit '4a13125033f2130cadb4c48b3e6e0085d8c98829':
  Fix several ineffective integer overflow checks

9 years agoam 64290793: Merge "Fix integer underflow in ESDS processing" into klp-dev
Nick Kralevich [Fri, 10 Apr 2015 23:34:59 +0000 (23:34 +0000)]
am 64290793: Merge "Fix integer underflow in ESDS processing" into klp-dev

* commit '6429079345404932c5be5956efc7154390d2ed0e':
  Fix integer underflow in ESDS processing

9 years agoam 17b625b7: Merge "Fix integer overflow during MP4 atom processing" into klp-dev
Nick Kralevich [Fri, 10 Apr 2015 23:34:57 +0000 (23:34 +0000)]
am 17b625b7: Merge "Fix integer overflow during MP4 atom processing" into klp-dev

* commit '17b625b7f51b75fde6640c737474b8b2c51412bf':
  Fix integer overflow during MP4 atom processing

9 years agoam 030d8d0a: Fix several ineffective integer overflow checks
Joshua J. Drake [Fri, 10 Apr 2015 23:34:56 +0000 (23:34 +0000)]
am 030d8d0a: Fix several ineffective integer overflow checks

* commit '030d8d0a557097b88d6ecbf6d04823213512b620':
  Fix several ineffective integer overflow checks

9 years agoMerge "Fix integer underflow in ESDS processing" into klp-dev
Nick Kralevich [Fri, 10 Apr 2015 23:16:02 +0000 (23:16 +0000)]
Merge "Fix integer underflow in ESDS processing" into klp-dev

9 years agoMerge "Fix integer overflow during MP4 atom processing" into klp-dev
Nick Kralevich [Fri, 10 Apr 2015 23:15:52 +0000 (23:15 +0000)]
Merge "Fix integer overflow during MP4 atom processing" into klp-dev

9 years agoFix integer underflow in ESDS processing
Joshua J. Drake [Thu, 9 Apr 2015 04:53:10 +0000 (23:53 -0500)]
Fix integer underflow in ESDS processing

Several arithmetic operations within parseESDescriptor could underflow, leading
to an out-of-bounds read operation. Ensure that subtractions from 'size' do not
cause it to wrap around.

Bug: 20139950

(cherry picked from commit 07c0f59d6c48874982d2b5c713487612e5af465a)

Change-Id: I377d21051e07ca654ea1f7037120429d3f71924a

9 years agoFix integer overflow during MP4 atom processing
Joshua J. Drake [Thu, 9 Apr 2015 04:44:57 +0000 (23:44 -0500)]
Fix integer overflow during MP4 atom processing

A few sample table related FourCC values are handled by the
setSampleToChunkParams function. An integer overflow exists within this
function. Validate that mNumSampleToChunkOffets will not cause an integer
overflow.

Bug: 20139950

(cherry picked from commit c24607c29c96f939aed9e33bfa702b1dd79da4b7)

Change-Id: I49086952451b09a234d8b82669251ab9f1ef58d9