OSDN Git Service
Srinivas Pandruvada [Wed, 19 Mar 2014 16:56:00 +0000 (16:56 +0000)]
iio: ak8975: Added ACPI enumeration
Added capability so that this device can be enumerated via ACPI.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Srinivas Pandruvada [Wed, 19 Mar 2014 16:56:00 +0000 (16:56 +0000)]
iio: ak8975 : Add AK8963 compatibility mode support
AK8963 and AK8975 use same register definitions, except the range
of X,Y,Z values. Added support of 8963 based on i2c_device_id.
Unfortunately there is no way to detect the type via registers,
both device registers return 0x48 as id of chipset.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Jonathan Cameron [Fri, 3 Jan 2014 22:08:00 +0000 (22:08 +0000)]
iio:gyro:itg3200 - drop unreachable return ret. Highlighted by smatch
CHECK drivers/iio/gyro/itg3200_core.c
drivers/iio/gyro/itg3200_core.c:114 itg3200_read_raw() info: ignoring unreachable code.
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Cc: Neil Brown <neilb@suse.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Jonathan Cameron [Fri, 3 Jan 2014 22:24:00 +0000 (22:24 +0000)]
iio:core: Fix bug in length of event info_mask and catch unhandled bits set in masks.
The unhandled bits case was highlighted by smatch:
CHECK drivers/iio/industrialio-core.c
drivers/iio/industrialio-core.c:719 iio_device_add_info_mask_type() error: buffer overflow 'iio_chan_info_postfix' 17 <= 31
CC [M] drivers/iio/industrialio-core.o
CHECK drivers/iio/industrialio-event.c
drivers/iio/industrialio-event.c:327 iio_device_add_event() error: buffer overflow 'iio_ev_info_text' 3 <= 3
The incorrect limit for the for_each_set_bit loop was noticed whilst fixing
this other case. Note that as we only have 3 possible entries a the moment
and the value was set to 4, the bug would not have any effect currently.
It will bite fairly soon though, so best fix it now.
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Angelo Compagnucci [Sun, 3 Aug 2014 22:22:00 +0000 (23:22 +0100)]
Add support for Microchip Technology's MCP3426/7/8 ADC
This patch extends previous mcp3422 driver to support
missing members of the family, mcp3426/7/8.
Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Lars-Peter Clausen [Fri, 3 Oct 2014 09:31:00 +0000 (10:31 +0100)]
staging:iio: Move ad799x driver out of staging
The driver is now at a reasonable quality level. Move it out of staging.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Lars-Peter Clausen [Fri, 3 Oct 2014 09:31:00 +0000 (10:31 +0100)]
staging:iio:ad799x: Move ring functions to the main file
The ad799x_ring.c file is pretty much only one function these days. No need to
keep it in a separate file. Since there is then only one user of the header left
also move everything from the header to the main file.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Sebastian Reichel [Fri, 3 Oct 2014 16:25:00 +0000 (17:25 +0100)]
iio: inkern: add iio_read_channel_average_raw
Add iio_read_channel_average_raw to support reading
averaged raw values in consumer drivers.
Signed-off-by: Sebastian Reichel <sre@debian.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Sebastian Reichel [Fri, 3 Oct 2014 16:25:00 +0000 (17:25 +0100)]
iio: documentation: Add ABI documentation for *_mean_raw
Add ABI documentation for in_*_mean_raw files, which are
already supported and used in the kernel for some time.
Signed-off-by: Sebastian Reichel <sre@debian.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Matt Ranostay [Wed, 3 Dec 2014 12:53:00 +0000 (12:53 +0000)]
iio: Add AS3935 lightning sensor support
AS3935 chipset can detect lightning strikes and reports those back as
events and the estimated distance to the storm.
Signed-off-by: Matt Ranostay <mranostay@gmail.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Matt Ranostay [Wed, 3 Dec 2014 12:53:00 +0000 (12:53 +0000)]
iio:as3935: Add DT binding docs for AS3935 driver
Document compatible string, required and optional DT properties for
AS3935 chipset driver.
Signed-off-by: Matt Ranostay <mranostay@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Kees Cook [Thu, 13 Mar 2014 16:46:00 +0000 (16:46 +0000)]
iio: force snprintf for PAGE_SIZE bufs
This is a tiny preventative measure to make sure we can't write beyond
PAGE_SIZE on the buffers being used in sysfs for iio. There is currently
no way for this to happen, but the change makes this code more robust
for the future.
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Chi Pham [Wed, 12 Mar 2014 15:36:19 +0000 (16:36 +0100)]
staging: cxt1e1: Removed assignments from if statements.
Assignments removed from if statements.
Fixed checkpatch warning such as indentation and negative error returns in
adjacent code.
Coccinelle was used for this patch. The following script found the match:
@simple@
expression E1, E2;
statement S1, S2;
@@
+ E1 = E2;
if (
- (E1 = E2)
+ E1
)
S1 else S2
@left@
expression E0, E1, E2;
statement S1, S2;
@@
+ E1 = E2;
if (
- (E1 = E2)
+ E1
== E0
)
S1 else S2
Signed-off-by: Chi Pham <fempsci@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Andreea-Cristina Bernat [Wed, 12 Mar 2014 20:50:01 +0000 (22:50 +0200)]
staging: lirc: Add fallthrough comment
This patch adds fallthrough comments for the cases not preceded by
break or fallthrough comment
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Himangi Saraogi [Wed, 12 Mar 2014 20:04:39 +0000 (01:34 +0530)]
staging:lustre: Fix Sparse Warning for Static Declarations in console.c
This patch fixes the following Sparse warnings in console.c :
drivers/staging/lustre/lnet/selftest/console.c:65:1: warning: symbol 'lstcon_node_get' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:118:1: warning: symbol 'lstcon_node_put' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:348:1: warning: symbol 'lstcon_sesrpc_condition' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:377:1: warning: symbol 'lstcon_sesrpc_readent' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:834:1: warning: symbol 'lstcon_batch_find' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:1002:1: warning: symbol 'lstcon_batrpc_condition' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:1145:1: warning: symbol 'lstcon_testrpc_condition' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:1374:1: warning: symbol 'lstcon_test_find' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:1389:1: warning: symbol 'lstcon_tsbrpc_readent' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:1468:1: warning: symbol 'lstcon_statrpc_readent' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:1492:1: warning: symbol 'lstcon_ndlist_stat' was not declared. Should it be static?
drivers/staging/lustre/lnet/selftest/console.c:1581:1: warning: symbol 'lstcon_debug_ndlist' was not declared. Should it be static?
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Gulsah Kose [Wed, 12 Mar 2014 19:13:53 +0000 (21:13 +0200)]
staging: rts5208: Remove unnecessary parentheses.
Return is not a method and doesn't need parentheses. Removed unnecaasary
parentheses.
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Himangi Saraogi [Wed, 12 Mar 2014 19:12:46 +0000 (00:42 +0530)]
staging:comedi: Fix sparse warnings of incorrect type in assignment
This patch fixes the following sparse warnings:
drivers/staging/comedi/drivers/mite.c:343:44: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/mite.c:343:44: expected unsigned int [unsigned] [usertype] count
drivers/staging/comedi/drivers/mite.c:343:44: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/mite.c:344:43: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/mite.c:344:43: expected unsigned int [unsigned] [usertype] addr
drivers/staging/comedi/drivers/mite.c:344:43: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/mite.c:346:43: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/mite.c:346:43: expected unsigned int [unsigned] [usertype] next
drivers/staging/comedi/drivers/mite.c:346:43: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/mite.c:351:45: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/mite.c:351:45: expected unsigned int [unsigned] [usertype] next
drivers/staging/comedi/drivers/mite.c:351:45: got restricted __le32 [usertype] <noident>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Gulsah Kose [Wed, 12 Mar 2014 19:01:48 +0000 (21:01 +0200)]
staging: rts5208: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in rtsx.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Andreea-Cristina Bernat [Wed, 12 Mar 2014 21:00:04 +0000 (23:00 +0200)]
staging: rtl8712: Delete space before semicolon
This patch solves the warning: "space prohibited before semicolon".
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Himangi Saraogi [Wed, 12 Mar 2014 19:25:20 +0000 (00:55 +0530)]
staging:rtl8187se: Fix sparse warning in right shift
This patch fixes the following sparse warning:
drivers/staging/rtl8187se/r8180_core.c:1328:40: warning: right shift by bigger than source value
by adding parenthesis.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Andreea-Cristina Bernat [Wed, 12 Mar 2014 20:04:46 +0000 (22:04 +0200)]
/staging/vt6656: Delete extra paranthesis from macro definition
This patch solves the error of checkpatch.pl by deleting the extra paranthesis.
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Himangi Saraogi [Wed, 12 Mar 2014 18:37:16 +0000 (00:07 +0530)]
staging:rtl8187se:ieee80211: Fix sparse warning of cast to restricted __le16
This patch fixes the following sparse warnings:
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c:496:17: warning: cast to restricted __le16
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c:540:12: warning: cast to restricted __le16
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c:586:12: warning: cast to restricted __le16
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Elena Oat [Wed, 12 Mar 2014 10:19:25 +0000 (12:19 +0200)]
Staging: rtl8188eu: Fix sparse warnings.
This patch fixes following warnings produced by sparse:
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3867:31: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3867:31: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38: expected void const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3897:9: warning: cast
removes address space of expression
While at it, I have also fixed the warnings of lines over 80 characters.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Gulsah Kose [Tue, 11 Mar 2014 22:55:34 +0000 (00:55 +0200)]
staging: rtl8712: Remove unnecessary parentheses.
Remove unnecessary parentheses from rtl871x_cmd.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Iulia Manda [Tue, 11 Mar 2014 23:28:53 +0000 (01:28 +0200)]
staging: unisys: visorutil: Use kzalloc instead of kmalloc with memset
Fix coccinelle warnings of better allocation by using kzalloc.
In these cases, kzalloc is preferred, as kmalloc may fail if it does not find
contiguous memory.
Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Iulia Manda [Tue, 11 Mar 2014 18:14:36 +0000 (20:14 +0200)]
staging: android: ion: Use ERR_CAST instead of ERR_PTR
Fix the following coccinelle warnings in ion.c:
drivers/staging/android/ion/ion.c:511:9-16: WARNING: ERR_CAST can be used with buffer
drivers/staging/android/ion/ion.c:218:9-16: WARNING: ERR_CAST can be used with table
drivers/staging/android/ion/ion.c:1150:9-16: WARNING: ERR_CAST can be used with dmabuf
Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Iulia Manda [Tue, 11 Mar 2014 18:12:29 +0000 (20:12 +0200)]
staging: android: ion: Replace seq_printf with seq_puts
It is preferred to use seq_puts instead of seq_printf here, as it suffices string printing.
Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Iulia Manda [Tue, 11 Mar 2014 18:10:37 +0000 (20:10 +0200)]
staging: android: ion: Fix quoted string split across lines
Join strings from two separated lines, even if this makes line longer than 80
characters.
Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Kristina Martšenko [Tue, 11 Mar 2014 18:58:14 +0000 (20:58 +0200)]
staging: rtl8188eu: explicitly convert from __le16 to integer
BA_para_set (of type __le16) is implicitly cast into an integer for
bitwise operations, after which the result is converted back into a
__le16. Make the initial cast explicit to make the code clearer. In
addition, refactor the code for readability.
This also removes five sparse warnings of the following type:
drivers/staging/rtl8188eu//core/rtw_mlme_ext.c:6114:70: warning: restricted __le16 degrades to integer
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Andreea-Cristina Bernat [Tue, 11 Mar 2014 16:46:07 +0000 (18:46 +0200)]
staging/media/solo6x10: Fix coding-style error
This patch fixes the error "space required after that ';'" for
the file /drivers/staging/media/solo6x10/solo6x10-tx28.c
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ashley Smith [Tue, 11 Mar 2014 16:27:23 +0000 (12:27 -0400)]
staging: vt6655 : Fix placement of open brace
This patch fixes the checkpatch warning "that open brace { should be on
the previous line" for a non-function statement block.
Signed-off-by: Ashley Smith <ashley@eclipso.ch>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Iulia Manda [Thu, 13 Mar 2014 23:17:03 +0000 (16:17 -0700)]
Staging: dgnc: fix indentation in dgnc_mgmt.c
Align test parts in if statement on separate lines.
Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Himangi Saraogi [Tue, 11 Mar 2014 06:52:28 +0000 (12:22 +0530)]
staging:cxt1e1:remove unused code with #if 0
The functions musycc_del_chan and musycc_del_chan_stats
are not being used at the moment and may not be required.
Remove them for now (with #if 0) till it is decided whether
it is really required.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Elena Oat [Tue, 11 Mar 2014 06:45:29 +0000 (08:45 +0200)]
Staging: rtl8188eu: Fix warning of unchecked sscanf return value.
This patch fixes the warnings produced by checkpatch "unchecked sscanf
return value" in file ioctl_linux.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ana Rey [Mon, 10 Mar 2014 18:18:14 +0000 (19:18 +0100)]
staging: rtl8187se: Fix braces in ieee80211/ieee80211_crypt_tkip.c
This patch fixes braces errors as the codingStyle of the kernel
recommends.
Thus, this patch fixes these errors and warning messages found by
checkpatch.pl:
WARNING: braces {} are not necessary for single statement blocks
ERROR: that open brace { should be on the previous line
Signed-off-by: Ana Rey <anarey@gmail.com>
Reviewed-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ana Rey [Mon, 10 Mar 2014 18:18:13 +0000 (19:18 +0100)]
staging: rtl8187se: Fix whitespaces in ieee80211/ieee80211_crypt_tkip.c
This patch fixes whitespaces as the codingStyle of the kernel
recommends.
Thus, this patch fixes these errors found by checkpatch.pl:
ERROR: space required before the open parenthesis '('
ERROR: space required before that '*' (ctx:OxV)
ERROR: spaces required around that '=' (ctx:VxW)
Signed-off-by: Ana Rey <anarey@gmail.com>
Reviewed-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ana Rey [Mon, 10 Mar 2014 18:13:19 +0000 (19:13 +0100)]
staging: rtl8187se: Deleted rtl8225z2_rf_set_mode function
After the next warning messages by sparse tools:
drivers/staging/rtl8187se/r8180_rtl8225z2.c:609:6: warning: symbol 'rtl8225z2_rf_set_mode' was not declared. Should it be static?
drivers/staging/rtl8187se/r8180_rtl8225z2.c:609:13: warning: ‘rtl8225z2_rf_set_mode’ defined but not used [-Wunused-function]
static void rtl8225z2_rf_set_mode(struct net_device *dev)
And the next search:
~/opw/dev/staging/drivers/staging/rtl8187se
(staging-next) $ git grep rtl8225z2_rf_set_mode
r8180_rtl8225z2.c:void rtl8225z2_rf_set_mode(struct net_device *dev)
I decided to delete rtl8225z2_rf_set_mode function.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ana Rey [Mon, 10 Mar 2014 18:10:25 +0000 (19:10 +0100)]
staging: rtl8187se: Delete commented code in r8180.h
This patch deletes all commented code in r8180.h that is not necessary.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ana Rey [Mon, 10 Mar 2014 18:10:24 +0000 (19:10 +0100)]
staging: rtl8187se: Convert _RT_PS_MODE typedef into an enum
The Documentation/CodingStyle doesn't recommend the use of typedef,
convert this into an enum.
While at it, I have also renamed the variable names that were used in
this typedef not to use Hungarian notation.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ana Rey [Mon, 10 Mar 2014 18:10:23 +0000 (19:10 +0100)]
staging: rtl8187se: Delete typedef _LED_CTL_MODE
The typedef _LED_CTL_MODE (and the enum constants) is not used in the driver.
I delete it.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Himangi Saraogi [Mon, 10 Mar 2014 10:35:27 +0000 (16:05 +0530)]
staging:wlan-ng:Fix sparse warning
This patch fixes the sparse warning -
drivers/staging/wlan-ng/p80211netdev.c:289:38: warning: cast to restricted __le16
by eliminating the variable fc as it is not required.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Ana Rey [Mon, 10 Mar 2014 17:56:47 +0000 (18:56 +0100)]
staging: rtl8187se: Convert _RT_RF_POWER_STATE typedef into an enum
The Documentation/CodingStyle doesn't recommend the use of typedef,
convert this to an enum.
While at it, I have also renamed the variable names that were used in
this typedef not to use Hungarian notation.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ana Rey [Mon, 10 Mar 2014 17:56:46 +0000 (18:56 +0100)]
staging: rtl8187se: Convert _LED_STRATEGY_8185 typedef into an enum
The Documentation/CodingStyle doesn't recommend the use of typedef,
convert this into an enum.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ana Rey [Mon, 10 Mar 2014 17:56:45 +0000 (18:56 +0100)]
staging: rtl8187se: Convert nic_t typedef into an enum
The Documentation/CodingStyle doesn't recommend the use of typedef,
convert this to enum.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ana Rey [Mon, 10 Mar 2014 17:56:44 +0000 (18:56 +0100)]
staging: rtl8187se: Convert _WIRELESS_MODE into a enum.
The Documentation/CodingStyle doesn't recommend the use of typedef,
convert this to enum.
While at it, I have also renamed the variable names that were used in
this typedef not to use Hungarian notation.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Greg Kroah-Hartman [Thu, 13 Mar 2014 03:01:12 +0000 (03:01 +0000)]
Merge branch 'for-greg' of git://git./linux/kernel/git/ppwaskie/staging into opw
Jérôme Pinot [Thu, 13 Mar 2014 01:17:17 +0000 (10:17 +0900)]
staging/ozwpan: formatting coding style
This fixes the following spacing issues detected by checkpatch.pl:
WARNING: line over 80 characters
#357: FILE: drivers/staging/ozwpan/ozhcd.c:357:
+static struct oz_urb_link *oz_uncancel_urb(struct oz_hcd *ozhcd, struct urb *urb)
ERROR: trailing whitespace
#25: FILE: drivers/staging/ozwpan/ozpd.h:25:
+/* $
Signed-off-by: Jerome Pinot <ngc891@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jérôme Pinot [Thu, 13 Mar 2014 01:20:55 +0000 (10:20 +0900)]
staging/ozwpan: coding style __constant_
This fixes the following issues detected by checkpatch.pl:
WARNING: __constant_cpu_to_le16 should be cpu_to_le16
#1991: FILE: drivers/staging/ozwpan/ozhcd.c:1991:
+ __constant_cpu_to_le16(0x0001);
WARNING: __constant_cpu_to_le32 should be cpu_to_le32
#2185: FILE: drivers/staging/ozwpan/ozhcd.c:2185:
+ put_unaligned(__constant_cpu_to_le32(0), (__le32 *)buf);
WARNING: __constant_htons should be htons
#675: FILE: drivers/staging/ozwpan/ozproto.c:675:
+ binding->ptype.type = __constant_htons(OZ_ETHERTYPE);
Signed-off-by: Jerome Pinot <ngc891@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Mon, 10 Mar 2014 17:53:18 +0000 (23:23 +0530)]
staging:comedi: Fix sparse warnings
This patch fixes the following sparse warnings:
drivers/staging/comedi/drivers/gsc_hpdi.c:367:53: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/gsc_hpdi.c:367:53: expected unsigned int volatile [unsigned] [usertype] pci_start_addr
drivers/staging/comedi/drivers/gsc_hpdi.c:367:53: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/gsc_hpdi.c:370:55: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/gsc_hpdi.c:370:55: expected unsigned int volatile [unsigned] [usertype] local_start_addr
drivers/staging/comedi/drivers/gsc_hpdi.c:370:55: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/gsc_hpdi.c:371:52: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/gsc_hpdi.c:371:52: expected unsigned int volatile [unsigned] [usertype] transfer_size
drivers/staging/comedi/drivers/gsc_hpdi.c:371:52: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/gsc_hpdi.c:373:43: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/gsc_hpdi.c:373:43: expected unsigned int volatile [unsigned] [usertype] next
drivers/staging/comedi/drivers/gsc_hpdi.c:373:43: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/gsc_hpdi.c:390:39: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/gsc_hpdi.c:390:39: expected unsigned int volatile [unsigned] [usertype] next
drivers/staging/comedi/drivers/gsc_hpdi.c:390:39: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/gsc_hpdi.c:704:15: warning: cast to restricted __le32
drivers/staging/comedi/drivers/gsc_hpdi.c:707:15: warning: cast to restricted __le32
drivers/staging/comedi/drivers/cb_pcidas64.c:1495:56: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:1495:56: expected unsigned int volatile [unsigned] [usertype] pci_start_addr
drivers/staging/comedi/drivers/cb_pcidas64.c:1495:56: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:1498:66: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:1498:66: expected unsigned int volatile [unsigned] [usertype] local_start_addr
drivers/staging/comedi/drivers/cb_pcidas64.c:1498:66: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:1502:66: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:1502:66: expected unsigned int volatile [unsigned] [usertype] local_start_addr
drivers/staging/comedi/drivers/cb_pcidas64.c:1502:66: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:1505:55: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:1505:55: expected unsigned int volatile [unsigned] [usertype] transfer_size
drivers/staging/comedi/drivers/cb_pcidas64.c:1505:55: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:1506:46: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:1506:46: expected unsigned int volatile [unsigned] [usertype] next
drivers/staging/comedi/drivers/cb_pcidas64.c:1506:46: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:1515:64: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:1515:64: expected unsigned int volatile [unsigned] [usertype] pci_start_addr
drivers/staging/comedi/drivers/cb_pcidas64.c:1515:64: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:1517:66: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:1517:66: expected unsigned int volatile [unsigned] [usertype] local_start_addr
drivers/staging/comedi/drivers/cb_pcidas64.c:1517:66: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:1520:63: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:1520:63: expected unsigned int volatile [unsigned] [usertype] transfer_size
drivers/staging/comedi/drivers/cb_pcidas64.c:1520:63: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:1521:54: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:1521:54: expected unsigned int volatile [unsigned] [usertype] next
drivers/staging/comedi/drivers/cb_pcidas64.c:1521:54: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:2540:63: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:2540:63: expected unsigned int volatile [unsigned] [usertype] transfer_size
drivers/staging/comedi/drivers/cb_pcidas64.c:2540:63: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:2890:58: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:2890:58: expected unsigned int volatile [unsigned] [usertype] transfer_size
drivers/staging/comedi/drivers/cb_pcidas64.c:2890:58: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:2893:21: warning: cast to restricted __le32
drivers/staging/comedi/drivers/cb_pcidas64.c:2895:49: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:2895:49: expected unsigned int volatile [unsigned] [usertype] next
drivers/staging/comedi/drivers/cb_pcidas64.c:2895:49: got restricted __le32 [usertype] <noident>
drivers/staging/comedi/drivers/cb_pcidas64.c:2898:21: warning: cast to restricted __le32
drivers/staging/comedi/drivers/cb_pcidas64.c:2900:54: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers/cb_pcidas64.c:2900:54: expected unsigned int volatile [unsigned] [usertype] next
drivers/staging/comedi/drivers/cb_pcidas64.c:2900:54: got restricted __le32 [usertype] <noident>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Andreea-Cristina Bernat [Mon, 10 Mar 2014 18:25:31 +0000 (20:25 +0200)]
/dgrp: Fixed warning by adding fallthrough comment
This patch solves the warning "possible switch case/default not preceded
by break or fallthrough comment" for the file
/drivers/staging/dgrp/dgrp_tty.c
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Ebru Akagunduz [Mon, 10 Mar 2014 08:02:02 +0000 (10:02 +0200)]
Staging: wlan-ng: Fix do not add new typedefs in p80211mgmt.h
Fix checkpatch.pl issues with do not add new typedefs in p80211mgmt.h
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Himangi Saraogi [Mon, 10 Mar 2014 11:58:55 +0000 (17:28 +0530)]
staging:rtl8821ae:Fix sparse warning of static function declaration
This patch makes the function _rtl8821ae_map_hwqueue_to_fwqueue
static as it is used only in the file trx.c.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Andreea-Cristina Bernat [Mon, 10 Mar 2014 12:01:13 +0000 (14:01 +0200)]
/drivers/staging/dgrp: Fixed warning unchecked sscanf return value
This patch solves the warning: unchecked sscanf return value from the script
checkpatch.pl for the file dgrp_sysfs.c
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Himangi Saraogi [Mon, 10 Mar 2014 18:35:05 +0000 (00:05 +0530)]
staging:rtl8187se: Remove unused variable
This patch disgards the variable declaration and initialization of
rsn_authen_cipher_suite as it is not used anywhere throughout
the kernel.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Himangi Saraogi [Mon, 10 Mar 2014 18:30:01 +0000 (00:00 +0530)]
staging:rtl8192u: Remove unused variable
This patch disgards the variable declaration and initialization of
rsn_authen_cipher_suite as it is not used in anywhere throughout
the kernel.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Jelena Bjelja [Mon, 10 Mar 2014 20:51:52 +0000 (21:51 +0100)]
staging:ozwpan: Fixed trailing whitespace in ozpd.h
This patch fixes trailing whitespace error found in ozpd.h
Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Andreea-Cristina Bernat [Sun, 9 Mar 2014 16:06:58 +0000 (18:06 +0200)]
drivers/staging/crystalhd/bcm_70012_regs.h: Fix line over 80 characters.
Fix checkpatch.pl issue with line over 80.
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Aybuke Ozdemir [Mon, 10 Mar 2014 20:46:44 +0000 (22:46 +0200)]
drivers/staging/rts5139:xd.c: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in xd.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Iulia Manda [Tue, 11 Mar 2014 06:00:03 +0000 (23:00 -0700)]
Staging:dgnc: Fixed space prohibited between function name and '('
Deleted space between sizeof and open parenthethis.
Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Iulia Manda [Mon, 10 Mar 2014 22:10:12 +0000 (00:10 +0200)]
Staging:dgnc: Use uaccess.h header from linux dir instead of asm
Include <linux/uaccess.h> instead of <asm/uaccess.h>
Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Iulia Manda [Mon, 10 Mar 2014 22:09:11 +0000 (00:09 +0200)]
Stagind:dgnc: Fixed unnecessary braces for single statement blocks
Deleted unnecessary braces for single statement if blocks.
Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Iulia Manda [Mon, 10 Mar 2014 22:08:06 +0000 (00:08 +0200)]
Staging:dgnc: Fixed else not following close brace error
Fix checkpatch.pl warning - else should follow close brace.
Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Chi Pham [Mon, 10 Mar 2014 21:31:52 +0000 (22:31 +0100)]
staging: rtl8192u: Removed assignments from if statements.
Removes assignments from if statements and simplifies unnecessary
0/NULL-checking. The following coccinelle script found the match:
@@
expression E0, E1, E2;
statement S0;
@@
- if (E0 == (E1 = E2))
+ E1 = E2;
+ if (E1 == E0)
S0
Signed-off-by: Chi Pham <fempsci@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Andreea-Cristina Bernat [Mon, 10 Mar 2014 10:31:31 +0000 (12:31 +0200)]
/drivers/staging/sbe2t3e3: Fixed left brace to be on the previous line
This patch solves the error: that open brace { should be on the previous line.
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Chi Pham [Sun, 9 Mar 2014 13:40:28 +0000 (14:40 +0100)]
staging:wlags49_h2: Removed assignments from if statements.
The following coccinelle script found the match:
@@
expression E0, E1, E2;
statement S0, S1;
@@
- if ((E1 = E2) != E0)
+ E1 = E2;
+ if (E1 != E0)
S0 else S1
Signed-off-by: Chi Pham <fempsci@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Monam Agarwal [Sun, 9 Mar 2014 12:49:11 +0000 (18:19 +0530)]
Staging: slicoss: Removal of unused macros in slicoss.c
This patch removes unused macro in slicoss.c as mentioned in TODO tasks.
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Chi Pham [Sun, 9 Mar 2014 13:11:11 +0000 (14:11 +0100)]
staging:vt6656: Removed assignment in if statement.
The following coccinelle script found the match:
@@
expression E0, E1, E2;
statement S0;
@@
- if ((E1 = E2) == E0)
+ E1 = E2;
+ if (E1 == E0)
S0
Signed-off-by: Chi Pham <fempsci@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Valentina Manea [Mon, 10 Mar 2014 08:36:40 +0000 (10:36 +0200)]
usbcore: rename struct dev_state to struct usb_dev_state
Since it is needed outside usbcore and exposed in include/linux/usb.h,
it conflicts with enum dev_state in rt2x00 wireless driver.
Mark it as usb specific to avoid conflicts in the future.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:36 +0000 (14:53 +0200)]
staging: usbip: userspace: add hwdata as optional dependency in README
This is an optional dependency since USB/IP can fully work without
it. However, it is needed to display device information such as
vendor.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:35 +0000 (14:53 +0200)]
staging: usbip: userspace: don't throw error when trying to read configuration specific attributes
When a device has just been bound to usbip-host but the client hasn't
set a configuration on it, certain attributes will not exist. Don't
treat this as an error.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:34 +0000 (14:53 +0200)]
staging: usbip: claim ports used by shared devices
A device should not be able to be used concurrently both by
the server and the client. Claiming the port used by the
shared device ensures no interface drivers bind to it and
that it is not usable from the server.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:33 +0000 (14:53 +0200)]
staging: usbip: trigger driver probing after unbinding from usbip-host
A sysfs attribute is used to announce kernel space that a
new driver probing session should be triggered for the just
unbinded device.
In order to have the address of struct device associated to this
USB device, a new member has been added to struct bus_id_priv.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:32 +0000 (14:53 +0200)]
staging: usbip: let client choose device configuration
Since usbip-host is now a device driver and the client
has full access to the shared device, it makes sense to
let the client choose device configuration.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:31 +0000 (14:53 +0200)]
staging: usbip: userspace: increase version to 2.0
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:30 +0000 (14:53 +0200)]
staging: usbip: userspace: update dependencies in README
Add libudev as dependency and remove libsysfs.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:29 +0000 (14:53 +0200)]
staging: usbip: userspace: remove libsysfs flag and autoconf check
libsysfs is now completely removed from USB/IP.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:28 +0000 (14:53 +0200)]
staging: usbip: userspace: migrate vhci_driver to libudev
This patch migrates vhci_driver to libudev.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Reviewed-by: Shuah Khan <shuah.kh@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:27 +0000 (14:53 +0200)]
staging: usbip: userspace: remove class device infrastructure in vhci_driver
The class device lists were used only when being initialized,
being populated and being destroyed. They had no real meaning
and thus the code was useless.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:26 +0000 (14:53 +0200)]
staging: usbip: userspace: migrate usbip_host_driver to libudev
This patch modifies usbip_host_driver to use libudev.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Reviewed-by: Shuah Khan <shuah.kh@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:25 +0000 (14:53 +0200)]
staging: usbip: userspace: move sysfs_utils to libsrc
Since it offers a API to both usbip tools and libusbip,
it is more appropriate to be place in the library.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:24 +0000 (14:53 +0200)]
staging: usbip: userspace: add new list API
Take the linked list implementation from the Linux Kernel
and strip it down to what it is needed.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:23 +0000 (14:53 +0200)]
staging: usbip: userspace: re-add interface information listing
This was deleted in the driver conversion patch. It didn't need
to be deleted; showing more information is ok.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Reviewed-by: Shuah Khan <shuah.kh@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:22 +0000 (14:53 +0200)]
staging: usbip: userspace: migrate usbip_list to libudev
This patch modifies usbip_list to use libudev.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:21 +0000 (14:53 +0200)]
staging: usbip: userspace: migrate usbip_unbind to libudev
This patch modifies usbip_unbind to use libudev.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Reviewed-by: Shuah Khan <shuah.kh@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:20 +0000 (14:53 +0200)]
staging: usbip: userspace: remove useless libsysfs includes
This patch removes useless libsysfs.h includes in various
userspace files.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valentina Manea [Sat, 8 Mar 2014 12:53:19 +0000 (14:53 +0200)]
staging: usbip: userspace: migrate usbip_bind to libudev
This patch adds autoconf check for libudev and migrates
usbip_bind to the new library.
libsysfs will still be used until all userspace is modified.
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Reviewed-by: Shuah Khan <shuah.kh@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alexey Khoroshilov [Sat, 8 Mar 2014 21:01:34 +0000 (01:01 +0400)]
staging: dgap: implement proper error handling in dgap_start()
dgap_start() ignored errors in class_create() and device_create().
The patch implements proper error handling.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alexey Khoroshilov [Sat, 8 Mar 2014 21:01:33 +0000 (01:01 +0400)]
staging: dgap: remove unneeded status variables
dgap_driver_start and dgap_Major_Control_Registered are used
to keep status of initialization of the driver as a whole and its "Major Control".
But the code that checks them is executed once on module init/unload.
That makes no sense in these variables as far as their values are predictable
at any time.
Also "dgap_downld" device was removed, while
device_destroy(MKDEV(DIGI_DGAP_MAJOR, 1)) is still in dgap_cleanup_module().
The patch removes it by the way.
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Fri, 7 Mar 2014 19:44:47 +0000 (13:44 -0600)]
Staging: unisys: Fix multiple variable length array declarations
There were multiple variable length arrays declared on the stack in proc
handlers:
char buf[count];
I changed these to be fixed length arrays.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 7 Mar 2014 19:02:21 +0000 (13:02 -0600)]
staging: unisys: update MAINTAINERS and TODO
This patch adds the Unisys s-Par driver maintainers to the MAINTAINERS
file, changes the state to "Supported", modifies TODO to address patches
to the Unisys mailing list, and adds Greg Kroah-Hartman to the patch
recipients list.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Fri, 7 Mar 2014 18:22:22 +0000 (12:22 -0600)]
Staging: unisys: uislib: Fix locking in info_proc_read_helper()
Make sure BusListLock is unlocked before returning. If an error is encountered
early on in info_proc_read_helper() the function can return without unlocking.
Also changed the PROCLINE macro so that it doesn't include a goto statement.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Fri, 7 Mar 2014 16:30:27 +0000 (10:30 -0600)]
Staging: unisys: virthba: Fix variable length array
A character array was declared on the stack with variable length. This has
been corrected to use a fixed length.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Fri, 7 Mar 2014 11:18:17 +0000 (14:18 +0300)]
staging: unisys/uislib: kthread_create() returns an ERR_PTR
kthread_create() returns an ERR_PTR on error, it never returns NULL.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shaun Laing [Fri, 7 Mar 2014 20:54:33 +0000 (13:54 -0700)]
staging: cxt1e1: change declaration of TWV_table
Changes the declaration of TWV_table to 'static void' to eliminate a sparse
"should it be static" warning.
Signed-off-by: Shaun Laing <shaun@xresource.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 7 Mar 2014 08:25:55 +0000 (17:25 +0900)]
staging: frontier: fix memory leak in usb_alphatrack_probe()
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 7 Mar 2014 00:01:51 +0000 (09:01 +0900)]
staging: cxt1e1: fix checkpatch errors with open brace '{'
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Thu, 6 Mar 2014 23:59:41 +0000 (08:59 +0900)]
staging: cxt1e1: fix checkpatch error 'assignment in if condition'
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 6 Mar 2014 22:44:25 +0000 (22:44 +0000)]
staging: vt6655: 64 bit fix sizeof long TKIP mic
Change to u32 and fix debug message format
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 6 Mar 2014 22:44:24 +0000 (22:44 +0000)]
staging: vt6655: 64 bit fixes TKIP mic correct sizeof long.
Correct to endian base type __le32.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 6 Mar 2014 22:44:23 +0000 (22:44 +0000)]
staging: vt6655: 64 bit fixes :TKIP mode micheal.c sizeof long.
Fix MIC_vGetMIC and MIC_vInit to u32
Fix calling functions to u32
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>