OSDN Git Service
TreeHugger Robot [Fri, 17 Feb 2017 00:04:34 +0000 (00:04 +0000)]
Merge "Mark only browser as default in app detail page"
TreeHugger Robot [Thu, 16 Feb 2017 22:59:46 +0000 (22:59 +0000)]
Merge "Update cast setting icon"
Fan Zhang [Thu, 16 Feb 2017 19:56:18 +0000 (11:56 -0800)]
Mark only browser as default in app detail page
Change-Id: I8112d859ba788a1dc67c44b5e0de668c0fc13169
Fix:
35307728
Test: make RunSettingsRoboTests
Hyunyoung Song [Thu, 16 Feb 2017 22:18:15 +0000 (22:18 +0000)]
Merge "Change launcher and shortcut icons to MaskableIconDrawable Test: manual test on Launcher3 Bug:
33034275 Bug:
35431198"
TreeHugger Robot [Thu, 16 Feb 2017 20:58:42 +0000 (20:58 +0000)]
Merge "Update string: lockdown confirmation dialog title"
Fan Zhang [Thu, 16 Feb 2017 20:53:44 +0000 (12:53 -0800)]
Update cast setting icon
Change-Id: Id5cbe994f58c3daea4c70ffd76718ac56389a610
Fix:
35407157
Test: manual
Hyunyoung Song [Tue, 14 Feb 2017 18:40:58 +0000 (10:40 -0800)]
Change launcher and shortcut icons to MaskableIconDrawable
Test: manual test on Launcher3
Bug:
33034275
Bug:
35431198
Change-Id: Ief9f49ec38ec95daa738799398fc4b458d634acc
TreeHugger Robot [Thu, 16 Feb 2017 20:26:39 +0000 (20:26 +0000)]
Merge "Fix NPE in WriteWifiConfigToNfcDialog."
TreeHugger Robot [Thu, 16 Feb 2017 20:04:30 +0000 (20:04 +0000)]
Merge "Add source metrics when launching top level setting items."
Robin Lee [Thu, 16 Feb 2017 17:48:41 +0000 (17:48 +0000)]
Update string: lockdown confirmation dialog title
The most common string shown previously was:
"Set always-on VPN?"
It's now a different string:
"Only allow connections through VPN?"
This makes more sense because the only way to get to this dialog in
stock Settings is by first enabling a specific VPN and afterwards
trying to set the same VPN to lockdown mode.
In this case the prompt should specifically refer to lockdown, not
having a VPN connection in general (because the user clearly already
has one).
Test: m Settings -j20, install a VPN, connect to it, open Settings > Network > Vpn > {VPN name} and select 'only allow connections through VPN'. Verify the title is now the one referred to in the commit message.
Fix:
34491069
Change-Id: Ic74a8b91eb8ae64fbe15723c173281f4ede52b06
Amin Shaikh [Thu, 16 Feb 2017 01:47:04 +0000 (17:47 -0800)]
Fix NPE in WriteWifiConfigToNfcDialog.
Bug:
34691792
Test: m RunSettingsRoboTests
Change-Id: I0e396f4f590c8de6636c7494e20d74c562b7c9cd
Fan Zhang [Thu, 16 Feb 2017 17:26:37 +0000 (09:26 -0800)]
Add source metrics when launching top level setting items.
Change-Id: Idca6e136747fb40ba962307abd2620cdd241c3b1
Fix:
35359289
Test: make RunSettingsRoboTests
Daniel Nishi [Thu, 16 Feb 2017 17:39:40 +0000 (17:39 +0000)]
Merge "Fix a race condition where the extra view may not update timely."
Bill Yi [Thu, 16 Feb 2017 15:56:31 +0000 (15:56 +0000)]
Import translations. DO NOT MERGE am:
7e0985b644 -s ours
am:
f6247a41f7 -s ours
Change-Id: I69de537de2f21a01535222697a0918f8a2245ddd
Bill Yi [Thu, 16 Feb 2017 15:49:10 +0000 (15:49 +0000)]
Import translations. DO NOT MERGE
am:
7e0985b644 -s ours
Change-Id: I90c3ee4b3610f62d693663cb7372b0e96806e9b5
Bill Yi [Thu, 16 Feb 2017 13:24:28 +0000 (05:24 -0800)]
Import translations. DO NOT MERGE
Change-Id: I9e1516012801af3f6f21231d6615f9a8969625ed
Auto-generated-cl: translation import
TreeHugger Robot [Thu, 16 Feb 2017 05:25:44 +0000 (05:25 +0000)]
Merge "Modify text in Apps & notifications settings."
TreeHugger Robot [Thu, 16 Feb 2017 04:42:43 +0000 (04:42 +0000)]
Merge "Log source with visibility change"
Doris Ling [Wed, 15 Feb 2017 23:42:30 +0000 (15:42 -0800)]
Modify text in Apps & notifications settings.
- in Settings->Apps & notifications->Apps->[select app], update the
header summary to installation status, and move the version text to
the bottom of the page.
- updatd preference title from Apps to App info
- update preference title from Notifications to App notifications
Bug:
34977561
Test: make RunSettingsRoboTests
Change-Id: I97e9b81c739fb99eaca2cf45fb11f208ad6cd9ca
TreeHugger Robot [Thu, 16 Feb 2017 02:51:37 +0000 (02:51 +0000)]
Merge "Update texts for Settings->Sound->Do not disturb"
Doris Ling [Thu, 16 Feb 2017 01:58:01 +0000 (01:58 +0000)]
Merge "Update preference title for add user on lock screen."
Fan Zhang [Tue, 14 Feb 2017 23:02:35 +0000 (15:02 -0800)]
Log source with visibility change
- Add a method in VisibilityLoggerMixin to log visible event using
LogMaker, which allows logging additional FIELD_CONTEXT field.
- In Utils.startFragment, add current page's metricsCategory as an extra
to next page.
- In next page's onResume(), extract the previous page's metricsCategory
and send it to VisibilityLoggerMixin.visible()
- Update all caller with additional paramters
Change-Id: I8e1f2597fa465b7d3aa16fa1d21c052a3219694a
Fix:
35359289
Test: RunSettingsRoboTests
TreeHugger Robot [Thu, 16 Feb 2017 01:05:39 +0000 (01:05 +0000)]
Merge "Update layout for App info page."
TreeHugger Robot [Thu, 16 Feb 2017 01:03:22 +0000 (01:03 +0000)]
Merge "Add logging when "Advanced" button is clicked"
Doris Ling [Thu, 16 Feb 2017 00:16:13 +0000 (00:16 +0000)]
Merge "Remove Cast from Display settings."
Doris Ling [Mon, 6 Feb 2017 19:59:18 +0000 (11:59 -0800)]
Remove Cast from Display settings.
Update the display settings xml to remove the wifi-display settings.
Change-Id: I5363e1a9c4e89af8eaa64512a72cf42160b0fee6
Bug:
34975969
Test: Visual
Fan Zhang [Tue, 14 Feb 2017 21:59:41 +0000 (13:59 -0800)]
Add logging when "Advanced" button is clicked
Change-Id: I8259b1b863991935165afb19e34c30dcf5056acf
Fix:
35356464
Test: RunSettingsRoboTests
Rubin Xu [Wed, 15 Feb 2017 22:37:39 +0000 (22:37 +0000)]
Merge "Do not show key entries used for user authentication flow"
Doris Ling [Wed, 15 Feb 2017 19:19:02 +0000 (11:19 -0800)]
Update preference title for add user on lock screen.
In Settings->User & accounts, update the preference title for "Add user"
to "Add users from lock screen" and remove the summary.
Bug:
34976320
Test: Visual
Change-Id: Idfb661537ac3b178ca20c2da9e66ab8a16567ba6
Doris Ling [Wed, 15 Feb 2017 20:04:57 +0000 (12:04 -0800)]
Update texts for Settings->Sound->Do not disturb
- Update title to "Do not disturb preferences"
- Add summary text to reflect the priority only allows preferences
- Refactor the summary handling in ZenModeSettings so that the
controller can get the summary text
Fix:
34975939
Test: make RunSettingsRoboTests
Change-Id: I3ca1dc43fe1d943735a9f625e66c89708a18300a
TreeHugger Robot [Wed, 15 Feb 2017 21:44:14 +0000 (21:44 +0000)]
Merge "Remove extra IndexProviders that provided bad data."
Philip P. Moltmann [Wed, 15 Feb 2017 21:37:30 +0000 (21:37 +0000)]
TreeHugger Robot [Wed, 15 Feb 2017 21:36:54 +0000 (21:36 +0000)]
Merge "Correctly restrict UI for WifiSettings in Guest profile."
Doris Ling [Wed, 15 Feb 2017 21:34:27 +0000 (21:34 +0000)]
Merge "Move Ringtones out of Advanced."
Doris Ling [Wed, 15 Feb 2017 02:56:49 +0000 (18:56 -0800)]
Update layout for App info page.
- Move the app link buttons to the right
- Move the footer buttons to the top below the header
- Rename the app header details title, summary, and icon views.
Bug:
34977561
Test: make RunSettingsRoboTests
Change-Id: Id0cfc2b73b4e5cbbc1a58e497da52560892b69c8
Stephen Chen [Tue, 14 Feb 2017 21:56:03 +0000 (13:56 -0800)]
Correctly restrict UI for WifiSettings in Guest profile.
Makes sure the restricted user does not see Wifi Preferences
or Saved Networks activity. Also fixes a bug where the progress
bar is displayed starting the activity in Guest mode, and does not go
away. LinkablePreference is changed to make sure titles can be
multi-lined.
Bug:
35317523
Bug:
35318292
Test: to be done in b/
35324506
Change-Id: I4a07a2ab3a83c3adaf87226969fd6f16e41c9419
TreeHugger Robot [Wed, 15 Feb 2017 03:04:08 +0000 (03:04 +0000)]
Merge "Skip redundant SuggestionLoader run during app start."
Fan Zhang [Wed, 8 Feb 2017 01:40:59 +0000 (17:40 -0800)]
Skip redundant SuggestionLoader run during app start.
also skip DiffUtil when drawing first frame.
Fix:
34103984
Test: make RunSettingsRoboTests
Change-Id: I4891d1bca1f17c437444761eaf3002624934014d
Philip P. Moltmann [Tue, 14 Feb 2017 20:43:02 +0000 (12:43 -0800)]
Revert accidential merge
afe6320d70f46e8af724ef2cde86a5963d198868
Test: Clean revert
Change-Id: I674df1a86539b03cb72f43eed2f40f421b953508
TreeHugger Robot [Wed, 15 Feb 2017 00:50:38 +0000 (00:50 +0000)]
Merge "Update security screen summary text when no fingerprint"
Matthew Fritze [Thu, 26 Jan 2017 23:21:24 +0000 (15:21 -0800)]
Remove extra IndexProviders that provided bad data.
Gesture Settings and Wireless settings were indexing
duplicate results that only added complexity to Search.
PowerUsageDetail was never supposed to be indexed.
Bug:
33701673
Test: make RunSettingsRoboTests
Change-Id: I45d1fa4bd412c3418acec24f8c98eb4736f220ab
TreeHugger Robot [Wed, 15 Feb 2017 00:34:34 +0000 (00:34 +0000)]
Merge "Create 'See All Networks' Preference to hide additional networks."
TreeHugger Robot [Wed, 15 Feb 2017 00:12:21 +0000 (00:12 +0000)]
Merge "Replace footer with regular preference"
Fan Zhang [Tue, 14 Feb 2017 19:58:25 +0000 (11:58 -0800)]
Update security screen summary text when no fingerprint
Change-Id: I810c533b0daeab3bd67d9d5be8a89d93738b4962
Fix:
35339887
Test: RunSettingsRoboTest
Doris Ling [Tue, 14 Feb 2017 21:48:01 +0000 (13:48 -0800)]
Move Ringtones out of Advanced.
Increase the tile limit in Settings->Sound so that Ringtones is not
hidden inside the Advances options.
Fix:
35318739
Test: Visual
Change-Id: I08db7b79127226bb6ef8ce8f147e5a90f5939d79
Salvador Martinez [Mon, 13 Feb 2017 19:50:10 +0000 (11:50 -0800)]
Replace footer with regular preference
Replaced the "Manage Storage" footer preference
with a regular preference because the footer type
is not meant to be a touch target. This should fix
the bug with not being able to click on specific
parts of the preference.
Test: run settings espresso tests
Bug:
34349518
Change-Id: I36ada2a6a537a68d9fcbe7e10773896225ecc6b2
Matthew Fritze [Tue, 14 Feb 2017 22:05:04 +0000 (22:05 +0000)]
Merge "Revert "Remove Gesture settings as inline results""
Matthew Fritze [Tue, 14 Feb 2017 22:02:13 +0000 (22:02 +0000)]
Revert "Remove Gesture settings as inline results"
This reverts commit
4ec4969b33c3d0f9db58937881eb1dcd7b3e3f59.
Change-Id: I5b0012174864bba8b196220ee29863a9a58faa69
TreeHugger Robot [Tue, 14 Feb 2017 21:30:40 +0000 (21:30 +0000)]
Merge "Add account preferences from account type description."
TreeHugger Robot [Tue, 14 Feb 2017 19:03:57 +0000 (19:03 +0000)]
Merge "Remove Gesture settings as inline results"
Daniel Nishi [Tue, 14 Feb 2017 18:45:29 +0000 (18:45 +0000)]
Merge "Don't show games and music apps in Other Apps."
Doris Ling [Fri, 10 Feb 2017 22:22:58 +0000 (14:22 -0800)]
Add account preferences from account type description.
Move the methods that handles the account type preferences to a separate
class and add the call to it in AccountDetailDashboardFragment.
Change-Id: Ib147fb73807b1264e3faedad3466126f2fd9c84d
Fix:
35224671
Test: Manual
TreeHugger Robot [Tue, 14 Feb 2017 18:40:35 +0000 (18:40 +0000)]
Merge "Fix monkey crash by guarding singleton initializing"
Philip P. Moltmann [Tue, 14 Feb 2017 18:27:10 +0000 (18:27 +0000)]
resolve merge conflicts of
9ac842a753 to nyc-mr2-dev-plus-aosp
am:
afe6320d70
Change-Id: I514cc08bef8ef2b76d90628ae3b21833d3bda206
Stephen Chen [Fri, 10 Feb 2017 00:17:28 +0000 (16:17 -0800)]
Create 'See All Networks' Preference to hide additional networks.
Bug:
34719725
Test: manual inspection, tests to be added in b/
35322551
Change-Id: I1a5a08ca4c53db71b4c0c3d4c2942da65faa67d2
Philip P. Moltmann [Tue, 14 Feb 2017 17:45:51 +0000 (09:45 -0800)]
resolve merge conflicts of
9ac842a753 to nyc-mr2-dev-plus-aosp
Test: built
Change-Id: I156db22c13da98bce0077b2acb8d9f1a3d2ce406
Matthew Fritze [Thu, 26 Jan 2017 23:21:24 +0000 (15:21 -0800)]
Remove Gesture settings as inline results
Given that inline results do not have intents associated,
the inline results must be self-explanatory. The gesture
settings ofter requier the video/animation to be
understood. Thus they should not be inline.
Test: RunSettingsRoboTests
Bug:
Change-Id: Iae25365b376ec510f8330bc0a0bf72883cf9a6d4
Philip P. Moltmann [Tue, 14 Feb 2017 16:03:27 +0000 (16:03 +0000)]
Merge "[DO NOT MERGE] Revert "[DO NOT MERGE] Use new QueuedWork interface."" into nyc-mr2-dev
Ricky Wai [Tue, 14 Feb 2017 11:14:08 +0000 (11:14 +0000)]
Merge "Change "Long pressing work mode in quick settings" to managed profile settings"
TreeHugger Robot [Tue, 14 Feb 2017 11:13:59 +0000 (11:13 +0000)]
Merge "CredentialFragment anti-pocket dialing measures."
Ricky Wai [Wed, 1 Feb 2017 15:26:29 +0000 (15:26 +0000)]
Change "Long pressing work mode in quick settings" to managed profile settings
Test: Long pressing work mode can go to managed profile settings now.
Bug:
34189626
Change-Id: I84820b1ce0a5693f36236c1bb512c99db3c6e9df
TreeHugger Robot [Tue, 14 Feb 2017 03:01:29 +0000 (03:01 +0000)]
Merge "Add logging for settings"
TreeHugger Robot [Tue, 14 Feb 2017 02:21:20 +0000 (02:21 +0000)]
Merge "Update char_limit for new string"
TreeHugger Robot [Tue, 14 Feb 2017 01:55:49 +0000 (01:55 +0000)]
Merge "Deprecate SettingsDrawerActivity.openTile."
Dmitry Dementyev [Tue, 14 Feb 2017 01:27:45 +0000 (01:27 +0000)]
Merge "Add permission check to Intents used by Authenticator Settings."
Fan Zhang [Mon, 13 Feb 2017 23:28:21 +0000 (15:28 -0800)]
Add logging for settings
- Log when navigating from Settings to injected tiles.
- Log when user creates a new widget shortcut
Fix:
33209678
Fix:
30137094
Test: RunSettingsRoboTests
Change-Id: I1e0f4e00709c392cde2550fafe53890836387c99
Fan Zhang [Tue, 14 Feb 2017 00:44:18 +0000 (16:44 -0800)]
Update char_limit for new string
Change-Id: I49fc0522a5522bf5dae16d1a2d12e2819eee7a2a
Fix:
35187169
Test: build
Philip P. Moltmann [Mon, 13 Feb 2017 20:58:46 +0000 (20:58 +0000)]
[DO NOT MERGE] Revert "[DO NOT MERGE] Use new QueuedWork interface."
This reverts commit
81758edffae751c31fb1795febe470c171f7fb1b.
Bug:
30662828
Change-Id: I5c877a3a888f075afcfb9f49ec92cf3ad43f6304
Dmitry Dementyev [Sat, 11 Feb 2017 00:51:51 +0000 (16:51 -0800)]
Add permission check to Intents used by Authenticator Settings.
Setting shares system uid and can be used to bypass different security
checks.
We add proper handling for intents which resolve toexported=true activities with permission filed.
Added nested preferences filtering.
Change-Id: If68343d155364654fa7db55ace3fb3c4db508c7e
Test: manual tests
Bug:
14408627
Fan Zhang [Mon, 13 Feb 2017 20:28:43 +0000 (12:28 -0800)]
Fix a bug where SYNC_SETTINGS intent opens a blank page.
Point to the intent to new IA fragment (User & Account)
Change-Id: I3880518f36f875091175432c5e91cfcd7edb42cd
Fix:
34395427
Test: run settings integ test
Fan Zhang [Mon, 13 Feb 2017 22:24:36 +0000 (14:24 -0800)]
Deprecate SettingsDrawerActivity.openTile.
Use DashboardFeatureProvider to open tile instead. This makes logic more
centralized in one place, and makes logging easier in the future.
Bug:
30137094
Test: RunSettingsRoboTests
Change-Id: I8a028bb7cac8f70f6c237f253be8668cc3ef257e
TreeHugger Robot [Mon, 13 Feb 2017 21:51:07 +0000 (21:51 +0000)]
Merge changes from topic 'hotspot_summary'
* changes:
Display current vpn for Vpn preference summary text
Display carrier network name as celluar setting summary.
Add hotspot summary text
Fan Zhang [Sat, 11 Feb 2017 21:43:05 +0000 (13:43 -0800)]
Display current vpn for Vpn preference summary text
Change-Id: Id9917a07e519d16e2000b4fa9888f783171e55f8
Fix:
34974598
Test: RunSettingsRoboTests
Fan Zhang [Sat, 11 Feb 2017 18:43:52 +0000 (10:43 -0800)]
Display carrier network name as celluar setting summary.
Bug:
34974598
Test: make RunSettingsRoboTests
Change-Id: I99436337919440e0dd21653f9ea63d6f3a694df0
Fan Zhang [Fri, 10 Feb 2017 02:04:00 +0000 (18:04 -0800)]
Add hotspot summary text
Bug:
34974598
Test: RunSettingsLibRoboTests
Change-Id: If5d17bf458f980b4f3a8fdeb4718bbf5d2993a21
TreeHugger Robot [Mon, 13 Feb 2017 20:45:17 +0000 (20:45 +0000)]
Merge "Add BatteryMeterView in Settings"
jackqdyulei [Thu, 2 Feb 2017 19:25:15 +0000 (11:25 -0800)]
Add BatteryMeterView in Settings
1. Show gauge icon at the top of battery main page instead of
battery usage graph.
2. Move the click action from battery usage graph to gauge icon.
Bug:
34387464
Test: RunSettingsRoboTest
Change-Id: Ib182619d6805b401cde03a50e2ae907cf4df7b94
TreeHugger Robot [Mon, 13 Feb 2017 17:46:23 +0000 (17:46 +0000)]
Merge "Replace deprecated ACTION_MASTER_CLEAR by ACTION_FACTORY_RESET."
Bill Yi [Mon, 13 Feb 2017 17:34:16 +0000 (17:34 +0000)]
Import translations. DO NOT MERGE am:
da8a98fb26 -s ours
am:
daa2d5a23a -s ours
Change-Id: I08237170e91f978d9f8718fff3df30c6f6be59f3
Bill Yi [Mon, 13 Feb 2017 17:31:14 +0000 (17:31 +0000)]
Import translations. DO NOT MERGE
am:
da8a98fb26 -s ours
Change-Id: I111397e147e83c3cc0e8d83d365627792035b238
Lenka Trochtova [Mon, 13 Feb 2017 14:05:27 +0000 (15:05 +0100)]
Replace deprecated ACTION_MASTER_CLEAR by ACTION_FACTORY_RESET.
Both do the same, ACTION_FACTORY_RESET is the new name.
Test: manual - reset the device
BUG:
33656232
Change-Id: I30cedea600bfcbeffa5d1094a6e0e83326f7ccfc
Rubin Xu [Thu, 9 Feb 2017 11:09:11 +0000 (11:09 +0000)]
Do not show key entries used for user authentication flow
Bug:
33126414
Test: Enable new authentication flow; go to user credentials in Settings
observe no entries related to user authentication are shown.
Change-Id: I62e5796cc73213b23ca7809a77082350a883fbee
Bill Yi [Mon, 13 Feb 2017 07:02:41 +0000 (23:02 -0800)]
Import translations. DO NOT MERGE
Change-Id: Ia85aa9d355617a44a438932f30332cfcbb70842a
Auto-generated-cl: translation import
Bill Yi [Mon, 13 Feb 2017 06:56:48 +0000 (22:56 -0800)]
Import translations. DO NOT MERGE
Change-Id: Ic5485e66425141363f2c338fa41dc94816916eec
Auto-generated-cl: translation import
Tadashi G. Takaoka [Fri, 10 Feb 2017 07:58:45 +0000 (16:58 +0900)]
Fix monkey crash by guarding singleton initializing
Fixes:
35203476
Test: Run monkey test and observe no crash happens.
adb shell monkey -p com.google.android.launcher -p com.android.settings
-c android.intent.category.LAUNCHER --ignore-security-exceptions
--monitor-native-crashes -s 454 -v -v -v 125000
Change-Id: Ib13afcc4e14470510f3ccbb20d7e7d6009347149
Fan Zhang [Sun, 12 Feb 2017 20:52:06 +0000 (20:52 +0000)]
Merge "Fix a memory leak caused by dashboard freature provider."
Fan Zhang [Sun, 12 Feb 2017 01:44:03 +0000 (01:44 +0000)]
DO NOT MERGE Fix "3 dot" icon size so it displays fully am:
fa190d437b
am:
6583bc3479 -s ours
Change-Id: I3f2e6b5aa6d3d86f2cc11fadff1f2d25c29b3612
Fan Zhang [Sun, 12 Feb 2017 01:42:03 +0000 (01:42 +0000)]
DO NOT MERGE Fix "3 dot" icon size so it displays fully
am:
fa190d437b
Change-Id: I7deb37ac62ff85f37d945d453bd6285a809779f1
TreeHugger Robot [Sun, 12 Feb 2017 01:19:15 +0000 (01:19 +0000)]
Merge "Sync search result loaders"
Fan Zhang [Sun, 12 Feb 2017 00:47:29 +0000 (16:47 -0800)]
Fix a memory leak caused by dashboard freature provider.
In constructor, use app context instead of fragment context
Change-Id: I24fbc457037c1d6854ecf0cb270110d73effb662
Fix:
35292764
Test: RunSettingsRoboTests
Fan Zhang [Sat, 11 Feb 2017 18:50:13 +0000 (10:50 -0800)]
DO NOT MERGE Fix "3 dot" icon size so it displays fully
Viewport size was set wrong due to bad merge, causing the last dot got
truncated slightly.
Change-Id: I5d5bbd703e780b21957613d88a2250bc3ba69bb8
Fix:
28194068
Test: visual
Robin Lee [Fri, 10 Feb 2017 16:12:20 +0000 (16:12 +0000)]
CredentialFragment anti-pocket dialing measures.
Now it is necessary to actually press the exact "OK" or Back button to
get the dialog to dismiss. This makes pocket wiping that little bit less
likely.
Bug:
32934848
Test: manual, enter the password too many times. The dialog should appear. Attempt to dismiss it by tapping outside the dialog. This should not happen.
Test: correctness of .setCanceledOnTouchOutside is outside scope.
Change-Id: Icff8bd9068f636c0a75decb787b8a5c9161a8cbd
Pavlin Radoslavov [Sat, 11 Feb 2017 01:34:12 +0000 (01:34 +0000)]
Merge "Add null pointer checks when updating A2DP configuration values" am:
6f7437580c am:
bd3f96703c am:
fae23e1e00
am:
73aa2c6b3f
Change-Id: Iac81cb29671c198414a53c517deb6db962294d0a
Pavlin Radoslavov [Sat, 11 Feb 2017 01:31:52 +0000 (01:31 +0000)]
Merge "Add null pointer checks when updating A2DP configuration values" am:
6f7437580c am:
bd3f96703c
am:
fae23e1e00
Change-Id: I55f901bee2b1a7368cf28cf0b2c6a89e8af27342
Pavlin Radoslavov [Sat, 11 Feb 2017 01:28:22 +0000 (01:28 +0000)]
Merge "Add null pointer checks when updating A2DP configuration values" am:
6f7437580c
am:
bd3f96703c
Change-Id: I04f7187c23a0f17c5ef2d37f75d892e4da54111e
Pavlin Radoslavov [Sat, 11 Feb 2017 01:25:50 +0000 (01:25 +0000)]
Merge "Add null pointer checks when updating A2DP configuration values"
am:
6f7437580c
Change-Id: I567042ca38e74e2ce228e4bb03c73095c8cf6513
Treehugger Robot [Sat, 11 Feb 2017 01:21:25 +0000 (01:21 +0000)]
Merge "Add null pointer checks when updating A2DP configuration values"
Fan Zhang [Fri, 10 Feb 2017 21:58:33 +0000 (21:58 +0000)]
Merge "Update storage setting summary text format."
Pavlin Radoslavov [Fri, 10 Feb 2017 20:52:04 +0000 (12:52 -0800)]
Add null pointer checks when updating A2DP configuration values
Under expected circumstances, those null pointer checks are not
needed: onCreate() is always called before onCreateView(),
and the former creates the objects: mBluetoothSelectA2dpCodec,
mBluetoothSelectA2dpSampleRate, mBluetoothSelectA2dpBitsPerSample,
mBluetoothSelectA2dpChannelMode, mBluetoothSelectA2dpLdacPlaybackQuality .
For some unknown reason, somehow the following chain of calls is executed
before onCreate() :
onCreateView() ->
getActivity().registerReceiver(mBluetoothA2dpReceiver, ...) ->
mBluetoothA2dpReceiver.onReceive(...) ->
updateBluetoothA2dpConfigurationValues()
Adding the null pointer checks until the issue is understood.
Test: Code compilation
Bug:
35204511
Change-Id: I7c1d81015e66b26544b7b26f36cbc75f11713496
TreeHugger Robot [Fri, 10 Feb 2017 20:10:38 +0000 (20:10 +0000)]
Merge "Distribute all the hidden items to apps"