OSDN Git Service
Philip P. Moltmann [Fri, 5 Apr 2019 18:13:14 +0000 (18:13 +0000)]
Merge "Remove Gallery and Music role" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 18:04:23 +0000 (18:04 +0000)]
Merge "Add getTextClassifier perf test" into qt-dev
John Reck [Fri, 5 Apr 2019 17:59:10 +0000 (17:59 +0000)]
Merge "Fix lifecycle issue in CommonPool" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 17:50:52 +0000 (17:50 +0000)]
Merge "Ensure getParentSurfaceControl and getSurfaceControl return valid or null SC" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 17:44:25 +0000 (17:44 +0000)]
Merge "Adding a level of indirection. Dimens value should live in the framework/base and not the overlay." into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 17:26:53 +0000 (17:26 +0000)]
Merge "Support profileable application action" into qt-dev
Chong Zhang [Fri, 5 Apr 2019 17:18:04 +0000 (17:18 +0000)]
Merge "make libmedia_jni_utils depends on libgui" into qt-dev
David Su [Fri, 5 Apr 2019 17:15:01 +0000 (17:15 +0000)]
Merge "wifi.proto: Add link probe event to StaEvent" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 17:06:51 +0000 (17:06 +0000)]
Merge "zygote: initialize ashmem early" into qt-dev
Chavi Weingarten [Fri, 5 Apr 2019 16:41:43 +0000 (16:41 +0000)]
Merge "Only switch task focus to window's task that was tapped outside current focus" into qt-dev
Courtney Goeltzenleuchter [Fri, 5 Apr 2019 16:37:25 +0000 (16:37 +0000)]
Merge "EGLAttrib requires special handling in JNI" into qt-dev
Robert Carr [Thu, 4 Apr 2019 19:02:51 +0000 (12:02 -0700)]
Ensure getParentSurfaceControl and getSurfaceControl return valid or null SC
Many places (like SurfaceAnimator#reset) expect that these SC will be valid or
null, but various implementors of Animatable were not fulfilling this contract.
Fulfill the contract and update the java-doc. Since everyone follows function
documentation this will never happen again.
Test: Existing tests pass. go/wm-smoke
Bug:
129949355
Change-Id: I5acb6b3209158c4c5b258a06c5d60d9e06bb6db1
Eric Laurent [Fri, 5 Apr 2019 16:00:00 +0000 (16:00 +0000)]
Merge "fix AudioAttributes matching rule in AudioProductStrategy" into qt-dev
Eric Laurent [Fri, 5 Apr 2019 16:00:00 +0000 (16:00 +0000)]
Merge "Revert "Revert "Mute haptic channels by default.""" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 15:52:17 +0000 (15:52 +0000)]
Merge "Flag to configure model parameters" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 15:41:25 +0000 (15:41 +0000)]
Merge "Set system gesture exclusion rects for Bubbles" into qt-dev
Priyank Singh [Wed, 27 Mar 2019 22:40:05 +0000 (15:40 -0700)]
Adding a level of indirection. Dimens value should live in the framework/base and not the overlay.
Bug:
129080865
Test: Manual
Change-Id: Ic6bc3b254c32afad4230351fe9dd33217a7a86a4
TreeHugger Robot [Fri, 5 Apr 2019 15:27:05 +0000 (15:27 +0000)]
Merge "Catch ArrayIndexOutOfBoundsException in StateMachine.toString()" into qt-dev
Jeff Sharkey [Fri, 5 Apr 2019 15:18:23 +0000 (15:18 +0000)]
Merge "Fix isExternalStorageSandboxed() bug." into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 15:05:15 +0000 (15:05 +0000)]
Merge "Expose notification guts on menu shown" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 14:26:14 +0000 (14:26 +0000)]
Merge "Update icon for Calendar permission." into qt-dev
Todd Kennedy [Fri, 5 Apr 2019 14:16:37 +0000 (14:16 +0000)]
Merge "fix nullability" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 14:10:41 +0000 (14:10 +0000)]
Merge "Sharesheet - Limit EXTRA_INITIAL_INTENTS to 2" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 14:08:52 +0000 (14:08 +0000)]
Merge "Update theme icon packs." into qt-dev
Mark Renouf [Mon, 1 Apr 2019 18:17:37 +0000 (14:17 -0400)]
Set system gesture exclusion rects for Bubbles
When there is at least one Bubble on-screen, the bounds
of the first (top) bubble are set to exclude system
navigation gestures.
Test: manually w/fully gesture nav enabled
Bug:
126360272
Change-Id: I47a3c69fdc89476805d48b5214a7f05f5d033306
Tony Mak [Fri, 22 Mar 2019 15:35:15 +0000 (15:35 +0000)]
Flag to configure model parameters
The objective is to allow us to push model parameters by using a settings flag,
without the need of pushing a new model file.
Settings.Global#TEXT_CLASSIFIER_ACTION_MODEL_PARAMS stores a comma
separated string that contains these three fields:
1. required_model_version
2. required_locales
3. serialized_preconditions
To ensure serialized_preconditions is applied to the target model file,
TextClassifierImpl only applies the serialized_preconditions when
required_model_version and required_locales are both met.
Test: atest frameworks/base/core/tests/coretests/src/android/view/textclassifier/
Test: adb shell settings put global text_classifier_action_model_params 'required_model_version=0,required_locales=en,serialized_preconditions=FAAAAAAADgAIAAAAAAAAAAAABAAOAAAAAAAAAA=='
Observe that the flag is actually applied in the model.
Test: Ensure that finalize is called when the activity is dead.
BUG:
123616497
Change-Id: Ie42dcfeee705c83bbb693a5c1a0fedd0821df5e7
TreeHugger Robot [Fri, 5 Apr 2019 13:26:20 +0000 (13:26 +0000)]
Merge "Stores serialized entity data to the extras" into qt-dev
Narayan Kamath [Fri, 5 Apr 2019 12:39:42 +0000 (12:39 +0000)]
Merge "Fix rollbacks in multi-user case." into qt-dev
Matt Pietal [Fri, 5 Apr 2019 12:32:47 +0000 (08:32 -0400)]
Sharesheet - Limit EXTRA_INITIAL_INTENTS to 2
Will eventually merge with suggested apps
Bug:
129979509
Test: ChooserActivityTest
Change-Id: I0e5f5a42155c83c77c6f6e355289218bc88033e7
Richard Uhler [Mon, 1 Apr 2019 12:02:31 +0000 (13:02 +0100)]
Fix rollbacks in multi-user case.
There are a few assumptions in the rollback manager that fail in the
multi-user case that need to be fixed:
* getAllSessions only returns sessions for the specific user.
* Session callbacks are only called on sessions associated with the
registered user.
* getPackageInfo only returns info for the specific user.
Fix these issues so that rollbacks will work properly, in particular
when the initial install session is owned by a non-system user.
Bug:
129809507
Bug:
129397974
Test: On single user device: atest RollbackTest StagedRollbackTest
Test: On primary user of multi-user device: atest RollbackTest StagedRollbackTest
Test: On multi user device manually:
adb install RollbackTestAppAv1.apk
adb install --user 10 --enable-rollback RollbackTestAppAv2.apk
-- verify the install succeeded --
adb shell pm rollback-app com.android.tests.rollback.testapp.A
-- verify the rollback succeeded --
Test: On multi user device manually:
adb install RollbackTestAppAv1.apk
adb install --staged --user 10 --enable-rollback RollbackTestAppAv2.apk
adb reboot
-- verify the install succeeded --
adb shell pm rollback-app com.android.tests.rollback.testapp.A
adb reboot
-- verify the rollback succeeded --
(cherry picked from commit
d81ff978667a776884362ef2461b3015c56117d1)
Merged-In: I1a7cf101b3bc3575421629c4bf0ff63418eb8731
Change-Id: I1a7cf101b3bc3575421629c4bf0ff63418eb8731
Susi Kharraz-Post [Fri, 5 Apr 2019 11:35:38 +0000 (11:35 +0000)]
Merge "Fast follow-on unit tests for HashedStringCache" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 09:45:40 +0000 (09:45 +0000)]
Merge "Refactor PackageWatchdog explicit health checks" into qt-dev
Sungsoo Lim [Fri, 5 Apr 2019 09:09:21 +0000 (09:09 +0000)]
Merge "Fix system_server watchdog timeout" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 08:02:37 +0000 (08:02 +0000)]
Merge "Fix NetworkStackTests." into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 06:49:33 +0000 (06:49 +0000)]
Merge "Set sdk_version for PluginCoreLib" into qt-dev
Kevin Chyn [Fri, 5 Apr 2019 06:33:37 +0000 (06:33 +0000)]
Merge "Add secure setting to cache attention" into qt-dev
Anil Admal [Fri, 5 Apr 2019 06:15:35 +0000 (06:15 +0000)]
Merge "Restore gnss@1.1 HAL capability bits removed in gnss@2.0 (framework)" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 05:33:13 +0000 (05:33 +0000)]
Merge "Sharesheet - Fix portrait -> landscape switch" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 05:10:58 +0000 (05:10 +0000)]
Merge "Remove unused flags from bubble controller" into qt-dev
Kevin Chyn [Fri, 5 Apr 2019 04:24:04 +0000 (04:24 +0000)]
Merge "Fix enumerate corner case" into qt-dev
Kevin Chyn [Fri, 5 Apr 2019 04:23:27 +0000 (04:23 +0000)]
Merge "Update BiometricPrompt default title" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 03:57:37 +0000 (03:57 +0000)]
Merge "Add back render-ahead support" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 03:30:48 +0000 (03:30 +0000)]
Merge "Add draw props back to greylist" into qt-dev
Jack Yu [Fri, 5 Apr 2019 03:17:40 +0000 (03:17 +0000)]
Merge "Improved the debug message" into qt-dev
Jack Yu [Thu, 4 Apr 2019 22:10:17 +0000 (15:10 -0700)]
Improved the debug message
Improved the log readability by printed out data state
in string format instead of integer. Also added listen
local log.
Bug:
129631771
Test: Manual
Change-Id: If786d51b35380f606bc388e29a441bb24a2792e0
TreeHugger Robot [Fri, 5 Apr 2019 02:42:44 +0000 (02:42 +0000)]
Merge "Adjust the physics params to values decided on in meeting w/ design." into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 02:41:01 +0000 (02:41 +0000)]
Merge "Update shape for all bubbles" into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 01:23:37 +0000 (01:23 +0000)]
Merge "Allow the WebView native library to have dependencies." into qt-dev
TreeHugger Robot [Fri, 5 Apr 2019 01:00:22 +0000 (01:00 +0000)]
Merge "Fix mixed up variable in triggering logic" into qt-dev
Kevin Chyn [Fri, 5 Apr 2019 00:44:01 +0000 (00:44 +0000)]
Merge "notifyEnabledOnKeyguardCallbacks when user switches" into qt-dev
Kevin Chyn [Fri, 5 Apr 2019 00:41:17 +0000 (00:41 +0000)]
Merge changes from topic "face-profile-qt-dev" into qt-dev
* changes:
Enroll for the correct user
Do not updateActiveGroup on a handler
Launch ConfirmDeviceCredential with actual userId
Settings should be per-profile
TreeHugger Robot [Fri, 5 Apr 2019 00:40:36 +0000 (00:40 +0000)]
Merge "Rename BluetoothManufacturerInfoReported to BluetoothDeviceInfoReported" into qt-dev
Kevin Chyn [Fri, 5 Apr 2019 00:13:50 +0000 (17:13 -0700)]
Add secure setting to cache attention
Fixes:
129912479
Test: Builds
Change-Id: I48979c65fc33bb5d70198f549a0ea863257e0247
Tim Murray [Thu, 4 Apr 2019 16:19:03 +0000 (09:19 -0700)]
zygote: initialize ashmem early
avoids dlopen of ashmemd_client in every app startup.
Test: boots, works, doesn't dlopen in app startup
Bug:
129543489
Change-Id: I76ba230af30cd007dbbca054e06660e8a30aca36
TreeHugger Robot [Fri, 5 Apr 2019 00:13:29 +0000 (00:13 +0000)]
Merge "Camera: Clarify camera1 API behavior for getNumberOfCameras" into qt-dev
Wonsik Kim [Fri, 5 Apr 2019 00:05:02 +0000 (00:05 +0000)]
Merge "media: fix documentation for MediaFormat.KEY_PREPEND_HEADERS_TO_SYNC_FRAMES" into qt-dev
Makoto Onuki [Thu, 4 Apr 2019 23:56:29 +0000 (23:56 +0000)]
Merge "Change ISE to AssertException, which is more suitable." into qt-dev
TreeHugger Robot [Thu, 4 Apr 2019 23:54:13 +0000 (23:54 +0000)]
Merge "WifiManager: Restore network pin behavior on enableNetwork" into qt-dev
TreeHugger Robot [Thu, 4 Apr 2019 23:43:30 +0000 (23:43 +0000)]
Merge "Fixup App Compaction CL nits." into qt-dev
TreeHugger Robot [Thu, 4 Apr 2019 23:42:57 +0000 (23:42 +0000)]
Merge "Don't show dnd suppressed icons on aod" into qt-dev
Zimuzo [Mon, 1 Apr 2019 17:54:17 +0000 (18:54 +0100)]
Refactor PackageWatchdog explicit health checks
Improvements:
1. Queuing PackageWatchdog requests to startObserving packages:
When observing packages with the watchdog, we needed to get
the packages supporting explicit health checks so we can decide if a
package should be passing or not. This prevents us from receiving
requests to monitor packages during early boot, before third party
packages are ready. In this change we don't depend on ExtServices to
be up to startObserving, we initially treat all package as failing a
health check and lazily syncRequests to request or cancel explicit
health checks based on the currently observed packages. When we receive
onSupportedPackages, we mark the packages that don't support health
checks as passing.
2. Lazy binding to the explicit health check service:
We were always bound to the explicit health check
service regardless of whether we are expecting requests or not, we need
to be able to bind and unbind dynamically to improve device resource
usage. In this change, we bind as soon as we make a request and are
expecting results, we unbind otherwise.
3. Fixed Races:
There were a couple of potential races that could lead to exceptions
that could bring the system server down, e.g when the service is
transitioning between disconnected and connected state (maybe it
crashed) or when ExtServices is being upated and is down or early
boot requests when third party apps are not ready. This change fixes such.
4. Logging:
We improved the logging wording and order and made it more consistent
Bug:
120598832
Test: Manual tests. Stress tested behavior by killing extservices and
making requests simultaneously
function killproc {
while true
do
local pid=$(adb shell pidof $1)
if [[ ! -z $pid ]]
then
echo $pid
adb shell kill $pid
fi
done;
}
adb install-multi-package -i com.android.shell --enable-rollback \
NetworkStack.apk ModuleMetadataGoogle.apk
Also switched between enabled and disabled states to verify packages
are handled correctly. Will automate these tests in later cl
atest PackageWatchdogTest
Change-Id: Iafaef553e95d107f700109f9a8328950a5e2bf71
TreeHugger Robot [Thu, 4 Apr 2019 23:22:55 +0000 (23:22 +0000)]
Merge "Introduce a result class for IStatusBarService#registerStatusBar()" into qt-dev
Amin Shaikh [Thu, 4 Apr 2019 22:21:19 +0000 (18:21 -0400)]
Update theme icon packs.
Mostly Settings, framework permission group icons and some SystemUI
volume dialog icons.
Bug:
129677355
Bug:
128354921
Test: make; install all overlays and change themes
Change-Id: I7099a050c6e4521e54fd258126e800dab3f66c3e
TreeHugger Robot [Thu, 4 Apr 2019 23:10:28 +0000 (23:10 +0000)]
Merge "Update systemui wifi icons to GM2." into qt-dev
John Reck [Thu, 4 Apr 2019 22:49:40 +0000 (15:49 -0700)]
Fix lifecycle issue in CommonPool
Destroy things more faster
Fixes:
129250875
Test: hwui_unit_tests
Change-Id: I7e060fcb61f5321dd9e68a3ee4a01868033b3fc3
Kevin Chyn [Thu, 4 Apr 2019 23:02:37 +0000 (16:02 -0700)]
notifyEnabledOnKeyguardCallbacks when user switches
The setting is per-user and the source of truth is in BiometricService.
Keyguard's cache needs to be updated when user switch occurs
Fixes:
5268106
Test: Builds
Change-Id: I8a5678375989221e5b502fa683697cf4ca664def
Kevin Chyn [Thu, 4 Apr 2019 22:50:11 +0000 (15:50 -0700)]
Enroll for the correct user
Bug:
110907543
Test: Builds
Change-Id: I637809cd18d84402918c95d1fc010dacc14f8785
TreeHugger Robot [Thu, 4 Apr 2019 22:48:01 +0000 (22:48 +0000)]
Merge "Fix for NetworkStats/Telephony deadlock" into qt-dev
Jack He [Thu, 4 Apr 2019 18:19:48 +0000 (11:19 -0700)]
Rename BluetoothManufacturerInfoReported to BluetoothDeviceInfoReported
* Rename this atom to match the atom's field name
Bug:
112969790
Test: make
Change-Id: Idb54766703f47a5eb6cd7f0cdff1c41e1a92cfb1
Salvador Martinez [Thu, 4 Apr 2019 17:30:19 +0000 (10:30 -0700)]
Fix mixed up variable in triggering logic
When this code got refactored the check for severe warnings
accidentally had the time remaining being compared against the percentage
value of the severe warning threshold. Unfortunately this meant that
it was impossible to mark the severe level warning as shown and could
result in multiple triggerings. This change makes it so everything
is compared with the appropriate type of value again.
Test: PowerUI Tests pass
Bug:
129730217
Change-Id: Ic8bdabf1c70e49d117210bb80f1ca0a0d7684617
Joshua Tsuji [Thu, 4 Apr 2019 21:50:02 +0000 (17:50 -0400)]
Adjust the physics params to values decided on in meeting w/ design.
Fixes:
129981373
Test: manual
Change-Id: Idfa840d6aade8ac975bd89bb0ba155f21e9f3ed8
Lyn Han [Thu, 4 Apr 2019 21:03:40 +0000 (14:03 -0700)]
Update shape for all bubbles
After theme change.
Test: manual
Bug:
123829494
Change-Id: I9eca25f19646607d85957f5113178619b7927dfe
Amin Shaikh [Tue, 2 Apr 2019 11:50:27 +0000 (07:50 -0400)]
Update systemui wifi icons to GM2.
Remove unneeded NeutralGoodDrawable.
Bug:
124106839
Test: make; used sysui demo mode
Change-Id: Ib3e903d83be140b00410e3adbb31f217b562d372
Makoto Onuki [Thu, 4 Apr 2019 20:39:55 +0000 (13:39 -0700)]
Change ISE to AssertException, which is more suitable.
Bug:
129139241
Bug:
129721058
Test: Treehugger
Change-Id: I12e97f37a58e1d88731a9bddd933abeb8c1169c1
Chris Craik [Thu, 4 Apr 2019 19:46:47 +0000 (12:46 -0700)]
Support profileable application action
Fixes:
129358330
Test: make -j16 aapt2_run_host_unit_tests && cat out/target/product/walleye/obj/PACKAGING/aapt2_run_host_unit_tests_intermediates/result.xml | grep "failure message"
Change-Id: Id9ec59447a99a5f6e0bfe47c0b8ce3553bf751c7
Yifan Hong [Thu, 4 Apr 2019 01:15:22 +0000 (18:15 -0700)]
Fix NetworkStackTests.
NetworkStackTests dlopens library which indirectly
uses libcgrouprc. Add it to jni_libs.
Test: atest
Fixes:
129902619
Change-Id: I0d60d7a317fa60607d6fdaea15f61b458aefd2f0
Merged-In: I0d60d7a317fa60607d6fdaea15f61b458aefd2f0
Kevin Chyn [Thu, 4 Apr 2019 01:12:48 +0000 (18:12 -0700)]
Do not updateActiveGroup on a handler
This method must not return to the caller until complete, otherwise
weird race conditions may occur.
Bug:
110907543
Test: Builds
Change-Id: Ia82671b34fac3662928012d8c709143efdf92266
Kevin Chyn [Thu, 4 Apr 2019 02:02:27 +0000 (19:02 -0700)]
Launch ConfirmDeviceCredential with actual userId
Fixes:
129905318
Bug:
110907543
Test: Set up work profile, use BiometricPromptDemo to allow device
credentials. Work profile demo app now requests work profile
password.
Change-Id: Iec53966c6ad87021fdaa1808a1814a4abfbf89bb
Kevin Chyn [Thu, 4 Apr 2019 03:28:28 +0000 (20:28 -0700)]
Settings should be per-profile
Fixes:
129905061
Test: Builds
Change-Id: If1b3e92da61c051c5f38a425da17f98cdfc3336d
Quang Luong [Tue, 2 Apr 2019 01:55:29 +0000 (18:55 -0700)]
Catch ArrayIndexOutOfBoundsException in StateMachine.toString()
StateMachine.toString() calls mSmHandler.getCurrentState(). In the
rare case when mStateStackTopIndex is -1 due to the StateMachine being
not yet initalized, this results in an ArrayIndexOutOfBoundsException.
Bug:
124858416
Test: none
Change-Id: Id558be95b6e12d8a923d325bca5f6f6d7f942b22
Wonsik Kim [Mon, 1 Apr 2019 21:48:10 +0000 (14:48 -0700)]
media: fix documentation for MediaFormat.KEY_PREPEND_HEADERS_TO_SYNC_FRAMES
Bug:
32746212
Test: builds
Change-Id: I38ecfa879091bc4016fbae04eab77ed6fd9eb1c1
Matt Pietal [Thu, 4 Apr 2019 19:49:48 +0000 (15:49 -0400)]
Sharesheet - Fix portrait -> landscape switch
Calculating the reserved height was using the wrong figures. Expose
the correct reserved alwaysShow height, and use it to determine the
offset for scrolling.
Bug:
120419081
Test: manual, rotate device
Change-Id: I21fd9fa8494a258d17f6002f79967aacc0efde34
Chong Zhang [Thu, 21 Mar 2019 19:33:27 +0000 (12:33 -0700)]
make libmedia_jni_utils depends on libgui
libmedia_jni_utils only has dependencies on libgui,
not entire libmedia_omx, it's linking to libmedia_omx
to get to libgui/bufferqueue headers.
bug:
129272021
test: builds
Change-Id: I48453cb53d36e6ecb2a6f6dd2b09f9a99e8479f0
(cherry picked from commit
a527e6d94b77b74545e09bd617b0060e2075eee2)
Susi Kharraz-Post [Thu, 4 Apr 2019 15:19:20 +0000 (11:19 -0400)]
Fast follow-on unit tests for HashedStringCache
Unit tests for HashedStringCache that was commited in earlier CL
ag/
6867725 . This is testing the various inputs and expected outputs.
Testing also revealed some vulnerability for invalid input so added
validation in the code under test.
Bug: b/
129870147
Test: This is the test file
Change-Id: I7387f808df87a869f81339cd4aea99b23dfc06bd
Hyunyoung Song [Thu, 4 Apr 2019 06:13:16 +0000 (23:13 -0700)]
Set sdk_version for PluginCoreLib
Bug:
129423457
Test: m Launcher3 && m Launcher3QuickStep
Change-Id: Iea69efb67d4aec124f29eb3cc956b96f5d06f1e7
Yohei Yukawa [Thu, 4 Apr 2019 18:49:02 +0000 (11:49 -0700)]
Introduce a result class for IStatusBarService#registerStatusBar()
This is a preparation to fix an issue that IME cannot enable light
navigation bar on direct-reply.
The initial state of StatusBar client is provided as return values of
IStatusBarService#registerStatusBar(). However, the way for the
client to receive the return values is to rely on "out" parameters in
the Binder method as follows.
void registerStatusBar(IStatusBar callbacks,
out List<String> iconSlots,
out List<StatusBarIcon> iconList,
out int[] switches,
out List<IBinder> binders,
out Rect fullscreenStackBounds,
out Rect dockedStackBounds);
The issue is that if I want to add a new parameter into
StatusBarManagerService to fix Bug
122439339, then it needs to be
notified back to the client via one of these out values, e.g. a new
element in "switches", which is hard to understand and maintain.
It'd be better to introduce a dedicated return object as follows.
RegisterStatusBarResult registerStatusBar(IStatusBar callbacks);
This is a purely mechanical code clean-up. Hence there should be no
behavior change.
Bug:
122439339
Test: presubmit
Change-Id: Ib1c0ae8f591ca09d0bce7a39f85ba57aad386e47
David Su [Wed, 3 Apr 2019 00:45:58 +0000 (17:45 -0700)]
wifi.proto: Add link probe event to StaEvent
Add link probe event type to StaEvent in order to correlate link probe
success/failure with other StaEvents (e.g. disconnection, score breach).
Bug:
112029045
Test: compiles
Change-Id: I2a18abc6f19179b164cd4c007597ba6cb69bf889
Todd Kennedy [Wed, 3 Apr 2019 22:19:53 +0000 (15:19 -0700)]
fix nullability
Bug:
126701951
Test: It builds, it runs
Merged-In: I43e02551ced8a6aa51b84dd8df7e57e75e1d58a9
Change-Id: I43e02551ced8a6aa51b84dd8df7e57e75e1d58a9
Eric Laurent [Wed, 3 Apr 2019 23:16:14 +0000 (16:16 -0700)]
Revert "Revert "Mute haptic channels by default.""
This reverts commit
e6243996efb90d6e9dd0b855aa47c8795cf4ba9f.
Bug:
129721367
Test: change volume in Play Music
(cherry picked from commit
ab3a3f8c02503f8a53a14f6b3f413e0cf739c957)
Change-Id: Id6e63e87265717130dde0e1b46e28edbb0b53edb
Eric Laurent [Wed, 3 Apr 2019 23:41:39 +0000 (16:41 -0700)]
fix AudioAttributes matching rule in AudioProductStrategy
The matching rule on audio attributes flags must be that ALL flags
set in the reference attributes are present in the compared attributes
and not just some flags.
Bug:
129721367
Test: change volume in Play Music
Change-Id: I462fd73fb9b78b094411c6f3b52004349f49bcf3
(cherry picked from commit
9b0bb840cd082822487e6cfe8c4470ce928d7531)
John Reck [Wed, 3 Apr 2019 23:47:42 +0000 (16:47 -0700)]
Add draw props back to greylist
Bug:
129957634
Test: none
Change-Id: Iaf2d7f8dc0f5d6f1b0dc12025210820bf8255f67
Evan Laird [Wed, 13 Mar 2019 16:54:37 +0000 (12:54 -0400)]
Expose notification guts on menu shown
This change adds a few methods to NotificationMenuRowPlugin so that a
menu row can tell the stack scroller to expose the notification guts
when the menu is fully exposed.
TODO: fix the menu close animation so it happens after the guts open,
and if you close the guts by swiping you can trigger a flicker.
Also there are some things to make lint happy and lots of null checks.
Bug:
127998765
Test: swipe RTL on any notification
Change-Id: I46f7c7dc90032a1914f7b5513bc57e089887c722
(cherry picked from commit
9272fd2f57e57475cb7ce9967e60946d0770d879)
John Reck [Wed, 13 Mar 2019 23:25:20 +0000 (16:25 -0700)]
Add back render-ahead support
Currently only supported in the EGL path.
Vulkan support Coming Soon
Bug:
127822449
Test: trace of hwuimacro
Change-Id: Iac2b039e11d964aab5b8ca1bdf2a5430b187e2ea
Lyn Han [Mon, 1 Apr 2019 22:59:56 +0000 (15:59 -0700)]
Remove unused flags from bubble controller
- ENABLE_BUBBLES_AT_TOP (default false)
- ENABLE_BUBBLE_FOOTER (default false)
Test: manual
Bug:
129546118
Change-Id: I6aaa33975d65fb20ba9b82a378e00c2100fd3164
Kevin Chyn [Fri, 29 Mar 2019 04:14:19 +0000 (21:14 -0700)]
Update BiometricPrompt default title
Fixes:
117466084
Test: manual
Change-Id: I3b82396694a26d63a79334e7e86c4e9121a370f6
Merged-In: I3b82396694a26d63a79334e7e86c4e9121a370f6
(cherry picked from commit
87fbeab12f708b3e987f89ad0c547f2315baac2a)
chaviw [Tue, 2 Apr 2019 20:59:28 +0000 (13:59 -0700)]
Only switch task focus to window's task that was tapped outside current focus
The previous logic would check what Task was at the coordinates that the event
receiver got. This was an issue if a window that was tapped didn't have a Task,
for example, system windows. The Task focus would get switched to the Task that
was behind the tapped window.
This change leverages the new API onPointerDownOutsideFocusLocked. When a down
outside focus occurs, WindowManager will check if the window has a Task + the
check that existed previously, before determining whether the new Task should
get focus.
Fixes:
129571534
Test: Steps from bug
Test: Resize in freeform continues to work.
Change-Id: I73286e03f505cdf37f30fa5914cf24f843a6bc7c
Kevin Chyn [Wed, 3 Apr 2019 21:39:04 +0000 (14:39 -0700)]
Fix enumerate corner case
Do not post reset runnable when another client is requested while
cleanup is happening. The runnable will be "pending" and started once
cleanup finishes instead.
Fixes:
129534163
Test: Based on logs in the bug, this is reasonable
Test: reboot device, fingerprint still works
Change-Id: I766cc04be151abaae60a0092f71fd7a3acf3397a
Merged-In: I766cc04be151abaae60a0092f71fd7a3acf3397a
(cherry picked from commit
ea80d17cb65e69457e169b0595094893ebabd494)
Jeff Sharkey [Thu, 4 Apr 2019 17:19:22 +0000 (11:19 -0600)]
Fix isExternalStorageSandboxed() bug.
It needs to use the same STOPSHIP logic for consistency with the
two other enforcement sites across the OS.
Bug:
129487770
Test: atest android.appsecurity.cts.ExternalStorageHostTest
Change-Id: I7a3fa836e0795912c264aae58a55472ffae3d8c3
Anil Admal [Wed, 3 Apr 2019 22:39:22 +0000 (15:39 -0700)]
Restore gnss@1.1 HAL capability bits removed in gnss@2.0 (framework)
In the IGnssCallback.hal@2.0 introduced in Android Q, the
capability bits in IGnssCallback.hal@1.1 that represent sub-HAL
interfaces have been removed as they are derivable from the
existing getExtensionXXX() family of methods in the IGnss.hal
interface.
These need to be restored back as the synchronous nature of the
getExtensionXXX() methods called by the framework has an impact on
partner implementations that need to communicate with the modem to
get the capabilities.
Additionally, the capability bit MEASUREMENT_CORRECTIONS needs to be
added for the new optional measurement_corrections@1.0 sub-HAL
introduced in gnss@2.0.
Fixes:
129870126
Test: Verified through cuttlefish default implementation and VTS tests.
Change-Id: I30c34361882e0722240feb3deba7d80136cd4bb3
Courtney Goeltzenleuchter [Wed, 3 Apr 2019 23:30:40 +0000 (17:30 -0600)]
EGLAttrib requires special handling in JNI
EGLAttrib is defined for a C / C++ interface and is
intended to be the size of a pointer. That can change
depending on which abi the code is built for but Java doesn't
have a way of dealing with such types. Java defines EGLAttrib
as a jlong, so need to convert jlong to 32bit when running on
a 32bit device.
Bug:
124382141
Test: atest --all-abi CtsGraphicsTestCases:EGL15Test
Change-Id: I966f6a3716b2710e17d10e0d0cb58314853675e0