OSDN Git Service
Marie Janssen [Thu, 13 Oct 2016 00:47:01 +0000 (00:47 +0000)]
Merge "cleanup: Remove BT_USE_TRACES and BT_TRACE_APPL" am:
14b3339e71 am:
0a859dabf8 am:
68f5854072
am:
0233cee19d
Change-Id: Ie10d53ecf8bb0a6dcd88979e87b313795225b7c4
Marie Janssen [Thu, 13 Oct 2016 00:41:33 +0000 (00:41 +0000)]
Merge "cleanup: Remove BT_USE_TRACES and BT_TRACE_APPL" am:
14b3339e71 am:
0a859dabf8
am:
68f5854072
Change-Id: Ibf813eba7a6748997c5693c28ab23b339a22e854
Marie Janssen [Thu, 13 Oct 2016 00:36:16 +0000 (00:36 +0000)]
Merge "cleanup: Remove BT_USE_TRACES and BT_TRACE_APPL" am:
14b3339e71
am:
0a859dabf8
Change-Id: I5cb910083965293b8aca2d37afbf7d02aa2f5cd6
Marie Janssen [Thu, 13 Oct 2016 00:27:13 +0000 (00:27 +0000)]
Merge "cleanup: Remove BT_USE_TRACES and BT_TRACE_APPL"
am:
14b3339e71
Change-Id: Id0d90c7ff59b86b9b685a635ef894c835c2ca1f9
Treehugger Robot [Thu, 13 Oct 2016 00:22:49 +0000 (00:22 +0000)]
Merge "cleanup: Remove BT_USE_TRACES and BT_TRACE_APPL"
Pavlin Radoslavov [Wed, 12 Oct 2016 23:11:53 +0000 (23:11 +0000)]
Fix file permissions for source code files am:
fdd641e512 am:
6046658298 am:
ec94a1259f
am:
7f34882438
Change-Id: Ia7efab59c3b724e47909372ddcad88bf5c91120a
Pavlin Radoslavov [Wed, 12 Oct 2016 23:05:34 +0000 (23:05 +0000)]
Fix file permissions for source code files am:
fdd641e512 am:
6046658298
am:
ec94a1259f
Change-Id: Ia2cd3c85eb64b0c69a872da1475753728f1a5b27
Pavlin Radoslavov [Wed, 12 Oct 2016 23:00:03 +0000 (23:00 +0000)]
Fix file permissions for source code files am:
fdd641e512
am:
6046658298
Change-Id: I581da1e3d2180a10cedaa8d03721769ba3b83ef6
Pavlin Radoslavov [Wed, 12 Oct 2016 22:50:07 +0000 (22:50 +0000)]
Fix file permissions for source code files
am:
fdd641e512
Change-Id: I80c163e8bfc2ba6f087b60dcc8833bd373289f35
Pavlin Radoslavov [Wed, 12 Oct 2016 19:54:05 +0000 (12:54 -0700)]
Fix file permissions for source code files
Removed file execute permissions for:
- bta/include/bta_hh_co.h
- embdrv/sbc/decoder/Android.mk
- embdrv/sbc/Android.mk
- embdrv/Android.mk
- btif/co/bta_ag_co.cc
Test: visual inspection of file permissions
Change-Id: I746debb1e8ceaa1cc14f867641b25cb42c04c7be
Marie Janssen [Wed, 12 Oct 2016 19:40:57 +0000 (12:40 -0700)]
cleanup: Remove BT_USE_TRACES and BT_TRACE_APPL
Test: mma in system/bt
Change-Id: I357eb44a97f3935262252cf97c13cef078a95e4d
Zach Johnson [Wed, 12 Oct 2016 17:26:55 +0000 (17:26 +0000)]
Merge "Fix HFP AT command BIA failures" into cw-f-dev am:
68b0ac8b42
am:
d2e4941d93
Change-Id: I3541973c12ddb1844bc36fde91b566063f284b61
Devin Kim [Wed, 12 Oct 2016 17:26:45 +0000 (17:26 +0000)]
Fix HFP AT command BIA failures am:
1b3e27469d
am:
0b7ff8d856
Change-Id: I879f864059fd105647ecd97337743ba1834cf6e8
Zach Johnson [Wed, 12 Oct 2016 17:19:18 +0000 (17:19 +0000)]
Merge "Fix HFP AT command BIA failures" into cw-f-dev
am:
68b0ac8b42
Change-Id: Ib0b7acd72e0459f4c1ebc5a4a4635e87350eb043
Devin Kim [Wed, 12 Oct 2016 17:19:17 +0000 (17:19 +0000)]
Fix HFP AT command BIA failures
am:
1b3e27469d
Change-Id: I9ac298b5a6d3d80b8ca6cc59e9c48f84c2c23e67
Zach Johnson [Wed, 12 Oct 2016 17:08:27 +0000 (17:08 +0000)]
Merge "Fix HFP AT command BIA failures" into cw-f-dev
Marie Janssen [Wed, 12 Oct 2016 16:46:08 +0000 (16:46 +0000)]
Merge "btif: migrate from pthread locks to std::mutex" am:
84ada302fe am:
d88f6a183c am:
2f351e9cea
am:
98d8f6136e
Change-Id: Ib799a3444c4e2baffc4be72ee7585977207f8c83
Marie Janssen [Wed, 12 Oct 2016 16:38:36 +0000 (16:38 +0000)]
Merge "btif: migrate from pthread locks to std::mutex" am:
84ada302fe am:
d88f6a183c
am:
2f351e9cea
Change-Id: I50607e319fdd1bb1c88e57835ae2a0418fc5f5bf
Marie Janssen [Wed, 12 Oct 2016 16:33:59 +0000 (16:33 +0000)]
Merge "btif: migrate from pthread locks to std::mutex" am:
84ada302fe
am:
d88f6a183c
Change-Id: I56962683a83454426f1bb35959f3a60a6105c6c5
Marie Janssen [Wed, 12 Oct 2016 16:24:43 +0000 (16:24 +0000)]
Merge "btif: migrate from pthread locks to std::mutex"
am:
84ada302fe
Change-Id: Ifab7477d07b3f49aa2469bdc6f0fae68f2f948f7
Devin Kim [Wed, 7 Sep 2016 04:47:47 +0000 (13:47 +0900)]
Fix HFP AT command BIA failures
Running the PTE test case TC_AG_IIA_BV_01_I, a failure occurs due to
missing initialization of tBTA_AG_VAL.
Bug:
31325270
Test: PTS
Change-Id: I683eccd53d40e79ec03545166b18ffa1922f0fb2
Marie Janssen [Wed, 12 Oct 2016 16:17:42 +0000 (16:17 +0000)]
Merge "btif: migrate from pthread locks to std::mutex"
Pavlin Radoslavov [Wed, 12 Oct 2016 02:57:04 +0000 (02:57 +0000)]
Moved the typedef of period_ms_t from alarm.h to time.h am:
d92fc91abb am:
0df62ad6c6 am:
6cfcd7d1db
am:
85cb5d1a33
Change-Id: I8aa7fa1cb5128a80f3d27ac74bb22ed71b34fc85
Pavlin Radoslavov [Wed, 12 Oct 2016 02:50:42 +0000 (02:50 +0000)]
Moved the typedef of period_ms_t from alarm.h to time.h am:
d92fc91abb am:
0df62ad6c6
am:
6cfcd7d1db
Change-Id: I8341cd7b335664763d7e837d0a453766e7d522e8
Pavlin Radoslavov [Wed, 12 Oct 2016 02:45:50 +0000 (02:45 +0000)]
Moved the typedef of period_ms_t from alarm.h to time.h am:
d92fc91abb
am:
0df62ad6c6
Change-Id: I51c08d7dba2a316424a995c4d6a6429117010972
Pavlin Radoslavov [Wed, 12 Oct 2016 02:36:55 +0000 (02:36 +0000)]
Moved the typedef of period_ms_t from alarm.h to time.h
am:
d92fc91abb
Change-Id: Ied9b5b09295972e29b67ba605098ad1e51c742fb
Pavlin Radoslavov [Wed, 12 Oct 2016 00:46:45 +0000 (17:46 -0700)]
Moved the typedef of period_ms_t from alarm.h to time.h
Test: code compilation
Change-Id: Ib61126d7921d088b045dca6c5b69a5379603fcc3
Marie Janssen [Mon, 10 Oct 2016 20:38:30 +0000 (13:38 -0700)]
btif: migrate from pthread locks to std::mutex
Test: run unit tests / sanity connection to devices
Change-Id: I293c3600affd229fea67cdd6624eba7f186cbcb7
Stephen Li [Tue, 11 Oct 2016 17:54:29 +0000 (17:54 +0000)]
Manually merge commit '
cc15f06acc3a1447318fefae00b3c10d9b7ae42a' to fix automerger am:
9ad78d6513 am:
8ac85b2361 am:
fb6d60efd7
am:
f60e6f92d6
Change-Id: I06019bf97c252c44b199fa26372f95bcc8d93636
Marie Janssen [Tue, 11 Oct 2016 17:54:16 +0000 (17:54 +0000)]
stack: remove dead (#if 0'd) code am:
af7b39e595 am:
140f7c1dfd am:
0439d33163
am:
6d78924b1c
Change-Id: I01d2ffb1f02900d1294a7ce7e4889371309328e5
Ajay Panicker [Tue, 11 Oct 2016 17:54:04 +0000 (17:54 +0000)]
Fix improper connection check for absolute volume am:
446df0360e am:
a3d9a4fe1f am:
04d76dcf14
am:
bb7694dfe5
Change-Id: I100b60ca785ca8b26ee0f6952c287db402785221
George Burgess IV [Tue, 11 Oct 2016 17:53:52 +0000 (17:53 +0000)]
Replace all uses of sprintf() with snprint() am:
80d7f60680 am:
9b0247eb7f am:
9b943e7eed
am:
d34293ac34
Change-Id: If3e5c9cdeb43d79ffaa9b902f438f6baf4333c86
Andre Eisenbach [Tue, 11 Oct 2016 17:53:42 +0000 (17:53 +0000)]
Merge "Revert "Add dumpsys support for LE connection parameter updates"" am:
b2f7a959fd am:
34b83d600c am:
f06af0cd46
am:
6b5cac7d75
Change-Id: Ied3f78bbf9180919269f076346d76daf96767ab6
Andre Eisenbach [Tue, 11 Oct 2016 17:53:30 +0000 (17:53 +0000)]
Remove Jabra headsets from absolute volume blacklist am:
98c7415e95 am:
ecc90d0f7b am:
1c25f2abd6
am:
88edc0b560
Change-Id: I0a2d4eff2acd23a3cdcd5e3a750107367d73e40f
Jakub Pawlowski [Tue, 11 Oct 2016 17:52:21 +0000 (17:52 +0000)]
Convert advertising HAL from struct into class (3/3) am:
74ef54b440 am:
90b9015e77 am:
f3b6c2a566
am:
fa10bcf5e2
Change-Id: Ia685bcef2a77f384c341c8e89965e22f5f3af027
Jakub Pawlowski [Tue, 11 Oct 2016 17:52:03 +0000 (17:52 +0000)]
Merge "Remove return value of BTM_VendorSpecificCommand function" am:
d4b958bced am:
459373a3d0 am:
9d6cf09525
am:
0fde896da5
Change-Id: Ib3e362dedff548cb5e341830ca2a464a9dc16d9a
Stephen Li [Tue, 11 Oct 2016 17:48:10 +0000 (17:48 +0000)]
Manually merge commit '
cc15f06acc3a1447318fefae00b3c10d9b7ae42a' to fix automerger am:
9ad78d6513 am:
8ac85b2361
am:
fb6d60efd7
Change-Id: I26739f40b456f7d01a588a81ff33b3bd76a30a47
Marie Janssen [Tue, 11 Oct 2016 17:47:59 +0000 (17:47 +0000)]
stack: remove dead (#if 0'd) code am:
af7b39e595 am:
140f7c1dfd
am:
0439d33163
Change-Id: I39041eff68527fdc73d3971a8294d34483dd714f
Ajay Panicker [Tue, 11 Oct 2016 17:47:47 +0000 (17:47 +0000)]
Fix improper connection check for absolute volume am:
446df0360e am:
a3d9a4fe1f
am:
04d76dcf14
Change-Id: Ib0468696f933b3263ab950688af076df3c309115
George Burgess IV [Tue, 11 Oct 2016 17:47:35 +0000 (17:47 +0000)]
Replace all uses of sprintf() with snprint() am:
80d7f60680 am:
9b0247eb7f
am:
9b943e7eed
Change-Id: If7c92a9a9e4c353a8fae189f56ef1c305af164e0
Andre Eisenbach [Tue, 11 Oct 2016 17:47:23 +0000 (17:47 +0000)]
Merge "Revert "Add dumpsys support for LE connection parameter updates"" am:
b2f7a959fd am:
34b83d600c
am:
f06af0cd46
Change-Id: I9c666513978590c8ec2fead462057adf339bb65d
Andre Eisenbach [Tue, 11 Oct 2016 17:47:11 +0000 (17:47 +0000)]
Remove Jabra headsets from absolute volume blacklist am:
98c7415e95 am:
ecc90d0f7b
am:
1c25f2abd6
Change-Id: Ib21cd8d3297010ecee959d7a43d0033d576019a1
Jakub Pawlowski [Tue, 11 Oct 2016 17:46:07 +0000 (17:46 +0000)]
Convert advertising HAL from struct into class (3/3) am:
74ef54b440 am:
90b9015e77
am:
f3b6c2a566
Change-Id: Ib090a816dcc7c65dbfeafc746b7cee95f5ce787b
Jakub Pawlowski [Tue, 11 Oct 2016 17:45:52 +0000 (17:45 +0000)]
Merge "Remove return value of BTM_VendorSpecificCommand function" am:
d4b958bced am:
459373a3d0
am:
9d6cf09525
Change-Id: Ic090db35b4174ebc2cc8b6dcb62b6afbbcb7cab3
Stephen Li [Tue, 11 Oct 2016 17:42:30 +0000 (17:42 +0000)]
Manually merge commit '
cc15f06acc3a1447318fefae00b3c10d9b7ae42a' to fix automerger am:
9ad78d6513
am:
8ac85b2361
Change-Id: I169323587b9a57c3ce8dbad4e2b328244d3d43e4
Marie Janssen [Tue, 11 Oct 2016 17:42:18 +0000 (17:42 +0000)]
stack: remove dead (#if 0'd) code am:
af7b39e595
am:
140f7c1dfd
Change-Id: I78a6c99c9711829f04316efccba9513d0eafa40a
Ajay Panicker [Tue, 11 Oct 2016 17:42:08 +0000 (17:42 +0000)]
Fix improper connection check for absolute volume am:
446df0360e
am:
a3d9a4fe1f
Change-Id: I4c8b215f0baec13b5bbe174dc38c216177e81752
George Burgess IV [Tue, 11 Oct 2016 17:41:56 +0000 (17:41 +0000)]
Replace all uses of sprintf() with snprint() am:
80d7f60680
am:
9b0247eb7f
Change-Id: I1f7c64866a7ffc2c34405049074d6699906e4c1c
Andre Eisenbach [Tue, 11 Oct 2016 17:41:45 +0000 (17:41 +0000)]
Merge "Revert "Add dumpsys support for LE connection parameter updates"" am:
b2f7a959fd
am:
34b83d600c
Change-Id: Id4701d42adbd07672659e6a7ad46114f5e454e17
Andre Eisenbach [Tue, 11 Oct 2016 17:41:34 +0000 (17:41 +0000)]
Remove Jabra headsets from absolute volume blacklist am:
98c7415e95
am:
ecc90d0f7b
Change-Id: I4d432404d0e2e3d9b1dcf9bb02bd917e4a51837f
Jakub Pawlowski [Tue, 11 Oct 2016 17:40:26 +0000 (17:40 +0000)]
Convert advertising HAL from struct into class (3/3) am:
74ef54b440
am:
90b9015e77
Change-Id: I420874bb6bc76741324f73e8b31c40418c8b36ee
Jakub Pawlowski [Tue, 11 Oct 2016 17:40:11 +0000 (17:40 +0000)]
Merge "Remove return value of BTM_VendorSpecificCommand function" am:
d4b958bced
am:
459373a3d0
Change-Id: Ia5118dcea23fa15a5f907b9653ad2ff41a4e52ec
Stephen Li [Tue, 11 Oct 2016 17:35:51 +0000 (17:35 +0000)]
Manually merge commit '
cc15f06acc3a1447318fefae00b3c10d9b7ae42a' to fix automerger
am:
9ad78d6513
Change-Id: Ie67f15b078eeb20862cafce05ecca598bcbad6ab
Marie Janssen [Tue, 11 Oct 2016 17:35:41 +0000 (17:35 +0000)]
stack: remove dead (#if 0'd) code
am:
af7b39e595
Change-Id: I2932190abc5c3553271419461c91afc96881aa23
Ajay Panicker [Tue, 11 Oct 2016 17:35:30 +0000 (17:35 +0000)]
Fix improper connection check for absolute volume
am:
446df0360e
Change-Id: I72486575e10b46f8efb19c833210ae63d60a8bbb
George Burgess IV [Tue, 11 Oct 2016 17:35:20 +0000 (17:35 +0000)]
Replace all uses of sprintf() with snprint()
am:
80d7f60680
Change-Id: I6a988bb6bfe61aaab1e05318b21be545b48f7e0f
Andre Eisenbach [Tue, 11 Oct 2016 17:35:10 +0000 (17:35 +0000)]
Merge "Revert "Add dumpsys support for LE connection parameter updates""
am:
b2f7a959fd
Change-Id: Id532466a62d7100feedea66f7e09fec9e0c1ddba
Andre Eisenbach [Tue, 11 Oct 2016 17:35:00 +0000 (17:35 +0000)]
Remove Jabra headsets from absolute volume blacklist
am:
98c7415e95
Change-Id: Ib34049bc751e0d8b423d1a38ae4cf698bc97fd73
Jakub Pawlowski [Tue, 11 Oct 2016 17:33:13 +0000 (17:33 +0000)]
Convert advertising HAL from struct into class (3/3)
am:
74ef54b440
Change-Id: I66f71a46d96d03de4dbe57fa3d38fd2cf2b6239f
Jakub Pawlowski [Tue, 11 Oct 2016 17:32:58 +0000 (17:32 +0000)]
Merge "Remove return value of BTM_VendorSpecificCommand function"
am:
d4b958bced
Change-Id: I5d3b90dd514ea5c5170eaed4124ec4449db3ebe9
Stephen Li [Tue, 11 Oct 2016 17:27:31 +0000 (10:27 -0700)]
Manually merge commit '
cc15f06acc3a1447318fefae00b3c10d9b7ae42a' to fix
automerger
BUG:
32069275
Change-Id: I60cc50b21fe0d5a5464bd3acc5897ba7c4e05b73
Marie Janssen [Mon, 10 Oct 2016 16:49:14 +0000 (09:49 -0700)]
stack: remove dead (#if 0'd) code
Test: compiles
Change-Id: I34f68c2b166a28622155358ff75478af8d18bed0
Ajay Panicker [Tue, 11 Oct 2016 03:43:42 +0000 (20:43 -0700)]
Fix improper connection check for absolute volume
Test: Manually tested
Bug:
32060762
Change-Id: Ia6ca97c119d421aef1136f97afccb3f0c126334d
George Burgess IV [Wed, 2 Mar 2016 22:00:19 +0000 (14:00 -0800)]
Replace all uses of sprintf() with snprint()
- sprintf() does not limit the length of the character string when writing
to a buffer and may result in buffer overflow
- snprintf() requires the maximum write length as a parameter. When the
maximum length supported is smaller than the reserved buffer length,
the call will not result in buffer overflow
Bug:
31859081
Test: TestTracker/64195/3975
Change-Id: I519f8ef7b9b162fd79094f89148250d783c734c0
Treehugger Robot [Mon, 10 Oct 2016 23:44:10 +0000 (23:44 +0000)]
Merge "Revert "Add dumpsys support for LE connection parameter updates""
Joseph Pirozzo [Mon, 10 Oct 2016 22:54:07 +0000 (22:54 +0000)]
Merge "L2CAP: Ensure handle is not null before attempting to close a socket" am:
171c14eae0 am:
eee39a51e6 am:
d9bd1d15c2
am:
67e450fb89
Change-Id: Ie6197477da3bf5e96b57749d3fe3e035570d2db7
Jakub Pawlowski [Mon, 10 Oct 2016 22:53:39 +0000 (22:53 +0000)]
Remove return value from btsnd_hcic_* functions am:
763abdfe79 am:
83eb6b9d71 am:
c846a8448d
am:
947305d348
Change-Id: I899fea7dd6e5a04d3e1c5694d30f5652b5cfb988
Jakub Pawlowski [Mon, 10 Oct 2016 22:53:33 +0000 (22:53 +0000)]
Ignore return value of btsnd_hcic_* functions am:
b6ab9b3af6 am:
bf1ff14834 am:
4e0e0fe522
am:
cc0d806149
Change-Id: I164ed1ef613b73a31cd89ee5a6a661390fa9aa3b
Andre Eisenbach [Tue, 13 Sep 2016 16:57:51 +0000 (09:57 -0700)]
Remove Jabra headsets from absolute volume blacklist
Firmware fixes are available for affected headsets (Thanks, Jabra!!).
Change-Id: I60b42366d1e8155895cc58fff69f6404415a0406
Joseph Pirozzo [Mon, 10 Oct 2016 22:44:42 +0000 (22:44 +0000)]
Merge "L2CAP: Ensure handle is not null before attempting to close a socket" am:
171c14eae0 am:
eee39a51e6
am:
d9bd1d15c2
Change-Id: Ib82bd66671d064876c6e99623fe6f9b53dbe90c8
Jakub Pawlowski [Mon, 10 Oct 2016 22:44:22 +0000 (22:44 +0000)]
Remove return value from btsnd_hcic_* functions am:
763abdfe79 am:
83eb6b9d71
am:
c846a8448d
Change-Id: I67241af4df6314ca80b0d86cc3751405ee092c2d
Jakub Pawlowski [Mon, 10 Oct 2016 22:44:16 +0000 (22:44 +0000)]
Ignore return value of btsnd_hcic_* functions am:
b6ab9b3af6 am:
bf1ff14834
am:
4e0e0fe522
Change-Id: I01c91b569afeb4dc0504f28b9420cf3bc848ef3f
Joseph Pirozzo [Mon, 10 Oct 2016 22:28:20 +0000 (22:28 +0000)]
Merge "L2CAP: Ensure handle is not null before attempting to close a socket" am:
171c14eae0
am:
eee39a51e6
Change-Id: I208840b1bf2927ce0b14ef853ae801447e377926
Jakub Pawlowski [Mon, 10 Oct 2016 22:28:02 +0000 (22:28 +0000)]
Remove return value from btsnd_hcic_* functions am:
763abdfe79
am:
83eb6b9d71
Change-Id: I43c09615eccb67a8c079a5b1ac25325acc254b5a
Jakub Pawlowski [Mon, 10 Oct 2016 22:27:57 +0000 (22:27 +0000)]
Ignore return value of btsnd_hcic_* functions am:
b6ab9b3af6
am:
bf1ff14834
Change-Id: I1c4ccf0bc72c73be53018882c716a325e908812b
Jakub Pawlowski [Thu, 6 Oct 2016 23:52:30 +0000 (16:52 -0700)]
Convert advertising HAL from struct into class (3/3)
Bug:
30622771
Test: all related tests were updated
Change-Id: I9695284ae249fa427ae4b2f3e9649da951102c6c
Treehugger Robot [Mon, 10 Oct 2016 22:21:36 +0000 (22:21 +0000)]
Merge "Remove return value of BTM_VendorSpecificCommand function"
Jakub Pawlowski [Mon, 10 Oct 2016 19:36:49 +0000 (12:36 -0700)]
Remove return value of BTM_VendorSpecificCommand function
The return value of BTM_VendorSpecificCommand is currently just an
information wether the callback was passed to it or not, but many places
through stack use this value as error indication. Remove it.
Test: unit tests pass
Change-Id: Idf73fc49fb25e52c3aeb64f2305b4498ecacd9a4
Andre Eisenbach [Thu, 6 Oct 2016 22:42:22 +0000 (22:42 +0000)]
Revert "Add dumpsys support for LE connection parameter updates"
Reverting for now after talking to Jacky because this causes circular dependencies as lower layer (stack/) functions are calling higher layer APIs (btif/) directly.
To restore a change like this, the data should be collected at a lower layer in the stack and reported through polling or a callback.
This reverts commit
8ec8ca4a875eed8b28e6714899f49781537411ae.
Change-Id: I748843864ae7198ea021fe70d2643a62097ab029
Joseph Pirozzo [Mon, 10 Oct 2016 21:28:41 +0000 (21:28 +0000)]
Merge "L2CAP: Ensure handle is not null before attempting to close a socket"
am:
171c14eae0
Change-Id: I67fb6fa41c43625d428876bf5e54a8dae0356619
Jakub Pawlowski [Mon, 10 Oct 2016 21:27:36 +0000 (21:27 +0000)]
Remove return value from btsnd_hcic_* functions
am:
763abdfe79
Change-Id: I4248cbfafdc297d8053b12d26f1791d00dbf359e
Jakub Pawlowski [Mon, 10 Oct 2016 21:27:34 +0000 (21:27 +0000)]
Ignore return value of btsnd_hcic_* functions
am:
b6ab9b3af6
Change-Id: Id0f22cafe797ddd5934d5e0685a65123c6a4f089
Treehugger Robot [Mon, 10 Oct 2016 20:19:29 +0000 (20:19 +0000)]
Merge "L2CAP: Ensure handle is not null before attempting to close a socket"
Jakub Pawlowski [Mon, 10 Oct 2016 19:36:49 +0000 (12:36 -0700)]
Remove return value of BTM_VendorSpecificCommand function
The return value of BTM_VendorSpecificCommand is currently just an
information wether the callback was passed to it or not, but many places
through stack use this value as error indication. Remove it.
Test: unit tests pass
Change-Id: Idf73fc49fb25e52c3aeb64f2305b4498ecacd9a4
Jakub Pawlowski [Mon, 10 Oct 2016 18:39:39 +0000 (11:39 -0700)]
Remove return value from btsnd_hcic_* functions
btsnd_hcic_* functions are always returning true, so this return value
is not really useful.
Test: unit tests pass
Change-Id: I06ced65392d180ceed565e45b7831de6aede283c
Jakub Pawlowski [Mon, 10 Oct 2016 16:35:13 +0000 (09:35 -0700)]
Ignore return value of btsnd_hcic_* functions
btsnd_hcic_* functions return only true. This patch makes sure that no
logic is waiting for "false" value.
Few methods, that had their return value dependent on result of
btsnd_hcic_* were made void.
Test: unit tests pass
Change-Id: I43cff62f461ff35f4bd84e5338f1a587b6a05c58
Joseph Pirozzo [Mon, 10 Oct 2016 14:05:51 +0000 (07:05 -0700)]
L2CAP: Ensure handle is not null before attempting to close a socket
Bug:
32054308
Test: manual, UPF 55
Change-Id: Ib89f7557fa390d60691afe8399a768e8127e52cb
(cherry picked from commit
a1fa1bb0d638d5f444bf959fb839e824d69de31d)
Gurpreet Ghai [Fri, 7 Oct 2016 20:17:47 +0000 (20:17 +0000)]
Merge "Add null check to avoid exception after L2CAP psm assigned" am:
ee85d35220 am:
defed78c2a am:
cdd852f7c1
am:
1c35575d3a
Change-Id: I80d95a095f17fff65dc1f9e354776ef8e19b2283
Ben YoungTae Kim [Fri, 7 Oct 2016 20:17:35 +0000 (20:17 +0000)]
HID: Fix to handle UHID_OUTPUT_EV command from UHID driver am:
960b9c391d am:
9dfee34e3f am:
1fa91ea4a9
am:
a854735b8a
Change-Id: If9f5ff685d852efc81d18f2f438ba46a108f5543
Gurpreet Ghai [Fri, 7 Oct 2016 20:07:23 +0000 (20:07 +0000)]
Merge "Add null check to avoid exception after L2CAP psm assigned" am:
ee85d35220 am:
defed78c2a
am:
cdd852f7c1
Change-Id: Id2a3d73a939f51b4e618768ef744ad94f17e496f
Ben YoungTae Kim [Fri, 7 Oct 2016 20:07:14 +0000 (20:07 +0000)]
HID: Fix to handle UHID_OUTPUT_EV command from UHID driver am:
960b9c391d am:
9dfee34e3f
am:
1fa91ea4a9
Change-Id: Iaf8eb1724a01e5209caac6d16dad8f0e1888579d
Gurpreet Ghai [Fri, 7 Oct 2016 20:02:49 +0000 (20:02 +0000)]
Merge "Add null check to avoid exception after L2CAP psm assigned" am:
ee85d35220
am:
defed78c2a
Change-Id: I6602872885f941baf842aba7de05ff602c33e7ba
Ben YoungTae Kim [Fri, 7 Oct 2016 20:02:39 +0000 (20:02 +0000)]
HID: Fix to handle UHID_OUTPUT_EV command from UHID driver am:
960b9c391d
am:
9dfee34e3f
Change-Id: Ibd3acdfdf31b7fb31dc07288f4d8bd46895c4cba
Gurpreet Ghai [Fri, 7 Oct 2016 19:58:52 +0000 (19:58 +0000)]
Merge "Add null check to avoid exception after L2CAP psm assigned"
am:
ee85d35220
Change-Id: Ie16d5d2af12291c02a47e6ce39fc002503063b93
Ben YoungTae Kim [Fri, 7 Oct 2016 19:58:43 +0000 (19:58 +0000)]
HID: Fix to handle UHID_OUTPUT_EV command from UHID driver
am:
960b9c391d
Change-Id: I47e7a4edfdf075223b8eb3115a31ff0a5541aa7d
Treehugger Robot [Fri, 7 Oct 2016 19:51:54 +0000 (19:51 +0000)]
Merge "Add null check to avoid exception after L2CAP psm assigned"
Ben YoungTae Kim [Wed, 10 Aug 2016 20:31:23 +0000 (13:31 -0700)]
HID: Fix to handle UHID_OUTPUT_EV command from UHID driver
Incorrect size check for UHID_OUTPUT_EV for incoming data from
UHID driver of kernel was leading to exiting of poll thread.
This was causing IOT issues with Apple Magic Mouse that require
output report to be sent for proper functioning of scroll functionality.
Bug:
28942565
Change-Id: I2eaba1f70b7cd51fb21933031d439543eb141fd2
Gurpreet Ghai [Wed, 3 Feb 2016 09:31:41 +0000 (15:01 +0530)]
Add null check to avoid exception after L2CAP psm assigned
Use case: BT will get crash in SNS testing.
steps: SNS testing BT ON/OFF.
Failure: Crash is observed.
Root Cause: If the number of supported services increased,
larger service record array is required. Smaller array is
resulting in out of record error causing L2CAP deregister.
Fix: Check added to avoid null pointer exception if null
is returned while fetching sock from id. Also cleanup of
SDP and security records done during BT turning Off.
Change-Id: I2e77127262119cabf2c372f894427dcdf3350e80
Jakub Pawlowski [Thu, 6 Oct 2016 23:50:16 +0000 (23:50 +0000)]
Refactor advertising data types am:
9eaf776867 am:
8b081eb046 am:
86d0de756f
am:
5e61d912f0
Change-Id: I7e195ad2831c1cdc79eb8b162599d32e7c714bb5
Jakub Pawlowski [Thu, 6 Oct 2016 23:22:45 +0000 (23:22 +0000)]
Refactor advertising data types am:
9eaf776867 am:
8b081eb046
am:
86d0de756f
Change-Id: I2a01a5e54b5b160c7f6b9496697b3c5af4dbc214