OSDN Git Service
Alex Sakhartchouk [Fri, 15 Jul 2011 17:57:33 +0000 (10:57 -0700)]
Merge "For the serialization context, no fifo initialization is necessary."
Gilles Debunne [Fri, 15 Jul 2011 17:55:32 +0000 (10:55 -0700)]
Merge "Bug
4382356: No automatic focus change in ScrollViews"
Fred Quintana [Fri, 15 Jul 2011 17:10:07 +0000 (10:10 -0700)]
Merge "Make the KeyChain handled its own grants rather than having AccountManagerService handle them."
Gilles Debunne [Fri, 15 Jul 2011 16:56:30 +0000 (09:56 -0700)]
Bug
4382356: No automatic focus change in ScrollViews
The current behavior in ScrollView is inconsistent: a slow scroll will
not change focus while a fling will. With this change, the focus is not
moved from field to field (resulting in poup due to keyboard / suggestion bar
state changes).
Also made sure any new input in a TextFields scrolls back the view to make the
EditText visible. Has no effect if the EditText is already visible.
Change-Id: I7ff301fe85f73c27d76e4893aeab7442d0539b13
Fabrice Di Meglio [Fri, 15 Jul 2011 16:49:48 +0000 (09:49 -0700)]
Merge "Implement textDirection heuristic selection."
Gilles Debunne [Fri, 15 Jul 2011 16:41:16 +0000 (09:41 -0700)]
Merge "Bug
5014726: Paste works in ExtractedText"
Glenn Kasten [Fri, 15 Jul 2011 16:23:33 +0000 (09:23 -0700)]
Merge "Bug
5031179 possible fix for assert in join"
Mike Lockwood [Fri, 15 Jul 2011 16:18:34 +0000 (09:18 -0700)]
Merge "MediaScanner: Add virtual NO_MEDIA column to fix support for .nomedia files"
Mike Lockwood [Fri, 15 Jul 2011 13:45:11 +0000 (09:45 -0400)]
MediaScanner: Add virtual NO_MEDIA column to fix support for .nomedia files
Bug:
5025615
Change-Id: Ia910cd1c063292599a03b878755edb2e3cdbbb57
Signed-off-by: Mike Lockwood <lockwood@android.com>
Narayan Kamath [Fri, 15 Jul 2011 09:56:31 +0000 (02:56 -0700)]
Merge "Remove the completeAudioAvailable API."
Jeff Brown [Fri, 15 Jul 2011 05:42:15 +0000 (22:42 -0700)]
Merge "Ensure selector state is updated when touch mode changes."
Jeff Brown [Fri, 15 Jul 2011 05:32:09 +0000 (22:32 -0700)]
Merge "Remove edge slop support."
Jeff Brown [Fri, 15 Jul 2011 05:31:40 +0000 (22:31 -0700)]
Merge "Refresh the drawable state when selecting a position."
Jeff Brown [Fri, 15 Jul 2011 05:31:34 +0000 (22:31 -0700)]
Merge "ListView focus bugfix."
Jeff Brown [Fri, 15 Jul 2011 05:31:27 +0000 (22:31 -0700)]
Merge "Add a call to pthread_attr_destroy to avoid potential memory leaks."
Jeff Brown [Fri, 15 Jul 2011 05:31:17 +0000 (22:31 -0700)]
Merge "Frameworks: fixes possible invalid pointer index call."
Jeff Brown [Fri, 15 Jul 2011 05:19:19 +0000 (22:19 -0700)]
Ensure selector state is updated when touch mode changes.
This fixes a problem where the focus selection rectangle
often remains visible even after entering touch mode.
This problem is particularly noticeable when using the
mouse to scroll the list while an item is selected.
Change-Id: I9938d2586725d91fd3f6738408233f2ead167319
Jeff Brown [Fri, 15 Jul 2011 04:55:58 +0000 (21:55 -0700)]
Merge "Enter touch mode on ACTION_SCROLL."
Adam Powell [Fri, 15 Jul 2011 04:53:41 +0000 (21:53 -0700)]
Merge "Fix bug
5032301 - size list menu icons appropriately."
Adam Powell [Fri, 15 Jul 2011 04:52:18 +0000 (21:52 -0700)]
Fix bug
5032301 - size list menu icons appropriately.
Change-Id: I309923cdd4d37292b390a9b760dec739becb1bbf
Jeff Brown [Fri, 15 Jul 2011 04:48:23 +0000 (21:48 -0700)]
Remove edge slop support.
The edge slop feature was added a long time ago for a specific
device that had severe non-linear touch response issues near
the edges of its touch screen. The feature is not useful on
modern hardware that is property calibrated.
Change-Id: I26716cbc7411c31883ddb4bb4ddd981027790d0f
Jason Bayer [Wed, 23 Mar 2011 03:03:31 +0000 (20:03 -0700)]
Refresh the drawable state when selecting a position.
It seems that mSelectorShowing is a dead (always false) field.
Bug:
4070346
Change-Id: Icf3cc6f19cc49dcfda15229a6d91232404c0743c
Jeff Sharkey [Fri, 15 Jul 2011 04:15:49 +0000 (21:15 -0700)]
Merge "Hide NetworkTemplate details, buffered stats I/O."
Adam Powell [Fri, 15 Jul 2011 04:08:10 +0000 (21:08 -0700)]
Fix bug
5030341 - ActionBar.getHeight is inaccurate in 2-row mode
Measure the shared container instead.
Change-Id: Ib851f773a36add19c227b3ad64a8497f1b5ff9dd
Jeff Sharkey [Fri, 15 Jul 2011 03:37:37 +0000 (20:37 -0700)]
Hide NetworkTemplate details, buffered stats I/O.
Move template matching to builder methods instead of exposing the
internal constants. Also rule to match Ethernet usage. Buffer
reading and writing of network stats, making operations 5x faster.
Change-Id: Iedb2d0ab3b26a976811c050f84a164e909eb74b6
Mark Lindner [Thu, 30 Jun 2011 23:26:51 +0000 (16:26 -0700)]
ListView focus bugfix.
resurrectSelection() didn't take into account disabled items
(which shouldn't ever get focus).
Bug:
4967915
Change-Id: I849d2d993ddf93f49108e7b867ff6d24643c07a8
Mathias Agopian [Fri, 15 Jul 2011 03:21:59 +0000 (20:21 -0700)]
Merge "fix a typo in ISurfaceTexture IPC code"
Mathias Agopian [Fri, 15 Jul 2011 03:20:58 +0000 (20:20 -0700)]
fix a typo in ISurfaceTexture IPC code
Change-Id: Ied1d9ddb0d849b17219d0ea3d333ce12be849419
Le-Chun Wu [Thu, 14 Jul 2011 21:27:18 +0000 (14:27 -0700)]
Add a call to pthread_attr_destroy to avoid potential memory leaks.
Change-Id: Ib57efc3530e9793298190cc9cab19c9af54e11a7
Justin Koh [Fri, 1 Jul 2011 00:11:26 +0000 (17:11 -0700)]
Frameworks: fixes possible invalid pointer index call.
Fixes possible invalid pointer index call in AbsListView.
Bug:
4982383
Change-Id: I9b88ab6a055c7678ef81fbe3187473edf8d12f6a
Jeff Brown [Fri, 15 Jul 2011 02:14:22 +0000 (19:14 -0700)]
Enter touch mode on ACTION_SCROLL.
Also fix the lastTouch tracking so it ignores irrelevant non-touch
events (like ACTION_HOVER).
Change-Id: I9e04872cb1f762aa6dcded1f9f83bf20eda17415
Chia-chi Yeh [Fri, 15 Jul 2011 02:05:33 +0000 (19:05 -0700)]
Merge "VPN: tear down VPN when the dependent interface is down."
Chia-chi Yeh [Fri, 15 Jul 2011 01:55:33 +0000 (18:55 -0700)]
VPN: tear down VPN when the dependent interface is down.
Change-Id: I1eaf8e39ee7aed1f4ecbd4c36c2a81a68ad2f9d1
Adam Powell [Fri, 15 Jul 2011 01:58:28 +0000 (18:58 -0700)]
Merge "Smooth the spinners"
Adam Powell [Thu, 14 Jul 2011 19:14:41 +0000 (12:14 -0700)]
Smooth the spinners
Change-Id: I36de60dc05e5c15692d33d030973f27d54a9d465
Adam Powell [Fri, 15 Jul 2011 01:52:26 +0000 (18:52 -0700)]
Merge "Fix regression with legacy expanded menus"
Adam Powell [Fri, 15 Jul 2011 01:50:02 +0000 (18:50 -0700)]
Fix regression with legacy expanded menus
Change-Id: I28a21dc72d11c6729370e0acd90b06ed98baf098
Mathias Agopian [Fri, 15 Jul 2011 01:04:09 +0000 (18:04 -0700)]
Merge "sensorservice: be more robust when there are no sensor h/w"
Jamie Gennis [Fri, 15 Jul 2011 00:54:27 +0000 (17:54 -0700)]
Merge changes Id9aa1003,I8c154189
* changes:
SurfaceTexture: make (dis)connect into an IPC
SurfaceTexture: add support for new connect values
Jamie Gennis [Thu, 14 Jul 2011 02:12:20 +0000 (19:12 -0700)]
SurfaceTexture: make (dis)connect into an IPC
This change makes the ANativeWindow connect and disconnect calls result
in an IPC to the SurfaceTexture object. This will allow us to prevent
multiple simultaneous connections from different processes.
Change-Id: Id9aa1003b1335b96ca6bd4a1f5a67aa433d42efb
Dianne Hackborn [Fri, 15 Jul 2011 00:23:28 +0000 (17:23 -0700)]
Merge "Move LoadAverageService to the SystemUI apk."
Jeff Brown [Fri, 15 Jul 2011 00:08:16 +0000 (17:08 -0700)]
Merge "Minor code cleanups in vector."
Jeff Brown [Thu, 14 Jul 2011 23:52:10 +0000 (16:52 -0700)]
Merge "Replace Vector _grow/_shrink checks with assert."
James Dong [Thu, 14 Jul 2011 23:42:34 +0000 (16:42 -0700)]
Merge "Revert "Add some logging to track down where ANR happens during MediaPlayer._release().""
Mathias Agopian [Thu, 14 Jul 2011 23:39:46 +0000 (16:39 -0700)]
sensorservice: be more robust when there are no sensor h/w
Bug:
5030108
Change-Id: I45b85b3c492b9268cb0ae44d2e5fc8c708b6e66e
James Dong [Thu, 14 Jul 2011 23:22:47 +0000 (16:22 -0700)]
Revert "Add some logging to track down where ANR happens during MediaPlayer._release()."
This reverts commit
a5293d1ca4459293f4993ea39c09ea703a022844.
Conflicts:
media/libstagefright/AwesomePlayer.cpp
Change-Id: I2a5960208a6780b9a44ab5cce0ffc0e2fb28f426
Chia-chi Yeh [Thu, 14 Jul 2011 23:22:21 +0000 (16:22 -0700)]
Merge "VPN: close the socket in protectVpn() to avoid leaking descriptors."
Chia-chi Yeh [Thu, 14 Jul 2011 23:19:19 +0000 (16:19 -0700)]
VPN: close the socket in protectVpn() to avoid leaking descriptors.
Change-Id: Idda0c2ea1770abc490566e894711bcb08f60b354
Glenn Kasten [Thu, 14 Jul 2011 23:16:54 +0000 (16:16 -0700)]
Bug
5031179 possible fix for assert in join
Change-Id: Id3a24c152579b8fdcfb9d66a11aa11579406a7ec
Dianne Hackborn [Thu, 14 Jul 2011 23:10:16 +0000 (16:10 -0700)]
Move LoadAverageService to the SystemUI apk.
Change-Id: I442e264802d1e35cd7d27bae121ae75f932595b6
Adam Cohen [Thu, 14 Jul 2011 22:55:55 +0000 (15:55 -0700)]
Merge "Catching RemoteViews#apply() layout inflation exceptions in RemoteViewsAdapter"
Adam Cohen [Thu, 14 Jul 2011 21:45:07 +0000 (14:45 -0700)]
Catching RemoteViews#apply() layout inflation exceptions in RemoteViewsAdapter
Change-Id: I8a481e106b27d145fda92aa0d747e4a8615a5fd0
Jim Miller [Thu, 14 Jul 2011 22:43:17 +0000 (15:43 -0700)]
Merge "Fix
5027468: prevent screen from turning back on while lockscreen in password mode."
Fabrice Di Meglio [Thu, 14 Jul 2011 22:31:03 +0000 (15:31 -0700)]
Merge "Fix bug #
5025936 TableLayout layout direction resolution is broken"
Chia-chi Yeh [Thu, 14 Jul 2011 22:22:59 +0000 (15:22 -0700)]
Merge "VPN: Hook up the new control protocol and network state."
Chia-chi Yeh [Thu, 14 Jul 2011 22:05:05 +0000 (15:05 -0700)]
VPN: Hook up the new control protocol and network state.
1. No more End-Of-Arguments.
2. Daemons close the control socket after they are initialized.
3. No more system properties.
4. ip-up-vpn now creates state to pass the configuration.
5. JNI methods are split again for legacy VPN.
Change-Id: I02fafdf01d425c965345ef712b2bd5fdee3a0cab
Jim Miller [Thu, 14 Jul 2011 22:04:42 +0000 (15:04 -0700)]
Fix
5027468: prevent screen from turning back on while lockscreen in password mode.
This fixes a bug where LockScreen would turn back on due to the sequence of events
that ultimately cause PasswordUnlockScreen.onResume() to be called when the device powers off.
This is required because the lockscreen rebuilds itself before the screen turns off
so that it's ready to show immediately when the device comes back on.
Change-Id: I86a61cc3b1d77cf7f2a9a198051ea2bbe90607b2
Jamie Gennis [Wed, 13 Jul 2011 19:57:23 +0000 (12:57 -0700)]
SurfaceTexture: add support for new connect values
This change adds support to SurfaceTextureClient for the new enum values
that can be passed to the ANativeWindow connect call.
Change-Id: I8c15418909e43a15673a9b22a5eb40df6923b273
Justin Ho [Thu, 14 Jul 2011 21:54:01 +0000 (14:54 -0700)]
Merge "Initial pass at some preload drawables Bug:
5020126"
Chia-chi Yeh [Thu, 14 Jul 2011 21:53:58 +0000 (14:53 -0700)]
Merge "ip-up-vpn: Create proper states for pppd and racoon."
Chia-chi Yeh [Thu, 14 Jul 2011 21:47:48 +0000 (14:47 -0700)]
ip-up-vpn: Create proper states for pppd and racoon.
VPN no longer uses system properties to pass parameters.
Change-Id: I13e4339ababb08552c4276c675c21176774da66c
Justin Ho [Thu, 14 Jul 2011 21:12:37 +0000 (14:12 -0700)]
Initial pass at some preload drawables
Bug:
5020126
Change-Id: I3c51e89774197caf50351ee55eb6922c9cdd32d5
John Wang [Thu, 14 Jul 2011 21:03:11 +0000 (14:03 -0700)]
am
74c425d3: am
54b2a326: Merge "Show SIM blocked after 10 time puk wrong entries." into honeycomb-LTE
* commit '
74c425d3e95ed0f47b1a5d447007886d01d7ff56':
Show SIM blocked after 10 time puk wrong entries.
John Wang [Thu, 14 Jul 2011 21:00:58 +0000 (14:00 -0700)]
am
54b2a326: Merge "Show SIM blocked after 10 time puk wrong entries." into honeycomb-LTE
* commit '
54b2a3262738cdb3d0df747d8719e9a3cac33dfc':
Show SIM blocked after 10 time puk wrong entries.
John Wang [Thu, 14 Jul 2011 20:59:10 +0000 (13:59 -0700)]
Merge "Show SIM blocked after 10 time puk wrong entries." into honeycomb-LTE
Eino-Ville Talvala [Thu, 14 Jul 2011 20:38:55 +0000 (13:38 -0700)]
Merge "NEW_API: Add auto-exposure and auto-white balance locking to the Camera."
Elliott Hughes [Thu, 14 Jul 2011 20:28:00 +0000 (13:28 -0700)]
Merge "Fix aidl to cope with multiple collection types per method."
Andreas Huber [Thu, 14 Jul 2011 20:22:45 +0000 (13:22 -0700)]
Merge "If audio startup fails while executing MediaPlayer::start() do NOT post an error"
Andreas Huber [Thu, 14 Jul 2011 20:02:47 +0000 (13:02 -0700)]
If audio startup fails while executing MediaPlayer::start() do NOT post an error
notification, the error returned by MediaPlayer::start() will suffice.
Change-Id: I49bd8d42078f039e5e6d8d4fed4f7f55dc5ff82a
related-to-bug:
5020200
Romain Guy [Thu, 14 Jul 2011 19:45:23 +0000 (12:45 -0700)]
Merge "Force bitmaps to load in ARGB8888 by default. Bug #
5024993"
Romain Guy [Thu, 14 Jul 2011 19:42:19 +0000 (12:42 -0700)]
Force bitmaps to load in ARGB8888 by default.
Bug #
5024993
Change-Id: Id0c63f675ae188e5a786b7fdd63916e114b9ed4a
Wink Saville [Thu, 14 Jul 2011 19:23:28 +0000 (12:23 -0700)]
Fix build.
Changes in ConnectivityService in hc-LTE when merged with changes
happening in Master caused the build to break.
Change-Id: I92a0b782ae58e9789b1e950c94ef966234fa94af
John Wang [Fri, 8 Jul 2011 19:31:08 +0000 (12:31 -0700)]
Show SIM blocked after 10 time puk wrong entries.
After user enters 10 time wrong puk in puk unlock screen,
device need show the SIM permanently disabled message
is in lock screen.
bug:
4905509
Change-Id: I06242834972b3f403cfe99a2edd8bae47d7ed474
Philip Milne [Thu, 14 Jul 2011 18:32:09 +0000 (11:32 -0700)]
Merge "Rationalize API after adding maximum size feature."
Doug Felt [Thu, 7 Jul 2011 18:57:48 +0000 (11:57 -0700)]
Implement textDirection heuristic selection.
Change-Id: I2fcf18de573f2d66494fa5ed61e4273c3c6078c7
Narayan Kamath [Thu, 14 Jul 2011 18:13:07 +0000 (11:13 -0700)]
Merge "Minor documentation updates for the AudioTrack class."
Glenn Kasten [Thu, 14 Jul 2011 17:59:40 +0000 (10:59 -0700)]
Merge "Add MEDIA_UID"
Wink Saville [Thu, 14 Jul 2011 17:55:58 +0000 (10:55 -0700)]
am
3810361e: am
6d1d16c3: Merge "Remove STOPSHIP but allow seamless Handoff when possible." into honeycomb-LTE
* commit '
3810361e4a3e93d3c8a10aaeec54f65dfcc2d03d':
Remove STOPSHIP but allow seamless Handoff when possible.
Jaikumar Ganesh [Thu, 14 Jul 2011 17:55:55 +0000 (10:55 -0700)]
am
6dd45316: (-s ours) resolved conflicts for merge of
ab3ec176 to honeycomb-plus-aosp
* commit '
6dd4531639157191e6224d3f8af5c9d099ca945f':
Bluetooth: correcting return value from cancelDiscovery
John Wang [Thu, 14 Jul 2011 17:49:38 +0000 (10:49 -0700)]
am
28d92afc: am
2ac78a2d: Merge "Add getImei() to Phone interface." into honeycomb-LTE
* commit '
28d92afc0a17cbf9149a0c8be9c8795d6f3306a5':
Add getImei() to Phone interface.
Dianne Hackborn [Thu, 14 Jul 2011 17:48:01 +0000 (10:48 -0700)]
Merge "Improve handling of low memory."
Adam Powell [Thu, 14 Jul 2011 03:40:52 +0000 (20:40 -0700)]
Nicer API for disabling/enabling the home/up button in action bars.
Have an explicit call for enabling the home/up button. Auto-enable it
if the app targets < ICS to preserve Honeycomb behavior. Auto-enable
it if the app shows home as up.
This prevents unwanted touch/focus feedback on the home button when
the app hasn't wired it up to do anything useful.
Change-Id: Icfe95ab5a11b3998bca08b0fbbfe1bf6c3c89b5d
Dianne Hackborn [Thu, 14 Jul 2011 02:33:41 +0000 (19:33 -0700)]
Improve handling of low memory.
Now classify background processes into a set of bins of how much
memory they should try to clear. The last bin also involves
destroying all activities in that process.
Removed the old code for the simulator that is no longer needed
(yay). The debugging features it had are now integrated into the
regular oom adj code.
Small fixes to load average service.
Change-Id: Ic8df401714b188c73b50dbc8f8e6345b58f1f3a0
Narayan Kamath [Thu, 14 Jul 2011 15:37:46 +0000 (16:37 +0100)]
Minor documentation updates for the AudioTrack class.
Change-Id: I0c3c220aa433d1917d997a7b1bfa54e61acc26b2
Jaikumar Ganesh [Thu, 14 Jul 2011 17:08:41 +0000 (10:08 -0700)]
Merge "Remove Car audio class from auto pairing."
Eino-Ville Talvala [Fri, 13 May 2011 17:25:00 +0000 (10:25 -0700)]
NEW_API: Add auto-exposure and auto-white balance locking to the Camera.
Unhides the Camera API calls for using the auto-exposure and
auto-white balance locks. Adds documentation about the interaction
between auto-focus and the AE and AWB locks.
Change-Id: I5bf73b9dce1c93e11a17f9d3efb82db1261524c5
James Dong [Thu, 14 Jul 2011 16:59:24 +0000 (09:59 -0700)]
Merge "Support profile and level query for SW video decoders"
Jeff Hamilton [Thu, 14 Jul 2011 16:53:08 +0000 (09:53 -0700)]
Merge "unhide public apis"
Jaikumar Ganesh [Thu, 14 Jul 2011 02:05:23 +0000 (19:05 -0700)]
Remove Car audio class from auto pairing.
Majority of the cars don't auto pair unlike headsets, as they have a display.
Instead of maintaining a blacklist of such cars, disable
auto pairing with 0000. This is legacy anyway as newer cars
come with 2.1 pairing.
Change-Id: I644e2da4d11cf2d250d846853523d7975ca000fc
Andreas Huber [Thu, 14 Jul 2011 16:09:14 +0000 (09:09 -0700)]
Merge "Include all supported mime types when querying decoder profile/level support."
Andreas Huber [Thu, 14 Jul 2011 16:09:07 +0000 (09:09 -0700)]
Merge "Remove legacy http support from stagefright, chromium is the new hotness."
Narayan Kamath [Fri, 1 Jul 2011 09:13:54 +0000 (10:13 +0100)]
Remove the completeAudioAvailable API.
Measurements have shown that the audio track in streaming mode
is pretty efficient as is, thanks to dalvik's JNI implementation.
Also, in streaming mode write( ) blocks until all data has been
copied to the mixer, which is the kind of behaviour we want so
that we don't have to explicitly block in our code. Also,
the java AudioTrack is thread-safe with respect to stop( ) calls
during write, which means we can do everything completeAudioAvailable
did, just as efficiently without it.
Change-Id: I70a8a108d94c7260676673979b5ea29f37fa5db4
Narayan Kamath [Thu, 14 Jul 2011 15:44:39 +0000 (08:44 -0700)]
Merge "Minor cleanups to TextToSpeech."
Glenn Kasten [Thu, 14 Jul 2011 14:54:34 +0000 (07:54 -0700)]
Merge "OMX CallbackDispatcher uses C++ Thread not pthread"
Narayan Kamath [Thu, 14 Jul 2011 14:30:36 +0000 (15:30 +0100)]
Minor cleanups to TextToSpeech.
(a) Fix an NPE reported when no TTS engine is installed.
(b) Fix a bad link, and some javadoc typos.
bug:
5004015
Change-Id: I38b97dbb5d7d4065a5ee408fae9138638ed48f40
Jeff Brown [Thu, 14 Jul 2011 11:20:56 +0000 (04:20 -0700)]
Merge "Refactor input dispatcher use of window/app handles."
Jeff Brown [Thu, 14 Jul 2011 11:12:51 +0000 (04:12 -0700)]
Merge "Fix invalid JNI call signature. Bug:
5029536"
Jeff Brown [Thu, 14 Jul 2011 07:29:49 +0000 (00:29 -0700)]
Minor code cleanups in vector.
Fixed a potential bug where calling replaceAt with a reference to
an existing element in the vector at the same index would cause
the element to be destroyed while being copied to itself.
Refactored the conditions in _grow and _shrink for clarity.
The computations are exactly the same but I think it reads better
this way. In particular, the ssize_t variable 's' is gone: it didn't
need to be signed anyways because its value could never be negative.
Change-Id: If087841c15e6a87160eee874720c4a77eb0e99a6
Jeff Brown [Thu, 14 Jul 2011 05:22:02 +0000 (22:22 -0700)]
Replace Vector _grow/_shrink checks with assert.
On review of the code, _grow and _shrink are checking for conditions
that cannot happen and that don't even really make sense. For
example, if _shrink is called with where + amount > mCount then
this is really bad, however the check only considered the case
when where >= mCount and then it would arbitrarily choose a new
value for where. Huh?
As it happens, the callers are correctly validating the
arguments before passing them down to these methods so we can
get rid of this code.
Change-Id: I921852dba8997065bb0e9cac733e82028d14afcd
Jeff Brown [Thu, 14 Jul 2011 05:51:29 +0000 (22:51 -0700)]
Refactor input dispatcher use of window/app handles.
This change moves the cached window and application input state
into the handle objects themselves. It simplifies the dispatcher
somewhat because it no longer needs to fix up references to
transient InputWindow objects each time the window list is updated.
This change will also make it easier to optimize setInputWindows
to avoid doing a lot of redundant data copying. In principle, only
the modified fields need to be updated. However, for now we
continue to update all fields in unison as before.
It turns out that the input dispatcher was inappropriately retaining
pointers to InputWindow objects within the mWindows InputWindow
vector. This vector is copy-on-write so it is possible and the
item pointers to change if an editing operation is performed on
the vector when it does not exclusively own the underlying
SharedBuffer. This bug was uncovered by a previous change that
replaced calls to clear() and appendVector() with a simple use
of operator= which caused the buffer to be shared. Consequently
after editItemAt was called (which it shouldn't have, actually)
the buffer was copied and the cached InputWindow pointers became
invalid. Oops. This change fixes the problem.
Change-Id: I0a259339a6015fcf9113dc4081a6875e047fd425