OSDN Git Service
Ken Shirriff [Fri, 22 Jan 2010 19:14:42 +0000 (11:14 -0800)]
Merge "Remove unused providers"
Romain Guy [Fri, 22 Jan 2010 19:01:42 +0000 (11:01 -0800)]
Merge "Bring back buttons in dialogs. Bug #
2390537"
Romain Guy [Fri, 22 Jan 2010 19:00:29 +0000 (11:00 -0800)]
Bring back buttons in dialogs.
Bug #
2390537
Xavier Ducrohet [Fri, 22 Jan 2010 17:45:49 +0000 (09:45 -0800)]
am
60e3c09e: am
6866daee: Merge "ADT/Layoutlib: implement radial gradient." into eclair
Merge commit '
60e3c09ec0fa73a3e650f4aec89c763599c2e0b7'
* commit '
60e3c09ec0fa73a3e650f4aec89c763599c2e0b7':
ADT/Layoutlib: implement radial gradient.
Ying Wang [Fri, 22 Jan 2010 17:45:31 +0000 (09:45 -0800)]
am
3c05f1fb: am
b5fb50a1: Merge "Add instrumentation as a source tag for proguard keep options." into eclair
Merge commit '
3c05f1fbac2ce35483f61dbd5d5bfb6341da6d9c'
* commit '
3c05f1fbac2ce35483f61dbd5d5bfb6341da6d9c':
Add instrumentation as a source tag for proguard keep options.
Guang Zhu [Fri, 22 Jan 2010 17:44:34 +0000 (09:44 -0800)]
am
e0aed796: am
ccec75e7: Merge "Prevent orientation change from triggering activity recreation." into eclair
Merge commit '
e0aed796f03b080dabae6be0803d4ead1b3260a0'
* commit '
e0aed796f03b080dabae6be0803d4ead1b3260a0':
Prevent orientation change from triggering activity recreation.
Amith Yamasani [Fri, 22 Jan 2010 17:44:16 +0000 (09:44 -0800)]
am
658dc0d4: am
b35b8c13: Merge "Security fix in accessibility - don\'t read out password. #
2371557" into eclair
Merge commit '
658dc0d4b03015eb4a692968b82b664e24aa605a'
* commit '
658dc0d4b03015eb4a692968b82b664e24aa605a':
Security fix in accessibility - don't read out password. #
2371557
Scott Main [Fri, 22 Jan 2010 17:43:56 +0000 (09:43 -0800)]
am
d603e989: am
88e653f6: Merge "docs: some spelling typos" into eclair
Merge commit '
d603e989f47093ad9f7638bd3f62717daa731fd5'
* commit '
d603e989f47093ad9f7638bd3f62717daa731fd5':
docs: some spelling typos
Marco Nelissen [Fri, 22 Jan 2010 15:53:12 +0000 (07:53 -0800)]
Merge "Make the media scanner disregard database entries that do not have absolute path names. This allows us to store other things (perhaps with http or content URIs) in the database, without the media scanner removing them again."
Ken Shirriff [Fri, 22 Jan 2010 08:14:31 +0000 (00:14 -0800)]
Remove unused providers
bug
2388178
Ken Shirriff [Fri, 22 Jan 2010 01:32:39 +0000 (17:32 -0800)]
Use AUTHORITY constant for calendar.
This will allow the calendar authority to be changed later.
bug
2388178
Chih-Chung Chang [Fri, 22 Jan 2010 01:31:06 +0000 (17:31 -0800)]
Add an orientation parameter for overlay, so we can do camera preview in portrait mode.
Romain Guy [Fri, 22 Jan 2010 03:11:20 +0000 (19:11 -0800)]
Merge "Add a new attribute to LinearLayout: useLargestChild. Bug #
2379138"
Romain Guy [Fri, 22 Jan 2010 03:09:51 +0000 (19:09 -0800)]
Add a new attribute to LinearLayout: useLargestChild.
Bug #
2379138
This new attribute is to be used when the LinearLayout is wrap_content but you want
all the children inside to have the same dimension. Set useLargestChild to true and
give all the children a width/height of 0 and a weight of 1.0.
Grace Kloba [Fri, 22 Jan 2010 01:57:51 +0000 (17:57 -0800)]
Grace Kloba [Fri, 22 Jan 2010 01:57:29 +0000 (17:57 -0800)]
Grace Kloba [Fri, 22 Jan 2010 01:57:07 +0000 (17:57 -0800)]
Grace Kloba [Fri, 22 Jan 2010 01:56:46 +0000 (17:56 -0800)]
am
8d4baa78: am
d79d1c72: Merge "If ZoomButttonsController detects more than one pointer, give up the control. This should enable the View behind it, like WebView, will always get the multi-pointer events even when ZoomButtonsController is up." into eclair
Merge commit '
8d4baa789302b2c0f2657af9ba6dc98fcc926ee2'
* commit '
8d4baa789302b2c0f2657af9ba6dc98fcc926ee2':
If ZoomButttonsController detects more than one pointer,
Grace Kloba [Fri, 22 Jan 2010 01:56:25 +0000 (17:56 -0800)]
Jim Miller [Fri, 22 Jan 2010 01:56:03 +0000 (17:56 -0800)]
am
84928fa9: am
813d2d86: Merge "Fix for
2292713: Remove workaround that hides SlidingTab widget while internal state is inconsistent." into eclair
Merge commit '
84928fa93c3be222b77794de9922d299f4971ea4'
* commit '
84928fa93c3be222b77794de9922d299f4971ea4':
Fix for
2292713: Remove workaround that hides SlidingTab widget while internal state is inconsistent.
Xavier Ducrohet [Fri, 22 Jan 2010 01:55:40 +0000 (17:55 -0800)]
am
da84d6a1: am
908a8111: Merge "ADT/Layoutlib: Add dash support to stroke." into eclair
Merge commit '
da84d6a1b1c37376d48f92ae59b76f1c891772f6'
* commit '
da84d6a1b1c37376d48f92ae59b76f1c891772f6':
ADT/Layoutlib: Add dash support to stroke.
Xavier Ducrohet [Fri, 22 Jan 2010 01:55:17 +0000 (17:55 -0800)]
am
c0ea805c: am
2b30a4a5: Merge "ADT/Layoutlib: properly handle stroke information." into eclair
Merge commit '
c0ea805c649666b55d4dde09eb72dcccfa8bccc3'
* commit '
c0ea805c649666b55d4dde09eb72dcccfa8bccc3':
ADT/Layoutlib: properly handle stroke information.
Paul Westbrook [Fri, 22 Jan 2010 01:14:06 +0000 (17:14 -0800)]
Marco Nelissen [Fri, 22 Jan 2010 01:12:45 +0000 (17:12 -0800)]
Make the media scanner disregard database entries that do not have
absolute path names. This allows us to store other things (perhaps
with http or content URIs) in the database, without the media scanner
removing them again.
Paul Westbrook [Wed, 13 Jan 2010 20:13:57 +0000 (12:13 -0800)]
Bug
2330111
Make NumberPicker public
Made setCurrent() more robust, as the value needs to be within the range
specified earlier. setCurrent() will now throw an exception
if the specified doesn't fall in the range
Wink Saville [Fri, 22 Jan 2010 00:46:42 +0000 (16:46 -0800)]
Merge "Fix build, incorrect link/see tags."
Dianne Hackborn [Fri, 22 Jan 2010 00:44:53 +0000 (16:44 -0800)]
Merge "Don't crash when there is no admin."
Mathias Agopian [Fri, 22 Jan 2010 00:37:48 +0000 (16:37 -0800)]
Merge changes I2d41cb94,Ia1a17985
* changes:
fix [
2324665] texture leak in surfaceflinger when using camera
fix a texture leak introduced recently.
Wink Saville [Fri, 22 Jan 2010 00:37:04 +0000 (16:37 -0800)]
Fix build, incorrect link/see tags.
Change-Id: Ia1c13ddb198721234323f1944ea3537ea6f34820
Mathias Agopian [Fri, 22 Jan 2010 00:04:56 +0000 (16:04 -0800)]
fix [
2324665] texture leak in surfaceflinger when using camera
Dianne Hackborn [Fri, 22 Jan 2010 00:29:00 +0000 (16:29 -0800)]
Don't crash when there is no admin.
Mathias Agopian [Fri, 22 Jan 2010 00:27:30 +0000 (16:27 -0800)]
fix a texture leak introduced recently.
create the texture name once and for all for a given BufferSource
and make sure to recreate it when we're forced to delete the texture.
Doug Zongker [Fri, 22 Jan 2010 00:10:58 +0000 (16:10 -0800)]
Merge "relocate GoogleLoginService"
Wink Saville [Thu, 21 Jan 2010 23:00:12 +0000 (15:00 -0800)]
Merge "Fix build, GsmServiceStateTracker was using old EventLog API."
Jim Miller [Thu, 21 Jan 2010 00:34:45 +0000 (16:34 -0800)]
Fix
2385283: Use device-specific salt when generating hashes for lock passwords.
Doug Zongker [Thu, 21 Jan 2010 22:36:17 +0000 (14:36 -0800)]
relocate GoogleLoginService
Change-Id: I79f4ff658ab136adcc54c432db76f34d2de5f6ac
Grace Kloba [Thu, 21 Jan 2010 22:32:01 +0000 (14:32 -0800)]
Grace Kloba [Thu, 21 Jan 2010 22:31:45 +0000 (14:31 -0800)]
Merge branch 'master' of ssh://android-git.corp.google.com:29418/platform/frameworks/base
Grace Kloba [Thu, 21 Jan 2010 22:31:33 +0000 (14:31 -0800)]
Xavier Ducrohet [Thu, 21 Jan 2010 22:31:11 +0000 (14:31 -0800)]
am
20cc5570: am
79f05bb4: Merge "ADT/Layoutlib: improved gradient drawing for perf." into eclair
Merge commit '
20cc55703348827fbd80ff0410777a537f01e10e'
* commit '
20cc55703348827fbd80ff0410777a537f01e10e':
ADT/Layoutlib: improved gradient drawing for perf.
Dianne Hackborn [Wed, 20 Jan 2010 21:37:26 +0000 (13:37 -0800)]
More device policy manager / admin work.
Update API with some new features, re-arrange how you check for valid
passwords, and start hooking up the back-end implementation.
Xavier Ducrohet [Thu, 21 Jan 2010 22:30:48 +0000 (14:30 -0800)]
am
38fa9eee: am
89d538dc: ADT/Layoutlib: don\'t draw 0-sized rectangle, AWT doesn\'t like that.
Merge commit '
38fa9eee9324b2355f28372e80dba12c1d7cc105'
* commit '
38fa9eee9324b2355f28372e80dba12c1d7cc105':
ADT/Layoutlib: don't draw 0-sized rectangle, AWT doesn't like that.
Xavier Ducrohet [Thu, 21 Jan 2010 22:30:17 +0000 (14:30 -0800)]
am
895c92a4: am
240298f9: Merge "ADT/Layoutlib: always use custom gradient (java) Paint." into eclair
Merge commit '
895c92a44b8bcf0aec7066c061293cafe12a76c2'
* commit '
895c92a44b8bcf0aec7066c061293cafe12a76c2':
ADT/Layoutlib: always use custom gradient (java) Paint.
Roman Nurik [Thu, 21 Jan 2010 22:29:26 +0000 (14:29 -0800)]
am
b8c564d0: am
6a739ea8: Merge "Updated developer groups documentation to point to Stack Overflow, also rearranged a few things." into eclair
Merge commit '
b8c564d0fc7b2bdcc794d63f23b21df2540d7cef'
* commit '
b8c564d0fc7b2bdcc794d63f23b21df2540d7cef':
Updated developer groups documentation to point to Stack Overflow, also rearranged a few things.
Xavier Ducrohet [Thu, 21 Jan 2010 22:29:02 +0000 (14:29 -0800)]
am
31ef2e77: am
b847fbf2: Merge "ADT/Layout: support for 3+ color in linear gradients" into eclair
Merge commit '
31ef2e77c50485ad6ed410a5d341754d6787b8e1'
* commit '
31ef2e77c50485ad6ed410a5d341754d6787b8e1':
ADT/Layout: support for 3+ color in linear gradients
Wink Saville [Thu, 21 Jan 2010 22:15:05 +0000 (14:15 -0800)]
Fix build, GsmServiceStateTracker was using old EventLog API.
Change-Id: Ib202d0ebbbb11c0ccad40445426c0c3704eb30b5
Leon Scroggins [Thu, 21 Jan 2010 21:29:32 +0000 (13:29 -0800)]
Merge "Create a common method for updating the title of a download from the filename."
Leon Scroggins [Thu, 21 Jan 2010 21:19:41 +0000 (16:19 -0500)]
Create a common method for updating the title of a download from the filename.
This method will be used by the DownloadProvider and the BrowserDownloadPage.
John Wang [Thu, 21 Jan 2010 20:47:13 +0000 (12:47 -0800)]
am
7319d94f: am
99f2a4bb: Merge "Add Event log for RAT switch." into eclair
Merge commit '
7319d94ff1ca898c36d2da8dd0cd8469d91bc5af'
* commit '
7319d94ff1ca898c36d2da8dd0cd8469d91bc5af':
Add Event log for RAT switch.
Derek Sollenberger [Thu, 21 Jan 2010 20:06:19 +0000 (15:06 -0500)]
Removing unused parameter from NP_Initialize.
Justin Mattson [Thu, 14 Jan 2010 05:05:46 +0000 (21:05 -0800)]
NEW_API: Declare an ACTION_SEARCH_SETTINGS constant in android.provider.Settings so that apps can cause this system setting group to be opened directly.
The Settings app already responds to this action it just was not exposed in the platform API.
Amith Yamasani [Thu, 21 Jan 2010 19:22:01 +0000 (11:22 -0800)]
Merge "Workaround for a database update callback that claims that the data doesn't exist."
Andreas Huber [Thu, 21 Jan 2010 18:44:54 +0000 (10:44 -0800)]
Merge "Fix circular dependency between StagefrightPlayer and AwesomePlayer that prevented proper cleanup."
Andreas Huber [Thu, 21 Jan 2010 18:44:47 +0000 (10:44 -0800)]
Merge "Special-case .wmv and .wma metadata retrieval and playback to use PV if available."
Andreas Huber [Thu, 21 Jan 2010 00:11:15 +0000 (16:11 -0800)]
Special-case .wmv and .wma metadata retrieval and playback to use PV if available.
related-to-bug:
2381874
Vasu Nori [Thu, 21 Jan 2010 18:29:22 +0000 (10:29 -0800)]
Merge "caching PRAGMA sql statements caused cts-tests failures."
Andreas Huber [Thu, 21 Jan 2010 18:28:45 +0000 (10:28 -0800)]
Fix circular dependency between StagefrightPlayer and AwesomePlayer that prevented proper cleanup.
related-to-bug:
2355922
Amith Yamasani [Thu, 21 Jan 2010 17:58:01 +0000 (09:58 -0800)]
Workaround for a database update callback that claims that the data doesn't exist.
It's probably some intermediate state when updating the volumes that's causing
the row to be missing.
Derek Sollenberger [Thu, 21 Jan 2010 16:39:15 +0000 (08:39 -0800)]
am
1f7747ad: am
7cabb03d: Resize the WebView when the soft-keyboard appears in landscape mode.
Merge commit '
1f7747adb6a79317f4bd52fb78b3c567dd203883'
* commit '
1f7747adb6a79317f4bd52fb78b3c567dd203883':
Resize the WebView when the soft-keyboard appears in landscape mode.
Derek Sollenberger [Thu, 21 Jan 2010 16:29:33 +0000 (08:29 -0800)]
am
7cabb03d: Resize the WebView when the soft-keyboard appears in landscape mode.
Merge commit '
7cabb03da7053f3ceb5ff8b41b6a46052c6658a1' into eclair-mr2-plus-aosp
* commit '
7cabb03da7053f3ceb5ff8b41b6a46052c6658a1':
Resize the WebView when the soft-keyboard appears in landscape mode.
Mike Lockwood [Thu, 21 Jan 2010 16:18:15 +0000 (08:18 -0800)]
Merge "Implement Notification.DEFAULT_LIGHTS flag."
Derek Sollenberger [Thu, 21 Jan 2010 15:37:38 +0000 (10:37 -0500)]
Resize the WebView when the soft-keyboard appears in landscape mode.
The WebView notifies the IME that it wishes to be resized when the
soft-keyboard is displayed. This fixes http://b/
2170192.
Mike Lockwood [Wed, 20 Jan 2010 17:13:36 +0000 (12:13 -0500)]
Implement Notification.DEFAULT_LIGHTS flag.
This flag was already in the public API but did not do anything until now.
We now use it so we can override the default notification LED color on a per device basis.
Change-Id: I0d6e239b7da2fdbeda9608d6d4de3e778aa88e2c
BUG:
2329568
Signed-off-by: Mike Lockwood <lockwood@android.com>
San Mehat [Thu, 21 Jan 2010 02:15:43 +0000 (18:15 -0800)]
Merge "INetworkManagementService: Add support for enumerating TTYs and attaching ppp servers to them"
San Mehat [Wed, 20 Jan 2010 23:16:42 +0000 (15:16 -0800)]
MountService: Codeshrink
Signed-off-by: San Mehat <san@google.com>
San Mehat [Thu, 21 Jan 2010 02:12:54 +0000 (18:12 -0800)]
Merge "NativeDaemonConnector: Add a convenience method for obtaining lists"
Vasu Nori [Thu, 21 Jan 2010 00:36:28 +0000 (16:36 -0800)]
caching PRAGMA sql statements caused cts-tests failures.
thats a strange-bug..caching PRAGMA sql statements caused sqlite to return
incorrect results.
Andreas Huber [Thu, 21 Jan 2010 00:07:23 +0000 (16:07 -0800)]
Merge "Fix no-copy-overhead OMXCodec implementation to actually work."
Vasu Nori [Wed, 20 Jan 2010 23:41:54 +0000 (15:41 -0800)]
Merge "reduce logging noise from cache-full conditions."
San Mehat [Wed, 20 Jan 2010 23:14:31 +0000 (15:14 -0800)]
NativeDaemonConnector: Add a convenience method for obtaining lists
Signed-off-by: San Mehat <san@google.com>
San Mehat [Tue, 19 Jan 2010 21:50:37 +0000 (13:50 -0800)]
INetworkManagementService: Add support for enumerating TTYs and attaching ppp servers to them
Signed-off-by: San Mehat <san@google.com>
Updated: Refactor out duplicated code
Jim Miller [Wed, 20 Jan 2010 23:12:04 +0000 (15:12 -0800)]
Merge "Fix
2385283: Add DevicePolicyManager calls to LockScreen."
Mathias Agopian [Wed, 20 Jan 2010 23:08:33 +0000 (15:08 -0800)]
Merge "fix [
2363362] [Sapphire] Corrupted raw picture displayed during snapshot"
Mathias Agopian [Wed, 20 Jan 2010 23:08:27 +0000 (15:08 -0800)]
Merge "part of fix for [
2363362] [Sapphire] Corrupted raw picture displayed during snapshot"
Vasu Nori [Wed, 20 Jan 2010 23:07:26 +0000 (15:07 -0800)]
reduce logging noise from cache-full conditions.
when the compiled-sql cache is full, print the warning only a few times and
after that, if the condition persists, clear the cache.
don't flood the cache with the same warning million times.
Andreas Huber [Wed, 20 Jan 2010 23:05:46 +0000 (15:05 -0800)]
Fix no-copy-overhead OMXCodec implementation to actually work.
Jim Miller [Wed, 20 Jan 2010 21:35:20 +0000 (13:35 -0800)]
Fix
2385283: Add DevicePolicyManager calls to LockScreen.
Joe Onorato [Wed, 20 Jan 2010 22:35:52 +0000 (14:35 -0800)]
am
b3699b14: am
836e1666: Merge "add drawSpriteScreenspaceCropped to renderscript" into eclair
Merge commit '
b3699b14be3a3db1d75ea4c38853b0a53d14b1be'
* commit '
b3699b14be3a3db1d75ea4c38853b0a53d14b1be':
add drawSpriteScreenspaceCropped to renderscript
Mathias Agopian [Wed, 20 Jan 2010 22:31:53 +0000 (14:31 -0800)]
fix [
2363362] [Sapphire] Corrupted raw picture displayed during snapshot
handled all cases where the scale factor of a video is out of bounds of
supported scale factors in copybit.
Jacek Surazski [Wed, 20 Jan 2010 22:14:12 +0000 (14:14 -0800)]
Merge "Add systemApp field to ApplicationErrorReport"
Barry Hayes [Wed, 20 Jan 2010 22:11:26 +0000 (14:11 -0800)]
Merge "Check the boolean value for the arg to ZygoteInit to make sure it's either true or false. Make a slightly more informative usage message. Give developers a slightly easier way to have their preloaded classes list out of sync without blowing up."
Mathias Agopian [Wed, 20 Jan 2010 21:56:07 +0000 (13:56 -0800)]
part of fix for [
2363362] [Sapphire] Corrupted raw picture displayed during snapshot
make sure to fallback properly to software when copybit operation fails.
with this change, the preview image will at least be displayed in b&w
(since GL doesn't support the yuv format). This would also fix
2363506, but that one is now handled more cleanly.
Mathias Agopian [Wed, 20 Jan 2010 21:44:53 +0000 (13:44 -0800)]
Merge "fix [
2363506] [Sapphire] Video playback broken"
Mathias Agopian [Wed, 20 Jan 2010 21:24:14 +0000 (13:24 -0800)]
fix [
2363506] [Sapphire] Video playback broken
don't try to use copybit for incompatible buffers
Barry Hayes [Wed, 20 Jan 2010 20:46:47 +0000 (12:46 -0800)]
Check the boolean value for the arg to ZygoteInit to make sure it's either true or false.
Make a slightly more informative usage message.
Give developers a slightly easier way to have their preloaded classes list out of sync without blowing up.
Jacek Surazski [Thu, 7 Jan 2010 15:23:03 +0000 (16:23 +0100)]
Add systemApp field to ApplicationErrorReport
Andreas Huber [Wed, 20 Jan 2010 20:12:24 +0000 (12:12 -0800)]
Make the MediaMetadataTest a little more lenient when it comes to verifying the duration of media files, only require that the returned duration is within 100ms of the expected one, as the PV and stagefright implementations differ slightly.
related-to-bug:
2377534
Dmitri Plotnikov [Wed, 20 Jan 2010 20:12:11 +0000 (12:12 -0800)]
Introducing the notion of "verified name" on a raw contact.
This flag can be set by a sync adapter if it is certain that the
name is correct (a social network sync adapter would be a good example
of this). It can also be explicitly set by the user in the Contact
Edit UI.
Bug:
2164422
Change-Id: Id46e04c28eeb0dc386adfc6ad8988dda50824e2b
Makoto Onuki [Wed, 20 Jan 2010 20:03:24 +0000 (12:03 -0800)]
Merge "DomainNameValiator: Remove workaround"
Andreas Huber [Wed, 20 Jan 2010 19:43:25 +0000 (11:43 -0800)]
Merge "Adds support for 8-bit (unsigned) PCM wave files."
Andreas Huber [Wed, 20 Jan 2010 19:20:01 +0000 (11:20 -0800)]
Adds support for 8-bit (unsigned) PCM wave files.
related-to-bug:
2382428
Andreas Huber [Wed, 20 Jan 2010 19:35:02 +0000 (11:35 -0800)]
Merge "Support for 'iTunes-style' metadata in .mp4 and .3gp files."
Eric Laurent [Wed, 20 Jan 2010 18:03:36 +0000 (10:03 -0800)]
Merge "Create base class for audio policy manager."
Makoto Onuki [Wed, 20 Jan 2010 17:56:01 +0000 (09:56 -0800)]
DomainNameValiator: Remove workaround
Remove the workaround introduced in CL 68137-p9.
Validation should fail when a certification can't be parsed.
Bug:
2369689
Andreas Huber [Wed, 20 Jan 2010 00:43:53 +0000 (16:43 -0800)]
Support for 'iTunes-style' metadata in .mp4 and .3gp files.
related-to-bug:
2368967
Makoto Onuki [Wed, 20 Jan 2010 17:22:42 +0000 (09:22 -0800)]
Merge "Addign more tests for DomainNameValidator."
Tom O'Neill [Wed, 20 Jan 2010 17:15:14 +0000 (09:15 -0800)]
Merge "Get rid of a TODO to add documentation for now-hidden columns"
Jason Sams [Wed, 20 Jan 2010 01:54:27 +0000 (17:54 -0800)]
Merge "Fix RS mipmap generation for 8 bit alpha textures."
Jason Sams [Wed, 20 Jan 2010 01:53:54 +0000 (17:53 -0800)]
Fix RS mipmap generation for 8 bit alpha textures.
Romain Guy [Wed, 20 Jan 2010 01:34:10 +0000 (17:34 -0800)]
Dpad based scrolling in ListView was mishandling the recycler:
recyclable views were removed instead of detached and non-recyclables views
were detached instead of removed.