OSDN Git Service
Iain Merrick [Thu, 2 Dec 2010 11:24:53 +0000 (11:24 +0000)]
CookieManager::flushCookieStore() is now synchronous.
This ensures that all data is correctly stored before onPause() returns.
There's no API change on the Java side (although I should update the
comment to explain it's now synchronous; I'll do that in another CL).
Depends on a new completion callback added to CookieMonster.
See change Ieb3e787b in external/chromium.
Change-Id: I008f35d101a9223fe705396273bc4cd563a5f77e
Russell Brenner [Wed, 24 Nov 2010 18:16:29 +0000 (10:16 -0800)]
Merge WebKit at r72274: Update WebKit revision number.
Change-Id: I38e2e15fe1061f51a5fc299f45763b0e49300b4c
Ben Murdoch [Tue, 9 Nov 2010 18:17:50 +0000 (18:17 +0000)]
Merge WebKit at r72274: Implement PlatformBridge memory management methods for WebKit change 71639
Get device class specific memory constraints for V8.
V8 can be more efficient in terms of memory management but to do
so needs to know about what resources are available to it.
This varies device to device on Android so add implement the functions
that the the PlatformBridge needs to query the relevant values from
Java.
MemoryUsage.cpp will compile for JSC, but needs tuning to report
correct JSC stats. It's currently a non-issue, as this routine is only
used with V8, at present.
Requires a frameworks/base change:
https://android-git.corp.google.com/g/#change,78690
Bug:
3075565
Requires a previously upstreamed webkit change:
http://trac.webkit.org/changeset/71639
Change-Id: I25ff54b5c8e25f5de5380e0d43e56551587adc5d
Russell Brenner [Tue, 23 Nov 2010 01:32:22 +0000 (17:32 -0800)]
Merge WebKit at r72274: Moved definition of EXPORT
The definition of EXPORT was removed from WebCorePrefix.h, citing that it's only needed by WebKit/android. Added definition to WebKit/android.
http://trac.webkit.org/changeset/71578
Change-Id: I3fe6909d5e5c668299ca25dc39ef0e444620fd33
Russell Brenner [Tue, 23 Nov 2010 00:58:26 +0000 (16:58 -0800)]
Merge WebKit at r72274: Fix CodeGeneratorV8.pm
Some of the script-generation code puts include statements in source files when
they need to be in headers.
Cherry-picked from webkit:
http://trac.webkit.org/changeset/72948
Change-Id: I07d425bcb97abcdda25b5ff2ea7af887a925f489
Russell Brenner [Fri, 19 Nov 2010 22:12:47 +0000 (14:12 -0800)]
Merge WebKit at r72274: Add new flag to ImageSource constructor with asssociated storage member
Patch for webkit change:
http://trac.webkit.org/changeset/72130
Change-Id: I5718b8c1ee5b2a9c8afa31de24e882f30d62972f
Russell Brenner [Fri, 19 Nov 2010 21:57:02 +0000 (13:57 -0800)]
Merge WebKit at r72274: Add orientation stub
Orientation is hardwired to horizontal. Needs proper implementation.
http://trac.webkit.org/changeset/71970
Change-Id: If838dd9689e0e54b282baaa82515b2460e50578f
Russell Brenner [Tue, 23 Nov 2010 01:59:09 +0000 (17:59 -0800)]
Merge WebKit at r72274: Fix Makefiles
Add ResourceLoadScheduler.cpp to build
http://trac.webkit.org/changeset/71562
Change-Id: Ia2fabc508bbcd65023824424951484f644066b1d
Russell Brenner [Fri, 19 Nov 2010 17:57:40 +0000 (09:57 -0800)]
Merge WebKit at r72272: Fix conflicts.
WebCore/Android.v8bindings.mk
http://trac.webkit.org/changeset/71802
WebCore/bindings/v8/V8Proxy.cpp
http://trac.webkit.org/changeset/71735
WebCore/css/CSSParser.cpp
http://trac.webkit.org/changeset/71767
http://trac.webkit.org/changeset/72116 (several APIs purged)
WebCore/loader/ResourceLoader.cpp
http://trac.webkit.org/changeset/71884
WebCore/platform/graphics/MediaPlayer.cpp
http://trac.webkit.org/changeset/72117
WebCore/platform/image-decoders/ImageDecoder.cpp
http://trac.webkit.org/changeset/72130
WebCore/rendering/RenderBlockLineLayout.cpp
http://trac.webkit.org/changeset/72235
WebCore/rendering/RenderView.cpp
http://trac.webkit.org/changeset/71851
Change-Id: If0a3466754b9755c1f4be97bf589f88c48eece0a
Russell Brenner [Fri, 19 Nov 2010 01:33:13 +0000 (17:33 -0800)]
Merge WebKit at r72274: Initial merge by git.
Change-Id: Ie51f0b4a16da82942bd516dce59cfb79ebbe25fb
Ben Murdoch [Thu, 2 Dec 2010 17:03:03 +0000 (09:03 -0800)]
Merge "Fix crash when syncing autofill settings."
Jean-Baptiste Queru [Thu, 2 Dec 2010 15:59:57 +0000 (07:59 -0800)]
am
6a2e8695: am
5d1bf1f6: Merge from open-source master
* commit '
6a2e86958d2c1827daa0639e5e9ed9515252f3be':
Fix compilation error:
Jean-Baptiste Queru [Thu, 2 Dec 2010 15:53:20 +0000 (07:53 -0800)]
am
5d1bf1f6: Merge from open-source master
* commit '
5d1bf1f6b21848ec1086d59111306d2d4a4b5fc3':
Fix compilation error:
Jean-Baptiste Queru [Thu, 2 Dec 2010 15:49:06 +0000 (07:49 -0800)]
Merge from open-source master
Change-Id: I22fd2b911ff05cd0d01fe151b18d64b4ac98e547
Ben Murdoch [Thu, 2 Dec 2010 15:10:50 +0000 (15:10 +0000)]
Fix crash when syncing autofill settings.
Since we moved the autofill initiation code out of the constructor
and into it's own method, we may crash if there is an autofill profile
set but the feature is turned off (i.e. the user had it on at one point
and had a profile set up but turned it off without deleting the
profile). That's because in this case we execute setAutoFillProfile()
in WebSettings without having first called the new init method. It makes
sense to not sync any profiles though when the feature is not enabled,
so add that check.
Change-Id: I9d99e96347770e5b08c982513f2370cb770cbe94
Steve Block [Thu, 2 Dec 2010 12:54:32 +0000 (04:54 -0800)]
Merge "Fix style in WebCore/platform/network/android"
Kristian Monsen [Wed, 1 Dec 2010 16:04:54 +0000 (16:04 +0000)]
Enable SPDY, and renames initChromiumLogging
initChromiumLogging is now renamed to the more generic initChromium,
the files are renamed to ChromiumInit.*
Change-Id: Ic9639d637f25e664b51d076b9b0ee58c2867c1b5
Jean-Baptiste Queru [Wed, 1 Dec 2010 23:26:30 +0000 (15:26 -0800)]
Merge "Fix compilation error:"
Rob Tsuk [Wed, 1 Dec 2010 22:02:29 +0000 (14:02 -0800)]
am
1fc015f0: (-s ours) am
4741f411: Do not merge.
* commit '
1fc015f0ce86a2bed612d2eec53b01cac6b8a793':
Do not merge.
Rob Tsuk [Wed, 1 Dec 2010 21:59:11 +0000 (13:59 -0800)]
Steve Block [Tue, 30 Nov 2010 14:17:48 +0000 (14:17 +0000)]
Fix style in WebCore/platform/network/android
This matches what was upstreamed in
http://trac.webkit.org/changeset/73062
Change-Id: I2cf2064ab51105fb16039f8af285a3797abe49a9
Steve Block [Mon, 29 Nov 2010 17:18:33 +0000 (17:18 +0000)]
Use one WebRequestContext per WebView
This change switches from using a pair of WebRequestContexts (one for
private browsing, one for regular browsing) to using one
WebRequestContext per WebView. This is required to allow us to set the
userAgent on each WebView.
The WebRequestContext is now owned by the WebView.
Bug:
3113804
Change-Id: Iba2b1490e7ce4ff65c08a04a310963fa2c7e4f83
Huahui Wu [Wed, 1 Dec 2010 19:48:03 +0000 (11:48 -0800)]
Merge "b/
2864818 setting the appropriate error code for certificate error."
Rob Tsuk [Tue, 30 Nov 2010 22:32:49 +0000 (14:32 -0800)]
Do not merge.
Re-implement a security fix against our older webkit code base.
Change-Id: Iaefa1d060bb71b717558a427e326742f8fa5c4fd
modified: WebCore/rendering/RenderBlock.cpp
modified: WebCore/rendering/RenderBlock.cpp
Huahui Wu [Wed, 1 Dec 2010 19:24:06 +0000 (11:24 -0800)]
b/
2864818 setting the appropriate error code for certificate error.
Change-Id: I628b6fdd82089207c5a25ad816d3e6475d85911a
Steve Block [Wed, 1 Dec 2010 18:49:56 +0000 (10:49 -0800)]
Merge "Do more AutoFill steup lazily"
Steve Block [Wed, 1 Dec 2010 18:18:33 +0000 (18:18 +0000)]
Do more AutoFill steup lazily
Currently, much of the AutoFill setup is done in the WebAutoFill
constructor, which is called when the Page is created. This change moves
this setup to be done lazily when searchDocument() is called, which is
the entry point into the feature.
Change-Id: I0d437ed53391b5a7d8d16ec1000dc783c710e564
Steve Block [Wed, 1 Dec 2010 17:26:40 +0000 (09:26 -0800)]
Merge "Fix a bug when cleaning up private browsing"
Kristian Monsen [Wed, 1 Dec 2010 17:22:48 +0000 (09:22 -0800)]
Merge "Youtube urls can now start with /v/ or /e/"
Kristian Monsen [Wed, 1 Dec 2010 12:19:46 +0000 (12:19 +0000)]
Youtube urls can now start with /v/ or /e/
Fix for bug
3242961
Note that the youtube player crashes when you launch it,
but that also happens with old style urls.
Tested with the testcase in the bug.
Change-Id: I0cb59f8404fe47aabec34c0a21e614f553ea0c32
Steve Block [Tue, 30 Nov 2010 17:57:14 +0000 (17:57 +0000)]
Fix a bug when cleaning up private browsing
Delete the singleton WebCache and WebCookieJar objects when we
clear up private browsing, so that they are correctly recreated when
next required.
Note that this patch causes the WebCache to leak the HostResolver
object, as was the case before the refactoring in b/
3113804. See
b/
3243797.
Bug:
3113804
Change-Id: Ic0e2a45b5fd2b30097880e57eac2f6cadbd5dc85
Ben Murdoch [Wed, 1 Dec 2010 14:38:53 +0000 (14:38 +0000)]
WtfStringToJString should be able to return a valid string on empty input
It is sometimes desirable to return a valid but 0-length string created
from a 0-length WTF string but currently the WtfStringToJString function
will always return a null jstring on an empty input. Add a parameter to
specify that it should return an empty jstring on empty WTF string and
default it to false.
Change-Id: Ia449f1f9ae9b37c3da7d0272424e4fd4878ceb31
Iain Merrick [Wed, 1 Dec 2010 14:46:37 +0000 (06:46 -0800)]
Merge "Add FlushCookieStore() method to CookieManager (C++ side)."
Cary Clark [Wed, 1 Dec 2010 13:33:11 +0000 (05:33 -0800)]
Merge "attach the last extra to the next picture"
Cary Clark [Tue, 30 Nov 2010 20:51:10 +0000 (15:51 -0500)]
pass the x and y to retrieve anchor data
During a long press, the original pointer to the
node and frame may change. Pass the location instead
to attempt to find the anchor.
companion change in frameworks/base
bug:
3240869
Change-Id: Idf5eb67e2cb544dfa312e41f9224813c6ca80563
Cary Clark [Wed, 1 Dec 2010 12:38:01 +0000 (07:38 -0500)]
attach the last extra to the next picture
When a new picture is generated for the content,
use the last cursor ring / text selection etc.
for the interval between the picture message and
the view inval. This reduces flickering.
bug:
3230094
Change-Id: Ie099a8db395bfa707790ffe3c1f7f5398cc9afa4
Iain Merrick [Tue, 30 Nov 2010 11:42:19 +0000 (11:42 +0000)]
Add FlushCookieStore() method to CookieManager (C++ side).
The browser app will use this to sync cookies to flash when it is
sent to the background. Corresponding Java code is in I04e96aff.
Depends on external/chromium changes in Ie600c588.
Bug:
3231371
Change-Id: Ia9b56f3cdb5acd1fca23102b68b2f83a94ba6e69
Cary Clark [Wed, 1 Dec 2010 11:35:08 +0000 (03:35 -0800)]
am
e5097951: (-s ours) am
5793dcc1: Merge "Do not merge: fix dns prefetch, multiply range" into gingerbread
* commit '
e5097951a2019ae742b9c348b21e613631f59cdc':
Do not merge: fix dns prefetch, multiply range
Cary Clark [Tue, 30 Nov 2010 19:46:28 +0000 (11:46 -0800)]
am
5793dcc1: Merge "Do not merge: fix dns prefetch, multiply range" into gingerbread
* commit '
5793dcc19c1dd5f2f3daacd05646ae237f050e58':
Do not merge: fix dns prefetch, multiply range
Cary Clark [Tue, 30 Nov 2010 18:24:15 +0000 (10:24 -0800)]
Merge "hit test complete node even if partially visible"
Steve Block [Tue, 30 Nov 2010 15:04:16 +0000 (15:04 +0000)]
Remove a superfluous TODO in ResourceLoaderAndroid.cpp
Change-Id: I290228dce1ce3e0be56666775f591c6c2b7dab32
Cary Clark [Tue, 30 Nov 2010 13:08:37 +0000 (05:08 -0800)]
Merge "Do not merge: fix dns prefetch, multiply range" into gingerbread
Steve Block [Tue, 30 Nov 2010 12:20:07 +0000 (04:20 -0800)]
Merge "Provide a URLRequestContext directly to AutoFill, rather than a factory function"
Steve Block [Tue, 30 Nov 2010 11:32:14 +0000 (11:32 +0000)]
Provide a URLRequestContext directly to AutoFill, rather than a factory function
In b/
3044989, AutoFill was modified to take a factory function for the
URLRequestContext (which was then created when needed), rather than
taking the context directly. This was to avoid a race condition where
the context is created before the required storage paths have been
synced to the WebCore thread through the BrowserFrame.
Since https://android-git.corp.google.com/g/76579 and
https://android-git.corp.google.com/g/80056, we read the required
paths directly from JniUtils, so the race condition no longer exists. We
can therefore provide the context directly to AutoFill.
Note that while the context may be created before the Settings have been
synced to the WebCore thread, the necessary properties will be updated
as part of this sync before the context is used.
This change will also simplify things when we use one context per
WebView.
Also requires a change in external/chromium ...
https://android-git.corp.google.com/g/82146
Change-Id: Idfc34d435bae21654a02e5898aef0e84da98218a
Bart Sears [Tue, 30 Nov 2010 01:15:52 +0000 (17:15 -0800)]
am
a5b8875c: (-s ours) am
1baa4609: Cherry-pick WebKit security fix (webkit.org r64706) Do not merge
* commit '
a5b8875c0b61e9dc9eb76e16a4cc1f741709ee74':
Cherry-pick WebKit security fix (webkit.org r64706) Do not merge
Bart Sears [Tue, 30 Nov 2010 01:12:45 +0000 (17:12 -0800)]
am
1baa4609: Cherry-pick WebKit security fix (webkit.org r64706) Do not merge
* commit '
1baa4609252ea42065c4399b9081b2087c8d70a2':
Cherry-pick WebKit security fix (webkit.org r64706) Do not merge
Cary Clark [Mon, 29 Nov 2010 21:28:22 +0000 (16:28 -0500)]
hit test complete node even if partially visible
An older test incorrectly discards nodes if they are partially
off the screen. The test was attempting to ignore nodes that
were fully invisible, so change the test to do that.
bug:
3198707
Change-Id: I3cb13de3c86b43d3388849161bdfc44f84d93b3d
Nicolas Roard [Mon, 29 Nov 2010 18:57:05 +0000 (10:57 -0800)]
Merge "Refactoring the zoom"
Ben Murdoch [Mon, 29 Nov 2010 15:38:49 +0000 (07:38 -0800)]
Merge "AutoFill no longer needs a unique profile id native side."
Steve Block [Mon, 29 Nov 2010 15:19:42 +0000 (07:19 -0800)]
Merge changes I006cddf2,Ib304a845,I4622749d
* changes:
Moves implementation of ResourceLoaderAndroid to ResourceLoaderAndroid.cpp
Add a static WebRequestContext::acceptLanguage() method
Make WebCookieJar::get() threadsafe
Steve Block [Mon, 29 Nov 2010 14:55:36 +0000 (14:55 +0000)]
Moves implementation of ResourceLoaderAndroid to ResourceLoaderAndroid.cpp
This means that the implmentation of this class for both HTTP stacks is
in the same place.
Change-Id: I006cddf27c245a88327643314bb7564a2486ff38
Steve Block [Mon, 29 Nov 2010 14:09:58 +0000 (14:09 +0000)]
Add a static WebRequestContext::acceptLanguage() method
This removes the need for PlatformBridge::computeDefaultLanguage() to
get an instance of WebRequestContext. This is part of the refactoring to
use a WebRequestContext per WebView.
Bug:
3113804
Change-Id: Ib304a8457a82d09d80fe4d6298f00f688ec53b7c
Cary Clark [Thu, 11 Nov 2010 20:26:06 +0000 (15:26 -0500)]
scroll the selection when dragging near the edge
Return the bounds of a layer.
support for a companion change in frameworks/base
bug:
3186988
Change-Id: Ie8f69dc8c46c6329fd0b093ecdba4715f8cde2a9
Ben Murdoch [Mon, 29 Nov 2010 13:25:42 +0000 (13:25 +0000)]
AutoFill no longer needs a unique profile id native side.
AutoFill profiles now use GUIDs that they generate themselves
rather than injecting a unique int ID so we no longer need to
reach into the java class to grab the ID.
Change-Id: I26492aeddd130831e941ec79ef1f5e36271903c8
Steve Block [Mon, 29 Nov 2010 12:46:55 +0000 (12:46 +0000)]
Make WebCookieJar::get() threadsafe
This should have been part of
https://android-git.corp.google.com/g/78476 which factored
WebCookieJar out of WebRequestContext.
Also, now that WebRequestContext::get() is called nly on the WebCore
thread, it does not need to be threadsafe.
Bug:
3113804
Change-Id: I4622749d1650be0b9ca0d37541361955a367110f
Steve Block [Mon, 29 Nov 2010 11:51:10 +0000 (03:51 -0800)]
Merge "Factor out WebCache from WebRequestContext"
Steve Block [Fri, 26 Nov 2010 16:11:52 +0000 (16:11 +0000)]
Factor out WebCache from WebRequestContext
This is the second step in allowing us to have a WebRequestContext per
WebView, which is required to allow the useragent string to be
configured per WebView.
Bug:
3113804
Change-Id: Idcd252194562d1ef91d9d6e2baf8c65b8ff088d4
Steve Block [Fri, 26 Nov 2010 17:18:30 +0000 (09:18 -0800)]
Merge "Minor code cleanup in WebCookieJar"
Steve Block [Fri, 26 Nov 2010 14:31:37 +0000 (14:31 +0000)]
Minor code cleanup in WebCookieJar
Change-Id: Ia68bac6bd93b0afeff049a9ac0f056191d92d2a0
Steve Block [Fri, 26 Nov 2010 13:31:28 +0000 (05:31 -0800)]
Merge "Factor out CookieManager from WebRequestContext"
Kristian Monsen [Fri, 5 Nov 2010 14:43:45 +0000 (14:43 +0000)]
Factor out CookieManager from WebRequestContext
This is the first step in allowing us to have a WebRequestContext per
WebView, which is required to allow the useragent string to be
configured per WebView.
Bug:
3113804
Change-Id: I9ccf07d4a277147e74e2f3e701bd6d2166954280
Steve Block [Fri, 26 Nov 2010 12:28:14 +0000 (04:28 -0800)]
Merge "No longer need to pass storage paths to WebRequestContext.cleanupPrivateBrowsingFiles()"
Steve Block [Fri, 26 Nov 2010 11:27:42 +0000 (11:27 +0000)]
No longer need to pass storage paths to WebRequestContext.cleanupPrivateBrowsingFiles()
Requires the following changes to frameworks/base and packages/apps/Browser
https://android-git.corp.google.com/g/81782
https://android-git.corp.google.com/g/81780
Bug:
3232569
Change-Id: I73cabb561e206beee2bc1716f04aed8764797cc1
Steve Block [Fri, 26 Nov 2010 10:06:54 +0000 (02:06 -0800)]
Merge "Fixes WebResourceRequest to correctly set load flags"
Steve Block [Thu, 25 Nov 2010 12:11:15 +0000 (12:11 +0000)]
Fixes WebResourceRequest to correctly set load flags
We now correctly set the cookie load flags and the cache control HTTP
headers.
Bug:
2889880
Change-Id: I759a3131b73a8fc82432a067a31754fcc566c136
Iain Merrick [Thu, 25 Nov 2010 15:26:17 +0000 (15:26 +0000)]
Session cookies are now persistent.
We previously checked !IsPersistent() to determine whether a
cookie is a session cookie, but now all cookies are persistent,
so we need to call the new method IsSessionCookie().
Depends on https://android-git.corp.google.com/g/81755
Bug:
2864791
Change-Id: Ia44cd0cdc5e68a4b0a61bdeebd70cdccfc8e4e1b
Iain Merrick [Wed, 24 Nov 2010 10:38:33 +0000 (10:38 +0000)]
Set useCachedCredentials to true on first auth request.
This flag previously defaulted to false, but the Android CTS
specifies that a "sufficient" implementation should return true
on the first authentication request. (The second and subsequent
auth requests aren't tested.)
This CL sets the flag to true on the first authentication request
for a given WebRequest, but false for subsequent requests (i.e.,
if the first attempt to authenticate failed).
Using a counter rather than a flag in WebRequest for readability.
"isFirstAuthRequest" would be a bit ambiguous as a member variable,
but "authRequestCount" seems pretty clear.
Change-Id: Id9baae4c30111f743e079f90940078b07498b168
Nicolas Roard [Tue, 23 Nov 2010 03:48:11 +0000 (19:48 -0800)]
Refactoring the zoom
Change-Id: I84d44b6aab2222b52d21a65ceb74e390c677fe72
Cary Clark [Wed, 24 Nov 2010 19:58:36 +0000 (11:58 -0800)]
Merge "use style ignoring pending style sheets"
Cary Clark [Wed, 24 Nov 2010 19:50:46 +0000 (14:50 -0500)]
use style ignoring pending style sheets
If the style is not yet computed, attempting to
compute the style may blow up (e.g., the font points
to zero and is dereferenced). The webkit way around
this appears to be to ignore pending style sheets,
even though six lines down from this change, the
regular webkit makes the original styleForElement
call.
This does fix sfgate.com, so it's not a bad thing to
do, and the real style change should retrigger this
code path later on.
bug:
3194102
Change-Id: Ia558e3d49c94ed817d69d528b9e914f906f62a66
Cary Clark [Wed, 24 Nov 2010 18:34:30 +0000 (10:34 -0800)]
Merge "allow animated gifs to skip frames"
Ben Murdoch [Wed, 24 Nov 2010 18:23:00 +0000 (10:23 -0800)]
Merge "Fix crash in JavaClassV8"
Cary Clark [Wed, 24 Nov 2010 18:17:30 +0000 (13:17 -0500)]
allow animated gifs to skip frames
Removing this patch causes gifs to skip frames rather than
play all intermediate frames in an attempt to catch up.
bug:
2621902
Change-Id: Idc19b11991c37c685d1dc61bb5daddc6d12d30e0
Ben Murdoch [Wed, 24 Nov 2010 12:16:03 +0000 (12:16 +0000)]
Fix crash in JavaClassV8
It is possible that the m_name member of JavaClass is uninitialized as
we possibly early out from the constructor if we could not load the Java
class from the JVM. In this case when we call the dtor we try to free
uninitialized memory and crash. m_name is not actually used anywhere
so we just remove it.
Will upstream to webkit.
Bug:
3222518
Change-Id: I9354e9914157d2c4afd72dcce9122329c2486c89
Kristian Monsen [Wed, 24 Nov 2010 17:54:55 +0000 (09:54 -0800)]
Merge "Removing CRASH() from asserts in WebRequest.cpp"
Steve Block [Wed, 24 Nov 2010 16:25:11 +0000 (08:25 -0800)]
Merge "Add LayoutTests http/tests/cookies at r71558"
Cary Clark [Wed, 24 Nov 2010 15:45:12 +0000 (10:45 -0500)]
fix radio, checkbox hit testing
Radio and checkbox input types draw only a bitmap in
their navigation bounds, and require some special treatment.
Never treat them as transparent.
Use the slop box instead of the exact box when detecting
them, since our asset may be larger than the space webkit
provides.
Also, fix a debug test if the layer is null.
bug:
3215174
Change-Id: I3b573e3aa215268390db2d58435ac47115804ed7
Steve Block [Wed, 24 Nov 2010 13:46:35 +0000 (13:46 +0000)]
Add LayoutTests http/tests/cookies at r71558
All tests pass or have failing test expectations.
Bug:
3227269
Change-Id: Ia0d58eb29d312c57c2f687e5431bb997b9433560
Kristian Monsen [Wed, 24 Nov 2010 10:34:19 +0000 (10:34 +0000)]
Removing CRASH() from asserts in WebRequest.cpp
These asserts have not been triggered in months, so removing the
crash (but keeping logging), and closing bug
2951985.
Change-Id: I5bb31c6e23c18e83301428582ad895b0b679ff86
Cary Clark [Fri, 19 Nov 2010 19:23:02 +0000 (14:23 -0500)]
reenable draw extras when GL is turned on
This captures the drawing in the UI thread, then passes
the drawing to the tile imaging thread.
The draw extras interface now takes an additional rectangle,
and each draw extra fills in the inval area formed as that
part is drawn.
The old extra implementation in GLWebViewState has been
removed. The inval portion of the setBaseLayer call has been split
out so it can be called directly.
bug:
3161294
Change-Id: I28d3e6879059770b973e7c0f7c0796909f7359aa
Ben Murdoch [Tue, 23 Nov 2010 14:42:50 +0000 (14:42 +0000)]
Revert "Merge Chromium at r65505: Work around regression introduced by 64761"
This reverts commit
0c918ae77b5edfe59b726ff40a7c86dbc4a94307.
This was actually not really a regression as we were still broken
previously it's just that this change makes that breakage more visible.
The problem reproduces on tip of tree Chromium, so we can make the fix
upstream and then cherry pick into Android.
Change-Id: I4d65544b4ea137d77c00a39fcd29edb28b40aa1c
Ben Murdoch [Tue, 23 Nov 2010 12:20:38 +0000 (04:20 -0800)]
Merge "By default, provide native AutoFill with an empty profile."
Ben Murdoch [Wed, 17 Nov 2010 11:03:51 +0000 (11:03 +0000)]
By default, provide native AutoFill with an empty profile.
If no profile is set then AutoFill will not inform Java that it has
found a form that could be autofilled. We want to be able to offer
the user the option Java side to set up a profile in this case, so
we set by default an empty profile that is active until the user
syncs their real profile. This ensures that the AutoFill detection
code will not early out.
Change-Id: I474b25c5b31dae59e4ddb23c7f398d013e9d3beb
Nicolas Roard [Tue, 23 Nov 2010 03:25:45 +0000 (19:25 -0800)]
Fix the Zoom out / dirty tiles bug
Bug:
3212531 Bug:
3212527
Change-Id: Ie038f5b42cd34653f0a3e8fbe8c1fb1c0c3aceca
Derek Sollenberger [Mon, 22 Nov 2010 21:13:02 +0000 (16:13 -0500)]
Fix case where the Texture class held a reference to a deleted Tile.
bug:
3217947
Change-Id: If75673ece459d6539f1fd990d538347e13d60d68
Shimeng (Simon) Wang [Sat, 20 Nov 2010 01:50:21 +0000 (17:50 -0800)]
Clear GL inside clear view.
issue:
3215000
Change-Id: I8668a857d840084c363b13c95efffc740a1451db
Nicolas Roard [Mon, 22 Nov 2010 21:01:53 +0000 (13:01 -0800)]
Fix browser ANR when using Hardware Acceleration
Bug:
3217947
Change-Id: Ic0da5c4c131026a88afff2acc254a23a4d6a42ff
Iain Merrick [Mon, 22 Nov 2010 17:34:46 +0000 (09:34 -0800)]
Merge "Call maybeSavePassword() from Chrome HTTP stack."
Iain Merrick [Mon, 22 Nov 2010 17:34:39 +0000 (09:34 -0800)]
Merge "Add maybeSavePassword() method to WebFrame."
John Reck [Mon, 22 Nov 2010 17:29:44 +0000 (09:29 -0800)]
Merge "Fixes the handling of unspecified mime-type"
John Reck [Fri, 19 Nov 2010 23:01:47 +0000 (15:01 -0800)]
Fixes the handling of unspecified mime-type
Bug:
3211038 and
3211569
If the server doesn't specify a Content-Type header in the response,
there was no mime-type set when using the Chrome HTTP stack. This change
fixes it so that it makes a guess based off of the URL extension.
Change-Id: I33ef90c1db54bdccb4e143795656f4f9b56572ca
Iain Merrick [Fri, 19 Nov 2010 12:07:55 +0000 (12:07 +0000)]
Call maybeSavePassword() from Chrome HTTP stack.
This will prompt the user to save the username and password
when posting a form. Same behaviour as the Android HTTP stack.
Bug:
3060688
Test: Logged into amazon.co.uk, checked that password is saved.
Change-Id: I4185b7ef2fbb299e4441b18b50f0018f0208d264
Iain Merrick [Thu, 18 Nov 2010 18:18:30 +0000 (18:18 +0000)]
Add maybeSavePassword() method to WebFrame.
This calls through to the new entrypoint on the Java size
(see change I3f3f84a1). I've done some modest refactoring
to minimize code duplication. The way we obtain a pointer
to the frame is still a bit messy, but I couldn't find a
really clean solution to that.
Change-Id: Ia5c12f615b8c41f1c846bbf6fd6dcfe56f3e2a51
Leon Scroggins [Thu, 18 Nov 2010 18:58:43 +0000 (13:58 -0500)]
Provide the line spacing attribute for textareas.
Bug:
3085564
In order to line up the WebTextView text with the page's text,
we need to know the line spacing attribute stored in the DOM.
Requires a change in frameworks/base:
https://android-git.corp.google.com/g/#change,80646
Change-Id: I539454df318826233496ffcd140ba1d6e396a4a0
Ben Murdoch [Mon, 22 Nov 2010 10:12:24 +0000 (10:12 +0000)]
Merge Chromium at r65505: Work around regression introduced by 64761
This is a temporary workaround to fix the regression introduced on
Android by http://src.chromium.org/viewvc/chrome?view=rev&revision=64761
It should be reverted when we understand better the root cause of the
regression.
Change-Id: I6652d817254f1b8c3857e2f14b53d5d034d2f12f
Ben Murdoch [Fri, 19 Nov 2010 18:41:33 +0000 (18:41 +0000)]
Merge Chromium at r65505: Merge AutoFill change 64761
Merge in http://src.chromium.org/viewvc/chrome?view=rev&revision=64761
This is not part of the bigger autofill merge as this introdcues
a regression that we need to understand.
Change-Id: I08cfcefb93181e70a8a48d0c6da2217d3a5bbcf9
Ben Murdoch [Fri, 19 Nov 2010 18:26:32 +0000 (18:26 +0000)]
Merge Chromium at r65505: Update AutoFill files.
Bring our forked AutoFill files in line with r65505.
http://src.chromium.org/viewvc/chrome?view=rev&revision=63527
http://src.chromium.org/viewvc/chrome?view=rev&revision=63797
http://src.chromium.org/viewvc/chrome?view=rev&revision=64470
http://src.chromium.org/viewvc/chrome?view=rev&revision=64572
http://src.chromium.org/viewvc/chrome?view=rev&revision=64612
http://src.chromium.org/viewvc/chrome?view=rev&revision=64691
http://src.chromium.org/viewvc/chrome?view=rev&revision=64696
Change-Id: I34755e649d1093a79ad50de53dfd1d1f9e92a584
Ben Murdoch [Fri, 19 Nov 2010 13:40:28 +0000 (13:40 +0000)]
Merge Chromium at r65505: Initiliase the OpenSSL library.
See https://chromereview.prom.corp.google.com/
2010002/
Change-Id: I16754f6f18a54350671a2226d4c8c69615c63812
Ben Murdoch [Thu, 18 Nov 2010 19:56:26 +0000 (19:56 +0000)]
Merge Chromium at r65505: Update use of AutoFillProfile.
With this new Chromium merge, unique profile ids have been
deprecated and profile previews are obtained through the
Label function rather that PreviewSummary.
WebKit/android/WebCoreSupport/autofill/WebAutoFill.cpp:
WebKit/android/jni/WebSettings.cpp:
WebKit/android/WebCoreSupport/autofill/WebAutoFill.h:
http://src.chromium.org/viewvc/chrome?view=rev&revision=63806
http://src.chromium.org/viewvc/chrome?view=rev&revision=65100
Change-Id: I8af86c8be8627e17b13edf66349d9df8f85638a1
Ben Murdoch [Thu, 18 Nov 2010 19:54:50 +0000 (19:54 +0000)]
Merge Chromium at r65505: Update log message handler
Add new parameters to our error logging handler.
WebKit/android/WebCoreSupport/ChromiumLogging.cpp
http://src.chromium.org/viewvc/chrome?view=rev&revision=65062
Change-Id: I6f34f2c5170b218c81894da541c923782e150e2e