OSDN Git Service
Elliott Hughes [Fri, 21 Apr 2017 19:52:32 +0000 (19:52 +0000)]
Merge "Make the _Unwind_Ptr declaration match clang's."
Elliott Hughes [Fri, 21 Apr 2017 17:25:56 +0000 (10:25 -0700)]
Make the _Unwind_Ptr declaration match clang's.
Bug: https://issuetracker.google.com/
37126620
Test: builds, boots angler
Change-Id: I7d4a9b998f2e5c4c7b0beed87807d7b76a564c5c
Yi Kong [Fri, 21 Apr 2017 19:48:56 +0000 (19:48 +0000)]
Merge "Remove unused lambda captures"
Treehugger Robot [Fri, 21 Apr 2017 01:10:22 +0000 (01:10 +0000)]
Merge "DO NOT MERGE: The future is now."
Josh Gao [Thu, 20 Apr 2017 19:58:31 +0000 (12:58 -0700)]
DO NOT MERGE: The future is now.
__INTRODUCED_IN_FUTURE -> __INTRODUCED_IN(26)
Bug: http://b/
37437368
Test: treehugger
Change-Id: I601a23da83b65a0cd582cc840ed3856a9031b673
(cherry picked from commit
cb302f932a3532f1484e1e70894e9b1199384283)
Yi Kong [Thu, 20 Apr 2017 16:08:11 +0000 (09:08 -0700)]
Remove unused lambda captures
Clean up. This fixes build under -Wunused-lambda-capture.
Test: build
Change-Id: Ic12aa39e14ed55dbb28cf55303f9c4258179037d
Josh Gao [Thu, 20 Apr 2017 19:52:51 +0000 (19:52 +0000)]
Merge "Add syscalls that aren't currently used to the seccomp whitelist."
Treehugger Robot [Thu, 20 Apr 2017 02:45:02 +0000 (02:45 +0000)]
Merge "Decode the common EM_ values."
Elliott Hughes [Thu, 20 Apr 2017 00:44:57 +0000 (17:44 -0700)]
Decode the common EM_ values.
We know what "3" and "40" are, but most folks not on our team don't.
I don't think we need to support all the weird values, because only the
supported architectures actually occur in practice.
Bug: N/A
Test: manually overwrote aarch64 libcrypto.so with an x86-64 .so and ran "date"
Test: CANNOT LINK EXECUTABLE "date": "/system/lib64/libcrypto.so" has unexpected e_machine: 62 (EM_X86_64)
Change-Id: Ic4c6325fe7968f0c96fc0bfe15a50ed922a5ba55
Treehugger Robot [Wed, 19 Apr 2017 22:29:41 +0000 (22:29 +0000)]
Merge "Make all the ELF relocation constants available."
Josh Gao [Tue, 18 Apr 2017 23:05:39 +0000 (16:05 -0700)]
Add syscalls that aren't currently used to the seccomp whitelist.
Add some useful new syscalls that we currently aren't using in bionic,
but might in the future to the seccomp whitelist.
Bug: http://b/
37317198
Test: mma
Change-Id: I6550867da152cea84fb13d0c15a399cdb2acf1aa
Treehugger Robot [Wed, 19 Apr 2017 20:38:57 +0000 (20:38 +0000)]
Merge "Add missing required libraries"
Treehugger Robot [Wed, 19 Apr 2017 20:31:41 +0000 (20:31 +0000)]
Merge "libc: fix typo in __RENAME macro"
Elliott Hughes [Wed, 19 Apr 2017 20:25:27 +0000 (13:25 -0700)]
Make all the ELF relocation constants available.
BSD thinks you should only get the relocation constants for your target
architecture, but it's often useful to have them all available at once.
Rearrange the headers to enable that.
Also update the (modified) NetBSD files to CVS HEAD.
Also remove the unused BSDism R_TYPE.
Bug: N/A
Test: builds
Change-Id: Iad5ef29192a732696e2b36af35144a9ca116aa46
Treehugger Robot [Wed, 19 Apr 2017 19:26:41 +0000 (19:26 +0000)]
Merge "Add missing arch-specific AT_ cruft."
Dimitry Ivanov [Wed, 19 Apr 2017 18:58:52 +0000 (11:58 -0700)]
Add missing required libraries
Test: m
Change-Id: Id8c8c69547fbfb0c8efe73b324c8b6dcd52aa8ca
George Burgess IV [Wed, 19 Apr 2017 01:28:19 +0000 (18:28 -0700)]
libc: fix typo in __RENAME macro
Apparently __strncpy_real redirects to strcpy instead of strncpy for GCC
builds. This is bad, and it confused a project compiled by GCC that uses
strcpy.
I audited all of the FORTIFY-related __RENAMEs both manually and with a
script I hacked together; they all look correct aside from this one.
FWIW, with the cleaned up clang FORTIFY, lots of the `void foo()
__RENAME(foo)` will just become `void foo()` if this last thing I'm
working on gets through review.
Bug:
35329524
Test: Previously broken project now seems to work. Bullhead and Ryu
both build + boot.
Change-Id: Ib18ee3535ae31eb7e8ae846dc012f9b64cac80bf
Elliott Hughes [Wed, 19 Apr 2017 17:20:25 +0000 (10:20 -0700)]
Add missing arch-specific AT_ cruft.
AP_FPUCW is referenced by valgrind.
Bug: https://bugs.kde.org/show_bug.cgi?id=339945
Test: valgrind builds with one less hack
Change-Id: I7146f3709286662108cc82ba3c55ce935375a1f1
Treehugger Robot [Tue, 18 Apr 2017 22:46:59 +0000 (22:46 +0000)]
Merge "Add PT_ARM_EXIDX."
Treehugger Robot [Tue, 18 Apr 2017 17:56:04 +0000 (17:56 +0000)]
Merge "Move bionic_systrace.cpp over to CachedProperty."
Elliott Hughes [Tue, 18 Apr 2017 04:16:04 +0000 (04:16 +0000)]
Merge "Remove unused elf_machdep.h cruft."
Treehugger Robot [Tue, 18 Apr 2017 01:00:20 +0000 (01:00 +0000)]
Merge "Document DT_RUNPATH support."
Treehugger Robot [Mon, 17 Apr 2017 23:45:55 +0000 (23:45 +0000)]
Merge "Un-deprecated __system_property_find_nth."
Elliott Hughes [Mon, 17 Apr 2017 23:25:09 +0000 (16:25 -0700)]
Remove unused elf_machdep.h cruft.
Also add a few missing include guards.
Bug: N/A
Test: builds
Change-Id: I9557303c81a4b11d430112528def038ecb5562a9
Dan Albert [Mon, 17 Apr 2017 23:06:59 +0000 (16:06 -0700)]
Add PT_ARM_EXIDX.
The updated LLVM libunwind needs this to be defined.
Test: make checkbuild
Bug: None
Change-Id: Ia20016a9e3becb37ea6902f1959d1884c1263e51
Elliott Hughes [Mon, 17 Apr 2017 23:01:23 +0000 (16:01 -0700)]
Document DT_RUNPATH support.
Bug: http://b/
37328826
Test: N/A
Change-Id: Ia220f7f519e3cdd6193faff3b58d598505d4d0cf
Elliott Hughes [Mon, 17 Apr 2017 21:53:07 +0000 (14:53 -0700)]
Un-deprecated __system_property_find_nth.
Netflix was using this, and looking the header file, although
__system_property_find_nth has been available since the beginning of time,
__system_property_foreach only appeared in 16. So anyone who wants to run
on pre-JellyBean devices would want to use __system_property_find_nth.
It's pretty much a one-liner in terms of __system_property_foreach anyway,
so it doesn't cost us anything to keep it.
Also restore slightly better tests than we originally removed.
Bug: http://b/
36566667
Test: ran tests
Change-Id: Id268c2c2e848da17bb0a5a5420af234d9dcb829a
Elliott Hughes [Mon, 17 Apr 2017 21:12:25 +0000 (14:12 -0700)]
Move bionic_systrace.cpp over to CachedProperty.
This is the last bionic caller that was manually trying to cache
property values.
Bug: N/A
Test: builds and boots
Change-Id: Id66c0a05d8448f08c39dbf7189241e75615d44b4
Treehugger Robot [Mon, 17 Apr 2017 17:09:40 +0000 (17:09 +0000)]
Merge "Link to the public post about clang FORTIFY."
Elliott Hughes [Sun, 16 Apr 2017 15:50:58 +0000 (08:50 -0700)]
Link to the public post about clang FORTIFY.
Bug: N/A
Test: builds
Change-Id: I1c2040fdd3c3bbe61a8adfc1f414fce50087a1b8
Treehugger Robot [Sat, 15 Apr 2017 22:30:57 +0000 (22:30 +0000)]
Merge "Avoid "D linker : (null)" with debug.ld.all for dlerror."
Elliott Hughes [Sat, 15 Apr 2017 16:11:15 +0000 (09:11 -0700)]
Avoid "D linker : (null)" with debug.ld.all for dlerror.
We only want to know when dlerror is actually set. The previous change
to this logic moved it so that we only show actual updates to dlerror,
not every string that might end up in dlerror's output. This change
ignores cases where we're _clearing_ dlerror (which happens on every
call to dlerror).
Bug: http://b/
37287938
Test: ran tests
Change-Id: I0c30ee199dc76d9aea165c1d90f694ead488518b
Treehugger Robot [Sat, 15 Apr 2017 00:18:29 +0000 (00:18 +0000)]
Merge "Report the right error code from PropertyServiceConnection()"
Elliott Hughes [Fri, 14 Apr 2017 22:14:43 +0000 (22:14 +0000)]
Merge "Fix incorrect check."
Tom Cherry [Fri, 14 Apr 2017 20:45:20 +0000 (13:45 -0700)]
Report the right error code from PropertyServiceConnection()
We're currently reporting errno from the clean up call to close(),
which is much less interesting than the failing connect() call that
precedes it. This change reports errno from the connect() call
instead.
Bug:
36249702
Test: Boot bullhead, bionic unit tests
Test: Fake bad end point and see relevant error returned
Change-Id: Icadec463f50cd0a2a2faa08f049a7996cd32786f
Christopher Ferris [Fri, 14 Apr 2017 19:58:24 +0000 (12:58 -0700)]
Fix incorrect check.
Bug:
37347846
Test: No error on data +%s
Change-Id: I7e88ea842af29ce4a366c25a3f79c09b63a25004
Christopher Ferris [Fri, 14 Apr 2017 16:00:00 +0000 (16:00 +0000)]
Merge "libc: ARM: Add 32-bit Kryo memcpy"
Treehugger Robot [Fri, 14 Apr 2017 05:43:46 +0000 (05:43 +0000)]
Merge "Address review comments on the bionic tzdata loader."
Treehugger Robot [Thu, 13 Apr 2017 19:26:03 +0000 (19:26 +0000)]
Merge "Restore __system_property_find_nth version"
Jake Weinstein [Fri, 26 Aug 2016 00:03:25 +0000 (20:03 -0400)]
libc: ARM: Add 32-bit Kryo memcpy
* Memcpy is based on Scorpion due to Qualcomm's
128-bit cache line size optimizations.
* PLDOFFSET and PLDSIZE are from the ARM64 Kryo memcpy routine.
Below are the results of the benchmark, tested on a OnePlus 3 with MSM8996.
Before:
BM_string_memcpy/8 1000k 8 0.934 GiB/s
BM_string_memcpy/64 1000k 11 5.785 GiB/s
BM_string_memcpy/512 1000k 25 19.918 GiB/s
BM_string_memcpy/1024 50M 42 23.938 GiB/s
BM_string_memcpy/8Ki 10M 473 17.291 GiB/s
BM_string_memcpy/16Ki 5M 565 28.976 GiB/s
BM_string_memcpy/32Ki 1000k 1105 29.631 GiB/s
BM_string_memcpy/64Ki 1000k 2194 29.864 GiB/s
After:
BM_string_memcpy/8 1000k 6 1.145 GiB/s
BM_string_memcpy/64 1000k 7 8.560 GiB/s
BM_string_memcpy/512 1000k 18 27.370 GiB/s
BM_string_memcpy/1024 50M 33 30.340 GiB/s
BM_string_memcpy/8Ki 10M 266 30.770 GiB/s
BM_string_memcpy/16Ki 5M 553 29.599 GiB/s
BM_string_memcpy/32Ki 1000k 1121 29.219 GiB/s
BM_string_memcpy/64Ki 1000k 2208 29.678 GiB/s
Test: make otapackage
Test: Ran bionic unit tests on Pixel device. Verified memcpy wins on
Test: Pixel device.
Change-Id: Id7a9c37ef75a306dd5cf8d374d79d0fe83f8a3ba
Dimitry Ivanov [Thu, 13 Apr 2017 01:05:56 +0000 (18:05 -0700)]
Restore __system_property_find_nth version
Moving this to LIBC_DEPRECATED caused compatibility
problems for some apps.
Bug: http://b/
36566667
Test: launch app and check that it does not crash
Change-Id: I470f916ef818ff62ff5391b3a0c86dd44c1e8cd0
(cherry picked from commit
2167e74f168a192ca9c63abee1c03197326b83d7)
Christopher Ferris [Thu, 13 Apr 2017 17:45:53 +0000 (17:45 +0000)]
Merge "libc: use Cortex-A7/A53 memset on Kryo"
Treehugger Robot [Thu, 13 Apr 2017 15:09:46 +0000 (15:09 +0000)]
Merge "Add seccomp blacklist, and exclude swap functions"
Jake Weinstein [Fri, 7 Apr 2017 18:55:53 +0000 (14:55 -0400)]
libc: use Cortex-A7/A53 memset on Kryo
Tested on OnePlus 3 with MSM8996
Before (Krait):
BM_string_memset/8 1000k 7 1.071 GiB/s
BM_string_memset/64 1000k 9 6.720 GiB/s
BM_string_memset/512 1000k 19 26.699 GiB/s
BM_string_memset/1024 1000k 29 34.214 GiB/s
BM_string_memset/8Ki 10M 184 44.302 GiB/s
BM_string_memset/16Ki 5M 351 46.656 GiB/s
BM_string_memset/32Ki 5M 686 47.744 GiB/s
BM_string_memset/64Ki 1000k 1355 48.342 GiB/s
After (A7/A53):
BM_string_memset/8 1000k 7 1.017 GiB/s
BM_string_memset/64 1000k 7 8.039 GiB/s
BM_string_memset/512 1000k 13 37.976 GiB/s
BM_string_memset/1024 1000k 21 47.595 GiB/s
BM_string_memset/8Ki 10M 150 54.354 GiB/s
BM_string_memset/16Ki 10M 285 57.336 GiB/s
BM_string_memset/32Ki 5M 555 59.016 GiB/s
BM_string_memset/64Ki 1000k 1097 59.720 GiB/s
Test: make otapackage
Test: Verified this wins in all dimensions on a Pixel device.
Change-Id: I4cb72cc0363877de7c41d6f991149fda42fd0b4b
Elliott Hughes [Wed, 12 Apr 2017 19:03:44 +0000 (12:03 -0700)]
Address review comments on the bionic tzdata loader.
Bug: N/A
Test: ran tests
Change-Id: Ia7e27a2f93fe814e46b0912ce358b72651192173
Paul Lawrence [Wed, 12 Apr 2017 17:02:54 +0000 (10:02 -0700)]
Add seccomp blacklist, and exclude swap functions
Bug:
37253880
Test: Make sure device boots
Run pylint on genseccomp.py, test_genseccomp.py
Run test_genseccomp.py
Run new CTS test
cts-tradefed run cts -m CtsSecurityTestCases -t android.security.cts.SeccompTest
Change-Id: I833a5364a1481d65173e77654da1798dc45a3f9d
Treehugger Robot [Wed, 12 Apr 2017 19:02:14 +0000 (19:02 +0000)]
Merge "Move libc_logging.cpp over to CachedProperty."
Treehugger Robot [Wed, 12 Apr 2017 18:41:26 +0000 (18:41 +0000)]
Merge "The workaround for apps using older version of soinfos"
Treehugger Robot [Wed, 12 Apr 2017 18:15:51 +0000 (18:15 +0000)]
Merge "Move localtime.c over to CachedProperty."
Dimitry Ivanov [Tue, 11 Apr 2017 22:22:49 +0000 (15:22 -0700)]
The workaround for apps using older version of soinfos
Skip the check for accessibility in the case soinfo
does not have primary/secondary namespaces associated
with them.
Bug: http://b/
37191433
Test: start an app from http://b/
37191433 make sure it does not crash on lunch
Change-Id: Id4c0bdab4dfc6bc8a33fc275d71e325518e0759f
(cherry picked from commit
97b4c5f2649db06661e45147f21a2ab26340ad89)
Treehugger Robot [Wed, 12 Apr 2017 07:54:02 +0000 (07:54 +0000)]
Merge "'make bionic-unit-tests' now builds all the required binaries"
Treehugger Robot [Wed, 12 Apr 2017 05:59:56 +0000 (05:59 +0000)]
Merge "Remove the useless lock from CachedProperty."
Elliott Hughes [Wed, 12 Apr 2017 00:23:37 +0000 (17:23 -0700)]
Remove the useless lock from CachedProperty.
Also document that the caller should provide locking at an
appropriate scope.
Bug: N/A
Test: ran tests
Change-Id: Ib84802fd8b9dbe69f98feab80edef05549a3f73e
Dan Willemsen [Wed, 12 Apr 2017 00:06:51 +0000 (00:06 +0000)]
Merge "Mark CRT objects as vendor available"
Dan Willemsen [Fri, 7 Apr 2017 21:09:05 +0000 (14:09 -0700)]
Mark CRT objects as vendor available
This will build separate copies of the CRT for vendor vs system when
BOARD_VNDK_VERSION is set. We'll be able to change crtbrand / etc as
needed with #ifdef __ANDROID_VNDK__ and similar.
Bug:
36426473
Bug:
36079834
Test: Put #ifdef __ANDROID_VNDK__ into crtbrand.S, see changes
Change-Id: I7db0cccfe94d144f072e7cef23832884f3c066f0
Treehugger Robot [Tue, 11 Apr 2017 23:48:56 +0000 (23:48 +0000)]
Merge "Don't let missing Treble property context files affect errno."
Dimitry Ivanov [Mon, 10 Apr 2017 23:52:25 +0000 (16:52 -0700)]
'make bionic-unit-tests' now builds all the required binaries
Test: make
Change-Id: Ie2f5dffaa4a09eba6714ced8ab0043fd7446bee5
Christopher Ferris [Tue, 11 Apr 2017 23:14:55 +0000 (23:14 +0000)]
Merge "Fix missing parse_open_file method."
Elliott Hughes [Tue, 11 Apr 2017 22:18:38 +0000 (15:18 -0700)]
Move libc_logging.cpp over to CachedProperty.
Bug: N/A
Test: ran tests
Change-Id: I50f9065799e783df961e1275a4cda671fcf0fd32
Elliott Hughes [Tue, 11 Apr 2017 21:44:51 +0000 (14:44 -0700)]
Move localtime.c over to CachedProperty.
Since localtime.c is C, this entails pulling our code out into its own
C++ file, which we should probably have done years ago anyway.
Bug: N/A
Test: ran tests, and manually tested via Settings
Change-Id: Ifc787a553e8f739a87641a2d35321aca40a47286
Elliott Hughes [Tue, 11 Apr 2017 20:38:36 +0000 (13:38 -0700)]
Don't let missing Treble property context files affect errno.
User code on a non-treble device was starting with errno == ENOENT rather
than 0 because of this treble support:
openat(AT_FDCWD, "/property_contexts", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
faccessat(AT_FDCWD, "/system/etc/selinux/plat_property_contexts", R_OK) = -1 ENOENT (No such file or directory)
This caused us to fail some toybox tests by reporting bogus errno values
where errno should have been left unset:
PASS: date -d @0
FAIL: date -d @0x123
echo -ne '' | TZ=UTC date -d @0x123 2>&1
--- expected
+++ actual
@@ -1 +1 @@
-date: bad date '@0x123'
+date: bad date '@0x123': No such file or directory
PASS: date -d
06021234
PASS: date -d
060212341982
FAIL: date -d 123
echo -ne '' | TZ=UTC date -d 123 2>&1
--- expected
+++ actual
@@ -1 +1 @@
-date: bad date '123'
+date: bad date '123': No such file or directory
PASS: date -d
1110143115.30
PASS: date -d
111014312015.30
PASS: date Unix time missing @
Bug: http://b/
37248982
Test: ran tests
Change-Id: Iacf08c89dbe207ec53a7837e6ac7f78f5541ef35
Alessio Balsini [Tue, 11 Apr 2017 16:27:29 +0000 (18:27 +0200)]
Fix missing parse_open_file method.
gensyscalls.py was failing to execute because of a missing "self"
keyword when calling parse_open_file.
Test: manual test running gensyscalls.py.
Change-Id: I78db2cba704c5ca56a730019e36601a7ccd069f8
Treehugger Robot [Tue, 11 Apr 2017 16:19:14 +0000 (16:19 +0000)]
Merge "Remove .(ll)ndk suffix from (ll)ndk_library"
Dan Willemsen [Fri, 7 Apr 2017 21:09:18 +0000 (14:09 -0700)]
Remove .(ll)ndk suffix from (ll)ndk_library
Soong handles these automatically now.
Bug:
33241851
Test: Android-aosp_arm.mk is the same before/after
Test: build.ninja is the same before/after
Test: build-aosp_arm.ninja is the same before/after
Merged-In: Ibfe4cf5db732d9007b1cc12dbc523c427de1b23d
Change-Id: Ibfe4cf5db732d9007b1cc12dbc523c427de1b23d
Treehugger Robot [Tue, 11 Apr 2017 06:07:06 +0000 (06:07 +0000)]
Merge "Send developers straight to the text relocation docs."
Elliott Hughes [Mon, 10 Apr 2017 16:52:33 +0000 (09:52 -0700)]
Send developers straight to the text relocation docs.
It's been years since we allowed text relocations, but I had a developer
ask me how to fix them at last week's O Developer Day. They'd never seen
our docs, so let's try to fix that for anyone else who's still confused...
Bug: N/A
Test: builds
Change-Id: I9202a7b0a3f024041b646c43c87585f4fab22d09
Christopher Ferris [Mon, 10 Apr 2017 19:49:37 +0000 (19:49 +0000)]
Merge "Refactor Config from a struct to a class."
Dan Willemsen [Fri, 7 Apr 2017 21:21:32 +0000 (21:21 +0000)]
Merge "Add LLNDK stub libraries for the VNDK"
Treehugger Robot [Thu, 6 Apr 2017 23:35:51 +0000 (23:35 +0000)]
Merge "versioner: fix LLVM assertion failure."
Tom Cherry [Thu, 6 Apr 2017 22:41:02 +0000 (22:41 +0000)]
Merge "Move scopeguard into android::base"
Christopher Ferris [Thu, 6 Apr 2017 02:13:03 +0000 (19:13 -0700)]
Refactor Config from a struct to a class.
This should make it easier to add new options, and to add options that
are complex. For example, I want to modify the behavior of
record_allocs_file so that it also enables record_allocs to a default
state.
Test: All unit tests pass.
Test: Enable the backtrace option and restart.
Change-Id: Idf5cdeed06ade3bc2c8ae39d228734bf65209b4f
Treehugger Robot [Thu, 6 Apr 2017 22:30:20 +0000 (22:30 +0000)]
Merge "Enable FORTIFY unit tests for clang"
Josh Gao [Thu, 6 Apr 2017 19:57:22 +0000 (12:57 -0700)]
versioner: fix LLVM assertion failure.
MemoryBuffer::getOpenFileSlice asserts that the map size passed in
isn't -1 (presumably because the offset can be nonzero). Switch to
getOpenFile, which results in an identical call to the implementation
function without the assert.
Bug: http://b/
37002637
Test: export FORCE_BUILD_LLVM_COMPONENTS=true
export FORCE_BUILD_LLVM_DEBUG=true
export FORCE_BUILD_LLVM_DISABLE_NDEBUG=true
mma -j && versioner
Change-Id: Ib610db9e07429aa3f64128eaef6ef555c4d1868e
Treehugger Robot [Thu, 6 Apr 2017 20:29:40 +0000 (20:29 +0000)]
Merge "Add support for disabling the greylist."
George Burgess IV [Thu, 6 Apr 2017 18:26:11 +0000 (11:26 -0700)]
Enable FORTIFY unit tests for clang
And add a thing to remind us to enable the malloc FORTIFY test when we
pull a new clang in.
Bug:
34747525
Test: vts -m BionicUnitTests on bullhead
Change-Id: If341a27756d608a0fa77ba6518e9bcc725f7632c
Elliott Hughes [Fri, 24 Mar 2017 00:42:49 +0000 (17:42 -0700)]
Add support for disabling the greylist.
Useful for testing whether apps have actually stopped using greylisted
libraries even if they still have references to them in their apk to support
old Android releases but also haven't bumped their targetSdkVersion yet.
Since we already have two expensive __system_property_get calls and this
would add a third, optimize two (but leave the third since it's not
obviously amenable to optimization). None of this matters for user builds,
but I don't want userdebug/eng to have distractingly different performance.
(cherrypick of
7933bec2872aa1c3430149c7649726333c0ac9d8.)
Bug: http://b/
36106661
Test: ran "can you escape 5" with and without this property
Change-Id: Id9a804695c1dca9b4be2ebd0e72f01817bb13cba
Hans Boehm [Thu, 6 Apr 2017 01:02:28 +0000 (01:02 +0000)]
Merge "Fix compare_exchange_weak tests to allow spurious failure"
Treehugger Robot [Wed, 5 Apr 2017 23:57:12 +0000 (23:57 +0000)]
Merge "libc: add const-correct string.h overloads"
Tom Cherry [Wed, 5 Apr 2017 23:20:29 +0000 (16:20 -0700)]
Move scopeguard into android::base
Test: boot bullhead, bionic unit tests
Change-Id: I223249684867655ecb53713b10da41d3014f96ae
Hans Boehm [Wed, 5 Apr 2017 00:34:59 +0000 (17:34 -0700)]
Fix compare_exchange_weak tests to allow spurious failure
Test: Ran bionic unit tests on angler.
Bug:
36869788
Change-Id: Ic1e0e4e409ac719d5b426391a771b4858a6149ee
Dan Willemsen [Mon, 20 Mar 2017 21:07:47 +0000 (14:07 -0700)]
Add LLNDK stub libraries for the VNDK
The stub libraries are the same as the (equivalent version) NDK, but
they also contain symbols tagged with 'vndk'. Except there are none of
those in Bionic currently.
For headers, the LLNDK/VNDK isn't using a sysroot like the NDK. Nor is
it hardcoding an explicit source path list like the platform. Instead it
runs the bionic/libc/include directory through versioner like the NDK,
then exports those generated headers and the kernel headers from the
stub library like any other exported header. Except it uses -isystem
instead of -I due to export_headers_as_system.
Test: aosp_arm; m -j
Test: Enable BOARD_VNDK_VERSION on aosp_arm; m -j
Test: Inspect out/soong/build.ninja before/after (w/o vndk)
Change-Id: Ief58a73907a83053b408b1d4b62999cba470d61c
Treehugger Robot [Wed, 5 Apr 2017 22:28:59 +0000 (22:28 +0000)]
Merge "libc: remove newlines in prototypes in string.h"
George Burgess IV [Wed, 5 Apr 2017 20:24:05 +0000 (13:24 -0700)]
libc: remove newlines in prototypes in string.h
This gives more useful diagnostics if clang needs to mention these
functions (or a parameter of them).
Bug:
36984245
Test: m on bullhead completes successfully.
Change-Id: I17c2b624d08bc9dd3f08185b30029ed0c49ebb08
George Burgess IV [Wed, 5 Apr 2017 00:34:02 +0000 (17:34 -0700)]
libc: add const-correct string.h overloads
libcxx provides const-correct overloads for a few string.h functions.
These overloads use clang's enable_if attribute, so they're preferred
over our FORTIFY'ed equivalents.
This weakens _FORTIFY_SOURCE=2 when used with some of these functions,
since clang needs to see __pass_object_size in order to pass an accurate
result for __builtin_object_size(s, 1) at a callsite. Since those
functions don't have __pass_object_size on their params, clang can't do
that. This makes LLVM lower the __builtin_object_size calls, which means
we get the same result as __builtin_object_size(s, 0).
We have to provide all of the overloads in Bionic, since enable_if is
only used to disambiguate overloads with (otherwise) the same type. In
other words:
// overload 1
char *strchr(const char *, int s) __attribute__((enable_if(1, "")));
// overload 2
char *strchr(char *, int s);
void foo() {
char cs[1] = {};
strchr(static_cast<const char *>(cs), '\0'); // calls overload #1.
strchr(cs, '\0'); // calls overload #2.
}
Bug:
34747525
Test: m checkbuild on bullhead internal master + AOSP. vts -m
BionicUnitTests passes on both. Surprisingly, the only code that this
seems to break is contained in Bionic.
Change-Id: Ie406f42fb3d1c5bf940dc857889876fc39b57c90
Neil Fuller [Wed, 5 Apr 2017 14:11:14 +0000 (14:11 +0000)]
Merge "Add (duplicate) license from new XML file"
Neil Fuller [Wed, 5 Apr 2017 13:57:00 +0000 (14:57 +0100)]
Add (duplicate) license from new XML file
This change was forgotten when I uploaded tzlookup.xml for
review. I meant to check this with enh@. Apologies. This fixes
the the NOTICE file so others can upload.
Test: repo upload
Change-Id: I9e722952f9ae8c8d971b1c2d23d53079d85f4ae7
Neil Fuller [Wed, 5 Apr 2017 13:33:32 +0000 (13:33 +0000)]
Merge "Addition of a new system file for time zone data"
Treehugger Robot [Wed, 5 Apr 2017 02:12:00 +0000 (02:12 +0000)]
Merge "Remove obsolete Android.mk comments"
Dan Willemsen [Tue, 4 Apr 2017 22:51:26 +0000 (15:51 -0700)]
Remove obsolete Android.mk comments
Test: none
Change-Id: I0419800d44a7918a4415baf840c7d30bf30a18ed
Christopher Ferris [Tue, 4 Apr 2017 21:10:55 +0000 (21:10 +0000)]
Merge "Add kryo support."
Treehugger Robot [Tue, 4 Apr 2017 20:01:36 +0000 (20:01 +0000)]
Merge "libc: use __bos instead of __bos0 for strchr."
George Burgess IV [Tue, 4 Apr 2017 01:03:36 +0000 (18:03 -0700)]
libc: use __bos instead of __bos0 for strchr.
I dunno why I used __bos0 in the first place; clang's strrchr (and
GCC's strchr+strrchr) both use __bos.
Bug:
34747525
Test: m. Device still boots. cts -m BionicUnitTests shows no new
failures.
Change-Id: Ifec0e05a6a1144fa3e3ac70562af3ec57c09c194
Josh Gao [Tue, 4 Apr 2017 00:49:24 +0000 (00:49 +0000)]
Merge "Break android_set_abort_message out of libc_logging."
am:
1c864b630f
Change-Id: I7d8ab343a09a0e2166d0462a3b378257cb837f67
Josh Gao [Tue, 4 Apr 2017 00:40:38 +0000 (00:40 +0000)]
Merge "Break android_set_abort_message out of libc_logging."
Josh Gao [Mon, 3 Apr 2017 23:26:49 +0000 (23:26 +0000)]
Merge changes I70edafb7,I96cba65e,I5142a335
am:
1400acc159
Change-Id: I8a336aac72ba8fa173ef2ea3364a55d7d84fc4f5
Treehugger Robot [Mon, 3 Apr 2017 23:17:58 +0000 (23:17 +0000)]
Merge changes I70edafb7,I96cba65e,I5142a335
* changes:
versioner: remove useless log message.
versioner: fix indentation in usage.
versioner: guard preprocessing messages with -v.
Josh Gao [Mon, 3 Apr 2017 22:13:29 +0000 (15:13 -0700)]
Break android_set_abort_message out of libc_logging.
libc_logging is getting statically linked into the crash handler
library, resulting in two copies of the abort message code existing in
processes, one in the linker, and one in the crash handler.
Move android_set_abort_message to its own file to solve this.
Bug: http://b/
36862204
Test: /data/nativetest/debuggerd_test/debuggerd_test32
Change-Id: Ie198c5a3bb07645aa43296915c9a6752693f14a9
Josh Gao [Mon, 3 Apr 2017 20:41:38 +0000 (20:41 +0000)]
Merge changes I826756d9,I00e2edb2
am:
6367f5ee55
Change-Id: I0585784475e8288fc06e5ca1089ff227f87001bd
Josh Gao [Mon, 3 Apr 2017 20:33:16 +0000 (20:33 +0000)]
Merge changes I826756d9,I00e2edb2
* changes:
libc_logging: mention that they're async signal safe.
linker: update dependencies.
Josh Gao [Mon, 3 Apr 2017 18:48:55 +0000 (11:48 -0700)]
versioner: remove useless log message.
Test: tools/versioner/run_tests.py
Change-Id: I70edafb7ad6a6274e7daa508903520dbb4b399c8