OSDN Git Service

android-x86/frameworks-base.git
4 years ago[automerger skipped] Merge "DO NOT MERGE: Disable SpellChecker in secondary user...
Automerger Merge Worker [Wed, 11 Dec 2019 19:53:03 +0000 (19:53 +0000)]
[automerger skipped] Merge "DO NOT MERGE: Disable SpellChecker in secondary user's direct reply" into oc-dev am: 70ffc41cad am: 063d83ca63 am: 402a7b2c33 -s ours
am skip reason: subject contains skip directive

Change-Id: Ie33411c2b6b95dba41997171acf0fced3ba4a740

4 years ago[automerger skipped] DO NOT MERGE: Disable SpellChecker in secondary user's direct...
Automerger Merge Worker [Wed, 11 Dec 2019 19:52:49 +0000 (19:52 +0000)]
[automerger skipped] DO NOT MERGE: Disable SpellChecker in secondary user's direct reply am: b52efcb9d5 am: 9b1ddfe488 am: 4f5d0e446e -s ours
am skip reason: subject contains skip directive

Change-Id: I770bd1ba8cc66b4179e88f194d45bb715be1977c

4 years agoMerge "DO NOT MERGE: Disable SpellChecker in secondary user's direct reply" into...
Automerger Merge Worker [Wed, 11 Dec 2019 19:30:18 +0000 (19:30 +0000)]
Merge "DO NOT MERGE: Disable SpellChecker in secondary user's direct reply" into oc-dev am: 70ffc41cad am: 063d83ca63

Change-Id: I0622df10fdde4fb961c920fc0c9529e4c3b3ecfc

4 years agoDO NOT MERGE: Disable SpellChecker in secondary user's direct reply am: b52efcb9d5...
Automerger Merge Worker [Wed, 11 Dec 2019 19:30:08 +0000 (19:30 +0000)]
DO NOT MERGE: Disable SpellChecker in secondary user's direct reply am: b52efcb9d5 am: 9b1ddfe488

Change-Id: Idcdef9d986a8d0e2f6f0209fd550900a6275796d

4 years agoMerge "DO NOT MERGE: Disable SpellChecker in secondary user's direct reply" into...
Automerger Merge Worker [Wed, 11 Dec 2019 19:10:38 +0000 (19:10 +0000)]
Merge "DO NOT MERGE: Disable SpellChecker in secondary user's direct reply" into oc-dev am: 70ffc41cad

Change-Id: I8439eee725f85cc1e939772663a4217e5dde2e38

4 years agoDO NOT MERGE: Disable SpellChecker in secondary user's direct reply am: b52efcb9d5
Automerger Merge Worker [Wed, 11 Dec 2019 19:10:27 +0000 (19:10 +0000)]
DO NOT MERGE: Disable SpellChecker in secondary user's direct reply am: b52efcb9d5

Change-Id: I438383977e4b7454e732dba8d2906a8c333f2bad

4 years agoMerge "DO NOT MERGE: Disable SpellChecker in secondary user's direct reply" into...
Taran Singh [Wed, 11 Dec 2019 18:52:54 +0000 (18:52 +0000)]
Merge "DO NOT MERGE: Disable SpellChecker in secondary user's direct reply" into oc-dev

4 years ago[automerger skipped] resolve merge conflicts of 88c651eab144bf64acb1d99f11aabe983f236...
Evan Laird [Wed, 20 Nov 2019 19:28:47 +0000 (11:28 -0800)]
[automerger skipped] resolve merge conflicts of 88c651eab144bf64acb1d99f11aabe983f23658c to oc-dr1-dev am: 2bb3845dff -s ours
am: ff797c3ba3 -s ours
am skip reason: change_id I0680034ed9315aa2c05282524d48faaed066ebd0 with SHA1 3b8c4743f6 is in history

Change-Id: I4236581921e3572b932a95c37a69a062e90b9231

4 years ago[automerger skipped] resolve merge conflicts of 88c651eab144bf64acb1d99f11aabe983f236...
Automerger Merge Worker [Wed, 20 Nov 2019 19:05:29 +0000 (19:05 +0000)]
[automerger skipped] resolve merge conflicts of 88c651eab144bf64acb1d99f11aabe983f23658c to oc-dr1-dev am: 2bb3845dff -s ours
am skip reason: Change-Id I0680034ed9315aa2c05282524d48faaed066ebd0 with SHA-1 3692a6d231 is in history

Change-Id: I43e5186089d0f40fccdcf9ac85c78f8bda488aac

4 years agoresolve merge conflicts of 88c651eab144bf64acb1d99f11aabe983f23658c to oc-dr1-dev
Evan Laird [Thu, 14 Nov 2019 16:27:07 +0000 (11:27 -0500)]
resolve merge conflicts of 88c651eab144bf64acb1d99f11aabe983f23658c to oc-dr1-dev

Bug: 119041698
Test: atest SystemUITests
Change-Id: I9d1547f98cc19111ce2dc8ab2f4e2bf2d3cb0baa
Merged-In: I0680034ed9315aa2c05282524d48faaed066ebd0

4 years agoMerge "Force FGS notifications to show for a minimum time" into oc-dev
TreeHugger Robot [Fri, 8 Nov 2019 22:30:24 +0000 (22:30 +0000)]
Merge "Force FGS notifications to show for a minimum time" into oc-dev

4 years ago[automerger skipped] Force FGS notifications to show for a minimum time
Evan Laird [Fri, 8 Nov 2019 21:19:35 +0000 (13:19 -0800)]
[automerger skipped] Force FGS notifications to show for a minimum time
am: 3692a6d231 -s ours
am skip reason: change_id I0680034ed9315aa2c05282524d48faaed066ebd0 with SHA1 3b8c4743f6 is in history

Change-Id: I575817ba777d7212391d75a6163c28e75c7ccbc4

4 years agoForce FGS notifications to show for a minimum time
Evan Laird [Wed, 6 Nov 2019 19:04:59 +0000 (14:04 -0500)]
Force FGS notifications to show for a minimum time

It's possible for a service to do a start/stop foreground and cause a
couple of things to happen:

NotificationManagerService will enqueue a EnqueueNotificationRunnable,
post a PostNotificationRunnable (for the startForeground), and then also
enqueue a CancelNotificationRunnable. There is some racy behavior here
in that the cancel runnable can get triggered in between enqueue and
post runnables. If the cancel happens first, then
NotificationListenerServices will never get the message.

This behavior is technically allowed, however for foreground services we
want to ensure that there is a minmum amount of time that notification
listeners are aware of the foreground service so that (for instance) the
FGS notification can be shown.

This CL does two things to mitigate this problem:

1. Introduce checking in the CancelNotificationRunnable such that it
will not cancel until after PostNotificationRunnable has finished
executing.

2. Introduce a NotificationLifetimeExtender method that will allow a
lifetime extender to manage the lifetime of a notification that has been
enqueued but not inflated yet.

Bug: 119041698
Test: atest NotificationManagerServiceTest
Test: atest ForegroundServiceLifetimeExtenderTest
Change-Id: I0680034ed9315aa2c05282524d48faaed066ebd0
Merged-In: I0680034ed9315aa2c05282524d48faaed066ebd0

4 years agoForce FGS notifications to show for a minimum time
Evan Laird [Wed, 6 Nov 2019 19:04:59 +0000 (14:04 -0500)]
Force FGS notifications to show for a minimum time

It's possible for a service to do a start/stop foreground and cause a
couple of things to happen:

NotificationManagerService will enqueue a EnqueueNotificationRunnable,
post a PostNotificationRunnable (for the startForeground), and then also
enqueue a CancelNotificationRunnable. There is some racy behavior here
in that the cancel runnable can get triggered in between enqueue and
post runnables. If the cancel happens first, then
NotificationListenerServices will never get the message.

This behavior is technically allowed, however for foreground services we
want to ensure that there is a minmum amount of time that notification
listeners are aware of the foreground service so that (for instance) the
FGS notification can be shown.

This CL does two things to mitigate this problem:

1. Introduce checking in the CancelNotificationRunnable such that it
will not cancel until after PostNotificationRunnable has finished
executing.

2. Introduce a NotificationLifetimeExtender method that will allow a
lifetime extender to manage the lifetime of a notification that has been
enqueued but not inflated yet.

Bug: 119041698
Test: atest NotificationManagerServiceTest
Test: atest ForegroundServiceLifetimeExtenderTest
Change-Id: I428bc334362f6e4b95f5f0c6974b71f76175c7ae
Merged-In: I0680034ed9315aa2c05282524d48faaed066ebd0

4 years ago[automerger skipped] Merge "DO NOT MERGE Validate wallpaper dimension while generatin...
Ahan Wu [Wed, 6 Nov 2019 09:32:40 +0000 (01:32 -0800)]
[automerger skipped] Merge "DO NOT MERGE Validate wallpaper dimension while generating crop" into oc-dev am: 17fd658061 am: 9c9c1c0f8a
am: 7c50686c92 -s ours
am skip reason: subject contains skip directive

Change-Id: I0c0d041dada006775e7fab48e312d61c3ee5f492

4 years ago[automerger skipped] DO NOT MERGE Validate wallpaper dimension while generating crop...
Ahan Wu [Wed, 6 Nov 2019 09:27:05 +0000 (01:27 -0800)]
[automerger skipped] DO NOT MERGE Validate wallpaper dimension while generating crop am: 160c28c36d am: f4c3460e24
am: 145dcf2c25 -s ours
am skip reason: subject contains skip directive

Change-Id: Id9c033a137dcc5ce774fe864b940a3afa0f65093

4 years agoMerge "DO NOT MERGE Validate wallpaper dimension while generating crop" into oc-dev...
Ahan Wu [Wed, 6 Nov 2019 09:23:55 +0000 (01:23 -0800)]
Merge "DO NOT MERGE Validate wallpaper dimension while generating crop" into oc-dev am: 17fd658061
am: 9c9c1c0f8a

Change-Id: I02286162c176e9edc5962f91c65c993767f83afc

4 years agoDO NOT MERGE Validate wallpaper dimension while generating crop am: 160c28c36d
Ahan Wu [Wed, 6 Nov 2019 09:20:31 +0000 (01:20 -0800)]
DO NOT MERGE Validate wallpaper dimension while generating crop am: 160c28c36d
am: f4c3460e24

Change-Id: I7a866644b805e7e71f188051fb3c7d30c5a8b7fb

4 years agoMerge "DO NOT MERGE Validate wallpaper dimension while generating crop" into oc-dev
Ahan Wu [Wed, 6 Nov 2019 09:08:34 +0000 (01:08 -0800)]
Merge "DO NOT MERGE Validate wallpaper dimension while generating crop" into oc-dev
am: 17fd658061

Change-Id: I5d783568dd734e880b7d5a88117cbfad30c880ef

4 years agoDO NOT MERGE Validate wallpaper dimension while generating crop
Ahan Wu [Wed, 6 Nov 2019 09:08:32 +0000 (01:08 -0800)]
DO NOT MERGE Validate wallpaper dimension while generating crop
am: 160c28c36d

Change-Id: Icee3d103aee1d5775a7d8feeb7a0ac3fc9b7fa26

4 years agoMerge "DO NOT MERGE Validate wallpaper dimension while generating crop" into pi-dev
TreeHugger Robot [Wed, 6 Nov 2019 04:58:32 +0000 (04:58 +0000)]
Merge "DO NOT MERGE Validate wallpaper dimension while generating crop" into pi-dev

4 years agoMerge "DO NOT MERGE Validate wallpaper dimension while generating crop" into oc-dev
TreeHugger Robot [Wed, 6 Nov 2019 04:45:50 +0000 (04:45 +0000)]
Merge "DO NOT MERGE Validate wallpaper dimension while generating crop" into oc-dev

4 years agoMerge "Prevent system uid component from running in an isolated app process" into...
Jing Ji [Wed, 6 Nov 2019 00:32:53 +0000 (16:32 -0800)]
Merge "Prevent system uid component from running in an isolated app process" into oc-dev am: 909ff7dc71 am: 68f3234072
am: 038be975a1

Change-Id: Ib4d8700eb5f5a8275a0a917ef6f6db2a0a3b85de

4 years agoOnly allow INSTALL_ALLOW_TEST from shell or root am: 702d394762 am: 8ff59f6a14
Todd Kennedy [Wed, 6 Nov 2019 00:27:32 +0000 (16:27 -0800)]
Only allow INSTALL_ALLOW_TEST from shell or root am: 702d394762 am: 8ff59f6a14
am: aa1d74e287

Change-Id: If511af964e4705e65e76a9ccb502cddb4f4b0012

4 years agoMerge "Prevent system uid component from running in an isolated app process" into...
Jing Ji [Wed, 6 Nov 2019 00:24:07 +0000 (16:24 -0800)]
Merge "Prevent system uid component from running in an isolated app process" into oc-dev am: 909ff7dc71
am: 68f3234072

Change-Id: I2393d4b5c683892d489398c906790c966a38b36b

4 years agoOnly allow INSTALL_ALLOW_TEST from shell or root am: 702d394762
Todd Kennedy [Wed, 6 Nov 2019 00:20:48 +0000 (16:20 -0800)]
Only allow INSTALL_ALLOW_TEST from shell or root am: 702d394762
am: 8ff59f6a14

Change-Id: I13fc086058cf0f40614bdb5d19cb53211772e628

4 years agoMerge "Prevent system uid component from running in an isolated app process" into...
Jing Ji [Wed, 6 Nov 2019 00:13:50 +0000 (16:13 -0800)]
Merge "Prevent system uid component from running in an isolated app process" into oc-dev
am: 909ff7dc71

Change-Id: Ib725e69bbd84c7e1e141c32c62c5204bd552b12f

4 years agoOnly allow INSTALL_ALLOW_TEST from shell or root
Todd Kennedy [Wed, 6 Nov 2019 00:07:44 +0000 (16:07 -0800)]
Only allow INSTALL_ALLOW_TEST from shell or root
am: 702d394762

Change-Id: I6e19c9738e083ce8863ffd1d9d467cae2f973c37

4 years agoMerge "Prevent system uid component from running in an isolated app process" into...
Jing Ji [Tue, 5 Nov 2019 23:52:53 +0000 (23:52 +0000)]
Merge "Prevent system uid component from running in an isolated app process" into oc-dev

4 years agoPrevent system uid component from running in an isolated app process
Jing Ji [Mon, 4 Nov 2019 22:22:27 +0000 (14:22 -0800)]
Prevent system uid component from running in an isolated app process

Bug: 140055304
Test: Manua
Change-Id: Ie7f6ed23f0c6009aad0f67a00af119b02cdceac3
Merged-In: I5a1618fab529cb0300d4a8e9c7762ee218ca09eb

4 years agoOnly allow INSTALL_ALLOW_TEST from shell or root
Todd Kennedy [Fri, 20 Sep 2019 20:45:15 +0000 (13:45 -0700)]
Only allow INSTALL_ALLOW_TEST from shell or root

Bug: 141169173
Test: Manual. App can't be installed as test-only
Change-Id: Ib6dcca7901aa549d620448c0165c22270a3042be
Merged-In: Ib6dcca7901aa549d620448c0165c22270a3042be

4 years ago[automerger skipped] Merge "RESTRICT AUTOMERGE Revive runLimit check logic" into...
Seigo Nonaka [Thu, 17 Oct 2019 04:07:12 +0000 (21:07 -0700)]
[automerger skipped] Merge "RESTRICT AUTOMERGE Revive runLimit check logic" into oc-mr1-dev
am: 9f7fb87dc4 -s ours
am skip reason: subject contains skip directive

Change-Id: If95365aeca3f84f75f571dcf705f477b01425a0c

4 years agoMerge "RESTRICT AUTOMERGE Revive runLimit check logic" into pi-dev
TreeHugger Robot [Thu, 17 Oct 2019 02:33:30 +0000 (02:33 +0000)]
Merge "RESTRICT AUTOMERGE Revive runLimit check logic" into pi-dev

4 years agoMerge "RESTRICT AUTOMERGE Revive runLimit check logic" into oc-mr1-dev
TreeHugger Robot [Thu, 17 Oct 2019 01:46:22 +0000 (01:46 +0000)]
Merge "RESTRICT AUTOMERGE Revive runLimit check logic" into oc-mr1-dev

4 years ago[automerger skipped] RESTRICT AUTOMERGE Revive runLimit check logic am: b730f1984f...
Seigo Nonaka [Thu, 17 Oct 2019 00:38:11 +0000 (17:38 -0700)]
[automerger skipped] RESTRICT AUTOMERGE Revive runLimit check logic am: b730f1984f am: 2af4f537ff
am: 709e9e6855 -s ours
am skip reason: subject contains skip directive

Change-Id: Ib2c5674e2cf4442fe10d3dd5eb7ae7906e432254

4 years agoRESTRICT AUTOMERGE Revive runLimit check logic am: b730f1984f
Seigo Nonaka [Thu, 17 Oct 2019 00:26:09 +0000 (17:26 -0700)]
RESTRICT AUTOMERGE Revive runLimit check logic am: b730f1984f
am: 2af4f537ff

Change-Id: Ia671d3f5a7fa62c80dd3c2468d199ce66fe734f1

4 years agoRESTRICT AUTOMERGE Revive runLimit check logic
Seigo Nonaka [Thu, 17 Oct 2019 00:14:15 +0000 (17:14 -0700)]
RESTRICT AUTOMERGE Revive runLimit check logic
am: b730f1984f

Change-Id: I329515d36c12ee5e12a63262ff7db8daff350832

4 years agoRESTRICT AUTOMERGE
Seigo Nonaka [Wed, 16 Oct 2019 21:48:30 +0000 (14:48 -0700)]
RESTRICT AUTOMERGE
Revive runLimit check logic

The runLimit check logic was accidentally removed by
I7089ed9b711dddd7de2b27c9c2fa0fb4cb53a735

Bug: 142134328
Bug: 140632678
Test: Manually done with reported step
Test: StaticLayoutTest passes
Change-Id: Ib1d5efdcb9adcc18a6a43370dc016ea464f48148

4 years agoRESTRICT AUTOMERGE
Seigo Nonaka [Wed, 16 Oct 2019 21:48:30 +0000 (14:48 -0700)]
RESTRICT AUTOMERGE
Revive runLimit check logic

The runLimit check logic was accidentally removed by
I7089ed9b711dddd7de2b27c9c2fa0fb4cb53a735

Bug: 142134328
Bug: 140632678
Test: Manually done with reported step
Test: StaticLayoutTest passes
Change-Id: Ib1d5efdcb9adcc18a6a43370dc016ea464f48148

4 years agoRESTRICT AUTOMERGE
Seigo Nonaka [Wed, 16 Oct 2019 21:48:30 +0000 (14:48 -0700)]
RESTRICT AUTOMERGE
Revive runLimit check logic

The runLimit check logic was accidentally removed by
I7089ed9b711dddd7de2b27c9c2fa0fb4cb53a735

Bug: 142134328
Bug: 140632678
Test: Manually done with reported step
Test: StaticLayoutTest passes
Change-Id: Ib1d5efdcb9adcc18a6a43370dc016ea464f48148

4 years agoForce FGS notifications to show for a minimum time
Evan Laird [Fri, 4 Oct 2019 18:18:59 +0000 (14:18 -0400)]
Force FGS notifications to show for a minimum time

It's possible for a service to do a start/stop foreground and cause a
couple of things to happen:

NotificationManagerService will enqueue a EnqueueNotificationRunnable,
post a PostNotificationRunnable (for the startForeground), and then also
enqueue a CancelNotificationRunnable. There is some racy behavior here
in that the cancel runnable can get triggered in between enqueue and
post runnables. If the cancel happens first, then
NotificationListenerServices will never get the message.

This behavior is technically allowed, however for foreground services we
want to ensure that there is a minmum amount of time that notification
listeners are aware of the foreground service so that (for instance) the
FGS notification can be shown.

This CL does two things to mitigate this problem:

1. Introduce checking in the CancelNotificationRunnable such that it
will not cancel until after PostNotificationRunnable has finished
executing.

2. Introduce a NotificationLifetimeExtender method that will allow a
lifetime extender to manage the lifetime of a notification that has been
enqueued but not inflated yet.

Bug: 119041698
Test: atest NotificationManagerServiceTest
Test: atest ForegroundServiceLifetimeExtenderTest
Change-Id: I0680034ed9315aa2c05282524d48faaed066ebd0
Merged-In: I0680034ed9315aa2c05282524d48faaed066ebd0

4 years ago[automerger skipped] RESTRICT AUTOMERGE Do not compute outside given range in TextLin...
Seigo Nonaka [Wed, 2 Oct 2019 17:10:34 +0000 (10:10 -0700)]
[automerger skipped] RESTRICT AUTOMERGE Do not compute outside given range in TextLine am: 4ce901e405 am: b51c7bb175
am: af62f3a7b3 -s ours
am skip reason: subject contains skip directive

Change-Id: Ifb67887f4b1a5860dca2569e57a74911efde801d

4 years agoRESTRICT AUTOMERGE Do not compute outside given range in TextLine am: 4ce901e405
Seigo Nonaka [Wed, 2 Oct 2019 16:59:45 +0000 (09:59 -0700)]
RESTRICT AUTOMERGE Do not compute outside given range in TextLine am: 4ce901e405
am: b51c7bb175

Change-Id: I6770f4b1a884020c374a75f67eb762b2c2bfd538

4 years agoRESTRICT AUTOMERGE Do not compute outside given range in TextLine
Seigo Nonaka [Wed, 2 Oct 2019 16:33:53 +0000 (09:33 -0700)]
RESTRICT AUTOMERGE Do not compute outside given range in TextLine
am: 4ce901e405

Change-Id: I739746d80a8dd29998a67c1d9aaa2d3f804ac57c

4 years agoMerge "RESTRICT AUTOMERGE Do not compute outside given range in TextLine" into pi-dev
Sterling Huber [Wed, 2 Oct 2019 15:51:19 +0000 (15:51 +0000)]
Merge "RESTRICT AUTOMERGE Do not compute outside given range in TextLine" into pi-dev

4 years agoDO NOT MERGE Validate wallpaper dimension while generating crop
Ahan Wu [Thu, 26 Sep 2019 11:00:26 +0000 (19:00 +0800)]
DO NOT MERGE Validate wallpaper dimension while generating crop

If dimensions of cropped wallpaper image exceed max texture size that
GPU can support, it will cause ImageWallpaper keep crashing
because hwui crashes by invalid operation (0x502).

Bug: 120847476.
Test: Write a custom app to set a 8000x800 bitmap as wallpaper.
Test: The cropped file will be 29600x2960 and make sysui keep crashing.
Test: After applyed this cl, wallpaper will use fallback.
Test: Sysui will not keep crashing any more.
Change-Id: Ifaf2085a0bc94448e49fa2f30066f47310586236

4 years agoDO NOT MERGE Validate wallpaper dimension while generating crop
Ahan Wu [Thu, 26 Sep 2019 10:29:59 +0000 (18:29 +0800)]
DO NOT MERGE Validate wallpaper dimension while generating crop

If dimensions of cropped wallpaper image exceed max texture size that
GPU can support, it will cause ImageWallpaper keep crashing
because hwui crashes by invalid operation (0x502).

Bug: 120847476.
Test: Write a custom app to set a 8000x800 bitmap as wallpaper.
Test: The cropped file will be 29600x2960 and make sysui keep crashing.
Test: After applyed this cl, wallpaper will use fallback.
Test: Sysui will not keep crashing any more.
Change-Id: I8ed5931298c652a2230858cf62df3f6fcd345c5a

4 years agoRESTRICT AUTOMERGE
Seigo Nonaka [Mon, 16 Sep 2019 21:49:49 +0000 (14:49 -0700)]
RESTRICT AUTOMERGE
Do not compute outside given range in TextLine

This is second attempt of I646851973b3816bf9ba32dfe26748c0345a5a081
which breaks various layout test on application.
The empty string must be also handled by the TextLine since it
retrieves the default line height from the empty string.

Bug: 140632678
Test: StaticLayoutTest
Test: Manually done
Change-Id: I7089ed9b711dddd7de2b27c9c2fa0fb4cb53a735

4 years agoRESTRICT AUTOMERGE
Seigo Nonaka [Mon, 16 Sep 2019 21:49:49 +0000 (14:49 -0700)]
RESTRICT AUTOMERGE
Do not compute outside given range in TextLine

This is second attempt of I646851973b3816bf9ba32dfe26748c0345a5a081
which breaks various layout test on application.
The empty string must be also handled by the TextLine since it
retrieves the default line height from the empty string.

Bug: 140632678
Test: StaticLayoutTest
Test: Manually done
Change-Id: I7089ed9b711dddd7de2b27c9c2fa0fb4cb53a735

4 years agoMerge "DO NOT MERGE revoke certain app-ops on suspend" into pi-dev
TreeHugger Robot [Sat, 28 Sep 2019 02:15:10 +0000 (02:15 +0000)]
Merge "DO NOT MERGE revoke certain app-ops on suspend" into pi-dev

4 years agoDO NOT MERGE revoke certain app-ops on suspend
Suprabh Shukla [Fri, 13 Sep 2019 00:35:22 +0000 (17:35 -0700)]
DO NOT MERGE revoke certain app-ops on suspend

Revoking an apps authorizations to use camera and record or play audio
while suspended. Appops watchers will also be notified of this change to
re-evaluate privileges at the time of suspension.

Test: atest FrameworksServicesTests:SuspendPackagesTest

Bug: 138636979
Change-Id: Ie95555856afdd56728125f7e60b6a78cf9fc0e58
Merged-In: Ie95555856afdd56728125f7e60b6a78cf9fc0e58
Merged-In: Ic5fb1807deceabfd956b666fa76f8bcc94020ac3

4 years agoMerge changes from topic "bp-135269143-p" into pi-dev
Jeff Sharkey [Thu, 12 Sep 2019 19:59:29 +0000 (19:59 +0000)]
Merge changes from topic "bp-135269143-p" into pi-dev

* changes:
  RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter.
  RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options.

4 years agoRESTRICT AUTOMERGE
Jeff Sharkey [Tue, 16 Jul 2019 22:50:42 +0000 (16:50 -0600)]
RESTRICT AUTOMERGE
Strict SQLiteQueryBuilder needs to be stricter.

Malicious callers can leak side-channel information by using
subqueries in any untrusted inputs where SQLite allows "expr" values.

This change offers setStrictGrammar() to prevent this by outright
blocking subqueries in WHERE and HAVING clauses, and by requiring
that GROUP BY and ORDER BY clauses be composed only of valid columns.

This change also offers setStrictColumns() to require that all
untrusted column names are valid, such as those in ContentValues.

Relaxes to always allow aggregation operators on returned columns,
since untrusted callers can always calculate these manually.

Bug: 135270103
Bug: 135269143
Test: atest android.database.sqlite.cts.SQLiteQueryBuilderTest
Test: atest FrameworksCoreTests:android.database.sqlite.SQLiteTokenizerTest
Exempt-From-Owner-Approval: already approved in downstream branch
Change-Id: I6290afd19c966a8bdca71c377c88210d921a9f25

4 years ago[automerger skipped] Merge "RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder...
Jeff Sharkey [Thu, 12 Sep 2019 17:31:54 +0000 (10:31 -0700)]
[automerger skipped] Merge "RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options." into oc-dev am: f8a2d069b4 am: f6aa7b8d8f
am: 8acb456949 -s ours
am skip reason: subject contains skip directive

Change-Id: Id9934307cef63a331bb1fad3ba4fddee11393d98

4 years ago[automerger skipped] RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options...
Jeff Sharkey [Thu, 12 Sep 2019 17:31:49 +0000 (10:31 -0700)]
[automerger skipped] RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options. am: f683c688d5 am: fc095efde0
am: e89348b54b -s ours
am skip reason: subject contains skip directive

Change-Id: I80528a71e90049489b85b5c95baf93cbd3a17808

4 years ago[automerger skipped] Merge "RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to...
Jeff Sharkey [Thu, 12 Sep 2019 17:27:55 +0000 (10:27 -0700)]
[automerger skipped] Merge "RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter." into oc-dev am: 7633a081ab am: b0054f0518
am: c97dfb57a8 -s ours
am skip reason: subject contains skip directive

Change-Id: I6467326680d2164bb4e2a9e54dc22cc490e2492d

4 years ago[automerger skipped] RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricte...
Jeff Sharkey [Thu, 12 Sep 2019 17:27:37 +0000 (10:27 -0700)]
[automerger skipped] RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter. am: 92e5e5e45c am: 37e2229257
am: bba6744ff4 -s ours
am skip reason: subject contains skip directive

Change-Id: I8711dac1ad4d2512d64dc489d87ffd4a18c0ebd6

4 years agoMerge "RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options." into oc-dev...
Jeff Sharkey [Thu, 12 Sep 2019 17:18:26 +0000 (10:18 -0700)]
Merge "RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options." into oc-dev am: f8a2d069b4
am: f6aa7b8d8f

Change-Id: I466630af8385d6da164196f2420d040b2aa6e2ac

4 years agoRESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options. am: f683c688d5
Jeff Sharkey [Thu, 12 Sep 2019 17:18:22 +0000 (10:18 -0700)]
RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options. am: f683c688d5
am: fc095efde0

Change-Id: I9bbeb106c1abe977439420d8005f33f5a7c1eaa1

4 years agoMerge "RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter." into oc...
Jeff Sharkey [Thu, 12 Sep 2019 17:14:15 +0000 (10:14 -0700)]
Merge "RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter." into oc-dev am: 7633a081ab
am: b0054f0518

Change-Id: I491c415de567d0375296f293fcbb35ee21413ce6

4 years agoRESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter. am: 92e5e5e45c
Jeff Sharkey [Thu, 12 Sep 2019 17:14:00 +0000 (10:14 -0700)]
RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter. am: 92e5e5e45c
am: 37e2229257

Change-Id: I3d7696be9733e40f31c160a77505c4e96ca05b5e

4 years agoMerge "RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options." into oc-dev
Jeff Sharkey [Thu, 12 Sep 2019 17:06:14 +0000 (10:06 -0700)]
Merge "RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options." into oc-dev
am: f8a2d069b4

Change-Id: If9534450fac2cd9b328f105be73f53c92ab14dbd

4 years agoRESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options.
Jeff Sharkey [Thu, 12 Sep 2019 17:06:09 +0000 (10:06 -0700)]
RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options.
am: f683c688d5

Change-Id: I64ae89ecc92127de21503fbcfdd34c60a6f620bc

4 years agoMerge "RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter." into oc-dev
Jeff Sharkey [Thu, 12 Sep 2019 17:02:13 +0000 (10:02 -0700)]
Merge "RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter." into oc-dev
am: 7633a081ab

Change-Id: Ia3853da8933c8c21fe06acad79059a3589eeb835

4 years agoRESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter.
Jeff Sharkey [Thu, 12 Sep 2019 17:02:05 +0000 (10:02 -0700)]
RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter.
am: 92e5e5e45c

Change-Id: I2e0a5c5cd35f9abcf362d3db4514e1bbd6bd7035

4 years agoMerge "RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options." into oc-dev
Jeff Sharkey [Thu, 12 Sep 2019 16:33:21 +0000 (16:33 +0000)]
Merge "RESTRICT AUTOMERGE Enable stricter SQLiteQueryBuilder options." into oc-dev

4 years agoMerge "RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter." into oc-dev
Jeff Sharkey [Thu, 12 Sep 2019 16:33:13 +0000 (16:33 +0000)]
Merge "RESTRICT AUTOMERGE Strict SQLiteQueryBuilder needs to be stricter." into oc-dev

4 years agoRESTRICT AUTOMERGE
Jeff Sharkey [Thu, 18 Jul 2019 00:51:28 +0000 (18:51 -0600)]
RESTRICT AUTOMERGE
Enable stricter SQLiteQueryBuilder options.

Malicious callers can leak side-channel information by using
subqueries in any untrusted inputs where SQLite allows "expr" values.

This change starts using setStrictColumns() and setStrictGrammar()
on SQLiteQueryBuilder to block this class of attacks.  This means we
now need to define the projection mapping of valid columns, which
consists of both the columns defined in the public API and columns
read internally by DownloadInfo.Reader.

We're okay growing sAppReadableColumnsSet like this, since we're
relying on our trusted WHERE clause to filter away any rows that
don't belong to the calling UID.

Remove the legacy Lexer code, since we're now internally relying on
the robust and well-tested SQLiteTokenizer logic.

Bug: 135270103135269143
Test: cts-tradefed run cts -m CtsAppTestCases -t android.app.cts.DownloadManagerTest
Change-Id: Iec1e8ce18dc4a9564318e0473d9d3863c8c2988a

4 years ago[automerger skipped] Set default phonebook access to ACCESS_REJECTED when user didn...
Zongheng Wang [Wed, 11 Sep 2019 01:41:23 +0000 (18:41 -0700)]
[automerger skipped] Set default phonebook access to ACCESS_REJECTED when user didn't choose one am: 1f9309bd11 am: a376239229 -s ours
am: aee078eae7 -s ours
am skip reason: change_id Iefabeb731b941f09fe1272ac7b7cd2feba75c8df with SHA1 9b3cb0f06b is in history

Change-Id: Ifb20decfdf6a48b599931f87a733e97013538888

4 years ago[automerger skipped] Set default phonebook access to ACCESS_REJECTED when user didn...
Zongheng Wang [Wed, 11 Sep 2019 01:30:55 +0000 (18:30 -0700)]
[automerger skipped] Set default phonebook access to ACCESS_REJECTED when user didn't choose one am: 1f9309bd11
am: a376239229 -s ours
am skip reason: change_id Iefabeb731b941f09fe1272ac7b7cd2feba75c8df with SHA1 02046b4f2c is in history

Change-Id: I3cc4d873250f924af768b37e97338024ee236e6e

4 years ago[automerger skipped] Set default phonebook access to ACCESS_REJECTED when user didn...
Zongheng Wang [Wed, 11 Sep 2019 01:20:49 +0000 (18:20 -0700)]
[automerger skipped] Set default phonebook access to ACCESS_REJECTED when user didn't choose one
am: 02046b4f2c -s ours
am skip reason: change_id Iefabeb731b941f09fe1272ac7b7cd2feba75c8df with SHA1 9b3cb0f06b is in history

Change-Id: I6003b908b417a8bb1d687b5eafe2f2646f63e814

4 years agoSet default phonebook access to ACCESS_REJECTED when user didn't choose one
Zongheng Wang [Wed, 11 Sep 2019 01:16:49 +0000 (18:16 -0700)]
Set default phonebook access to ACCESS_REJECTED when user didn't choose one
am: 1f9309bd11

Change-Id: I142d2737f6444b5148963c1ca7af84e8cf0eded3

4 years agoMerge "Set default phonebook access to ACCESS_REJECTED when user didn't choose one...
TreeHugger Robot [Wed, 11 Sep 2019 00:46:54 +0000 (00:46 +0000)]
Merge "Set default phonebook access to ACCESS_REJECTED when user didn't choose one" into pi-dev

4 years agoRESTRICT AUTOMERGE
Jeff Sharkey [Tue, 16 Jul 2019 22:50:42 +0000 (16:50 -0600)]
RESTRICT AUTOMERGE
Strict SQLiteQueryBuilder needs to be stricter.

Malicious callers can leak side-channel information by using
subqueries in any untrusted inputs where SQLite allows "expr" values.

This change offers setStrictGrammar() to prevent this by outright
blocking subqueries in WHERE and HAVING clauses, and by requiring
that GROUP BY and ORDER BY clauses be composed only of valid columns.

This change also offers setStrictColumns() to require that all
untrusted column names are valid, such as those in ContentValues.

Relaxes to always allow aggregation operators on returned columns,
since untrusted callers can always calculate these manually.

Bug: 135270103135269143
Test: cts-tradefed run cts -m CtsDatabaseTestCases -t android.database.sqlite.cts.SQLiteQueryBuilderTest
Change-Id: I6290afd19c966a8bdca71c377c88210d921a9f25

4 years agoSet default phonebook access to ACCESS_REJECTED when user didn't choose
Zongheng Wang [Thu, 5 Sep 2019 20:44:28 +0000 (13:44 -0700)]
Set default phonebook access to ACCESS_REJECTED when user didn't choose
one

When there's no users' choice to tell us whether to share their
phonebook information to the Bluetooth device, set the phonebook access
permission to ACCESS_REJECTED.

Bug: 138529441
Test: Manual test
Change-Id: Iefabeb731b941f09fe1272ac7b7cd2feba75c8df
Merged-In: Iefabeb731b941f09fe1272ac7b7cd2feba75c8df

4 years agoSet default phonebook access to ACCESS_REJECTED when user didn't choose
Zongheng Wang [Thu, 5 Sep 2019 20:44:28 +0000 (13:44 -0700)]
Set default phonebook access to ACCESS_REJECTED when user didn't choose
one

When there's no users' choice to tell us whether to share their
phonebook information to the Bluetooth device, set the phonebook access
permission to ACCESS_REJECTED.

Bug: 138529441
Test: Manual test
Change-Id: Iefabeb731b941f09fe1272ac7b7cd2feba75c8df
Merged-In: Iefabeb731b941f09fe1272ac7b7cd2feba75c8df

4 years agoSet default phonebook access to ACCESS_REJECTED when user didn't choose
Zongheng Wang [Thu, 5 Sep 2019 20:44:28 +0000 (13:44 -0700)]
Set default phonebook access to ACCESS_REJECTED when user didn't choose
one

When there's no users' choice to tell us whether to share their
phonebook information to the Bluetooth device, set the phonebook access
permission to ACCESS_REJECTED.

Bug: 138529441
Test: Manual test
Change-Id: Iefabeb731b941f09fe1272ac7b7cd2feba75c8df
Merged-In: Iefabeb731b941f09fe1272ac7b7cd2feba75c8df

4 years ago[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d...
Jonathan Scott [Mon, 9 Sep 2019 19:50:26 +0000 (12:50 -0700)]
[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d6e8e am: 80e1c4fd36 am: 7b6a04fceb am: 743846742d am: 0b1d526f50 am: e4ddc22035
am: 5f619835ed

Change-Id: Ie2c9fb05e3245f3045f3c9a4919760e70285fa37

4 years ago[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d...
Jonathan Scott [Mon, 9 Sep 2019 19:35:53 +0000 (12:35 -0700)]
[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d6e8e am: 80e1c4fd36 am: 7b6a04fceb am: 743846742d am: 0b1d526f50
am: e4ddc22035

Change-Id: I4084d344b3c92b5a4459852837e323f44d2b0b72

4 years ago[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d...
Jonathan Scott [Mon, 9 Sep 2019 19:20:54 +0000 (12:20 -0700)]
[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d6e8e am: 80e1c4fd36 am: 7b6a04fceb am: 743846742d
am: 0b1d526f50

Change-Id: Ie3f10bbed4bdb2bb7e141d7bb8d34e0b818c3f30

4 years ago[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d...
Android Build Merger (Role) [Mon, 9 Sep 2019 16:55:54 +0000 (16:55 +0000)]
[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d6e8e am: 80e1c4fd36 am: 7b6a04fceb am: 743846742d

Change-Id: Ia84a02b1b3ff3e9f4849554c6b2f0e904daadd05

4 years ago[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d...
Android Build Merger (Role) [Mon, 9 Sep 2019 16:55:50 +0000 (16:55 +0000)]
[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d6e8e am: 80e1c4fd36 am: 7b6a04fceb

Change-Id: I8914a6337a6e6c905b42cc498f34db5142db7a1a

4 years ago[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d...
Android Build Merger (Role) [Mon, 9 Sep 2019 16:55:45 +0000 (16:55 +0000)]
[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d6e8e am: 80e1c4fd36

Change-Id: I6ef1648f805c48ef37c8921ddfa1d147a8e5e032

4 years ago[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d6e8e
Android Build Merger (Role) [Mon, 9 Sep 2019 16:55:42 +0000 (16:55 +0000)]
[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613 am: c1ec4d6e8e

Change-Id: I641d14a61338365b5da7f6c55ead2baff29e811c

4 years ago[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613
Android Build Merger (Role) [Mon, 9 Sep 2019 16:55:35 +0000 (16:55 +0000)]
[automerger] Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc). am: 20e5d92613

Change-Id: I6b5ad877382a352cb5b4bcdd05a2d19da502945a

4 years agoRESTRICT AUTOMERGE
Jeff Sharkey [Thu, 18 Jul 2019 00:51:28 +0000 (18:51 -0600)]
RESTRICT AUTOMERGE
Enable stricter SQLiteQueryBuilder options.

Malicious callers can leak side-channel information by using
subqueries in any untrusted inputs where SQLite allows "expr" values.

This change starts using setStrictColumns() and setStrictGrammar()
on SQLiteQueryBuilder to block this class of attacks.  This means we
now need to define the projection mapping of valid columns, which
consists of both the columns defined in the public API and columns
read internally by DownloadInfo.Reader.

We're okay growing sAppReadableColumnsSet like this, since we're
relying on our trusted WHERE clause to filter away any rows that
don't belong to the calling UID.

Remove the legacy Lexer code, since we're now internally relying on
the robust and well-tested SQLiteTokenizer logic.

Bug: 135270103
Bug: 135269143
Test: atest DownloadProviderTests
Test: atest CtsAppTestCases:android.app.cts.DownloadManagerTest
Change-Id: Iec1e8ce18dc4a9564318e0473d9d3863c8c2988a

5 years agofixes a security vulnerability in slice provider
Pinyao Ting [Thu, 8 Aug 2019 22:35:20 +0000 (15:35 -0700)]
fixes a security vulnerability in slice provider

Bug: 138441555
Test: Manual
Change-Id: Ib1b4fba54ebd3599fe11021d21dc9b09d34e8965
Merged-In: Ib1b4fba54ebd3599fe11021d21dc9b09d34e8965
(cherry picked from commit 2b415a4c4465a6294e51ad1a8fcf2e6c1497853b)

5 years agoAdd MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc).
Jonathan Scott [Tue, 25 Jun 2019 09:58:06 +0000 (10:58 +0100)]
Add MANAGED_PROVISIONING_DPC_DOWNLOADED (nyc).

Test: Just adding a constant
Bug: 132261064
Change-Id: I1527be03a10fa1a2fde09e3e41d6b7e83a986fc0
Merged-In: I2bce277ff8f2de4614e19d5385fe6712b076f9c9

5 years agoDO NOT MERGE: Disable SpellChecker in secondary user's direct reply
Tarandeep Singh [Mon, 1 Jul 2019 21:27:25 +0000 (14:27 -0700)]
DO NOT MERGE: Disable SpellChecker in secondary user's direct reply

For secondary users, when AOSP keyboard is used to type in
direct-reply, unknown words can be added to dictionary.
It's *not* OK for SpellCheckerService of primary user to
check unknown words typed by a secondary user.
The dialog to add these words shows up in primary user instead.

TextView uses TextView#isSuggestionsEnabled() to determine if
SpellChecker is enabled. This can be disabled by setting the flag
TYPE_TEXT_FLAG_NO_SUGGESTIONS in inputType.

Note: This doesn't affect workprofile users on P or older versions since
they use same SpellCheckerService for all workprofiles.

Bug: 123232892
Test: Manually tested using the steps mentioned in the bug.
 1. Flash latest P build.
 2. Install AOSP keyboard (LatinIME) and set it as default.
 3. Install and open EditTextVariations
 4. Initiate direct reply in primary user and type non-english
    words like "ggggg hhhhh".
 5. Observe that they get red underline and tapping it brings "add
    to dictionary" popup.
 6. Create a new secondary user and switch to it.
 7. Once the setup completes, initiate a direct reply and type words
    similar to step 4.
 8. Verify that red underlines dont appear.
 9. switch back to primary user and verify direct reply still has red
    underlines.

Change-Id: I93918eb2c12e37908e03a7951a9e2c5375bc0ecc

5 years agoMerge changes from topic "am-491d8213-3eca-4563-937d-c6f23dd5f887" into oc-dev am...
Bryan Ferris [Thu, 11 Jul 2019 00:41:49 +0000 (17:41 -0700)]
Merge changes from topic "am-491d8213-3eca-4563-937d-c6f23dd5f887" into oc-dev am: 4244190788 am: 61ea78238e
am: 61581686b6

Change-Id: I528351af6ed11b2cd486f9fee42ad09b69cd8d56

5 years agoMerge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into oc-dev am: 8abe600b81...
Bryan Ferris [Thu, 11 Jul 2019 00:28:45 +0000 (17:28 -0700)]
Merge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into oc-dev am: 8abe600b81 am: 4fea890c18
am: f97b567234

Change-Id: I3e7a09fa3e1568696b129d28298bbf2836d1d718

5 years agoMerge changes from topic "am-491d8213-3eca-4563-937d-c6f23dd5f887" into oc-dev am...
Bryan Ferris [Thu, 11 Jul 2019 00:28:34 +0000 (17:28 -0700)]
Merge changes from topic "am-491d8213-3eca-4563-937d-c6f23dd5f887" into oc-dev am: 4244190788
am: 61ea78238e

Change-Id: I0b4af47df7862451ba65246b232459d37441c837

5 years agoMerge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into oc-dev am: 8abe600b81
Bryan Ferris [Thu, 11 Jul 2019 00:19:27 +0000 (17:19 -0700)]
Merge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into oc-dev am: 8abe600b81
am: 4fea890c18

Change-Id: Ie296e5c7186739812d8ea2a1bc4806da5e92563a

5 years agoMerge changes from topic "am-491d8213-3eca-4563-937d-c6f23dd5f887" into oc-dev
Bryan Ferris [Thu, 11 Jul 2019 00:13:54 +0000 (17:13 -0700)]
Merge changes from topic "am-491d8213-3eca-4563-937d-c6f23dd5f887" into oc-dev
am: 4244190788

Change-Id: Id4563c2be11b532bdbd1b504b4a83734eed58708

5 years agoMerge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into oc-dev
Bryan Ferris [Wed, 10 Jul 2019 23:52:52 +0000 (16:52 -0700)]
Merge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into oc-dev
am: 8abe600b81

Change-Id: I6a8ddfc1c5fb771194f9b7d6c5eb335b0ddc70c0

5 years agoMerge changes from topic "am-491d8213-3eca-4563-937d-c6f23dd5f887" into oc-dev
Bryan Ferris [Wed, 10 Jul 2019 23:39:53 +0000 (23:39 +0000)]
Merge changes from topic "am-491d8213-3eca-4563-937d-c6f23dd5f887" into oc-dev

* changes:
  [automerger] Fix Layout.primaryIsTrailingPreviousAllLineOffsets am: d3e81cd63f
  Fix Layout.primaryIsTrailingPreviousAllLineOffsets

5 years agoMerge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into nyc-mr2-dev
Bryan Ferris [Wed, 10 Jul 2019 23:39:53 +0000 (23:39 +0000)]
Merge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into nyc-mr2-dev

5 years agoMerge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into oc-dev
Bryan Ferris [Wed, 10 Jul 2019 23:11:15 +0000 (23:11 +0000)]
Merge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into oc-dev

5 years agoMerge changes from topic "am-8d44d2e5-2b24-4867-a4fc-1c5b430ac3a0" into oc-dev am...
Bryan Ferris [Wed, 10 Jul 2019 22:33:21 +0000 (15:33 -0700)]
Merge changes from topic "am-8d44d2e5-2b24-4867-a4fc-1c5b430ac3a0" into oc-dev am: ecc48fbc96 am: f56e704fb5
am: cbac93ac65

Change-Id: I2067316d6788061b74bd411c83ed5a60f70c3128

5 years ago[automerger] Fix Layout.primaryIsTrailingPreviousAllLineOffsets am: 2778b1e49d am...
Mihai Popa [Wed, 10 Jul 2019 22:29:42 +0000 (15:29 -0700)]
[automerger] Fix Layout.primaryIsTrailingPreviousAllLineOffsets am: 2778b1e49d am: 77b7393e7d am: 126189263d am: 29534f6c57 am: 09bfff78dd
am: 36e9a7af7f

Change-Id: Iead8dd8c3e4a0e675a86767bae54c2ddd599e65a