OSDN Git Service
Andy Hung [Wed, 21 Sep 2016 19:55:15 +0000 (12:55 -0700)]
Add logging of written frame counts
Bug:
31591209
Change-Id: Ife5917aa65b02c3b0791dfe1975c70ccf58f9a75
(cherry picked from commit
2c45393d842a5d2968ef78fa7a08667efdf15f2a)
Treehugger Robot [Thu, 20 Oct 2016 05:44:33 +0000 (05:44 +0000)]
Merge "AudioFlinger: Account for frames dropped in suspend mode"
Andy Hung [Thu, 28 Jul 2016 17:53:22 +0000 (10:53 -0700)]
AudioFlinger: Account for frames dropped in suspend mode
These frames must be added to the kernel position in timestamps.
Bug:
30025777
Change-Id: I30c14503c9467059c3782e5c96c01ae1cf3709f6
(cherry picked from commit
238fa3deff26d7e4d9e81bd0a88c936f16226c4e)
Caroline Tice [Wed, 19 Oct 2016 17:34:28 +0000 (17:34 +0000)]
Merge "Fix potental memory leak (compiler warning)."
Caroline Tice [Tue, 18 Oct 2016 23:32:13 +0000 (16:32 -0700)]
Fix potental memory leak (compiler warning).
This CL fixes the following warning:
EffectProxy.cpp:93:8: warning: Potential leak of memory pointed to by
'pContext'.
BUG=None
Test: WITH_TIDY=1 WITH_STATIC_ANLYZER=1 mm
Change-Id: I7f127042eb50d3d6297473bfd90a5402b182cc85
Treehugger Robot [Tue, 18 Oct 2016 17:26:47 +0000 (17:26 +0000)]
Merge "WAVExtractor: support ambisonic subformat"
Marco Nelissen [Fri, 14 Oct 2016 14:49:24 +0000 (14:49 +0000)]
Merge "Fix issues with metadata handling when format change happens"
Treehugger Robot [Wed, 12 Oct 2016 21:03:50 +0000 (21:03 +0000)]
Merge "Fix dereference null pointer warning."
Yunlian Jiang [Wed, 12 Oct 2016 19:05:54 +0000 (12:05 -0700)]
Fix dereference null pointer warning.
This fixes
warning: Access to field 'region' results in a dereference of a
null pointer (loaded from variable 'config')
Test: The warning is gone.
Change-Id: Iac531e879a6768d8638e77fc03dadb08481c486a
Treehugger Robot [Mon, 10 Oct 2016 23:31:40 +0000 (23:31 +0000)]
Merge "Rely on the platform -std default."
Elliott Hughes [Fri, 7 Oct 2016 22:50:21 +0000 (15:50 -0700)]
Rely on the platform -std default.
Bug: http://b/
32019064
Test: builds
Change-Id: I535e2fb041cf11c3c4eeaf3367c54072e9208ebe
Roger1 Jonsson [Tue, 6 Sep 2016 06:51:46 +0000 (08:51 +0200)]
Fix issues with metadata handling when format change happens
When a video format changes, the discontinuity will clear the ATSParser
queue and format. This means that AnotherPacketSource::getFormat() will
return NULL until a new format is found. The discontinuity casues the
decoder to be shutdown and NuPlayer will start scanning sources.
But since ESQueue has not yet found any format, the call to the
StreamingSource::getFormat() will return an error (BAD_VALUE) since the
convertMetaDataToMessage() fails upon NULL input.
This error code causes the scanning of sources to stop which means that
the video will be stoped.
Instead returning -EWOULDBLOCK while waiting for a new format will keep
the scanning of source.
Bug:
32007921
Test: Manual - Install SVT Play app, start live streaming
Change-Id: Ia237825361755bc63ba34b7089e7804c187fafd8
Treehugger Robot [Wed, 5 Oct 2016 21:21:40 +0000 (21:21 +0000)]
Merge "Convert to Android.bp"
Dan Willemsen [Tue, 4 Oct 2016 07:14:41 +0000 (00:14 -0700)]
Convert to Android.bp
See build/soong/README.md for more information.
Test: mmma -j frameworks/av/media/libnbaio
Change-Id: Ifd5f13ad6ab1c9590623c3b58adea5ef3ea6af60
Merged-In: Ifd5f13ad6ab1c9590623c3b58adea5ef3ea6af60
Treehugger Robot [Wed, 5 Oct 2016 16:50:34 +0000 (16:50 +0000)]
Merge "Convert to Android.bp"
Dan Willemsen [Wed, 5 Oct 2016 02:58:25 +0000 (19:58 -0700)]
Convert to Android.bp
See build/soong/README.md for more information
Test: mmma -j frameworks/av
Change-Id: I1b8deeec65e2cfa1633354712004ef87f3ac8b3e
Jeffrey Vander Stoep [Mon, 3 Oct 2016 21:54:42 +0000 (21:54 +0000)]
Merge "mediaextractor: Skip setting memory limits on ASan builds"
Jeff Vander Stoep [Sun, 2 Oct 2016 03:26:51 +0000 (20:26 -0700)]
mediaextractor: Skip setting memory limits on ASan builds
ASan-ified libraries have a larger memory footprint which counts
towards a process's RLIMIT_AS. Detect ASan at runtime and skip
setting memory limits.
Test: Builds and boots. "MediaUtils: running with ASan, not setting
memory limits" appears in logcat, mediaextractor is no longer
crashing.
(cherry picked from commit
4bc7ad9e0ea04928e7ed9767251696cc4a4e5d15)
Bug:
31831213
Change-Id: I6705baa825cbfd45695def2cd80d8d2261b05339
Colin Cross [Sat, 1 Oct 2016 00:23:08 +0000 (00:23 +0000)]
Merge "Fix struct vs. class mismatch in forward definitions"
Colin Cross [Fri, 30 Sep 2016 23:30:24 +0000 (23:30 +0000)]
Merge "Rename dump methods to dumpState"
Treehugger Robot [Thu, 29 Sep 2016 19:30:43 +0000 (19:30 +0000)]
Merge "Prevent crash for malformed ID3 COMM frame"
Roger1 Jonsson [Wed, 21 Sep 2016 07:06:34 +0000 (09:06 +0200)]
Prevent crash for malformed ID3 COMM frame
When trying to retrieve the full text string from a malformed
ID3 COMM frame, there is a risk of getting a negative index
value if the size of the frame is too small.
Adding a size check to avoid negative indexes.
Bug:
31815576
Test: Playback content with malformed ID3 COMM frame
Change-Id: I21253e104cd76a65f5ab5d03f58490e0f4a4cb65
Colin Cross [Wed, 28 Sep 2016 19:34:05 +0000 (12:34 -0700)]
Fix struct vs. class mismatch in forward definitions
The warnings were being hidden by the use of -isystem to include
frameworks/native/include.
Bug:
31752268
Test: m -j
Change-Id: I0eea5b59e7bd696d9aff44c8680361c99474e634
Colin Cross [Wed, 28 Sep 2016 01:10:24 +0000 (18:10 -0700)]
Rename dump methods to dumpState
The dump methods shadow the IBinder dump method. The warnings were being
hidden by the use of -isystem to include frameworks/native/include.
Bug:
31752268
Test: m -j
Change-Id: I78136a4baf71630455010e884bc198314cecca7a
Treehugger Robot [Tue, 27 Sep 2016 20:50:25 +0000 (20:50 +0000)]
Merge "Migrate libmediandk to ndk_library."
Treehugger Robot [Mon, 26 Sep 2016 20:30:07 +0000 (20:30 +0000)]
Merge "libeffects: fix enum conversion warnings."
George Burgess IV [Mon, 26 Sep 2016 18:15:48 +0000 (11:15 -0700)]
libeffects: fix enum conversion warnings.
warning: implicit conversion from enumeration type 'LVDBE_Fs_en' to
different enumeration type 'LVM_Fs_en' [-Wenum-conversion]
Thanks to Luis Lozano for the patch!
BUG: None
Test: Compiles without warnings.
Change-Id: I5bb0b5fc2e4e23080f61a209ab0ea95f423bafb1
Treehugger Robot [Sat, 24 Sep 2016 23:54:40 +0000 (23:54 +0000)]
Merge "Add missing liblog dependency"
Dimitry Ivanov [Sat, 24 Sep 2016 00:15:38 +0000 (17:15 -0700)]
Add missing liblog dependency
Bug: http://b/
31289077
Bug: http://b/
27171986
Test: remove liblog from libcutils and recompile
Change-Id: Ic2e8a3d9e62d778d32863a4b794dc4c80b1b1b2b
Dan Albert [Fri, 23 Sep 2016 23:17:45 +0000 (16:17 -0700)]
Migrate libmediandk to ndk_library.
Test: make native
Bug: http://b/
30465923
Change-Id: Id62eac2d5cc518465445d87ce204fa918f0ddb68
Treehugger Robot [Thu, 22 Sep 2016 18:16:37 +0000 (18:16 +0000)]
Merge "IMediaSource: Pack alignment of ReadOption struct"
Dan Liang [Wed, 14 Sep 2016 23:31:47 +0000 (16:31 -0700)]
IMediaSource: Pack alignment of ReadOption struct
int64_t aligns differently in x86 vs x64, which presents
problems when communicating across Binder.
Use packed struct to avoid problems.
Bug:
30472583
Change-Id: Iacdad792e19c19899cde5289238b5aa8981a9a7a
Treehugger Robot [Tue, 20 Sep 2016 20:30:09 +0000 (20:30 +0000)]
Merge "Migrate libcamera2ndk to ndk_library."
Treehugger Robot [Mon, 19 Sep 2016 23:00:09 +0000 (23:00 +0000)]
Merge "Fix build when #define LOG_NDEBUG 0"
Marco Nelissen [Mon, 19 Sep 2016 20:33:24 +0000 (20:33 +0000)]
Merge "stagefright: fix finding hardware codec"
Tobias Melin [Fri, 16 Sep 2016 08:04:26 +0000 (10:04 +0200)]
Fix build when #define LOG_NDEBUG 0
A few variables have changed type and when building with LOG_NDEBUG 0
the code no longer compile. Adjust the ALOG_ASSERT strings to use the
correct types.
Test: make with LOG_NDEBUG enabled
Bug:
31584070
Change-Id: Ib47f369f8be9fa0c12fa4f69c294a719df8ad018
Treehugger Robot [Fri, 16 Sep 2016 23:08:06 +0000 (23:08 +0000)]
Merge "Remove incorrect forward declaration"
Colin Cross [Fri, 16 Sep 2016 20:02:22 +0000 (13:02 -0700)]
Remove incorrect forward declaration
ANativeWindow is a struct, not a class, and the incorrect forward
declaration causes a warning when -isystem is removed from
system/core/include.
Test: m -j native
Bug:
31492149
Change-Id: I3516aa98defe1944a9776c07f52f4ee580366988
Treehugger Robot [Fri, 16 Sep 2016 08:35:05 +0000 (08:35 +0000)]
Merge "Stop including libcore/include/ in frameworks/av."
Dan Albert [Wed, 14 Sep 2016 19:35:50 +0000 (12:35 -0700)]
Migrate libcamera2ndk to ndk_library.
Test: make checkbuild tests
Bug: http://b/
30465923
Change-Id: Iab800fd20beeef64250abc7d1c966d12fa8bfbb5
Treehugger Robot [Thu, 15 Sep 2016 21:49:42 +0000 (21:49 +0000)]
Merge "media: Fix graphic buffer leak."
Chih-Hung Hsieh [Thu, 15 Sep 2016 20:54:21 +0000 (13:54 -0700)]
media: Fix graphic buffer leak.
Bug:
30882996
Test: build and boot
Change-Id: I673c06b225f55f0d9f15800edb8113abc237c4ce
Merged-In: I571a3a9d1705233029abb92f3752416d55ed1056
Elliott Hughes [Thu, 15 Sep 2016 20:04:22 +0000 (13:04 -0700)]
Stop including libcore/include/ in frameworks/av.
Change-Id: I7c0ffa84071c2080b5bfe2ce9ad7e1822fe863c7
Treehugger Robot [Tue, 13 Sep 2016 02:08:50 +0000 (02:08 +0000)]
Merge "Remove unnecessary pathmap usage"
Dan Willemsen [Mon, 12 Sep 2016 23:21:27 +0000 (16:21 -0700)]
Remove unnecessary pathmap usage
speex is being removed by the pathmap because libspeexresampler already
exports that include dir automatically if you link against it.
Test: mma
Change-Id: If3d07234696cd24ff0060d829f55d9d50a3df849
Chih-hung Hsieh [Mon, 12 Sep 2016 18:50:46 +0000 (18:50 +0000)]
Merge "Fix google-explicit-constructor warnings in camera."
Chih-hung Hsieh [Sat, 10 Sep 2016 17:08:12 +0000 (17:08 +0000)]
Merge "Fix google-explicit-constructor warnings in audioflinger, audiopolicy."
Chih-hung Hsieh [Sat, 10 Sep 2016 17:08:04 +0000 (17:08 +0000)]
Merge "Fix google-explicit-constructor warnings in media."
Jean-Michel Trivi [Fri, 2 Sep 2016 01:06:02 +0000 (01:06 +0000)]
Merge "Use symbolic name for return value in legacy audio policy client"
Dan Willemsen [Mon, 29 Aug 2016 23:25:57 +0000 (23:25 +0000)]
Merge "Convert to Android.bp"
Chih-Hung Hsieh [Mon, 29 Aug 2016 21:22:17 +0000 (14:22 -0700)]
Fix google-explicit-constructor warnings in media.
* Add explicit keyword to conversion constructors.
Bug:
28341362
Test: build with WITH_TIDY=1
Change-Id: I141b22bcb3caf386400b6b0403d1b231a8e7e6c4
Chih-Hung Hsieh [Mon, 29 Aug 2016 21:21:14 +0000 (14:21 -0700)]
Fix google-explicit-constructor warnings in camera.
* Add explicit keyword to conversion constructors.
Bug:
28341362
Test: build with WITH_TIDY=1
Change-Id: I61f9b5b2b6e13e0c6561327bc8dfe69c9cfc5ba5
Chih-Hung Hsieh [Mon, 29 Aug 2016 21:18:27 +0000 (14:18 -0700)]
Fix google-explicit-constructor warnings in audioflinger, audiopolicy.
* Add explicit keyword to conversion constructors.
Bug:
28341362
Test: build with WITH_TIDY=1
Change-Id: I3b73f0cd73f47be7735cc374306c02301c20588f
Viraj Karandikar [Fri, 26 Aug 2016 11:24:16 +0000 (16:54 +0530)]
WAVExtractor: support ambisonic subformat
Support ambisonic subformat
Change-Id: I4fb35cbac3dd8b97bdda0e4faf4cfc356e2de928
Dan Willemsen [Sat, 27 Aug 2016 00:52:29 +0000 (17:52 -0700)]
Convert to Android.bp
See build/soong/README.md for more information.
Change-Id: Ib5abad8bcb63bd3f3aa19a08817276fe21902515
Treehugger Robot [Thu, 25 Aug 2016 21:10:02 +0000 (21:10 +0000)]
Merge "Mark unused parameters as UNUSED in BRILLO."
Martijn Coenen [Thu, 25 Aug 2016 20:08:14 +0000 (20:08 +0000)]
Merge "Add bound checks to utf16_to_utf8"
Alex Deymo [Thu, 25 Aug 2016 18:59:14 +0000 (11:59 -0700)]
Mark unused parameters as UNUSED in BRILLO.
Bug:
31068444
Test: `make dist` in Brillo.
Change-Id: Ib0229ad78894fc703e9c5ad7bda4ab2466641f77
Eino-Ville Talvala [Thu, 25 Aug 2016 19:40:29 +0000 (19:40 +0000)]
Merge "Camera3: don't let dequeueBuffer block indefinitely"
Zhijun He [Tue, 2 Aug 2016 07:58:11 +0000 (00:58 -0700)]
Camera3: don't let dequeueBuffer block indefinitely
The synchronous consumers (e.g. ImageReader) may be very slow when the
clients have computational intensive image processings. When system
load is high, these processing will be even much slower. This could
starve the producer side and then cause dequeue/attach buffer block
indefinitely. If clients intends to close the capture session, right
after a capture request is submitted, the waitUntil drain could be
blocked indefinitely if the capture request dequeue buffer call is
blocked indefinitely, as the request thread will never become idle until
the last dequeue buffer is done and the request is sent.This indefinite
getBuffer() blocking could easily trigger the waitUntilDrained 5s timeout
thus put the camera device into error state although there is nothing
bad happening in the HAL.
Introducing the timeout will avoid such bad situation. When consumer is
slow, there will be no new request being sent to HAL, as there is really
no new buffer available.
Bug:
30404840
Change-Id: Ibf08d2745911203bce6f31130800707f36d7f985
Alex Deymo [Thu, 25 Aug 2016 16:30:43 +0000 (16:30 +0000)]
Merge "Silence warning about unused variables in BRILLO."
Sergio Giro [Tue, 28 Jun 2016 17:24:52 +0000 (18:24 +0100)]
Add bound checks to utf16_to_utf8
Bug:
29250543
Change-Id: I3518416e89ed901021970958fb6005fd69129f7c
(cherry picked from commit
1d3f4278b2666d1a145af2f54782c993aa07d1d9)
Alex Deymo [Thu, 25 Aug 2016 03:19:39 +0000 (20:19 -0700)]
Silence warning about unused variables in BRILLO.
This patch moves the call to validateClientPermissionsLocked() outside
the #if so it is executed in Brillo builds anyway, but the result is
ignored. This fixes the warning about unused parameters which was
causing the build to fail.
Bug:
31068444
Test: `make dist` in Brillo
Change-Id: I8a6648bf2221406068c9f5a1850a59ae0bde03ca
Sunghyun Kwon [Tue, 9 Aug 2016 07:11:12 +0000 (16:11 +0900)]
stagefright: fix finding hardware codec
When findMatchingCodecs(.., kHardwareCodecsOnly,..) was called,
it wouldn't actually match any hardware codecs because of a typo:
if (!(TRUE_prefer_HW_codec && !FALSE_is_SW_codec))
==> if (!(TRUE && TRUE))
Fix logic and clarify statements
Change-Id: Ice725f043475caedd8f7ab961e0bc985db2eba6f
Eric Laurent [Thu, 18 Aug 2016 12:40:13 +0000 (12:40 +0000)]
Merge "Fix for tone glitch produced in ToneGenerator"
am:
46f1c24c5a
Change-Id: If7da9dbfe106fdda640fc817a4fffe05b2ed5dff
Eric Laurent [Thu, 18 Aug 2016 12:35:37 +0000 (12:35 +0000)]
Merge "Fix for tone glitch produced in ToneGenerator"
Chih-hung Hsieh [Mon, 15 Aug 2016 21:26:27 +0000 (21:26 +0000)]
Merge "Fix google-explict-constructor warnings in mtp."
am:
b480ab9365
Change-Id: I7285319a159b5d1d42145e6eb9f51849c53df9d3
Chih-hung Hsieh [Mon, 15 Aug 2016 21:17:51 +0000 (21:17 +0000)]
Merge "Fix google-explict-constructor warnings in mtp."
Chih-hung Hsieh [Mon, 15 Aug 2016 20:03:52 +0000 (20:03 +0000)]
Merge "Fix google-explict-constructor warnings in img_utils."
am:
c36d401e83
Change-Id: I3cc4f149a715084f36a5e0fa4007e54ec6a7e84f
Chih-hung Hsieh [Mon, 15 Aug 2016 19:36:56 +0000 (19:36 +0000)]
Merge "Fix google-explict-constructor warnings in img_utils."
Chih-Hung Hsieh [Fri, 12 Aug 2016 20:46:48 +0000 (13:46 -0700)]
resolve merge conflicts of
6ae8c7b to stage-aosp-master
Change-Id: Iabb5d9b93b98e428c53f0504fbfe832ed24d988d
Chih-hung Hsieh [Fri, 12 Aug 2016 20:34:15 +0000 (20:34 +0000)]
Merge "Fix clang-tidy warnings in stagefright."
Chih-Hung Hsieh [Fri, 12 Aug 2016 18:13:49 +0000 (11:13 -0700)]
resolve merge conflicts of
70066d9 to stage-aosp-master
Change-Id: I9af1ace904388c91e6ce885e8a6d3540eb57bb4a
Treehugger Robot [Fri, 12 Aug 2016 17:48:29 +0000 (17:48 +0000)]
Merge "Fix clang-tidy warnings in camera."
Hans Boehm [Thu, 11 Aug 2016 14:55:23 +0000 (14:55 +0000)]
Merge "Remove RefBase base class from FrameRenderTracker"
am:
e4e2a8fc35
Change-Id: Ibf36079f9b9474988e7aed4d15964d89e2a0da49
Hans Boehm [Thu, 11 Aug 2016 14:51:42 +0000 (14:51 +0000)]
Merge "Remove RefBase base class from FrameRenderTracker"
Chih-Hung Hsieh [Wed, 10 Aug 2016 22:40:39 +0000 (15:40 -0700)]
resolve merge conflicts of
fd923e7 to stage-aosp-master
Change-Id: I75b44b89bae41197a1fd68362d20b8ba2b4dd192
Treehugger Robot [Wed, 10 Aug 2016 22:17:25 +0000 (22:17 +0000)]
Merge "Fix clang-tidy warnings in audio and playerservice."
Chih-Hung Hsieh [Tue, 9 Aug 2016 21:31:32 +0000 (14:31 -0700)]
Fix clang-tidy warnings in audio and playerservice.
* Add explicit keyword to conversion constructors.
Bug:
28341362
* Use const reference type for read-only parameters.
Bug:
30407689
Test: build with WITH_TIDY=1
Change-Id: I265f3b094e08d5705b506b3fbba51439c134af84
Merged-In: I265f3b094e08d5705b506b3fbba51439c134af84
Chih-Hung Hsieh [Tue, 9 Aug 2016 21:28:14 +0000 (14:28 -0700)]
Fix clang-tidy warnings in stagefright.
* Add explicit keyword to conversion constructors.
* Or add NOLINT to implicit conversion constructors.
Bug:
28341362
* Use const reference type for read-only parameters.
Bug:
30407689
* Use const reference type to avoid unnecessary copy.
Bug:
30413862
Test: build with WITH_TIDY=1
Change-Id: I7a15ac1e37973fe2c661f577a6106b913653de40
Merged-In: I7a15ac1e37973fe2c661f577a6106b913653de40
Chih-Hung Hsieh [Tue, 9 Aug 2016 21:25:53 +0000 (14:25 -0700)]
Fix clang-tidy warnings in camera.
* Add explicit keyword to conversion constructors.
Bug:
28341362
* Use const reference type for read-only parameters.
Bug:
30407689
* Use const reference type to avoid unnecessary copy.
Bug:
30413862
Test: build with WITH_TIDY=1
Change-Id: I71d3008da843ba5f1df1a73a320fb2af6ceffa16
Merged-In: I71d3008da843ba5f1df1a73a320fb2af6ceffa16
Chih-Hung Hsieh [Wed, 10 Aug 2016 17:18:32 +0000 (10:18 -0700)]
resolve merge conflicts of
1c10de5 to stage-aosp-master
Change-Id: I1e395ecb96524c18348b9f65c96d60c9eae9be45
Treehugger Robot [Wed, 10 Aug 2016 16:53:34 +0000 (16:53 +0000)]
Merge "Fix clang-tidy warnings in mediaresourcemanager."
Chih-Hung Hsieh [Tue, 9 Aug 2016 21:18:51 +0000 (14:18 -0700)]
Fix clang-tidy warnings in mediaresourcemanager.
* Add explicit keyword to conversion constructors.
Bug:
28341362
* Use const reference type for read-only parameters.
Bug:
30407689
Test: build with WITH_TIDY=1
Change-Id: I9aac64b379ddb77a9abb4b03a6648f38e2a756ab
Merged-In: I9aac64b379ddb77a9abb4b03a6648f38e2a756ab
Chih-Hung Hsieh [Tue, 9 Aug 2016 23:35:06 +0000 (23:35 +0000)]
Merge "Fix clang-tidy warnings in drm."
am:
e055519839
Change-Id: I99159fb0391af796445ea24265d088d20d178077
Chih-Hung Hsieh [Tue, 9 Aug 2016 23:31:39 +0000 (23:31 +0000)]
Merge "Fix clang-tidy warnings in soundtrigger."
am:
3ba2cb78bf
Change-Id: Ib9481a6bb666c75b8c0c1db5fc8f480cc85a266a
Chih-Hung Hsieh [Tue, 9 Aug 2016 23:31:37 +0000 (23:31 +0000)]
Merge "Fix google-explict-constructor warnings in radio."
am:
f53c1d182d
Change-Id: I5973845ffdd43d318ba1058c4c03432d78dbf733
Treehugger Robot [Tue, 9 Aug 2016 23:27:48 +0000 (23:27 +0000)]
Merge "Fix clang-tidy warnings in drm."
Treehugger Robot [Tue, 9 Aug 2016 23:26:07 +0000 (23:26 +0000)]
Merge "Fix clang-tidy warnings in soundtrigger."
Treehugger Robot [Tue, 9 Aug 2016 23:25:09 +0000 (23:25 +0000)]
Merge "Fix google-explict-constructor warnings in radio."
Chih-Hung Hsieh [Tue, 9 Aug 2016 21:20:59 +0000 (14:20 -0700)]
Fix clang-tidy warnings in drm.
* Add explicit keyword to conversion constructors.
Bug:
28341362
* Use const reference type for read-only parameters.
Bug:
30407689
* Use const reference type to avoid unnecessary copy.
Bug:
30413862
Test: build with WITH_TIDY=1
Change-Id: Idf1c48d7bfe3f0da20401cb3ff1983ec00be170d
Chih-Hung Hsieh [Tue, 9 Aug 2016 21:16:10 +0000 (14:16 -0700)]
Fix google-explict-constructor warnings in mtp.
* Add explicit keyword to conversion constructors.
Bug:
28341362
Test: build with WITH_TIDY=1
Change-Id: I3a84ae7ffa03b2e23562edef95ef6abefe0ff456
Chih-Hung Hsieh [Tue, 9 Aug 2016 21:13:55 +0000 (14:13 -0700)]
Fix google-explict-constructor warnings in img_utils.
* Add explicit keyword to conversion constructors.
Bug:
28341362
Test: build with WITH_TIDY=1
Change-Id: I490f8fcb666e0e1cb7923067857a747e7f529b3b
Chih-Hung Hsieh [Tue, 9 Aug 2016 21:06:20 +0000 (14:06 -0700)]
Fix google-explict-constructor warnings in radio.
* Add explicit keyword to conversion constructors.
Bug:
28341362
Test: build with WITH_TIDY=1
Change-Id: I15359f74d6587d691a8cb35445732aff44188268
Chih-Hung Hsieh [Tue, 9 Aug 2016 21:10:03 +0000 (14:10 -0700)]
Fix clang-tidy warnings in soundtrigger.
* Add explicit keyword to conversion constructors.
Bug:
28341362
* Use const reference type for read-only parameters.
Bug:
30407689
Test: build with WITH_TIDY=1
Change-Id: I28b251c99c78286a2da1e039df470a3f0bd8abe2
Hans Boehm [Wed, 3 Aug 2016 21:28:09 +0000 (14:28 -0700)]
Remove RefBase base class from FrameRenderTracker
FrameRenderTracker is never s standalone object, so it's unnecessary.
This avoids allocating a few extra heap objects. More importantly
it no longer interferes with my attempts to understand RefBase
objects that are deallocated without acquiring a strong reference.
Change-Id: I008b04b085fbab1efa4e8948efdcca14b26c247f
Pirama Arumuga Nainar [Tue, 28 Jun 2016 22:53:20 +0000 (15:53 -0700)]
Fix writeColrBox to write 0x80 instead of 128
Use 0x80 and explicitly cast down to int8_t.
Bug: http://b/
29831838
Change-Id: Ibf989863ab2affdc7218f94ca073f37f5192d488
(cherry picked from commit
fffb0c8fbe16ac948619b85e1eea9e65a9daa0c9)
Daniel Micay [Tue, 19 Jul 2016 23:47:16 +0000 (23:47 +0000)]
Merge \"webm: avoid unnecessary variable-length arrays\"
am:
67fbddfdc2
Change-Id: I7f738a3ab2fadf0794da4b5f47c2be259613bf4d
Treehugger Robot [Tue, 19 Jul 2016 22:38:19 +0000 (22:38 +0000)]
Merge "webm: avoid unnecessary variable-length arrays"
Daniel Micay [Mon, 18 Jul 2016 23:22:49 +0000 (19:22 -0400)]
webm: avoid unnecessary variable-length arrays
Change-Id: Ia72df2c208f2b0ebc9c55099dfaabdca97914791