OSDN Git Service
android-build-team Robot [Thu, 3 May 2018 16:53:44 +0000 (16:53 +0000)]
Merge "Greylist additions from bugreports, Thursday edition." into pi-dev
Nicolas Geoffray [Thu, 3 May 2018 16:44:32 +0000 (16:44 +0000)]
Merge "Light grey APIs." into pi-dev
android-build-team Robot [Thu, 3 May 2018 16:38:54 +0000 (16:38 +0000)]
Merge "In place split install native support" into pi-dev
android-build-team Robot [Thu, 3 May 2018 16:27:58 +0000 (16:27 +0000)]
Merge "Use current user for lockdown setting" into pi-dev
android-build-team Robot [Thu, 3 May 2018 16:17:36 +0000 (16:17 +0000)]
Merge "Fix QS edit accessibility." into pi-dev
android-build-team Robot [Thu, 3 May 2018 15:46:10 +0000 (15:46 +0000)]
Merge "Make safe label more safe" into pi-dev
Nicolas Geoffray [Thu, 3 May 2018 14:39:16 +0000 (15:39 +0100)]
Light grey APIs.
bug:
79074635
Test: m
Change-Id: I5013e7e71777357a75cceaba9cddeb7bd622102b
android-build-team Robot [Thu, 3 May 2018 15:23:49 +0000 (15:23 +0000)]
Merge "Dismiss systemui QS dialogs on screen off." into pi-dev
Selim Cinek [Thu, 3 May 2018 15:15:42 +0000 (15:15 +0000)]
Merge "Fix new notification showing timestamp "now" after turning off DND" into pi-dev
Mathew Inwood [Thu, 3 May 2018 15:00:14 +0000 (16:00 +0100)]
Greylist additions from bugreports, Thursday edition.
Bug:
72974713
Bug:
75406528
Bug:
75985094
Bug:
77500881
Bug:
78540770
Bug:
79126374
Bug:
79159669
Bug:
79163074
Bug:
79163553
Test: m
Change-Id: I8757a66bf625388e6f6419714ef5bba7af5d93ea
Benjamin Miller [Thu, 3 May 2018 14:08:54 +0000 (14:08 +0000)]
Merge "Docs: noted that DISALLOW_INSTALL_APPS prevents DPCs installing apps." into pi-dev
Nicolas Geoffray [Thu, 3 May 2018 14:08:50 +0000 (14:08 +0000)]
Merge "Add sql methods into light grey." into pi-dev
android-build-team Robot [Thu, 3 May 2018 14:05:00 +0000 (14:05 +0000)]
Merge "WIDGET_TYPE_UNSELECTABLE_TEXTVIEW is missing in the WidgetType" into pi-dev
android-build-team Robot [Thu, 3 May 2018 13:55:38 +0000 (13:55 +0000)]
Merge "BackgroundFallback: Cover all cases where the fallback is needed" into pi-dev
android-build-team Robot [Thu, 3 May 2018 13:46:56 +0000 (13:46 +0000)]
Merge "Revert "Update 'dnd is hiding notifications' view"" into pi-dev
android-build-team Robot [Thu, 3 May 2018 13:26:50 +0000 (13:26 +0000)]
Merge "old paths contains all entries when updating" into pi-dev
Richard Uhler [Thu, 3 May 2018 13:02:35 +0000 (13:02 +0000)]
Merge "Fix leak of WeakReferences on mThemeRefs list." into pi-dev
Julia Reynolds [Thu, 3 May 2018 12:40:20 +0000 (12:40 +0000)]
Revert "Update 'dnd is hiding notifications' view"
This reverts commit
85bad9b5bbbf2d974ad597963ae1bab87c60faf0.
Change-Id: Ic68475a8df0ae377c4fc357017b7d2a6b5311433
Fixes:
79155510
Fixes:
79156480
Nicolas Geoffray [Thu, 3 May 2018 12:08:14 +0000 (12:08 +0000)]
Merge "Add IWindowManager.setAnimationScales to light grey." into pi-dev
Nicolas Geoffray [Thu, 3 May 2018 12:04:21 +0000 (12:04 +0000)]
Merge "More light grey apis." into pi-dev
Benjamin Miller [Thu, 3 May 2018 10:56:28 +0000 (10:56 +0000)]
Docs: noted that DISALLOW_INSTALL_APPS prevents DPCs installing apps.
Bug:
72428023
Test: make ds-docs and inspect output
Change-Id: Ifc31378b7061d10b73de183e3c64864d608975b1
Todd Kennedy [Thu, 3 May 2018 09:05:04 +0000 (10:05 +0100)]
Make safe label more safe
* limit the absolute maximum size of the label to 50000 characters
[which is probably far more than necessary, but, can be dialed down]
* use a string buffer while processing the string [instead of creating
multiple string objects]
Bug:
62537081
Test: Manual. Install APK in bug and see that it can be uninstalled
Change-Id: Ibf63c2691ad7438a123e92110d95b1f50050f8b1
android-build-team Robot [Thu, 3 May 2018 10:08:23 +0000 (10:08 +0000)]
Merge "Turn on QuickStep onboarding" into pi-dev
Todd Kennedy [Wed, 2 May 2018 09:59:45 +0000 (10:59 +0100)]
old paths contains all entries when updating
In certains circumstances, only the base and split APKs were included in
the "old paths" list when updating the application info. Instead, this
list should contain _all_ elements, including any additional libraries
that may be added to the overall classpath.
Bug:
77342775
Test: Manual. Install a package. Install a split with --dont_kill. See that the path doesn't contain duplicate entries
Change-Id: Id9739cce215ab07bff1b17966583c0cf51a0b34a
android-build-team Robot [Thu, 3 May 2018 09:36:52 +0000 (09:36 +0000)]
Merge "Fixes non-matching instant app behavior" into pi-dev
Richard Uhler [Thu, 26 Apr 2018 14:09:30 +0000 (15:09 +0100)]
Fix leak of WeakReferences on mThemeRefs list.
Periodically remove references from the list whose referents have been
garbage collected.
Bug:
73961798
Test: Device boots.
Test: Take a heap dump of systemui and manually check that the state of
ThemeRefs looks reasonable.
Change-Id: I691027feb5dd217bcb60406b28897b9614e2a845
Nicolas Geoffray [Thu, 3 May 2018 08:32:44 +0000 (09:32 +0100)]
Add sql methods into light grey.
bug:
79147309
Test: m
Change-Id: Ia986d123e1e87489fec98e2d16c94b74119696c4
android-build-team Robot [Thu, 3 May 2018 08:19:43 +0000 (08:19 +0000)]
Merge "Add static IpClient logging" into pi-dev
Mathew Inwood [Thu, 3 May 2018 08:12:02 +0000 (08:12 +0000)]
Merge "Pass package name to runtime." into pi-dev
shawnlin [Wed, 2 May 2018 09:02:54 +0000 (17:02 +0800)]
Fix new notification showing timestamp "now" after turning off DND
DateTimeView won't update timestamp until the view is attached to
window and received TIME_TICK intent.
Update timestamp on onAttachedToWindow().
Test: manual 1) turn on DND 2) send a notification and wait some time 3)
turn off DND and check the timestamp
Fixes:
77970557
Change-Id: Ia8420aacf5b91b0bb9cbec561629ddbfc8de4f67
Shaowei Shen [Thu, 3 May 2018 02:05:17 +0000 (02:05 +0000)]
Merge "Fix [kv-3]PerformBackupTask using last package status to decide status sent to IBackupObserver." into pi-dev
Tracy Zhou [Thu, 3 May 2018 01:01:58 +0000 (01:01 +0000)]
Merge "Update QuickScrub tip according to the latest spec." into pi-dev
android-build-team Robot [Thu, 3 May 2018 00:14:23 +0000 (00:14 +0000)]
Merge "Fix a condition to reset the current spell checker" into pi-dev
android-build-team Robot [Wed, 2 May 2018 23:40:06 +0000 (23:40 +0000)]
Merge "Quickscrub will hide the most right buttons on nav bar" into pi-dev
android-build-team Robot [Wed, 2 May 2018 23:31:38 +0000 (23:31 +0000)]
Merge "Fix a race in spell checker session handling" into pi-dev
Yi Jin [Wed, 2 May 2018 21:36:23 +0000 (21:36 +0000)]
Merge "Add a section flag to bypass failure if a specific path can't be found." into pi-dev
Tracy Zhou [Tue, 1 May 2018 23:28:51 +0000 (16:28 -0700)]
Update QuickScrub tip according to the latest spec.
- Treat inreaction to the tip as 1st dismissal.
- Show tip after 1st dismissal based on Overview opened count instead of
app launch count.
Bug:
70180942
Test: manual test
Change-Id: I4410c78ac547ad49bd135dede71e79aaca2e1b10
Farid Zare Seisan [Wed, 2 May 2018 21:29:17 +0000 (21:29 +0000)]
Merge "UserDataPrepare: CE storage property set too early." into pi-dev
Matthew Ng [Thu, 26 Apr 2018 22:23:27 +0000 (15:23 -0700)]
Quickscrub will hide the most right buttons on nav bar
When scrub occurs, it will fade out the container of the navigation bar
menu buttons and animate them back when scrub ends.
Fixes:
77338303
Test: enable magnify in accessibility settings and drag home
Change-Id: Ic5df73b980c2cb20a135b20a9f84002f107db1c0
Jeff Sharkey [Wed, 2 May 2018 21:14:17 +0000 (21:14 +0000)]
Merge "Return to modifying raw /mnt/media_rw paths." into pi-dev
android-build-team Robot [Wed, 2 May 2018 20:58:14 +0000 (20:58 +0000)]
Merge "Preventing zombie process creation." into pi-dev
Selim Cinek [Wed, 2 May 2018 20:36:24 +0000 (20:36 +0000)]
Merge "Fix incorrect icon alignment on shelf" into pi-dev
Ryan Mitchell [Wed, 2 May 2018 20:23:49 +0000 (20:23 +0000)]
Merge "AAPT2: Fix quoted text in res/xml assets" into pi-dev
Lucas Dupin [Wed, 2 May 2018 20:20:51 +0000 (20:20 +0000)]
Merge "Fix NPE when casting" into pi-dev
Amin Shaikh [Wed, 2 May 2018 19:59:44 +0000 (15:59 -0400)]
Dismiss systemui QS dialogs on screen off.
CLOSE_SYSTEM_DIALOGS may not be sent if the user turns off and on the
screen quickly, resulting in systemui dialogs being displayed over the
lock screen. Dismissing these system dialogs when the SCREEN_OFF
broadcast is sent prevents this bug.
Change-Id: I097d0997d1538002b23bdd8f7aa32ecf4d32e0d4
Fixes:
78915648
Test: manual
android-build-team Robot [Wed, 2 May 2018 19:38:43 +0000 (19:38 +0000)]
Merge "Invoke create_recording_canvas correctly in macro bench tests" into pi-dev
android-build-team Robot [Wed, 2 May 2018 19:22:15 +0000 (19:22 +0000)]
Merge "Use Wi-Fi content description in StatusBarWifiView" into pi-dev
android-build-team Robot [Wed, 2 May 2018 19:17:27 +0000 (19:17 +0000)]
Merge changes from topic "ifaceStatsDetail" into pi-dev
* changes:
Remove the unused file parsing function
Use eBPF map data for per iface stats
Chia-I Wu [Wed, 2 May 2018 19:15:11 +0000 (19:15 +0000)]
Merge "Update Configuration#isScreenWideColorGamut doc" into pi-dev
Amin Shaikh [Wed, 2 May 2018 17:02:57 +0000 (13:02 -0400)]
Fix QS edit accessibility.
- Announce the correct QS tile positions when moving/adding tiles.
- Only insert a placeholder tile when adding tiles.
- Ensure all tiles are draggable, even if they are currently unavailable.
- Fix off by one error adding tiles into the last position.
- Remove tile remove a11y announcement as it is unnecessary.
Change-Id: Ia0bc1cb1559c2e46f9ddfe0f3ba0f50d5de56868
Fixes:
78608195
Fixes:
78611593
Fixes:
74253408
Test: manual
android-build-team Robot [Wed, 2 May 2018 18:30:13 +0000 (18:30 +0000)]
Merge "Fix DemoMode icon spacing" into pi-dev
Yang Lu [Wed, 2 May 2018 18:25:18 +0000 (18:25 +0000)]
Merge "Lock the pulling alarm handler." into pi-dev
Gopinath Elanchezhian [Wed, 2 May 2018 18:24:30 +0000 (18:24 +0000)]
Merge "Add 'ss' trace category in app launch test." into pi-dev
Lucas Dupin [Wed, 2 May 2018 07:33:17 +0000 (00:33 -0700)]
Fix NPE when casting
We didn't have any tests that guarantee that the keyguard casting flow
wouldn't be broken by updates on KeyguardStatusView.
Such test was created
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/KeyguardPresentationTest.java
Change-Id: I44f66be770ea2263fbf183bc438d1cedaa6f589a
Fixes:
71696859
Evan Laird [Wed, 2 May 2018 17:58:28 +0000 (13:58 -0400)]
Use Wi-Fi content description in StatusBarWifiView
Test: turn on TalkBack, tap Wi-Fi
Change-Id: Ic8bea2c5643ff44dfb042fceba1e87e12462635f
Fixes:
78172399
Ryan Mitchell [Fri, 27 Apr 2018 21:53:04 +0000 (14:53 -0700)]
AAPT2: Fix quoted text in res/xml assets
AAPT2 aggressively processed xml nodes and regressed from the behavior
of AAPT. This change restores AAPT's processing of xml nodes with
quotations.
Bug:
71805084
Test: Created tests in XmlFlattener_test.cpp and ran the test in the
Android Studio project given in the bug
Change-Id: Idedb4f1002e9fd705ceb5feae35289235b754b02
android-build-team Robot [Wed, 2 May 2018 17:47:15 +0000 (17:47 +0000)]
Merge "Work on issue #
77931346: The notification that should not be named appeared" into pi-dev
android-build-team Robot [Wed, 2 May 2018 17:44:17 +0000 (17:44 +0000)]
Merge "Fixed that some notifications were expandable by just a few pixels" into pi-dev
Chia-I Wu [Wed, 2 May 2018 17:13:22 +0000 (10:13 -0700)]
Update Configuration#isScreenWideColorGamut doc
Clarify that the method does not imply the screen is color-managed.
A global color transform may still be applied depending on the user
settings, such as night light, accessibility, Boosted, or Stretched.
Bug:
78012876
Test: builds
Change-Id: Ie9cdf455cf4ca93be2357a5313cd63555ab91ff9
Jack Yu [Wed, 2 May 2018 17:11:09 +0000 (17:11 +0000)]
Merge "Enabled area info update for India" into pi-dev
android-build-team Robot [Wed, 2 May 2018 16:55:15 +0000 (16:55 +0000)]
Merge "Fix issue #
78230210: Strobe: Need separate runtime permission group for READ_CALL_LOG and WRITE_CALL_LOG" into pi-dev
Hyunyoung Song [Wed, 2 May 2018 16:52:45 +0000 (16:52 +0000)]
Merge "Log OVERVIEW_ACTIVITY via MetricsLogger in quickstep Test: is done on ub-launcher3-edmonton branch that uses this library function Bug:
77920179" into pi-dev
Evan Laird [Wed, 2 May 2018 16:47:26 +0000 (12:47 -0400)]
Fix DemoMode icon spacing
- Use the same margin on the left of Wi-Fi (2.5dp)
- DemoMode uses the padding of the view it's replacing, and WRAP_CONTENT
for the width of its children
- Fix DemoMode etc dot color
- Don't constrain number of icons if DemoMode is replacing an
unconstrained container
Test: visual;
adb shell settings put global sysui_demo_allowed 1 && \
adb shell am broadcast -a com.android.systemui.demo -e command clock -e hhmm 0900 && \
adb shell am broadcast -a com.android.systemui.demo -e command network -e wifi show -e level 4 && \
adb shell am broadcast -a com.android.systemui.demo -e command network -e mobile show -e datatype none -e level 4 && \
adb shell am broadcast -a com.android.systemui.demo -e command status -e bluetooth disconnected && \
adb shell am broadcast -a com.android.systemui.demo -e command battery -e level 100 -e plugged false
Change-Id: I1d1389f9c6d6cb7d6078af5bbe4bc21e42771560
Fixes:
79094455
Victor Hsieh [Mon, 23 Apr 2018 21:43:19 +0000 (14:43 -0700)]
Avoid using 0 for fs-verity extension ID
Also:
* Adjust size and order of some fields
* Fix Merkle tree size calculation bug
Test: Verify fs-verity works with kernel patch
Bug:
67380979
Change-Id: I58f14cfe9630c1ff62ed64dbf333bb1c9bfe0fb1
Ryan Mitchell [Wed, 2 May 2018 16:27:03 +0000 (16:27 +0000)]
Merge "AAPT2: Fixed id parsing error" into pi-dev
Rohan Shah [Wed, 2 May 2018 16:21:38 +0000 (16:21 +0000)]
Merge "[Notif] Update guts/blocking helper UI" into pi-dev
Selim Cinek [Wed, 2 May 2018 16:15:06 +0000 (09:15 -0700)]
Fixed that some notifications were expandable by just a few pixels
The minimum height for the content with an image was
incorrect and was unnecessarily leading to the notification
being expandable even though it shouldn't need to
Test: add notification with single line, no actions, image, observe not expandable
Change-Id: Ia0b5c976ccbee9d7419bb809123c348b310bc148
Fixes:
77823428
Tony Mak [Wed, 2 May 2018 15:49:01 +0000 (16:49 +0100)]
WIDGET_TYPE_UNSELECTABLE_TEXTVIEW is missing in the WidgetType
Test: None
Bug:
72534351
Change-Id: I9cde8d98d2cd32aae91513fd65010011e3570470
Adrian Roos [Wed, 2 May 2018 15:46:04 +0000 (08:46 -0700)]
[automerger skipped] Fix build more
am:
d9d5f654c7 -s ours
Change-Id: Id7d1d5f358c21e010530c0158ba72f4ccb8c6bf9
Adrian Roos [Wed, 2 May 2018 15:44:36 +0000 (08:44 -0700)]
[automerger skipped] Fix build
am:
3e0fd90693 -s ours
Change-Id: I814a48bdab01da6aab05b08ff58c688f4909170a
Adrian Roos [Wed, 2 May 2018 15:42:33 +0000 (08:42 -0700)]
[automerger skipped] OC-MR1 DisplayCutout XML API
am:
361580459e -s ours
Change-Id: Ibff9a5fd9396eb54264970f02c832a7d085a9648
Nicolas Geoffray [Wed, 2 May 2018 15:28:54 +0000 (16:28 +0100)]
Add IWindowManager.setAnimationScales to light grey.
bug:
78784393
Test: m
Change-Id: Id29ebe3071fbfd54935aba52a8dedc8ed8e68495
android-build-team Robot [Wed, 2 May 2018 15:23:25 +0000 (15:23 +0000)]
Merge "Greylist updates from bugreports, Wednesday edition." into pi-dev
Mihai Popa [Wed, 2 May 2018 14:50:41 +0000 (14:50 +0000)]
Merge "[Magnifier-43] Refactor to remove code duplication" into pi-dev
android-build-team Robot [Wed, 2 May 2018 14:42:49 +0000 (14:42 +0000)]
Merge "Fix RTL TileLayout." into pi-dev
David Brazdil [Wed, 25 Apr 2018 10:15:07 +0000 (11:15 +0100)]
Merge non-SDK @removed API and light greylist
@removed APIs are not part of the public SDK but we do not want
to block access to them. Use the recently added removed-dex.txt
list of @removed API signatures and merge it into the hidden API
light greylist programmatically.
Note that due to Doclava's rule precedence, @removed APIs which
override a public SDK method are considered public and are
whitelisted. We have to intersect removed-dex.txt with private-dex.txt
to satisfy the rule that light greylist is a subset of private-dex.txt.
Bug:
78182899
Test: make out/target/common/obj/PACKAGING/removed-dex.txt
Change-Id: I44e54c405fc667d54a990b9ded1de8456802545e
David Brazdil [Wed, 2 May 2018 14:28:18 +0000 (14:28 +0000)]
Merge "Build list of @removed API's dex signatures" into pi-dev
Nicolas Geoffray [Wed, 2 May 2018 13:58:07 +0000 (14:58 +0100)]
More light grey apis.
bug:
79110492
Test: m
Change-Id: Ic83c6cfe28828f5c0b1a45eabfaa3e8ec3d54d81
android-build-team Robot [Wed, 2 May 2018 14:24:28 +0000 (14:24 +0000)]
Merge "Flip the cross profile apps animation" into pi-dev
Mathew Inwood [Wed, 2 May 2018 14:06:06 +0000 (15:06 +0100)]
Greylist updates from bugreports, Wednesday edition.
Bug:
78309612
Bug:
78471731
Bug:
78479712
Bug:
78596948
Bug:
78786637
Bug:
78906153
Bug:
79129056
Test: m
Change-Id: I1f6eb4e8de51ebf223b6863606a0a6401be03d9d
Nicolas Geoffray [Wed, 2 May 2018 13:22:48 +0000 (13:22 +0000)]
Merge "Add more light grey APIs." into pi-dev
Daniel Sandler [Wed, 2 May 2018 13:03:20 +0000 (13:03 +0000)]
Merge "SystemUI heap monitor & hprof dump tile." into pi-dev
Adrian Roos [Mon, 30 Apr 2018 14:05:00 +0000 (16:05 +0200)]
BackgroundFallback: Cover all cases where the fallback is needed
Fixes an issue where uncovered regions were not
covered if they are to the right or bottom of the
content view.
Fixes:
78661186
Test: Install test app from bug, enable cuotut, open test app, go to landscape, verify white fallback background is drawn in both landscape and seascape
Test: atest BackgroundFallbackTest
Change-Id: I442f03395a71550a534d64233762aa84002319dd
Milo Sredkov [Wed, 2 May 2018 12:57:17 +0000 (12:57 +0000)]
Merge "Keep the notification shade open for smart replies" into pi-dev
Erik Kline [Tue, 1 May 2018 07:51:44 +0000 (16:51 +0900)]
Add static IpClient logging
Support keeping IpClient logs around and dumping them
during dumpsys. Previously we got this benefit for
wifi by virtue of WifiStateMachine's long-lived nature.
Now that this is changing we need to be sure we have
logs, and this method gets us Ethernet logs as well.
Bug:
62476366
Bug:
77999594
Test: as follows
- built
- flashed
- booted
- runtest frameworks-net passes
- dumpsys connmetrics [ipclient] works
Change-Id: I1136a83de8097fdb4130debe1eaf689be7132fe5
Adrian Roos [Wed, 2 May 2018 12:30:35 +0000 (12:30 +0000)]
Fix build more
Bug:
78122614
Test: m checkbuild
Change-Id: Ia69eca72a2982c6417bcd30bf806ef8c18616251
Merged-In: I226622533a1b406ba26c161cba13721080b4baca
Eran Messeri [Wed, 2 May 2018 12:31:06 +0000 (12:31 +0000)]
Merge "Save password requirements on the right user" into pi-dev
android-build-team Robot [Wed, 2 May 2018 12:02:46 +0000 (12:02 +0000)]
Merge "WindowStateAnimator: Hide preserved surface when showing new Surface" into pi-dev
Mihai Popa [Wed, 2 May 2018 12:02:18 +0000 (12:02 +0000)]
Merge changes I63f2b185,I0d749c1a into pi-dev
* changes:
[Magnifier-42] Fix bug in window positioning
[Magnifier-41] Fix behavior in windows with insets
Adrian Roos [Mon, 23 Apr 2018 16:54:37 +0000 (18:54 +0200)]
Fix build
Bug:
78122614
Test: m checkbuild
Change-Id: Ifd908fc91dc89d33a2b88fcfaed48480315991c6
Merged-In: I226622533a1b406ba26c161cba13721080b4baca
Adrian Roos [Tue, 20 Mar 2018 13:58:29 +0000 (14:58 +0100)]
OC-MR1 DisplayCutout XML API
Bug:
78122614
Test: m checkbuild
Change-Id: I974d3d4385ba66477e0932d40d0af7bcd32ddfb1
Merged-In: I226622533a1b406ba26c161cba13721080b4baca
Nicolas Geoffray [Wed, 2 May 2018 10:35:54 +0000 (11:35 +0100)]
Add more light grey APIs.
bug:
64382372
Test: m
Change-Id: Ia6f389ffb22f052409fc307de89cfef8d2fbeee4
Mihai Popa [Mon, 30 Apr 2018 18:08:57 +0000 (19:08 +0100)]
[Magnifier-43] Refactor to remove code duplication
Since Ic5b5f6ca687db8b5d842f0ab20eac70f1fd2f85e, the magnifier can be
the child of a diffent surface than the one its content is copied from.
This initially led to much code duplication accross different methods,
making the code quite difficult to understand. This CL performs a small
refactoring, removing some of the TODOs and making the code a bit
cleaner.
Bug:
78876353
Test: atest CtsWidgetTestCases:android.widget.cts.MagnifierTest
Change-Id: Ifa26f94ba2e4983446f058f016af6010c1017ea7
Mihai Popa [Fri, 27 Apr 2018 15:32:44 +0000 (16:32 +0100)]
[Magnifier-42] Fix bug in window positioning
The position of the magnifier surface is always clamped inside its
parent surface. As of Ic5b5f6ca687db8b5d842f0ab20eac70f1fd2f85e, we are
always trying to make the magnifier surface a child of the main
application window, if possible (before, if the magnified view was a
SurfaceView, we were making the magnifier a child of the SurfaceView's
surface). However, the CL did not also update the clamping, continuing
to clamp to the SurfaceView space when the magnified view was a
SurfaceView (even if the magnifier was child of the main window). This
was making the magnifier window to be wrongly positioned on the screen
when the magnified view is a SurfaceView. The current CL fixes this.
Bug:
78876353
Test: manual testing
Test: atest CtsWidgetTestCases:android.widget.cts.MagnifierTest
Change-Id: I63f2b185f58e62e8ad6eadf788e641fb1de07b04
Mihai Popa [Fri, 27 Apr 2018 12:09:12 +0000 (13:09 +0100)]
[Magnifier-41] Fix behavior in windows with insets
The CL fixes the magnifier's behavior when its parent window has
positive insets in its surface:
- we compute the content copy coordinates sent to the pixel copy request
relative to the surface the content is copied from. We were clamping
them inside the visible region of the magnified view as returned by
belonging to the view which is magnified. However, the method returns
coordinates relative to the window. Therefore, the CL offsets the
visible rectangle with the window insets, to account for them.
Otherwise, when the insets were non-zero, on a text line we were
allowing the magnifier to display content from the left outside of the
text line, while a certain region at the end of the text line could have
never been magnified
- when clamping against the visible view region, when the surface we
copy from is a SurfaceView, #getGlobalVisibleRect is still returning
coordinates relative to the main window, whereas the coordinates we are
trying to clamp are relative to the surface of the SurfaceView. In order
to make the visible rectangle relative to the surface of the SurfaceView
instead, this CL negatively offsets the visible rectangle with the
SurfaceView position in the parent surface
- the selection/insertion handles are hidden when they overlap the
magnifier. To check this, we intersect the magnifier rectangle with the
rectangle of each handle. However, when we were performing this check,
the magnifier rectangle was relative to the surface, whereas the
handles' rectangle was relative to the main window. The CL negatively
offsets the magnifier position with the surface insets, to make both
rectangles relative to the window.
Bug:
78621162
Test: manual testing
Test: atest CtsWidgetTestCases:android.widget.cts.MagnifierTest
Change-Id: I0d749c1abb38520fe8fc477d22d6523f470e9abc
Mathew Inwood [Wed, 2 May 2018 09:42:23 +0000 (10:42 +0100)]
Pass package name to runtime.
When binding an application in ActivityThread, pass the package name to
the runtime so it knows which package is running in the process.
Bug:
77517571
Test: m
Change-Id: Ia646599ca45b76ebcd068fcc50df23659e89b82b
Milo Sredkov [Tue, 1 May 2018 21:45:38 +0000 (22:45 +0100)]
Keep the notification shade open for smart replies
Currently when the user taps on a smart reply button from a locked
screen, we ask for a pattern/password and then close the notification
shade. This is inconsistent with the unlocked case and with how inline
replies are handled.
Set mLeaveOpenOnKeyguardHide to true when handling smart reply clicks.
Also simplify and rename the method in KeyguardDismissHandler to make
this new behaviour clearer.
Bug:
77841506
Test: Tap on a smart reply from the lockscreen, then unlock.
Change-Id: If1dab2a4b0d93a512c27e6d8a870289f64c7b63d
android-build-team Robot [Wed, 2 May 2018 09:10:45 +0000 (09:10 +0000)]
Merge "Remove margin from first line of remote history" into pi-dev
David Brazdil [Thu, 26 Apr 2018 15:10:35 +0000 (16:10 +0100)]
Build list of @removed API's dex signatures
CL Iba8869ce6e4f401a8e420ad83ab459d25bbbaae0 added Doclava support
to generate a list of @removed API. Add a rule which builds that
list.
Bug:
78182899
Test: make out/target/common/obj/PACKAGING/removed-dex.txt
Merged-In: Ifa912f8751025b7de24a982a1a227a9c27d18267
Merged-In: I80860c2b9f7213db65d0a9ca65bd645187aa0ce0
Change-Id: I688c14e0d2fbfafe9ac212e6abdc3593cb744ef9
android-build-team Robot [Wed, 2 May 2018 07:28:33 +0000 (07:28 +0000)]
Merge "Request focus when pin is visible" into pi-dev