Move TODO stuff to 0.9

Wound up doing some work that's more important than the stuff in the
TODO, so it's all getting moved out to 0.9

Signed-off-by: Peter Jones <pjones@redhat.com>

Clean up some whitespace.

Signed-off-by: Peter Jones <pjones@redhat.com>

Add the ability to clean up duplicates in BootOrder

This adds -D (--remove-dups), which iterates BootOrder and keeps only
the first of any number it finds.  Duplicate entries can happen as a
result of an interaction between fallback.efi and some system firmware,
and this option provides an easy workaround to fix it.

Resolves: rhbz#1097396

Signed-off-by: Peter Jones <pjones@redhat.com>

Fix some leaked memory that shows up in valgrind.

Signed-off-by: Peter Jones <pjones@redhat.com>

Don't leak memory in remove_from_boot_order()

Signed-off-by: Peter Jones <pjones@redhat.com>

Don't pass around a format specifier when we don't need to.

Current code has the format specifier in a function that doesn't
otherwise know about the format, and passes it in to a function that
does.

And it's always been like this.

Signed-off-by: Peter Jones <pjones@redhat.com>

Compare should respect the size of the data it compares.

Use PRIx64 in nvme parsing.

This should fix https://github.com/vathpela/efibootmgr/issues/6 , though
I don't know if it'll actually make nvme work.

Signed-off-by: Peter Jones <pjones@redhat.com>

Clang uses C99 semantics by default for inline keyword.

It's most straightforward not to state get_scsi_idlun is inline.

Signed-off-by: Daniel Jared Dominguez <Jared_Dominguez@Dell.com>

Variable "needed" should be of type ssize_t as that's how it's used.

Signed-off-by: Daniel Jared Dominguez <Jared_Dominguez@Dell.com>

data_size in construct_boot_order/set_boot_order is of type size_t, so fix a couple of comparisons involving it.

Signed-off-by: Daniel Jared Dominguez <Jared_Dominguez@Dell.com>

Fix typo in compare function.

Signed-off-by: Daniel Jared Dominguez <Jared_Dominguez@Dell.com>

Remove unused function var_num_from_name.

Signed-off-by: Daniel Jared Dominguez <Jared_Dominguez@Dell.com>

Mitigate apple setting invalid attribute bits in boot variables.

Signed-off-by: Peter Jones <pjones@redhat.com>

We don't actually have docbook hooked up to the builds, so ditch it.

Frankly I'm more comfortable maintaining groff anyway, but right now
they just get out of sync all the time.

Signed-off-by: Peter Jones <pjones@redhat.com>

Only free hard drive signatures if we've allocated them.

Signed-off-by: Peter Jones <pjones@redhat.com>

Remove bogus test for optional data length bounds.

We're getting the size from subtracting from the actual limit; it can't
be over the limit, and it's not related to the variable we're comparing
it to anyway.

Not sure how I came up with that logic, but it sure is wrong.

Signed-off-by: Peter Jones <pjones@redhat.com>

Make nvme work with "-e 3".

This will force a long-form NVME device path.

Signed-off-by: Peter Jones <pjones@redhat.com>

Add support for displaying NVME device paths.

This doesn't actually let you /use/ them yet, but it does show them if
they're there.

Signed-off-by: Peter Jones <pjones@redhat.com>

Get a lot more picky with our compiler warnings.

Signed-off-by: Peter Jones <pjones@redhat.com>

Filenames and github - the worst of both worlds.

Signed-off-by: Peter Jones <pjones@redhat.com>

Call it 0.7

This has been around for a while, and it's not going to get any more
testing without some exposure.  Let's give it a shot.

Signed-off-by: Peter Jones <pjones@redhat.com>

Fix device path size and allocation in make_file_path_device_path()

Signed-off-by: Peter Jones <pjones@redhat.com>

Fix a missing error return.

Signed-off-by: Peter Jones <pjones@redhat.com>

Add a --keep option to preserve the old BootOrder entries when using -o.

So basically if you've got a boot order of:

0000,0001,0018,001A,0019

And you do "efibootmgr -o 001A --keep", you'll get:

001A,0000,0001,0018,0019

And if you subsequently do "efibootmgr -o 0002 --keep" you'll get:

0002,001A,0000,0001,0018,0019

This is to work around a buggy firmware reported in rhbz#889509 ,
which will erroneously try to re-populate BootOrder /and create new
Boot#### entries to do so/ if you supply a BootOrder without the
defaults in it.

This firmware is garbage.

Signed-off-by: Peter Jones <pjones@redhat.com>

Add SATA(x,y,z) device path unparsing.

Signed-off-by: Peter Jones <pjones@redhat.com>

Get the correct size for device path in our optional data blob.

Signed-off-by: Peter Jones <pjones@redhat.com>

Add some requires to our spec file for efivar-libs and efivar-devel.

Signed-off-by: Peter Jones <pjones@redhat.com>

Make Vendor-Defined Message paths show up the same way as in "bcfg boot dump".

Signed-off-by: Peter Jones <pjones@redhat.com>

Make FvFile show up the same way it does in "bcfg boot dump".

Signed-off-by: Peter Jones <pjones@redhat.com>

Handle bogus malformed variables somewhat more gracefully.

Because previously we tried to dump what it was saying, but that really
just means crashing.

Signed-off-by: Peter Jones <pjones@redhat.com>

Fix gpg path in "make archive".

Still pointed at .tar.gz while everything else says .tar.bz2

Signed-off-by: Peter Jones <pjones@redhat.com>

Make the man page not mention proc, and make it mention efivarfs.

Signed-off-by: Peter Jones <pjones@redhat.com>

Merge the old TODO and the new one.

Oops.

Signed-off-by: Peter Jones <pjones@redhat.com>

Update urls in README.

Signed-off-by: Peter Jones <pjones@redhat.com>

Update TODO.

Signed-off-by: Peter Jones <pjones@redhat.com>

Get rid of the 1024-byte limit on ESP file path.

Not that I think 1024 was something we were going to hit there, but...

Signed-off-by: Peter Jones <pjones@redhat.com>

Handle some other device paths.

Add support for Vendor-Defined Messaging Device Paths as well as
FVFILE() and FVVOL()

Signed-off-by: Peter Jones <pjones@redhat.com>

Get rid of 1024-byte limit for displaying variables as well.

This basically makes all of unparse_path() and its derivatives into
snprintf()-like functions, so we don't have to have static buffers.

Signed-off-by: Peter Jones <pjones@redhat.com>

Add a TODO here so I can keep track of what is yet to be done.

Signed-off-by: Peter Jones <pjones@redhat.com>

Typo fix.

Signed-off-by: Peter Jones <pjones@redhat.com>

Correctly fill out sa_family for MAC address device types.

Signed-off-by: Peter Jones <pjones@redhat.com>

Handle virtio network devices.

Just like virtio scsi devices, look up their bus/device/function by the
virtio device instead of the traditional way.

Signed-off-by: Peter Jones <pjones@redhat.com>
Tested-and-reviewed-by: Laszlo Ersek <lersek@redhat.com>

'-h' is a valid option, recognize it

This completes commit e562a948.

Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Ignore patches.

Signed-off-by: Peter Jones <pjones@redhat.com>

Remove 40-character limit on file paths in /boot.

This is totally unnecessary now; the only real point before was
everything was fixed size to keep it within 1024.

Signed-off-by: Peter Jones <pjones@redhat.com>

Don't allow negative boot numbers.

In the case where you typo the command line and do:

efibootmgr -b -a blah blah blah

instead of

efibootmgr -b 0001 -a blah blah blah

sscanf(..., "%X", &num) happily produces a successful return code and a
value of -10.  This later results in us creating a boot variable named
BootFFFFFFFF6 , which is clearly not okay.  So if we've got a negative
number there, it's probably not what the user wanted.

Bounds check the whole thing.

Signed-off-by: Peter Jones <pjones@redhat.com>

Make make_linux_load_option() slightly more readable.

Signed-off-by: Peter Jones <pjones@redhat.com>

Make add_extra_args_file() work properly.

Two things:
1) make it actually return the data
2) _ascii() and _unicode() will get invoked in some cases, and they need
   to handle the case where they do nothing.

Signed-off-by: Peter Jones <pjones@redhat.com>

Audit strlen() in append_extra_args_ascii() as well.

Similar code, similar bugs.

Signed-off-by: Peter Jones <pjones@redhat.com>

Restore old boot order behavior.

Previously we prepended rather than appending new elements to the boot
order.

Signed-off-by: Peter Jones <pjones@redhat.com>

Do better error checking in read_boot_u16(), and simplify it.

Why am I even doing this stupid bitshifting?

Signed-off-by: Peter Jones <pjones@redhat.com>

Fix byte assignment in read_boot_u16().

It helps if you put the bytes in the right order, and the parenthesis
around the right things to keep them from being all zero.

Signed-off-by: Peter Jones <pjones@redhat.com>

More work on append_extra_args_unicode()

two problems:
1) strlen off-by-one
2) efichar_from_char() awesomely takes a length in bytes, returns in
   bytes, and operates on efi_char16_t sizes.  This can be somewhat
   confusing.

Signed-off-by: Peter Jones <pjones@redhat.com>

You really can't free something you put through realloc().

This should make '-u' work again.

Signed-off-by: Peter Jones <pjones@redhat.com>

Fix typo in arg parsing.

Signed-off-by: Peter Jones <pjones@redhat.com>

Remove some dead code.

If anybody's looking for it, it's in git.

Signed-off-by: Peter Jones <pjones@redhat.com>

Clean up .gitignores some.

Signed-off-by: Peter Jones <pjones@redhat.com>

Make --help also -h, and don't have it exit with an error status.

Signed-off-by: Peter Jones <pjones@redhat.com>

Make tilt_slashes() static.

Signed-off-by: Peter Jones <pjones@redhat.com>

Fix uninitialized variable.

valgrind found a couple of errors, one of which fixes some odd behavior
with BootOrder I was seeing.

Signed-off-by: Peter Jones <pjones@redhat.com>

Fix minor compiler warning.

Signed-off-by: Peter Jones <pjones@redhat.com>

Fix completely wrong compiler warning.

gcc's data flow analysis still kind of blows.

Signed-off-by: Peter Jones <pjones@redhat.com>

Make the error case from make_boot_var() cleaner.

bcl thinks it looks better at the end, and I agree.

Signed-off-by: Peter Jones <pjones@redhat.com>

Don't do unnecessary math.

bcl found this one too - we know len % 5 is 4, because it's tested a few
lines up.

Signed-off-by: Peter Jones <pjones@redhat.com>

Fix error message that says "delete" on the "activate" case.

bcl found this reviewing it.

Signed-off-by: Peter Jones <pjones@redhat.com>

Use libefivar.

Using libefivar divorces us from the kernel api, which is a very good
thing.  It also means we don't need to know about efi_status_t or efi
error types, or carry our own headers for describing variables.

This also makes device paths > 1024 bytes long work (on newer kernels)

Signed-off-by: Peter Jones <pjones@redhat.com>
Conflicts:
src/efibootmgr/efibootmgr.c
src/lib/efi.c

Ignore some files so "git status" is clearer.

Signed-off-by: Peter Jones <pjones@redhat.com>

Silence some minor compiler warnings.

Signed-off-by: Peter Jones <pjones@redhat.com>

Release 0.6.1

Signed-off-by: Peter Jones <pjones@redhat.com>

Modernize "make tarball" for our glorious git future.

Signed-off-by: Peter Jones <pjones@redhat.com>

Prepping for move to GitHub. Updated documentation to refer to new maintainer and new git repository.

From: Colin Watson <cjwatson@ubuntu.com>

Fix -w option to leave an existing unique MBR signature intact. This makes the
implementation match the documentation.

From: Bdale Garbee <bdale@gag.com>

change computeroutput to programlisting to fix man page formatting issue,
update rules to use docbook source for man page, closes Debian bug #680716

Fix unchecked malloc calls.
Resolves: rhbz#715216
From Peter Jones@Redhat

produce virtio-scsi device paths under EDD 3.0
Patch from Laszlo Ersek@RedHat

prevent out-of-bounds access with SCSI_IOCTL_GET_PCI
Patch from Laszlo Ersek@RedHat

disk_get_virt_pci(): generalize to arbitrary major & minor device numbers
Patch from Laszlo Ersek@RedHat

disk_info_from_fd(): group output parameters into struct disk_info
Patch from Laszlo Ersek@RedHat

produce virtio-blk device paths under EDD 3.0
Patch from Laszlo Ersek@RedHat

disk_get_pci(): expose detected interface type
Patch from Laszlo Ersek@RedHat

disk_info_from_fd(): get major/minor from buf.st_rdev
Patch from Laszlo Ersek@RedHat

Add support for UNIX-style path names (forward-slash)
Submitted by Keshav Padram [the.ridikulus.rat@gmail.com]

Update manpage email

Bump efibootmgr version to include latest changes

Add patches from fedora release
* Wed Nov 28 2012 Matthew Garrett <mjg59@srcf.ucam.org> - 0.5.4-14
- efibootmgr-0.5.4-Work-around-broken-Apple-firmware.patch
  Resolves: #873629
- efibootmgr-0.5.4-Remove-device-path-padding-on-non-Itanium.patch - improve
  spec conformance

From: Lane Winner<lane.winner@oracle.com>

make_boot_var does not check for failed status with create_variable.
This can result in a memory leak.
Additionally the user should be notified of the problem.

We encounter this issue on one system after filling up the UEFI boot list
with dummy devices.

The patch fix the problem. It was verified on a Mensa system using RHEL 6.0

Signed-off-by: Yinghai Lu<yinghai@kernel.org>

Handle sector_size != 512.

Disks can have 4kB sectors now, so don't just bail out when that's the
case.

fix disk minor number discovery

Raymund Will noted disk_info_from_fd() incorrectly used logical &&
instead of bitwise & when obtaining the minor number.

Reported in https://bugzilla.novell.com/show_bug.cgi?id=524529#c1

fix minor memory leak

David Binderman noted new_data was being allocated but not freed.  Not
a big deal as the program exits soon thereafter (and is thus freed),
but worth fixing anyhow.

Fixes https://bugzilla.novell.com/show_bug.cgi?id=524529#c1

update ChangeLog

replacing elilo < 3.6-6, not -5

per conversation with clumens.

RPM spec rewrite for Fedora inclusion

efibootmgr is being split out of the elilo SRPM in Fedora, into its
own SRPM.

Makefile cleanups

bump version

take an EXTRA_CFLAGS argument so rpmbuild can give us it's CFLAGS
without overriding ours.

exclude .git and *~ files from the tarball.

src/lib/efi.c: include linux/types.h

patch from Fedora.

make sure GPT_HEADER_SIGNATURE is a 64-bit value

patch from Debian / Ubuntu 0.5.3-3ubuntu1.

avoid more unaligned access warnings

cleanup a few unaligned access warnings

cleanup exit values a little

patch to make efibootmgr have non-zero exit code on errors

We have some automated tools that use efibootmgr which are having a hard
time detecting when efibootmgr fails since it exits with 0 on many
failures.  This patch catches (most) errors and exits with non-zero.  I
also added several error messages for to make it more obvious what was
wrong with the command line arguments.

Signed-off-by: Matt Domsch <Matt_Domsch@dell.com>