OSDN Git Service
Peter Eisentraut [Sat, 11 Dec 2004 19:01:46 +0000 (19:01 +0000)]
Added port report
Bruce Momjian [Fri, 10 Dec 2004 18:01:59 +0000 (18:01 +0000)]
Reorder IRC examples.
Tom Lane [Mon, 6 Dec 2004 23:57:17 +0000 (23:57 +0000)]
ActiveSnapshot must be set to something valid while running deferred
triggers during COMMIT. Per trouble report from Frank van Vugt.
Peter Eisentraut [Mon, 6 Dec 2004 23:47:08 +0000 (23:47 +0000)]
Start filling in the supported platforms list with build farm information.
Peter Eisentraut [Mon, 6 Dec 2004 22:10:42 +0000 (22:10 +0000)]
Translation updates
Michael Meskes [Mon, 6 Dec 2004 20:35:35 +0000 (20:35 +0000)]
Fixed bug in parsing of typedef'ed array sizes.
Synced parser.
Neil Conway [Mon, 6 Dec 2004 01:09:20 +0000 (01:09 +0000)]
Fix off-by-1 bug in pg_ctl in -D handling, per report from pjmodos@parba.cz
Tom Lane [Sun, 5 Dec 2004 20:05:47 +0000 (20:05 +0000)]
Fix several mistaken xreflabel entries, including those spotted by
Michael Fuhr.
Bruce Momjian [Sat, 4 Dec 2004 18:19:33 +0000 (18:19 +0000)]
Back out addition of Win1252 encoding.
Bruce Momjian [Sat, 4 Dec 2004 04:12:11 +0000 (04:12 +0000)]
Properl format HTML in developer's FAQ.
PostgreSQL Daemon [Fri, 3 Dec 2004 22:24:53 +0000 (22:24 +0000)]
tag configure for rc1 ..
Tom Lane [Fri, 3 Dec 2004 22:19:28 +0000 (22:19 +0000)]
As long as we're forcing an ORDER BY in these four join queries, we had
better make sure the sort order is totally specified; else we get burnt
by platform-specific behavior of qsort() with equal keys. Per buildfarm
results.
Tom Lane [Fri, 3 Dec 2004 21:26:31 +0000 (21:26 +0000)]
Use StrNCpy not strncpy to fill hash key, to ensure the resulting key
is null-terminated. I think this is not a real bug because the parser
would always have truncated the identifier to NAMEDATALEN-1 already,
but let's be safe. Per report from Klocwork.
Tom Lane [Fri, 3 Dec 2004 18:48:19 +0000 (18:48 +0000)]
Adjust help message for --no-owner, per Alvaro Herrera.
Bruce Momjian [Fri, 3 Dec 2004 18:34:31 +0000 (18:34 +0000)]
Back out ARRAY() patch.
Tom Lane [Fri, 3 Dec 2004 17:46:19 +0000 (17:46 +0000)]
Improve description of --disable-rpath workaround for regression test
problems.
Bruce Momjian [Fri, 3 Dec 2004 17:13:28 +0000 (17:13 +0000)]
> If it bothers you that much. I'd make a flag, cleared at the start of
> each COPY, and then where we test for CR or LF in CopyAttributeOutCSV,
> if the flag is not set then set it and issue the warning.
Andrew Dunstan
Bruce Momjian [Fri, 3 Dec 2004 17:12:09 +0000 (17:12 +0000)]
>>This patch adds another plpgsql trigger example to the chapter. It uses
>>the emp table again, but shows how to audit changes into another table
>>(emp_audit).
Mark Kirkwood
Bruce Momjian [Fri, 3 Dec 2004 17:07:50 +0000 (17:07 +0000)]
Add:
> * ANALYZE should record a pg_statistic entry for an all-NULL column
Bruce Momjian [Fri, 3 Dec 2004 06:30:40 +0000 (06:30 +0000)]
Typo fixes.
Bruce Momjian [Fri, 3 Dec 2004 06:18:12 +0000 (06:18 +0000)]
Fix typo.
Bruce Momjian [Fri, 3 Dec 2004 06:04:38 +0000 (06:04 +0000)]
Merge pgadmin paragraph.
Bruce Momjian [Fri, 3 Dec 2004 05:50:18 +0000 (05:50 +0000)]
First version of external projects manual section.
Bruce Momjian [Fri, 3 Dec 2004 02:24:01 +0000 (02:24 +0000)]
Add:
> * Fix priority ordering of read and write light-weight locks (Neil)
Bruce Momjian [Fri, 3 Dec 2004 01:58:43 +0000 (01:58 +0000)]
Fix compile breakage from SIGPIPE fix for threading.
Bruce Momjian [Fri, 3 Dec 2004 01:23:38 +0000 (01:23 +0000)]
Remove doc changes that were in process during previous commit.
Bruce Momjian [Fri, 3 Dec 2004 01:20:33 +0000 (01:20 +0000)]
Back out fix for Unicode characters above 0x10000
Tom Lane [Thu, 2 Dec 2004 23:20:21 +0000 (23:20 +0000)]
Code review for recent libpq changes. Be more careful about error
handling in SIGPIPE processing; avoid unnecessary pollution of application
link-symbol namespace; spell 'pointer to function' in the conventional
way.
Bruce Momjian [Thu, 2 Dec 2004 23:11:30 +0000 (23:11 +0000)]
Add:
<
> o Fix problem with shared memory on the Win32 Terminal Server
Bruce Momjian [Thu, 2 Dec 2004 22:51:28 +0000 (22:51 +0000)]
> I have installed your patch and adjusted the names of the standards
> throughout to the spellings suggested by your book.
Great.
A follow-up patch for current CVS HEAD is attached, and available at
http://troels.arvin.dk/db/pgsql/conformance/pgsql-sql-conformance-
followup.patch
The patch
- includes a core feature ID that had been left
out by mistake (C011)
- updates the sql_feature_packages.txt table to
reflect changes in SQL:2003 which were not
covered properly in my last patch
Troels Arvin
Bruce Momjian [Thu, 2 Dec 2004 22:48:10 +0000 (22:48 +0000)]
> > 8.0beta3 has pg_autovacuum included, when I want to run this as a
> > Windows service, it says you can use the -I and -R options.
> >
> > When I do that and I specify a password with '-P'
> (uppercase) then in
> > the registry it's saved as '-p' (lowercase) in the
> service-commandline
> > (ImagePath).
This was fixed in v1.21 of pg_autovacuum.c, That rev is tagged for
beta3, so you should not be seeing this issue unless you actually have
an older version for some reason.
http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_autovacuum/p
g_autovacuum.c.diff?r1=1.20;r2=1.21;f=h
> > Also it removes the quotes I added and I'm not so sure it
> would work
> > the way it's supposed to, without it.
It's not so much that it strips them (that happens automagically), more
that it doesn't re-add them when it writes the command line in the
registry. The attached patch fixes that by simply quoting all options
that may need it.
> > If you add DependOnService (a REG_MULTI_SZ an
> array-like-thingie) and
> > have the name (in this case: pgsql-8.0-beta2-dev3) of a service it
> > depends on, it will not fail to start (it will not even try, as
> > PostgreSQL is not running), when PostgreSQL already failed.
> >
> > Maybe it's an idea to specify it on the commandline (what
> service to
> > depend on).
A -E <service> option is added in the attached patch.
Dave Page
Bruce Momjian [Thu, 2 Dec 2004 22:40:18 +0000 (22:40 +0000)]
> I enclose a short patch to reduce the PGARCH_RESTART_INTERVAL from 60
> seconds to 10 seconds. The original number was plucked from thin air
> some months ago, and I'd like to review that now based upon further
> thought, observation and experience.
>
> This change has little or no effect on performance, since the interval
> is there mainly to avoid repeated respawn attempts if archiver fails at
> startup. Archiver start-up time is very quick, so there is little danger
> of exceeding 10 seconds.
>
> On a busy system, if the archiver does die, then many files can build up
> in the 60 seconds before respawning. That xlog file backlog could take
> some time to clear. This then leaves a larger than normal window of data
> loss for a possibly long period.
>
> It's a minor change only, with no other effect on function.
Simon Riggs
Bruce Momjian [Thu, 2 Dec 2004 22:37:14 +0000 (22:37 +0000)]
Fix for Unicode characters above 0x10000.
John Hansen
Bruce Momjian [Thu, 2 Dec 2004 22:28:22 +0000 (22:28 +0000)]
On win32, there is currently no way to get the equivalent function of
the "ps" argument list on Unix - meaning that there is no way to
identify for example the stats processors or the bgwriter.
This patch adds this functionality, in a bit of a crufty way. It creates
a kernel Event object with the name of what would be in the title. This
can be viewed using for example Process Explorer.
It's been very handy for me during both debugging and using. I haven't
figured a better way, but perhaps someone has one that's less crufty? If
not, here is at least a working patch :-)
Magnus Hagander
Bruce Momjian [Thu, 2 Dec 2004 22:21:12 +0000 (22:21 +0000)]
Attached is a patch that adds the function xml_encode_special_chars to
the xml2 contrib module. It's against 8.0beta4. It's intended for
commit.
Markus Bertheau <twanger@bluetwanger.de>
Bruce Momjian [Thu, 2 Dec 2004 22:14:38 +0000 (22:14 +0000)]
Add Charset WIN1252 support.
Roland Volkmann
Tom Lane [Thu, 2 Dec 2004 21:41:12 +0000 (21:41 +0000)]
Allow libedit to keep its headers in /usr/include/readline/ ... not a
very good practice IMHO, but apparently some people think so.
Bruce Momjian [Thu, 2 Dec 2004 21:04:47 +0000 (21:04 +0000)]
Add documention on ARRAY() function.
David Fetter
Bruce Momjian [Thu, 2 Dec 2004 20:35:45 +0000 (20:35 +0000)]
Add mention of using --disable-rpath with regression test.
Bruce Momjian [Thu, 2 Dec 2004 20:31:17 +0000 (20:31 +0000)]
Prevent pg_autovacuum -D from needing an argument.
Kenneth Marshall
Tom Lane [Thu, 2 Dec 2004 20:04:20 +0000 (20:04 +0000)]
Hack to work around broken linker on older NetBSD/OpenBSD/Irix assumed
that readline must depend on libcurses, but it seems more recent ones
use libtermcap instead. Allow that case.
Bruce Momjian [Thu, 2 Dec 2004 19:38:50 +0000 (19:38 +0000)]
Change Win32 dlerror message to:
return "dynamic loading error";
Bruce Momjian [Thu, 2 Dec 2004 19:37:58 +0000 (19:37 +0000)]
Add for Win32:
> o Improve dlerror() reporting string
Bruce Momjian [Thu, 2 Dec 2004 19:32:57 +0000 (19:32 +0000)]
Add:
> * Allow a warm standby system to also allow read-only queries
>
> This is useful for checking PITR recovery.
>
Tom Lane [Thu, 2 Dec 2004 19:28:49 +0000 (19:28 +0000)]
Disallow the combination VACUUM FULL FREEZE for safety's sake, for the
reasons I outlined in pghackers a few days ago.
Also, undo someone's overly optimistic decision to reduce tuple state
checks from if (...) elog() to Asserts. If I trusted this code more,
I might think it was a good idea to disable these checks in production
installations. But I don't.
Bruce Momjian [Thu, 2 Dec 2004 18:13:47 +0000 (18:13 +0000)]
Add:
> * Fix psql's display of schema information (Neil)
Bruce Momjian [Thu, 2 Dec 2004 18:11:40 +0000 (18:11 +0000)]
Don't bother adding to cflags/cppflags, just set them because configure
handles that, and make solaris debug use no optimization.
Bruce Momjian [Thu, 2 Dec 2004 17:39:54 +0000 (17:39 +0000)]
Wording improvement.
Bruce Momjian [Thu, 2 Dec 2004 17:14:54 +0000 (17:14 +0000)]
Document that btrim()'s second parameter is optional, and defaults to spaces.
Bruce Momjian [Thu, 2 Dec 2004 15:49:25 +0000 (15:49 +0000)]
Update Brazilian FAQ.
Euler Taveira de Oliveira
Bruce Momjian [Thu, 2 Dec 2004 15:32:54 +0000 (15:32 +0000)]
Rework libpq threaded SIGPIPE handling to avoid interference with
calling applications. This is done by blocking sigpipe in the libpq
thread and using sigpending/sigwait to possibily discard any sigpipe we
generated.
Neil Conway [Thu, 2 Dec 2004 06:14:50 +0000 (06:14 +0000)]
Fix a potential free() of string literal in oid2name, per report from
Michael Fuhr. Along the way, fix a bunch of accesses to uninitialized
memory, add a mystrdup() routine and use it to cleanup some code.
Bruce Momjian [Thu, 2 Dec 2004 04:40:37 +0000 (04:40 +0000)]
Add:
>
> * Allow FOR UPDATE queries to do NOWAIT locks
>
Neil Conway [Thu, 2 Dec 2004 04:12:12 +0000 (04:12 +0000)]
This is a little patch to correct the documentation on CVS. The URL for
downloading CVS at cyclic.com site is long defunct, and I changed the text
to not overtly recommend CVS 1.10, a now fairly old version.
Jon Jensen
Bruce Momjian [Thu, 2 Dec 2004 03:46:47 +0000 (03:46 +0000)]
Update Japanese FAQ.
Jun Kuwamura
Tom Lane [Thu, 2 Dec 2004 02:45:07 +0000 (02:45 +0000)]
Teach regex_fixed_prefix() the correct handling of advanced regex
escapes --- they aren't simply quoted characters. Problem noted by
Antti Salmela. Also fix problem with incorrect handling of multibyte
characters when followed by a quantifier.
Tom Lane [Thu, 2 Dec 2004 01:34:18 +0000 (01:34 +0000)]
Make some adjustments to reduce platform dependencies in plan selection.
In particular, there was a mathematical tie between the two possible
nestloop-with-materialized-inner-scan plans for a join (ie, we computed
the same cost with either input on the inside), resulting in a roundoff
error driven choice, if the relations were both small enough to fit in
sort_mem. Add a small cost factor to ensure we prefer materializing the
smaller input. This changes several regression test plans, but with any
luck we will now have more stability across platforms.
Bruce Momjian [Wed, 1 Dec 2004 23:42:26 +0000 (23:42 +0000)]
Allow libpq to build on MS Visual Studio .NET 2003 on Windows XP.
Bruce Momjian [Wed, 1 Dec 2004 22:17:16 +0000 (22:17 +0000)]
Update French FAQ.
Guillaume LELARGE
Tom Lane [Wed, 1 Dec 2004 19:57:49 +0000 (19:57 +0000)]
Fix timestamptz_age() to do calculation in local timezone not GMT, per bug 1332.
Tom Lane [Wed, 1 Dec 2004 19:32:12 +0000 (19:32 +0000)]
Clarify documentation of age() functions.
Tom Lane [Wed, 1 Dec 2004 19:00:56 +0000 (19:00 +0000)]
Change planner to use the current true disk file size as its estimate of
a relation's number of blocks, rather than the possibly-obsolete value
in pg_class.relpages. Scale the value in pg_class.reltuples correspondingly
to arrive at a hopefully more accurate number of rows. When pg_class
contains 0/0, estimate a tuple width from the column datatypes and divide
that into current file size to estimate number of rows. This improved
methodology allows us to jettison the ancient hacks that put bogus default
values into pg_class when a table is first created. Also, per a suggestion
from Simon, make VACUUM (but not VACUUM FULL or ANALYZE) adjust the value
it puts into pg_class.reltuples to try to represent the mean tuple density
instead of the minimal density that actually prevails just after VACUUM.
These changes alter the plans selected for certain regression tests, so
update the expected files accordingly. (I removed join_1.out because
it's not clear if it still applies; we can add back any variant versions
as they are shown to be needed.)
Bruce Momjian [Wed, 1 Dec 2004 17:39:18 +0000 (17:39 +0000)]
Add:
> * Allow ecpg to work with MSVC and BCC
Bruce Momjian [Wed, 1 Dec 2004 17:21:58 +0000 (17:21 +0000)]
Update with Gavin's additions.
Bruce Momjian [Tue, 30 Nov 2004 22:15:21 +0000 (22:15 +0000)]
Remove question mark on COPY CSV fix:
< returns in data?
> returns in data
Bruce Momjian [Tue, 30 Nov 2004 20:00:34 +0000 (20:00 +0000)]
Add \n to end of output for psql \s with no history file name.
This prevents the next psql prompt from showing up on the end of the
last history line.
Bruce Momjian [Tue, 30 Nov 2004 19:42:38 +0000 (19:42 +0000)]
Update Turkish FAQ.
Devrim GUNDUZ
Bruce Momjian [Tue, 30 Nov 2004 19:32:24 +0000 (19:32 +0000)]
Removed:
< * Make log_min_duration_statement output when the duration is reached rather
< than when the statement completes
<
< This prints long queries while they are running, making trouble shooting
< easier. Also, it eliminates the need for log_statement because it
< would now be the same as a log_min_duration_statement of zero.
Bruce Momjian [Tue, 30 Nov 2004 19:01:28 +0000 (19:01 +0000)]
Quote SHELL arguments only on Win32.
Bruce Momjian [Tue, 30 Nov 2004 18:20:35 +0000 (18:20 +0000)]
Add:
> * Make log_min_duration_statement output when the duration is reached rather
> than when the statement completes
>
> This prints long queries while they are running, making trouble shooting
> easier. Also, it eliminates the need for log_statement because it
> would now be the same as a log_min_duration_statement of zero.
Tom Lane [Tue, 30 Nov 2004 06:13:04 +0000 (06:13 +0000)]
Fix readline/libedit selection code to prefer readline over libedit
reliably (ie, regardless of which libraries they depend on). Also
make sure that we don't select headers that obviously belong to the
wrong one of the two libraries. This was discussed back around 4-Sep
but seems to have slipped through the cracks. The header selection
could be checked more closely, perhaps, but let's see if this is good
enough.
Bruce Momjian [Tue, 30 Nov 2004 05:06:33 +0000 (05:06 +0000)]
Update wording:
< you would like to work on an item, please read the developer's FAQ
> you would like to work on an item, please read the Developer's FAQ
Bruce Momjian [Tue, 30 Nov 2004 05:03:47 +0000 (05:03 +0000)]
Updated TODO list description:
9c5
< Last updated: Mon Nov 29 23:33:09 EST 2004
> Last updated: Tue Nov 30 00:03:37 EST 2004
13a10,16
> #A hyphen, "-", marks changes that will appear in the upcoming 8.1 release.#
>
> Bracketed items, "[]", have more detail.
>
> This list contains all known PostgreSQL bugs and feature requests. If
> you would like to work on an item, please read the developer's FAQ
> first.
Bruce Momjian [Tue, 30 Nov 2004 04:33:14 +0000 (04:33 +0000)]
Add:
> * Prevent INET cast to CIDR from droping netmask, SELECT '1.1.1.1'::inet::cidr
Bruce Momjian [Tue, 30 Nov 2004 03:53:00 +0000 (03:53 +0000)]
Add:
> o Allow COPY FROM ... CVS to interpret newlines and carriage
> returns in data?
>
> This would require major refactoring of the copy source code.
Neil Conway [Tue, 30 Nov 2004 03:50:29 +0000 (03:50 +0000)]
Fix a few typos in comments.
Bruce Momjian [Tue, 30 Nov 2004 03:27:10 +0000 (03:27 +0000)]
Add:
> * Improve NLS maintenace of libpgport messages linked onto applications
>
Tom Lane [Mon, 29 Nov 2004 20:11:06 +0000 (20:11 +0000)]
Update plperl to use ereport() not elog() for user-facing messages,
so that they will be translatable. Give messages some semblance of
conformance to the style guide.
Bruce Momjian [Mon, 29 Nov 2004 03:17:30 +0000 (03:17 +0000)]
Add:
<
> * Allow cross-compiling by generating the zic database on the target system
Tom Lane [Mon, 29 Nov 2004 03:05:03 +0000 (03:05 +0000)]
Clean up initdb's error handling so that it prints something more
useful than just \'failed\' when there's a problem. Per gripe from
Chris Albertson.
In an unrelated change, use VACUUM FULL; VACUUM FREEZE; rather than
a single VACUUM FULL FREEZE command, to respond to my worries of a
couple days ago about the reliability of doing this in one go.
Bruce Momjian [Mon, 29 Nov 2004 03:04:31 +0000 (03:04 +0000)]
Update Turkish FAQ.
Devrim GUNDUZ
Bruce Momjian [Mon, 29 Nov 2004 03:01:54 +0000 (03:01 +0000)]
Add comment explaining possible compiler warning:
/*
* Some compilers with throw a warning knowing this test can never be
* true because off_t can't exceed the compared maximum.
*/
if (th->fileLen > MAX_TAR_MEMBER_FILELEN)
die_horribly(AH, modulename, "archive member too large for tar format\n");
Bruce Momjian [Mon, 29 Nov 2004 02:29:28 +0000 (02:29 +0000)]
Add:
> * Auto-vacuum
> o Move into the backend code
> o Scan the buffer cache to find free space or use background writer
> o Use free-space map information to guide refilling
Bruce Momjian [Mon, 29 Nov 2004 01:58:10 +0000 (01:58 +0000)]
Typo fixes.
Euler Taveira de Oliveira
Bruce Momjian [Mon, 29 Nov 2004 01:14:45 +0000 (01:14 +0000)]
Have initdb display relative paths to start postmaster if used to invoke
initdb, and display in a path-native way.
Tom Lane [Sun, 28 Nov 2004 23:49:49 +0000 (23:49 +0000)]
Make pg_dumplo schema-aware. Karel Zak
Tom Lane [Sun, 28 Nov 2004 22:16:31 +0000 (22:16 +0000)]
Avoid scribbling on original parsetree during DECLARE CURSOR. This
prevents problems when the DECLARE is in a portal and is executed
repeatedly, as is possible in v3 protocol. Per analysis by Oliver
Jowett, though I didn't use his patch exactly.
Bruce Momjian [Sun, 28 Nov 2004 05:12:19 +0000 (05:12 +0000)]
Add description:
< information, either by name or offset from UTC
> information, either zone name or offset from UTC
>
> If the TIMESTAMP value is stored with a time zone name, interval
> computations should adjust based on the time zone rules, e.g. adding
> 24 hours to a timestamp would yield a different result from adding one
> day.
>
Bruce Momjian [Sun, 28 Nov 2004 04:56:04 +0000 (04:56 +0000)]
Mega-clarifications from Joachim Wieland.
Peter Eisentraut [Sat, 27 Nov 2004 22:44:15 +0000 (22:44 +0000)]
Work around lack of NLS support in libpgport by making those components
who use it scan the relevant source files for their own catalog. It
creates a bit of duplicate work for translators, but it gets the job done
for now.
Peter Eisentraut [Sat, 27 Nov 2004 21:56:05 +0000 (21:56 +0000)]
Correctly name the Windows operating systems
Peter Eisentraut [Sat, 27 Nov 2004 21:27:08 +0000 (21:27 +0000)]
Update of conformance information to SQL:2003
by Troels Arvin, Simon Riggs, Elein Mustain
Make spelling of SQL standard names uniform.
Tom Lane [Sat, 27 Nov 2004 18:51:08 +0000 (18:51 +0000)]
Fix HAVE_OPTRESET to be HAVE_INT_OPTRESET. Typos spotted by Lorne Sunley.
Bruce Momjian [Sat, 27 Nov 2004 06:02:53 +0000 (06:02 +0000)]
Add web development faq item.
Bruce Momjian [Sat, 27 Nov 2004 05:15:21 +0000 (05:15 +0000)]
Add mention of Cygwin. Update version number.
Bruce Momjian [Sat, 27 Nov 2004 05:03:26 +0000 (05:03 +0000)]
Add to CPPFLAGS/CFLAGS in template files, don't over-ride them.
Tom Lane [Sat, 27 Nov 2004 00:01:02 +0000 (00:01 +0000)]
This adds mention of my latest tweak to the tsearch2/pg_trgm
integration. It is much better to create a word list of unstemmed words
than stemmed ones.
Chris K-L
Tom Lane [Fri, 26 Nov 2004 21:08:35 +0000 (21:08 +0000)]
RelOptInfo.pages should really be declared as BlockNumber, not long.
Tom Lane [Wed, 24 Nov 2004 22:56:54 +0000 (22:56 +0000)]
Install Tcl regex fixes to sync our regex engine with Tcl 8.4.8 (up from
8.4.1). This corrects some curious regex bugs, though not the greediness
issue I was hoping to find a solution for :-(
Tom Lane [Wed, 24 Nov 2004 22:44:07 +0000 (22:44 +0000)]
Our interface code for Spencer's regexp package was checking for regexp
error conditions during regexp compile, but not during regexp execution;
any sort of "can't happen" errors would be treated as no-match instead
of being reported as they should be. Noticed while trying to duplicate
a reported Tcl bug.