OSDN Git Service
Ivailo Monev [Mon, 13 Jan 2020 17:44:29 +0000 (17:44 +0000)]
reuse QDir object in QFactoryLoader::updateDir()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 17:28:10 +0000 (17:28 +0000)]
use plain assignment in QTextStreamPrivate::saveConverterState() and QTextStreamPrivate::saveConverterState()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 17:15:09 +0000 (17:15 +0000)]
replace 0 with Q_NULLPTR in QXmlInputSource, QXmlDefaultHandler, QXmlSimpleReaderPrivate, QXmlSimpleReader and QXmlSimpleReaderPrivate
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 16:59:49 +0000 (16:59 +0000)]
use uninitialized buffer with QT_BUFFSIZE as size in QXmlInputSource::fetchData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 16:47:29 +0000 (16:47 +0000)]
remove unused QXmlInputSourcePrivate member
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 16:32:29 +0000 (16:32 +0000)]
rework internal QTextStream converter state save/restore
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 15:26:40 +0000 (15:26 +0000)]
indent QDBusDemarshaller::toStringList()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 15:26:24 +0000 (15:26 +0000)]
avoid passing QSettings pointer as argument to QLibraryPrivate::isPlugin() and QFactoryLoader::updateDir()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 01:46:47 +0000 (01:46 +0000)]
remove redundant DBUS_TYPE_UNIX_FD checks
DBUS_TYPE_UNIX_FD and DBUS_TYPE_UNIX_FD_AS_STRING are available since
v1.2.16 and v1.5.12 is required now
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 00:54:16 +0000 (00:54 +0000)]
remove BOMs if QTextCodec::ConverterState has QTextCodec::IgnoreHeader flag set
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 00:38:19 +0000 (00:38 +0000)]
sync stub QTextCodec class version with non-stub
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 13 Jan 2020 00:37:33 +0000 (00:37 +0000)]
remove redundant const_cast<> in qobject_cast<>() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 22:22:10 +0000 (22:22 +0000)]
use foreach() for iteration in QPollingFileSystemWatcherEngine::addPaths() and QPollingFileSystemWatcherEngine::removePaths()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 21:54:52 +0000 (21:54 +0000)]
move QFileSystemWatcher initialization from QFileSystemWatcher::addPaths() to QFileSystemWatcherPrivate::init()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 18:46:42 +0000 (18:46 +0000)]
use __PRETTY_FUNCTION__ for Q_FUNC_INFO when compiler is GCC/Clang, __func__ if other
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 17:37:34 +0000 (17:37 +0000)]
remove tmake comments from qobjectdefs header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 17:12:03 +0000 (17:12 +0000)]
use QSettings::NativeFormat as default for QSettings constructed with filename
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 17:03:33 +0000 (17:03 +0000)]
optimize QFileSystemWatcher
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 16:48:56 +0000 (16:48 +0000)]
replace 0 with Q_NULLPTR in QFileSystemWatcherPrivate and QFileSystemWatcher
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 16:04:25 +0000 (16:04 +0000)]
replace _POSIX_MONOTONIC_CLOCK definition with QElapsedTimer::isMonotonic() result checks
in addition to the compile-time check, QElapsedTimer::isMonotonic() does
runtime check via sysconf() and is guarded by QT_NO_CLOCK_MONOTONIC option
definition check
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 15:35:31 +0000 (15:35 +0000)]
make use of qt_error_string() in QSystemError::toString() method and qdlerror() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 15:21:15 +0000 (15:21 +0000)]
update translations [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 03:07:28 +0000 (03:07 +0000)]
set QFSFileEnginePrivate::tried_stat to proper type in QTemporaryFileEngine::open()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 03:06:01 +0000 (03:06 +0000)]
remove redundant int() constructs from qt_error_string() function calls
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 02:39:22 +0000 (02:39 +0000)]
remove redundant condition in QFSFileEnginePrivate::readFdFh()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 02:39:01 +0000 (02:39 +0000)]
mark warning cases in QFSFileEngine as unlikely
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sun, 12 Jan 2020 02:13:44 +0000 (02:13 +0000)]
require D-Bus v1.5.12+ for demarshaling basic types
fixes a crash
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 11 Jan 2020 23:07:24 +0000 (23:07 +0000)]
introduce QT_BUFFSIZE
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 11 Jan 2020 20:41:42 +0000 (20:41 +0000)]
Merge branch 'refileengine'
Ivailo Monev [Sat, 11 Jan 2020 02:29:34 +0000 (02:29 +0000)]
cleanup file engine, notably the Qt resource part
this is fixes QTBUG-11223, I also would like to take it step further
and make the resources requests prefixed with "qrc:/" so that the
check when to use QResourceFileEngine is even more reliable but
that will require backwards incompatible change so it will be done
in future release.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 11 Jan 2020 02:55:23 +0000 (02:55 +0000)]
define QIODEVICE_BUFFERSIZE to value of BUFSIZ from stdio header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 11 Jan 2020 01:48:28 +0000 (01:48 +0000)]
replace 0 with Q_NULLPTR in QThreadPoolThread and QThreadPoolPrivate
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 11 Jan 2020 01:27:36 +0000 (01:27 +0000)]
set error to QFile::CopyError in case of failure in QFile::copy()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Sat, 11 Jan 2020 00:28:27 +0000 (00:28 +0000)]
set result error if lookup by address fails in QHostInfoAgent::fromName()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 23:30:27 +0000 (23:30 +0000)]
optimize toMSecsSinceEpoch_helper() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 21:25:16 +0000 (21:25 +0000)]
set QSharedMemory error from errno in QSharedMemoryPrivate::handle()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 21:01:10 +0000 (21:01 +0000)]
implement QFileSystemEngine::copyFile() for non-Linux platforms
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 16:54:43 +0000 (16:54 +0000)]
add note in which version qFmod() function was introduced [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 16:51:52 +0000 (16:51 +0000)]
replace qFloorF() with qFloor() function call in snapTo26Dot6Grid() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 16:49:41 +0000 (16:49 +0000)]
introduce qFmod() math function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 16:43:30 +0000 (16:43 +0000)]
use expf() in qExp() for float types
it is available since C++ 11
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 16:41:41 +0000 (16:41 +0000)]
replace math with cmath header inclusion in qlocale_tools source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 16:41:23 +0000 (16:41 +0000)]
remove math header inclusion from qrect source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 15:16:46 +0000 (15:16 +0000)]
replace Q_PI with M_PI from math header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 14:57:22 +0000 (14:57 +0000)]
remove unused qFastSin() and qFastCos() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 14:52:19 +0000 (14:52 +0000)]
define _USE_MATH_DEFINES in qmath header
also replace math with qmath header inclusion where the constants are
needed
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 14:40:24 +0000 (14:40 +0000)]
indent qCeil(), qFloor(), qFabs(), qSin(), qCos(), qTan(), qAcos(), qAsin(), qAtan(), qAtan2(), qSqrt(), qLn(), qExp() and qPow() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 04:12:29 +0000 (04:12 +0000)]
remove redundant virtual QEasingCurveFunction::copy() method override
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Fri, 10 Jan 2020 01:12:46 +0000 (01:12 +0000)]
replace hardcodec value with enum in QFile::exists()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 9 Jan 2020 23:25:05 +0000 (23:25 +0000)]
use correct type for flags in QFile::exists() and restore behaviour of QDir::exists() overload
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 9 Jan 2020 02:15:39 +0000 (02:15 +0000)]
remove most std::bad_alloc exceptions handling
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 9 Jan 2020 00:59:01 +0000 (00:59 +0000)]
check type in QFile::exists() and QDir::exists()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Thu, 9 Jan 2020 00:44:04 +0000 (00:44 +0000)]
replace 0 with Q_NULLPTR in QEasingCurve
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 03:26:46 +0000 (03:26 +0000)]
update translations [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 02:30:21 +0000 (02:30 +0000)]
update Shell scripts and .cmake files copyright
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 02:23:15 +0000 (02:23 +0000)]
do not reset KATIE_GIT variable from katie_git_checkout() macro if hash cannot be obtained
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 02:11:07 +0000 (02:11 +0000)]
update moc utility
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 02:10:44 +0000 (02:10 +0000)]
remove qvariant and qbitarray from bootstrap sources array
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 02:00:06 +0000 (02:00 +0000)]
remove unused USE_LEXEM_STORE definition and conditionals from moc source files
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 01:50:36 +0000 (01:50 +0000)]
remove redundant qdatetime header inclusion from moc source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 01:31:23 +0000 (01:31 +0000)]
mark warning, null and incompatible signal/slot QObject cases as unlikely
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 01:13:09 +0000 (01:13 +0000)]
use loop-local variables in qt_qFindChildren_helper() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 01:12:41 +0000 (01:12 +0000)]
replace 0 with Q_NULLPTR in qt_qFindChild_helper()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 00:34:36 +0000 (00:34 +0000)]
remove accidently added QDir test Makefile file
Ivailo Monev [Wed, 8 Jan 2020 00:32:32 +0000 (00:32 +0000)]
update copyright of recently added tests
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 00:22:47 +0000 (00:22 +0000)]
replace QHash with QSet where applicable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Wed, 8 Jan 2020 00:04:51 +0000 (00:04 +0000)]
add assert to qChecksum32()
the function is stub for bootstrapped build only and should not be used in
that case
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 23:45:59 +0000 (23:45 +0000)]
use http/www service port to test QTcpSocket constructing in tst_QIODevice::constructing_QTcpSocket()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 22:59:01 +0000 (22:59 +0000)]
Revert "avoid temporaries in QDir::mkdir(), QDir::rmdir(), QDir::mkpath() and QDir::rmpath()"
This reverts commit
b0112afc64848f840b6daf37ef51657b77027c13.
Ivailo Monev [Tue, 7 Jan 2020 22:42:25 +0000 (22:42 +0000)]
mark gethostname() success as likely in QHostInfo::localHostName()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 18:53:21 +0000 (18:53 +0000)]
correct localtime_r() check in QDateTime::currentDateTime()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 18:44:32 +0000 (18:44 +0000)]
update README [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 18:44:17 +0000 (18:44 +0000)]
make function check notes consistent
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 18:04:31 +0000 (18:04 +0000)]
obtain getpwnam_r() buffer size via sysconf() in qt_tildeExpansion() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 17:59:32 +0000 (17:59 +0000)]
check for getpwnam_r() function during configuration
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 17:40:17 +0000 (17:40 +0000)]
check for localtime_r() and gmtime_r() functions during configuration
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 16:54:49 +0000 (16:54 +0000)]
inline qstricmp()/qstrnicmp() to strcasecmp()/strncasecmp() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 16:04:59 +0000 (16:04 +0000)]
introduce qChecksum32()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 15:48:31 +0000 (15:48 +0000)]
remove unused report_error() function
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 15:45:17 +0000 (15:45 +0000)]
remove redundant scoping in QDBusMetaType::typeToSignature()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 15:44:44 +0000 (15:44 +0000)]
replace 0 with Q_NULLPTR in QDBusMetaType::typeToSignature()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 15:17:16 +0000 (15:17 +0000)]
copy logic in katie_require_function() macro from katie_optional_function() to avoid definitions for required functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 15:14:55 +0000 (15:14 +0000)]
correct loop expression in createFileFromTemplate()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 14:35:25 +0000 (14:35 +0000)]
add note that check_function_exists() and check_symbol_exists() cache results
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 14:27:48 +0000 (14:27 +0000)]
check for getpwuid_r() and getgrgid_r() functions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 04:59:52 +0000 (04:59 +0000)]
use QTime instead of QDateTime as random seed
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 03:31:24 +0000 (03:31 +0000)]
fix QFileSystemEngine::createDirectory() and QFileSystemEngine::removeDirectory()
the life-time of the string created by QFile::encodeName() was probably
optimized out by the compiler causing the variables of char array type to
contain invalid data
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 02:52:55 +0000 (02:52 +0000)]
pass size of string to QString::fromLocal8Bit() where known
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Tue, 7 Jan 2020 02:52:01 +0000 (02:52 +0000)]
avoid temporaries in QDir::mkdir(), QDir::rmdir(), QDir::mkpath() and QDir::rmpath()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 22:08:55 +0000 (22:08 +0000)]
avoid temporaries in QComboBoxPrivate::emitActivated() and QComboBoxPrivate::_q_emitHighlighted()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 21:58:15 +0000 (21:58 +0000)]
use signle variable assignment in QComboBox::findData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 21:53:38 +0000 (21:53 +0000)]
remove supposedly fast scrolling case from QComboBoxPrivateScroller
the timer has 100ms interval so emiting three signals in a row and checking
for conditions on mouse events is sub-optimal
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 19:09:33 +0000 (19:09 +0000)]
use foreach() for iteration in QDBusMessagePrivate::makeLocal()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 17:14:41 +0000 (17:14 +0000)]
return if writing function failed in QSettingsPrivate::write()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 16:43:23 +0000 (16:43 +0000)]
use foreach() for iteration in QFormBuilderExtra::applyBuddy()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 16:38:57 +0000 (16:38 +0000)]
replze 0 with Q_NULLPTR in QFormBuilderExtra::applyBuddy()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 16:33:20 +0000 (16:33 +0000)]
use foreach() for iteration in QAbstractFormBuilder::setupColorGroup()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 16:32:55 +0000 (16:32 +0000)]
avoid temporary in QAbstractFormBuilder::computeProperties()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 16:21:13 +0000 (16:21 +0000)]
remove redundant QDir class forward declaration from textbuilder_p header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
Ivailo Monev [Mon, 6 Jan 2020 16:09:02 +0000 (16:09 +0000)]
replace Q_ASSERT(0) with Q_ASSERT(false)
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>