OSDN Git Service
Bruce Momjian [Mon, 21 Feb 2011 14:15:09 +0000 (09:15 -0500)]
Update docs about new role privileges reference, per Alvaro.
Itagaki Takahiro [Mon, 21 Feb 2011 07:26:58 +0000 (16:26 +0900)]
Fix pg_server_to_client, that was broken in the previous commit.
Itagaki Takahiro [Mon, 21 Feb 2011 05:08:04 +0000 (14:08 +0900)]
Add ENCODING option to COPY TO/FROM and file_fdw.
File encodings can be specified separately from client encoding.
If not specified, client encoding is used for backward compatibility.
Cases when the encoding doesn't match client encoding are slower
than matched cases because we don't have conversion procs for other
encodings. Performance improvement would be be a future work.
Original patch by Hitoshi Harada, and modified by me.
Bruce Momjian [Mon, 21 Feb 2011 03:20:57 +0000 (22:20 -0500)]
Merge two documentation permission chapters into a single chapter.
Tom Lane [Sun, 20 Feb 2011 19:55:07 +0000 (14:55 -0500)]
Minor logic fix for new levenshtein implementation.
Alexander Korotkov
Tom Lane [Sun, 20 Feb 2011 19:06:59 +0000 (14:06 -0500)]
Add contrib/file_fdw foreign-data wrapper for reading files via COPY.
This is both very useful in its own right, and an important test case
for the core FDW support.
This commit includes a small refactoring of copy.c to expose its option
checking code as a separately callable function. The original patch
submission duplicated hundreds of lines of that code, which seemed pretty
unmaintainable.
Shigeru Hanada, reviewed by Itagaki Takahiro and Tom Lane
Tom Lane [Sun, 20 Feb 2011 05:17:18 +0000 (00:17 -0500)]
Implement an API to let foreign-data wrappers actually be functional.
This commit provides the core code and documentation needed. A contrib
module test case will follow shortly.
Shigeru Hanada, Jan Urbanski, Heikki Linnakangas
Bruce Momjian [Sun, 20 Feb 2011 05:01:08 +0000 (00:01 -0500)]
Adjust documentation wording of window function ORDER BY to not mention
avg() because it was inaccurate.
Bruce Momjian [Sun, 20 Feb 2011 00:00:19 +0000 (19:00 -0500)]
Documentation update for UTF16 surrogate pairs in UTF8 encoding.
Marko Kreen
Bruce Momjian [Sat, 19 Feb 2011 23:21:03 +0000 (18:21 -0500)]
Document that an SQL-standard-compliant query that expects a unique row
from information_schema.referential_constraints might return several in
Postgres because we allow duplicate-named constraints in the same
schema.
Peter Eisentraut [Sat, 19 Feb 2011 14:52:24 +0000 (16:52 +0200)]
Invalidate PL/Python functions with composite type argument when the
type changes.
The invalidation will cause the type information to be refetched, and
everything will work.
Jan Urbański, reviewed by Alex Hunsaker
Bruce Momjian [Sat, 19 Feb 2011 13:14:32 +0000 (08:14 -0500)]
Initialize variable to quiet compiler.
Peter Eisentraut [Sat, 19 Feb 2011 06:54:58 +0000 (08:54 +0200)]
Set psql client encoding from locale by default
Add a new libpq connection option client_encoding (which includes the
existing PGCLIENTENCODING environment variable), which besides an
encoding name accepts a special value "auto" that tries to determine
the encoding from the locale in the client's environment, using the
mechanisms that have been in use in initdb.
psql sets this new connection option to "auto" when running from a
terminal and not overridden by setting PGCLIENTENCODING.
original code by Heikki Linnakangas, with subsequent contributions by
Jaime Casanova, Peter Eisentraut, Stephen Frost, Ibrar Ahmed
Tom Lane [Sat, 19 Feb 2011 05:06:18 +0000 (00:06 -0500)]
Create the catalog infrastructure for foreign-data-wrapper handlers.
Add a fdwhandler column to pg_foreign_data_wrapper, plus HANDLER options
in the CREATE FOREIGN DATA WRAPPER and ALTER FOREIGN DATA WRAPPER commands,
plus pg_dump support for same. Also invent a new pseudotype fdw_handler
with properties similar to language_handler.
This is split out of the "FDW API" patch for ease of review; it's all stuff
we will certainly need, regardless of any other details of the FDW API.
FDW handler functions will not actually get called yet.
In passing, fix some omissions and infelicities in foreigncmds.c.
Shigeru Hanada, Jan Urbanski, Heikki Linnakangas
Bruce Momjian [Sat, 19 Feb 2011 04:23:52 +0000 (23:23 -0500)]
Improve text search prefix doc addition.
Bruce Momjian [Sat, 19 Feb 2011 03:39:17 +0000 (22:39 -0500)]
Document that text search comparisons happen after text search
configuration rules.
Erik Rijkers
Tom Lane [Fri, 18 Feb 2011 19:05:42 +0000 (14:05 -0500)]
Un-break building with BTREE_BUILD_STATS.
This has been broken for awhile, but not clear it's worth back-patching.
Euler Taveira de Oliveira
Tom Lane [Fri, 18 Feb 2011 18:11:45 +0000 (13:11 -0500)]
Fix parallel pg_restore to handle comments on POST_DATA items correctly.
The previous coding would try to process all SECTION_NONE items in the
initial sequential-restore pass, which failed if they were dependencies of
not-yet-restored items. Fix by postponing such items into the parallel
processing pass once we have skipped any non-PRE_DATA item.
Back-patch into 9.0; the original parallel-restore coding in 8.4 did not
have this bug, so no need to change it.
Report and diagnosis by Arnd Hannemann.
Tom Lane [Fri, 18 Feb 2011 16:55:57 +0000 (11:55 -0500)]
One more hack to make contrib upgrades from 9.0 match fresh 9.1 installs.
intarray and tsearch2 both reference core support functions in their GIN
opclasses, and the signatures of those functions changed for 9.1. We added
backwards-compatible pg_proc entries for the functions in order to allow
9.0 dump files to be restored at all, but that hack leaves the opclasses
pointing at pg_proc entries different from what they'd point to if the
contrib modules were installed fresh in 9.1. To forestall any possibility
of future problems, fix the opclasses to match fresh installs via the
expedient of direct UPDATEs on pg_amproc in the update-from-unpackaged
scripts. (Yech ... but the alternatives are worse, or require far more
effort than seems justified right now.)
Note: updating pg_amproc is sufficient because there will be no pg_depend
entries corresponding to these dependencies, since the referenced functions
are all pinned.
Alvaro Herrera [Fri, 18 Feb 2011 15:47:48 +0000 (12:47 -0300)]
Use $INDENT instead of `which` to find the indent binary
Per discussion after my commit o yesterday.
Simon Riggs [Fri, 18 Feb 2011 15:07:26 +0000 (15:07 +0000)]
Make a hard state change from catchup to streaming mode.
More useful state change for monitoring purposes, plus a
required change for synchronous replication patch.
Simon Riggs [Fri, 18 Feb 2011 11:31:49 +0000 (11:31 +0000)]
Separate messages for standby replies and hot standby feedback.
Allow messages to be sent at different times, and greatly reduce
the frequency of hot standby feedback. Refactor to allow additional
message types.
Magnus Hagander [Fri, 18 Feb 2011 10:59:57 +0000 (11:59 +0100)]
Properly initialize variables
Kevin Grittner
Michael Meskes [Fri, 18 Feb 2011 10:16:16 +0000 (11:16 +0100)]
Applied a patch by Zoltán Böszörményi that makes ecpg's parser accept dynamic cursornames even in WHERE CURRENT OF clauses.
Itagaki Takahiro [Fri, 18 Feb 2011 05:29:40 +0000 (14:29 +0900)]
Fix an uninitialized field in DR_copy.
Shigeru HANADA
Itagaki Takahiro [Fri, 18 Feb 2011 05:04:34 +0000 (14:04 +0900)]
Add transaction-level advisory locks.
They share the same locking namespace with the existing session-level
advisory locks, but they are automatically released at the end of the
current transaction and cannot be released explicitly via unlock
functions.
Marko Tiikkaja, reviewed by me.
Alvaro Herrera [Fri, 18 Feb 2011 01:11:50 +0000 (22:11 -0300)]
Convert Postgres arrays to Perl arrays on PL/perl input arguments
More generally, arrays are turned in Perl array references, and row and
composite types are turned into Perl hash references. This is done
recursively, in a way that's natural to every Perl programmer.
To avoid a backwards compatibility hit, the string representation of
each structure is also available if the function requests it.
Authors: Alexey Klyukin and Alex Hunsaker.
Some code cleanups by me.
Alvaro Herrera [Thu, 17 Feb 2011 19:40:13 +0000 (16:40 -0300)]
pgindent run on plperl.c
Alvaro Herrera [Thu, 17 Feb 2011 19:37:47 +0000 (16:37 -0300)]
Use $INDENT rather than indent throughout the pgindent code
This allows the user to change the path to be used more easily.
Also, change URL in README.
Tom Lane [Fri, 18 Feb 2011 00:00:49 +0000 (19:00 -0500)]
Fix tsmatchsel() to account properly for null rows.
ts_typanalyze.c computes MCE statistics as fractions of the non-null rows,
which seems fairly reasonable, and anyway changing it in released versions
wouldn't be a good idea. But then ts_selfuncs.c has to account for that.
Failure to do so results in overestimates in columns with a significant
fraction of null documents. Back-patch to 8.4 where this stuff was
introduced.
Jesper Krogh
Tom Lane [Thu, 17 Feb 2011 23:11:28 +0000 (18:11 -0500)]
Fix upgrade of contrib/xml2 from 9.0.
Update script was being sloppy about two functions that have been changed
since 9.0.
Tom Lane [Thu, 17 Feb 2011 22:45:09 +0000 (17:45 -0500)]
Fix upgrade of contrib/intarray and contrib/unaccent from 9.0.
Take care of a couple of discrepancies between what you get from a fresh
install and what the first-draft update-from-unpackaged scripts produced.
Tom Lane [Thu, 17 Feb 2011 21:37:34 +0000 (16:37 -0500)]
Fix upgrade of contrib/btree_gist from 9.0.
The initial version of the update-from-unpackaged script neglected to
include the <> operators that were added to the opclasses during 9.1.
To make this script produce the same final state as the regular install
script, use the same ALTER OPERATOR FAMILY trick as in pg_trgm.
Robert Haas [Thu, 17 Feb 2011 21:03:28 +0000 (16:03 -0500)]
Add client_hostname field to pg_stat_activity.
Peter Eisentraut, reviewed by Steve Singer, Alvaro Herrera, and me.
Robert Haas [Thu, 17 Feb 2011 21:00:23 +0000 (16:00 -0500)]
Prevent possible compiler warnings.
Simon Riggs reports that rnode.dbNode and rnode.spcNode were
generating unused variable warnings on gcc 4.4.3 with CFLAGS=-O1
Bruce Momjian [Thu, 17 Feb 2011 20:57:03 +0000 (15:57 -0500)]
Typo fix
Erik Rijkers
Tom Lane [Thu, 17 Feb 2011 20:03:30 +0000 (15:03 -0500)]
Fix contrib/pg_trgm to have smoother updates from 9.0.
Take care of some loose ends in the update-from-unpackaged script, and
apply some ugly hacks to ensure that it produces the same catalog state
as the fresh-install script. Per discussion, this seems like a safer
plan than having two different catalog states that both call themselves
"pg_trgm 1.0", even if it's not immediately clear that the subtle
differences would ever matter.
Also, fix the stub function gin_extract_trgm() so that it works instead
of just bleating. Needed because this function will get called during a
regular dump and reload, if there are any indexes using its opclass.
The user won't have an opportunity to update the extension till later,
so telling him to do so is unhelpful.
Bruce Momjian [Thu, 17 Feb 2011 19:24:14 +0000 (14:24 -0500)]
Remove doc mention about read committed in upsert example.
Bruce Momjian [Thu, 17 Feb 2011 18:36:36 +0000 (13:36 -0500)]
Document that plpgsql upsert example can fail if insert triggers return
unique exception, or if not used in read committed transaction mode.
Bruce Momjian [Thu, 17 Feb 2011 17:37:13 +0000 (12:37 -0500)]
In documentation example, use concat_values() instead of concat()
because concat() is a built-in function.
Erik Rijkers
Robert Haas [Thu, 17 Feb 2011 15:29:42 +0000 (10:29 -0500)]
Add some words of caution to elog.c.
Stephen Frost, somewhat rewritten by me
Robert Haas [Thu, 17 Feb 2011 13:07:31 +0000 (08:07 -0500)]
Typo fixes.
Thom Brown
Robert Haas [Thu, 17 Feb 2011 11:39:13 +0000 (06:39 -0500)]
Remove rule to build sepgsql-regtest.pp.
Instead, document how to build it manually.
Per discussion. KaiGai Kohei, with some wordsmithing by me.
Tom Lane [Thu, 17 Feb 2011 00:53:20 +0000 (19:53 -0500)]
Fix blatantly uninitialized variable in recent commit.
Doesn't anybody around here pay attention to compiler warnings?
Tom Lane [Thu, 17 Feb 2011 00:24:45 +0000 (19:24 -0500)]
Fix bogus test for hypothetical indexes in get_actual_variable_range().
That function was supposing that indexoid == 0 for a hypothetical index,
but that is not likely to be true in any non-toy implementation of an index
adviser, since assigning a fake OID is the only way to know at EXPLAIN time
which hypothetical index got selected. Fix by adding a flag to
IndexOptInfo to mark hypothetical indexes. Back-patch to 9.0 where
get_actual_variable_range() was added.
Gurjeet Singh
Tom Lane [Wed, 16 Feb 2011 22:24:06 +0000 (17:24 -0500)]
Add backwards-compatible declarations of some core GIN support functions.
These are needed to support reloading dumps of 9.0 installations containing
contrib/intarray or contrib/tsearch2. Since not only regular dump/reload
but binary upgrade would fail, it seems worth the trouble to carry these
stubs for awhile. Note that the contrib opclasses referencing these
functions will still work fine, since GIN doesn't actually pay any
attention to the declared signature of a support function.
Peter Eisentraut [Wed, 16 Feb 2011 21:14:38 +0000 (23:14 +0200)]
Also process psqlrc when running psql -l
This was previously not very useful, but with many people customizing
the linestyle, it is nice for a consistent appearance.
Peter Eisentraut [Wed, 16 Feb 2011 21:06:36 +0000 (23:06 +0200)]
Better support for thread-support flag detection with clang
When testing the stderr produced by various thread-support flags, also
run a compilation in addition to a link, because clang warns on
certain flags when compiling but not when linking.
Peter Eisentraut [Wed, 16 Feb 2011 20:19:29 +0000 (22:19 +0200)]
Fix for warnings-free compilation with Python 3.2
The first argument of PyEval_EvalCode() was changed from PyCodeObject*
to PyObject* because of PEP 384.
Bruce Momjian [Wed, 16 Feb 2011 20:16:57 +0000 (15:16 -0500)]
In pg_upgrade, no need to initialize global struct values; they are
always zeros. Also no need to free memory before we exit.
Simon Riggs [Wed, 16 Feb 2011 19:29:37 +0000 (19:29 +0000)]
Hot Standby feedback for avoidance of cleanup conflicts on standby.
Standby optionally sends back information about oldestXmin of queries
which is then checked and applied to the WALSender's proc->xmin.
GetOldestXmin() is modified slightly to agree with GetSnapshotData(),
so that all backends on primary include WALSender within their snapshots.
Note this does nothing to change the snapshot xmin on either master or
standby. Feedback piggybacks on the standby reply message.
vacuum_defer_cleanup_age is no longer used on standby, though parameter
still exists on primary, since some use cases still exist.
Simon Riggs, review comments from Fujii Masao, Heikki Linnakangas, Robert Haas
Tom Lane [Wed, 16 Feb 2011 17:39:45 +0000 (12:39 -0500)]
Make a no-op ALTER EXTENSION UPDATE give just a NOTICE, not ERROR.
This seems a bit more user-friendly.
Alvaro Herrera [Wed, 16 Feb 2011 17:06:17 +0000 (14:06 -0300)]
Cleanup ClusterInfo initialization in pg_upgrade
Robert Haas [Wed, 16 Feb 2011 15:24:50 +0000 (10:24 -0500)]
WAL receiver shouldn't try to send a reply when dying.
Per report from, and discussion with, Fujii Masao.
Tom Lane [Wed, 16 Feb 2011 06:52:04 +0000 (01:52 -0500)]
Add FOREACH IN ARRAY looping to plpgsql.
(I'm not entirely sure that we've finished bikeshedding the syntax details,
but the functionality seems OK.)
Pavel Stehule, reviewed by Stephen Frost and Tom Lane
Robert Haas [Wed, 16 Feb 2011 02:28:48 +0000 (21:28 -0500)]
pg_ctl promote
Fujii Masao, reviewed by Robert Haas, Stephen Frost, and Magnus Hagander.
Itagaki Takahiro [Wed, 16 Feb 2011 02:19:11 +0000 (11:19 +0900)]
Export the external file reader used in COPY FROM as APIs.
They are expected to be used by extension modules like file_fdw.
There are no user-visible changes.
Itagaki Takahiro
Reviewed and tested by Kevin Grittner and Noah Misch.
Bruce Momjian [Wed, 16 Feb 2011 00:01:33 +0000 (19:01 -0500)]
Fix bug in 9.1 pg_upgrade processing of old/new relations; adjust debug
output.
Tom Lane [Tue, 15 Feb 2011 23:09:41 +0000 (18:09 -0500)]
Fix corner case for binary upgrade: extension functions in pg_catalog.
Normally, pg_dump summarily excludes functions in pg_catalog from
consideration. However, some extensions may create functions in pg_catalog
(adminpack already does that, and extensions for procedural languages will
likely do it too). In binary-upgrade mode, we have to dump such functions,
or the extension will be incomplete after upgrading. Per experimentation
with adminpack.
Alvaro Herrera [Tue, 15 Feb 2011 22:52:32 +0000 (19:52 -0300)]
Make pg_upgrade compile again
Tom Lane [Tue, 15 Feb 2011 20:49:54 +0000 (15:49 -0500)]
Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.
Recent releases had a check on rel->rd_refcnt in heap_drop_with_catalog,
but failed to cover the possibility of pending trigger events at DROP time.
(Before 8.4 we didn't even check the refcnt.) When the trigger events were
eventually fired, you'd get "could not open relation with OID nnn" errors,
as in recent report from strk. Better to throw a suitable error when the
DROP is attempted.
Also add a similar check in DROP INDEX.
Back-patch to all supported branches.
Bruce Momjian [Tue, 15 Feb 2011 20:00:07 +0000 (15:00 -0500)]
Adjust pg_upgrade error message, array freeing, and add error check.
Tom Lane [Tue, 15 Feb 2011 19:21:45 +0000 (14:21 -0500)]
Bring hstore's comment into line with style of other contrib comments.
All the other ones that are primarily a new datatype say "data type for
<purpose>", so make this one similar.
Tom Lane [Tue, 15 Feb 2011 18:27:03 +0000 (13:27 -0500)]
Fix obsolete comment.
Comment about MaxAllocSize was not updated when the TOAST-header macros
were replaced in 8.3 "varvarlena" changes. Per report from Frederik Ramm.
Robert Haas [Tue, 15 Feb 2011 17:02:53 +0000 (12:02 -0500)]
Assorted corrections to the patch to add WAL receiver replies.
Per reports from Fujii Masao.
Robert Haas [Tue, 15 Feb 2011 13:00:04 +0000 (08:00 -0500)]
Rename max_predicate_locks_per_transaction.
The new name, max_pred_locks_per_transaction, is shorter.
Kevin Grittner, per discussion.
Peter Eisentraut [Mon, 14 Feb 2011 19:52:32 +0000 (21:52 +0200)]
Allow make check in PL directories
Also add make check-world target, and refactor pg_regress invocation
code in makefiles a bit.
Robert Haas [Tue, 15 Feb 2011 04:17:35 +0000 (23:17 -0500)]
Avoid a few more SET DATA TYPE table rewrites.
When the new type is an unconstrained domain over the old type, we don't
need to rewrite the table.
Noah Misch and Robert Haas
Robert Haas [Tue, 15 Feb 2011 03:37:37 +0000 (22:37 -0500)]
Delete stray word from comment.
Tom Lane [Tue, 15 Feb 2011 01:59:42 +0000 (20:59 -0500)]
Rethink naming of contrib/intagg extension.
Initially it was called int_aggregate after the old SQL file, but since
the documentation just says "intagg" and that's also the directory name,
let's conform to that instead.
Simon Riggs [Tue, 15 Feb 2011 00:59:29 +0000 (00:59 +0000)]
Additional required docs for pg_constraint catalog entry
Noted by Bernd Helmle
Simon Riggs [Tue, 15 Feb 2011 00:51:39 +0000 (00:51 +0000)]
PITR can stop at a named restore point when recovery target = time
though must not update the last transaction timestamp.
Plus comment and message cleanup for recent named restore point.
Fujii Masao, minor changes by me
Tom Lane [Tue, 15 Feb 2011 00:45:46 +0000 (19:45 -0500)]
Fix MSVC build scripts for recent extension-related changes.
Untested, but we'll soon see if the buildfarm likes this.
Tom Lane [Mon, 14 Feb 2011 21:07:00 +0000 (16:07 -0500)]
Rearrange extension-related views as per recent discussion.
The original design of pg_available_extensions did not consider the
possibility of version-specific control files. Split it into two views:
pg_available_extensions shows information that is generic about an
extension, while pg_available_extension_versions shows all available
versions together with information that could be version-dependent.
Also, add an SRF pg_extension_update_paths() to assist in checking that
a collection of update scripts provide sane update path sequences.
Tom Lane [Mon, 14 Feb 2011 17:32:42 +0000 (12:32 -0500)]
Small improvements to external-projects documentation.
Simon Riggs [Tue, 15 Feb 2011 00:08:15 +0000 (00:08 +0000)]
Add version-sensitive SQL for psql when constraints NOT VALID
Bug report and fix by Andres Freund
Tom Lane [Mon, 14 Feb 2011 06:10:44 +0000 (01:10 -0500)]
Fix obsolete references to old-style contrib installation methods.
Tom Lane [Mon, 14 Feb 2011 04:42:13 +0000 (23:42 -0500)]
Remove no-longer-needed special case hacks in MSVC build scripts.
Tom Lane [Mon, 14 Feb 2011 04:33:18 +0000 (23:33 -0500)]
More fixups for "unpackaged" conversion scripts.
Tom Lane [Mon, 14 Feb 2011 03:53:00 +0000 (22:53 -0500)]
Assorted fixups for "unpackaged" conversion scripts.
From first pass of testing. Notably, there seems to be no need for
adminpack--unpackaged--1.0.sql because none of the objects that the
old module creates would ever be dumped by pg_dump anyway (they are
all in pg_catalog).
Tom Lane [Mon, 14 Feb 2011 02:24:14 +0000 (21:24 -0500)]
Avoid use of CREATE OR REPLACE FUNCTION in extension installation files.
It was never terribly consistent to use OR REPLACE (because of the lack of
comparable functionality for data types, operators, etc), and
experimentation shows that it's now positively pernicious in the extension
world. We really want a failure to occur if there are any conflicts, else
it's unclear what the extension-ownership state of the conflicted object
ought to be. Most of the time, CREATE EXTENSION will fail anyway because
of conflicts on other object types, but an extension defining only
functions can succeed, with bad results.
Tom Lane [Mon, 14 Feb 2011 01:06:41 +0000 (20:06 -0500)]
Convert contrib modules to use the extension facility.
This isn't fully tested as yet, in particular I'm not sure that the
"foo--unpackaged--1.0.sql" scripts are OK. But it's time to get some
buildfarm cycles on it.
sepgsql is not converted to an extension, mainly because it seems to
require a very nonstandard installation process.
Dimitri Fontaine and Tom Lane
Tom Lane [Sun, 13 Feb 2011 18:38:05 +0000 (13:38 -0500)]
Support replacing MODULE_PATHNAME during extension script file execution.
This avoids the need to find a way to make PGXS' .sql.in-to-.sql rule
insert the right thing. We'll just deprecate use of that hack for
extensions.
Tom Lane [Sun, 13 Feb 2011 18:03:41 +0000 (13:03 -0500)]
Change the naming convention for extension files to use double dashes.
This allows us to have an unambiguous rule for deconstructing the names
of script files and secondary control files, without having to forbid
extension and version names from containing any dashes. We do have to
forbid them from containing double dashes or leading/trailing dashes,
but neither restriction is likely to bother anyone in practice.
Per discussion, this seems like a better solution overall than the
original design.
Bruce Momjian [Sun, 13 Feb 2011 14:29:01 +0000 (09:29 -0500)]
Clarify documentation for libpq's PQescapeBytea to mention the new hex
format.
Modify PQescapeStringConn() docs to be consisent with other escaping
functions.
Add mention problems with pre-9.0 versions of libpq using not understanding
bytea hex format to the 9.0 release notes.
Backpatch to 9.0 docs.
Bruce Momjian [Sun, 13 Feb 2011 05:17:55 +0000 (00:17 -0500)]
Back out libpq doc change; not ready yet.
Bruce Momjian [Sun, 13 Feb 2011 05:14:08 +0000 (00:14 -0500)]
Fix reverse 'if' test in path_is_relative_and_below_cwd(), per Tom.
Tom Lane [Sat, 12 Feb 2011 21:40:41 +0000 (16:40 -0500)]
Refactor ALTER EXTENSION UPDATE to have cleaner multi-step semantics.
This change causes a multi-step update sequence to behave exactly as if the
updates had been commanded one at a time, including updating the "requires"
dependencies afresh at each step. The initial implementation took the
shortcut of examining only the final target version's "requires" and
changing the catalog entry but once. But on reflection that's a bad idea,
since it could lead to executing old update scripts under conditions
different than they were designed/tested for. Better to expend a few extra
cycles and avoid any surprises.
In the same spirit, if a CREATE EXTENSION FROM operation involves applying
a series of update files, it will act as though the CREATE had first been
done using the initial script's target version and then the additional
scripts were invoked with ALTER EXTENSION UPDATE.
I also removed the restriction about not changing encoding in secondary
control files. The new rule is that a script is assumed to be in whatever
encoding the control file(s) specify for its target version. Since this
reimplementation causes us to read each intermediate version's control
file, there's no longer any uncertainty about which encoding setting would
get applied.
Bruce Momjian [Sat, 12 Feb 2011 14:47:51 +0000 (09:47 -0500)]
Properly handle Win32 paths of 'E:abc', which can be either absolute or
relative, by creating a function path_is_relative_and_below_cwd() to
check for specific requirements. It is unclear if this fixes a security
problem or not but the new code is more robust.
Peter Eisentraut [Sat, 12 Feb 2011 13:54:13 +0000 (15:54 +0200)]
DDL support for collations
- collowner field
- CREATE COLLATION
- ALTER COLLATION
- DROP COLLATION
- COMMENT ON COLLATION
- integration with extensions
- pg_dump support for the above
- dependency management
- psql tab completion
- psql \dO command
Robert Haas [Sat, 12 Feb 2011 13:27:55 +0000 (08:27 -0500)]
Teach ALTER TABLE .. SET DATA TYPE to avoid some table rewrites.
When the old type is binary coercible to the new type and the using
clause does not change the column contents, we can avoid a full table
rewrite, though any indexes on the affected columns will still need
to be rebuilt. This applies, for example, when changing a varchar
column to be of type text.
The prior coding assumed that the set of operations that force a
rewrite is identical to the set of operations that must be propagated
to tables making use of the affected table's rowtype. This is
no longer true: even though the tuples in those tables wouldn't
need to be modified, the data type change invalidate indexes built
using those composite type columns. Indexes on the table we're
actually modifying can be invalidated too, of course, but the
existing machinery is sufficient to handle that case.
Along the way, add some debugging messages that make it possible
to understand what operations ALTER TABLE is actually performing
in these cases.
Noah Misch and Robert Haas
Tom Lane [Sat, 12 Feb 2011 03:53:43 +0000 (22:53 -0500)]
Clean up installation directory choices for extensions.
Arrange for the control files to be in $SHAREDIR/extension not
$SHAREDIR/contrib, since we're generally trying to deprecate the term
"contrib" and this is a once-in-many-moons opportunity to get rid of it in
install paths. Fix PGXS to install the $EXTENSION file into that directory
no matter what MODULEDIR is set to; a nondefault MODULEDIR should only
affect the script and secondary extension files. Fix the control file
directory parameter to be interpreted relative to $SHAREDIR, to avoid a
surprising disconnect between how you specify that and what you set
MODULEDIR to.
Per discussion with David Wheeler.
Tom Lane [Sat, 12 Feb 2011 02:25:20 +0000 (21:25 -0500)]
Add support for multiple versions of an extension and ALTER EXTENSION UPDATE.
This follows recent discussions, so it's quite a bit different from
Dimitri's original. There will probably be more changes once we get a bit
of experience with it, but let's get it in and start playing with it.
This is still just core code. I'll start converting contrib modules
shortly.
Dimitri Fontaine and Tom Lane
Alvaro Herrera [Fri, 11 Feb 2011 22:42:15 +0000 (19:42 -0300)]
Fix comment recently obsoleted
Robert Haas [Fri, 11 Feb 2011 21:57:58 +0000 (16:57 -0500)]
Allow tab-completion of :variable even as first word on a line.
Christoph Berg
Robert Haas [Fri, 11 Feb 2011 16:55:12 +0000 (11:55 -0500)]
Typo fixes. receivedUpto should be capitalized consistently.
Robert Haas [Fri, 11 Feb 2011 13:47:38 +0000 (08:47 -0500)]
Tweak find_composite_type_dependencies API a bit more.
Per discussion with Noah Misch, the previous coding, introduced by
my commit
65377e0b9c0e0397b1598b38b6a7fb8b6f740d39 on 2011-02-06,
was really an abuse of RELKIND_COMPOSITE_TYPE, since the caller in
typecmds.c is actually passing the name of a domain. So go back
having a type name argument, but make the first argument a Relation
rather than just a string so we can tell whether it's a table or
a foreign table and emit the proper error message.
Alvaro Herrera [Thu, 10 Feb 2011 22:47:57 +0000 (19:47 -0300)]
Fix isolation tester Makefile so that it runs in a VPATH build
Tom Lane [Thu, 10 Feb 2011 22:36:44 +0000 (17:36 -0500)]
Extend "ALTER EXTENSION ADD object" to permit "DROP object" as well.
Per discussion, this is something we should have sooner rather than later,
and it doesn't take much additional code to support it.
Alvaro Herrera [Thu, 10 Feb 2011 22:30:57 +0000 (19:30 -0300)]
Fix the isolation tester compilation on VPATH builds