OSDN Git Service

pf3gnuchains/pf3gnuchains4x.git
21 years ago2002-12-16 Jeff Johnston <jjohnstn@redhat.com>
Jeff Johnston [Mon, 16 Dec 2002 20:03:17 +0000 (20:03 +0000)]
2002-12-16  Jeff Johnston  <jjohnstn@redhat.com>

        * lib/mi-support.exp (mi_reinitialize_dir): Check mi level
        to see whether we are using the new -environment-directory
        command which resets via -r or the old version of the command
        which may prompt the user.  Part of fix for gdb/741.

21 years ago2002-11-23 H.J. Lu <hjl@gnu.org>
H.J. Lu [Mon, 16 Dec 2002 19:58:06 +0000 (19:58 +0000)]
2002-11-23  H.J. Lu <hjl@gnu.org>

* accross.m4: New.

21 years agoRemove obsolete testsuite code.
Andrew Cagney [Mon, 16 Dec 2002 19:33:54 +0000 (19:33 +0000)]
Remove obsolete testsuite code.

21 years ago * hppa-hpux-tdep.c: New file.
Joel Brobecker [Mon, 16 Dec 2002 16:51:47 +0000 (16:51 +0000)]
    * hppa-hpux-tdep.c: New file.
        * hppa-tdep.c (hppa_gdbarch_init): call the registered osabi-
        specific initialization routines.
        * Makefile.in (ALLDEPFILES): Add hppa-hpux-tdep.c.
        (hppa-hpux-tdep.o): Add rule.
        * config/pa/hppahpux.mt (TDEPFILES): Add hppa-hpux-tdep.o.
        * config/pa/hppa64.mt (TDEPFILES): Likewise.

21 years agoFix the reading of the debugging information of Tru64/Alpha binaries that
Nick Clifton [Mon, 16 Dec 2002 16:25:06 +0000 (16:25 +0000)]
Fix the reading of the debugging information of Tru64/Alpha binaries that
are produced by recent Compaq compilers.

21 years ago * hppa.h (completer_chars): #if 0 out.
Alan Modra [Mon, 16 Dec 2002 09:57:03 +0000 (09:57 +0000)]
* hppa.h (completer_chars): #if 0 out.

21 years ago * ns32k-dis.c (print_insn_ns32k): Constify "d", remove register
Alan Modra [Mon, 16 Dec 2002 09:54:12 +0000 (09:54 +0000)]
* ns32k-dis.c (print_insn_ns32k): Constify "d", remove register
keyword.

21 years ago * ns32k.h (struct ns32k_opcode): Constify "name", "operands" and
Alan Modra [Mon, 16 Dec 2002 09:53:48 +0000 (09:53 +0000)]
* ns32k.h (struct ns32k_opcode): Constify "name", "operands" and
"default_args".
(struct not_wot): Constify "args".
(struct not): Constify "name".
(numopcodes): Delete.
(endop): Delete.

21 years ago*** empty log message ***
gdbadmin [Mon, 16 Dec 2002 00:00:03 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Sun, 15 Dec 2002 23:35:50 +0000 (23:35 +0000)]
daily update

21 years ago * infrun.c (handle_inferior_event): Rearrange code to resume if
Daniel Jacobowitz [Sun, 15 Dec 2002 20:38:52 +0000 (20:38 +0000)]
* infrun.c (handle_inferior_event): Rearrange code to resume if
no catchpoint triggers for an event.

21 years ago * infrun.c (handle_inferior_event): Merge TARGET_WAITKIND_FORKED
Daniel Jacobowitz [Sun, 15 Dec 2002 20:15:56 +0000 (20:15 +0000)]
* infrun.c (handle_inferior_event): Merge TARGET_WAITKIND_FORKED
and TARGET_WAITKIND_VFORKED cases.

21 years ago * infrun.c (handle_inferior_event): Assume that catchpoints
Daniel Jacobowitz [Sun, 15 Dec 2002 20:08:02 +0000 (20:08 +0000)]
* infrun.c (handle_inferior_event): Assume that catchpoints
are not affected by DECR_PC_AFTER_BREAK.

21 years ago * target.c (update_current_target): Don't inherit DONT_USE.
Daniel Jacobowitz [Sun, 15 Dec 2002 19:00:33 +0000 (19:00 +0000)]
* target.c (update_current_target): Don't inherit DONT_USE.
* target.h (struct target_ops): Remove DONT_USE.
(target_next): Remove macro.

21 years ago* ui-out.c (MAX_UI_OUT_LEVELS): Raise to 6. Fixes PR cli/654.
Mark Kettenis [Sun, 15 Dec 2002 16:05:37 +0000 (16:05 +0000)]
* ui-out.c (MAX_UI_OUT_LEVELS): Raise to 6.  Fixes PR cli/654.

21 years ago*** empty log message ***
gdbadmin [Sun, 15 Dec 2002 00:00:32 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Sat, 14 Dec 2002 23:00:05 +0000 (23:00 +0000)]
daily update

21 years ago* arm-tdep.c (convert_from_extended): New argument to hold the
Richard Earnshaw [Sat, 14 Dec 2002 10:42:05 +0000 (10:42 +0000)]
* arm-tdep.c (convert_from_extended): New argument to hold the
type of floating point result we want to convert to.  Make input
argument const.  Fix all callers.
(convert_to_extended): Similarly.
(arm_extract_return_value): Now takes a regcache argument.  Change
code to use regcache accessor functions.  Correctly extract
smaller-than-word results on big-endian machines.
(arm_store_return_value): Now takes a regcache argument.  Change
code to use regcache accessor functions.  Correctly zero/sign extend
smaller than word results before storing into r0.
(arm_gdbarch_init): Register new-style extract_return_value and
store_return_value functions.

21 years ago * Makefile.tpl (check-gcc-c++): Renamed from check-c++. Don't run
Jason Merrill [Sat, 14 Dec 2002 08:35:49 +0000 (08:35 +0000)]
    * Makefile.tpl (check-gcc-c++): Renamed from check-c++.  Don't run
        library tests.
        (check-c++): Just depend on it and check-target-libstdc++-v3.
        * Makefile.in: Regenerate.

21 years ago*** empty log message ***
gdbadmin [Sat, 14 Dec 2002 00:00:03 +0000 (00:00 +0000)]
*** empty log message ***

21 years ago2002-12-13 Michael Snyder <msnyder@to-limbo.toronto.redhat.com>
Michael Snyder [Fri, 13 Dec 2002 23:28:28 +0000 (23:28 +0000)]
2002-12-13  Michael Snyder  <msnyder@to-limbo.toronto.redhat.com>

* thread-db.c (thread_from_lwp): Uniquify error msg.
(lwp_from_thread): Ditto.
(check_event): Ditto.
(find_new_threads_callback): Ditto.
(thread_db_pid_to_str): Ditto.

21 years ago2002-12-13 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Fri, 13 Dec 2002 23:18:56 +0000 (23:18 +0000)]
2002-12-13  Andrew Cagney  <ac131313@redhat.com>

* frame.h (get_frame_saved_regs): Declare.
(frame_saved_regs_zalloc): Change return type to CORE_ADDR
pointer.
* frame.c (get_frame_saved_regs): New function.
(frame_saved_regs_zalloc): Return the allocated saved_regs.

21 years agodaily update
Alan Modra [Fri, 13 Dec 2002 23:00:06 +0000 (23:00 +0000)]
daily update

21 years ago2002-12-13 Nathanael Nerode <neroden@gcc.gnu.org>
Nathanael Nerode [Fri, 13 Dec 2002 22:59:14 +0000 (22:59 +0000)]
2002-12-13  Nathanael Nerode  <neroden@gcc.gnu.org>

* configure.in, Makefile.tpl, Makefile.def: Remove tclX.
* Makefile.in: Regenerate.

21 years ago2002-12-13 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Fri, 13 Dec 2002 21:57:40 +0000 (21:57 +0000)]
2002-12-13  Andrew Cagney  <ac131313@redhat.com>

* frame.c (deprecated_update_current_frame_pc_hack): New
function.
* frame.h (deprecated_update_current_frame_pc_hack): Declare.
* infrun.c (normal_stop): Use said function instead of directly
modifying the frame's PC.

21 years ago* frame.h (frame_id_unwind_ftype): Fix typo in return type.
Alexandre Oliva [Fri, 13 Dec 2002 20:21:32 +0000 (20:21 +0000)]
* frame.h (frame_id_unwind_ftype): Fix typo in return type.

21 years agoMultiarch NUM_REGS for MIPS.
Kevin Buettner [Fri, 13 Dec 2002 18:09:30 +0000 (18:09 +0000)]
Multiarch NUM_REGS for MIPS.

21 years ago2002-12-13 Jeff Johnston <jjohnstn@redhat.com>
Jeff Johnston [Fri, 13 Dec 2002 17:57:38 +0000 (17:57 +0000)]
2002-12-13  Jeff Johnston  <jjohnstn@redhat.com>

        * mi-basics.exp: Change tests for -environment-directory.  Also add
        tests for -environment-cd, -environment-pwd, and -environment-path.
        Part of fix for PR gdb/741.

21 years ago2002-12-13 Jeff Johnston <jjohnstn@redhat.com>
Jeff Johnston [Fri, 13 Dec 2002 17:55:49 +0000 (17:55 +0000)]
2002-12-13  Jeff Johnston  <jjohnstn@redhat.com>

        * defs.h (init_last_source_visited): New prototype.
        (add_path): Ditto.
        * source.c (add_path): New function that adds to a specified path.
        (mod_path): Change to call add_path.
        (init_last_source_visited): New function to allow interfaces to
        initialize static variable: last_source_visited.  Part of fix
        for PR gdb/741.
        * Makefile.in: Add support for mi/mi-cmd-env.c.

21 years ago2002-12-13 Jeff Johnston <jjohnstn@redhat.com>
Jeff Johnston [Fri, 13 Dec 2002 17:00:22 +0000 (17:00 +0000)]
2002-12-13  Jeff Johnston  <jjohnstn@redhat.com>

        * mi-cmds.c (-environment-directory) Change to use mi_cmd_env_dir,
        (-environment-cd): Change to use mi_cmd_env_cd,.
        (-environment-pwd): Change to use mi_cmd_env_pwd.
        (-environment-path): Change to use mi_cmd_env_path.
        * mi-cmds.h (mi_cmd_env_cd, mi_cmd_env_dir): New prototypes.
        (mi_cmd_env_path, mi_cmd_env_pwd): Ditto.
        * mi-cmd-env.c: New file.  Part of fix for PR gdb/741.
        * gdbmi.texinfo (environment-cd): Update output and example.
        (environment-pwd): Ditto.
        (environment-dir): Update output, description, and examples.
        (environment-path): Ditto.

21 years ago2002-12-13 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Fri, 13 Dec 2002 16:40:25 +0000 (16:40 +0000)]
2002-12-13  Andrew Cagney  <ac131313@redhat.com>

* frame.h (frame_id_unwind): Declare.
(struct frame_info): Add fields id_unwind, id_unwind_cache_p and
id_unwind_cache.
(frame_id_unwind_ftype): Declare.
* frame.c (frame_id_unwind): New function.
(set_unwind_by_pc): Add unwind_id parameter.  Initialized.
(create_new_frame, get_prev_frame): Pass id_unwind to
set_unwind_by_pc.
(frame_saved_regs_id_unwind): New function.
(frame_saved_regs_id_unwind): New function.
* dummy-frame.c (dummy_frame_id_unwind): New function.
(struct dummy_frame): Add field id.
(generic_push_dummy_frame): Initialize `id'.
* dummy-frame.h (dummy_frame_id_unwind): Declare.

21 years ago2002-12-13 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Fri, 13 Dec 2002 16:26:02 +0000 (16:26 +0000)]
2002-12-13  Andrew Cagney  <ac131313@redhat.com>

* infcmd.c (run_stack_dummy): Create a frame ID directly and then
pass that to set_momentary_breakpoint.  Move comments to where they
belong.
* frame.h (set_current_frame): Delete declaration.
* frame.c (set_current_frame): Delete function.

21 years ago2002-12-13 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Fri, 13 Dec 2002 16:11:32 +0000 (16:11 +0000)]
2002-12-13  Andrew Cagney  <ac131313@redhat.com>

* frame.c (frame_extra_info_zalloc): New function.
* frame.h (frame_extra_info_zalloc): Declare.

21 years ago * hppa-tdep.c (hppa_pop_frame): Fix a compilation error introduced
Joel Brobecker [Fri, 13 Dec 2002 14:37:41 +0000 (14:37 +0000)]
   * hppa-tdep.c (hppa_pop_frame): Fix a compilation error introduced
       in the previous prototype change to set_momentary_breakpoint.

21 years ago2002-12-12 Jeff Johnston <jjohnstn@redhat.com>
Jeff Johnston [Fri, 13 Dec 2002 00:36:42 +0000 (00:36 +0000)]
2002-12-12  Jeff Johnston  <jjohnstn@redhat.com>

        * COPYING.NEWLIB: Update list of alternate Regent of California
        licenses and discuss official revoking of advertising clause.
        * COPYING.LIBGLOSS: Ditto.

21 years ago*** empty log message ***
gdbadmin [Fri, 13 Dec 2002 00:00:32 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Thu, 12 Dec 2002 23:00:04 +0000 (23:00 +0000)]
daily update

21 years ago * pj-opc.c (pj_opc_info): Add braces around union initializer.
Alan Modra [Thu, 12 Dec 2002 22:56:41 +0000 (22:56 +0000)]
* pj-opc.c (pj_opc_info): Add braces around union initializer.

21 years ago * infrun.c (pending_follow): Remove saw_parent_fork, saw_child_fork,
Daniel Jacobowitz [Thu, 12 Dec 2002 22:41:21 +0000 (22:41 +0000)]
* infrun.c (pending_follow): Remove saw_parent_fork, saw_child_fork,
and saw_child_exec.
(follow_fork, init_wait_for_inferior, handle_inferior_event): Remove
references to saw_parent_fork, saw_child_fork, and saw_child_exec.
(stop_stepping): Remove outdated check for child vfork events.

21 years ago * h8500-opc.h (h8500_table): Add missing initializers to quiet
Alan Modra [Thu, 12 Dec 2002 22:34:04 +0000 (22:34 +0000)]
* h8500-opc.h (h8500_table): Add missing initializers to quiet
warnings.

* config/tc-h8500.c (cons): Delete declaration.
(md_begin <opcode>): Constify.
(displacement_size, immediate_size, absolute_size): Remove.
(build_relaxable_instruction <operand>): Add ATTRIBUTE_UNUSED.
(tc_crawl_symbol_chain <headers>): Likewise.
(md_undefined_symbol <name>): Likewise.
(tc_headers_hook <headers>): Likewise.
(md_parse_option <c,arg>): Likewise.
(md_show_usage <stream>): Likewise.
(md_convert_frag <headers, seg>): Likewise.
(tc_coff_symbol_emit_hook <ignore>): Likewise.
(md_atof): Remove declaration of atof_ieee.
(tc_aout_fix_to_chars): Remove unused function.
(parse_reg): Prototype.
(parse_exp): Prototype.
(skip_colonthing): Prototype.  Use &&, not & in logical expressions.
(parse_reglist): Prototype.
(get_operand): Prototype.
(get_operands): Prototype.
(get_specific): Prototype.  Make "this_index" signed.
(check): Prototype, make static.
(insert): Prototype
(build_relaxable_instruction): Prototype, make static.
(build_bytes): Prototype.
(wordify_scb): Prototype.
* config/tc-h8500.h (start_label): Declare.
(tc_coff_sizemachdep): Declare.

21 years ago* elf-m10300.c (elf32_mn10300_link_hash_newfunc): Reorder
Alexandre Oliva [Thu, 12 Dec 2002 21:54:32 +0000 (21:54 +0000)]
* elf-m10300.c (elf32_mn10300_link_hash_newfunc): Reorder
initializers to match struct declaration.

21 years ago * pj.h (pj_opc_info_t): Add union.
Alan Modra [Thu, 12 Dec 2002 21:52:05 +0000 (21:52 +0000)]
* pj.h (pj_opc_info_t): Add union.

* pj-dis.c (print_insn_pj): Adjust for pj_opc_info_t change.

* config/tc-pj.c (little, big, parse_exp_save_ilp): Prototype.
(c_to_r, ipush_code, fake_opcode, alias): Likewise.
(fake_opcode): Adjust for pj_opc_int_t change.
(md_begin): Likewise.
(md_assemble): Likewise.
(ipush_code): Correct parse_exp_save_ilp call.  Test pending_reloc
instead of non-existent third arg of parse_exp_save_ilp.
(md_parse_option): Correct "little" and "big" calls.

21 years ago * config/tc-z8k.c (cons, obj_coff_section): Delete declarations.
Alan Modra [Thu, 12 Dec 2002 21:27:58 +0000 (21:27 +0000)]
* config/tc-z8k.c (cons, obj_coff_section): Delete declarations.
(whatreg, parse_reg, parse_exp): Make static, prototype.
(checkfor, regword, regaddr, get_ctrl_operand): Prototype.
(get_flags_operand, get_interrupt_operand, get_cc_operand): Likewise.
(get_operand, get_operands, get_specific, newfix): Likewise.
(apply_fix, build_bytes): Likewise.
(md_atof): Remove declaration of atof_ieee.
(tc_aout_fix_to_chars): Delete.
(md_begin): Constify "opcode".  Don't try to init opcode->idx.
Fix s_unseg call.
(md_parse_option): Fix s_segm and s_unseg calls.

* z8kgen.c: Include "libiberty.h".
(opt, args, toks): Fix initializer warnings.
(chewname): Make "name" a char **.  Return mnemonic trimmed of
operands.
(gas): Improve emitted "DO NOT EDIT" warning.  Format emitted
opcode_entry_type, and make "nicename" and "name" const.  Make
z8k_table const too.  Formatting.  Generate idx as gas needs it.
* z8k-opc.h: Regenerate.

21 years agoComment typo fixes.
Alan Modra [Thu, 12 Dec 2002 10:26:01 +0000 (10:26 +0000)]
Comment typo fixes.

21 years ago * elf32-i386.c (elf_i386_finish_dynamic_sections): Add output_offset
Alan Modra [Thu, 12 Dec 2002 10:17:14 +0000 (10:17 +0000)]
* elf32-i386.c (elf_i386_finish_dynamic_sections): Add output_offset
to DT_JMPREL.  Use srelplt input section size for DT_PLTRELSZ and
DT_RELSZ adjustment, not output section.  Avoid writing tags when
unchanged.  Don't assume linker script is sane, adjust DT_REL too.
* elf32-hppa.c (elf32_hppa_finish_dynamic_sections): Just use raw
size of srelplt for DT_PLTRELSZ.  Use srelplt input section size for
DT_RELASZ adjustment, not output section.  Avoid writing tags when
unchanged.  Adjust DT_RELA.
* elf64-ppc.c (ppc64_elf_finish_dynamic_sections): Tweaks for better
formatting.  Avoid writing tags when unchanged.  Adjust DT_RELA.

21 years ago* Makefile.tpl (configure-target-rda): Depend on $(ALL_GCC_C).
Alexandre Oliva [Thu, 12 Dec 2002 07:04:28 +0000 (07:04 +0000)]
* Makefile.tpl (configure-target-rda): Depend on $(ALL_GCC_C).
* Makefile.in: Rebuilt.

21 years ago5.3 released.
Andrew Cagney [Thu, 12 Dec 2002 06:29:25 +0000 (06:29 +0000)]
5.3 released.

21 years ago* elfxx-mips.c (mips_elf_calculate_relocation): Don't divide
Alexandre Oliva [Thu, 12 Dec 2002 04:42:06 +0000 (04:42 +0000)]
* elfxx-mips.c (mips_elf_calculate_relocation): Don't divide
addend by 4.

21 years ago* elfxx-mips.c (struct mips_got_entry): New.
Alexandre Oliva [Thu, 12 Dec 2002 02:55:41 +0000 (02:55 +0000)]
* elfxx-mips.c (struct mips_got_entry): New.
(struct mips_got_info): Added got_entries field.
(mips_elf_got_entry_hash, mips_elf_got_entry_eq): New functions.
(mips_elf_local_got_index, mips_elf_got_page,
mips_elf_got16_entry): Re-implement in terms of new...
(mips_elf_create_local_got_entry): Rewrite to use got_entries.
Change return type.
(mips_elf_highest): Warning clean-up.
(mips_elf_create_got_section): Initialize got_entries.
(_bfd_mips_elf_check_relocs): Use got_entries to estimate
local got size.
(_bfd_mips_elf_size_dynamic_sections): Do not account for
GOT_PAGE entries, since we now reuse GOT16 entries.

21 years ago * corelow.c (init_core_ops): Delete references to to_require_attach
Daniel Jacobowitz [Thu, 12 Dec 2002 01:39:34 +0000 (01:39 +0000)]
* corelow.c (init_core_ops): Delete references to to_require_attach
and to_require_detach.
* exec.c (init_exec_ops): Likewise.
* hppah-nat.c (child_follow_fork): Call hppa_require_attach and
hppa_require_detach directly.
* inferior.h (REQUIRE_ATTACH, REQUIRE_DETACH): Delete.
* inftarg.c (child_detach): Remove.
(child_detach_from_process): Rename to child_detach, remove
after_fork argument.
(child_attach): Remove.
(child_attach_to_process): Rename to child_attach, remove after_fork
argument.
(init_child_ops): Delete references to to_require_attach
and to_require_detach.
* infttrace.c (hppa_require_attach): Update comment.
* target.c (cleanup_target, update_current_target)
(init_dummy_target, setup_target_debug): Delete references to
to_require_attach and to_require_detach.
(find_default_require_detach, find_default_require_attach)
(debug_to_require_attach, debug_to_require_detach): Remove
functions.
* target.h (struct target_ops): Remove to_require_attach
and to_require_detach.
(target_require_attach, target_require_detach): Delete macros.
(find_default_require_detach, find_default_require_attach): Delete
prototypes.
* config/pa/nm-hppah.h (REQUIRE_ATTACH, REQUIRE_DETACH): Delete.

21 years ago2002-12-11 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Thu, 12 Dec 2002 00:56:44 +0000 (00:56 +0000)]
2002-12-11  Andrew Cagney  <ac131313@redhat.com>

* frame.c (get_frame_extra_info): New function.
* frame.h (get_frame_extra_info): Declare.

21 years ago*** empty log message ***
gdbadmin [Thu, 12 Dec 2002 00:00:02 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Wed, 11 Dec 2002 23:00:05 +0000 (23:00 +0000)]
daily update

21 years ago2002-12-06 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Wed, 11 Dec 2002 22:34:47 +0000 (22:34 +0000)]
2002-12-06  Andrew Cagney  <ac131313@redhat.com>

* breakpoint.h (struct breakpoint): Replace frame with frame_id.
(set_momentary_breaokpoint): Replace `struct frame_info' parameter
with `struct frame_id'.
(set_longjmp_resume_breakpoint): Ditto.
* infrun.c (handle_inferior_event): Update.
* breakpoint.c (watch_command_1, until_break_command): Update.
* infrun.c (handle_inferior_event, check_sigtramp2): Update.
(handle_inferior_event, step_over_function): Update.
* breakpoint.c (bpstat_stop_status, print_one_breakpoint): Update.
(set_raw_breakpoint, set_longjmp_resume_breakpoint): Update.
(set_momentary_breakpoint, deprecated_frame_in_dummy): Update.
* infcmd.c (finish_command, run_stack_dummy): Update.

21 years agoConvert complain() to complaint().
Kevin Buettner [Wed, 11 Dec 2002 20:55:37 +0000 (20:55 +0000)]
Convert complain() to complaint().

21 years ago2002-12-11 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Wed, 11 Dec 2002 20:35:43 +0000 (20:35 +0000)]
2002-12-11  Andrew Cagney  <cagney@redhat.com>

* frame.c (deprecated_get_frame_saved_regs): Rename
get_frame_saved_regs.
* frame.h (deprecated_get_frame_saved_regs): Update declaration.
* sparc-tdep.c: Update.
* hppa-tdep.c: Update.
* h8500-tdep.c: Update.

21 years ago * gdbarch.sh (ADDRESS_CLASS_TYPE_FLAGS_TO_NAME)
Kevin Buettner [Wed, 11 Dec 2002 20:19:39 +0000 (20:19 +0000)]
* gdbarch.sh (ADDRESS_CLASS_TYPE_FLAGS_TO_NAME)
(ADDRESS_CLASS_NAME_TO_TYPE_FLAGS): Use ``const char *'' instead of
``char *'' for return and parameter types.
* gdbarch.h, gdbarch.c: Regenerate.
* gdbtypes.h, gdbtypes.c (address_space_int_to_name): Change
return type from ``char *'' to ``const char *''.
* c-typeprint.c (c_type_print_modifier): Make ``address_space_id''
const.

21 years ago2002-12-11 David Carlton <carlton@math.stanford.edu>
David Carlton [Wed, 11 Dec 2002 18:45:29 +0000 (18:45 +0000)]
2002-12-11  David Carlton  <carlton@math.stanford.edu>

* gdb.c++/m-data.exp: Add test for members that shadow global
variables: see PR gdb/804.
* gdb.c++/m-data.cc: Ditto.

21 years ago* i386-tdep.c: Include "dummy-frame.h".
Mark Kettenis [Wed, 11 Dec 2002 14:38:23 +0000 (14:38 +0000)]
* i386-tdep.c: Include "dummy-frame.h".
(i386_frame_chain, i386_frame_saved_pc): Replace
DEPRECATED_PC_IN_CALL_DUMMY with call to pc_in_dummy_frame.
(i386_gdbarch_init): Don't set deprecated_pc_in_call_dummy.

21 years ago * configure: Fix bug put in by gremlins.
Nathanael Nerode [Wed, 11 Dec 2002 04:14:47 +0000 (04:14 +0000)]
* configure: Fix bug put in by gremlins.

21 years ago2002-12-10 Nathanael Nerode <neroden@gcc.gnu.org>
Nathanael Nerode [Wed, 11 Dec 2002 04:00:09 +0000 (04:00 +0000)]
2002-12-10  Nathanael Nerode  <neroden@gcc.gnu.org>

* Makefile.tpl: Substitute more autoconfily.
* configure: Substitute more autoconfily.
* Makefile.in: Regenerate.

21 years agoFix date on changelog entry :-/
Andrew Cagney [Wed, 11 Dec 2002 02:28:34 +0000 (02:28 +0000)]
Fix date on changelog entry :-/

21 years ago2002-12-10 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Wed, 11 Dec 2002 02:26:38 +0000 (02:26 +0000)]
2002-12-10  Andrew Cagney  <cagney@redhat.com>

* gdbarch.sh (DEPRECATED_INIT_FRAME_PC): Rename INIT_FRAME_PC.
Change to a function with predicate.
* gdbarch.h, gdbarch.c: Re-generate.
* frame.c (get_prev_frame): Update.  Test
DEPRECATED_INIT_FRAME_PC_P.
* config/sparc/tm-sparc.h (DEPRECATED_INIT_FRAME_PC): Update.
* config/rs6000/tm-rs6000.h (DEPRECATED_INIT_FRAME_PC): Update.
* config/mn10200/tm-mn10200.h (DEPRECATED_INIT_FRAME_PC): Update.
* alpha-tdep.c (alpha_gdbarch_init): Update.
* mn10300-tdep.c (mn10300_gdbarch_init): Update.
* mips-tdep.c (mips_gdbarch_init): Update.
* i386-interix-tdep.c (i386_interix_init_abi): Update.
* arm-tdep.c: Update comments.
* h8300-tdep.c (h8300_gdbarch_init): Explicitly set init_frame_pc.
* config/m32r/tm-m32r.h (DEPRECATED_INIT_FRAME_PC): Ditto.
* frv-tdep.c (frv_gdbarch_init): Ditto.
* x86-64-tdep.c (x86_64_init_abi): Ditto.
* ia64-tdep.c (ia64_gdbarch_init): Ditto.
* s390-tdep.c (s390_gdbarch_init): Ditto.
* v850-tdep.c (v850_gdbarch_init): Ditto.
* vax-tdep.c (vax_gdbarch_init): Ditto.
* sh-tdep.c (sh_gdbarch_init): Ditto.
* ns32k-tdep.c (ns32k_gdbarch_init): Ditto.
* m68hc11-tdep.c (m68hc11_gdbarch_init): Ditto.
* mcore-tdep.c (mcore_gdbarch_init): Ditto.
* xstormy16-tdep.c (xstormy16_gdbarch_init): Ditto.
* i386-tdep.c (i386_gdbarch_init): Ditto.
* d10v-tdep.c (d10v_gdbarch_init): Ditto.
* cris-tdep.c (cris_gdbarch_init): Ditto.
* avr-tdep.c (avr_gdbarch_init): Ditto.
* arm-tdep.c (arm_gdbarch_init): Ditto.
* config/z8k/tm-z8k.h (INIT_FRAME_PC_FIRST): Delete macro.
(DEPRECATED_INIT_FRAME_PC): Rename INIT_FRAME_PC.

21 years ago * config/pa/nm-hppah.h (CHILD_POST_FOLLOW_VFORK): Change to
Daniel Jacobowitz [Wed, 11 Dec 2002 02:04:45 +0000 (02:04 +0000)]
* config/pa/nm-hppah.h (CHILD_POST_FOLLOW_VFORK): Change to
CHILD_FOLLOW_FORK.
* hppah-nat.c (saved_vfork_pid): Add.
(child_post_follow_vfork): Remove.
(child_follow_fork): New function.
(child_wait): Call detach_breakpoints after receiving the child vfork.
Call child_resume directly instead of going through resume ().
Make sure we have the exec before reporting the vfork.
* inferior.h (follow_inferior_reset_breakpoints): Add prototype.
* infrun.c (follow_fork, follow_vfork, follow_inferior_fork): Remove.
(follow_fork): New function.  Call target_follow_fork.
(follow_inferior_reset_breakpoints): New function broken out from
old follow_inferior_fork.
(resume): Remove hack to follow exec after vfork.
* inftarg.c (child_post_follow_vfork): Remove.
(child_follow_fork): New function.
(init_child_ops): Replace to_post_follow_vfork with to_follow_fork.
* target.c (cleanup_target): Replace to_post_follow_vfork with
to_follow_fork.
(update_current_target): Likewise.
(setup_target_debug): Likewise.
(debug_to_post_follow_vfork): Remove.
(debug_to_follow_fork): New function.
* target.h (struct target_ops): Replace to_post_folow_vfork with
to_follow_fork.
(child_post_follow_vfork): Remove prototype.
(child_follow_fork): Add prototype.
(target_post_follow_vfork): Remove macro.
(target_follow_fork): Add macro.

testsuite/
* gdb.base/foll-vfork.exp: Re-enable test on HP/UX.

21 years ago * hppah-nat.c (saved_child_execd_pathname, saved_vfork_state): New.
Daniel Jacobowitz [Wed, 11 Dec 2002 02:02:03 +0000 (02:02 +0000)]
* hppah-nat.c (saved_child_execd_pathname, saved_vfork_state): New.
(child_post_follow_vfork): Cancel pending exec event if we follow
the parent.
(child_wait): Only return TARGET_WAITKIND_VFORKED when all necessary
events have been processed.  Return a fake TARGET_WAITKIND_EXECD
event at the following wait call if necessary.
* infrun.c (follow_vfork): Don't follow_exec here.
(handle_inferior_event): Add comment to TARGET_WAITKIND_EXECD
case about HP/UX 10.20.  Remove code pushed down to
hppah-nat.c:child_wait.
* infttrace.c (child_resume): Use TT_PROC_CONTINUE if
vfork_in_flight is set.

21 years ago * hppah-nat.c (child_wait): Return TARGET_WAITKIND_IGNORE
Daniel Jacobowitz [Wed, 11 Dec 2002 01:25:19 +0000 (01:25 +0000)]
* hppah-nat.c (child_wait): Return TARGET_WAITKIND_IGNORE
for the parent's fork event.
* infrun.c (handle_inferior_event): Only expect one fork event.
Call prepare_to_wait for TARGET_WAITKIND_IGNORE.  Update comment.
* target.h: Update comment for TARGET_WAITKIND_IGNORE.

21 years ago*** empty log message ***
gdbadmin [Wed, 11 Dec 2002 00:00:32 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Tue, 10 Dec 2002 23:00:04 +0000 (23:00 +0000)]
daily update

21 years ago2002-12-10 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Tue, 10 Dec 2002 21:24:47 +0000 (21:24 +0000)]
2002-12-10  Andrew Cagney  <ac131313@redhat.com>

* PROBLEMS: Delete reference to PR gdb/725.

21 years ago2002-12-10 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Tue, 10 Dec 2002 21:19:03 +0000 (21:19 +0000)]
2002-12-10  Andrew Cagney  <ac131313@redhat.com>

* MAINTAINERS (gdb.c++): Add David Carlton.

21 years agoAdd support for displaying extension to DWARF2 used by Unified Parallel C
Nick Clifton [Tue, 10 Dec 2002 17:48:27 +0000 (17:48 +0000)]
Add support for displaying extension to DWARF2 used by Unified Parallel C
compiler.

21 years agoAllow an otherwise unrepresentable read-only section that lies after .text
Nick Clifton [Tue, 10 Dec 2002 16:15:27 +0000 (16:15 +0000)]
Allow an otherwise unrepresentable read-only section that lies after .text
and before .data to be written into the output file and included in a_text.

21 years ago2002-12-09 David Carlton <carlton@math.stanford.edu>
David Carlton [Tue, 10 Dec 2002 00:30:43 +0000 (00:30 +0000)]
2002-12-09  David Carlton  <carlton@math.stanford.edu>

* cli/cli-setshow.c: #include <readline/tilde.h> after defs.h.
* cli/cli-cmds.c: Ditto.

21 years ago*** empty log message ***
gdbadmin [Tue, 10 Dec 2002 00:00:33 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Mon, 9 Dec 2002 23:46:37 +0000 (23:46 +0000)]
daily update

21 years ago* gdbarch.sh (gdbarch_dump): Wrap function addresses in <>.
Andrew Cagney [Mon, 9 Dec 2002 22:46:31 +0000 (22:46 +0000)]
* gdbarch.sh (gdbarch_dump): Wrap function addresses in <>.

21 years ago2002-12-09 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Mon, 9 Dec 2002 22:22:40 +0000 (22:22 +0000)]
2002-12-09  Andrew Cagney  <cagney@redhat.com>

* gdbarch.sh (gdbarch_dump): Print NAME_OF_MALLOC using %s.
* gdbarch.c: Re-generate.

21 years ago2002-12-09 David Carlton <carlton@math.stanford.edu>
David Carlton [Mon, 9 Dec 2002 20:48:07 +0000 (20:48 +0000)]
2002-12-09  David Carlton  <carlton@math.stanford.edu>

* p-exp.y: Rename TRUE and FALSE to TRUEKEYWORD and FALSEKEYWORD.

21 years ago2002-12-09 David Carlton <carlton@math.stanford.edu>
David Carlton [Mon, 9 Dec 2002 19:49:00 +0000 (19:49 +0000)]
2002-12-09  David Carlton  <carlton@math.stanford.edu>

* linespec.c (symtab_from_filename): New function.
(decode_line_1): Move code into symtab_from_filename.

21 years ago * lin-lwp.c (strsignal): Make extern declaration match that of glibc.
Kevin Buettner [Mon, 9 Dec 2002 18:41:42 +0000 (18:41 +0000)]
* lin-lwp.c (strsignal): Make extern declaration match that of glibc.

21 years ago2002-12-07 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Mon, 9 Dec 2002 03:30:44 +0000 (03:30 +0000)]
2002-12-07  Andrew Cagney  <ac131313@redhat.com>

* f-valprint.c (info_common_command): Use get_frame_pc.
* std-regs.c (value_of_builtin_frame_pc_reg): Ditto.
* ax-gdb.c (agent_command): Ditto.
* rs6000-tdep.c (rs6000_init_extra_frame_info): Ditto.
(rs6000_pop_frame): Ditto.
(rs6000_frameless_function_invocation): Ditto.
(rs6000_frame_saved_pc, frame_get_saved_regs): Ditto.
(frame_initial_stack_address, rs6000_frame_chain): Ditto.
* macroscope.c (default_macro_scope): Ditto.
* stack.c (print_frame_info_base): Ditto.
(print_frame, frame_info, print_frame_label_vars): Ditto.
(return_command, func_command, get_frame_language): Ditto.
* infcmd.c (finish_command): Ditto.
* dummy-frame.c (cached_find_dummy_frame): Ditto.
* breakpoint.c (deprecated_frame_in_dummy): Ditto.
(break_at_finish_at_depth_command_1): Ditto.
(break_at_finish_command_1): Ditto.
(until_break_command, get_catch_sals): Ditto.
* blockframe.c (func_frame_chain_valid): Ditto.
(frameless_look_for_prologue): Ditto.
(frame_address_in_block, generic_func_frame_chain_valid): Ditto.

21 years ago2002-12-08 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Mon, 9 Dec 2002 02:44:52 +0000 (02:44 +0000)]
2002-12-08  Andrew Cagney  <ac131313@redhat.com>

* config/rs6000/tm-rs6000.h (init_frame_pc_noop): Add declaration.
* dwarf2cfi.c (cfi_init_frame_pc): Cast the PC to a pointer.

21 years ago2002-12-08 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Mon, 9 Dec 2002 02:04:17 +0000 (02:04 +0000)]
2002-12-08  Andrew Cagney  <ac131313@redhat.com>

* gdbarch.sh (INIT_FRAME_PC_FIRST, INIT_FRAME_PC_DEFAULT): Convert
to pure functions.
* gdbarch.h, gdbarch.c: Re-generate.
* frame.c (get_prev_frame): Explictly assign prev's pc with value
returned by INIT_FRAME_PC_FIRST and INIT_EXTRA_FRAME_INFO.

* arch-utils.h (init_frame_pc_default, init_frame_pc_noop): Change
declaration to a function returning a CORE_ADDR.
* x86-64-tdep.h (x86_64_init_frame_pc): Ditto.
* arch-utils.c (init_frame_pc_noop): Return the PC value.
(init_frame_pc_default): Ditto.
* x86-64-linux-tdep.c (x86_64_init_frame_pc): Ditto.
* s390-tdep.c (s390_init_frame_pc_first): Ditto.
* mips-tdep.c (mips_init_frame_pc_first): Ditto.
* dwarf2cfi.h (cfi_init_frame_pc): Ditto.
* dwarf2cfi.c (cfi_init_frame_pc): Ditto.
* alpha-tdep.c (alpha_init_frame_pc_first): Ditto.

* i386-interix-tdep.c (i386_interix_init_abi): Set init_frame_pc
to init_frame_pc_noop.
(i386_interix_init_frame_pc): Delete function.
* z8k-tdep.c (init_frame_pc): Delete function.
* config/z8k/tm-z8k.h (INIT_FRAME_PC): Define as init_frame_pc_noop.
(INIT_FRAME_PC_FIRST): Ditto.
* config/mn10200/tm-mn10200.h (INIT_FRAME_PC): Ditto.
(INIT_FRAME_PC_FIRST): Ditto.
* config/sparc/tm-sparc.h (INIT_FRAME_PC): Ditto.
* config/rs6000/tm-rs6000.h (INIT_FRAME_PC): Redefine as
init_frame_pc_noop.
(INIT_FRAME_PC_FIRST): Convert to an expression.
* config/sparc/tm-sparc.h (INIT_FRAME_PC_FIRST): Ditto.

21 years ago2002-12-08 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Mon, 9 Dec 2002 01:40:25 +0000 (01:40 +0000)]
2002-12-08  Andrew Cagney  <ac131313@redhat.com>

* blockframe.c: Use get_frame_base instead of directly accessing
the `struct frame_info' member frame.
* f-valprint.c, std-regs.c, rs6000-tdep.c: Ditto.
* stack.c, dummy-frame.c, breakpoint.c: Ditto.

21 years ago2002-12-08 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Mon, 9 Dec 2002 01:28:10 +0000 (01:28 +0000)]
2002-12-08  Elena Zannoni  <ezannoni@redhat.com>

* Makefile.in (readline_h): Define.
(completer.o): Depend on readline_h.
(corelow.o): Ditto.
(event-top.o): Ditto.
(exec.o): Ditto.
(solib.o): Ditto.
(source.o): Ditto.
(symfile.o): Ditto.
(symmisc.o): Ditto.
(top.o): Ditto.
(tracepoint.o): Ditto.
(utils.o): Ditto.
(cli-dump.o): Ditto.
(tui-hooks.o): Ditto.
(tuiWin.o): Ditto.

21 years ago2002-12-08 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Mon, 9 Dec 2002 00:59:27 +0000 (00:59 +0000)]
2002-12-08  Elena Zannoni  <ezannoni@redhat.com>

More cleanup from import of readline 4.3.
* completer.h (complete_line, readline_line_completion_function):
Update prototypes.
(line_completion_function): Removed, not used outside of completer.c.
* completer.c (readline_line_completion_function,
complete_function, line_completion_function): Use const for first
parameter.
(line_completion_function): Make static.
(filename_completer): filename_completion_function is now called
rl_filename_completion_function
* corelow.c: Include <readline/readline.h>.
* exec.c: Ditto.
* solib.c: Ditto.
* source.c: Ditto.
* symfile.c: Ditto.
* symmisc.c: Ditto.
* top.c (init_main): No need to coerce
readline_line_completion_function anymore.
* cli/cli-dump.c: Include <readline/readline.h>.

21 years ago2002-12-08 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Mon, 9 Dec 2002 00:32:08 +0000 (00:32 +0000)]
2002-12-08  Andrew Cagney  <ac131313@redhat.com>

* stack.c (frame_info): Use get_prev_frame.
* blockframe.c (frame_address_in_block): Ditto.
* rs6000-tdep.c (rs6000_init_extra_frame_info): Ditto.
(rs6000_frameless_function_invocation): Ditto.
(rs6000_frame_saved_pc): Ditto.
(rs6000_frame_chain): Ditto.
* arch-utils.c (init_frame_pc_default): Ditto.

21 years ago*** empty log message ***
gdbadmin [Mon, 9 Dec 2002 00:00:02 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Sun, 8 Dec 2002 23:00:05 +0000 (23:00 +0000)]
daily update

21 years ago* Makefile.tpl (all-sim): Depend on maybe-configure-gdb.
DJ Delorie [Sun, 8 Dec 2002 22:39:43 +0000 (22:39 +0000)]
* Makefile.tpl (all-sim): Depend on maybe-configure-gdb.
* Makefile.in (all-sim): Ditto.

21 years ago2002-12-08 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Sun, 8 Dec 2002 22:39:09 +0000 (22:39 +0000)]
2002-12-08  Andrew Cagney  <ac131313@redhat.com>

* config/mn10200/tm-mn10200.h (DEPRECATED_PC_IN_CALL_DUMMY):
Delete redundant definition.

21 years agoImport of readline 4.3.
Elena Zannoni [Sun, 8 Dec 2002 22:31:39 +0000 (22:31 +0000)]
Import of readline 4.3.
Non-readline modified files:

src/gdb/ChangeLog src/gdb/defs.h src/gdb/cli/cli-cmds.c
src/gdb/cli/cli-setshow.c src/gdb/tui/ChangeLog
src/gdb/tui/tuiWin.c

In readline directory:

        * compat.c, mbutil.c, misc.c, rlmbutil.h, rltypedefs.h,
        text.c, doc/history.0, doc/history.3, support/wcwidth.c,
        examples/readlinebuf.h, examples/rlcat.c: New files.

        * CHANGELOG, CHANGES, INSTALL,  MANIFEST, Makefile.in, README,
        aclocal.m4, ansi_stdlib.h, bind.c, callback.c, chardefs.h,
        complete.c, config.h.in, configure, configure.in, display.c,
        emacs_keymap.c, funmap.c, histexpand.c, histfile.c, histlib.h,
        history.c, history.h, histsearch.c, input.c, isearch.c,
        keymaps.c, keymaps.h, kill.c, macro.c, nls.c, parens.c,
        posixdir.h, readline.c, readline.h, rlconf.h, rldefs.h,
        rlprivate.h, rlshell.h, rlstdc.h, rltty.c, savestring.c,
        search.c, shell.c, signals.c, terminal.c, tilde.c, tilde.h,
        undo.c, util.c, vi_keymap.c, vi_mode.c, xmalloc.c, xmalloc.h,
        doc/Makefile.in, doc/hist.texinfo, doc/hstech.texinfo,
        doc/hsuser.texinfo, doc/manvers.texinfo, doc/readline.3,
        doc/rlman.texinfo, doc/rltech.texinfo, doc/rluser.texinfo
        doc/rluserman.texinfo, doc/texi2dvi, doc/texi2html,
        shlib/Makefile.in, support/install.sh, support/mkdirs,
        support/mkdist, support/shlib-install, support/shobj-conf,
        examples/Inputrc, examples/Makefile.in, examples/fileman.c,
        examples/histexamp.c, examples/manexamp.c, examples/rl.c,
        examples/rlfe.c, examples/rltest.c, examples/rlversion.c:
        Modified files.

21 years agoFix date...
Elena Zannoni [Sun, 8 Dec 2002 21:11:19 +0000 (21:11 +0000)]
Fix date...

21 years ago2002-12-06 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Sun, 8 Dec 2002 21:10:28 +0000 (21:10 +0000)]
2002-12-06  Elena Zannoni  <ezannoni@redhat.com>

        * Makefile.in (thread-db.o): Add explicit rule to ignore the use of
        -Werror on this file.

21 years ago * m68hc11-dis.c (print_indexed_operand): Fix PC-relative address
Stephane Carrez [Sun, 8 Dec 2002 20:53:19 +0000 (20:53 +0000)]
* m68hc11-dis.c (print_indexed_operand): Fix PC-relative address
for 9 and 16-bit PC-relative addressing mode.

21 years ago2002-12-07 Andrew Cagney <ac131313@redhat.com>
Andrew Cagney [Sun, 8 Dec 2002 20:48:17 +0000 (20:48 +0000)]
2002-12-07  Andrew Cagney  <ac131313@redhat.com>

* gdbarch.sh (TARGET_FLOAT_FORMAT): Use the macro when printing
the format name.
(TARGET_DOUBLE_FORMAT, TARGET_LONG_DOUBLE_FORMAT): Ditto.
* gdbarch.c: Regenerate.

21 years ago * bfd-in.h: Comment typo fix. Formatting.
Alan Modra [Sun, 8 Dec 2002 03:34:38 +0000 (03:34 +0000)]
* bfd-in.h: Comment typo fix.  Formatting.
* bfd-in2.h: Regenerate.
* coff64-rs6000.c (xcoff64_openr_next_archived_file): Warning fix.
* elf32-m68hc12.c (m68hc12_elf_set_mach_from_flags): Prototype.
* elf64-mmix.c (mmix_dump_bpo_gregs): Warning fix.

21 years ago*** empty log message ***
gdbadmin [Sun, 8 Dec 2002 00:00:32 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Sat, 7 Dec 2002 23:00:04 +0000 (23:00 +0000)]
daily update

21 years ago2002-12-06 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Sat, 7 Dec 2002 03:36:46 +0000 (03:36 +0000)]
2002-12-06  Elena Zannoni  <ezannoni@redhat.com>

* tuiStack.c (tuiShowFrameInfo): Fix typo.