OSDN Git Service
Weichuan Yan [Wed, 26 Mar 2014 03:41:15 +0000 (03:41 +0000)]
Fix and clean up strtotimeval
- parsing of fractional part was wrong (always parsed as 0)
- return value was also wrong in the presence of fractional parts
- general style clean up
Change-Id: I1935a63db938dbed7cacb4b5646e993a52c27f1a
Signed-off-by: Weichuan Yan <wchyan@marvell.com>
Calin Juravle [Wed, 26 Mar 2014 14:21:11 +0000 (14:21 +0000)]
Added strtotimeval tests.
Change-Id: I3dfd3647a8494490a2d549bdb915968063a7fb99
Calin Juravle [Wed, 26 Mar 2014 14:23:59 +0000 (14:23 +0000)]
Merge "Clean up CMSG_*HDR in <sys/socket.h>"
Christopher Ferris [Tue, 25 Mar 2014 17:46:30 +0000 (17:46 +0000)]
Merge "Keep the symbol table in the shared libc."
Calin Juravle [Wed, 19 Mar 2014 17:40:23 +0000 (17:40 +0000)]
Clean up CMSG_*HDR in <sys/socket.h>
Removed __CMSG_NXTHDR, __CMSG_FIRSTHDR and cmsg_nxthdr.
Bug:
13418328
Change-Id: I6b1ed58b41b3f37d41e070c4f222b5bfa512bc48
Christopher Ferris [Fri, 21 Mar 2014 18:11:38 +0000 (11:11 -0700)]
Keep the symbol table in the shared libc.
In order to allow the unwinder code to have meaningful names for
libc functions, leave the symbol table. This results in the libc.so
getting to be about ~130K larger on all arm platforms and about ~70K
larger on mips/x86 platforms.
Bug:
12958251
Change-Id: I6b3a97e4824142faf5de46aeabf7c1dfb98a8cc6
Brian Carlstrom [Tue, 25 Mar 2014 00:16:30 +0000 (00:16 +0000)]
Merge "Add include of float.h for LDBL_MIN_EXP and LDBL_MANT_DIG"
Brian Carlstrom [Mon, 24 Mar 2014 23:45:18 +0000 (16:45 -0700)]
Add include of float.h for LDBL_MIN_EXP and LDBL_MANT_DIG
(cherry picked from commit
1711c6ea3a0d891da665325c75738a68bd7d501f)
Change-Id: Ia64676b2b904f042fec678003e3f2cd5bd82b510
Calin Juravle [Mon, 24 Mar 2014 12:13:24 +0000 (12:13 +0000)]
Merge "Fix LP64 libm for 128-bit long doubles"
Calin Juravle [Mon, 24 Mar 2014 12:11:30 +0000 (12:11 +0000)]
Merge "Remove ALIGNBYTES and ALIGN from <sys/param.h>"
Calin Juravle [Fri, 14 Mar 2014 17:56:46 +0000 (17:56 +0000)]
Fix LP64 libm for 128-bit long doubles
* reworked amd64/_fpmath.h and arm64/_fpmath.h to support 128-bit long
doubles.
* improved tests to cover long double cases
* made modfl an alias for LP32
Tests pass on x86, x86_64, arm, arm64 and mips.
Bug:
12921273
Change-Id: Ibe39acde57972447a8950fa45b1e702acc68ebeb
Nick Kralevich [Sat, 22 Mar 2014 17:55:48 +0000 (17:55 +0000)]
Merge "FORTIFY_SOURCE: don't define s?printf macros if already defined"
Mark Salyzyn [Fri, 21 Mar 2014 20:09:32 +0000 (20:09 +0000)]
Merge "libc: Thread IDs missing from logcat -v thread"
Christopher Ferris [Fri, 21 Mar 2014 17:26:58 +0000 (17:26 +0000)]
Merge "Fix deadlock in timer_delete."
Calin Juravle [Thu, 20 Mar 2014 15:21:32 +0000 (15:21 +0000)]
Remove ALIGNBYTES and ALIGN from <sys/param.h>
There are only three users of bionic definition of ALIGN and keeping it
in sys/param.h polutes the namespace.
I inline the definition in the the three places that's used.
Bug:
13400663
Change-Id: I565008e8426c38ffb07422f42cd8e547d53044e9
Christopher Ferris [Fri, 21 Mar 2014 03:47:45 +0000 (20:47 -0700)]
Fix deadlock in timer_delete.
If the callback function for a timer did a timer_delete, the function
would never return. The problem was that the timer_delete function would try
to wait until the timer thread has finished. Waiting for yourself to finish
doesn't work very well.
Bug:
13397340
Change-Id: Ica123a5bafbc8660c8a4a909e5c2dead55ca429d
Mark Salyzyn [Thu, 20 Mar 2014 23:07:55 +0000 (16:07 -0700)]
libc: Thread IDs missing from logcat -v thread
- stuff caller's thread id into the packet.
Bug:
13568206
Change-Id: If8b318ef75c7dcdddb05da8ac3038860f0fda5ec
Calin Juravle [Wed, 19 Mar 2014 18:31:25 +0000 (18:31 +0000)]
Merge "Added a test flag to bionic run-test targets."
Calin Juravle [Wed, 19 Mar 2014 17:45:08 +0000 (17:45 +0000)]
Added a test flag to bionic run-test targets.
It makes it much easier to pass arguments to the tests.
Change-Id: Ia91eba4868627a3cea3f8d2c26ba01af4e860b12
Nick Kralevich [Wed, 19 Mar 2014 00:03:38 +0000 (17:03 -0700)]
FORTIFY_SOURCE: don't define s?printf macros if already defined
Clang specific: Don't #define sprintf and snprintf macros if they
are already defined.
Change-Id: I30fc507d898377e1b8a57a65a147926229e0f9e2
Christopher Ferris [Mon, 17 Mar 2014 23:51:36 +0000 (23:51 +0000)]
Merge "Use the float/double assert macros."
Christopher Ferris [Mon, 17 Mar 2014 23:40:26 +0000 (16:40 -0700)]
Use the float/double assert macros.
The normal ASSERT_EQ macros don't work quite right for float/double values,
and result in false failures. Use the correct macros instead.
Bug:
13511379
Change-Id: Ic2feee7f3d3569f57b6453b8fa95222846c625cd
Calin Juravle [Fri, 14 Mar 2014 10:58:17 +0000 (10:58 +0000)]
Merge "Update libm to the upstream head (2014.03.13)"
Elliott Hughes [Fri, 14 Mar 2014 04:58:19 +0000 (04:58 +0000)]
Merge "Clean up reentrancy cruft."
Elliott Hughes [Thu, 13 Mar 2014 23:17:43 +0000 (16:17 -0700)]
Clean up reentrancy cruft.
The DNS copy of reentrant.h was unused, so remove it.
The strtod implementation can use the upstream-netbsd reentrant.h and
get a little closer to what was then upstream. (It's since been replaced
by gdtoa, and we'll have to follow at some point, but for now this doesn't
make anything any worse.)
ANDROID_CHANGES is (now) only used in the DNS code, so push the -D
down.
The <locale.h> change prevents an LP32 hack from leaking into LP64.
Change-Id: Idf30b98a59d7ca8f7c6cd6d07020b512057911ef
Elliott Hughes [Thu, 13 Mar 2014 23:13:58 +0000 (23:13 +0000)]
Merge "Clean up <stdio.h> macros."
Elliott Hughes [Thu, 13 Mar 2014 21:54:53 +0000 (14:54 -0700)]
Clean up <stdio.h> macros.
Also neuter __isthreaded.
We should come back to try to hide struct FILE's internals for LP64.
Bug:
3453512
Bug:
3453550
Change-Id: I7e115329fb4579246a72fea367b9fc8cb6055d18
Elliott Hughes [Thu, 13 Mar 2014 20:16:17 +0000 (20:16 +0000)]
Merge "property: fix getting dirty serial value"
jiaguo [Thu, 13 Mar 2014 09:39:58 +0000 (17:39 +0800)]
property: fix getting dirty serial value
__system_property_serial just returned serial value without
checking if it is dirty, so check and wait until serial
value is not dirty before return
Change-Id: If485b6251b5555b004912c66c7c2cb455a7fdbdc
Signed-off-by: jiaguo <jiaguo@marvell.com>
Calin Juravle [Thu, 13 Mar 2014 16:20:36 +0000 (16:20 +0000)]
Update libm to the upstream head (2014.03.13)
The most relevant changes are the ones in s_erff.c which should improve
the overall speed of exececution and the maximum error in ULP.
Change-Id: I7bd867f902db418db67f02cd58578624357b1ee8
Elliott Hughes [Thu, 13 Mar 2014 00:49:23 +0000 (00:49 +0000)]
Merge "Upgrade to current upstream scanf implementation."
Elliott Hughes [Thu, 13 Mar 2014 00:10:41 +0000 (17:10 -0700)]
Upgrade to current upstream scanf implementation.
Also add a basic test.
Change-Id: Icc0e68a5716b9579244f6eb8bac1ab5a24eda85a
Elliott Hughes [Wed, 12 Mar 2014 23:32:37 +0000 (23:32 +0000)]
Merge "Ensure we always have symbols for atof, strtof, strtold."
Elliott Hughes [Wed, 12 Mar 2014 23:12:57 +0000 (16:12 -0700)]
Ensure we always have symbols for atof, strtof, strtold.
We'll need a better implementation of strtold for LP64, but all our
long double functions are currently broken for LP64 anyway so this
isn't a regression.
Change-Id: I2bdebac11245d31521d5fa09a16331c03dc4339c
Mark Salyzyn [Wed, 12 Mar 2014 21:02:46 +0000 (21:02 +0000)]
Merge "logd: default user space logger"
Elliott Hughes [Wed, 12 Mar 2014 20:51:48 +0000 (20:51 +0000)]
Merge "Include what you use."
Elliott Hughes [Wed, 12 Mar 2014 20:50:38 +0000 (13:50 -0700)]
Include what you use.
Don't rely on transitive includes. (Even though that works fine in AOSP.)
Change-Id: Ifc06575e4aea383cfff24d6c5c14fc0a7aabdf2b
Elliott Hughes [Wed, 12 Mar 2014 20:48:39 +0000 (20:48 +0000)]
Merge "Use [u]int32_t instead of __[u]int32_t in sys/types.h"
Pavel Chupin [Wed, 12 Mar 2014 07:23:49 +0000 (11:23 +0400)]
Use [u]int32_t instead of __[u]int32_t in sys/types.h
Avoid this error in -ffreestanding mode:
sys/types.h:45:1: error: unknown type name '__uint32_t'
Change-Id: I826b36873862d1d70b47401f31f4369a77666b8e
Signed-off-by: Pavel Chupin <pavel.v.chupin@intel.com>
Mark Salyzyn [Wed, 12 Mar 2014 16:27:53 +0000 (09:27 -0700)]
logd: default user space logger
Change-Id: Id205b01537940051c72d79def28a3c1a8b169a21
Elliott Hughes [Wed, 12 Mar 2014 02:25:22 +0000 (02:25 +0000)]
Merge "Clean up our termios implementation."
Elliott Hughes [Tue, 11 Mar 2014 23:06:23 +0000 (16:06 -0700)]
Clean up our termios implementation.
It's safe to fix our constant definitions because we know we never
had symbols before, so can't be passing the bad old constants to the new
functions, or the correct new constants to the old inlines.
Change-Id: I858fc680df39bdd3ba471e867833bdfa71f6224e
Elliott Hughes [Tue, 11 Mar 2014 22:31:00 +0000 (22:31 +0000)]
Merge "More stdio cleanup."
Elliott Hughes [Tue, 11 Mar 2014 22:05:50 +0000 (15:05 -0700)]
More stdio cleanup.
Change-Id: Idc909cd3dc7b072f1edd2ae4980932d6550e8568
Elliott Hughes [Tue, 11 Mar 2014 21:36:02 +0000 (21:36 +0000)]
Merge "Reimplement clock(3) and switch to OpenBSD time(3)."
Elliott Hughes [Tue, 11 Mar 2014 20:37:11 +0000 (13:37 -0700)]
Reimplement clock(3) and switch to OpenBSD time(3).
The new implementation is a better approximation to the processor time used
by the process because it's actually based on resource usage rather than just
elapsed wall clock time.
Change-Id: I9e13b69c1d3048cadf0eb9dec1e3ebc78225596a
Elliott Hughes [Tue, 11 Mar 2014 20:02:49 +0000 (20:02 +0000)]
Merge "Add a basic unit test for system(3)."
Elliott Hughes [Tue, 11 Mar 2014 19:54:44 +0000 (12:54 -0700)]
Add a basic unit test for system(3).
Change-Id: Ibc5ac21f3663685d89ce261b58d6ea386fc1ff88
Elliott Hughes [Tue, 11 Mar 2014 19:47:38 +0000 (19:47 +0000)]
Merge "Add various benchmarks."
Elliott Hughes [Tue, 11 Mar 2014 18:19:06 +0000 (11:19 -0700)]
Add various benchmarks.
These are based on ones from system/extras/tests/bionic/.
Change-Id: I7b1ae15a2ca5d1031a6a511d97b88125c1770047
Calin Juravle [Tue, 11 Mar 2014 10:50:00 +0000 (10:50 +0000)]
Merge "Sysconfig fixes"
Calin Juravle [Tue, 11 Mar 2014 10:49:46 +0000 (10:49 +0000)]
Merge "Removed pthread_attr_getstackaddr/pthread_attr_setstackaddr"
Calin Juravle [Mon, 10 Mar 2014 18:25:36 +0000 (18:25 +0000)]
Sysconfig fixes
Remove _POSIX_THREAD_ATTR_STACKADDR and _POSIX_THREAD_ATTR_STACKSIZE
since they don't exists. Return -1 for their corresponding values but
don't set errno.
Bug:
13281069
Change-Id: Ice29b4dfebe2b474212e40ee726d86782a3064b9
Calin Juravle [Mon, 10 Mar 2014 18:10:04 +0000 (18:10 +0000)]
Removed pthread_attr_getstackaddr/pthread_attr_setstackaddr
Moved existing definitions to ndk_cruft to preserve NDK compatibility.
Bug:
13281069
Change-Id: I6f260de69afa55a6274f0d13145c19ac6517b9d5
Elliott Hughes [Tue, 11 Mar 2014 01:41:21 +0000 (01:41 +0000)]
Merge "Add system/extras strftime and strptime tests."
Elliott Hughes [Tue, 11 Mar 2014 01:19:03 +0000 (18:19 -0700)]
Add system/extras strftime and strptime tests.
Change-Id: I889c58f6e2e27b99cf6328a8671858d2e5feaa4e
Elliott Hughes [Tue, 11 Mar 2014 00:40:56 +0000 (00:40 +0000)]
Merge "Take ownership of various simple syscall wrappers."
Elliott Hughes [Tue, 11 Mar 2014 00:17:01 +0000 (17:17 -0700)]
Take ownership of various simple syscall wrappers.
None of these trivial functions is something we're going to get from BSD.
Change-Id: Iee1d1281b73db67da5ec303da7a49748121464bf
Elliott Hughes [Mon, 10 Mar 2014 23:37:27 +0000 (23:37 +0000)]
Merge "Switch to NetBSD utmp.c."
Elliott Hughes [Mon, 10 Mar 2014 23:32:35 +0000 (16:32 -0700)]
Switch to NetBSD utmp.c.
Change-Id: Ibe94888aa48b5b28fea97fd5719a1ed7a23ddeb3
Elliott Hughes [Mon, 10 Mar 2014 23:25:38 +0000 (23:25 +0000)]
Merge "Switch to upstream FreeBSD ldexp.c."
Elliott Hughes [Mon, 10 Mar 2014 23:25:04 +0000 (23:25 +0000)]
Merge "Rename the stack protector intermediate library."
Elliott Hughes [Mon, 10 Mar 2014 23:23:09 +0000 (16:23 -0700)]
Switch to upstream FreeBSD ldexp.c.
(Yes, this should be in libm, but it isn't. For once, this mistake predates
bionic!)
Change-Id: I1340407acbcdc0151dee969a38ba490bdd5e6767
Elliott Hughes [Mon, 10 Mar 2014 23:21:08 +0000 (23:21 +0000)]
Merge "Switch to OpenBSD wcscoll."
Elliott Hughes [Mon, 10 Mar 2014 23:15:11 +0000 (16:15 -0700)]
Rename the stack protector intermediate library.
libbionic_ssp already confused at least one person, and characters
in filenames are cheap, so let's just call this library what it is.
Change-Id: I69ab950bf52fa4d267a6891efb49b5e177efc0c4
Elliott Hughes [Mon, 10 Mar 2014 23:12:58 +0000 (23:12 +0000)]
Merge "Remove non-standard memswap."
Elliott Hughes [Mon, 10 Mar 2014 23:11:59 +0000 (16:11 -0700)]
Switch to OpenBSD wcscoll.
Change-Id: I1050ef728e18124656e76f32b42ac9a4688f252d
Elliott Hughes [Mon, 10 Mar 2014 22:54:40 +0000 (15:54 -0700)]
Remove non-standard memswap.
Change-Id: I06548dda339987b755ef7139c590ca3e1f9fe0a9
Elliott Hughes [Mon, 10 Mar 2014 22:21:35 +0000 (22:21 +0000)]
Merge "Upgrade to tzdata2014a."
Elliott Hughes [Mon, 10 Mar 2014 22:19:05 +0000 (15:19 -0700)]
Upgrade to tzdata2014a.
From the release notes:
Changes affecting near-future time stamps
Turkey begins DST on 2014-03-31, not 03-30. (Thanks to Faruk Pasin
for the heads-up, and to Tim Parenti for simplifying the update.)
Changes affecting past time stamps
Fiji ended DST on 2014-01-19 at 02:00, not the previously-scheduled
03:00. (Thanks to Steffen Thorsen.)
Ukraine switched from Moscow to Eastern European time on 1990-07-01
(not 1992-01-01), and observed DST during the entire next winter.
(Thanks to Vladimir in Moscow via Alois Treindl.)
In 1988 Israel observed DST from 04-10 to 09-04, not 04-09 to
09-03. (Thanks to Avigdor Finkelstein.)
Bug:
13193205
Change-Id: Ie2e4fd48491315f3e97befff0c8ea797a766c676
Calin Juravle [Mon, 10 Mar 2014 11:25:50 +0000 (11:25 +0000)]
Merge "Update the NOTICE files"
Calin Juravle [Mon, 10 Mar 2014 11:23:52 +0000 (11:23 +0000)]
Update the NOTICE files
Change-Id: I751c4eeda813b811faa4ee26c64445896db3d5bd
Calin Juravle [Mon, 10 Mar 2014 11:20:12 +0000 (11:20 +0000)]
Merge "Update res_debug.c to take into account changes to the nameser.h"
Brian Carlstrom [Sat, 8 Mar 2014 23:41:45 +0000 (23:41 +0000)]
Merge "Add includes for waitpid"
Brian Carlstrom [Sat, 8 Mar 2014 23:05:26 +0000 (15:05 -0800)]
Add includes for waitpid
(cherry picked from commit
f07c5dd9ab63f2e8ba736107bd4b69bbd8829c9f)
Change-Id: I7a765fd7a3a5f8f29a703f6a591c4fd8df4ebf1c
Elliott Hughes [Sat, 8 Mar 2014 03:07:46 +0000 (03:07 +0000)]
Merge "Fix pthread_detach for already-exited threads."
Elliott Hughes [Sat, 8 Mar 2014 01:59:05 +0000 (17:59 -0800)]
Fix pthread_detach for already-exited threads.
Change-Id: I2bf7f41234d93b226132a4c51705f4186f4961c3
Reported-by: Paresh Nakhe <pnakhe@codeaurora.org>
Elliott Hughes [Sat, 8 Mar 2014 00:52:02 +0000 (00:52 +0000)]
Merge "Add si_timerid to <signal.h>."
Elliott Hughes [Sat, 8 Mar 2014 00:50:56 +0000 (00:50 +0000)]
Merge "Rewrite the POSIX timer functions."
Elliott Hughes [Tue, 4 Mar 2014 23:58:02 +0000 (15:58 -0800)]
Rewrite the POSIX timer functions.
This is a much simpler implementation that lets the kernel
do as much as possible.
Co-authored-by: Jörgen Strand <jorgen.strand@sonymobile.com>
Co-authored-by: Snild Dolkow <snild.dolkow@sonymobile.com>
Change-Id: Iad19f155de977667aea09410266d54e63e8a26bf
Elliott Hughes [Fri, 7 Mar 2014 23:41:25 +0000 (15:41 -0800)]
Add si_timerid to <signal.h>.
The kernel uses the very misleading name "si_tid", but glibc uses the more
intention-revealing "si_timerid". We should let people use that.
(Added because I wanted to improve SI_TIMER siginfo_t dumping in strace.)
Change-Id: Ib626cdd3b57a6afb276a15753a237b4e81ec45e3
Calin Juravle [Fri, 7 Mar 2014 20:03:57 +0000 (20:03 +0000)]
Update res_debug.c to take into account changes
to the nameser.h
Bug:
13219633
Change-Id: Id75de2e8933f716ad86ca296a97f5c619fb946a7
Calin Juravle [Fri, 7 Mar 2014 11:46:48 +0000 (11:46 +0000)]
Merge "Fix broken pointer overflow check ns_name_unpack()"
Calin Juravle [Fri, 7 Mar 2014 11:45:58 +0000 (11:45 +0000)]
Merge "Sync up nameser with upstream(2014.03.05)"
Elliott Hughes [Fri, 7 Mar 2014 01:03:24 +0000 (01:03 +0000)]
Merge "Fix some pthread symbols build as C++ symbol under x64 lunch."
Elliott Hughes [Thu, 6 Mar 2014 23:12:15 +0000 (23:12 +0000)]
Merge "Bring the generate-NOTICE script up to date."
Elliott Hughes [Thu, 6 Mar 2014 23:10:22 +0000 (15:10 -0800)]
Bring the generate-NOTICE script up to date.
Change-Id: I63981a2f3cb0a4d7ee7e1a2b4ce00f77898ac25b
Elliott Hughes [Thu, 6 Mar 2014 23:07:08 +0000 (23:07 +0000)]
Merge "Update the NOTICE files."
Elliott Hughes [Thu, 6 Mar 2014 23:06:11 +0000 (15:06 -0800)]
Update the NOTICE files.
Change-Id: Ie72a01cddd5b813393656f603689e497b0f88ddd
Elliott Hughes [Thu, 6 Mar 2014 23:02:11 +0000 (23:02 +0000)]
Merge "Add ARMv8 optimized string handling functions based on cortex-strings"
Bernhard Rosenkraenzer [Wed, 5 Mar 2014 10:40:57 +0000 (11:40 +0100)]
Add ARMv8 optimized string handling functions based on cortex-strings
This adds ARMv8 optimized string handling functions to Bionic.
The implementations live in a generic/ directory because there will
likely be more CPU specific versions (e.g. Cortex-A53 vs. Cortex-A57)
later.
These implementations are 50%+ faster on current v8 models.
Change-Id: If3adc54a284d9519459b0d4d4390f0cd6ded8786
Signed-off-by: Bernhard Rosenkraenzer <Bernhard.Rosenkranzer@linaro.org>
Calin Juravle [Thu, 6 Mar 2014 17:05:49 +0000 (17:05 +0000)]
Fix broken pointer overflow check ns_name_unpack()
Many compilers may optimize away the overflow check `msg + l < msg',
where `msg' is a pointer and `l' is an integer, because pointer
overflow is undefined behavior in C.
Use a safe precondition test `l >= eom - msg' instead.
Bug:
13219633
Change-Id: I3fca2125834073cc36d7e9c4e586e97842265a59
Calin Juravle [Wed, 5 Mar 2014 15:06:52 +0000 (15:06 +0000)]
Sync up nameser with upstream(2014.03.05)
Bug:
13219633
Change-Id: I8ee4ddf270710e9eea415fa3db984af7719a8dd4
Mark Salyzyn [Thu, 6 Mar 2014 01:01:17 +0000 (01:01 +0000)]
Merge "libc: libc_logging 64bit compile issue"
Mark Salyzyn [Wed, 5 Mar 2014 21:44:00 +0000 (13:44 -0800)]
libc: libc_logging 64bit compile issue
- user space logger wire format for time
Change-Id: I4840653e3a6ae151a02584311d1227d2fe536d0f
Narayan Kamath [Wed, 5 Mar 2014 13:19:21 +0000 (13:19 +0000)]
Merge "Stop defining HAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC."
Narayan Kamath [Tue, 4 Mar 2014 16:16:43 +0000 (16:16 +0000)]
Stop defining HAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC.
No code is using this definition.
Change-Id: I188db63f38d62baf1cb57d0a36fcda540ad98492
Halton Huo [Fri, 21 Feb 2014 10:05:29 +0000 (18:05 +0800)]
Fix some pthread symbols build as C++ symbol under x64 lunch.
Functions protected with !defined(__LP64__) will be get build as C++
symbols for X64 build. This is not the desired work. So protect the
implementation with !defined(__LP64__) as well.
Change-Id: I4ef50ec36e46289ab308063e24f6c5ac61a6ca8d
Elliott Hughes [Tue, 4 Mar 2014 19:04:19 +0000 (19:04 +0000)]
Merge "Remove dead NULL checks from pthread code."
Elliott Hughes [Tue, 4 Mar 2014 18:55:39 +0000 (10:55 -0800)]
Remove dead NULL checks from pthread code.
GCC is removing these checks anyway because it knows the arguments
must be non-null, so leaving this code around is just confusing.
We know from experience that people were shipping code with locking
bugs because they weren't checking for error returns. Failing hard
like glibc does seems the better choice. (And it's what the checked
in code was already doing; this patch doesn't change that. It just
makes it more obvious that that's what's going on.)
Change-Id: I167c6d7c0a296822baf0cb9b43b97821eba7ab35