OSDN Git Service
Bruce Momjian [Mon, 21 Oct 2002 20:35:07 +0000 (20:35 +0000)]
Add:
> * Allow pg_dump to dump a specific schema
Bruce Momjian [Mon, 21 Oct 2002 20:34:09 +0000 (20:34 +0000)]
Small update for the removal of some memory leaks in plpython SGML example.
Nigel J. Andrews
Bruce Momjian [Mon, 21 Oct 2002 20:33:21 +0000 (20:33 +0000)]
When I removed the cube based stuff from eathdistance I accidentally
left a reference to cube in a comment in the regression test (that also
shows up in the expected output). This doesn't cause any real problem,
but people who read the comment might be confused. Attached is a diff to
remove the reference.
Bruno Wolff III
Bruce Momjian [Mon, 21 Oct 2002 20:32:33 +0000 (20:32 +0000)]
Cleanup for CLUSTERDB failure:
On Sat, Oct 19, 2002 at 12:11:32AM +0200, Peter Eisentraut wrote:
> $ ./clusterdb
> psql: could not connect to server: No such file or directory
> Is the server running locally and accepting
> connections on Unix domain socket "/tmp/.s.PGSQL.5432"?
> psql: could not connect to server: No such file or directory
> Is the server running locally and accepting
> connections on Unix domain socket "/tmp/.s.PGSQL.5432"?
> clusterdb: While clustering peter, the following failed:
> $
>
> This could probably handled a little more gracefully.
Yes, sorry. A patch for this is attached. Please apply.
Alvaro Herrera
Bruce Momjian [Mon, 21 Oct 2002 20:31:52 +0000 (20:31 +0000)]
Fix ALTER TABLE ... ADD COLUMN for inheritance cases.
Alvaro Herrera
Tom Lane [Mon, 21 Oct 2002 19:59:14 +0000 (19:59 +0000)]
Remove unnecessary (and inadequate) check of IsTransactionBlock() in
pgstat_vacuum_tabstat(). Assume that caller (namely, VACUUM) has done
the appropriate state checking beforehand.
Tom Lane [Mon, 21 Oct 2002 19:55:49 +0000 (19:55 +0000)]
Avoid using IsTransactionBlock() in DeferredTriggerSetState(); no real
need for this optimization, and it's too easily fooled anyway.
Tom Lane [Mon, 21 Oct 2002 19:46:45 +0000 (19:46 +0000)]
Make CREATE/ALTER/DROP USER/GROUP transaction-safe, or at least pretty
nearly so, by postponing write of flat password file until transaction
commit.
Peter Eisentraut [Mon, 21 Oct 2002 18:57:35 +0000 (18:57 +0000)]
Add DLLIMPORT declarations needed by contrib modules.
Peter Eisentraut [Mon, 21 Oct 2002 18:56:30 +0000 (18:56 +0000)]
Need sys/param.h for endianness macros.
Peter Eisentraut [Mon, 21 Oct 2002 18:55:10 +0000 (18:55 +0000)]
Might need to link with -lcrypt.
Peter Eisentraut [Mon, 21 Oct 2002 18:53:20 +0000 (18:53 +0000)]
Add guards against double inclusion.
Peter Eisentraut [Mon, 21 Oct 2002 18:51:03 +0000 (18:51 +0000)]
Translation updates
Peter Eisentraut [Mon, 21 Oct 2002 18:05:24 +0000 (18:05 +0000)]
Remove obsoleted stuff merged in from branch.
Peter Eisentraut [Mon, 21 Oct 2002 18:04:05 +0000 (18:04 +0000)]
Improve ECPG documentation.
Michael Meskes [Mon, 21 Oct 2002 13:09:31 +0000 (13:09 +0000)]
Merged ecpg_big_bison back into HEAD
Tatsuo Ishii [Mon, 21 Oct 2002 05:14:06 +0000 (05:14 +0000)]
Update multibyte Japanese document
Tom Lane [Mon, 21 Oct 2002 04:33:39 +0000 (04:33 +0000)]
Since ANY is a reserved word, better suggest that ANY be quoted when
used for the input type of an aggregate.
Tom Lane [Mon, 21 Oct 2002 02:12:08 +0000 (02:12 +0000)]
Fix documented sizes of geometric types.
Tom Lane [Mon, 21 Oct 2002 02:11:37 +0000 (02:11 +0000)]
Fix example of doing a restore.
Bruce Momjian [Mon, 21 Oct 2002 01:42:14 +0000 (01:42 +0000)]
SET autocommit no longer needed in /contrib because pg_regress.sh does
it automatically now on regression session startup.
Bruce Momjian [Mon, 21 Oct 2002 00:47:44 +0000 (00:47 +0000)]
Updates from Ian Barwick.
Bruce Momjian [Mon, 21 Oct 2002 00:36:24 +0000 (00:36 +0000)]
Done:
> * -Move /contrib/retep to gborg.postgresql.org
Bruce Momjian [Mon, 21 Oct 2002 00:35:41 +0000 (00:35 +0000)]
Completely remove /contrib/retep, with Peter's approval; now on Source
Forge.
Bruce Momjian [Mon, 21 Oct 2002 00:12:46 +0000 (00:12 +0000)]
First step to removing /contrib/retep, with Peter Mount's approval.
Bruce Momjian [Sun, 20 Oct 2002 20:58:02 +0000 (20:58 +0000)]
Remove trailing blanks in cvs.sgml.
Tom Lane [Sun, 20 Oct 2002 20:47:31 +0000 (20:47 +0000)]
Fix potential problem with btbulkdelete deleting an indexscan's current
item, if the page containing the current item is split while the indexscan
is stopped and holds no read-lock on the page. The current item might
move right onto a page that the indexscan holds no pin on. In the prior
code this would allow btbulkdelete to reach and possibly delete the item,
causing 'my bits moved right off the end of the world!' when the indexscan
finally resumes. Fix by chaining read-locks to the right during
_bt_restscan and requiring btbulkdelete to LockBufferForCleanup on every
page it scans, not only those with deletable items. Per my pghackers
message of 25-May-02. (Too bad no one could think of a better way.)
Tom Lane [Sun, 20 Oct 2002 19:38:10 +0000 (19:38 +0000)]
Fix core dump recently introduced into pgbench.
Tatsuo Ishii [Sun, 20 Oct 2002 11:33:48 +0000 (11:33 +0000)]
Returns exit status 1 if invalid encoding name or
encoding number is given.
Tom Lane [Sun, 20 Oct 2002 05:05:46 +0000 (05:05 +0000)]
Update description of numeric constants to match 7.3 reality.
Miscellaneous other copy-editing.
Bruce Momjian [Sun, 20 Oct 2002 02:58:56 +0000 (02:58 +0000)]
Update char/varchar()/text/bytea to mention they have similar performance
characteristics.
Barry Lind [Sun, 20 Oct 2002 02:55:50 +0000 (02:55 +0000)]
Applied patch from Teofilis Martisius to improve performance.
Also removed some unused files and fixed the which needed a small change
after the previous patch to build.xml.
Modified Files:
jdbc/Makefile jdbc/org/postgresql/core/Encoding.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java
Removed Files:
jdbc/utils/CheckVersion.java jdbc/utils/buildDriver
jdbc/utils/changelog.pl
Bruce Momjian [Sun, 20 Oct 2002 02:51:21 +0000 (02:51 +0000)]
Add:
> * Make a transaction-safe TRUNCATE
Bruce Momjian [Sun, 20 Oct 2002 02:37:49 +0000 (02:37 +0000)]
Update Japanese FAQ, from Jun Kuwamura.
Bruce Momjian [Sun, 20 Oct 2002 02:30:04 +0000 (02:30 +0000)]
Add:
> o Add GUC parameter to control the maximum number of rewrite cycles
Tom Lane [Sun, 20 Oct 2002 01:43:32 +0000 (01:43 +0000)]
Add warning that autocommit=off is not well-supported yet.
Tom Lane [Sun, 20 Oct 2002 01:38:18 +0000 (01:38 +0000)]
Move BeOS and QNX4 to unsupported-platform list, until someone cares
to expend the effort to update them for new semaphore code.
Tom Lane [Sun, 20 Oct 2002 00:58:55 +0000 (00:58 +0000)]
Rule rewriter was doing the wrong thing with conditional INSTEAD rules
whose conditions might yield NULL. The negated qual to attach to the
original query is properly 'x IS NOT TRUE', not 'NOT x'. This fix
produces correct behavior, but we may be taking a performance hit because
the planner is much stupider about IS NOT TRUE than it is about NOT
clauses. Future TODO: teach prepqual, other parts of planner how to
cope with BooleanTest clauses more effectively.
Tom Lane [Sun, 20 Oct 2002 00:31:53 +0000 (00:31 +0000)]
Disallow aggregate functions in rule WHERE clauses. Per gripe from
Fritz Lehmann-Grube back in January.
Barry Lind [Sun, 20 Oct 2002 00:10:55 +0000 (00:10 +0000)]
Applied patch submitted by Mike Beachy to give a better error message if
configure hasn't been run before trying to build.
Also cleaned up the README file and removed some obsolete files.
Modified Files:
jdbc/README jdbc/build.xml
Removed Files:
jdbc/CHANGELOG jdbc/Implementation jdbc/jdbc.jpx
Tom Lane [Sat, 19 Oct 2002 23:09:20 +0000 (23:09 +0000)]
Fix inconsistent formatting.
Tom Lane [Sat, 19 Oct 2002 22:51:45 +0000 (22:51 +0000)]
Fix incomplete definition of ALTER TABLE ADD/DROP CONSTRAINT syntax.
Add some verbiage about recent tweaks to behavior of ADD and DROP
COLUMN when there are descendant tables.
Tom Lane [Sat, 19 Oct 2002 22:10:58 +0000 (22:10 +0000)]
Fix within-function memory leaks in the various PLs' interfaces to
SPI_prepare: they all save the prepared plan into topCxt, and so the
procCxt copy that's actually returned by SPI_prepare ought to be freed.
Diagnosis and plpython fix by Nigel Andrews, followup for other PLs
by Tom Lane.
Barry Lind [Sat, 19 Oct 2002 22:10:36 +0000 (22:10 +0000)]
Applied patch submitted by Kris Jurka to result in a better error message
under some circumstances and handle negative money values better.
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
Tom Lane [Sat, 19 Oct 2002 22:01:45 +0000 (22:01 +0000)]
Fix pltcl self-test for recent changes to elog.
Barry Lind [Sat, 19 Oct 2002 21:53:42 +0000 (21:53 +0000)]
Backed out part of the change from 1.6. The attempt to support int8 binds
in such a way that indexes on int8 columns would be used (by quoting the value)
caused other problems. Will need to wait for the backend to properly fix
the root problem.
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
Tom Lane [Sat, 19 Oct 2002 21:23:20 +0000 (21:23 +0000)]
Fix case where a function in FROM returns a scalar type, but is
referred to with whole-tuple syntax.
Tom Lane [Sat, 19 Oct 2002 20:50:44 +0000 (20:50 +0000)]
Make psql's \df display functions that return sets as having return type
'setof something'; formerly you could not tell at all that the function
returns set.
Tom Lane [Sat, 19 Oct 2002 20:15:09 +0000 (20:15 +0000)]
Invert logic in pg_exec_query_string() so that we set a snapshot for
all utility statement types *except* a short list, per discussion a few
days ago. Add missing SetQuerySnapshot calls in VACUUM and REINDEX,
and guard against calling REINDEX DATABASE from a function (has same
problem as VACUUM).
Tom Lane [Sat, 19 Oct 2002 19:00:47 +0000 (19:00 +0000)]
Fix rewrite code so that rules are in fact executed in order by name,
rather than being reordered according to INSTEAD attribute for
implementation convenience.
Also, increase compiled-in recursion depth limit from 10 to 100 rewrite
cycles. 10 seems pretty marginal for situations where multiple rules
exist for the same query. There was a complaint about this recently,
so I'm going to bump it up. (Perhaps we should make the limit a GUC
parameter, but that's too close to being a new feature to do in beta.)
Bruce Momjian [Sat, 19 Oct 2002 03:01:09 +0000 (03:01 +0000)]
Back out Alvaro's patch until regression tests pass.
Tom Lane [Sat, 19 Oct 2002 02:56:16 +0000 (02:56 +0000)]
Fix range-query estimation to not double-exclude NULLs, per gripe from
Ray Ontko 28-June-02. Also, fix prefix_selectivity for NAME lefthand
variables (it was bogusly assuming binary compatibility), and adjust
make_greater_string() to not call pg_mbcliplen() with invalid multibyte
data (this last per bug report that I can't find at the moment, but it
was in July '02).
Bruce Momjian [Sat, 19 Oct 2002 02:31:10 +0000 (02:31 +0000)]
Add:
> * Move /contrib/retep to gborg.postgresql.org
Bruce Momjian [Sat, 19 Oct 2002 02:25:51 +0000 (02:25 +0000)]
Fix compile failure caused by new patch.
Bruce Momjian [Sat, 19 Oct 2002 02:23:26 +0000 (02:23 +0000)]
Remove mention of utils/getopt.c. Not used anymore.
Bruce Momjian [Sat, 19 Oct 2002 02:16:40 +0000 (02:16 +0000)]
It includes
-Support for mirroring tables in different Schema's
-Improved documentation for compiling with 7.1.x and 7.2.x
-Fixes a buffer overrun bug.
Steven Singer
Bruce Momjian [Sat, 19 Oct 2002 02:09:45 +0000 (02:09 +0000)]
> Huh, I don't know where I got the idea you were (or someone else was?)
> in the position that attislocal should be reset. I'll clean everything
> up and submit the patch I had originally made.
All right, this is it. This patch merely checks if child tables have
the column. If atttypid and atttypmod are the same, the attributes'
attinhcount is incremented; else the operation is aborted. If child
tables don't have the column, recursively add it.
attislocal is not touched in any case.
Alvaro Herrera
Bruce Momjian [Sat, 19 Oct 2002 02:08:19 +0000 (02:08 +0000)]
This patch adds some missing functions for float8 math operations,
specifically ceil(), floor(), and sign(). There may be other functions
that need to be added, but this is a start. I've included some simple
regression tests.
Neil Conway
Bruce Momjian [Sat, 19 Oct 2002 01:35:43 +0000 (01:35 +0000)]
Make regression tests safe for autocommit = 'off'.
Tom Lane [Sat, 19 Oct 2002 00:25:36 +0000 (00:25 +0000)]
Add missing #include <errno.h>.
Tom Lane [Sat, 19 Oct 2002 00:22:14 +0000 (00:22 +0000)]
Fix psql's \copy to accept table names containing schemas, as well as
a column list. Bring its parsing of quoted names and quoted strings
somewhat up to speed --- I believe it now handles all non-error cases
the same way the backend would, but weird boundary conditions are not
necessarily done the same way.
Peter Eisentraut [Fri, 18 Oct 2002 22:05:36 +0000 (22:05 +0000)]
Improve formatting of --help output.
Tom Lane [Fri, 18 Oct 2002 20:44:02 +0000 (20:44 +0000)]
Fix breakage that had crept into setlocale() usage: once again we've
been bit by the fact that the locale functions return pointers to
modifiable variables. I added some comments that might help us avoid
the mistake in future.
Tom Lane [Fri, 18 Oct 2002 20:33:57 +0000 (20:33 +0000)]
Make 'dummy' declarations in header files be 'extern int no_such_variable'
instead of 'extern int errno'; the latter is unsafe according to the
ANSI C standard, as well as in practice on some platforms.
Tom Lane [Fri, 18 Oct 2002 19:35:28 +0000 (19:35 +0000)]
Un-break createlang build.
Bruce Momjian [Fri, 18 Oct 2002 19:11:27 +0000 (19:11 +0000)]
Clean up for dblink autocommit OFF handling.
Bruce Momjian [Fri, 18 Oct 2002 18:41:22 +0000 (18:41 +0000)]
Update /contrib for "autocommit TO 'on'".
Create objects in public schema.
Make spacing/capitalization consistent.
Remove transaction block use for object creation.
Remove unneeded function GRANTs.
Tom Lane [Fri, 18 Oct 2002 18:26:22 +0000 (18:26 +0000)]
Improve discussion of FOR UPDATE.
Bruce Momjian [Thu, 17 Oct 2002 23:34:10 +0000 (23:34 +0000)]
Update for tables returning function, item 5.3, from Joe Conway.
Barry Lind [Thu, 17 Oct 2002 19:17:08 +0000 (19:17 +0000)]
Fix in updateable result sets to handle binding null values correctly
Patch submitted by Kris Jurka (applied with some modifications)
Modified Files:
jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSet.java
Tom Lane [Thu, 17 Oct 2002 14:53:32 +0000 (14:53 +0000)]
Fix free-slot search in PgSetResultId so it actually works.
Tom Lane [Thu, 17 Oct 2002 14:51:50 +0000 (14:51 +0000)]
Improve formatting of error message.
Barry Lind [Thu, 17 Oct 2002 05:33:52 +0000 (05:33 +0000)]
Fixed support in jdbc for 7.3 server autocommit. With these changes the
jdbc regression tests pass for both autocommit on and autocommit off
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java
jdbc/org/postgresql/test/jdbc2/ConnectionTest.java
Bruce Momjian [Thu, 17 Oct 2002 03:58:22 +0000 (03:58 +0000)]
Add:
> o Allow copy to understand \x as hex
Peter Eisentraut [Wed, 16 Oct 2002 22:06:33 +0000 (22:06 +0000)]
Put the disk information all in one chapter.
Bruce Momjian [Wed, 16 Oct 2002 05:46:54 +0000 (05:46 +0000)]
Make pg_dump save for autocommit = off.
Bruce Momjian [Wed, 16 Oct 2002 04:38:00 +0000 (04:38 +0000)]
Fix from Joe on timeout code.
Bruce Momjian [Wed, 16 Oct 2002 03:44:28 +0000 (03:44 +0000)]
Improve appearance of SET command.
Bruce Momjian [Wed, 16 Oct 2002 03:24:09 +0000 (03:24 +0000)]
Fix script to handle autocommit = 'off' by prepending autocommit 'on' to
the start of the psql commandline. This is better than adding BEGIN/END
because it handles multiple queries well, and allows the return code for
psql to return the proper value.
Bruce Momjian [Wed, 16 Oct 2002 02:55:30 +0000 (02:55 +0000)]
Fix connection_timeout to use time() and handle timeout == 1.
Code cleanup.
Bruce Momjian [Tue, 15 Oct 2002 21:34:10 +0000 (21:34 +0000)]
Remove:
< * Rename oid2name to relfilenode2name and install by default
< * Move /contrib/oid2name to /bin, rename to relfilenode2name
Bruce Momjian [Tue, 15 Oct 2002 18:54:56 +0000 (18:54 +0000)]
Add:
> * Move /contrib/oid2name to /bin, rename to relfilenode2name
Tom Lane [Tue, 15 Oct 2002 16:44:21 +0000 (16:44 +0000)]
Fix unintentional breakage of COPY TO/FROM stdin. Mea culpa.
Tom Lane [Tue, 15 Oct 2002 16:04:17 +0000 (16:04 +0000)]
Fix Linux dynloader code for pre-HAVE_DLOPEN systems, which evidently
are still in use out there. Per report from Brendan LeFebvre.
Tom Lane [Tue, 15 Oct 2002 02:24:16 +0000 (02:24 +0000)]
Fix psql to cope with autocommit off, at least during startup.
Behavior of backslash commands (especially for large objects)
may still require some thought.
Tom Lane [Tue, 15 Oct 2002 01:48:25 +0000 (01:48 +0000)]
Fix libpq startup code to work correctly in autocommit off mode.
In passing, fix breakage for case where PGCLIENTENCODING is set in
environment.
Tom Lane [Mon, 14 Oct 2002 23:49:20 +0000 (23:49 +0000)]
Make SPI's execution of querystrings follow the rules agreed to for
command status at the interactive level. SPI_processed, etc are set
in the same way as the returned command status would have been set if
the same querystring were issued interactively. Per gripe from
Michael Paesold 25-Sep-02.
Bruce Momjian [Mon, 14 Oct 2002 22:43:45 +0000 (22:43 +0000)]
None.
Tom Lane [Mon, 14 Oct 2002 22:14:35 +0000 (22:14 +0000)]
Adjust handling of command status strings in the presence of rules,
as per recent pghackers discussions. initdb forced due to change in
fields of stored Query nodes.
Tom Lane [Mon, 14 Oct 2002 22:12:49 +0000 (22:12 +0000)]
Add missing entries for bit<->int4 and bit<->int8 conversions.
Peter Eisentraut [Mon, 14 Oct 2002 19:04:28 +0000 (19:04 +0000)]
Translation updates
Bruce Momjian [Mon, 14 Oct 2002 18:11:17 +0000 (18:11 +0000)]
Mention that resetting the timeout may be wrong on select retry.
Bruce Momjian [Mon, 14 Oct 2002 17:33:08 +0000 (17:33 +0000)]
Restore ptmp_timeout for cases where no timeout is passed.
Bruce Momjian [Mon, 14 Oct 2002 17:15:11 +0000 (17:15 +0000)]
libpq connection_timeout doesn't do subsecond timing, so make the code
clear on that point.
Tom Lane [Mon, 14 Oct 2002 16:51:30 +0000 (16:51 +0000)]
Arrange to copy relcache's trigdesc structure at the start of any
query that uses it. This ensures that triggers will be applied consistently
throughout a query even if someone commits changes to the relation's
pg_class.reltriggers field meanwhile. Per crash report from Laurette Cisneros.
While at it, simplify memory management in relcache.c, which no longer
needs the old hack to try to keep trigger info in the same place over
a relcache entry rebuild. (Should try to fix rd_att and rewrite-rule
access similarly, someday.) And make RelationBuildTriggers simpler and
more robust by making it build the trigdesc in working memory and then
CopyTriggerDesc() into cache memory.
Bruce Momjian [Mon, 14 Oct 2002 04:29:23 +0000 (04:29 +0000)]
- Link the entries in the table to the catalog heading
- Wrap them in the <database class="table"> tags, since thats what they
are (no markup rules for this, so it inherits from parent -- no style
change)
- Mention that pg_database, pg_shadow, and pg_group are global, and the
rest are local to the specific DB. (I believe this is correct).
> Works for me, though I suppose we could explain what the exceptions are
> like in general terms. Perhaps something like
>
> 'Most system catalogs are copied from the template database during
> database creation, and are thereafter database-specific. A few
> catalogs are physically shared across all databases in an installation;
> these are marked in the descriptions of the individual catalogs.'
Ok, new patch.
Rod Taylor
Bruce Momjian [Mon, 14 Oct 2002 04:27:25 +0000 (04:27 +0000)]
This trivial patch fixes a bunch of spelling mistakes in the
contrib/dbmirror/README.dbmirror doc file.
Neil Conway
Bruce Momjian [Mon, 14 Oct 2002 04:26:54 +0000 (04:26 +0000)]
As Niel so nicely pointed out this morning, the output of EXPLAIN
ANALYZE is not quite clear when branches of the query are never
executed. So this tiny patch fixes that.
The patch is attached and can also be found at:
http://svana.org/kleptog/pgsql/pgsql-explain.patch
Martijn van Oosterhout
Bruce Momjian [Mon, 14 Oct 2002 04:20:52 +0000 (04:20 +0000)]
I have attached two patches as per:
1) pltcl:
Add SPI_freetuptable() calls to avoid memory leaks (Me + Neil Conway)
Change sprintf()s to snprintf()s (Neil Conway)
Remove header files included elsewhere (Neil Conway)
2)plpython:
Add SPI_freetuptable() calls to avoid memory leaks
Cosemtic change to remove a compiler warning
Notes:
I have tested pltcl.c for
a) the original leak problem reported for the repeated call of spi_exec
in a TCL fragment
and
b) the subsequent report resulting from the use of spi_exec -array
in a TCL
fragment.
The plpython.c patch is exactly the same as that applied to make
revision 1.23,
the plpython_schema.sql and feature.expected sections of the patch are
also the
same as last submited, applied and subsequently reversed out. It remains
untested by me (other than via make check). However, this should be safe
provided PyString_FromString() _copies_ the given string to make a
PyObject.
Nigel J. Andrews
Bruce Momjian [Mon, 14 Oct 2002 03:15:33 +0000 (03:15 +0000)]
Improvements to Ian Barwick patch.