OSDN Git Service
Jakub Pawlowski [Wed, 1 Nov 2017 23:35:56 +0000 (23:35 +0000)]
Don't notify legacy advertiser in master role.
am:
874ef327d4
Change-Id: I7aaa97fb72abd91d332418e07ac21e56529143bc
Jakub Pawlowski [Wed, 1 Nov 2017 21:03:39 +0000 (14:03 -0700)]
Don't notify legacy advertiser in master role.
Legacy advertiser should be notified about connection success only
if we're the slave of connection.
Bug:
68712406
Test: bonding with device while using legacy advertising
Change-Id: I4790fb9c8a4f58ea76f6b28fd5384479f2fee0d8
Myles Watson [Tue, 31 Oct 2017 22:37:44 +0000 (22:37 +0000)]
Merge "btif: Simplify dependencies for btif_storage_test"
am:
a413084c84
Change-Id: I93c662dc789b7dac6f404d0653a902db8fbd8013
Treehugger Robot [Tue, 31 Oct 2017 22:12:05 +0000 (22:12 +0000)]
Merge "btif: Simplify dependencies for btif_storage_test"
Jakub Pawlowski [Tue, 31 Oct 2017 22:00:22 +0000 (22:00 +0000)]
Merge changes I7a3e9ee7,I29702219
am:
4929fa2ecb
Change-Id: I3dae9559ce9434bdc266d45c2dda702fe15499ca
Jakub Pawlowski [Tue, 31 Oct 2017 21:01:11 +0000 (21:01 +0000)]
Merge changes I7a3e9ee7,I29702219
* changes:
Remove dead code - dump_bin
Assert on null callback in BTA_JvL2capConnect and BTA_JvL2capConnectLE
Myles Watson [Mon, 30 Oct 2017 23:00:56 +0000 (16:00 -0700)]
btif: Simplify dependencies for btif_storage_test
Bug:
68350333
Test: lunch gce_x86_pasan;
SANITIZE_TARGET="address coverage" m net_test_btif
Change-Id: Ia87a4e3d224fcd7ddfa55bdcca391f9b262d50e5
Pavlin Radoslavov [Tue, 31 Oct 2017 19:31:28 +0000 (19:31 +0000)]
Merge "Add a workaround to play A2DP SBC Mono"
am:
9e2b73f574
Change-Id: I2c0f6656e6e10dcfe6f97201f8744236951b0789
Treehugger Robot [Tue, 31 Oct 2017 19:25:40 +0000 (19:25 +0000)]
Merge "Add a workaround to play A2DP SBC Mono"
Pavlin Radoslavov [Sun, 29 Oct 2017 18:35:22 +0000 (11:35 -0700)]
Add a workaround to play A2DP SBC Mono
The PCM audio is pulled as STEREO and mixed into MONO by the
Audio A2DP HAL.
Test: Playing SBC mono with Headset
Bug:
67763743
Change-Id: I2710a6633dd81c6917362ed6dd4af75a8d517b0a
Ruina Liu [Tue, 31 Oct 2017 16:05:46 +0000 (16:05 +0000)]
Fix Bluetooth crash when pairing with 8th HOGP device
am:
2e3c3d7829
Change-Id: I15f10e1135f54425643f0f3dc5606d61d342d157
Ruina Liu [Mon, 11 Sep 2017 08:28:21 +0000 (16:28 +0800)]
Fix Bluetooth crash when pairing with 8th HOGP device
In function bta_hh_hdl_event, when handling with
the event of BTA_HH_API_GET_DSCP_EVT after bonded
with 8th HOGP device, no correct p_cb will be found,
due to mapping error between the device handle and
dev cb for HOGP. Then NPE happen.
Change to map le_cb_index into the device handle for
HOGP, so that HOGP and HID can be separately maintained
maximum to 14 device
Test: Pair with 14 HOGP devices
Change-Id: I8556f1ffea160862c2e52f874ef334f68c17050e
Jakub Pawlowski [Tue, 31 Oct 2017 05:02:41 +0000 (22:02 -0700)]
Remove dead code - dump_bin
Bug:
68359837
Test: compilation test
Change-Id: I7a3e9ee79da06753b329fcd13c6c8aa76bd6fa8f
Jakub Pawlowski [Mon, 30 Oct 2017 19:38:30 +0000 (12:38 -0700)]
Assert on null callback in BTA_JvL2capConnect and BTA_JvL2capConnectLE
Passing null as callback should never happen in any scenario.
Bug:
68359837
Test: compilation test
Change-Id: I29702219183eae9d1782438f99d01534fbe44d73
Jakub Pawlowski [Tue, 31 Oct 2017 02:29:56 +0000 (02:29 +0000)]
Use LOG macros in BTA JV
am:
c1a13bcb43
Change-Id: If41a91a09332ecf0c6ecd2615b4cb22b1f4a93e8
Jakub Pawlowski [Tue, 31 Oct 2017 00:45:11 +0000 (00:45 +0000)]
Get rid of BTA_JV specific events
am:
5243b3d290
Change-Id: If4dc158de6b123944e958bfea363455f0c527c88
Jakub Pawlowski [Tue, 31 Oct 2017 00:45:06 +0000 (00:45 +0000)]
Use Bind in BTA_JvStartDiscovery
am:
eb40c5c991
Change-Id: Ie6b1f098a292a5a4e2fd85360f21ff32e3a39e3a
Jakub Pawlowski [Tue, 31 Oct 2017 00:45:01 +0000 (00:45 +0000)]
Get rid of BTA_JV_API_PM_STATE_CHANGE_EVT
am:
45190ba9e6
Change-Id: Ia24dc02f9dd13d56a9fca812d1ed9fb3ed56d039
Jakub Pawlowski [Tue, 31 Oct 2017 00:44:57 +0000 (00:44 +0000)]
Use Bind in BTA_JvSetPmProfile
am:
c6b8023c1f
Change-Id: I1d8f9019d0968958322dc04300a03bae96997755
Jakub Pawlowski [Tue, 31 Oct 2017 00:44:52 +0000 (00:44 +0000)]
Use Bind in BTA_JvRfcommWrite
am:
971f275376
Change-Id: I94fc79cc20ba863982884ee7411503103d8fe997
Jakub Pawlowski [Tue, 31 Oct 2017 00:44:47 +0000 (00:44 +0000)]
Use Bind in BTA_JvRfcommStartServer and BTA_JvRfcommStopServer
am:
82c54a47bd
Change-Id: If54cb7a0c0c0f3385e412f2a5e6280263071a08f
Jakub Pawlowski [Tue, 31 Oct 2017 00:41:46 +0000 (00:41 +0000)]
Use Bind in BTA_JvRfcommClose
am:
d439a7b7c1
Change-Id: I69db8f314ebd98e982b661aac46d7d9250da5e6c
Jakub Pawlowski [Tue, 31 Oct 2017 00:41:39 +0000 (00:41 +0000)]
Use Bind in BTA_JvRfcommConnect
am:
3070b22173
Change-Id: Iaffefe773f725ad19b23675477a3cd9734670be3
Jakub Pawlowski [Tue, 31 Oct 2017 00:41:34 +0000 (00:41 +0000)]
Use Bind in BTA_JvL2capRead
am:
457d20a3a3
Change-Id: If1c2ca54c566ead7d52b2958d4f567870feffe38
Jakub Pawlowski [Tue, 31 Oct 2017 00:41:30 +0000 (00:41 +0000)]
Use Bind in BTA_JvL2capWriteFixed
am:
70bc98fd70
Change-Id: Ibcc18065c9261ed11a9b88818c1ae62dc79f9956
Jakub Pawlowski [Tue, 31 Oct 2017 00:41:23 +0000 (00:41 +0000)]
Use Bind in BTA_JvL2capWrite
am:
a9c80d2240
Change-Id: I1ddc63ea7947e14e32cfb7e72f75d180016f5ca0
Jakub Pawlowski [Tue, 31 Oct 2017 00:41:17 +0000 (00:41 +0000)]
Use Bind in BTA_JvL2capStopServerLE
am:
f53bb82959
Change-Id: If23f2304952081fd3ffac7aaedc5916aebe42d76
Jakub Pawlowski [Tue, 31 Oct 2017 00:41:12 +0000 (00:41 +0000)]
Use Bind in BTA_JvL2capStopServer
am:
345f60ea1d
Change-Id: Ica8e885b322423725640b6effeac2839f118fbf9
Jakub Pawlowski [Tue, 31 Oct 2017 00:41:05 +0000 (00:41 +0000)]
Use Bind in BTA_JvL2capStartServerLE
am:
792ab6f8a8
Change-Id: I61adae0ae5916ffd4441748f4897b60831a3333d
Jakub Pawlowski [Tue, 31 Oct 2017 00:39:56 +0000 (00:39 +0000)]
Use Bind in BTA_JvL2capStartServer
am:
6a10ea2cb7
Change-Id: I1c4faa15f4ed980b02dbe46944c503e6a8e3e946
Jakub Pawlowski [Tue, 31 Oct 2017 00:39:52 +0000 (00:39 +0000)]
Use Bind in BTA_JvL2capCloseLE
am:
a034a03229
Change-Id: I201e09a52d7381fb29672c813efceb4b65f4f5f4
Jakub Pawlowski [Tue, 31 Oct 2017 00:39:47 +0000 (00:39 +0000)]
Use Bind in BTA_JvL2capClose
am:
6ccc6f4954
Change-Id: I8285a8952cbca55c3953e1d706f94f456d314d1c
Jakub Pawlowski [Tue, 31 Oct 2017 00:39:43 +0000 (00:39 +0000)]
Use Bind in BTA_JvL2capConnect
am:
b48986cfc2
Change-Id: Ib684ba9db9099ab24526cb89acbf5f4efd3ae698
Jakub Pawlowski [Tue, 31 Oct 2017 00:39:38 +0000 (00:39 +0000)]
Use Bind in BTA_JvL2capConnectLE
am:
5458047d4e
Change-Id: I18bbdeb92816088d8e5f15f43cb8a69f89a9cfae
Jakub Pawlowski [Mon, 30 Oct 2017 17:41:06 +0000 (10:41 -0700)]
Use LOG macros in BTA JV
Bug:
68359837
Test: compilation test
Change-Id: Ic886f5979c40e49ad870b750dc0650a325153176
Jakub Pawlowski [Sat, 28 Oct 2017 03:15:38 +0000 (03:15 +0000)]
Use Bind in BTA_JvDeleteRecord
am:
a567799194
Change-Id: Ibd2aa662bcc23798b8095f9e84dff4e1094ebc30
Jakub Pawlowski [Sat, 28 Oct 2017 03:14:24 +0000 (03:14 +0000)]
Use Bind in BTA_JvCreateRecordByUser
am:
60596e700a
Change-Id: Ida5dd09e400e927987c98fcbc41bdadad56a05e4
Jakub Pawlowski [Sat, 28 Oct 2017 03:14:18 +0000 (03:14 +0000)]
Use Bind in BTA_JvFreeChannel
am:
cdd9dac140
Change-Id: I84b978fa9735d9a10d7dc2fb1b61029204db726c
Jakub Pawlowski [Sat, 28 Oct 2017 03:14:13 +0000 (03:14 +0000)]
Use Bind in BTA_JvGetChannelId
am:
a2394f273a
Change-Id: I878ec0ccfd784791deaaab876785ef5afb830ed2
Jakub Pawlowski [Sat, 28 Oct 2017 03:14:08 +0000 (03:14 +0000)]
Use Bind in BTA_JvDisable
am:
e72240defc
Change-Id: Iee4008e67e8f6bd6b166ba351e0a31b97ca8ad32
Jakub Pawlowski [Sat, 28 Oct 2017 03:14:02 +0000 (03:14 +0000)]
Use Bind in BTA_JvEnable
am:
d3c1f2e43a
Change-Id: I3e8ed1b1d8a030d3078bfcc03207b65e2685e06b
Jakub Pawlowski [Fri, 27 Oct 2017 18:57:24 +0000 (11:57 -0700)]
Use Bind in BTA_JvDeleteRecord
Bug:
68359837
Test: compilation test
Change-Id: I23236fecf21ffb7808cfabef1570add2e07b0920
Jakub Pawlowski [Sat, 28 Oct 2017 02:48:25 +0000 (19:48 -0700)]
Get rid of BTA_JV specific events
Bug:
68359837
Test: compilation test
Change-Id: I4273bc1bed2cef676ab1ed026ac8a0fa3ffbada9
Jakub Pawlowski [Sat, 28 Oct 2017 02:29:01 +0000 (19:29 -0700)]
Use Bind in BTA_JvStartDiscovery
Bug:
68359837
Test: compilation test
Change-Id: I34279fb831ebc9dcf839f7c7339a50dda57a4246
Jakub Pawlowski [Sat, 28 Oct 2017 02:04:25 +0000 (19:04 -0700)]
Get rid of BTA_JV_API_PM_STATE_CHANGE_EVT
Bug:
68359837
Test: compilation test
Change-Id: I0ad741b7491cbcf95b882d200e008da5026e0f60
Jakub Pawlowski [Sat, 28 Oct 2017 01:55:48 +0000 (18:55 -0700)]
Use Bind in BTA_JvSetPmProfile
Bug:
68359837
Test: compilation test
Change-Id: I6ac2f5ab8061d7d7c65554172d7c0fc3cb703cc6
Jakub Pawlowski [Sat, 28 Oct 2017 01:36:43 +0000 (18:36 -0700)]
Use Bind in BTA_JvRfcommWrite
Bug:
68359837
Test: compilation test
Change-Id: I73ba3a1c0b6fa3cbde8a4f2c3a4b378d5dcab0fe
Jakub Pawlowski [Sat, 28 Oct 2017 01:15:15 +0000 (18:15 -0700)]
Use Bind in BTA_JvRfcommStartServer and BTA_JvRfcommStopServer
Bug:
68359837
Test: compilation test
Change-Id: I81ee51fc9bfce1ffb19621f5b4eab9028d089421
Jakub Pawlowski [Sat, 28 Oct 2017 01:01:54 +0000 (18:01 -0700)]
Use Bind in BTA_JvRfcommClose
Bug:
68359837
Test: compilation test
Change-Id: I867107dbf86a2a0fcb9232ce902d38345d04c444
Jakub Pawlowski [Sat, 28 Oct 2017 00:52:01 +0000 (17:52 -0700)]
Use Bind in BTA_JvRfcommConnect
Bug:
68359837
Test: compilation test
Change-Id: I0e567cbe573c94574cc5f384cddf697dc2337109
Jakub Pawlowski [Sat, 28 Oct 2017 00:39:02 +0000 (17:39 -0700)]
Use Bind in BTA_JvL2capRead
Bug:
68359837
Test: compilation test
Change-Id: I743e655acab6b57bb9d67e75b7a6d54d002568c6
Jakub Pawlowski [Sat, 28 Oct 2017 00:29:04 +0000 (17:29 -0700)]
Use Bind in BTA_JvL2capWriteFixed
Bug:
68359837
Test: compilation testPlease enter the commit message for your changes. Lines starting
Change-Id: I4774fc9e4a7c7776a2d346613d1e0d5ea2e14b04
Jakub Pawlowski [Sat, 28 Oct 2017 00:20:24 +0000 (17:20 -0700)]
Use Bind in BTA_JvL2capWrite
Bug:
68359837
Test: compilation test
Change-Id: Iedd9ebb0f659d85f24ebe83eade50c7944212e7f
Jakub Pawlowski [Fri, 27 Oct 2017 23:59:45 +0000 (16:59 -0700)]
Use Bind in BTA_JvL2capStopServerLE
Bug:
68359837
Test: compilation test
Change-Id: Ibba26fd62571e97f75502cd65240534ff6078e01
Jakub Pawlowski [Fri, 27 Oct 2017 23:51:52 +0000 (16:51 -0700)]
Use Bind in BTA_JvL2capStopServer
Bug:
68359837
Test: compilation test
Change-Id: I25f718a943aabb5897145ec75a8e2b7b154cc2d4
Jakub Pawlowski [Fri, 27 Oct 2017 23:45:13 +0000 (16:45 -0700)]
Use Bind in BTA_JvL2capStartServerLE
Bug:
68359837
Test: compilation test
Change-Id: I56717075758bc3f0fab5b092bd5fbc60b78a9a83
Jakub Pawlowski [Fri, 27 Oct 2017 23:29:45 +0000 (16:29 -0700)]
Use Bind in BTA_JvL2capStartServer
Bug:
68359837
Test: compilation test
Change-Id: I0fb574e25c11f46a6fa68bef830a2e9fbcbd2d42
Jakub Pawlowski [Fri, 27 Oct 2017 23:09:20 +0000 (16:09 -0700)]
Use Bind in BTA_JvL2capCloseLE
Bug:
68359837
Test: compilation test
Change-Id: Ia9349c4f62fc515864518af3fd05e3f3af611cbf
Jakub Pawlowski [Fri, 27 Oct 2017 20:28:23 +0000 (13:28 -0700)]
Use Bind in BTA_JvL2capClose
Bug:
68359837
Test: compilation test
Change-Id: Ia153dab61cb593b4319ffa718c691d5985e529e6
Jakub Pawlowski [Fri, 27 Oct 2017 20:15:47 +0000 (13:15 -0700)]
Use Bind in BTA_JvL2capConnect
Bug:
68359837
Test: compilation test
Change-Id: I0d6efdfefa12551c615bee5dd43a3101a5cac3d2
Jakub Pawlowski [Fri, 27 Oct 2017 19:33:58 +0000 (12:33 -0700)]
Use Bind in BTA_JvL2capConnectLE
Bug:
68359837
Test: compilation test
Change-Id: Iaef4695db6b46af59641d5af508b87f20bcf5232
Jakub Pawlowski [Fri, 27 Oct 2017 07:09:17 +0000 (00:09 -0700)]
Use Bind in BTA_JvCreateRecordByUser
Bug:
68359837
Test: compilation test
Change-Id: I889467b07694b16485a7541c4d9fdfa38a47e0be
Jakub Pawlowski [Fri, 27 Oct 2017 07:03:12 +0000 (00:03 -0700)]
Use Bind in BTA_JvFreeChannel
Bug:
68359837
Test: compilation test
Change-Id: I69fdbc9ea8510060736ae522baf865aa2d0c55f2
Jakub Pawlowski [Fri, 27 Oct 2017 06:53:42 +0000 (23:53 -0700)]
Use Bind in BTA_JvGetChannelId
Bug:
68359837
Test: compilation test
Change-Id: I9da50222561da8410cdffa2e8b4c695cd2488841
Jakub Pawlowski [Fri, 27 Oct 2017 06:45:27 +0000 (23:45 -0700)]
Use Bind in BTA_JvDisable
Bug:
68359837
Test: compilation test
Change-Id: I73470c7a98a36a57d5f44decbbf388f02c6caddd
Jakub Pawlowski [Fri, 27 Oct 2017 06:32:49 +0000 (23:32 -0700)]
Use Bind in BTA_JvEnable
Bug:
68359837
Test: compilation test
Change-Id: I1913b7763c93932c59fe94c3a40293e02335afa2
Tiansong Cui [Sat, 28 Oct 2017 00:17:20 +0000 (00:17 +0000)]
Correct rssi size
am:
1dee3a50ea
Change-Id: I8b830f00a93b2a743d26c43c1ae3cbd567f8a0df
Tiansong Cui [Fri, 27 Oct 2017 21:24:15 +0000 (14:24 -0700)]
Correct rssi size
Bug: None
Test: print rssi, size of rssi equals sizeof(int8_t).
Change-Id: I40edb63257618c48b0ab2d0181105c5a2c473ea6
Myles Watson [Fri, 27 Oct 2017 16:40:50 +0000 (16:40 +0000)]
Merge "test_vendor: Extract DeviceProperties"
am:
6cfa155015
Change-Id: I9051b2f44e41f944b8754e30abc487ce1c92b9aa
Treehugger Robot [Fri, 27 Oct 2017 16:30:20 +0000 (16:30 +0000)]
Merge "test_vendor: Extract DeviceProperties"
Jacky Cheung [Fri, 27 Oct 2017 03:03:22 +0000 (03:03 +0000)]
Fix addr_type overriding by btm_ble_process_adv_addr().
am:
78008b961e
Change-Id: I85dd292a4f3f52fb26c66155030581d7da3e8d37
Jacky Cheung [Thu, 26 Oct 2017 23:07:36 +0000 (16:07 -0700)]
Fix addr_type overriding by btm_ble_process_adv_addr().
Bug:
67042709
Test: manual
Change-Id: Iedffe2fa3dcb3f4e600626490b95c27d1535a737
Pavlin Radoslavov [Fri, 27 Oct 2017 01:29:21 +0000 (01:29 +0000)]
Merge "Revert "Build only for current architecture by default""
am:
9b4d4ff353
Change-Id: I1400da14ee348b5fe17bf0f566a7b2572e44d3ba
Treehugger Robot [Fri, 27 Oct 2017 01:12:39 +0000 (01:12 +0000)]
Merge "Revert "Build only for current architecture by default""
Zach Johnson [Fri, 27 Oct 2017 00:16:11 +0000 (00:16 +0000)]
Merge "Respect AVRCP versions in SDP records"
am:
e714a318ee
Change-Id: I6a55139ef350f3dcb63a8e492537af5ff9118880
Jakub Pawlowski [Fri, 27 Oct 2017 00:15:48 +0000 (00:15 +0000)]
Types should always be a static library
am:
d59bdf57e3
Change-Id: Ibfcd9189d9fa8d22b8c2ed32977cb075af3724c6
Treehugger Robot [Fri, 27 Oct 2017 00:08:34 +0000 (00:08 +0000)]
Merge "Respect AVRCP versions in SDP records"
Pavlin Radoslavov [Thu, 26 Oct 2017 23:36:30 +0000 (23:36 +0000)]
Revert "Build only for current architecture by default"
This reverts commit
862095819ffac9e5e543c114b6f0d4a7d89f6938.
The result audio.a2dp.default.so shared library is only 64-bit,
and it can't be used by the audioserver which is still 32-bit only
Bug:
68127690
Change-Id: I60b15c32425db3b2ada687fa8d0dcb728cf1812f
Test: A2DP streaming
Zach Johnson [Wed, 18 Oct 2017 22:39:51 +0000 (15:39 -0700)]
Respect AVRCP versions in SDP records
It's all wrong. All wrong.
In the protocol descriptor list in SDP:
1.3 reports 1.2
1.4 reports 1.3
1.5 reports 1.4
1.6 reports 1.4
1.6.1 reports 1.4
wtf
Simplify as:
1.3 to 1.5 report (version - 1),
everything else reports 1.4
Bug:
66842069
Test: inspect SDP records with tool
Change-Id: I8c3912281a7c01b9f43be1a2c2cc59263e98a0a6
Jakub Pawlowski [Wed, 25 Oct 2017 22:30:54 +0000 (15:30 -0700)]
Types should always be a static library
Test: compilation
Change-Id: I524ef23963f68573352fc5ae8c610a12fc65c822
Bailey Forrest [Thu, 26 Oct 2017 06:20:51 +0000 (06:20 +0000)]
Merge "AAC support for A2DP sink"
am:
c6258565db
Change-Id: Ie337e89291fb0895d5e99b2d01d5d924c201eab9
Treehugger Robot [Thu, 26 Oct 2017 06:05:23 +0000 (06:05 +0000)]
Merge "AAC support for A2DP sink"
Jack He [Thu, 26 Oct 2017 05:57:44 +0000 (05:57 +0000)]
Merge "Use C++11 static assert instead of macro"
am:
edffc8c908
Change-Id: I7c2c2127d82b9756ade5f7d46368877b3baf1f90
Treehugger Robot [Thu, 26 Oct 2017 05:52:41 +0000 (05:52 +0000)]
Merge "Use C++11 static assert instead of macro"
Tobias Melin [Thu, 26 Oct 2017 04:16:08 +0000 (04:16 +0000)]
Don't print error message when rename operation is successful
am:
6d6f34ccf3
Change-Id: I63ae2e6f1a0213dd68247e12c72042c409e5f960
Bailey Forrest [Fri, 16 Jun 2017 22:38:03 +0000 (15:38 -0700)]
AAC support for A2DP sink
Bug:
37562860
Test: Test on device.
Change-Id: Ic8699e5ffa5f97e102ec4b9fc63ce5afd3382c5d
Tobias Melin [Fri, 18 Aug 2017 11:18:54 +0000 (13:18 +0200)]
Don't print error message when rename operation is successful
Bug:
65355196
Change-Id: I34504175a58d93f0dd71a8a51275818ebace4b6a
Jack He [Wed, 25 Oct 2017 23:46:42 +0000 (16:46 -0700)]
Use C++11 static assert instead of macro
Test: host and device unit tests
Change-Id: Iab56242aff6e427124c1ce3f6218ba81c2f95f7c
Pavlin Radoslavov [Wed, 25 Oct 2017 21:04:46 +0000 (21:04 +0000)]
Merge "Don't use a pointer for the A2DP Sink static mutex"
am:
42f2975d87
Change-Id: Ic7d2c17e565b2522754458844edfe865b278104f
Treehugger Robot [Wed, 25 Oct 2017 21:00:48 +0000 (21:00 +0000)]
Merge "Don't use a pointer for the A2DP Sink static mutex"
Jack He [Wed, 25 Oct 2017 19:25:07 +0000 (19:25 +0000)]
Host test script should return 1 when build fails or test is missing
am:
b738576806
Change-Id: Ie1f154ebe42b06aec18f2e354df08887b5f6f9b2
Pavlin Radoslavov [Wed, 25 Oct 2017 18:40:27 +0000 (11:40 -0700)]
Don't use a pointer for the A2DP Sink static mutex
The A2DP Sink cleanup might be called even if A2DP Sink init wasn't called
before, hence the g_mutex local pointer might be null.
We cannot check whether the pointer is null, because the A2DP Sink init
and cleanup operations are not executed on the same thread.
Bug:
68255348
Test: Manual
Change-Id: I9881ada0c4d01192352621ca5fe024f0e8b0ef76
Jack He [Wed, 25 Oct 2017 17:14:53 +0000 (10:14 -0700)]
Host test script should return 1 when build fails or test is missing
* test/run_host_unit_tests.py returns 1 when
- Build environement could not be setup
- Build fails
- Test could not be found
* It returns 0 when
- Test exists, but failed
- All tests pass
Bug:
64687730
Test: ./test/run_host_unit_tests.py -j40
Change-Id: Idbff0c73a219b5ce7b640f44f41caf43030e2b51
Bailey Forrest [Wed, 25 Oct 2017 03:14:06 +0000 (03:14 +0000)]
Fix race conditions in a2dp sink
am:
1a886d4d0b
Change-Id: Iadc5e6f404e1fb90d81529cce5eb3b0f7bad37fc
Bailey Forrest [Wed, 7 Jun 2017 21:55:37 +0000 (14:55 -0700)]
Fix race conditions in a2dp sink
- Use std::atomic for btif_a2dp_sink_state variable
- Add a lock for other static members
Explanation:
- There's the main thread that things on this file should run on:
btif_a2dp_sink_cb.worker_thread
- External callers may call from any thread.
- fixed_queue_t is a thread safe queue which uses locking.
Many of the functions just append commands to cmd_msg_queue which are
commands which are processed by btif_a2dp_sink_command_ready. Operations
on this queue can be done without locking.
The main bug is a TOCTOU bug on 'rx_audio_queue'.
btif_a2dp_sink_avk_handle_timer preforms a fixed_queue_try_peek_first
operation and modifies the pointer without dequing it. This causes a
race when other operations cause a dequeue on rx_audio_queue.
I have added locks on all functions which modify the static data except:
- Helpers which are only called while locked
- Functions which only modify cmd_msg_queue or access
btif_a2dp_sink_state
Bug:
35807779
Test: Test on device.
Change-Id: I289e23213426dbc182ca4a3fca26bc5658299381
Myles Watson [Fri, 20 Oct 2017 16:46:59 +0000 (09:46 -0700)]
test_vendor: Extract DeviceProperties
Test: start/stop Bluetooth with rootcanal loaded
Change-Id: Ic3dd1c87df9583c4b5957592bca3332f2daaa3da
liuchao [Tue, 24 Oct 2017 17:51:31 +0000 (17:51 +0000)]
Remove aliase name while removing bonded device
am:
ce7c3c045f
Change-Id: I705eaaed0caaa82671c57d624932110eb4262cc0
liuchao [Wed, 12 Apr 2017 02:23:00 +0000 (10:23 +0800)]
Remove aliase name while removing bonded device
when remove a bonded device, the date in bt_config.conf
is deleted but only removed linkey in the global cache.
The user set alise name is left there
When comes to next time search ,the linkey is set to
config and write to bt_config.conf, before OFF/ON BT
operation, the cached alse name is reported unexceptedly
After remove,the remote device is expected to be brand
new to the phone in the 2nd time they see each other.
Test: mm -j8
Change-Id: I005a6487c546e2639e3180e8a6e181c4d3c1d4ac
Pulkit Bhuwalka [Tue, 24 Oct 2017 06:27:46 +0000 (06:27 +0000)]
Get Bluetooth Class of Device
am:
c5ed99ea41
Change-Id: I116fd9e1e74f10d8b51d41a058982add301c289e
Pulkit Bhuwalka [Wed, 20 Sep 2017 22:11:01 +0000 (15:11 -0700)]
Get Bluetooth Class of Device
Modifies the native Bluetooth stack to
1) return default value from BTA_DM_COD configuration when not set, and
2) return adapter COD value even before stack start for Java Android
stack.
Bug:
36015415
Test: Verified fetching of COD both before and after modification of
CoD value and restart of machine.
Change-Id: Ibcf726dcd7bea5d7e27c7a775f8cf7ea3f9e4107
OSDN Git Service
