OSDN Git Service

android-x86/art.git
7 years agoMerge "base: make SafeCopy work on older Linux kernels."
Josh Gao [Thu, 20 Apr 2017 03:09:00 +0000 (03:09 +0000)]
Merge "base: make SafeCopy work on older Linux kernels."
am: 8d0f3aaf28

Change-Id: I6542a492d60208b37f4880dc0d92d8ac3e61857d

7 years agoMerge "base: make SafeCopy work on older Linux kernels."
Treehugger Robot [Thu, 20 Apr 2017 03:04:32 +0000 (03:04 +0000)]
Merge "base: make SafeCopy work on older Linux kernels."

7 years agobase: make SafeCopy work on older Linux kernels.
Josh Gao [Wed, 19 Apr 2017 22:44:20 +0000 (15:44 -0700)]
base: make SafeCopy work on older Linux kernels.

process_vm_readv is documented to not split transfer across a single
iovec element, but this appears to not be the case for the newer
kernels we have on our workstations.

Split up transfers across page boundaries, to avoid this. This has the
side effect of limiting the maximum size of a transfer, but 64 pages
ought to be enough for anybody.

Test: safe_copy_test on 3.13.0-101-generic (failing before)
Test: safe_copy_test on 4.4.0-66-generic (still passing)
Change-Id: I6a6dbf0cd2aeaa7eab39f6d41285d46ebd760e30

7 years agoMerge "Remove obsolete rules to build runtests"
Colin Cross [Wed, 19 Apr 2017 22:58:42 +0000 (22:58 +0000)]
Merge "Remove obsolete rules to build runtests"
am: 6c99499c8a

Change-Id: I5e10478e2ffadec2c0ccad151c49c24e24e05a96

7 years agoMerge changes from topic 'art_run_test_912_cts_refactor'
Andreas Gampe [Wed, 19 Apr 2017 22:56:47 +0000 (22:56 +0000)]
Merge changes from topic 'art_run_test_912_cts_refactor'
am: afcec28403

Change-Id: Ibda516ad39de9a931e3b4ddc3ecfbeaba01dc719

7 years agoMerge "Remove obsolete rules to build runtests"
Colin Cross [Wed, 19 Apr 2017 22:54:19 +0000 (22:54 +0000)]
Merge "Remove obsolete rules to build runtests"

7 years agoMerge changes from topic 'art_run_test_912_cts_refactor'
Treehugger Robot [Wed, 19 Apr 2017 22:52:57 +0000 (22:52 +0000)]
Merge changes from topic 'art_run_test_912_cts_refactor'

* changes:
  ART: Refactor run-test 912 (3/3)
  ART: Refactor run-test 912 (2/3)
  ART: Refactor run-test 912 (1/3)

7 years agoART: Refactor run-test 912 (3/3)
Andreas Gampe [Wed, 19 Apr 2017 20:45:25 +0000 (13:45 -0700)]
ART: Refactor run-test 912 (3/3)

Add run-test Main.

Bug: 32072923
Test: m
Test: art/test/testrunner/testrunner.py -b --host -t 912
Change-Id: I4a4bbe587937d9b87eab77af1a5f05fd4df7f0d4

7 years agoART: Refactor run-test 912 (2/3)
Andreas Gampe [Wed, 19 Apr 2017 20:43:43 +0000 (13:43 -0700)]
ART: Refactor run-test 912 (2/3)

Move the refactored run-test into place.

Bug: 32072923
Test: m
Change-Id: I170cd1465a3afce3f48a9cbad864eaa5d9fdaacc

7 years agoART: Refactor run-test 912 (1/3)
Andreas Gampe [Wed, 19 Apr 2017 20:37:48 +0000 (13:37 -0700)]
ART: Refactor run-test 912 (1/3)

Refactor the test for CTS. Break out the ART-specific part. Move
the rest into the regular layout. Move class events to their own
thread, and report them on the Java side. Use InMemoryDexClassLoader
for classloaders to avoid explicit files.

Bug: 32072923
Test: none
Change-Id: I80e27cc9c21646bbecd1de1a246f583a0d388e05

7 years agoMerge "fault_handler: hopefully fix darwin build."
Josh Gao [Wed, 19 Apr 2017 20:29:35 +0000 (20:29 +0000)]
Merge "fault_handler: hopefully fix darwin build."
am: 1f56cb5c59

Change-Id: I9ef55964245472afd412ae0720651bc2fdcdc2e0

7 years agoMerge "fault_handler: hopefully fix darwin build."
Josh Gao [Wed, 19 Apr 2017 20:22:45 +0000 (20:22 +0000)]
Merge "fault_handler: hopefully fix darwin build."

7 years agofault_handler: hopefully fix darwin build.
Josh Gao [Wed, 19 Apr 2017 20:20:19 +0000 (13:20 -0700)]
fault_handler: hopefully fix darwin build.

Test: none
Change-Id: I08adf266c6287a289d213a0b1fa854f223fec72d

7 years agoMerge "Revert "Add dexdiag_test""
David Sehr [Wed, 19 Apr 2017 20:04:28 +0000 (20:04 +0000)]
Merge "Revert "Add dexdiag_test""
am: 1cfe8728e0

Change-Id: I705ab54f2a7386373be5fbb469ca1e1dfde670fe

7 years agoMerge changes Ie3d5e176,Ic1fbb885,I10bafcff
Josh Gao [Wed, 19 Apr 2017 20:04:04 +0000 (20:04 +0000)]
Merge changes Ie3d5e176,Ic1fbb885,I10bafcff
am: 3955baf83f

Change-Id: I449e532cd4061667213fea7a999278f7a52f6b9f

7 years agoMerge "Revert "Add dexdiag_test""
David Sehr [Wed, 19 Apr 2017 20:00:50 +0000 (20:00 +0000)]
Merge "Revert "Add dexdiag_test""

7 years agoMerge changes Ie3d5e176,Ic1fbb885,I10bafcff
Treehugger Robot [Wed, 19 Apr 2017 19:57:35 +0000 (19:57 +0000)]
Merge changes Ie3d5e176,Ic1fbb885,I10bafcff

* changes:
  fault_handler: use SafeCopy to verify the validity of ArtMethod.
  fault_handler: use SafeCopy to decode x86 instruction length.
  base: add SafeCopy.

7 years agoRevert "Add dexdiag_test"
David Sehr [Wed, 19 Apr 2017 19:44:08 +0000 (19:44 +0000)]
Revert "Add dexdiag_test"

This reverts commit 2120ad43acc0ab0fa74c151069948ef9698c009f.

Change-Id: Icdb42e47eb2f099cbfbd302477ad6614bb8524f1

7 years agoMerge "Implement can_generate_native_method_bind capability"
Alex Light [Wed, 19 Apr 2017 19:35:59 +0000 (19:35 +0000)]
Merge "Implement can_generate_native_method_bind capability"
am: 9088df87d9

Change-Id: I7be5238299d959c2d7bdabffe436fd7469cbd1e7

7 years agoMerge "Implement can_generate_native_method_bind capability"
Treehugger Robot [Wed, 19 Apr 2017 19:31:06 +0000 (19:31 +0000)]
Merge "Implement can_generate_native_method_bind capability"

7 years agoMerge "Implement halving add idiom (with checker tests)."
Aart Bik [Wed, 19 Apr 2017 19:24:27 +0000 (19:24 +0000)]
Merge "Implement halving add idiom (with checker tests)."
am: ed5d0ee21e

Change-Id: Ibc118d3cad5b7563426a9fee07e1082e750da552

7 years agoMerge "Implement halving add idiom (with checker tests)."
Treehugger Robot [Wed, 19 Apr 2017 19:19:00 +0000 (19:19 +0000)]
Merge "Implement halving add idiom (with checker tests)."

7 years agoMerge "MIPS64: java.lang.System.arraycopy() for copying char[] to char[]."
Chris Larsen [Wed, 19 Apr 2017 18:21:52 +0000 (18:21 +0000)]
Merge "MIPS64: java.lang.System.arraycopy() for copying char[] to char[]."
am: 88b7c37163

Change-Id: Iae649dc92794bee44aec59b000a1ae312d2093c7

7 years agoMerge "MIPS64: java.lang.System.arraycopy() for copying char[] to char[]."
Treehugger Robot [Wed, 19 Apr 2017 18:15:58 +0000 (18:15 +0000)]
Merge "MIPS64: java.lang.System.arraycopy() for copying char[] to char[]."

7 years agoMerge "Fix CHA test failures under some configurations."
Mingyao Yang [Wed, 19 Apr 2017 18:03:51 +0000 (18:03 +0000)]
Merge "Fix CHA test failures under some configurations."
am: 59715029ae

Change-Id: I2b3f997173ad4a99470333b2d1c7c5dc4ec15b6f

7 years agoMerge "Fix CHA test failures under some configurations."
Mingyao Yang [Wed, 19 Apr 2017 17:59:32 +0000 (17:59 +0000)]
Merge "Fix CHA test failures under some configurations."

7 years agofault_handler: use SafeCopy to verify the validity of ArtMethod.
Josh Gao [Tue, 18 Apr 2017 03:10:29 +0000 (20:10 -0700)]
fault_handler: use SafeCopy to verify the validity of ArtMethod.

Reimplement ArtMethod::GetDeclaringClassUnchecked and VerifyClassClass
in terms of SafeCopy, to be able to safely verify the validity of
putative ArtMethods in FaultManager::IsInGeneratedCode.

Bug: http://b/30836730
Test: m test-art-host
Change-Id: Ie3d5e176ea569cedcefd320e2480a1e1e496a53a

7 years agoImplement halving add idiom (with checker tests).
Aart Bik [Thu, 13 Apr 2017 00:09:20 +0000 (17:09 -0700)]
Implement halving add idiom (with checker tests).

Rationale:
First of several idioms that map to very efficient SIMD instructions.
Note that the is-zero-ext and is-sign-ext are general-purpose utilities
that will be widely used in the vectorizer to detect low precision
idioms, so expect that code to be shared with many CLs to come.

Test: test-art-host, test-art-target
Change-Id: If7dc2926c72a2e4b5cea15c44ef68cf5503e9be9

7 years agoMerge "Allow dex2oat to handle relative paths."
Jeff Hao [Wed, 19 Apr 2017 17:20:31 +0000 (17:20 +0000)]
Merge "Allow dex2oat to handle relative paths."
am: 72fdec3928

Change-Id: I4daab86a70cde8e9d99b4e49d21e59879d2bec70

7 years agoMerge "Allow dex2oat to handle relative paths."
Treehugger Robot [Wed, 19 Apr 2017 17:13:11 +0000 (17:13 +0000)]
Merge "Allow dex2oat to handle relative paths."

7 years agoImplement can_generate_native_method_bind capability
Alex Light [Tue, 18 Apr 2017 22:20:38 +0000 (15:20 -0700)]
Implement can_generate_native_method_bind capability

This capability lets one observe and even replace the implementations
of native methods when they are bound.

Test: ./test.py --host -j40

Bug: 37432636
Change-Id: I2432a8e4da1a677e8011ce495296f4ab9f42eb3e

7 years agoMerge "Add dexdiag_test"
David Sehr [Wed, 19 Apr 2017 16:41:45 +0000 (16:41 +0000)]
Merge "Add dexdiag_test"
am: ad70f8f997

Change-Id: Ib0b515f78bf12a1c8c2aaa2394b7c9bd2eae3181

7 years agoMerge "Add dexdiag_test"
David Sehr [Wed, 19 Apr 2017 16:37:46 +0000 (16:37 +0000)]
Merge "Add dexdiag_test"

7 years agoMerge "ART: Refactor run-test 924"
Andreas Gampe [Wed, 19 Apr 2017 16:18:33 +0000 (16:18 +0000)]
Merge "ART: Refactor run-test 924"
am: 70d9cf92f6

Change-Id: I805ddab8a1b96f53ba0f9dc67b0df98a429e088f

7 years agoMerge "ART: Filter more thread roots"
Andreas Gampe [Wed, 19 Apr 2017 16:18:13 +0000 (16:18 +0000)]
Merge "ART: Filter more thread roots"
am: 5e2c2894dc

Change-Id: Iabef998fd43ff59b586dc86516b6ee449781b3d4

7 years agoMerge "ART: Refactor run-test 924"
Treehugger Robot [Wed, 19 Apr 2017 16:14:17 +0000 (16:14 +0000)]
Merge "ART: Refactor run-test 924"

7 years agoMerge "ART: Filter more thread roots"
Treehugger Robot [Wed, 19 Apr 2017 16:13:40 +0000 (16:13 +0000)]
Merge "ART: Filter more thread roots"

7 years agoMerge "Record class status after verification."
Nicolas Geoffray [Wed, 19 Apr 2017 12:38:08 +0000 (12:38 +0000)]
Merge "Record class status after verification."
am: 25009fdd7a

Change-Id: I28f26f8df620687c3c2124812e7f228eb53d7e2e

7 years agoMerge "Record class status after verification."
Nicolas Geoffray [Wed, 19 Apr 2017 12:31:42 +0000 (12:31 +0000)]
Merge "Record class status after verification."

7 years agoMerge "ARM64: Heap poisoning for link-time Baker CC read barrier thunks."
Vladimir Marko [Wed, 19 Apr 2017 11:38:33 +0000 (11:38 +0000)]
Merge "ARM64: Heap poisoning for link-time Baker CC read barrier thunks."
am: 46d342f845

Change-Id: I38dcd3f91d902c7020aa39ef3541a1868f3ee596

7 years agoMerge "ARM64: Heap poisoning for link-time Baker CC read barrier thunks."
Vladimir Marko [Wed, 19 Apr 2017 11:32:49 +0000 (11:32 +0000)]
Merge "ARM64: Heap poisoning for link-time Baker CC read barrier thunks."

7 years agoMerge "Follow-up to 70d60275cc2860bde50e5f9c5b151e94f745ae14"
Sebastien Hertz [Wed, 19 Apr 2017 10:23:00 +0000 (10:23 +0000)]
Merge "Follow-up to 70d60275cc2860bde50e5f9c5b151e94f745ae14"
am: bea9172064

Change-Id: I7c55be3340ad08e8142c39804ea2b28d8492de00

7 years agoMerge "Follow-up to 70d60275cc2860bde50e5f9c5b151e94f745ae14"
Treehugger Robot [Wed, 19 Apr 2017 10:13:12 +0000 (10:13 +0000)]
Merge "Follow-up to 70d60275cc2860bde50e5f9c5b151e94f745ae14"

7 years agoMerge "Reduce timeout of JDWP tests"
Sebastien Hertz [Wed, 19 Apr 2017 09:38:26 +0000 (09:38 +0000)]
Merge "Reduce timeout of JDWP tests"
am: aebc6870db

Change-Id: I8f995fc15c007572662f65a2533d998da99c3be8

7 years agoARM64: Heap poisoning for link-time Baker CC read barrier thunks.
Vladimir Marko [Tue, 18 Apr 2017 12:55:13 +0000 (13:55 +0100)]
ARM64: Heap poisoning for link-time Baker CC read barrier thunks.

And fix running out of scratch registers for HArraySet
with large constant index and a reference to poison.

Test: Nexus 6P boots with heap poisoning enabled.
Test: testrunner.py --target with heap poisoning enabled on Nexus 6P.
Bug: 29516974
Bug: 30126666
Bug: 36141117
Change-Id: Ifb38f4a0e23a2963468772f34f294febfc340b8c

7 years agoMerge "Reduce timeout of JDWP tests"
Sebastien Hertz [Wed, 19 Apr 2017 09:26:54 +0000 (09:26 +0000)]
Merge "Reduce timeout of JDWP tests"

7 years agoReduce timeout of JDWP tests
Sebastien Hertz [Mon, 27 Mar 2017 09:35:54 +0000 (11:35 +0200)]
Reduce timeout of JDWP tests

This CL sets the timeout of JDWP tests to 10s (instead of the default
timeout of 60s).

This should save up time for continuous testing (~ 3min on host).
Indeed, some tests do wait until the timeout to detect that no reply
(or no event) has been received.

Test: art/tools/run-jdwp-tests.sh --mode=host --variant=X64
Change-Id: Id03c8a1d629e6da551cf8eb405cc79754a363fe0

7 years agoMerge "Revert "Invoke dex2oat explictly before dalvikvm""
Nicolas Geoffray [Wed, 19 Apr 2017 09:15:55 +0000 (09:15 +0000)]
Merge "Revert "Invoke dex2oat explictly before dalvikvm""
am: 75be076511

Change-Id: I40d7f7b443408716de3bb04f39587b39d39c0728

7 years agoMerge "Revert "Invoke dex2oat explictly before dalvikvm""
Nicolas Geoffray [Wed, 19 Apr 2017 09:01:46 +0000 (09:01 +0000)]
Merge "Revert "Invoke dex2oat explictly before dalvikvm""

7 years agoRevert "Invoke dex2oat explictly before dalvikvm"
Nicolas Geoffray [Wed, 19 Apr 2017 09:01:29 +0000 (09:01 +0000)]
Revert "Invoke dex2oat explictly before dalvikvm"

Fails on device with:
07-13 04:35:49.410 24424 24424 F dex2oat : instruction_set_features.cc:58] static std::unique_ptr<const InstructionSetFeatures> art::InstructionSetFeatures::FromVariant(art::InstructionSet, const std::string &, std::string *) unimplemented None

Bug: 36824842

This reverts commit 4806f7afc92b1812cefaab291235d01773732400.

Change-Id: I34a23fb69b0284e6d70ec0a54d5ada9e107ffeb7

7 years agoRecord class status after verification.
Nicolas Geoffray [Wed, 19 Apr 2017 08:36:24 +0000 (09:36 +0100)]
Record class status after verification.

The class status was recorded when doing vdex verification, or
any compilation (quickening or optimizing), but not when only doing
verification.

bug:37446669
Test:compiler_driver_test
Change-Id: Id027c7a9776ed651de570a0f3417c969c8cff9cd

7 years agoFollow-up to 70d60275cc2860bde50e5f9c5b151e94f745ae14
Sebastien Hertz [Tue, 18 Apr 2017 16:28:51 +0000 (18:28 +0200)]
Follow-up to 70d60275cc2860bde50e5f9c5b151e94f745ae14

Test: make -j build-art-host
Change-Id: Id6e81518041bd64dec537ff3da2fa049d39b27d0

7 years agoMerge "Always check result of Thread::ModifySuspendCount"
Sebastien Hertz [Wed, 19 Apr 2017 07:31:49 +0000 (07:31 +0000)]
Merge "Always check result of Thread::ModifySuspendCount"
am: 0d8cf9106c

Change-Id: I782e9dc794ea46bb29a777c10cda45e36fd26a5f

7 years agoMerge "Always check result of Thread::ModifySuspendCount"
Sebastien Hertz [Wed, 19 Apr 2017 07:23:36 +0000 (07:23 +0000)]
Merge "Always check result of Thread::ModifySuspendCount"

7 years agoMerge "Call mirror::CallSite::VisitRoots"
Mathieu Chartier [Wed, 19 Apr 2017 02:48:00 +0000 (02:48 +0000)]
Merge "Call mirror::CallSite::VisitRoots"
am: ea24e09568

Change-Id: I3f1dfaac4eb3e9e2cc5cc38d68c2da84fd61ed58

7 years agoMerge "Call mirror::CallSite::VisitRoots"
Mathieu Chartier [Wed, 19 Apr 2017 02:41:02 +0000 (02:41 +0000)]
Merge "Call mirror::CallSite::VisitRoots"

7 years agoAllow dex2oat to handle relative paths.
Jeff Hao [Thu, 6 Apr 2017 00:05:46 +0000 (17:05 -0700)]
Allow dex2oat to handle relative paths.

During installation at compile time, the PackageManager is passing
shared libraries to dex2oat with -classpath. For split apps, we want the
splits to have the proper dependencies, and are now passing previous
parts of the split apk as shared libraries as we compile them all. These
apks are staged in a temp dir during compilation, so we pass a relative
path for them instead.

Since PackageManager can now pass relative paths to dex2oat as shared
libraries, dex2oat has an added --classpath-dir switch to specify the
directory to use for relative class paths. At runtime when checking
shared libraries, we use oat file functionality to resolve relative paths
to determine if the paths match.

Bug: 34169257
Test: cts-tradefed run singleCommand cts -d --module
CtsAppSecurityHostTestCases -t android.appsecurity.cts.SplitTests

Merged-In: I9667f0069c8d12e94598f8a78888d3855d870824
(cherry-picked from commit f79ac83a8c18b0bd81aafc9c8823f6bed35d8847)

Change-Id: I8e4703fdd4bfeb94f982e93abb7eb0cd71060fce

7 years agoMerge "Invoke dex2oat explictly before dalvikvm"
Calin Juravle [Tue, 18 Apr 2017 23:35:15 +0000 (23:35 +0000)]
Merge "Invoke dex2oat explictly before dalvikvm"
am: 77ced6adfd

Change-Id: I60b418c83278e135064e9d657d5a75d95619d854

7 years agoCall mirror::CallSite::VisitRoots
Mathieu Chartier [Tue, 18 Apr 2017 23:14:19 +0000 (16:14 -0700)]
Call mirror::CallSite::VisitRoots

Needed to visit CallSite static class root.

Test: test/run-test --no-patchoat --relocate --host --64 --interpreter --gdb 952

Bug: 33191717

Change-Id: I1fad3df8ad810c5c7905afadfa25cdc0901ef035

7 years agoMerge "Invoke dex2oat explictly before dalvikvm"
Calin Juravle [Tue, 18 Apr 2017 23:20:16 +0000 (23:20 +0000)]
Merge "Invoke dex2oat explictly before dalvikvm"

7 years agoART: Refactor run-test 924
Andreas Gampe [Wed, 12 Apr 2017 15:42:16 +0000 (08:42 -0700)]
ART: Refactor run-test 924

Move testing to a dedicated thread to have a known thread name.
Change event reporting to be Java-side. Use Java-side thread list
(from Thread.getAllStackTraces) as comparison for minimal expected
set of threads.

Bug: 32072923
Test: art/test/testrunner/testrunner.py -b --host -t 924
Change-Id: I238ffc202e42eea8d1788137715188d3dfbcc8fb

7 years agoAdd dexdiag_test
David Sehr [Fri, 14 Apr 2017 22:26:09 +0000 (15:26 -0700)]
Add dexdiag_test

Tests that dexdiag runs on the current process and returns with a
non-error status for a variety of command line options.

Bug: 35800981
Test: make test-art-target-gtest-dexdiag_test
Change-Id: Ib6f21a99ddec270cf8026a6123b028fe4b3fb840

7 years agoMerge "Fix obsolete method change check."
Alex Light [Tue, 18 Apr 2017 22:53:54 +0000 (22:53 +0000)]
Merge "Fix obsolete method change check."
am: 494505a9de

Change-Id: Ie3dac35eb222fb3662b2588576ca71c7a029495a

7 years agoMerge "Fix obsolete method change check."
Treehugger Robot [Tue, 18 Apr 2017 22:42:58 +0000 (22:42 +0000)]
Merge "Fix obsolete method change check."

7 years agoInvoke dex2oat explictly before dalvikvm
Calin Juravle [Wed, 12 Apr 2017 02:04:28 +0000 (19:04 -0700)]
Invoke dex2oat explictly before dalvikvm

The goal is to stop relying on dex2oat being run when dex files are
loaded.

Test: ./out/host/linux-x86/bin/art --profile -Ximage:$PWD/out/host/linux-x86/framework/core.art -Xusejit:true -Xcompiler-option --compiler-filter=speed -Xcompiler-option --compiler-backend=Optimizing -verbose:oat -Djava.library.path=$PWD/out/x86_64/host/linux-x86/lib64 -cp $PWD/generated/benchmarks.dex benchmarks.ExoPlayerBench.java.ExoPlayerBench

Bug: 36824842
Change-Id: I9f4a1384cdc91502edea08402ee984c57ff8c37d

7 years agofault_handler: use SafeCopy to decode x86 instruction length.
Josh Gao [Tue, 18 Apr 2017 18:18:56 +0000 (11:18 -0700)]
fault_handler: use SafeCopy to decode x86 instruction length.

Prevent a crash in the x86 fault handler when pc points to garbage and
we try to figure out its instruction length.

Bug: http://b/30836730
Test: m test-art-host
Change-Id: Ic1fbb8856e30140f0e1ebc9caccf9559e88ff137

7 years agobase: add SafeCopy.
Josh Gao [Tue, 18 Apr 2017 01:31:26 +0000 (18:31 -0700)]
base: add SafeCopy.

Add a function that uses process_vm_readv on Linux to safely
dereference pointers without the risk of segfault.

Bug: http://b/30836730
Test: safe_copy_test on host
Change-Id: I10bafcffe2172e17b00f65455d1dd6a08aa631d7

7 years agoART: Filter more thread roots
Andreas Gampe [Tue, 18 Apr 2017 20:59:09 +0000 (13:59 -0700)]
ART: Filter more thread roots

Also filter interface classes that may be held by the JIT.

Bug: 31385354
Test: art/test/testrunner/testrunner.py --host -b -t 913
Change-Id: I129ab8c28e398d779d9d43b03358aa54a9a14c8c

7 years agoFix obsolete method change check.
Alex Light [Tue, 18 Apr 2017 20:03:31 +0000 (13:03 -0700)]
Fix obsolete method change check.

We were incorrectly checking for changes in the obsolete-method map.
This could cause issues if a class was redefined multiple times.

Bug: 37475600

Test: ./test.py --host -j40
Test: cts-tradefed run cts-dev --module CtsJvmtiRedefineClassesHostTestCases

Change-Id: Icf39d5154c0e48461405b700bf1fa20830195fc1

7 years agoMerge "Make ART build/test configurations use the CC collector by default."
Roland Levillain [Tue, 18 Apr 2017 18:28:13 +0000 (18:28 +0000)]
Merge "Make ART build/test configurations use the CC collector by default."
am: 741a81af44

Change-Id: Ica953a72f63c07fb551b75b2f0448bb1212d792f

7 years agoMerge "Differentiate between native alloc and normal background GC"
Mathieu Chartier [Tue, 18 Apr 2017 18:27:53 +0000 (18:27 +0000)]
Merge "Differentiate between native alloc and normal background GC"
am: e4e7d601ef

Change-Id: I26f9a501d9da8b5d9cdefc08ae1a4fa394a533b6

7 years agoMerge "ART: Make less lock-level noise on abort"
Andreas Gampe [Tue, 18 Apr 2017 18:27:38 +0000 (18:27 +0000)]
Merge "ART: Make less lock-level noise on abort"
am: 2888e85164

Change-Id: I58b17056982de8e306ab6e0dfef430f74b5ec11f

7 years agoMerge "Make ART build/test configurations use the CC collector by default."
Treehugger Robot [Tue, 18 Apr 2017 18:25:01 +0000 (18:25 +0000)]
Merge "Make ART build/test configurations use the CC collector by default."

7 years agoMerge "Differentiate between native alloc and normal background GC"
Mathieu Chartier [Tue, 18 Apr 2017 18:24:00 +0000 (18:24 +0000)]
Merge "Differentiate between native alloc and normal background GC"

7 years agoMerge "ART: Make less lock-level noise on abort"
Treehugger Robot [Tue, 18 Apr 2017 18:21:41 +0000 (18:21 +0000)]
Merge "ART: Make less lock-level noise on abort"

7 years agoDifferentiate between native alloc and normal background GC
Mathieu Chartier [Mon, 17 Apr 2017 22:24:43 +0000 (15:24 -0700)]
Differentiate between native alloc and normal background GC

Added a new GC cause kGcCauseForNativeAllocBackground.

Bug: 35872915

Test: test-art-host

Change-Id: I94e17f8bd53af29f2862b9910bd8abd2df97e229

7 years agoMerge "Use correct type for GetValueFromShadowFrame"
Mathieu Chartier [Tue, 18 Apr 2017 17:16:48 +0000 (17:16 +0000)]
Merge "Use correct type for GetValueFromShadowFrame"
am: c36a970fcd

Change-Id: I7ae578e671658c4790aaaf67aac22adfded9b5df

7 years agoMerge "Use WARN_UNUSED consistently in ART."
Roland Levillain [Tue, 18 Apr 2017 17:16:33 +0000 (17:16 +0000)]
Merge "Use WARN_UNUSED consistently in ART."
am: b2410c931a

Change-Id: I9bc56ed10c7c4b7d72b89f5cfc95ac964b3e4138

7 years agoMerge "Use correct type for GetValueFromShadowFrame"
Mathieu Chartier [Tue, 18 Apr 2017 17:14:00 +0000 (17:14 +0000)]
Merge "Use correct type for GetValueFromShadowFrame"

7 years agoMerge "Use WARN_UNUSED consistently in ART."
Roland Levillain [Tue, 18 Apr 2017 17:06:25 +0000 (17:06 +0000)]
Merge "Use WARN_UNUSED consistently in ART."

7 years agoUse correct type for GetValueFromShadowFrame
Mathieu Chartier [Tue, 18 Apr 2017 03:12:29 +0000 (20:12 -0700)]
Use correct type for GetValueFromShadowFrame

The field type is not necessarily the input type for boxed
primitives. If the field type is < 32 bits, it means there will be
partial object pointer in the JValue. If a conversion check is
later needed in GetUnboxedTypeAndValue, it will crash. The fix is
to use the PTypes.

Bug: 37446461
Test: test-art-host
Change-Id: I0c4b405f0c13910523b98a87ef12b9f302a5e241

7 years agoMerge "JDWP: fix Dbg::ResumeThread"
Sebastien Hertz [Tue, 18 Apr 2017 16:22:31 +0000 (16:22 +0000)]
Merge "JDWP: fix Dbg::ResumeThread"
am: 2203253254

Change-Id: Ie4f5a2ce448d182eb306b59f718a52a86b999bf7

7 years agoMerge "JDWP: fix Dbg::ResumeThread"
Sebastien Hertz [Tue, 18 Apr 2017 16:11:55 +0000 (16:11 +0000)]
Merge "JDWP: fix Dbg::ResumeThread"

7 years agoAlways check result of Thread::ModifySuspendCount
Sebastien Hertz [Fri, 14 Apr 2017 13:05:12 +0000 (15:05 +0200)]
Always check result of Thread::ModifySuspendCount

Ensures that we never ignore the result of ModifySuspendCount so that
we can react if the suspend count is not updated as expected.

This CL does the following:
* Adds __attribute__((warn_unused_result)) on the method to raise an
  error at compilation time if the result is ignored.
* Wraps calls with DCHECK where the result used to be ignored.

Bug: 27385848
Test: make -j test-art-host
Test: art/tools/run-jdwp-tests.sh --mode=host --variant=X64
Change-Id: I2d0e1ab7158c70ec8076c8bae6e4b814aee75af6

7 years agoMerge "ART: Call ThreadGroup.add in Thread::FinishStartup"
Andreas Gampe [Tue, 18 Apr 2017 15:22:26 +0000 (15:22 +0000)]
Merge "ART: Call ThreadGroup.add in Thread::FinishStartup"
am: 2aac653df7

Change-Id: Ia457840ddc3c96eb3271dde5e210db26df404a58

7 years agoMerge "ART: Call ThreadGroup.add in Thread::FinishStartup"
Treehugger Robot [Tue, 18 Apr 2017 15:12:58 +0000 (15:12 +0000)]
Merge "ART: Call ThreadGroup.add in Thread::FinishStartup"

7 years agoMerge "Fix ARM64 SystemArrayCopy intrinsic with large constant dest position."
Roland Levillain [Tue, 18 Apr 2017 12:45:45 +0000 (12:45 +0000)]
Merge "Fix ARM64 SystemArrayCopy intrinsic with large constant dest position."
am: 1cae72e6cf

Change-Id: Id814f38204ec28bb5d84e5ec772d5caf79a7e274

7 years agoMerge "Fix ARM64 SystemArrayCopy intrinsic with large constant dest position."
Roland Levillain [Tue, 18 Apr 2017 12:37:10 +0000 (12:37 +0000)]
Merge "Fix ARM64 SystemArrayCopy intrinsic with large constant dest position."

7 years agoMerge "Revert "Disable 160-read-barrier-stress temporarily""
Vladimir Marko [Tue, 18 Apr 2017 12:13:13 +0000 (12:13 +0000)]
Merge "Revert "Disable 160-read-barrier-stress temporarily""
am: e58b971b57

Change-Id: I288940985c066629dd5ab2e9312997b89055098f

7 years agoMerge "Revert "Disable 160-read-barrier-stress temporarily""
Vladimir Marko [Tue, 18 Apr 2017 12:06:55 +0000 (12:06 +0000)]
Merge "Revert "Disable 160-read-barrier-stress temporarily""

7 years agoMerge "Fix Arena allocation tracking."
Vladimir Marko [Tue, 18 Apr 2017 11:35:41 +0000 (11:35 +0000)]
Merge "Fix Arena allocation tracking."
am: 4cb99a13d2

Change-Id: I4353655032f22837c55d4d221619126210b8aa47

7 years agoMerge "Fix Arena allocation tracking."
Treehugger Robot [Tue, 18 Apr 2017 11:29:25 +0000 (11:29 +0000)]
Merge "Fix Arena allocation tracking."

7 years agoUse WARN_UNUSED consistently in ART.
Roland Levillain [Tue, 18 Apr 2017 11:01:58 +0000 (12:01 +0100)]
Use WARN_UNUSED consistently in ART.

Test: mmma art
Change-Id: I776840725f56258c45edfcfd165da61ab653f0b5

7 years agoFix ARM64 SystemArrayCopy intrinsic with large constant dest position.
Roland Levillain [Thu, 13 Apr 2017 18:34:30 +0000 (19:34 +0100)]
Fix ARM64 SystemArrayCopy intrinsic with large constant dest position.

Make sure we do not deplete the whole VIXL scratch register pool, so
that VIXL can still use IP0 as a temporary when emitting
macro-instructions.

Test: art/test/testrunner/testrunner.py --optimizing --target --64
Bug: 37256530
Change-Id: I5da22e552297fad87db5763e2dab60ae6a7a43af

7 years agoRevert "Disable 160-read-barrier-stress temporarily"
Vladimir Marko [Tue, 18 Apr 2017 09:47:12 +0000 (09:47 +0000)]
Revert "Disable 160-read-barrier-stress temporarily"

And reduce the number of fields in class ManyFields from
10000 to 5000 to reduce memory pressure on Jack. Split
the ManyFields class in a simple hierarchy to keep files
under 64KiB and allow compilation with javac.

Test: testrunner.py --host -j 48
Test: run-test --host --jvm 160-read-barrier-stress
Bug: 37335480

This reverts commit 101074999bd339c276eeaaf0538930d90a96657e.

Change-Id: I52217fd2c9d00a5b045a7faa6e4dc1438c7f93b1

7 years agoART: Make less lock-level noise on abort
Andreas Gampe [Tue, 18 Apr 2017 04:40:28 +0000 (21:40 -0700)]
ART: Make less lock-level noise on abort

The lock-level violations with the abort lock aren't really all
that interesting.

Test: m test-art-host
Change-Id: I8a5fc687009db914ec8f60d86068d87e71f8a894

7 years agoART: Call ThreadGroup.add in Thread::FinishStartup
Andreas Gampe [Tue, 18 Apr 2017 03:19:14 +0000 (20:19 -0700)]
ART: Call ThreadGroup.add in Thread::FinishStartup

ART should add the main thread to the main ThreadGroup. Behavior
of the Thread constructor changed.

Bug: 37444210
Test: art/test/testrunner/testrunner.py -b --host -t 051
Test: m test-art-host
Test: m build-art-host && art/tools/run-libcore-tests.sh --mode=host
Change-Id: I92cf2f9a6c5c3fdf385eb7925addc38b64fa4d98

7 years agoMerge "sigchain: switch from __thread to pthread_setspecific."
Josh Gao [Tue, 18 Apr 2017 01:08:05 +0000 (01:08 +0000)]
Merge "sigchain: switch from __thread to pthread_setspecific."
am: 36831abc29

Change-Id: Ie5567b3889bf9b2af37ef2e88296f392d7f86073

7 years agoMerge "sigchain: switch from __thread to pthread_setspecific."
Treehugger Robot [Tue, 18 Apr 2017 00:58:38 +0000 (00:58 +0000)]
Merge "sigchain: switch from __thread to pthread_setspecific."

7 years agosigchain: switch from __thread to pthread_setspecific.
Josh Gao [Mon, 17 Apr 2017 22:58:36 +0000 (15:58 -0700)]
sigchain: switch from __thread to pthread_setspecific.

__thread is implemented via emutls on Android, which will result in the
thread local variable being allocated again and leaked if it gets used
after it has been destructed already (e.g. by a later destructor
calling sigprocmask, or triggering a signal handler).

Switch to pthread_setspecific, which doesn't suffer from this problem.

Bug: http://b/36871013
Test: ran dalvikvm on a class that spins creating threads
Change-Id: Ie5deab453be387490ba30a0010e12f60d736c8ad