OSDN Git Service

android-x86/frameworks-base.git
4 years agodocs: Fixed contradictory info in IntentFilter
Kevin Hufnagle [Tue, 3 Sep 2019 21:54:29 +0000 (21:54 +0000)]
docs: Fixed contradictory info in IntentFilter

The docs now (correctly) state that, if an intent filter specifies no
actions, then it only matches intents that don't specify/contain an
action.

Test: make ds-docs -j32

Bug: 140435265
Change-Id: I8931c6540cb22edd15e8caa1be984ca70efcdc96

4 years agoMerge "docs: Improved tick/click effect descriptions" into qt-dev
Kevin Hufnagle [Fri, 30 Aug 2019 01:26:35 +0000 (01:26 +0000)]
Merge "docs: Improved tick/click effect descriptions" into qt-dev

4 years agoMerge "Unset INSTALL_DISABLE_VERIFICATION flag if install is not from system" into...
TreeHugger Robot [Thu, 29 Aug 2019 21:47:30 +0000 (21:47 +0000)]
Merge "Unset INSTALL_DISABLE_VERIFICATION flag if install is not from system" into qt-dev

4 years agodocs: Improved tick/click effect descriptions
Kevin Hufnagle [Thu, 29 Aug 2019 04:29:08 +0000 (04:29 +0000)]
docs: Improved tick/click effect descriptions

Test: make ds-docs -j32

Bug: 139888074
Change-Id: I939aaa4cf81ddab1705611222c12a60823493d38

4 years agoMerge "docs: Added desc. of launcher app criteria in Q" into qt-dev
Kevin Hufnagle [Wed, 28 Aug 2019 22:08:47 +0000 (22:08 +0000)]
Merge "docs: Added desc. of launcher app criteria in Q" into qt-dev

4 years agoMerge "Docs: clarify getSharedPreferences behavior" into qt-dev
Andrew Solovay [Wed, 28 Aug 2019 18:11:44 +0000 (18:11 +0000)]
Merge "Docs: clarify getSharedPreferences behavior" into qt-dev

4 years agodocs: Added desc. of launcher app criteria in Q
Kevin Hufnagle [Thu, 15 Aug 2019 00:23:58 +0000 (17:23 -0700)]
docs: Added desc. of launcher app criteria in Q

As of Android Q, an app is included in the return value of
LauncherApps#getActivityList() unless it fulfills specific criteria.
This CL describes the conditions necessary for an app's activities
to *not* appear in the list.

Test: make ds-docs -j32

Bug: 130352392
Change-Id: I6a6e17351a6c1234229d1d7eb8147ee2c24ee2c9

4 years agoMerge "aw: Correct doc of addJavascriptInterface()" into qt-dev
TreeHugger Robot [Wed, 28 Aug 2019 01:39:59 +0000 (01:39 +0000)]
Merge "aw: Correct doc of addJavascriptInterface()" into qt-dev

4 years agoDocs: clarify getSharedPreferences behavior
Nate Fischer [Tue, 27 Aug 2019 23:37:00 +0000 (16:37 -0700)]
Docs: clarify getSharedPreferences behavior

No change to logic, only documentation.

This updates Context#getSharedPreferences docs:

 * Fix a typo ("thead" -> "thread")
 * Formatting: use <p> when appropriate, {@link} to other APIs, limit
   the @param to only a single sentence
 * Mention getSharedPreferences() may actually perform disk IO (this was
   undocumented)
 * Mention Editor#apply() as well as #commit()

Fixes: 140137651
Test: make docs
Change-Id: I245371d13d4f317c6c522debcdf7938ab783f897

4 years agoUnset INSTALL_DISABLE_VERIFICATION flag if install is not from system
Nikita Ioffe [Tue, 30 Jul 2019 16:10:27 +0000 (17:10 +0100)]
Unset INSTALL_DISABLE_VERIFICATION flag if install is not from system

Bug: 138650665
Test: pushed manual privapp that attempts an install
  with INSTALL_DISABLE_VERIFICATION flag.
  Checked that PackageVerifier was called.
Change-Id: I041d2e5f6d2609bfe9475f24eefb936f0c8e2a32
Merged-In: I041d2e5f6d2609bfe9475f24eefb936f0c8e2a32

4 years agoUse mContext directly
Daniel Rosenberg [Tue, 27 Aug 2019 02:29:45 +0000 (19:29 -0700)]
Use mContext directly

We already have the context saved, so we can just use that.

Test: Edited code to force expection path to be called, confirmed
      reboot happens
Bug: 138952436
Bug: 140111727

Change-Id: I40e95d72c63f864131f0028c47f121463d0f6dff

4 years agoMerge "docs: Added content desc in ImageView example." into qt-dev
Kevin Hufnagle [Mon, 26 Aug 2019 21:05:37 +0000 (21:05 +0000)]
Merge "docs: Added content desc in ImageView example." into qt-dev

4 years agoaw: Correct doc of addJavascriptInterface()
Shimi Zhang [Mon, 26 Aug 2019 18:01:12 +0000 (11:01 -0700)]
aw: Correct doc of addJavascriptInterface()

The Javadoc of addJavascriptInterface() mentioned that the injected
Java object will be injected to main frame, but this is not telling
a full picture. The current implementation will inject the Java
object to all the frames actually.

This CL corrected the misleading wording and add a new warning to
explicitly call it out as a security risk.

Bug: 113336656
Test: make ds-docs
Change-Id: Ia79381d1ab38afa963ea7365526749c14e25238c

4 years agoAdd SocketUtils CTS tests
Paul Hu [Tue, 18 Jun 2019 11:26:29 +0000 (04:26 -0700)]
Add SocketUtils CTS tests

Test APIs below:
makeNetlinkSocketAddress(int, int)
makePacketSocketAddress(short, int)
makePacketSocketAddress(int, byte[])
closeSocket(java.io.FileDescriptor)

Bug:129200596
Test: atest FrameworksNetTests
      atest CtsNetTestCases --instant
Merged-In: I36252fdf516cf4a9d4506b615cdb38f5413739e5
(cherry picked from commit 93a53224d3a1cd6fc1de7d94955e03116b744e4a)

Change-Id: I0963acaf00c5bdd93db0503c426f190f409ca076

4 years agoMerge "DO NOT MERGE: Fixed an issue where the notification icons wouldn't show while...
Selim Cinek [Tue, 20 Aug 2019 23:39:13 +0000 (23:39 +0000)]
Merge "DO NOT MERGE: Fixed an issue where the notification icons wouldn't show while docked" into qt-dev

4 years agoDO NOT MERGE: Fixed an issue where the notification icons wouldn't show while docked
Selim Cinek [Mon, 19 Aug 2019 18:57:11 +0000 (11:57 -0700)]
DO NOT MERGE: Fixed an issue where the notification icons wouldn't show while docked

Since we're using the pulsing state for docking, the icons would now
become clipped while pulsing.

Fixes: 139096431
Test: dock, observe notification icons showing
Change-Id: If251e6b18c03b2824b4d3ea4dab82d4a403565f1
Merged-In: I8f7bd7a6a0562942ed3e12f28705043722d177e8

4 years agoMerge "WebView: prettyprint docs" into qt-dev
TreeHugger Robot [Mon, 19 Aug 2019 19:06:32 +0000 (19:06 +0000)]
Merge "WebView: prettyprint docs" into qt-dev

4 years agoMerge "API: Explicitly track incompatibilities with previous API versions" into qt-dev
TreeHugger Robot [Thu, 15 Aug 2019 18:07:32 +0000 (18:07 +0000)]
Merge "API: Explicitly track incompatibilities with previous API versions" into qt-dev

4 years agodocs: Added content desc in ImageView example.
Kevin Hufnagle [Thu, 15 Aug 2019 00:50:17 +0000 (17:50 -0700)]
docs: Added content desc in ImageView example.

The example ImageView at the beginning of the class description now
includes a content description attribute. Also updated the links in
the first paragraph where code fonts aren't necessary.

Test: make ds-docs -j32

Bug: 138856073
Change-Id: I33a75dc31d68289d955979d2fe8afe2ae3d4770e

4 years agoMerge "Revert "docs: Added desc. of launcher app criteria in Q"" into qt-dev
Kevin Hufnagle [Wed, 14 Aug 2019 23:32:22 +0000 (23:32 +0000)]
Merge "Revert "docs: Added desc. of launcher app criteria in Q"" into qt-dev

4 years agoRevert "docs: Added desc. of launcher app criteria in Q"
Kevin Hufnagle [Wed, 14 Aug 2019 19:22:59 +0000 (19:22 +0000)]
Revert "docs: Added desc. of launcher app criteria in Q"

This reverts commit 786f22e4169126c82358490ad6e9c70028fc102b.

Reason for revert: Need further feedback from SMEs

Bug: 130352392

Change-Id: I51b3bd19e27d28fe3aea300893da50bbf889ec73

4 years agoMerge "docs: Added desc. of launcher app criteria in Q" into qt-dev
Kevin Hufnagle [Wed, 14 Aug 2019 19:22:11 +0000 (19:22 +0000)]
Merge "docs: Added desc. of launcher app criteria in Q" into qt-dev

4 years agoMerge "docs: Correct sensor runtime permission documentation" into qt-dev
Brian Duddie [Wed, 14 Aug 2019 17:32:05 +0000 (17:32 +0000)]
Merge "docs: Correct sensor runtime permission documentation" into qt-dev

4 years agoMerge "apply empty transaction in startActivitySync" into qt-dev
TreeHugger Robot [Wed, 14 Aug 2019 06:42:05 +0000 (06:42 +0000)]
Merge "apply empty transaction in startActivitySync" into qt-dev

4 years agoWebView: prettyprint docs
Nate Fischer [Tue, 13 Aug 2019 03:44:51 +0000 (20:44 -0700)]
WebView: prettyprint docs

No change to logic, only docs.

Use class=prettyprint so docs are syntax highlighted. This also fixes a
section which should have been an ordered list but abused <pre> instead.

Bug: 125526827
Test: make -j4 docs
Change-Id: Iac780ace066be35620d5121b1977df404eaf18c1

4 years agodocs: Correct sensor runtime permission documentation
Brian Duddie [Tue, 13 Aug 2019 18:42:19 +0000 (11:42 -0700)]
docs: Correct sensor runtime permission documentation

The ACTIVITY_RECOGNITION permission applies to TYPE_STEP_DETECTOR, not
TYPE_GEOMAGNETIC_ROTATION_VECTOR.

Bug: 139363621
Test: n/a, comment update only
Change-Id: Ibce74be1e704ded04ae710988d0e03df43ab1cf9

4 years agodocs: Added desc. of launcher app criteria in Q
Kevin Hufnagle [Mon, 12 Aug 2019 23:52:41 +0000 (16:52 -0700)]
docs: Added desc. of launcher app criteria in Q

As of Android Q, an app is included in the return value of
LauncherApps#getActivityList() unless it fulfills specific criteria.
This CL describes the conditions necessary for an app's activities
to *not* appear in the list.

Test: make ds-docs -j32

Bug: 130352392
Change-Id: Iad888a7a7f47d090da1b143ac152705577144d20

4 years agoAPI: Explicitly track incompatibilities with previous API versions
Adrian Roos [Mon, 12 Aug 2019 15:47:39 +0000 (17:47 +0200)]
API: Explicitly track incompatibilities with previous API versions

Bug: 139128921
Test: make checkapi
Change-Id: I1f17b57705e2f7350b55ab278e06fc4e988771ff
Merged-In: I1f17b57705e2f7350b55ab278e06fc4e988771ff

4 years agoMerge "Import translations. DO NOT MERGE" into qt-dev
TreeHugger Robot [Mon, 12 Aug 2019 04:00:48 +0000 (04:00 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-dev

4 years agoMerge "Ensure isTopBucket() gets set when there is just one notification" into qt-dev
Ned Burns [Fri, 9 Aug 2019 22:21:45 +0000 (22:21 +0000)]
Merge "Ensure isTopBucket() gets set when there is just one notification" into qt-dev

4 years agoImport translations. DO NOT MERGE
Bill Yi [Fri, 9 Aug 2019 22:06:46 +0000 (15:06 -0700)]
Import translations. DO NOT MERGE

Auto-generated-cl: translation import

Bug: 64712476
Change-Id: Ibb92c8650e8f63fd70e7a23dcbde26ce19868d4a

4 years agoMerge "Import translations. DO NOT MERGE" into qt-dev
TreeHugger Robot [Fri, 9 Aug 2019 18:42:27 +0000 (18:42 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-dev

4 years agoEnsure isTopBucket() gets set when there is just one notification
Ned Burns [Thu, 8 Aug 2019 17:43:57 +0000 (13:43 -0400)]
Ensure isTopBucket() gets set when there is just one notification

My descendants will vilify this CL for generations to come. We'll
clean it up for R, but this is our last, best hope for fixing things
in Q.

Bug: 138775282

Test: manual
Change-Id: I615b2f7fddca30dae67dbaab0e5d54a824a4c441
Merged-In: I615b2f7fddca30dae67dbaab0e5d54a824a4c441
(cherry picked from commit 2d35980e7201e042e253fadd0eb55e1866fc28d9)

4 years agoImport translations. DO NOT MERGE
Bill Yi [Fri, 9 Aug 2019 01:58:21 +0000 (18:58 -0700)]
Import translations. DO NOT MERGE

Auto-generated-cl: translation import

Bug: 64712476
Change-Id: If8df5134da53280a8a52b21df9d4769d31230d0a

4 years agoMerge "Import translations. DO NOT MERGE" into qt-dev
TreeHugger Robot [Fri, 9 Aug 2019 01:08:59 +0000 (01:08 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-dev

4 years agoMerge "Add a blacklist for preinstalled carrier apps." into qt-dev
Andrew Sapperstein [Thu, 8 Aug 2019 20:50:09 +0000 (20:50 +0000)]
Merge "Add a blacklist for preinstalled carrier apps." into qt-dev

4 years agoMerge "Avoid using secondary displays as launch params when not support" into qt-dev
bsears [Thu, 8 Aug 2019 17:51:11 +0000 (17:51 +0000)]
Merge "Avoid using secondary displays as launch params when not support" into qt-dev

4 years agoImport translations. DO NOT MERGE
Bill Yi [Thu, 8 Aug 2019 17:30:47 +0000 (10:30 -0700)]
Import translations. DO NOT MERGE

Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I1fc9b1dc26f21604c06de951f0bfc0ec4e5e1155

4 years agoMerge "Cleans up sharedUser regardless of creation logic" into qt-dev
TreeHugger Robot [Thu, 8 Aug 2019 16:18:33 +0000 (16:18 +0000)]
Merge "Cleans up sharedUser regardless of creation logic" into qt-dev

4 years agoAdd a blacklist for preinstalled carrier apps.
Andrew Sapperstein [Wed, 7 Aug 2019 22:04:35 +0000 (15:04 -0700)]
Add a blacklist for preinstalled carrier apps.

Allows an OEM to specify that a preinstalled carrier app, even if
TelephonyManager says it should have carrier privileges, does not
get granted the default permissions and does not get enabled when
a compatible SIM is inserted.

Bug: 138150105
Test: verified locally
Change-Id: I0afec28f1f18227947c1fe9e6bb5fd0dad3b5dac
Merged-In: I0afec28f1f18227947c1fe9e6bb5fd0dad3b5dac

4 years agoCleans up sharedUser regardless of creation logic
Patrick Baumann [Thu, 8 Aug 2019 00:56:58 +0000 (17:56 -0700)]
Cleans up sharedUser regardless of creation logic

Prior to this change, we were not updating the shared user a package
setting belongs to if the package setting was not deep copied. In the
case that shared users didn't match, we were not deep copying and so
were not updating later. There is a more fundamental change to be made
here, but we're limiting risk by keeping this change as small as
possible.

Bug: 138919405
Test: atest AppSecurityTests
Test: manual; flash P then flash this build: observe consistent PackageSettings
Change-Id: Ib22f9e6a1fb3104bec4eb3e5b1de983e19d49dce

4 years agoMerge "docs: Removed dates in obsolete field messages." into qt-dev
Kevin Hufnagle [Wed, 7 Aug 2019 22:05:16 +0000 (22:05 +0000)]
Merge "docs: Removed dates in obsolete field messages." into qt-dev

4 years agoapply empty transaction in startActivitySync
Prabir Pradhan [Fri, 26 Jul 2019 21:21:21 +0000 (14:21 -0700)]
apply empty transaction in startActivitySync

Force SurfaceFlinger to update synchronously by applying an empty
transaction. Without this, SurfaceFlinger will only update after the
next vsync, which may only happen after the instrumentation already
starts.

Since InputFlinger will only have the proper InputWindowInfo after
SurfaceFlinger updates, waiting for the vsync caused some
instruemntation tests to be flaky.

Bug: 138263890
Test: atest android.view.cts.HoverTest
Change-Id: I5457ab67ac574530dc1aa84549ca11e7e3f0d714

4 years agoMerge "Import translations. DO NOT MERGE" into qt-dev
TreeHugger Robot [Wed, 7 Aug 2019 05:28:25 +0000 (05:28 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-dev

4 years agodocs: Removed dates in obsolete field messages.
Kevin Hufnagle [Wed, 7 Aug 2019 01:17:11 +0000 (18:17 -0700)]
docs: Removed dates in obsolete field messages.

Notices about obsolete fields and methods now mention the publish
location (Google Play Store) or Android version (Q and higher).

Test: make ds-docs

Bug: 122482744
Change-Id: Idb60fef711401d43af8eb71343f157590c311571

4 years agoImport translations. DO NOT MERGE
Bill Yi [Tue, 6 Aug 2019 21:07:31 +0000 (14:07 -0700)]
Import translations. DO NOT MERGE

Auto-generated-cl: translation import

Bug: 64712476
Change-Id: Ic7853a4d8574d496f1ee03a8163fff2671cafafd

4 years agoMerge "docs: Clarified when onRestoreInstanceState() executes" into qt-dev
Kevin Hufnagle [Tue, 6 Aug 2019 15:53:40 +0000 (15:53 +0000)]
Merge "docs: Clarified when onRestoreInstanceState() executes" into qt-dev

4 years agoMerge "Import translations. DO NOT MERGE" into qt-dev
TreeHugger Robot [Sat, 3 Aug 2019 23:17:27 +0000 (23:17 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-dev

4 years agoImport translations. DO NOT MERGE
Bill Yi [Sat, 3 Aug 2019 10:46:32 +0000 (03:46 -0700)]
Import translations. DO NOT MERGE

Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I13841d4c409aed2b5192f6d5bf132a71f76da519

4 years agodocs: Clarified when onRestoreInstanceState() executes
Kevin Hufnagle [Thu, 18 Jul 2019 21:37:36 +0000 (21:37 +0000)]
docs: Clarified when onRestoreInstanceState() executes

This method executes only after onDestroy() is called.

Change-Id: I4880cc98ea08945f30b16baa7ae400a5bbe3e439
Test: make ds-docs
Bug: 136241777

4 years agoMerge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev
Adrian Roos [Fri, 2 Aug 2019 12:17:11 +0000 (12:17 +0000)]
Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev

4 years agoAvoid using secondary displays as launch params when not support
Louis Chang [Fri, 26 Jul 2019 05:34:22 +0000 (13:34 +0800)]
Avoid using secondary displays as launch params when not support

Activities were moved on secondary displays when layouting tasks by
LaunchParamsController while the device has no multi-displays support.

Bug: 136607870
Test: atest TaskLaunchParamsModifierTests
Change-Id: If17f119008cb2fa9ab08090f128c83215f8523a0
(cherry picked from commit 740448f08a263ca6cd8605b4e83048be06610882)

4 years agoMerge "Update WebSettings.setSaveFormData deprecated doc" into qt-dev
Tao Bai [Thu, 1 Aug 2019 01:17:10 +0000 (01:17 +0000)]
Merge "Update WebSettings.setSaveFormData deprecated doc" into qt-dev

4 years agoMerge "docs: Added missing comma in RectF class description." into qt-dev
TreeHugger Robot [Thu, 1 Aug 2019 00:25:05 +0000 (00:25 +0000)]
Merge "docs: Added missing comma in RectF class description." into qt-dev

4 years agoMerge "Revert "Stop timer when notification isn't visible"" into qt-dev
Beth Thibodeau [Wed, 31 Jul 2019 20:31:53 +0000 (20:31 +0000)]
Merge "Revert "Stop timer when notification isn't visible"" into qt-dev

4 years agoRevert "Stop timer when notification isn't visible"
Beth Thibodeau [Wed, 31 Jul 2019 20:23:44 +0000 (20:23 +0000)]
Revert "Stop timer when notification isn't visible"

This reverts commit 3c4a8e48d404649bd03ee8e6e377dcf9a65afee9.

Reason for revert: NPE errors
Fixes: b/138697134

Change-Id: Ic89eb58cd68485dcc5e7c5a3ef48d7ed79c303ca

4 years agoMerge "syncInputWindows for mouse events" into qt-dev
TreeHugger Robot [Wed, 31 Jul 2019 18:14:57 +0000 (18:14 +0000)]
Merge "syncInputWindows for mouse events" into qt-dev

4 years agodocs: Added missing comma in RectF class description.
Kevin Hufnagle [Tue, 30 Jul 2019 18:57:35 +0000 (18:57 +0000)]
docs: Added missing comma in RectF class description.

Test: make ds-docs -j32

Bug: 132942874
Change-Id: I8e9d2bfa620be35ef66bd9b05c4a0b9e4727cafa

4 years agoMerge "Import translations. DO NOT MERGE" into qt-dev
TreeHugger Robot [Tue, 30 Jul 2019 18:08:35 +0000 (18:08 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-dev

4 years agoImport translations. DO NOT MERGE
Bill Yi [Tue, 30 Jul 2019 12:27:50 +0000 (05:27 -0700)]
Import translations. DO NOT MERGE

Auto-generated-cl: translation import

Bug: 64712476
Change-Id: Ibf6c04dc31f46bff1ad2077478de96bcdd2f7440

4 years agoMerge "Fixed an issue where the notification wouldn't collapse" into qt-dev
Selim Cinek [Mon, 29 Jul 2019 20:35:36 +0000 (20:35 +0000)]
Merge "Fixed an issue where the notification wouldn't collapse" into qt-dev

4 years agoMerge "Showing the notification icon properly now when the pulse is suppressed" into...
TreeHugger Robot [Mon, 29 Jul 2019 20:33:42 +0000 (20:33 +0000)]
Merge "Showing the notification icon properly now when the pulse is suppressed" into qt-dev

4 years agoMerge "Stop timer when notification isn't visible" into qt-dev
TreeHugger Robot [Mon, 29 Jul 2019 20:30:46 +0000 (20:30 +0000)]
Merge "Stop timer when notification isn't visible" into qt-dev

4 years agoMerge "Only supports ambient mode when necessary." into qt-dev
bsears [Sun, 28 Jul 2019 17:29:03 +0000 (17:29 +0000)]
Merge "Only supports ambient mode when necessary." into qt-dev

4 years ago[DO NOT MERGE] Don't drop restricted permissions on upgrade
Svet Ganov [Sat, 27 Jul 2019 00:45:56 +0000 (17:45 -0700)]
[DO NOT MERGE] Don't drop restricted permissions on upgrade

Restricted permissions cannot be held until whitelisted. In
a P -> Q upgrade we grandfather all restricted permissions.
However, the whitelisting code runs after the internal update
of permission happens for the first time resulting in a
revocation of the restricted permissions we were about to
grandfather.

The fix is to not deal with restricted permission when updating
the permissions state until the permission controller has run
the grandfathering logic and once the latter happens we do run
the permission update logic again to properly handle the
restricted permissions.

Bug: 138263882

Test: atest CtsPermissionTestCases
      atest CtsPermission2TestCases
      atest CtsAppSecurityHostTestCases:android.appsecurity.cts.PermissionsHostTest
      P -> Q upgrade preserves grandfathered restricted permissions
      P -> Bad Q build -> Q fixes up broken fixed restricted permissions

Change-Id: Iaef80426bf50181df93d1380af1d0855340def8e

4 years agoMerge "Do not allow the FalsingManager sesion to start when AOD is showing." into...
Dave Mankoff [Sat, 27 Jul 2019 11:28:16 +0000 (11:28 +0000)]
Merge "Do not allow the FalsingManager sesion to start when AOD is showing." into qt-dev

4 years agoFixed an issue where the notification wouldn't collapse
Selim Cinek [Sat, 27 Jul 2019 04:47:19 +0000 (21:47 -0700)]
Fixed an issue where the notification wouldn't collapse

When clicking on a notification with an activity that
wouldn't start an opening animation, the panel could
remain open. We're now closing it in that case.

Fixes: 138468703
Test: follow test on bug and observe normal closing
Change-Id: I0b867302d616c017d82f944ee983d4ba4356701a

4 years agoDo not allow the FalsingManager sesion to start when AOD is showing.
Dave Mankoff [Fri, 26 Jul 2019 17:50:08 +0000 (13:50 -0400)]
Do not allow the FalsingManager sesion to start when AOD is showing.

Bug: 138220274
Test: manual

Change-Id: I6d14db66d53a668b7cf8dd15ebb489fb3ebf4c7c
Merged-In: I6d14db66d53a668b7cf8dd15ebb489fb3ebf4c7c

4 years agoShowing the notification icon properly now when the pulse is suppressed
Selim Cinek [Fri, 26 Jul 2019 03:41:29 +0000 (20:41 -0700)]
Showing the notification icon properly now when the pulse is suppressed

Previously the notification would be hidden so if the user would pull
out the phone from the pocket, they might not see what notification
actually alerted.

Bug: 138336424
Test: add notification while on AOD, block prox sensor, see icon
Change-Id: I101640c9d0226948e44a4bf36a7ca91dd135fe66
Merged-In: I8f7bd7a6a0562942ed3e12f28705043722d177e8

4 years agoMerge "docs: Fixed typo in SERVICE_META_DATA" into qt-dev
Kevin Hufnagle [Fri, 26 Jul 2019 23:20:51 +0000 (23:20 +0000)]
Merge "docs: Fixed typo in SERVICE_META_DATA" into qt-dev

4 years agoMerge "Revert "SharedMemory: break Cleaner reference cycle." Bug: 138422309" into...
bsears [Fri, 26 Jul 2019 23:03:15 +0000 (23:03 +0000)]
Merge "Revert "SharedMemory: break Cleaner reference cycle." Bug: 138422309" into qt-dev

4 years agoMerge "Revert "SharedMemory: clear file descriptor when explicitly closed." Bug:...
bsears [Fri, 26 Jul 2019 23:03:06 +0000 (23:03 +0000)]
Merge "Revert "SharedMemory: clear file descriptor when explicitly closed." Bug: 138422309" into qt-dev

4 years agoRevert "SharedMemory: break Cleaner reference cycle."
Adam Seaton [Fri, 26 Jul 2019 17:13:18 +0000 (17:13 +0000)]
Revert "SharedMemory: break Cleaner reference cycle."
Bug: 138422309

This reverts commit 390d9e6a1806626eb521d55a36b1578d28714cc8.

Reason for revert: crashes documented in b/138422309

Change-Id: I235f727d0fe87c09f6f05dddcae7759bab64dfd8

4 years agoRevert "SharedMemory: clear file descriptor when explicitly closed."
Adam Seaton [Fri, 26 Jul 2019 17:14:01 +0000 (17:14 +0000)]
Revert "SharedMemory: clear file descriptor when explicitly closed."
Bug: 138422309

This reverts commit 20ab1e34273aa179053f5dc93e70c0191a39e91b.

Reason for revert: crashes documented in b/138422309

Change-Id: Ic9e33fdb24bad2b30f0eb357d6752c1834df41d5

4 years agoStop timer when notification isn't visible
Beth Thibodeau [Thu, 25 Jul 2019 20:42:51 +0000 (16:42 -0400)]
Stop timer when notification isn't visible

Fixes: 138261464
Test: manual, atest com.android.systemui.statusbar.notification.row.wrapper.NotificationMediaTemplateViewWrapperTest
Change-Id: Id7b1b586f3ab258fad8670070240ef951080c969

4 years agoGestureNav: Clarify javadoc in regards to exclusion limits
Adrian Roos [Thu, 25 Jul 2019 18:29:07 +0000 (20:29 +0200)]
GestureNav: Clarify javadoc in regards to exclusion limits

Bug: 124518180
Test: m checkapi
Change-Id: I43b0b890a763e339deb246cabf9adbf011eae088

4 years agoOnly supports ambient mode when necessary.
Ahan Wu [Tue, 23 Jul 2019 12:41:52 +0000 (20:41 +0800)]
Only supports ambient mode when necessary.

We only need support ambient mode on specified devices but we currently
enable this attribute on all devices, that means we need redraw every
time when ambient mode changes. However, we can just show / hide
wallpaper window on the devices which not support ambient transition.

In addition, always use portrait dimension as scissor area since we only
do transition in portrait.

Bug: 138021396
Bug: 137962047
Test: Manually test on F2, C1, B4, S4 and walleye.
Test: Set an image wallpaper, switch between home, aod and lockscreen.
Test: Also use finger print to unlock from aod to home directly.
Test: Rotate to landscape, set a new image wallpaper.
Test: Switch between home, aod and lockscreen.
Change-Id: I36dd49363e81df5a260b10695d90aa9d8c70a45a

4 years agoMerge changes I8bdb4c74,I613a7d03 into qt-dev
TreeHugger Robot [Thu, 25 Jul 2019 23:41:51 +0000 (23:41 +0000)]
Merge changes I8bdb4c74,I613a7d03 into qt-dev

* changes:
  SharedMemory: clear file descriptor when explicitly closed.
  SharedMemory: break Cleaner reference cycle.

4 years agoMerge changes from topic "chromehole" into qt-dev
Jorim Jaggi [Thu, 25 Jul 2019 23:07:16 +0000 (23:07 +0000)]
Merge changes from topic "chromehole" into qt-dev

* changes:
  Only consider gone for layout if parent is gone for layout
  Reland "Prevent dismissing starting window when reopening app"

4 years agoSharedMemory: clear file descriptor when explicitly closed.
Josh Gao [Thu, 25 Jul 2019 20:54:23 +0000 (13:54 -0700)]
SharedMemory: clear file descriptor when explicitly closed.

We run the Cleaner in close, but after the fix in commit 6ca916a6, this
no longer clears the value stored in the FileDescriptor, which means
that subsequent operations on an explicitly closed SharedMemory will
operate on a bogus fd number. Clearing the FileDescriptor value in close
is sufficient, because Cleaner.clean is idempotent, and the only other
case where it executes is when the FileDescriptor is phantom reachable,
which means no one can access it to get its integer value.

Bug: http://b/138392115
Bug: http://b/138323667
Test: treehugger
Change-Id: I8bdb4c745466532a0712976416184c53fcf0dbf6
(cherry picked from commit a7641806ddf1099239632d53c629c062ff2168f4)

4 years agosyncInputWindows for mouse events
Siarhei Vishniakou [Thu, 25 Jul 2019 16:59:17 +0000 (09:59 -0700)]
syncInputWindows for mouse events

Add back the syncInputWindows calls for mouse events, because there are
tests that rely on this behaviour (they might inject only a few events,
which is not very realistic, but we still have to support this).

Bug: 137072767
Bug: 138263890
Test: atest android.view.cts.HoverTest
Change-Id: I37b621bc6dc6a844ca86324962124bb06857b906

4 years agoSharedMemory: break Cleaner reference cycle.
Josh Gao [Wed, 24 Jul 2019 22:40:57 +0000 (15:40 -0700)]
SharedMemory: break Cleaner reference cycle.

Previously, the Cleaner we create to close the ashmem file descriptor
used a thunk that held a strong reference to the FileDescriptor we
wanted to clean up, which prevented the Cleaner from ever running.

Break the cycle by storing the integer value of the file descriptor
instead.

Bug: http://b/138323667
Test: treehugger
Change-Id: I613a7d035892032f9567d59acb04672957c96011
(cherry picked from commit 6ca916a657cd56158212a57601108716ce78cbe8)

4 years agoOnly consider gone for layout if parent is gone for layout
Jorim Jaggi [Tue, 16 Jul 2019 15:43:15 +0000 (17:43 +0200)]
Only consider gone for layout if parent is gone for layout

If we check getParentWindowHidden, that determines mostly actual
visibility. However, we don't want that because we still would
like to follow the parent's window layout lifecycle, as otherwise
we may be stuck in a transition in case the parent window is
hidden but the child is waiting for a layout to happen.

Test: Click "Customize" on wallpaper picker, go back, ensure no
transition timeout
Fixes: 135976008

Change-Id: I66aeab29a81cd82b170aaf337249616b1f559848
(cherry picked from commit b52b0457e1bad14697341cb81f6d391755b009be)

4 years agoMerge "Only update overlays for target" into qt-dev
TreeHugger Robot [Thu, 25 Jul 2019 01:15:26 +0000 (01:15 +0000)]
Merge "Only update overlays for target" into qt-dev

4 years agoMerge "Prevent the BrightLineFalsingManager from duping its session." into qt-dev
TreeHugger Robot [Thu, 25 Jul 2019 00:47:21 +0000 (00:47 +0000)]
Merge "Prevent the BrightLineFalsingManager from duping its session." into qt-dev

4 years agoMerge "Fix issue with media notifs being misbucketed" into qt-dev
Ned Burns [Thu, 25 Jul 2019 00:34:18 +0000 (00:34 +0000)]
Merge "Fix issue with media notifs being misbucketed" into qt-dev

4 years agoMerge "DO NOT MERGE Do not call drawableChanged pre Q" into qt-dev
Jorim Jaggi [Wed, 24 Jul 2019 22:49:21 +0000 (22:49 +0000)]
Merge "DO NOT MERGE Do not call drawableChanged pre Q" into qt-dev

4 years agoPrevent the BrightLineFalsingManager from duping its session.
Dave Mankoff [Wed, 24 Jul 2019 22:06:44 +0000 (18:06 -0400)]
Prevent the BrightLineFalsingManager from duping its session.

The BrightLineFalsingManager should not be able to start a session
when it's already in a session. Primarily, this caused the
FalsingManager to hang onto extra registrations to the Proximity
Sensor, per the bug.

Bug: 138220274
Test: atest SystemUITests and manual.
Change-Id: Id10d2697a96524e98c87aaa87702209d1752fe68

4 years agoDO NOT MERGE Do not call drawableChanged pre Q
Vadim Caen [Wed, 24 Jul 2019 14:24:33 +0000 (16:24 +0200)]
DO NOT MERGE Do not call drawableChanged pre Q

Some apps rely on not updating the window format when changing the
background of the DecorView. To keep the compatibilty with these app we
add only call DecoreView.drawableChanged() when the window background is
changed on app targetting Q and above.

Test: Manually test by lunching Instagram TV and pressing return twice.
The window should aninate with no flickering.
Bug: 136987724

Change-Id: I3593d30dc6f10519008151974e475f0dad86fc64

4 years agoFix issue with media notifs being misbucketed
Ned Burns [Fri, 19 Jul 2019 18:26:15 +0000 (14:26 -0400)]
Fix issue with media notifs being misbucketed

Previous code assumed that "isHighPriority" == "is in top section",
which is not always true. Media notifs and some other notifs can appear
in the top section even if they're not high priority. Because we detect
section boundaries by iterating through the list until we find the first
notif where isHighPriority == false, we were sometimes drawing the
section boundary way too high. This change creates a new propery,
isInTopSection() that accurately tracks this state.

Setting this value in the proper location would require some seriously
destabilizing refactors, so instead we set it in the list comparator,
which is awful but here are.

Test: manual
Bug: 138320173
Change-Id: I19223720bac534ab92219a2962169097819e8efb
Merged-In: I19223720bac534ab92219a2962169097819e8efb
(cherry picked from commit 8c1b763dcf5df6e7fc7177dad5e7390adb229fa4)

4 years agoOnly update overlays for target
Ryan Mitchell [Tue, 23 Jul 2019 17:01:06 +0000 (10:01 -0700)]
Only update overlays for target

When a target package would update, the OMS would update the stat of
overlays that target android as if the android overlays targeted the
target package. This would cause the overlay state to change to
STATE_MISSING_TARGET for android overlays.

This change will only update state for overlays that target the updated
package.

Bug: 137038000
Bug: 136549878
Test: manual debugging
Change-Id: I0430426d8e8588a0fb97096a1f2570a7930069b3
Merged-In: I0d545253179b3545307b88b3151d11fd9e6cbd5b

4 years agoMerge "Allow BrightLineFalsingManager settings to be experimented with via Phenotype...
Dave Mankoff [Wed, 24 Jul 2019 19:09:02 +0000 (19:09 +0000)]
Merge "Allow BrightLineFalsingManager settings to be experimented with via Phenotype." into qt-dev

4 years agoAllow BrightLineFalsingManager settings to be experimented with via Phenotype.
Dave Mankoff [Thu, 18 Jul 2019 21:20:11 +0000 (17:20 -0400)]
Allow BrightLineFalsingManager settings to be experimented with via Phenotype.

This is a CP of http://ag/8687829

Bug: 138308096
Test: atest SystemUITests
Change-Id: I9e2b22b157c45da1606466acdfff3c5de7f182e1
Merged-In: I9fa4d1344bb184dea00f92f8d265667f0be11466

4 years agoMerge "Don't animate clock when turning screen off." into qt-dev
bsears [Wed, 24 Jul 2019 01:22:21 +0000 (01:22 +0000)]
Merge "Don't animate clock when turning screen off." into qt-dev

4 years agoMerge "Mark screen rotation as early (1/2)" into qt-dev
TreeHugger Robot [Wed, 24 Jul 2019 01:05:37 +0000 (01:05 +0000)]
Merge "Mark screen rotation as early (1/2)" into qt-dev

4 years agoMark screen rotation as early (1/2)
Jorim Jaggi [Mon, 22 Jul 2019 15:17:42 +0000 (17:17 +0200)]
Mark screen rotation as early (1/2)

To decrease jank while rotating.

Test: Rotate screen
Bug: 138083790
Change-Id: If0b4428253dbfa4dcb102b8146a847e2e9ab876b
Merged-In: If0b4428253dbfa4dcb102b8146a847e2e9ab876b

4 years agoDon't animate clock when turning screen off.
Robert Snoeberger [Fri, 19 Jul 2019 20:35:35 +0000 (16:35 -0400)]
Don't animate clock when turning screen off.

This change stops the animation because there isn't a
transition from the no-header state to the music header
state when turning the screen off (to AOD). Since there
isn't a transition, there isn't an animation.

This assumes that there isn't a transition from unlocked to
lock screen. If there is, then there would be an animation
of the music going away while arriving at the lock screen.

Fixes: 137383007
Test: Checked repro steps in bug, clock doesn't animate.
Test: Also checked repro steps when audio is paused, clock doesn't
animate.
Test: atest KeyguardSliceProviderTest.java

Change-Id: If39777340b72bc623d6690bc4f784c7f5c26ea8d
Merged-In: If39777340b72bc623d6690bc4f784c7f5c26ea8d

4 years agoMerge "Fix permission javadoc about whitelisting." into qt-dev
TreeHugger Robot [Tue, 23 Jul 2019 17:16:14 +0000 (17:16 +0000)]
Merge "Fix permission javadoc about whitelisting." into qt-dev

4 years agoMerge "Add cleanup method to FalsingManager to prevent memory leaks." into qt-dev
Dave Mankoff [Tue, 23 Jul 2019 17:10:26 +0000 (17:10 +0000)]
Merge "Add cleanup method to FalsingManager to prevent memory leaks." into qt-dev

4 years agoMerge "Fixed a bug with the animation of the notification background" into qt-dev
TreeHugger Robot [Tue, 23 Jul 2019 00:57:58 +0000 (00:57 +0000)]
Merge "Fixed a bug with the animation of the notification background" into qt-dev