OSDN Git Service
Griff Hazen [Mon, 19 Dec 2016 18:15:53 +0000 (18:15 +0000)]
Revert "Prune uses library classes even without profile DO NOT MERGE"
This fix may be causing other crashes e.g. b/
33718412.
Bug:
33718412
Bug:
30688277
Bug:
31427727
This reverts commit
8394cee5f0f87ddeeb8f33c199fa21e0cdee9073.
Change-Id: Ie19ece9d8ae1afef8b578482fae1cdbd35ff930d
Mathieu Chartier [Fri, 5 Aug 2016 23:09:09 +0000 (16:09 -0700)]
Prune uses library classes even without profile DO NOT MERGE
The previous pruning relied on the classes being pruned from the
profile, and then using the profile to prune classes. If there was
no profile, the uses library classes were incorrectly left unpruned.
Leaving these classes unpruned caused aborts during compilation.
Cherry picked from https://android-review.googlesource.com/#/c/312750/
Bug:
30688277
Bug:
31427727
Test: adb shell dex2oat --runtime-arg -classpath --runtime-arg /system/framework/com.google.android.maps.jar --dex-file=/data/app/comb.BBClient-1/base.apk --dex-location=/data/app/comb.BBClient-1/base.apk --oat-file=/data/app/comb.BBClient-1/oat/arm/base.odex --app-image-file=/data/app/comb.BBClient-1/oat/arm/base.art --image-format=lz4 --compiler-filter=speed
Change-Id: I261b8894847b5b0a4f7330f49666e823a1b38bb0
Brian Carlstrom [Mon, 17 Oct 2016 15:27:26 +0000 (15:27 +0000)]
Ensure OpenDexFilesFromImage closes file to prevent file descriptor leak
am:
645e477c2c
Change-Id: I071d7c8a53641981673387295c51757e5e18e635
Brian Carlstrom [Fri, 14 Oct 2016 08:04:26 +0000 (01:04 -0700)]
Ensure OpenDexFilesFromImage closes file to prevent file descriptor leak
Test: m -j32 test-art-host
Bug:
32095919
Change-Id: I44541edeb403a508e1b9794ee09fb1f55e3f42bf
Andreas Gampe [Wed, 5 Oct 2016 02:31:13 +0000 (02:31 +0000)]
ART: Reprint long messages on abort
am:
47d522b27f
Change-Id: I0b82fa7b714688b9971eae9c7711821a2c0b32b2
Andreas Gampe [Wed, 5 Oct 2016 02:31:06 +0000 (02:31 +0000)]
ART: Clean up IRT-related abort messaging
am:
15b7c90ab8
Change-Id: I9a5f61d7d6952f88ea457e15365e19cc13071844
Andreas Gampe [Tue, 4 Oct 2016 02:47:08 +0000 (19:47 -0700)]
ART: Reprint long messages on abort
Add an abort message parameter to Runtime::Abort. In case the message
is multiline (and will thus not be completely preserved in the
Android abort reason), reprint the message after all threads have
been dumped.
Bug:
31893081
Test: m test-art-host
Change-Id: I65bc77691fec79f7c868a90d6132805fcc91e473
(cherry picked from commit
90a32b16feb58d4edf932fdcb6a070be3418e365)
Andreas Gampe [Mon, 3 Oct 2016 18:42:31 +0000 (11:42 -0700)]
ART: Clean up IRT-related abort messaging
Change AbortIfNoCheckJNI to take the abort message as a parameter.
This way it can be passed down.
Bug:
31893081
Test: m test-art-host
Change-Id: Ib24c7060f1b32c9613ab84e6c1966082c866bc14
(cherry picked from commit
f1e8630fe8eab89e61e9f0a97135ae7c9d38ce23)
Alex Light [Wed, 28 Sep 2016 22:09:05 +0000 (22:09 +0000)]
DO NOT MERGE: Update Oat version to 088
am:
ae444410cc
Change-Id: I44f82f443b449733dadbc1e262aac83a782c76a5
Alex Light [Wed, 28 Sep 2016 18:27:11 +0000 (11:27 -0700)]
DO NOT MERGE: Update Oat version to 088
Give N-MR1 a different oat version to prevent compatibility problems
with NYC.
Bug:
31789675
Test: mma test-art-host
Test: Phone boots and runs apps
Change-Id: I6a922e8ac932dbf36a19431c4f34c2ace6f34609
Andreas Gampe [Wed, 28 Sep 2016 06:46:04 +0000 (06:46 +0000)]
ART: Dump referenced type in IRT overflows
am:
280f32b095
Change-Id: I6dedb3915fd67c08e45218892a7c909d397d9733
Andreas Gampe [Wed, 28 Sep 2016 01:45:02 +0000 (18:45 -0700)]
ART: Dump referenced type in IRT overflows
When the runtime dumps a reference table, e.g., when aborting for
an overflow, dump the type of stored referents for reference types
to aid in debugging leaks.
Bug:
31600693
Change-Id: Ia892dc84ca8827dd93a8b75d6f571c392f94859c
Alex Light [Mon, 26 Sep 2016 17:57:40 +0000 (17:57 +0000)]
Make test for app-image loading.
am:
d3997bd98a
Change-Id: I19963f3dca87677b02e52dcc403c6c66b33f352c
Alex Light [Tue, 3 May 2016 22:01:06 +0000 (15:01 -0700)]
Make test for app-image loading.
Bug:
26882072
(cherry picked from commit
2e960a075cd30a1fdfc31597c4a64f1fca026efd)
Test: test/run-test --host --no-relocate 596-app-images
Change-Id: I40a45e7944aec3a5ee28ef3d47e9881f61a7c9e6
Mathieu Chartier [Fri, 23 Sep 2016 21:51:44 +0000 (21:51 +0000)]
Smarter image layout
am:
4e9c4e7466
Change-Id: Iba240ee3bbb768f258ab7bc3aa22325fd4d7992a
Mathieu Chartier [Tue, 20 Sep 2016 22:33:31 +0000 (15:33 -0700)]
Smarter image layout
Put strings in the dex file that resolves them.
Depth first traversal with overrides for class and dex cache. The
work list keeps track of what oat_index with each pushed item. This
means the static fields of a class will usually be in the same image.
Added layout test to image_test to make sure things are somewhat
reasonably attributed.
Bug:
28640955
Test: test-art-host
Change-Id: I67a536c33aeed603b252d8e0f75622c9efbf2559
Mathieu Chartier [Thu, 22 Sep 2016 02:48:10 +0000 (02:48 +0000)]
Merge "Make image test multi image" into nyc-mr1-dev
am:
41be588f4f
Change-Id: I427a63c24354ca8f6f8df788881730b95128e16b
Mathieu Chartier [Thu, 22 Sep 2016 02:48:09 +0000 (02:48 +0000)]
Make image test multi image
am:
25adcfb7dc
Change-Id: Iea181f7ef946b7a063d3424845774517011fc706
TreeHugger Robot [Thu, 22 Sep 2016 02:00:45 +0000 (02:00 +0000)]
Merge "Make image test multi image" into nyc-mr1-dev
Mathieu Chartier [Wed, 21 Sep 2016 22:24:18 +0000 (15:24 -0700)]
Make image test multi image
Required for testing multi image layout in future CLs.
Bug:
28640955
Test: clean-oat-hos, test-art-host, device booting
Change-Id: I14809f56e711b4a87e01056c327eddbbd087f4ee
Jeff Hao [Tue, 20 Sep 2016 18:12:03 +0000 (18:12 +0000)]
Ensure class is initialized when reading its fields from debugger.
am:
894f3fd2bb
Change-Id: Iadd8832ab37487dd838c164c066637972c549c17
Jeff Hao [Wed, 14 Sep 2016 22:56:35 +0000 (15:56 -0700)]
Ensure class is initialized when reading its fields from debugger.
Bug:
31016523
Test: mm run-jdwp-tests-ri & mm run-jdwp-tests-host
(cherry-picked from commit
de19a25625823496bcf8f92352f709c7a3924bfa)
Change-Id: I02f6c66116f4507c89f7ca1cb480d7029d97c485
Alex Light [Fri, 9 Sep 2016 21:56:37 +0000 (21:56 +0000)]
Merge "Fix vtable corruption issue" into nyc-mr1-dev
am:
949ce9c1da
Change-Id: Ic5fc1c6cd47d3620676a5fb4357f09f4727087b9
Alex Light [Fri, 9 Sep 2016 21:56:37 +0000 (21:56 +0000)]
Fix vtable corruption issue
am:
b47a1cc17f
Change-Id: I0f94ef0789b8a15525e38765e45c4a3383af643e
TreeHugger Robot [Fri, 9 Sep 2016 21:51:51 +0000 (21:51 +0000)]
Merge "Fix vtable corruption issue" into nyc-mr1-dev
Mathieu Chartier [Fri, 9 Sep 2016 20:20:59 +0000 (20:20 +0000)]
Don't assume resolved classses are filled in for ResolvedFieldAccessTest
am:
c90450a201
Change-Id: Iacd940d12b4d9a54cd2f7ac21063f6178cf35031
Alex Light [Wed, 7 Sep 2016 19:04:20 +0000 (12:04 -0700)]
Fix vtable corruption issue
We were adding duplicate methods to the vtable in some cases where
default methods (and conflict methods) were used. This caused issues
where they were not correctly overridden in subclasses that implement
these methods directly. When overridden only one of the vtable entries
was updated meaning it was still possible to reach the overridden code
using a virtual call.
This change prevents the duplicate methods from being added to the
vtable in this circumstance. It also adds a debug check that ensures
that the vtable has no duplicates to prevent regressions.
Bug:
31280371
Test: mma test-art-host
Test: mma test-art-host-run-test-960-default-smali
Change-Id: I17d88fb8949c8d5d75b4de3c734fd98660b81e61
(cherry picked from commit
1f3925d4f067438d3689ef2736fd2af063c98668)
Mathieu Chartier [Fri, 9 Sep 2016 00:34:25 +0000 (17:34 -0700)]
Don't assume resolved classses are filled in for ResolvedFieldAccessTest
The assumption that the dex cache type for class of the field is
resolved is not correct since FindClass does not fill in the
resolved type array. This resulted in crashes if dex_access_to ==
nullptr.
Also implemented for ResolvedMethodAccessTest
Bug:
31277064
Test: Launch ZeroTouch with profile guided compilation.
Change-Id: I40cfb15f3ae4fbfe941fd01ea46211bd86b6e6f7
David Sehr [Wed, 31 Aug 2016 20:15:46 +0000 (20:15 +0000)]
Save environment snapshot and use at fork/exec
am:
0e4a2f0d6b
Change-Id: I0f0ab67798266911cd8209dfdd9cde0cf371c815
David Sehr [Wed, 17 Aug 2016 02:22:57 +0000 (19:22 -0700)]
Save environment snapshot and use at fork/exec
Some applications may inadvertently or maliciously set of environment
variables such as LD_LIBRARY_PATH before spawning subprocesses.
To make this more difficult, save the environment at the time the
runtime starts and use the saved copy anytime Exec is called.
BUG:
30160149
TEST: make test-art-{host,target}
Change-Id: I887b78bdb21ab20855636a96da14a74c767bbfef
(cherry picked from commit
d106d9f871c957286ccdeb79c1c2a5ed41f859a6)
Nicolas Geoffray [Mon, 29 Aug 2016 23:25:25 +0000 (23:25 +0000)]
Pass the right class loader when inlining. am:
c770fe0480 am:
5b5ee2a89f
am:
91373ca410
Change-Id: I3d75cc076f4d7eb9db65ed686a8e27f6e93afa76
Nicolas Geoffray [Mon, 29 Aug 2016 22:50:54 +0000 (22:50 +0000)]
Pass the right class loader when inlining. am:
c770fe0480
am:
5b5ee2a89f
Change-Id: I47bfba0654850a6e15ef0337556ed6a12e02fb90
Nicolas Geoffray [Mon, 29 Aug 2016 22:47:31 +0000 (22:47 +0000)]
Pass the right class loader when inlining.
am:
c770fe0480
Change-Id: If6f2946d649addef8381079eb0132d35ee1fd62f
Nicolas Geoffray [Thu, 28 Jul 2016 02:49:14 +0000 (03:49 +0100)]
Pass the right class loader when inlining.
Otherwise, method and type resolution can resolve to the wrong
things and as a side effect update the dex cache with wrong data.
bug:
30403437
Change-Id: I23f94486f51c65e0a1328c6185b36084627e09b3
test:./art/test/run-test --host --jit --dev --no-prebuild 613
(cherry picked from commit
0a210d9b108c87c0e7c1d430a92ce6fc89790c95)
Christopher Ferris [Fri, 26 Aug 2016 18:00:45 +0000 (18:00 +0000)]
Add lock when iterating over BacktraceMap.
am:
250a966717
Change-Id: I220924343cbf4a510473fba8d896b438307dc567
Christopher Ferris [Fri, 17 Jun 2016 06:19:36 +0000 (23:19 -0700)]
Add lock when iterating over BacktraceMap.
In order to avoid a race condition in the maps data, acquire
a read lock while iterating over the maps data.
Bug:
29387050
Bug:
31067025
(cherry picked from commit
56f8b5631ab2874dc2ec385802e38555acac0d90)
Change-Id: I48ecd2705b4aa4eedfed1daae2eb3b9b8bf8dda9
Mathieu Chartier [Thu, 25 Aug 2016 20:34:45 +0000 (20:34 +0000)]
Card mark holding class instead of declaring class
am:
db16f2a0a7
Change-Id: Ifa6f51e997bc1283cc892d3b00ed8c8b2f187307
Mathieu Chartier [Fri, 5 Aug 2016 17:46:36 +0000 (10:46 -0700)]
Card mark holding class instead of declaring class
For profiling info, we need to mark the card of the holding class
instead of declaring class. This is required for GC correctness since
the GC relies on the card table to track cross space references.
Test: test-art-host ART_TEST_JIT=true
Bug:
30655270
(cherry picked from commit
65975776f807d55c83af6cca1e447f8daa794413)
Change-Id: I3de518693d3cac1ad9770eae671db740ebdf1d8d
Mathieu Chartier [Wed, 24 Aug 2016 16:36:42 +0000 (16:36 +0000)]
Revert "Revert "Use try lock to fix class resolution race""
am:
23da026ec7
Change-Id: Icc27f56679886cddbacdd2fcb198bdeeafdd1904
Mathieu Chartier [Wed, 24 Aug 2016 16:36:37 +0000 (16:36 +0000)]
Revert "Use try lock to fix class resolution race"
am:
adc538a57a
Change-Id: I5dc4f5291800c124beed080e46bfee437b40669b
Mathieu Chartier [Wed, 24 Aug 2016 16:36:32 +0000 (16:36 +0000)]
Use try lock to fix class resolution race
am:
1386f8619b
Change-Id: Ic196684640f2bad1b24837bdefd902305b4eb785
Mathieu Chartier [Fri, 29 Jul 2016 23:26:01 +0000 (16:26 -0700)]
Revert "Revert "Use try lock to fix class resolution race""
Fix possible deadlock in EnsureResolved caused by interaction with
GC. Since we were sleeping while holding the mutator lock, it could
block thread suspension. This would deadlock if the thread that
had locked h_class is already suspended since we would spin forever
and not make progress.
Bug:
27417671
Bug:
30500547
Test: test-art-host ART_TEST_GC_STRESS=true
This reverts commit
69bf969c055c31a75d17ea92aeee756042678114.
(cherry picked from commit
4b0ef1c980a1f3b0201d77e33bdb2f7df12c9114)
Change-Id: If5766c2c3c8a130cbb83735cdb9970038570dafd
Mathieu Chartier [Fri, 29 Jul 2016 20:06:45 +0000 (20:06 +0000)]
Revert "Use try lock to fix class resolution race"
This reverts commit
a704eda0078989a73cac111ed309aca50d2e289b.
Bug:
27417671
Bug:
30500547
(cherry picked from commit
69bf969c055c31a75d17ea92aeee756042678114)
Change-Id: I4354d1c9f1c554f054e99efd7aa52d8a2c5d402c
Mathieu Chartier [Wed, 13 Jul 2016 16:53:35 +0000 (09:53 -0700)]
Use try lock to fix class resolution race
There was some possible deadlocks related to EnsureResolved caused by
acquiring an object lock.
Scenario:
Thread 1 acquires lock on obj1
Thread 1 begins to resolve / initialize class1
Thread 1 blocks since it sees that class1 is already being resolved and
gets preempted before it can acquire the object lock on class1
Thread 2 finishes resolving and initializing class1 and locks class1
Thread 2 blocks attempting to lock obj1
Thread 1 blocks attempting to lock class1
Deadlock
Fixed the deadlock by changing EnsureResolved to use a try lock for the
unresolved case.
Added a test.
Test: Device boot, test-art-host, monitor_test
Bug:
27417671
(cherry picked from commit
a704eda0078989a73cac111ed309aca50d2e289b)
Change-Id: I1150b19bdc1a5cc87ae95eda4f2b6b4bca215a60
David Sehr [Tue, 23 Aug 2016 17:10:20 +0000 (17:10 +0000)]
Merge "Revert "Save environment snapshot and use at fork/exec"" into nyc-mr1-dev
am:
7ae0862d40
Change-Id: I8cb8282d61aea83ec09bbcd68e9bdb329a02db51
David Sehr [Tue, 23 Aug 2016 17:10:20 +0000 (17:10 +0000)]
Revert "Save environment snapshot and use at fork/exec"
am:
47393386aa
Change-Id: Id9ef46ef85495132dd9b9d3e8471fe94cd06d75c
David Sehr [Tue, 23 Aug 2016 16:44:25 +0000 (16:44 +0000)]
Merge "Revert "Save environment snapshot and use at fork/exec"" into nyc-mr1-dev
David Sehr [Tue, 23 Aug 2016 15:59:24 +0000 (15:59 +0000)]
Revert "Save environment snapshot and use at fork/exec"
This reverts commit
1488ff8aa3b041734ef0fbd113df512a2376e44e.
Change-Id: I3c237c94ffa865378f8efd9aa2b0fb2ad33867c2
David Sehr [Mon, 22 Aug 2016 23:37:09 +0000 (23:37 +0000)]
Merge "Save environment snapshot and use at fork/exec" into nyc-mr1-dev
am:
19d9b1e227
Change-Id: Iad472ba0d242bfad43211692d1c28b4f43f00600
David Sehr [Mon, 22 Aug 2016 23:37:09 +0000 (23:37 +0000)]
Save environment snapshot and use at fork/exec
am:
1488ff8aa3
Change-Id: I904562490ccc66831a4513864719019bd4b761ad
David Sehr [Mon, 22 Aug 2016 23:07:35 +0000 (23:07 +0000)]
Merge "Save environment snapshot and use at fork/exec" into nyc-mr1-dev
Jeff Hao [Mon, 22 Aug 2016 20:35:56 +0000 (20:35 +0000)]
Fix debugger calling new String().
am:
95ca9d2099
Change-Id: Ia5b2477311036d4d55fb84f4895ba6167fea3d13
Jeff Hao [Sat, 20 Aug 2016 01:31:39 +0000 (18:31 -0700)]
Fix debugger calling new String().
Used to return an empty string instead of the newly created String.
Requires accompanying jdwp test fix to test String contents.
Bug:
30951794
Test: mm -j24 run-jdwp-tests-host
Merges two cherry-picks:
f15ec05896ddc5fec1f224ef97bdfebb72b5a855
9e0878494cdacd0877a1614041efc38ebb053017
Change-Id: Idc4725b82798a9b6d636c72e76715bc97ad30d23
David Sehr [Wed, 17 Aug 2016 02:22:57 +0000 (19:22 -0700)]
Save environment snapshot and use at fork/exec
Some applications may inadvertently or maliciously set of environment
variables such as LD_LIBRARY_PATH before spawning subprocesses.
To make this more difficult, save the environment at the time the
runtime starts and use the saved copy anytime Exec is called.
BUG=b/
30160149
TEST=make test-art-{host,target}-gtest-utils_test
Change-Id: Ice0097bf0de30db3d4ead124caf93316f39e3df3
Mathieu Chartier [Thu, 11 Aug 2016 18:03:33 +0000 (18:03 +0000)]
Merge "Fix pending exception failure for encoded statics" into nyc-mr1-dev
am:
b6f58cbfad
Change-Id: I69786ff4810ccf8b625832382d9f752b5811ba99
Mathieu Chartier [Thu, 11 Aug 2016 18:03:33 +0000 (18:03 +0000)]
Fix pending exception failure for encoded statics
am:
5464c73567
Change-Id: Id83316ec538a13bd70e77b669c60ba37ee76d4ea
Mathieu Chartier [Thu, 11 Aug 2016 17:56:04 +0000 (17:56 +0000)]
Merge "Fix pending exception failure for encoded statics" into nyc-mr1-dev
Andreas Gampe [Thu, 11 Aug 2016 02:09:09 +0000 (02:09 +0000)]
Merge "ART: Check for more low-space situations in zygote" into nyc-mr1-dev
am:
546ca1b013
Change-Id: I9a6e6f16636c369eb03e407a47e083183c465732
Andreas Gampe [Thu, 11 Aug 2016 02:09:09 +0000 (02:09 +0000)]
ART: Check for more low-space situations in zygote
am:
f242f66cf7
Change-Id: I8043e4a91d7aebe9a7c9fbd90cb0382eb8fa6789
TreeHugger Robot [Thu, 11 Aug 2016 02:01:53 +0000 (02:01 +0000)]
Merge "ART: Check for more low-space situations in zygote" into nyc-mr1-dev
Mathieu Chartier [Wed, 10 Aug 2016 20:57:39 +0000 (13:57 -0700)]
Fix pending exception failure for encoded statics
ReadValueToField may allocate a string and cause OOME, we were
not checking this each loop iteration. Throwing an exception
with a pending exception causes an abort.
Bug:
30690988
Test: test-art-host
(cherry picked from commit
da595bec0f9af0b087822e4febc282fe8ec28192)
Change-Id: I4701a4dcc63553aeb5c7970f99fd7f136443b266
Andreas Gampe [Wed, 10 Aug 2016 03:19:18 +0000 (20:19 -0700)]
ART: Check for more low-space situations in zygote
Even if a boot image exists and can be loaded, the rest of the
platform may not be able to boot. We previously only checked
after full image generation and missed this case.
Also prune the cache if there wasn't even space to put the boot
marker.
Bug:
30765660
Change-Id: Icd43746e681c62ce2e4e8745fb17bda65ca60372
Nicolas Geoffray [Wed, 10 Aug 2016 10:43:16 +0000 (10:43 +0000)]
Put the deletion of profiling info under a GC critical section.
am:
99c959f386
Change-Id: I8302de355f210b78573d2a4b14a7bc1c53c2af7f
Nicolas Geoffray [Sat, 30 Jul 2016 21:49:11 +0000 (22:49 +0100)]
Put the deletion of profiling info under a GC critical section.
Otherwise the GC could see dangling pointers.
bug:
30033802
(cherry picked from commit
cf48fa030780c3185f225d558b704c396f7713cc)
Change-Id: I2c43e973878f50dc147aa0af81551ecc942a790d
Jeff Hao [Mon, 1 Aug 2016 23:38:02 +0000 (23:38 +0000)]
Fix profiling output to properly display class info.
am:
6b9c54c8ae
Change-Id: I789734e0aaa3d217b4221cab79e5a268c9c21675
Jeff Hao [Wed, 27 Jul 2016 17:35:03 +0000 (10:35 -0700)]
Fix profiling output to properly display class info.
The profiler stores class def indexes, not type ids.
Bug:
30436198
(cherry-picked from commit
58d40f3a7245e65d57a5daf6bf27c3b209260044)
Change-Id: I63524957547c5e0dbaf1d752220de8d05473638f
Nicolas Geoffray [Thu, 28 Jul 2016 04:26:16 +0000 (04:26 +0000)]
Pass the right class loader when inlining.
am:
0a210d9b10
Change-Id: I21bb2189eb9220bab756a58408fc7099ff710996
Nicolas Geoffray [Thu, 28 Jul 2016 02:49:14 +0000 (03:49 +0100)]
Pass the right class loader when inlining.
Otherwise, method and type resolution can resolve to the wrong
things and as a side effect update the dex cache with wrong data.
bug:
30403437
Change-Id: I23f94486f51c65e0a1328c6185b36084627e09b3
test:./art/test/run-test --host --jit --dev --no-prebuild 613
Nicolas Geoffray [Thu, 21 Jul 2016 23:32:11 +0000 (23:32 +0000)]
JIT: Don\'t update the dex cache of another class loader.
am:
e50a7b834b
Change-Id: Ib2019ac3afafebaa01c8b74f7e8e1744c85f367d
Nicolas Geoffray [Tue, 19 Jul 2016 16:06:23 +0000 (17:06 +0100)]
JIT: Don't update the dex cache of another class loader.
This only works for properly delegating class loaders. But Java allows
non-delegating ones :(
bug:
29964720
test:612-jit-dex-cache
(cherry picked from commit
491617a612c8a1c890e72d8ba780a151ddee8e11)
(cherry picked from commit
a2d7cbb44e570ec0a9064dc93f57441e6ab9e45a)
(cherry picked from commit
ae093d69f58c2b6257c3e5b82a32c135a1f33641)
Change-Id: I73df55286a9bdb3f96963e0756e3a8b784aa9077
Nicolas Geoffray [Tue, 19 Jul 2016 16:06:23 +0000 (17:06 +0100)]
JIT: Don't update the dex cache of another class loader.
This only works for properly delegating class loaders. But Java allows
non-delegating ones :(
bug:
29964720
test:612-jit-dex-cache
(cherry picked from commit
491617a612c8a1c890e72d8ba780a151ddee8e11)
(cherry picked from commit
a2d7cbb44e570ec0a9064dc93f57441e6ab9e45a)
Change-Id: I2523ce1fd4cd36dc83394d0f77ffc3f844e80c69
TreeHugger Robot [Tue, 19 Jul 2016 22:34:10 +0000 (22:34 +0000)]
Merge "Do allocation fence before pushing on allocation stack" into nyc-mr1-dev
Mathieu Chartier [Mon, 18 Jul 2016 18:11:45 +0000 (11:11 -0700)]
Do allocation fence before pushing on allocation stack
Heap::VisitObjects relies on having valid classes for objects in
the allocation stack. If the writes reorder, the thread calling
VisitObjects could see the free list pointer instead of the class
of the object. I believe this is causing crashes in VisitObjects.
Bug:
28790624
Test: Volantis booted
(cherry picked from commit
011dc2c4b9f3a064cba801679aedd3251fe191e3)
Change-Id: Ib620acbcd641ccd59fea9a66f5587c5026110a22
Philip Cuadra [Thu, 14 Jul 2016 22:26:20 +0000 (22:26 +0000)]
Merge "Add API for getting location of odex or oat file" into nyc-mr1-dev
Philip Cuadra [Tue, 12 Jul 2016 23:37:40 +0000 (16:37 -0700)]
Add API for getting location of odex or oat file
Add an API for getting the file path of odex or oat file given a dex
path.
Bug
28251566
Change-Id: Ibebaa20f15d8135b25d9eb5927b7979801ebf0b2
Nicolas Geoffray [Wed, 13 Jul 2016 13:13:48 +0000 (14:13 +0100)]
Fix a bug in ClassTableGet code generation for IMTs.
Introduced by:
https://android-review.googlesource.com/#/c/244980/
test:566-polymorphic-inling for fixing x86 crash. Also
fixes a performance regression.
bug:
29188168
(cherry picked from commit
ff484b95b25a5181a6a8a191cbd11da501c97651)
Change-Id: Iae5a63cb24017222c3fefda695a0a39673719f51
Andreas Gampe [Wed, 13 Jul 2016 18:29:47 +0000 (18:29 +0000)]
Merge "ART: Remove zygote OTA code" into nyc-mr1-dev
Nicolas Geoffray [Mon, 11 Jul 2016 12:33:16 +0000 (12:33 +0000)]
Merge "Fix System.arraycopy when doing same array copying." into nyc-mr1-dev
Andreas Gampe [Sat, 9 Jul 2016 17:51:12 +0000 (10:51 -0700)]
ART: Remove zygote OTA code
The renaming and relabeling of the A/B artifacts is now done in
a special-purpose script started by init, so as to not complicate
the logic here (e.g., name of the current slot).
Partially reverts commit
754479f7aa056602de8282f4f03718b42c20b89b.
Bug:
25612095
Bug:
28069686
Change-Id: I4d965361000fd448e199c9af059b6d18bfe928bb
Artem Udovichenko [Thu, 30 Jun 2016 09:18:25 +0000 (09:18 +0000)]
Revert "Revert "Optimize IMT""
This reverts commit
88f288e3564d79d87c0cd8bb831ec5a791ba4861.
Test: Includes smali tests to exercise cts failures that led to revert.
These tests check that objects that don't implement any interfaces are
handled properly when interface methods are invoked on them.
Bug:
29188168 (for initial CL)
Bug:
29778499 (reason for revert)
Change-Id: I49605d53692cbec1e2622e23ff2893fc51ed4115
Nicolas Geoffray [Thu, 7 Jul 2016 11:07:42 +0000 (12:07 +0100)]
Fix System.arraycopy when doing same array copying.
At compile time, if constant source < constant destination, and we don't
know if the arrays are the same, then we must emit code that checks
if the two arrays are the same. If so, we jump to the slow path.
test:610-arraycopy
bug:
30030084
(cherry picked from commit
9f65db89353c46f6b189656f7f55a99054e5cfce)
Change-Id:Ida67993d472b0ba4056d9c21c68f6e5239421f7d
Vladimir Marko [Tue, 26 Apr 2016 16:55:55 +0000 (17:55 +0100)]
Work around Jack optimizations in arm64 shifter operand test.
And also in the ror test.
Bug:
28392114
(cherry picked from commit
5bc80b9994bde67184adc1a168538c2a9b99fc8b)
Change-Id: I597a2556a81792d7a5289cc4925cb057ee57438d
Andreas Gampe [Sat, 25 Jun 2016 04:05:23 +0000 (21:05 -0700)]
ART: Add very-large threshold to dex2oat
Add a variable threshold to dex2oat. If the total dex file size for
an app reaches this threshold, dex2oat will punt all compilation and
compile the app with verify-at-runtime. This ensures smaller compile
time and memory thrashing, while still extracting the dex files and
thus helping with dirty memory later.
Added tests.
Bug:
29557002
Bug:
29790079
Test: m test-art-host-gtest-dex2oat_test
Change-Id: I78870e4a80ccaafcbbe56839e61ced0acd2ca05e
Vladimir Marko [Wed, 29 Jun 2016 19:10:20 +0000 (19:10 +0000)]
Fix merging HLoadClass with HNewInstance.
am:
2b8b6040d0
Change-Id: I31021cee60cd328e952f33bf8d98c6f26319c779
Vladimir Marko [Wed, 29 Jun 2016 13:59:07 +0000 (14:59 +0100)]
Fix merging HLoadClass with HNewInstance.
Do not merge HLoadClass with HNewInstance if they do not
come from the same dex instruction. This is the same check
as for moving the clinit check responsibility around.
Test: Added a regression test, run standard ART test suite
plus gcstress and ndebug modes on host and Nexus 9.
Bug:
29570861
Bug:
29321958
(cherry picked from commit
c7591b4c0dd405a766f4d701deea6c3750101978)
Change-Id: I0f019c36dd991889caad2666e61bbcc6d9d9c91f
TreeHugger Robot [Wed, 29 Jun 2016 16:01:21 +0000 (16:01 +0000)]
Merge changes I2814a0b8,I05a7961f into nyc-mr1-dev
* changes:
ART: Add dex2oat swap-usage parameters
OatFileAssistantTest: do not relocate image randomly.
Andreas Gampe [Fri, 24 Jun 2016 21:55:38 +0000 (14:55 -0700)]
ART: Add dex2oat swap-usage parameters
Make the dex2oat swap usage decision dependent on parameters that
can be changed on the command line. Both the dex file size and dex
file count can be modified through the following to new parameters:
--swap-dex-size-threshold
--swap-dex-count-threshold
The defaults remain the same (20MB and 2).
Factor out some dex2oat setup code from oat_file_assistant_test
and use it in a new dex2oat test.
Bug:
29557002
Test: m test-art-host-gtest-dex2oat_test
Test: m test-art-host-gtest-oat_file_assistant_test
Test: m test-art-host
Change-Id: I2814a0b895d960416d20b31c4b0052f98c9cb5e6
Jeff Hao [Tue, 28 Jun 2016 23:47:09 +0000 (23:47 +0000)]
Revert "Optimize IMT"
This reverts commit
0790af1391b316c5c12b4e135be357008c060696.
Bug:
29188168 (for initial CL)
Bug:
29778499 (reason for revert)
Change-Id: I2c3e4ec2cebdd40faec67ddb721b7acdc8e90061
Andreas Gampe [Mon, 27 Jun 2016 23:04:02 +0000 (23:04 +0000)]
ART: Disable no-prebuild test for run-test 608
am:
0748ed9fcf
Change-Id: I24f3f299b9f7159b17857a503559436905667b65
Nicolas Geoffray [Mon, 27 Jun 2016 22:58:49 +0000 (22:58 +0000)]
Do not remove loads/store with unresolved accesses.
am:
c2f1735e04
Change-Id: I83f86184e8ab5bd1143b8f66d35bd4c752995ea4
Andreas Gampe [Mon, 27 Jun 2016 21:55:02 +0000 (14:55 -0700)]
ART: Disable no-prebuild test for run-test 608
This test relies on unresolved types, which is not the case in a
no-prebuild setting (as all parts will be on the classpath).
Bug:
29433999
Change-Id: I11b1c6b446905aacd7a520796d0b2217319cefc7
Test: m ART_TEST_RUN_TEST_NO_PREBUILD=true test-art-host-run-test
(cherry picked from commit
06b7c4de44979f1cb51707d2236142bc733ebf75)
Nicolas Geoffray [Mon, 27 Jun 2016 09:03:29 +0000 (10:03 +0100)]
Do not remove loads/store with unresolved accesses.
Due to AOT and compiling classes that are not ready yet
(eg missing a super class), we need to be conservative when
accessing fields and can end up in a situation where the same
field can be resolved and unresolved within the same method
(because of inlining). Therefore, disable removing loads and
stores in a method when there are unresolved accesses.
bug:
29433999
(cherry picked from commit
b93a16517dce12b83e9d5d3b599446e25fcc157a)
Change-Id: I8fcfb52c584222474a8220eb16c6581350b702e0
Richard Uhler [Tue, 26 Apr 2016 17:24:38 +0000 (10:24 -0700)]
OatFileAssistantTest: do not relocate image randomly.
Manually relocate the boot image to a known location before starting
the runtime so that the image won't be randomly relocated. This fixes
flaky test failures due to the image randomly being relocated by 0.
Bug:
28294887
Bug:
29557002
(cherry picked from commit
a48403eb54494ac52f81c9ecc9da723075ac65da)
Change-Id: I05a7961f1237a05e89d3f631c959e260ccfe0b70
Oleksiy Vyalov [Wed, 22 Jun 2016 22:56:10 +0000 (22:56 +0000)]
Merge \"Call prctl(PR_SET_PTRACER, PR_SET_PTRACER_ANY) if app is debuggable.\" into nyc-dev
am:
f7a0543d88
Change-Id: Ifd8495cb08cf25f94ac0b87dc844f95c41ccda25
Oleksiy Vyalov [Wed, 22 Jun 2016 22:43:47 +0000 (22:43 +0000)]
Merge "Call prctl(PR_SET_PTRACER, PR_SET_PTRACER_ANY) if app is debuggable." into nyc-dev
Oleksiy Vyalov [Tue, 21 Jun 2016 23:21:37 +0000 (16:21 -0700)]
Call prctl(PR_SET_PTRACER, PR_SET_PTRACER_ANY) if app is debuggable.
Enabled Yama security may prevent non-privileged debugger from
attaching to the app. However, if app is marked is debuggable
then it should acceptable to allow debugger with arbitrary pid
to connect the app.
Bug:
29549463
Change-Id: I50c79dbca272dc473e489cc61471628e2fdc4a03
Nicolas Geoffray [Wed, 22 Jun 2016 08:55:00 +0000 (08:55 +0000)]
Fix braino in the test to make it work on target.
am:
af17a5e38a
Change-Id: I900bac835a6380a770d56b41c1749b276f79577a
Mathieu Chartier [Wed, 15 Jun 2016 22:07:03 +0000 (15:07 -0700)]
Propagate flags to ShouldHaveEmbeddedVTable
Pass kVerifyFlags and kReadBarrierrOption to ShouldHaveEmbeddedVTable
from ShouldHaveImt.
Bug:
29188168
(cherry picked from commit
efeb9f01308c5c4b723ff905cf5bea1636f7a549)
Change-Id: Ia76d8cd340fbb0527955f4ef611d6e14bebf8dd9
Nelli Kim [Fri, 13 May 2016 10:08:53 +0000 (13:08 +0300)]
Optimize IMT
* Remove IMT for classes which do not implement interfaces
* Remove IMT for array classes
* Share same IMT
Saved memory (measured on hammerhead):
boot.art:
Total number of classes: 3854
Number of affected classes: 1637
Saved memory: 409kB
Chrome (excluding classes in boot.art):
Total number of classes: 2409
Number of affected classes: 1259
Saved memory: 314kB
Google Maps (excluding classes in boot.art):
Total number of classes: 6988
Number of affected classes: 2574
Saved memory: 643kB
Performance regression on benchmarks/InvokeInterface.java benchmark
(measured timeCall10Interface)
1st launch: 9.6%
2nd launch: 6.8%
Bug:
29188168
(cherry picked from commit
badee9820fcf5dca5f8c46c3215ae1779ee7736e)
Change-Id: If8db765e3333cb78eb9ef0d66c2fc78a5f17f497
Nicolas Geoffray [Tue, 21 Jun 2016 12:05:24 +0000 (13:05 +0100)]
Fix braino in the test to make it work on target.
bug:
29449194
(cherry picked from commit
d8aa513eba9c6100a829168d31938610a99eecbb)
Change-Id: I58bd94a6c8cef7b6ac52dfb375a1df1937510767