OSDN Git Service
John W. Bruce [Fri, 24 Mar 2017 05:40:17 +0000 (22:40 -0700)]
Add Flag for Enabling 64-bit Legacy DRM Plugins
We are ready for devices to begin migrating to a 64-bit Legacy DRM
Loader. However, not all devices are ready to make this jump yet. A
device needs to have all of its Legacy DRM Plugins ready to run as
64-bit before it can do this. This includes having 64-bit hardware
integrations.
So that devices can turn on 64-bit support as they get ready, I am
adding flags that can be set in a device's device.mk file. There are two
parts:
* ENABLE_MEDIADRM_64 enables building the Legacy DRM Plugin HAL as
64-bit.
* Setting drm.64bit.enabled=true in PRODUCT_PROPERTY_OVERRIDES switches
the Legacy DRM Plugin HAL to searching for DRM Plugins in the 64-bit
directory.
Test: Validated that turning on these flags enables a 64-bit Legacy DRM
Plugin HAL that loads 64-bit Legacy DRM Plugins from the lib64
directory.
Bug:
36076017
Change-Id: I8d21fc7e7c0357eb6755839d41caa0f37ca20aff
TreeHugger Robot [Thu, 6 Apr 2017 06:58:57 +0000 (06:58 +0000)]
Merge changes from topic 'vhal-def-refactor' into oc-dev
* changes:
Extract logic of storing values to separate class
Fix an issue where Vehicle HAL would crash when trying to update a continuous property without an initial floating-point value
Refactor default values in VHAL
TreeHugger Robot [Thu, 6 Apr 2017 05:34:28 +0000 (05:34 +0000)]
Merge "Bluetooth HAL: Add to foreground schedtune group" into oc-dev
Pavel Maltsev [Fri, 31 Mar 2017 20:45:54 +0000 (13:45 -0700)]
Extract logic of storing values to separate class
Also rename DefaultVehicleHal to EmulatedVehicleHal and
extract emulator related code to VehicleEmulator class
Test: mm -j32 ; verified Car Service worked
Change-Id: I34361fdec6f94629cf7ef6c35ff56ef9ce78b855
Enrico Granata [Mon, 3 Apr 2017 19:59:00 +0000 (12:59 -0700)]
Fix an issue where Vehicle HAL would crash when trying to update a continuous property without an initial floating-point value
Bug:
36858992
Test: build, flash and boot
(cherry picked from commit
945d0bbc866ce21f262a1715c5a2560898c8aca1)
Merged-In: I9906abbf386cf75e838102299e3e97de3475db63
Change-Id: I19ef534fde190a3a1adaca377e8f09760c0ccf4e
Pavel Maltsev [Wed, 29 Mar 2017 19:09:54 +0000 (12:09 -0700)]
Refactor default values in VHAL
Move default values closer to config declration to add properties
with less pain in future.
Test: mm -j32; verified if Car Service works
(cherry picked from commit
24ade1751811742948b8ce5177f57f873a4b1b96)
Merged-In: I2f18837658149eb657f44d81e34eb8e6e497a25c
Change-Id: Ie4285581fa9d871b366b0ed2f08fa8073739a0a9
Greg Hartman [Wed, 5 Apr 2017 22:20:21 +0000 (22:20 +0000)]
Merge "CameraProvider: Refactor legacy name regex code" into oc-dev
Badhri Jagan Sridharan [Wed, 5 Apr 2017 21:16:05 +0000 (21:16 +0000)]
Merge "USB: HIDL: check the status of registerAsService" into oc-dev
TreeHugger Robot [Wed, 5 Apr 2017 19:54:13 +0000 (19:54 +0000)]
Merge "wifi(implementation): Print out the cb object on failure" into oc-dev
TreeHugger Robot [Wed, 5 Apr 2017 18:31:01 +0000 (18:31 +0000)]
Merge "Fix DRM prebuilt vendor module handling" into oc-dev
Roshan Pius [Fri, 31 Mar 2017 01:01:54 +0000 (18:01 -0700)]
wifi(implementation): Print out the cb object on failure
This should help us figure out if there are multiple callback objects in
wifi_chip when we see the IPC storm from
onDebugRingBufferDataAvailable().
Bug:
36599054
Test: ACTS wifi tests.
Change-Id: I8c67032c59ecdd45824e131b59d890ce6c94fe25
Roshan Pius [Mon, 3 Apr 2017 17:09:43 +0000 (10:09 -0700)]
wifi(implementation): Ignore IE parsing error
The IE blob may not always be fully formed in gscan full scan results.
So, log errors when we hit a parsing error and return the IE elements we
could parse so far.
Bug:
36455164
Test: ACTS wifi gscan tests.
Change-Id: I804937ea5e69f51696aaabf3fe3f53850c145ad3
Roshan Pius [Fri, 31 Mar 2017 01:04:04 +0000 (18:04 -0700)]
wifi(implementation): Return const-ref for callback set
Bug:
36792787
Test: Compiles
Change-Id: Ibd19c6f41801d0fa1ea7dc9c3334213865d649ec
Andreas Gampe [Wed, 5 Apr 2017 03:02:25 +0000 (20:02 -0700)]
CameraProvider: Refactor legacy name regex code
The match will use iterators that will be invalidated when the
used string input goes out of scope. Refactor the API to return
the two components of the match.
Bug:
36871785
Test: m && m SANITIZE_TARGET=address
Change-Id: I2418541234a09e53856ea61e0fbc4b67d8036308
Joel Fernandes [Tue, 4 Apr 2017 02:19:30 +0000 (19:19 -0700)]
Bluetooth HAL: Add to foreground schedtune group
EAS (Energy-Aware Scheduler) tends to cluster tasks together unless
they're marked to prefer an idle CPU (prefer-idle) during placement.
This is to save energy however it increases latencies. This is
noticeable when the Binder driver demotes the RT task to CFS and when
we try to do load balance in this path, the selection path still selects
a busy CPU. Add Bluetooth HAL service to the foreground schedtune group
to fix this as its critical for tasks like bluetooth audio playback.
Test: Boot and verify bluetooth HAL is in the foreground stune group
Bug:
36867985
Change-Id: Ib3c43cca4a2049af3700978b58a05989cc20b6ac
Signed-off-by: Joel Fernandes <joelaf@google.com>
(cherry picked from commit
1b8f6f7c771a7ff04790833674705972009a3c7d)
Jeff Tinker [Fri, 31 Mar 2017 23:34:17 +0000 (16:34 -0700)]
Fix DRM prebuilt vendor module handling
bug:
36817233
Change-Id: I93659a9901198d05fd43bf95804067a244533808
Jaesoo Lee [Fri, 24 Mar 2017 05:08:24 +0000 (14:08 +0900)]
removed log print statements for configstore from SurfaceFlingerConfigs.cpp
Log messages for the retrieved values from configstore will be
automatically printed at the client side (by configstore-utils).
Bug:
36275627
Test: Built and check the log messages
Change-Id: Id5033a74ef58778e93e39be6ac5b9e10ee28c5cf
Jaesoo Lee [Fri, 24 Mar 2017 05:08:24 +0000 (14:08 +0900)]
print log message for values retrieved from configstore
This CL adds a code for printing log messages in clients-side utility
library functions (getXXX) for configstore so that the developer can
figure out which configuration values are actually retrieved from the configstore.
Bug:
36275627
Test: Built and check the log message appears
Change-Id: I2c0895f8afbbb2947b62164acaf62a491c451dc0
TreeHugger Robot [Wed, 5 Apr 2017 01:18:49 +0000 (01:18 +0000)]
Merge "Add DeleteKey and DeleteAllKeys test to Keymaster VTS tests" into oc-dev
Yin-Chia Yeh [Tue, 4 Apr 2017 22:22:02 +0000 (22:22 +0000)]
Merge "Revert "camera: Map between legacy gralloc0 usage, and HIDL gralloc1 usages"" into oc-dev
Badhri Jagan Sridharan [Wed, 29 Mar 2017 17:51:17 +0000 (10:51 -0700)]
USB: HIDL: check the status of registerAsService
registerAsService call could fail. Hence check the return value.
Bug:
36704362
Test: Manually checked to see if usb hal service is running.
Change-Id: I46dcd74dbee6aba72cf344f10854e5d4b1b6de18
Yin-Chia Yeh [Tue, 4 Apr 2017 20:00:35 +0000 (13:00 -0700)]
Revert "camera: Map between legacy gralloc0 usage, and HIDL gralloc1 usages"
This reverts commit
2d80c0d66f9ca869d6102f07bd236b7c4c94c205.
Test: fix b/
36876770
Bug: b/
36876770
Change-Id: Ia251ec97273d71fd5bc759aa1161960f6266358a
Etan Cohen [Tue, 4 Apr 2017 19:42:00 +0000 (19:42 +0000)]
Merge "[AWARE] Create true translations between legacy and hidl enums" into oc-dev
TreeHugger Robot [Tue, 4 Apr 2017 19:24:26 +0000 (19:24 +0000)]
Merge "Camera: HAL1: remove libbinder usage" into oc-dev
Steven Moreland [Tue, 4 Apr 2017 17:58:00 +0000 (17:58 +0000)]
Merge "Enable the clang-format pre-submit hook" into oc-dev
TreeHugger Robot [Tue, 4 Apr 2017 17:55:53 +0000 (17:55 +0000)]
Merge "Clarifying broadcast vs. predicted orbits" into oc-dev
Etan Cohen [Mon, 3 Apr 2017 23:10:54 +0000 (16:10 -0700)]
[AWARE] Create true translations between legacy and hidl enums
Replace implicits translations between legacy and hidl enums (using
casts) with explicit translations.
(cherry-pick of commit
284511779ca6c425a4f701ca8098484d954e13c4)
Bug:
35767620
Test: integration (sl4a) tests
Merged-In: I4ae4cd691226ce29bc0e92f9890fbb343a064505
Change-Id: I4ae4cd691226ce29bc0e92f9890fbb343a064505
TreeHugger Robot [Tue, 4 Apr 2017 03:06:50 +0000 (03:06 +0000)]
Merge "nfc: vts: Correct parameters going for CoreInitialized" into oc-dev
TreeHugger Robot [Tue, 4 Apr 2017 01:03:53 +0000 (01:03 +0000)]
Merge "Remove dependency to libbinder in VHAL" into oc-dev
TreeHugger Robot [Tue, 4 Apr 2017 01:00:38 +0000 (01:00 +0000)]
Merge "Test for getHashChain() in IBase." into oc-dev
Ruchi Kandoi [Fri, 31 Mar 2017 23:32:15 +0000 (16:32 -0700)]
nfc: vts: Correct parameters going for CoreInitialized
Core Initialized with parameters 1-3 leads the device into recovery
mode. Which causes the test to fail.
Bug:
36751759
Change-Id: If2b91237a445ce050b7da6be5f97dd8eea30046e
Merged-In: I1375546cc66c147f26c315a042ca0afb49f0ce06
Test: Test passes
TreeHugger Robot [Tue, 4 Apr 2017 00:31:00 +0000 (00:31 +0000)]
Merge "Camera: add interface to evict obsolete buffer caches" into oc-dev
TreeHugger Robot [Mon, 3 Apr 2017 23:51:34 +0000 (23:51 +0000)]
Merge "add components necessary for bootanim to animation class" into oc-dev
Pavel Maltsev [Tue, 28 Mar 2017 20:47:31 +0000 (13:47 -0700)]
Remove dependency to libbinder in VHAL
Also, removed per property ACL as it was based on client UID
Test: mm -j ; verified Car Service works
Bug: b/
36649684
Change-Id: I7625a013dda8e3ebce5b86a253a8c1befe267c11
(cherry picked from commit
72aebeb3ec070b6c334fab68b2c46f94868d014a)
Eino-Ville Talvala [Mon, 3 Apr 2017 22:03:13 +0000 (22:03 +0000)]
Merge "camera: Map between legacy gralloc0 usage, and HIDL gralloc1 usages" into oc-dev
Yin-Chia Yeh [Thu, 30 Mar 2017 22:06:20 +0000 (15:06 -0700)]
Camera: add interface to evict obsolete buffer caches
Test: fix CTS ReprocessCaptureTest
Bug:
34461678
Change-Id: Icde654b0c8423c31d7d39d180913ffa374e7de3c
Yifan Hong [Wed, 29 Mar 2017 22:46:12 +0000 (15:46 -0700)]
Test for getHashChain() in IBase.
Each interface has a getHashChain() method that
returns the hash of all .hal files from the rtti
of the interface up to IBase.
Test: hidl_test
Bug:
36602587
Change-Id: I53a79ba69edd109f169c37dbe0fd10e302eb929c
TreeHugger Robot [Mon, 3 Apr 2017 07:34:01 +0000 (07:34 +0000)]
Merge "Camera: add HAL1 recording batching support" into oc-dev
Yuexi Ma [Fri, 31 Mar 2017 23:26:18 +0000 (16:26 -0700)]
Updates bluetooth hal test to use VtsHalHidlTargetTestBase v3
Test: pass
Change-Id: Ia5237a27800010174f2b23a3a4b1157f1c48781f
(cherry picked from commit
b8012eb907639990f4cbfe04ca1490d1ab270168)
Yuexi Ma [Thu, 30 Mar 2017 01:11:01 +0000 (18:11 -0700)]
NFC VTS test use VtsHalHidlCallbackBase for callback wait and notify
VtsHalNfcV1_0TargetTest uses VtsHalHidlCallbackBase.
Callback class extends VtsHalHidlCallbackBase and use waitForCallback and notifyFromCallback
The original NFC test contains the following use cases:
* Callback notify happens before wait
* Multiple waiting in serial
The modified version added the following use cases:
* Wait for specific callback function
* Passing callback arg data along wait and notify functions
Bug:
36036059
Test: make VtsHalNfcV1_0TargetTest, adb push & adb shell
Change-Id: Ic6668a18254661d07c4ff37309cd96ea5f786d29
(cherry picked from commit
bfefc5ef104b63d0644ec3b4c766131987824535)
Yuexi Ma [Wed, 29 Mar 2017 23:49:59 +0000 (16:49 -0700)]
Bluetooth VTS test use VtsHalHidlCallbackBase for callback wait and notify
VtsHalBluetoothV1_0TargetTest uses VtsHalHidlCallbackBase.
Callback class extends VtsHalHidlCallbackBase and use waitForCallback, notifyFromCallback, and setWaitTimeout
The original Bluetooth test contains the following use cases:
* Wait for specific callback
* Set timeout for specific callback waiting
The modified version supports the above use cases.
Bug:
36036059
Test: Test pass locally
Change-Id: I961baaf7f1b09fa9c134629cc7280565a2664ed5
(cherry picked from commit
51d023c48ec6cf709e756ceed62c11b25fb0c085)
Yin-Chia Yeh [Sat, 25 Mar 2017 00:55:42 +0000 (17:55 -0700)]
Camera: HAL1: remove libbinder usage
Test: Angler HAL1 preview/takePicture/record
Bug:
35887419
Change-Id: I6cb37fd78a2fad1ee3b24e4cd61e3a3b2bce4744
Yin-Chia Yeh [Wed, 22 Mar 2017 00:47:02 +0000 (17:47 -0700)]
Camera: add HAL1 recording batching support
Test: Angler HAL1 + set mBatchSize to 4 locally
Bug:
35997432
Change-Id: I6baf112f9da56534ae81008bad818fba1e76a294
TreeHugger Robot [Sat, 1 Apr 2017 02:22:27 +0000 (02:22 +0000)]
Merge "Change sytle of radio and sap tests to clang google" into oc-dev
TreeHugger Robot [Sat, 1 Apr 2017 00:54:06 +0000 (00:54 +0000)]
Merge "Update DRM makefile." into oc-dev
Scott Randolph [Sat, 1 Apr 2017 00:49:20 +0000 (00:49 +0000)]
Merge "Add VTS tests for EVS HAL" into oc-dev
Yuexi Ma [Thu, 30 Mar 2017 17:58:23 +0000 (10:58 -0700)]
Change sytle of radio and sap tests to clang google
Test: make VtsHalRadioV1_0TargetTest, make VtsHalSapV1_0TargetTest
Change-Id: Ie13efe0d049ade7839881c14ed2904d8acd99b93
(cherry picked from commit
bb96133731e84cad563aa1f392a71d7fec728fa9)
Keun-young Park [Thu, 23 Mar 2017 20:48:26 +0000 (13:48 -0700)]
add components necessary for bootanim to animation class
- necessary for running shutdown animation:
android.hardware.graphics.composer
android.hardware.graphics.allocator
android.hardware.configstore
bug:
36526187
Test: many reboots
Change-Id: Iba3eefddd2bd33c28152c17081a4ad13619d330d
Scott Randolph [Thu, 30 Mar 2017 21:24:14 +0000 (14:24 -0700)]
Add VTS tests for EVS HAL
Note: This change list was developed as ag/
2031642 on master, but
cherry picks are broken at the moment, so reapplying directly to oc-dev.
The change in master will be abandoned in favor of the auto-merger.
Test: Run them against the default (mock) driver on bat_land
Change-Id: I7ae523eb6a18ce6a1d0dcd8494f335ffa77f34f1
Janis Danisevskis [Sat, 11 Mar 2017 00:00:57 +0000 (16:00 -0800)]
Add DeleteKey and DeleteAllKeys test to Keymaster VTS tests
The tests added verify that a generated key is no longer usable
after it was
- explicictely deleted with deleteKey, or
- all keys where deleted with deleteAllKeys.
Bug:
32022681
Test: make vts -j30 BUILD_GOOGLE_VTS=true TARGET_PRODUCT=aosp_arm64 &&
vts-tradefed run commandAndExit vts --skip-all-system-status-check
--primary-abi-only --skip-preconditions
--module VtsHalKeymasterV3_0TargetTest -l INFO
Change-Id: I172ee5d3ccf1850c3c92d3a1a9e991f46b07a0e3
TreeHugger Robot [Fri, 31 Mar 2017 22:25:34 +0000 (22:25 +0000)]
Merge "supplicant(vts): Compilation fixes" into oc-dev
Wyatt Riley [Fri, 31 Mar 2017 22:23:00 +0000 (15:23 -0700)]
Clarifying broadcast vs. predicted orbits
Clarifying comment changes only, no functional
changes.
Bug:
30955615
Test: Builds and GPS still works on device
Change-Id: I073527c11d095651d712b41fc5b301ac478e4082
Ryan Campbell [Fri, 31 Mar 2017 21:36:00 +0000 (14:36 -0700)]
Update DRM makefile.
Change module name to VTS format.
Test: cd hardware/interfaces && mma
Bug:
34178477
Change-Id: I33490627e1254ec1b1d36ebb7778e20680005910
Wyatt Riley [Fri, 31 Mar 2017 15:28:16 +0000 (15:28 +0000)]
Merge "IGnssDebug.hal field fixes" into oc-dev
TreeHugger Robot [Fri, 31 Mar 2017 05:29:53 +0000 (05:29 +0000)]
Merge "Add VTS tests for drm+crypto HALs" into oc-dev
Jeff Tinker [Thu, 12 Jan 2017 03:42:05 +0000 (19:42 -0800)]
Add VTS tests for drm+crypto HALs
Tests: drm vts tests are passing
related-to-bug:
32815560
Change-Id: I2b36f27fbb42eba37f3e5a26acea0e359e60b3af
Wyatt Riley [Wed, 29 Mar 2017 17:11:59 +0000 (10:11 -0700)]
IGnssDebug.hal field fixes
Modifying some fields in this API to align with values
that work with partner implementations, and better
capture the intent of this new API.
Bug:
30955615
Test: Builds and works with hidl-gen
Change-Id: Ied53cbeed2703ce757a246b45339ff2b9dfeb410
TreeHugger Robot [Fri, 31 Mar 2017 01:05:31 +0000 (01:05 +0000)]
Merge "Check result of registerAsService in dumpstate." into oc-dev
TreeHugger Robot [Fri, 31 Mar 2017 00:37:29 +0000 (00:37 +0000)]
Merge "Simplify EVS HAL and move to "agressive opens"" into oc-dev
Eino-Ville Talvala [Thu, 23 Mar 2017 22:39:12 +0000 (15:39 -0700)]
camera: Map between legacy gralloc0 usage, and HIDL gralloc1 usages
Otherwise some bits will be set incorrectly.
Also move device@1.0 to use ProducerUsageFlags instead of ProducerUsage,
and add a compatibility workaround to set the gralloc0 HW_CAMERA_ZSL flags
when ConsumerUsage::CAMERA is passed in.
Test: Camera CTS passes, updated VTS tests pass
Bug:
35215313
Change-Id: I981dc1a650f838f94d932944fe835fd267f2004d
Jeff Tinker [Thu, 30 Mar 2017 23:00:40 +0000 (23:00 +0000)]
Merge "Fix getKeyRequest legacy HAL returning invalid status" into oc-dev
Jeff Tinker [Tue, 7 Mar 2017 00:58:47 +0000 (16:58 -0800)]
Fix getKeyRequest legacy HAL returning invalid status
bug:
36006198
Test: drm hal vts test
Change-Id: Ie3125b4459add4fd30dc418f92ab0f51d8fcc73b
TreeHugger Robot [Thu, 30 Mar 2017 22:12:29 +0000 (22:12 +0000)]
Merge "Add VTS tests for Sap Apis." into oc-dev
Roshan Pius [Tue, 21 Mar 2017 22:44:40 +0000 (15:44 -0700)]
supplicant(vts): Compilation fixes
Fixed couple of compilation failures from .hal changes and made change
to stop/start framework during tests.
Bug:
33457575
Test: mmma -j32 hardware/interfaces/wifi/supplicant/1.0/vts/functional
Change-Id: I1bac68bd71e92b025acdebd0fef8834b826bcfcb
Scott Randolph [Thu, 30 Mar 2017 21:04:12 +0000 (14:04 -0700)]
Simplify EVS HAL and move to "agressive opens"
This adapts the API implementation to allow a duplicate "open" operation
to automatically close any previous connections to the device. This
works around a binder level issue that can cause destructors triggered
by remote clients to be delivered out of order to the server.
This was originally change ag/
1969959 on master, but has been
recreated on oc-dev (cherry-picking was broken at the time).
The original master change will be abandoned in favor of this getting
merged down from oc-dev.
Test: Run Vts test (added in following change)
Change-Id: I7b417998e59a4d592fbb91811c4101f39097c5dd
Myles Watson [Thu, 30 Mar 2017 16:13:50 +0000 (09:13 -0700)]
Enable the clang-format pre-submit hook
Bug:
36699008
Test: Try to upload a patch with formatting errors.
Change-Id: I4af7d142ccbbaf39eb236547487c59c5ff8f2cd6
Steven Moreland [Thu, 30 Mar 2017 17:59:42 +0000 (10:59 -0700)]
Check result of registerAsService in dumpstate.
Test: see change I35f5d4498abd7369b03a04081e8aa26a3933328e
Fixes:
36704363
Change-Id: I5cc8f32592a77994e756438b8d1b7f3255acef19
Mikhail Naganov [Wed, 29 Mar 2017 16:31:18 +0000 (09:31 -0700)]
audiohal: Fix UAF of HAL devices in Stream objects
Stream objects used to hold a pointer to underlying HAL device
object which they didn't own. Since destruction of server side
objects is asynchronous, it was possible that a Device object
gets destroyed before Stream objects, making all the HAL device
object pointer to become stale.
Fixed by adding a strong reference to Device objects into Stream
objects.
Bug:
36702804
Change-Id: I3da3611afbb91d6fd6410ac5b8af2a2eebfa6dac
Test: ran Loopback app and HAL VTS tests
(cherry picked from commit
96d3573cda6f76bcbfc277e69d94914a565218d8)
Shawn Willden [Thu, 30 Mar 2017 03:27:12 +0000 (21:27 -0600)]
Revert "Revert "Add keymaster VTS tests.""
This reverts commit
8e10baee45a1bfab4094869159b8ede270b6d416.
Test: Tests pass, except known failures with in-progress vendor fixes
Change-Id: Ia95c1444100e123fa65d095b001878cf9040d0c4
Michael Butler [Fri, 17 Mar 2017 20:02:53 +0000 (13:02 -0700)]
RenderScript VTS cleanup and fixes
This CL fixes the remaining VTS test cases for the RenderScript
vts-hidl-hal test and cleans up and improves the working test cases.
The goal is to have at least one passing test case per HIDL HAL entry.
Bug:
35915961
Test: mm and run on angler
Change-Id: I4b6e25831ce7d2abb3148c39eb48bde10ed04646
(cherry picked from commit
54fa8d428552a6202d196b6abf6a844bb277ac98)
Michael Butler [Mon, 27 Mar 2017 21:14:18 +0000 (14:14 -0700)]
Fix RS HIDL server, pass data by bytes instead of by elements.
Our current stack:
API->API_TO_HAL_translator->HAL
->HAL_TO_Implementation_translator->Implementation
For most APIs:
- API passes objectCount.
- HAL expects objectCount.
- Implementation expects objectCount.
For APIs like ScriptGroupCreate:
- API passes byteCount. And unfortunately, these APIs are part of
NDK, we could not make them also passing objectCount like others.
- HAL expects objectCount.
- Implementation expects byteCount.
So that both API_TO_HAL_translator and
HAL_TO_Implementation_translator should correctly convert input
objectCount/byteCount to byteCount/objectCount.
This CL only fixes the HAL_TO_Implementation_translator part,
whereas aosp/356395 fixes the API_TO_HAL_translator part. Both
parts were mistakenly using byteCount as objectCount, causing
potential out-of-bound access.
Bug:
36404879
Test: mm on angler
Change-Id: I28541a8926aeafece40e2a3f664bda67e26a34a2
(cherry picked from commit
fd14e27b8997da6b453174af2af2e1cf66e01b5d)
Shuoq [Fri, 24 Mar 2017 00:22:50 +0000 (17:22 -0700)]
Add VTS tests for Sap Apis.
Bug:
32022332
Test: vts
Change-Id: I9a55978aa485a59510090f46a8e5edfb87bccc0e
Keun Soo Yim [Wed, 29 Mar 2017 20:19:28 +0000 (20:19 +0000)]
Merge "Revert "Add keymaster VTS tests."" into oc-dev
Keun Soo Yim [Wed, 29 Mar 2017 20:18:52 +0000 (20:18 +0000)]
Revert "Add keymaster VTS tests."
This reverts commit
dda22ea8845f6906d4bccc13bf142d96a43976c5.
Change-Id: Ie6a60e17ed5258840eba3d3f6b8092636160b2c2
Andreas Huber [Wed, 29 Mar 2017 18:48:36 +0000 (18:48 +0000)]
Merge "Convert all comments into "doxygen-ready" comments." into oc-dev
Andreas Huber [Tue, 28 Mar 2017 23:19:16 +0000 (16:19 -0700)]
Convert all comments into "doxygen-ready" comments.
Bug:
36453077
Test: mma
Change-Id: I0b1f77dfae5d2258969e33d85ecf45401ffbdfaa
Shawn Willden [Fri, 2 Dec 2016 12:07:02 +0000 (05:07 -0700)]
Add keymaster VTS tests.
Note: Recent Google devices have keymaster implementations that don't
pass this test suite. See https://goo.gl/6hsGwa for a summary.
Bug:
32022681
Test: This is the test suite.
Change-Id: Ib200b68e0c7844df02eb9f086385d6c36e306d45
Andreas Huber [Tue, 28 Mar 2017 21:40:58 +0000 (14:40 -0700)]
Convert all comments into "doxygen-ready" comments.
Bug:
36453077
Test: make
Change-Id: Ic77394d4d2e1ccedba3a28230d870c5d6108bd40
TreeHugger Robot [Tue, 28 Mar 2017 20:55:50 +0000 (20:55 +0000)]
Merge "Use gralloc usage conversion library" into oc-dev
Jesse Hall [Thu, 23 Mar 2017 23:40:59 +0000 (16:40 -0700)]
Use gralloc usage conversion library
Converting from ..graphics.allocator@2.0 usage to gralloc0 usage isn't
quite as simple as ORing and truncating, which is what the default
implementation was doing. Switch to using library functions that do it
correctly.
Test: boot bullhead
Change-Id: I40ae00e9aad92b374f281569207972b7461a3e55
Steven Moreland [Mon, 27 Mar 2017 18:48:14 +0000 (11:48 -0700)]
Update makefiles for hwtypes.h
Test: pass
Change-Id: I8e17eb8fec5d2f04c526476a866c8dd54ccb556c
Ben Fennema [Tue, 28 Mar 2017 04:29:31 +0000 (04:29 +0000)]
Merge "Add missing LOW_LATENCY_OFFBODY_DETECT handling"
TreeHugger Robot [Tue, 28 Mar 2017 04:17:46 +0000 (04:17 +0000)]
Merge "Fingerprint vts tests."
TreeHugger Robot [Tue, 28 Mar 2017 02:37:45 +0000 (02:37 +0000)]
Merge "Revert "Add auth token parsing to IKeymasterDevice.hal""
Shawn Willden [Tue, 28 Mar 2017 00:40:57 +0000 (00:40 +0000)]
Revert "Add auth token parsing to IKeymasterDevice.hal"
This reverts commit
62f63c7ddbd08737e298a97975754225e5da0126.
Reason for revert: b/
36637075
Bug:
36637075
Change-Id: Ie0e8d0b480047a7c68f266e7e5d8a31722f85128
TreeHugger Robot [Tue, 28 Mar 2017 00:02:18 +0000 (00:02 +0000)]
Merge "Sync the constants in HAL and framework"
Roshan Pius [Mon, 27 Mar 2017 22:36:14 +0000 (22:36 +0000)]
wifi(implementation): Stop loading vendor library statically am:
34e4bc4dd2 am:
c17e4e07ac
am:
0e5e51175c
Change-Id: Ib1e6cc90a4388e49fda3608fb193e15fb66aef80
Roshan Pius [Mon, 27 Mar 2017 22:33:13 +0000 (22:33 +0000)]
wifi(implementation): Stop loading vendor library statically am:
34e4bc4dd2
am:
c17e4e07ac
Change-Id: I843085db6544dd9c14feb611b709f48e6284c901
Roshan Pius [Mon, 27 Mar 2017 22:30:43 +0000 (22:30 +0000)]
wifi(implementation): Stop loading vendor library statically
am:
34e4bc4dd2
Change-Id: I614a2074fbc2d82618eeb72002724830cf888dab
Roshan Pius [Mon, 27 Mar 2017 16:23:12 +0000 (09:23 -0700)]
wifi(implementation): Stop loading vendor library statically
libwifi-hal statically imports the vendor implementation of the legacy
HAL. Since the HIDL daemon is dynamically linking against libwif-hal,
there is no need for it to statically import the vendor implementation
library (one pointed to by: $LIBWIFI-HAL variable).
Bug:
36169790
Test: Compiles & device is able to connect to wifi networks with the
change.
Change-Id: Ie44b58328f9bdde011ba6d4a4d26f786c2d097e7
Kevin Chyn [Tue, 21 Mar 2017 20:36:24 +0000 (13:36 -0700)]
Fingerprint vts tests.
Fix callback mechanism. Add tests for uncovered interfaces.
Test: make vts && adb push
out/host/linux-x86/vts/android-vts/testcases/DATA/nativetest64/VtsHalBiometricsFingerprintV2_1TargetTest/VtsHalBiometricsFingerprintV2_1TargetTest
/data/local/tmp/ && adb shell
./data/local/tmp/VtsHalBiometricsFingerprintV2_1TargetTest
Bug:
32022721
Change-Id: Ibeb955bfb937d9f23f98a2e073235aa745183e94
Shubang [Tue, 21 Mar 2017 20:00:51 +0000 (13:00 -0700)]
Sync the constants in HAL and framework
Test: build and flash device.
Bug:
36233336
Change-Id: I8134b8bded5e31561a97938bdf86a43f7c2b6dc5
TreeHugger Robot [Mon, 27 Mar 2017 17:57:55 +0000 (17:57 +0000)]
Merge "audiohal: Add crash tests for some methods of IEffect"
Steven Moreland [Mon, 27 Mar 2017 17:51:28 +0000 (17:51 +0000)]
Update makefiles. am:
e90c31f125 am:
f11981de68
am:
103bada0e1
Change-Id: Ibe6eeeacab5660a8cf70d59dd9a4864d6f70ab80
Steven Moreland [Mon, 27 Mar 2017 17:48:27 +0000 (17:48 +0000)]
Update makefiles. am:
e90c31f125
am:
f11981de68
Change-Id: Icf25d969d83dff9653435d5fff0edb6b274a9d9f
Steven Moreland [Mon, 27 Mar 2017 17:45:26 +0000 (17:45 +0000)]
Update makefiles.
am:
e90c31f125
Change-Id: I370a9a20b005d7510463594b24e5c4fc8791116a
Steven Moreland [Sat, 25 Mar 2017 04:50:45 +0000 (21:50 -0700)]
Update makefiles.
Test: pass
Change-Id: I925baccbe51a32b7b7f3f66cf2918d017ee6b039
Shawn Willden [Fri, 17 Feb 2017 19:23:51 +0000 (12:23 -0700)]
Add auth token parsing to IKeymasterDevice.hal
Auth tokens have an unfortunate dual character. To most of the system
they are opaque blobs that are intended only to be obtained from one
HAL (e.g. gatekeeper or fingerprint) and passed to another
HAL (keymaster), but keystore actually needs to extract some bits of
information from them in order to determine which of the available blobs
should be provided for a given keymaster key operation.
This CL adds a method that resolves this dual nature by moving the
responsibility of parsing blobs to the HAL so that no component of the
framework has to make any assumptions about their content and all can
treat them as fully opaque. This still means that the various HAL
implementers have to agree on content, but they also have to agree on an
HMAC key which much be securely distributed to all at every boot, so
asking them to agree on an auth token format is perfectly
acceptable. But now the Android system doesn't have to care about the
format.
Bug:
32962548
Test: CTS tests pass, plus manual testing.
Change-Id: I78aa6e4ea9c5d8f34906b0969909387e2c5894e6
Shawn Willden [Wed, 1 Mar 2017 13:36:26 +0000 (06:36 -0700)]
Note that auth token is opaque.
Change-Id: I788ab8c5be630dd818a9a442c487c3451029bf81
Test: N/A, comment-only change
Bug:
34985116
Ben Fennema [Sat, 25 Mar 2017 01:45:50 +0000 (18:45 -0700)]
Add missing LOW_LATENCY_OFFBODY_DETECT handling
Bug:
36580454
Test: unlock watch with LLOB sensor and verify no SensorService crash
Change-Id: Ib1d086efd80e829bb844521fa39325f095b1c2c9
Signed-off-by: Ben Fennema <fennema@google.com>