OSDN Git Service
Heena Sirwani [Mon, 6 Oct 2014 08:16:09 +0000 (13:46 +0530)]
Staging: comedi: Compressed two lines of code into one.
The following patch compressed two lines of code into one using
coccinelle and removed an unused variable.
The semantic patch used is as follows:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return ret;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 06:29:29 +0000 (11:59 +0530)]
Staging: comedi: drivers: Compressed two lines of code into one.
The following patch compresses two lines of code into one using
coccinelle and removes an unused variable.
The following semantic patch was used:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return ret;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:56:49 +0000 (11:26 +0530)]
staging: comedi: drivers: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Sat, 4 Oct 2014 22:47:37 +0000 (01:47 +0300)]
staging: comedi: Fix cast to restricted __be32
This patch fixes "cast to restricted __be32"
sparse warning in ni_stc.h
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Veronika Kabatova [Tue, 7 Oct 2014 22:41:10 +0000 (00:41 +0200)]
staging: unisys: Remove typedef and rename struct to lowercase
Remove typedef and rename struct to lowercase (ultra_segment_state) in unisys
Signed-off-by: Veronika Kabátová <veronicca114@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Tue, 7 Oct 2014 12:58:48 +0000 (15:58 +0300)]
staging: octeon: Fix warning of prefer ether_addr_copy.
This patch fixes the following checkpatch.pl warnings:
WARNING: "Prefer ether_addr_copy() over memcpy() if the Ethernet
addresses are __aligned(2)" in file ethernet.c
Pahole shows that the addresses are aligned.
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sarah Khan [Tue, 7 Oct 2014 01:03:54 +0000 (06:33 +0530)]
staging: octeon-usb: Removed unnessecary else after return
WARNING: else is generally not useful after return or break
checkpatch.pl warning in octeon-hcd.c
Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Esra Altintas [Tue, 7 Oct 2014 19:45:55 +0000 (22:45 +0300)]
staging: speakup: remove jiffies comparison using time_after_eq() in speakup_dtlk.c
The following patch fixes the checkpatch.pl warning:
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends
Signed-off-by: Esra Altintas <es.altintas@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Tue, 7 Oct 2014 07:59:18 +0000 (10:59 +0300)]
staging: speakup: Change char * array type as static const
This patch fixes "char * array declaration might be better as static
const" checkpatch.pl warning in main.c
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Sat, 4 Oct 2014 10:36:27 +0000 (13:36 +0300)]
staging: speakup: Change char * array type as static const
This patch fixes "char * array declaration might be better as static const"
checkpatch.pl warning in kobjects.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yeliz Taneroglu [Fri, 3 Oct 2014 11:04:25 +0000 (14:04 +0300)]
staging: speakup: Fixed else after return or break warning
The following patch fixes the checkpatch.pl warning:
drivers/staging/speakup/kobjects.c:812 warning: else is not generally useful after a break or return
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Fri, 3 Oct 2014 10:23:00 +0000 (13:23 +0300)]
staging: gs_fpgaboot: remove unnecessary 'out of memory' message
This patch fixes "Possible unnecessary 'out of memory' message"
checkpatch.pl warning in gs_fpgaboot.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 13:09:47 +0000 (18:39 +0530)]
Staging: rtl8188eu: core: Remove variable that is not very useful.
The following patch removes a variable which is not very useful using
coccinelle.
The following semaintic patch was used:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mahati Chamarthy [Mon, 6 Oct 2014 16:37:17 +0000 (22:07 +0530)]
Staging: rtl8188eu: include: Remove unused macros
This patch removes macros that are never used.
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:57:21 +0000 (11:27 +0530)]
staging: rtl8188eu: core: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mahati Chamarthy [Sat, 4 Oct 2014 16:27:02 +0000 (21:57 +0530)]
Staging: rtl8188eu: include: Remove unnecessary macro
This patch removes a macro which is not used anywhere except in the header
file. The existing usage in the header file is replaced with the actual value.
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Fri, 3 Oct 2014 10:08:21 +0000 (13:08 +0300)]
staging: rtl8188eu: Fix prefer ether_addr_copy() over memcpy()
This patch fixes "Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)" in rtw_ap.c
Pahole showed that the addresses are aligned.
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 09:16:30 +0000 (14:46 +0530)]
Staging: rtl8723au: core: Removed variable that is always 0.
The following patch removes a variable that is always 0 using
coccinelle.
The following semantic patch was used:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 09:15:56 +0000 (14:45 +0530)]
Staging: rtl8723au: os_dep: Removed variable that is always 0.
The following patch removes a variable that is always 0 using
coccinelle.
The semaintic patch used is as follows:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mahati Chamarthy [Sun, 5 Oct 2014 07:41:39 +0000 (13:11 +0530)]
Staging: rtl8723au: include: Remove unnecessary macro
This patch removes a macro which is not used anywhere except in the header
file. Existing usage in the header file is replaced with the actual value.
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Sat, 4 Oct 2014 22:41:58 +0000 (01:41 +0300)]
staging: rtl8723au: include: fix space prohibited before
Fix checkpatch.pl issues with space prohibited before semicolon in
Hal8723UHWImg_CE.h
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 08:53:18 +0000 (14:23 +0530)]
staging: rtl8712: Delete explicit comparison with false and NULL
This patch delete explicit comparison to false and NULL in files of
rtl8712.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sarah Khan [Fri, 3 Oct 2014 14:03:39 +0000 (19:33 +0530)]
staging: rtl8712: Fixed else not required after return
WARNING: else is generally not required after return
checkpatch.pl warning in osdep_service.h
Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:57:30 +0000 (11:27 +0530)]
staging: rtl8712: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tina Johnson [Tue, 7 Oct 2014 19:12:06 +0000 (00:42 +0530)]
Staging: lustre: Fix checkpatch warning: Unnecessary braces
The following checkpatch warning was fixed :
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Tina Johnson <tinajohnson.1234@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tina Johnson [Tue, 7 Oct 2014 19:12:05 +0000 (00:42 +0530)]
Staging: lustre: Fix checkpatch warning: Missing blank line
The following checkpatch warning was fixed :
WARNING: Missing a blank line after declarations
Signed-off-by: Tina Johnson <tinajohnson.1234@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:59:11 +0000 (17:29 +0530)]
Staging: lustre: lustre: osc: Changed the return code of a function from int to void.
The following patch changes the return code of a function from int to void
as the return value was not used by the callers.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Reviewed-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:58:30 +0000 (17:28 +0530)]
Staging: lustre: lustre: osc: Remove variable that is not very useful.
The following patch removes a variable that is not very useful using
coccinelle.
The semantic patch used was:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:57:54 +0000 (17:27 +0530)]
Staging: lustre: lustre: osc: Remove variable that is not very useful.
The following patch removes a variable that is not very useful using
coccinelle.
The semantic patch used was:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:57:18 +0000 (17:27 +0530)]
Staging: lustre: lustre: lov: Remove variable that is not very useful.
The following patch removes a variable that is not very useful using
coccinelle.
The semantic patch used was:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:56:47 +0000 (17:26 +0530)]
Staging: lustre: lustre: mgc: Remove variable that is not very useful.
The following patch removes a variable that is not very useful using
coccinelle.
The semantic patch used was:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:56:14 +0000 (17:26 +0530)]
Staging: lustre: lustre: lmv: Removed variable that is not very useful.
The following patch removes a variable that is not very useful using
coccinelle.
The semantic patch used was:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:57:00 +0000 (11:27 +0530)]
staging: lustre: lustre: llite: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kumari Radha [Sun, 5 Oct 2014 14:52:54 +0000 (20:22 +0530)]
staging: lustre: lustre: obdclass: Added missing line after declaration
Added missing line after declaration fixing the following checkpatch.pl warning in dt_object.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Kumari Radha <kumari.radha3@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:57:10 +0000 (11:27 +0530)]
staging: lustre: lustre: ptlrpc: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Sun, 5 Oct 2014 11:58:18 +0000 (17:28 +0530)]
Staging: lustre: Remove non-standard spinlock macro definitions
This patch removes non-standard spinlock's macros as they are no longer
used by this driver.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Sun, 5 Oct 2014 11:58:12 +0000 (17:28 +0530)]
Staging: lustre: Replace non-standard spinlock macro definations
This patch replaces non-standard spin lock macro with standard linux function.
This is done using Coccinelle and semantic patch used is as follows:
@@
expression x;
@@
- TREE_READ_LOCK_IRQ(x)
+ spin_lock_irq(&(x)->tree_lock)
@@
expression x;
@@
- TREE_READ_UNLOCK_IRQ(x)
+ spin_unlock_irq(&(x)->tree_lock)
Also semantic patch result is modified by droping ->,
inner & and adding . for simplification of code.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Sun, 5 Oct 2014 11:58:06 +0000 (17:28 +0530)]
Staging: lustre: Replace non-standard spin-lock's macro
This patch replaces non-standard spin lock macro with standard linux function.
This is done using Coccinelle and semantic patch used is as follows:
@@
expression x;
@@
- TREE_READ_LOCK_IRQ(x)
+ spin_lock_irq(&x->tree_lock)
@@
expression x;
@@
- TREE_READ_UNLOCK_IRQ(x)
+ spin_unlock_irq(&x->tree_lock)
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Fri, 3 Oct 2014 05:16:09 +0000 (10:46 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it is not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_server_handle' was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Fri, 3 Oct 2014 05:15:38 +0000 (10:45 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it is not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_bulk_ready' was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Fri, 3 Oct 2014 05:14:58 +0000 (10:44 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it is not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_server_rpc_done' was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Fri, 3 Oct 2014 05:14:25 +0000 (10:44 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it is not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_check_bulk' was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Fri, 3 Oct 2014 03:57:18 +0000 (09:27 +0530)]
Staging: lustre: lnet: Declare ping_srv_workitems static
This patch makes ping_srv_workitems static as it is
used only in the file ping_test.c
This problem is detected by sparse.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Darshana Padmadas [Sat, 4 Oct 2014 16:25:27 +0000 (21:55 +0530)]
Staging: iio: trigger: Break line over 80 characters
This patch breaks a line that is over 80 characters as reported by checkpatch.pl
Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Darshana Padmadas [Sat, 4 Oct 2014 16:25:26 +0000 (21:55 +0530)]
Staging: iio: trigger: Add module name information in Kconfig
This patch updates Kconfig with paragraphs that describe config symbol fully.
Found using checkpatch.pl.
Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 11:34:43 +0000 (17:04 +0530)]
Staging: iio: Documentation: Added check for sscanf return value.
The following patch fixes the following checkpatch.pl warning by adding
a check for sscanf return value.
WARNING: unchecked sscanf return value.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 11:34:10 +0000 (17:04 +0530)]
Staging: iio: Documentation: Simplify error handling.
This also has the nice effect of removing of a temporary variable from stack and
fixes the following checkpatch.pl warning:
WARNING: Missing blank line after declarations.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 11:33:31 +0000 (17:03 +0530)]
Staging: iio: Documentation: Added missing blank line after declarations.
The following patch fixes the following checkpatch.pl warning by adding
a blank line after declarations.
WARNING: Missing blank line after declarations.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Sat, 4 Oct 2014 14:24:25 +0000 (19:54 +0530)]
staging: iio: accel: Update Kconfig description with module name information
This patch fixes checkpatch.pl warning.
WARNING: please write a paragraph that describes the config symbol fully
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Sat, 4 Oct 2014 13:09:53 +0000 (18:39 +0530)]
Staging: iio: gyro: Added description for config symbol.
The following patch fixes the checkpatch.pl warning by adding
description for a config symbol.
WARNING: please write a paragraph that describes the config symbol
fully.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roxana Blaj [Mon, 6 Oct 2014 21:18:48 +0000 (00:18 +0300)]
staging: iio: addac: annotate Kconfig entries with module name information
This fixes the checkpatch.pl warning:
WARNING: please write a paragraph that describes the config symbol fully
Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roxana Blaj [Sat, 4 Oct 2014 11:26:13 +0000 (14:26 +0300)]
staging: iio: addac: fix line over 80 characters
This fixes checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Fri, 3 Oct 2014 20:35:54 +0000 (23:35 +0300)]
staging: iio: Fix missing blank line warning
Fixes "Missing a blank line after declarations" checkpatch.pl warning in
Documentation/iio_utils.h
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Fri, 3 Oct 2014 20:34:50 +0000 (23:34 +0300)]
staging: iio: Fix missing blank line warning
Fixes "Missing a blank line after declarations" checkpatch.pl warning in
Documentation/generic_buffer.c
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Darshana Padmadas [Fri, 3 Oct 2014 13:57:29 +0000 (19:27 +0530)]
Staging: iio: meter: Kconfig: Add module name information in Kconfig
This patch updates Kconfig with paragraphs that describe config symbol fully.
Found using checkpatch.pl.
Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roberta Dobrescu [Fri, 3 Oct 2014 12:02:48 +0000 (15:02 +0300)]
staging: iio: light: Remove unnecessary line continuations
This fixes the following checkpatch.pl warning:
WARNING: Avoid unnecessary line continuations
Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Mon, 6 Oct 2014 09:41:06 +0000 (15:11 +0530)]
Staging: iio: adc: Fixing line over 80 characters
This patch fixes the following checkpatch.pl warning:
WARNING: line over 80 charcaters
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Mon, 6 Oct 2014 09:40:25 +0000 (15:10 +0530)]
Staging: iio: adc: Fix line over 80 characters
This patch fixes the following checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Fri, 3 Oct 2014 03:46:53 +0000 (09:16 +0530)]
Staging: iio: adc: Refine delay computation
As per comment in function ad7280_delay, conversion delay may take up
to 250us. We cannot rely on msleep for this because it may sleep longer
than intended time for values less than 20ms, so use usleep_range instead.
Problem detected using checkpatch.pl.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Sat, 4 Oct 2014 22:26:47 +0000 (01:26 +0300)]
staging: rts5208: Delete braces are not necessary
Fix checkpatch.pl warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:57:50 +0000 (11:27 +0530)]
staging: unisys: virtpci: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:57:39 +0000 (11:27 +0530)]
staging: unisys: common-spar: include: channels: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:23 +0000 (14:09 -0400)]
staging: unisys: remove unused vmcall functions from uisutils.h
Delete the issue_vmcall_measurement_do_nothing() and
issue_vmcall_fatal() functions, because they are unused.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:22 +0000 (14:09 -0400)]
staging: unisys: remove unused fields from iopart structures
The bus_no and dev_no fields in several of the iopart command parameter
structures are unused. Remove them.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:21 +0000 (14:09 -0400)]
staging: unisys: remove unused struct network_policy
Nobody is using this structure, so remove it.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:20 +0000 (14:09 -0400)]
staging: unisys: remove redundant max macro
No need to have another max macro when the kernel has one already.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:19 +0000 (14:09 -0400)]
staging: unisys: remove old doxygen comments from timskmod.h
Remove doxygen comments and fix what's left so it's still useful.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:18 +0000 (14:09 -0400)]
staging: unisys: Fix ULTRA_VBUS_DEVICEINFO
Remove the typedef from ULTRA_VBUS_DEVICEINFO and use struct
ultra_vbus_deviceinfo instead. Fix CamelCase member names:
devType => devtype
drvName => drvname
infoStrings => infostrs
Fix indentation on function definitions that were affected by the
structure's name change.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:17 +0000 (14:09 -0400)]
staging: unisys: Fix VMCALL_CHANNEL_VERSION_MISMATCH_PARAMS
Get rid of the typedef for VMCALL_CHANNEL_VERSION_MISMATCH_PARAMS, and
use the name struct vmcall_channel_version_mismatch_params instead. Fix
CamelCase member names:
ChannelName => chname
ItemName => item_name
SourceFileName => file_name
SourceLineNumber => line_no
And get rid of the lengthof macro in issue_vmcall_channel_mismatch().
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:16 +0000 (14:09 -0400)]
staging: unisys: remove volatile from struct log_info_t
There's no need for last_cycles to be declared volatile. Take that out.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:15 +0000 (14:09 -0400)]
staging: unisys: fix VMCALL_IO_VISORSERIAL_ADDR_PARAMS
Remove the typedef from VMCALL_IO_VISORSERIAL_ADDR_PARAMS and use the
name struct vmcall_io_visorserial_addr_params instead. Fix CamelCase
member names:
ChannelAddress => address
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:14 +0000 (14:09 -0400)]
staging: unisys: Fix VMCALL_IO_DIAG_ADDR_PARAMS
Remove the typedef from VMCALL_IO_DIAG_ADDR_PARAMS and use the name
struct vmcall_io_diag_addr_params instead. Fix CamelCase member names:
ChannelAddress => address
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:13 +0000 (14:09 -0400)]
staging: unisys: Fix VMCALL_IO_CONTROLVM_ADDR_PARAMS structure
Remove the typedef from VMCALL_IO_CONTROLVM_ADDR_PARAMS and switch to
use struct vmcall_io_controlvm_addr_params. Fix the CamelCase names:
ChannelAddress => address
ChannelBytes => channel_bytes
Unused => unused
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:12 +0000 (14:09 -0400)]
staging: unisys: fix typedef of ULTRA_VBUS_CHANNEL_PROTOCOL
Get rid of the typedef ULTRA_VBUS_CHANNEL_PROTOCOL, in favor of the name
struct ultra_vbus_channel_protocol. This change finishes the warnings
clean up for include/uisqueue.h.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:11 +0000 (14:09 -0400)]
staging: unisys: remove DEDICATED_SWITCH macro
Nobody is using this macro anymore so remove it.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:10 +0000 (14:09 -0400)]
staging: unisys: fix CamelCase name for struct InterruptInfo
Fix CamelCase names:
InterruptInfo => irq_info
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:09 +0000 (14:09 -0400)]
staging: unisys: fix CamelCase struct name PciId
Fix CamelCase name:
PciId => pci_id
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:08 +0000 (14:09 -0400)]
staging: unisys: fix CamelCase in uislib_client_inject_del_vnic()
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:07 +0000 (14:09 -0400)]
staging: unisys: Fix CamelCase in uislib_client_inject_resume_vnic()
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:06 +0000 (14:09 -0400)]
staging: unisys: Fix CamelCase in uislib_client_inject_pause_vnic()
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:05 +0000 (14:09 -0400)]
staging: unisys: Fix CamelCase in uislib_client_inject_add_vnic()
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
instGuid => inst_uuid
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:04 +0000 (14:09 -0400)]
staging: unisys: Fix CamelCase in uislib_client_inject_del_vhba()
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:03 +0000 (14:09 -0400)]
staging: unisys: Fix CamelCase in uislib_client_inject_resume_vhba()
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:02 +0000 (14:09 -0400)]
staging: unisys: Fix CamelCase in uislib_client_inject_pause_vhba()
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:01 +0000 (14:09 -0400)]
staging: unisys: Fix CamelCase in uislib_client_inject_add_vhba()
Clean up CamelCase names:
busNo => bus_no
devNo => dev_no
instGuid => inst_uuid
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:09:00 +0000 (14:09 -0400)]
staging: unisys: fix CamelCase in uislib_client_inject_del_bus()
Fix CamelCase names:
busNo => bus_no
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:59 +0000 (14:08 -0400)]
staging: unisys: Fix CamelCase in uislib_client_inject_add_bus()
Fix CamelCase names:
busNo => bus_no
instGuid => inst_uuid
channelAddr => channel_addr
nChannelBytes => n_channel_bytes
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:58 +0000 (14:08 -0400)]
staging: unisys: remove uislib_server_inject_add/del_vnic() prototypes
These functions contain CamelCase names but are not used. Delete the
prototypes from uisutils.h.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:57 +0000 (14:08 -0400)]
staging: unisys: fix CamelCase in uisctrl_unregister_req_handler_ex
Fix CamelCase names:
switchTypeGuid => switch_uuid
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:56 +0000 (14:08 -0400)]
staging: unisys: fix CamelCase in uisctrl_register_req_handler_ex
Fix CamelCase names:
switchTypeGuid => switch_uuid
clientStr => client_str
clientStrLent => client_str_len
chipset_driverInfo => chipset_driver_info
Server_Channel_Ok => server_channel_ok
Server_Channel_Init => server_channel_init
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:55 +0000 (14:08 -0400)]
staging: unisys: fix indentation in req_handler_info
Fix the indentation around server_channel_init, so the parameters line
up nicely.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:54 +0000 (14:08 -0400)]
staging: unisys: fix CamelCase in ReqHandlerDel
Fix CamelCase names:
ReqHandlerDel => req_handler_del
switchTypeGuid => switch_uuid
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:53 +0000 (14:08 -0400)]
staging: unisys: fix CamelCase in ReqHandlerFind()
Fix CamelCase names:
ReqHandlerFind => req_handler_find
switchTypeGuid => switch_uuid
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:52 +0000 (14:08 -0400)]
staging: unisys: fix CamelCase names in ReqHandlerAdd()
Fix CamelCase names:
ReqHandlerAdd => req_handler_add
Server_Channel_Ok => svr_channel_ok
channelBytes => channel_bytes
Server_Channel_Init => svr_channel_init
clientStr => client_str
ClientStrLen => client_str_len
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:51 +0000 (14:08 -0400)]
staging: unisys: fix CamelCase in struct req_handler_info
Fix CamelCase names:
switchTypeGuid => switch_uuid
Server_Channel_Ok => server_channel_ok
channelBytes => channel_bytes
Server_Channel_Init => server_channel_init
clientStr => client_str
clientStrLen => client_str_len
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:50 +0000 (14:08 -0400)]
staging: unisys: remove typedef ReqHandlerInfo_t
Convert all references to the typedef to struct req_handler_info.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:49 +0000 (14:08 -0400)]
staging: unisys: get rid of MACARRAY typedef
Remove the MACARRAY typedef entirely and switch over to u8*[ETH_ALEN],
like everybody else seems to use.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:48 +0000 (14:08 -0400)]
staging: unisys: fix CamelCase name for registered services variable
Fix CamelCase names:
UisUtils_Registered_Services => uisutils_registered_services
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:47 +0000 (14:08 -0400)]
staging: unisys: Fix CamelCase function pointers in uisutils
Fix CamelCase names:
UisnicControlChanFunc => uisnic_control_chan_func
UissdControlChanFunc => uissd_control_chan_func
VirtControlChanFunc => virt_control_chan_func
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 3 Oct 2014 18:08:46 +0000 (14:08 -0400)]
staging: unisys: fix CamelCase in struct add_vbus_guestpart
Clean up CamelCase names:
busNo => bus_no
deviceCount => dev_count
busTypeGuid => bus_uuid
busInstGuid => instance_guid
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>