OSDN Git Service
Brad [Mon, 28 Mar 2011 01:05:22 +0000 (21:05 -0400)]
patcheck: Allow overiding grep program(s) through environment variables.
patcheck hardcodes the binary names for grep/egrep. This makes overriding the
binary names a pain, e.g. when calling a GNU version of grep on BSD systems.
Signed-off-by: Diego Biurrun <diego@biurrun.de>
Diego Biurrun [Sat, 23 Apr 2011 12:14:22 +0000 (14:14 +0200)]
Remove stray libavcore and _g binary references.
Diego Biurrun [Sun, 17 Apr 2011 17:44:33 +0000 (19:44 +0200)]
vorbis: Rename decoder/encoder files to follow general file naming scheme.
Nathan Caldwell [Tue, 5 Apr 2011 07:05:24 +0000 (01:05 -0600)]
aacenc: Fix whitespace after last commit.
Signed-off-by: Martin Storsjö <martin@martin.st>
Diego Biurrun [Sat, 23 Apr 2011 00:02:42 +0000 (02:02 +0200)]
cook: Fix small typo in av_log_ask_for_sample message.
Nathan Caldwell [Wed, 5 Jan 2011 08:32:16 +0000 (01:32 -0700)]
aacenc: Finish 3GPP psymodel analysis for non mid/side cases.
There is still are still a few sections missing relating to TNS (not present)
and mid/side (contains other bugs).
Overall this improves quality, and vastly improves rate-control.
Signed-off-by: Martin Storsjö <martin@martin.st>
Alex Converse [Thu, 21 Apr 2011 18:39:04 +0000 (18:39 +0000)]
Remove RDFT dependency from AAC decoder.
$subj
>From
557176d961c70604c2a96d81aff4bd6faa670d8a Mon Sep 17 00:00:00 2001
From: Alex Converse <aconverse@google.com>
Date: Thu, 21 Apr 2011 12:11:42 -0700
Subject: [PATCH] Remove RDFT dependency from AAC decoder.
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------1"
This is a multi-part message in MIME format.
--------------1
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit
It was used for an old implementation of the SBR filterbank.
./configure --disable-everything --disable-ffplay --enable-decoder=aac works.
Alex Converse [Wed, 20 Apr 2011 17:47:28 +0000 (17:47 +0000)]
Add some debug log messages to AAC extradata
On Wed, Apr 20, 2011 at 11:39 AM, Justin Ruggles
<justin.ruggles@gmail.com> wrote:
> On 04/20/2011 02:26 PM, Alex Converse wrote:
>
>> ---
>> libavcodec/aacdec.c | 10 +++++++++-
>> 1 files changed, 9 insertions(+), 1 deletions(-)
>>
>>
>>
>> 0002-Add-some-Debug-log-messages-to-AAC-extradata.patch
>>
>>
>> diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c
>> index
c9761a1..
3ec274f 100644
>> --- a/libavcodec/aacdec.c
>> +++ b/libavcodec/aacdec.c
>> @@ -79,7 +79,6 @@
>> Parametric Stereo.
>> */
>>
>> -
>> #include "avcodec.h"
>> #include "internal.h"
>> #include "get_bits.h"
>
>
> stray whitespace change
>
oops, fixed
>From
94e8d0eea77480630f84368c97646cabc0f50628 Mon Sep 17 00:00:00 2001
From: Alex Converse <aconverse@google.com>
Date: Wed, 20 Apr 2011 11:23:34 -0700
Subject: [PATCH] Add some debug log messages to AAC extradata
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------1"
This is a multi-part message in MIME format.
--------------1
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit
Alex Converse [Wed, 20 Apr 2011 17:25:47 +0000 (17:25 +0000)]
Fix mov debug (u)int64_t format strings.
Jason Garrett-Glaser [Fri, 22 Apr 2011 21:59:55 +0000 (17:59 -0400)]
bswap: use native types for av_bwap16().
This prevents a call to bytestream_get_be16() using a movzwl both before
and after the ror instruction, which is obviously inefficient. Arm uses
the same trick also.
Sintel decoding goes from (avg+SD) 9.856 +/- 0.003 to 9.797 +/- 0.003 sec.
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
Carl Eugen Hoyos [Fri, 22 Apr 2011 17:24:17 +0000 (19:24 +0200)]
doc: FLV muxing is supported.
Signed-off-by: Martin Storsjö <martin@martin.st>
Martin Storsjö [Sun, 23 Jan 2011 21:42:18 +0000 (23:42 +0200)]
applehttp: Handle AES-128 encrypted streams
This should hopefully fix roundup issue 2586.
This commit only implements it in the demuxer, not in the
protocol handler. If desired, some of the code could be
refactored to be shared by both implementations.
Signed-off-by: Martin Storsjö <martin@martin.st>
Martin Storsjö [Sat, 22 Jan 2011 23:31:41 +0000 (01:31 +0200)]
Add a protocol handler for AES CBC decryption with PKCS7 padding
This can later be extended to support other AES bit sizes,
encryption, other crypto algorithms, reading the key from a URL, etc.
In order to use it, the key and initialization vector has to be
passed via AVOptions. Since such options can't be passed to
protocols from the command line, the protocol is currently
only for libavformat internal use.
Signed-off-by: Martin Storsjö <martin@martin.st>
Martin Storsjö [Thu, 21 Apr 2011 21:45:06 +0000 (00:45 +0300)]
doc: Mention that DragonFly BSD requires __BSD_VISIBLE set
Setting this should fix the FATE build failure on DragonFly BSD,
since inet_aton only is visible if __BSD_VISIBLE is set.
Alternatively, a line defining __BSD_VISIBLE=1 could be
added at the top of os_support.c. For FreeBSD, similar lines
are required in libavdevice/bktr.c and libavdevice/oss_audio.c, too.
Signed-off-by: Martin Storsjö <martin@martin.st>
Diego Biurrun [Fri, 22 Apr 2011 17:41:59 +0000 (19:41 +0200)]
Use av_log_ask_for_sample() to request samples from users.
Diego Biurrun [Fri, 22 Apr 2011 17:30:25 +0000 (19:30 +0200)]
Make av_log_ask_for_sample() accept a variable number of arguments.
Diego Biurrun [Fri, 22 Apr 2011 17:46:54 +0000 (19:46 +0200)]
vqavideo: We no longer need to ask for version 1 samples.
Young Han Lee [Fri, 22 Apr 2011 12:39:56 +0000 (21:39 +0900)]
aacdec: indentation cosmetics
Signed-off-by: Diego Biurrun <diego@biurrun.de>
Ronald S. Bultje [Thu, 21 Apr 2011 23:50:19 +0000 (19:50 -0400)]
APIChanges: document git revision for CODEC_CAP_SLICE_THREADS addition.
Ronald S. Bultje [Wed, 20 Apr 2011 18:14:42 +0000 (14:14 -0400)]
Introduce slice threads flag.
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
Ronald S. Bultje [Wed, 20 Apr 2011 17:12:38 +0000 (13:12 -0400)]
FATE: allow forcing thread-type when doing threaded fate runs.
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
Diego Biurrun [Thu, 21 Apr 2011 17:38:49 +0000 (19:38 +0200)]
Use av_log_ask_for_sample() where appropriate.
Stefano Sabatini [Thu, 21 Apr 2011 11:36:12 +0000 (13:36 +0200)]
error: sort, pack, and align error code and string definitions
Signed-off-by: Diego Biurrun <diego@biurrun.de>
Diego Biurrun [Thu, 21 Apr 2011 13:56:55 +0000 (15:56 +0200)]
The stabilization period after version bumps should be one month, not one week.
Martin Storsjö [Wed, 20 Apr 2011 07:10:10 +0000 (10:10 +0300)]
applehttp: Expose the stream bitrate via metadata
This helps callers to intelligently switch between bitrate
variants.
Signed-off-by: Martin Storsjö <martin@martin.st>
Martin Storsjö [Wed, 20 Apr 2011 20:04:31 +0000 (23:04 +0300)]
doc: Add some initial docs on the applehttp demuxer
Signed-off-by: Martin Storsjö <martin@martin.st>
Martin Storsjö [Thu, 21 Apr 2011 11:02:38 +0000 (13:02 +0200)]
Provide a fallback version of the libm function trunc
This fixes compilation on DOS.
Signed-off-by: Martin Storsjö <martin@martin.st>
Martin Storsjö [Thu, 21 Apr 2011 10:49:21 +0000 (13:49 +0300)]
libavdevice: Define _XOPEN_SOURCE for usleep
This hopefully fixes build failures on Dragonfly BSD.
Signed-off-by: Martin Storsjö <martin@martin.st>
Anton Khirnov [Wed, 20 Apr 2011 15:21:39 +0000 (17:21 +0200)]
lavc: provide deprecated avcodec_thread_init until next major version
It was deprecated only recently.
Anton Khirnov [Wed, 20 Apr 2011 15:09:45 +0000 (17:09 +0200)]
lavc: provide the opt.h header until the next bump
AVOptions were moved to libavutil only recently.
Anton Khirnov [Wed, 20 Apr 2011 05:14:50 +0000 (07:14 +0200)]
error: change AVERROR_EOF value
The current value is masking the POSIX error code EPIPE, which has a
different semantics.
This breaks API.
Signed-off-by: Stefano Sabatini <stefano.sabatini-lala@poste.it>
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Stefano Sabatini [Sun, 10 Apr 2011 22:29:30 +0000 (00:29 +0200)]
error: remove AVERROR_NUMEXPECTED
AVERROR_NUMEXPECTED is used only in the image muxer and demuxer, and
has a too much specific meaning, which is better explained through a
log message. Thus it can be replaced by AVERROR(EINVAL).
This breaks API.
Signed-off-by: Stefano Sabatini <stefano.sabatini-lala@poste.it>
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Stefano Sabatini [Sun, 10 Apr 2011 22:52:04 +0000 (00:52 +0200)]
error: add error code AVERROR_OPTION_NOT_FOUND, and use it in opt.c
The new error code is better than AVERROR(ENOENT), which has a
completely different semantics ("No such file or directory").
Signed-off-by: Stefano Sabatini <stefano.sabatini-lala@poste.it>
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Martin Storsjö [Wed, 20 Apr 2011 18:22:08 +0000 (21:22 +0300)]
Makefile: Include dependencies for test tools, too
This makes seek_test to be rebuilt when its dependencies
has changed. The changes to the dependencies didn't usually matter
in practice, but the introduction of side data in AVPacket required
a recompilation.
Signed-off-by: Martin Storsjö <martin@martin.st>
Diego Biurrun [Wed, 20 Apr 2011 15:18:27 +0000 (17:18 +0200)]
Remove a version check in av_log made unnecessary by the big bump.
Justin Ruggles [Tue, 19 Apr 2011 23:37:29 +0000 (19:37 -0400)]
update last major version increase dates in APIchanges
Michael Niedermayer [Wed, 23 Mar 2011 04:31:01 +0000 (04:31 +0000)]
Reduce picture size for yadif.
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Michael Niedermayer [Tue, 12 Apr 2011 04:22:31 +0000 (04:22 +0000)]
oggdec: use av_freep() instead of av_free()
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Martin Storsjö [Wed, 20 Apr 2011 14:09:46 +0000 (17:09 +0300)]
avio: Fix sanity checks in ffurl_read*
This fixes e.g. reading data over HTTP, where the underlying
socket is set to read/write.
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Martin Storsjö [Wed, 20 Apr 2011 09:03:55 +0000 (12:03 +0300)]
libavformat: Free AVFormatContext->streams
After switching this from a statically allocated array to a
dynamically allocated one in the major bump, this needs explicit
freeing.
Signed-off-by: Martin Storsjö <martin@martin.st>
Martin Storsjö [Wed, 20 Apr 2011 09:40:29 +0000 (11:40 +0200)]
libavformat: Make protocols pass URLContext as log context where available
Since the libavformat major bump, URLContext contains an AVClass,
making it a usable log context.
Signed-off-by: Martin Storsjö <martin@martin.st>
Vladimir Pantelic [Wed, 20 Apr 2011 10:31:10 +0000 (12:31 +0200)]
asf: remove commented out code in asf_read_seek
Signed-off-by: Mans Rullgard <mans@mansr.com>
Diego Biurrun [Tue, 19 Apr 2011 19:53:48 +0000 (21:53 +0200)]
libpostproc: Remove crufty code disabled by the big bump.
Reinhard Tartler [Tue, 19 Apr 2011 17:48:44 +0000 (19:48 +0200)]
Reflect 0.7_beta1 release in the Changelog
Anton Khirnov [Tue, 19 Apr 2011 19:25:10 +0000 (21:25 +0200)]
sws: remove disabled cruft.
Anton Khirnov [Tue, 19 Apr 2011 19:21:44 +0000 (21:21 +0200)]
lavu: remove disabled ff_random_get_seed cruft.
Anton Khirnov [Tue, 19 Apr 2011 19:16:35 +0000 (21:16 +0200)]
lavu: remove disabled sha1 cruft.
Justin Ruggles [Sun, 17 Apr 2011 20:57:55 +0000 (16:57 -0400)]
In avcodec_open(), set return code to an error value only when an error occurs
instead of unconditionally at the start of the function.
This fixes a bug where a successful call to ff_thread_init() masks errors that
occur after that point in the function. It also makes future bugs like this
less likely since the error code is now set near to the point in the code
where the error is found.
Anton Khirnov [Tue, 19 Apr 2011 17:50:23 +0000 (19:50 +0200)]
lavc: remove reference to opt.h from Makefile.
Fixes make install after
3453a231a6cebe5989c213be0f9fd6c71ec5ea23.
Stefano Sabatini [Fri, 8 Apr 2011 23:32:37 +0000 (01:32 +0200)]
prefer avio_check() over url_exist()
The problem with url_exist() is that it tries to open a resource in
RDONLY mode. If the file is a FIFO and there is already a reading
client, the open() call will hang.
By using avio_check() with access mode of 0, the second reading
process will check if the file exists without attempting to open it,
thus avoiding the lock.
Fix issue #1663.
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Stefano Sabatini [Fri, 15 Apr 2011 14:42:09 +0000 (16:42 +0200)]
avio: remove AVIO_* access symbols in favor of new AVIO_FLAG_* symbols
Make AVIO_FLAG_ access constants work as flags, and in particular fix
the behavior of functions (such as avio_check()) which expect them to
be flags rather than modes.
This breaks API.
Anton Khirnov [Tue, 12 Apr 2011 19:17:26 +0000 (21:17 +0200)]
lavu: remove misc disabled cruft
Anton Khirnov [Tue, 12 Apr 2011 19:11:15 +0000 (21:11 +0200)]
lavu: remove FF_API_OLD_IMAGE_NAMES cruft
Anton Khirnov [Tue, 12 Apr 2011 18:57:07 +0000 (20:57 +0200)]
lavu: remove FF_API_OLD_EVAL_NAMES cruft
Anton Khirnov [Tue, 12 Apr 2011 18:46:49 +0000 (20:46 +0200)]
lavc: remove misc disabled cruft.
Anton Khirnov [Thu, 3 Feb 2011 14:00:50 +0000 (15:00 +0100)]
lavc: remove the FF_API_INOFFICIAL cruft.
Anton Khirnov [Thu, 3 Feb 2011 13:58:59 +0000 (14:58 +0100)]
lavc: remove the FF_API_SET_STRING_OLD cruft.
Anton Khirnov [Thu, 3 Feb 2011 13:51:50 +0000 (14:51 +0100)]
lavc: remove the FF_API_USE_LPC cruft.
Anton Khirnov [Thu, 3 Feb 2011 13:50:06 +0000 (14:50 +0100)]
lavc: remove the FF_API_SUBTITLE_OLD cruft.
Anton Khirnov [Thu, 3 Feb 2011 13:48:39 +0000 (14:48 +0100)]
lavc: remove the FF_API_VIDEO_OLD cruft.
Anton Khirnov [Thu, 3 Feb 2011 13:48:00 +0000 (14:48 +0100)]
lavc: remove the FF_API_AUDIO_OLD cruft.
Anton Khirnov [Thu, 3 Feb 2011 13:45:22 +0000 (14:45 +0100)]
lavc: remove the FF_API_OPT_SHOW cruft.
Anton Khirnov [Thu, 3 Feb 2011 13:43:53 +0000 (14:43 +0100)]
lavc: remove the FF_API_MM_FLAGS cruft.
Anton Khirnov [Wed, 13 Apr 2011 06:01:49 +0000 (08:01 +0200)]
lavf: remove misc disabled cruft.
Anton Khirnov [Tue, 12 Apr 2011 18:10:10 +0000 (20:10 +0200)]
lavf: remove FF_API_INDEX_BUILT cruft
Anton Khirnov [Thu, 3 Feb 2011 11:53:28 +0000 (12:53 +0100)]
lavf: remove FF_API_URL_CLASS cruft.
Anton Khirnov [Thu, 3 Feb 2011 11:49:12 +0000 (12:49 +0100)]
lavf: remove FF_API_SYMVER cruft
Anton Khirnov [Thu, 3 Feb 2011 11:47:18 +0000 (12:47 +0100)]
lavf: remove FF_API_FIRST_FORMAT cruft
Anton Khirnov [Thu, 3 Feb 2011 11:46:12 +0000 (12:46 +0100)]
lavf: remove FF_API_PARAMETERS_CODEC_ID cruft
Anton Khirnov [Thu, 3 Feb 2011 11:45:30 +0000 (12:45 +0100)]
lavf: remove FF_API_LAVF_UNUSED cruft
Anton Khirnov [Thu, 3 Feb 2011 11:44:04 +0000 (12:44 +0100)]
lavf: remove FF_API_PARSE_FRAME_PARAM cruft
Anton Khirnov [Thu, 3 Feb 2011 11:42:38 +0000 (12:42 +0100)]
lavf: remove FF_API_ALLOC_FORMAT_CONTEXT cruft
Anton Khirnov [Thu, 3 Feb 2011 11:40:25 +0000 (12:40 +0100)]
lavf: remove FF_API_URL_SPLIT cruft
Anton Khirnov [Thu, 3 Feb 2011 11:39:11 +0000 (12:39 +0100)]
lavf: remove FF_API_UDP_GET_FILE cruft
Anton Khirnov [Thu, 3 Feb 2011 11:38:05 +0000 (12:38 +0100)]
lavf: remove FF_API_GUESS_FORMAT cruft
Anton Khirnov [Thu, 3 Feb 2011 11:36:18 +0000 (12:36 +0100)]
lavf: remove FF_API_REGISTER_PROTOCOL cruft
Anton Khirnov [Thu, 3 Feb 2011 11:32:59 +0000 (12:32 +0100)]
lavf: remove FF_API_URL_RESETBUF cruft
Anton Khirnov [Thu, 3 Feb 2011 11:30:16 +0000 (12:30 +0100)]
lavf: remove FF_API_OLD_METADATA cruft
Anton Khirnov [Thu, 3 Feb 2011 11:25:54 +0000 (12:25 +0100)]
lavf: remove FF_API_MAX_STREAMS cruft
Kostya [Mon, 18 Apr 2011 05:32:14 +0000 (05:32 +0000)]
document introduction of side data in APIchanges
this should've been written earlier, sorry
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Diego Biurrun [Tue, 19 Apr 2011 06:47:59 +0000 (08:47 +0200)]
pcm: Add const to cast in ENCODE macro.
This fixes a lot of warnings of the sort:
libavcodec/pcm.c:105: warning: cast discards qualifiers from pointer target type
Diego Biurrun [Mon, 18 Apr 2011 21:12:40 +0000 (23:12 +0200)]
Remove now obsolete references to _g-suffixed binaries.
Automatic stripping of binaries was removed in commit
e0be794
and the _g binaries disappeared along with it.
Luca Barbato [Mon, 18 Apr 2011 20:12:50 +0000 (22:12 +0200)]
libvo-aacenc,libvo-amrwbenc}: fix api usage
Use the correct error codes and format identifier.
Anton Khirnov [Thu, 3 Feb 2011 11:18:16 +0000 (12:18 +0100)]
Bump major versions of all libraries.
They've accumulated enough new APIs and corresponding deprecated cruft.
This breaks API and ABI.
Diego Biurrun [Sun, 17 Apr 2011 18:13:59 +0000 (20:13 +0200)]
Replace mplayerhq.hu URLs by libav.org.
Diego Biurrun [Sun, 17 Apr 2011 17:48:27 +0000 (19:48 +0200)]
asfdec: Remove dead code from asf_read_close().
Diego Biurrun [Sun, 17 Apr 2011 21:42:10 +0000 (23:42 +0200)]
ptx: Use av_log_ask_for_sample() where appropriate.
Diego Biurrun [Sun, 17 Apr 2011 20:18:00 +0000 (22:18 +0200)]
Update regtest checksums after revision
6001dad.
The string "FFmpeg" was replaced by "Libav" in metadata that
got encoded in file headers.
Diego Biurrun [Fri, 15 Apr 2011 20:30:26 +0000 (22:30 +0200)]
Replace more FFmpeg references by Libav.
Justin Ruggles [Sun, 17 Apr 2011 16:26:47 +0000 (12:26 -0400)]
ac3dec: fix processing of delta bit allocation information.
The number of dba segments is the coded value + 1.
The coupling dba offset starts at the first coupling band, not at zero.
Ronald S. Bultje [Sat, 16 Apr 2011 19:29:05 +0000 (19:29 +0000)]
vc1: fix fate-vc1 after previous commit.
PROFILE_ADVANCED doesn't set res_fasttx, so make that a special case
in the condition that decides which IDCT to use (and whether to read
coefficients transposed or not).
Signed-off-by: Kostya Shishkov <kostya.shishkov@gmail.com>
Ronald S. Bultje [Sat, 16 Apr 2011 19:07:14 +0000 (15:07 -0400)]
wmv3dec: fix playback of complex WMV3 files using simple_idct.
IDCT coefficients are read transposed, but simple_idct does not expect
this. Therefore, only do tranposed coefficient reading if we're not
using simple_idct.
Fixes http://forum.videolan.org/viewtopic.php?f=14&t=89651
Diego Biurrun [Fri, 15 Apr 2011 15:49:36 +0000 (17:49 +0200)]
Replace references to ffmpeg-devel with libav-devel; fix roundup URL.
Kostya Shishkov [Wed, 13 Apr 2011 15:36:02 +0000 (17:36 +0200)]
make av_dup_packet() more cautious on allocation failures
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Kostya Shishkov [Sat, 9 Apr 2011 13:49:51 +0000 (15:49 +0200)]
make containers pass palette change in AVPacket
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Kostya Shishkov [Sat, 9 Apr 2011 13:31:39 +0000 (15:31 +0200)]
introduce side information for AVPacket
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Diego Biurrun [Fri, 15 Apr 2011 11:28:04 +0000 (13:28 +0200)]
xwma: Fix wrong printf format expression.
Also add inttypes.h #include for PRId64 macros.
This fixes the following warnings:
libavformat/xwma.c:147: warning: too many arguments for format
libavformat/xwma.c:151: warning: too many arguments for format
Max Horn [Fri, 15 Apr 2011 07:43:15 +0000 (09:43 +0200)]
xwma demuxer: typos
Signed-off-by: Diego Biurrun <diego@biurrun.de>
Clément Bœsch [Sun, 10 Apr 2011 07:26:43 +0000 (09:26 +0200)]
oggdec: simplify audio chained ogg streams support
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Janne Grunau [Fri, 15 Apr 2011 07:12:34 +0000 (09:12 +0200)]
swscale: fix "ISO C90 forbids mixed declarations and code" warning
only hit with --enable-runtime-cpudetect