OSDN Git Service
Bruce Momjian [Wed, 30 May 2001 20:15:28 +0000 (20:15 +0000)]
Add recent UNDO/VACUUM thread to TODO.detail.
Tom Lane [Wed, 30 May 2001 19:55:08 +0000 (19:55 +0000)]
Add "#define GIST_AM_OID".
Tom Lane [Wed, 30 May 2001 19:53:40 +0000 (19:53 +0000)]
Tweak StrategyEvaluation data structure to eliminate hardwired limit on
number of strategies supported by an index AM. Add missing copyright
notices and CVS $Header$ markers to GIST source files.
Bruce Momjian [Wed, 30 May 2001 19:49:42 +0000 (19:49 +0000)]
Update TODO list.
Tom Lane [Wed, 30 May 2001 19:39:50 +0000 (19:39 +0000)]
Remove unused, redundant header files.
Tom Lane [Wed, 30 May 2001 18:32:29 +0000 (18:32 +0000)]
Fix broken $Header$ declaration.
Bruce Momjian [Wed, 30 May 2001 18:08:24 +0000 (18:08 +0000)]
Properly compute max sys oid for 7.0 and 7.1.
Bruce Momjian [Wed, 30 May 2001 16:34:49 +0000 (16:34 +0000)]
I just got bitten by this too. I use type timestamp in the
database, and often need the latest timestamp, but want to
format it as a date. With 7.0.x, I just
select ts from foo order by ts desc limit 1
and in java: d = res.getDate(1);
but this fails everywhere in my code now :(
http://java.sun.com/j2se/1.3/docs/guide/jdbc/spec/jdbc-spec.frame7.html
says
The ResultSet.getXXX methods will attempt to
convert whatever SQL type was returned by the
database to whatever Java type is returned by
the getXXX method.
Palle Girgensohn
Bruce Momjian [Wed, 30 May 2001 15:37:38 +0000 (15:37 +0000)]
Fix missing relation in FROM causing NOTICE. Cleanup.
Bruce Momjian [Wed, 30 May 2001 14:44:00 +0000 (14:44 +0000)]
Remove reference to pg_class.relhaspkey from code. Column is unused.
Bruce Momjian [Wed, 30 May 2001 14:40:13 +0000 (14:40 +0000)]
Mark as unused:
> Are these columns in pg_class:
> relukeys | relfkeys | relhaspkey
> unused or what?
Christopher Kings
Bruce Momjian [Wed, 30 May 2001 14:37:51 +0000 (14:37 +0000)]
Update TODO list.
Bruce Momjian [Wed, 30 May 2001 14:18:18 +0000 (14:18 +0000)]
Remove SEP_CHAR from /contrib.
Bruce Momjian [Wed, 30 May 2001 14:15:27 +0000 (14:15 +0000)]
Remove SEP_CHAR, replace with / or '/' as appropriate.
Bruce Momjian [Wed, 30 May 2001 13:03:43 +0000 (13:03 +0000)]
Fix for Druid. We did not support some PROCEDURE queries.
Dave Cramer
Bruce Momjian [Wed, 30 May 2001 13:01:08 +0000 (13:01 +0000)]
This is a docs patch to go with my DROP CONSTRAINT patch.
Christopher Kings
Bruce Momjian [Wed, 30 May 2001 13:00:03 +0000 (13:00 +0000)]
These patches should fix check constraints not inheriting
when added by alter table add constraint. The first file
patches backend/commands/command.c and the latter is a patch
to the alter table regression test.
Stephan Szabo
Bruce Momjian [Wed, 30 May 2001 12:58:45 +0000 (12:58 +0000)]
Playing with the earthdistance stuff, and found I needed the following
patch:
Larry Rosenman
Bruce Momjian [Wed, 30 May 2001 12:57:36 +0000 (12:57 +0000)]
Attached is my patch that adds DROP CONSTRAINT support to PostgreSQL. I
basically want your guys feedback. I have sprinkled some of my q's thru
the text delimited with the @@ symbol. It seems to work perfectly.
[ Removed @@ comments because patch was reviewed. ]
At the moment it does CHECK constraints only, with inheritance. However,
due to the problem mentioned before with the mismatching between inherited
constraints it may be wise to disable the inheritance feature for a while.
it is written in an extensible fashion to support future dropping of other
types of constraint, and is well documented.
Please send me your comments, check my use of locking, updating of
indices, use of ERROR and NOTICE, etc. and I will rework the patch based
on feedback until everyone
is happy with it...
Christopher Kings
Tom Lane [Wed, 30 May 2001 04:32:30 +0000 (04:32 +0000)]
Correct obsolete example of FROM-less query.
Bruce Momjian [Wed, 30 May 2001 04:01:11 +0000 (04:01 +0000)]
In chapter:
7.7. Keys
you have
However, my application requires that each collection will also have a
unique name. Why? So that a human being who wants to modify a collection
will be able to identify it. It's much harder to know, if you have two
collections named "Life Science", the the one tagged 24433 is the one
you
need, and the one tagged 29882 is not
I think 'the the' shouldn't be repeated twice. Although taken from an
email it would be cool to fix.
Cheers,
Maxim Maletsky
D'Arcy J.M. Cain [Wed, 30 May 2001 02:11:46 +0000 (02:11 +0000)]
Further conversions to Version 1 API. Also, fix boolean return to use
PG_RETURN_BOOL(0) instead of return 0.
D'Arcy J.M. Cain [Wed, 30 May 2001 02:04:49 +0000 (02:04 +0000)]
Add missing comma.
Tom Lane [Mon, 28 May 2001 21:58:32 +0000 (21:58 +0000)]
Make text <=> char conversion functions convert zero character to and
from an empty text string. This makes them consistent with the de facto
behavior of type char's I/O conversion functions, and avoids generating
text values with embedded nulls, which confuse many text operators.
Tom Lane [Mon, 28 May 2001 19:33:24 +0000 (19:33 +0000)]
Cause plpgsql's PERFORM to behave according to its documentation,
which says that PERFORM will execute any SELECT query and discard the
result. The former implementation would in fact raise an error if the
result contained more than one row or more than one column.
Also, change plpgsql's error-logging mechanism to emit the additional
messages about error location at NOTICE rather than DEBUG level. This
allows them to be seen by the client without having to dig into the
postmaster log file (which may be nonexistent or inaccessible by the
client).
D'Arcy J.M. Cain [Mon, 28 May 2001 15:34:27 +0000 (15:34 +0000)]
Upgraded code to use the current version 1 calling conventions.
Tom Lane [Mon, 28 May 2001 15:29:51 +0000 (15:29 +0000)]
Suppress useless memmove() when buffer already contains left-justified
data.
Peter Eisentraut [Mon, 28 May 2001 14:58:58 +0000 (14:58 +0000)]
markup fix
Bruce Momjian [Mon, 28 May 2001 04:28:36 +0000 (04:28 +0000)]
Update TODO list.
Bruce Momjian [Mon, 28 May 2001 04:27:17 +0000 (04:27 +0000)]
Sample output that appears below the table attributes for \d:
Indicies: palm_buy_date_idx
palm_user_date_idx
Primary Key: palm_buyers_pkey
Unique Key: palm_buyers_username
Constraint: "$1" ((sex = 'M'::bpchar) OR (sex = 'F'::bpchar))
Note that check constraint name now shown as well. (Makes it a lot easier
to test inheritance support in ADD/DROP constraint :) )
Attached is a docs change for psql.
Christopher Kings
Bruce Momjian [Mon, 28 May 2001 02:01:22 +0000 (02:01 +0000)]
This just breaks down the indices in to three groups:
non-unique: stay as they were
unique and primary: become listed as primary keys
unique and non-primary: become listed as unique keys
I also made it so that it shows the names of check constraints ie:
Check: "$1" (a > 5)
Christopher Kings
Tatsuo Ishii [Mon, 28 May 2001 01:00:25 +0000 (01:00 +0000)]
Fix a message error in utf_to_local
Bruce Momjian [Mon, 28 May 2001 00:37:00 +0000 (00:37 +0000)]
Attached is a patch to fix the problem Thomas mentions below. The JDBC
driver now correctly handles timezones that are offset fractional hours
from GMT (ie. -06:30).
Barry Lind
Peter Eisentraut [Sun, 27 May 2001 21:50:50 +0000 (21:50 +0000)]
Don't use multi-line string literals.
Tom Lane [Sun, 27 May 2001 20:48:51 +0000 (20:48 +0000)]
When using a junkfilter, the output tuple should NOT be stored back into
the same tuple slot that the raw tuple came from, because that slot has
the wrong tuple descriptor. Store it into its own slot with the correct
descriptor, instead. This repairs problems with SPI functions seeing
inappropriate tuple descriptors --- for example, plpgsql code failing to
cope with SELECT FOR UPDATE.
Tom Lane [Sun, 27 May 2001 20:42:20 +0000 (20:42 +0000)]
Cause ExecCountSlots() accounting to bear some relationship to reality.
Rather surprising we hadn't seen bug reports about this ...
D'Arcy J.M. Cain [Sun, 27 May 2001 19:06:20 +0000 (19:06 +0000)]
Changed use of macros for extracting information. According to comments
in c.h we should be using the visible structure. We should only see
de-TOASTed values in this program. The old method refused to compile
because the length macro was no longer an lvalue.
Tom Lane [Sun, 27 May 2001 17:37:48 +0000 (17:37 +0000)]
Fix eqjoinsel() to make use of new statistics.
Bruce Momjian [Sun, 27 May 2001 16:31:30 +0000 (16:31 +0000)]
Update TODO list.
Peter Eisentraut [Sun, 27 May 2001 09:59:30 +0000 (09:59 +0000)]
Make UPDATE and DELETE privileges distinct. Add REFERENCES and TRIGGER
privileges. INSERT and COPY FROM now require INSERT (only). Add
privileges regression test.
D'Arcy J.M. Cain [Sun, 27 May 2001 08:24:52 +0000 (08:24 +0000)]
Add NUMERICOID return type. Treat it as floating point for now. This
could be changed if we create a new Python type that matches it better
but NUMERIC <==> FLOAT probably works fine for most cases.
Bruce Momjian [Fri, 25 May 2001 16:29:17 +0000 (16:29 +0000)]
Mention failure of ANT to delete directories on clean.
Bruce Momjian [Fri, 25 May 2001 15:48:33 +0000 (15:48 +0000)]
See attached for a small patch that enables plpython to build cleanly
under Cygwin. This patch together with my previous Python patch:
http://postgresql.readysetnet.com/mhonarc/pgsql-patches/2001-05/msg00075.htm
l
enables full Python support (i.e., configure --with-python) for Cygwin
PostgreSQL.
Jason Tishler
Bruce Momjian [Fri, 25 May 2001 15:45:34 +0000 (15:45 +0000)]
Oops, only wanted python change in the last commit. Backing out.
Bruce Momjian [Fri, 25 May 2001 15:34:50 +0000 (15:34 +0000)]
While changing Cygwin Python to build its core as a DLL (like Win32
Python) to support shared extension modules, I have learned that Guido
prefers the style of the attached patch to solve the above problem.
I feel that this solution is particularly appropriate in this case
because the following:
PglargeType
PgType
PgQueryType
are already being handled in the way that I am proposing for PgSourceType.
Jason Tishler
Bruce Momjian [Fri, 25 May 2001 15:32:33 +0000 (15:32 +0000)]
Back out, per Peter E.
> > The attached patch changes src/interfaces/python/GNUmakefile to use the
> > value of DESTDIR like the rest (or at least most) of the PostgreSQL
> > makefiles. I found this problem when trying to package a pre-built
> > Cygwin PostgreSQL distribution, but this problem is platform independent.
Bruce Momjian [Fri, 25 May 2001 14:29:39 +0000 (14:29 +0000)]
The attached patch changes src/interfaces/python/GNUmakefile to use the
value of DESTDIR like the rest (or at least most) of the PostgreSQL
makefiles. I found this problem when trying to package a pre-built
Cygwin PostgreSQL distribution, but this problem is platform independent.
The problem manifests itself when one tries to install into a stagging
area (e.g., to build a tarball) instead of a real install. In this case,
pg.py and _pgmodule$(SO) still end up being installed in the configured
prefix directory ignoring the value of DESTDIR.
Unfortunately, this patch does not handle the case where PostgreSQL
and Python are configured with different prefixes. Since the Python
Makefile is automatically generated and does not use DESTDIR, I believe
that this issue will be difficult to correct. If anyone has ideas on
how to fix this issue, then I'm quite willing to rework the patch to
take the suggestion into account.
Jason Tishler
Bruce Momjian [Fri, 25 May 2001 14:28:58 +0000 (14:28 +0000)]
The following patch corrects a make install problem when building
under Cygwin. The root cause of this problem is that (Sun) java is a
native Win32 app and hence does not understand Cygwin Posix style paths.
The solution is to use Cygwin's cygpath utility to convert the Posix style
JDBC installation directory path into a Win32 one before invoking ant.
I'm not sure if my patch is the best way to correct this issue but
my goal was to confine the Cygwin specific constructs to
Jason Tishler
Hiroshi Inoue [Fri, 25 May 2001 08:12:32 +0000 (08:12 +0000)]
Get rid of the following size limit.
1) Query size limit(was 65536) for >=7.0 servers.
2) Text size limit(was 8190) for 7.1 servers.
Bruce Momjian [Fri, 25 May 2001 04:26:21 +0000 (04:26 +0000)]
Another Makefile fix for qnx patch.
Bruce Momjian [Fri, 25 May 2001 04:24:33 +0000 (04:24 +0000)]
Fix tabs in Makefile.
Bruce Momjian [Thu, 24 May 2001 22:33:18 +0000 (22:33 +0000)]
Back out qnx plpgsql/Makefile change and move to src/Makefile.
Bruce Momjian [Thu, 24 May 2001 15:53:34 +0000 (15:53 +0000)]
I haven't tried building postgres with the Watcom compiler for 7.1 because
it does not support 64bit integers. AFAIK that's the default data type for
OIDs, so I am not surprised that this does not work. Use gcc instead.
BTW., 7.1 does not compile as is with gcc either, I believed the
required patches made it into the 7.1.1 release but obviously I missed
the deadline.
Since the ports mailing list does not seem to be archived I have attached
a copy of the patch (for 7.1 and 7.1.1).
I've just performed a build of a Watcom compiled version and found a couple
of bugs in the watcom specific part of that patch. Please use the attached
version instead.
Tegge, Bernd
Bruce Momjian [Thu, 24 May 2001 15:48:32 +0000 (15:48 +0000)]
There are a number of changes. The main ones are:
return oid on insert
handle all primitive data types
handle single quotes and newlines in Strings
handle null variables
deal with non public and final variables (not very
well, though)
Ken K
Bruce Momjian [Thu, 24 May 2001 14:36:31 +0000 (14:36 +0000)]
Update TODO list.
Peter Eisentraut [Thu, 24 May 2001 09:29:29 +0000 (09:29 +0000)]
SQL function bit_length
Peter Eisentraut [Thu, 24 May 2001 00:13:13 +0000 (00:13 +0000)]
Unset PGLIB so it doesn't slip in from the environment.
Peter Eisentraut [Wed, 23 May 2001 22:00:43 +0000 (22:00 +0000)]
Make createlang use dynamic loader enhancements (automatic path and suffix).
Bruce Momjian [Wed, 23 May 2001 20:54:12 +0000 (20:54 +0000)]
Fix ANT for *.properties files.
Bruce Momjian [Wed, 23 May 2001 19:30:35 +0000 (19:30 +0000)]
Fix ANT so it only has '*.class' files, not the 'tags' file.
Bruce Momjian [Wed, 23 May 2001 16:02:55 +0000 (16:02 +0000)]
Update TODO list.
Bruce Momjian [Wed, 23 May 2001 00:42:25 +0000 (00:42 +0000)]
Update TODO list.
Bruce Momjian [Tue, 22 May 2001 21:50:34 +0000 (21:50 +0000)]
Update FAQ.
Bruce Momjian [Tue, 22 May 2001 19:38:22 +0000 (19:38 +0000)]
Update TODO list.
Bruce Momjian [Tue, 22 May 2001 19:19:55 +0000 (19:19 +0000)]
Back out timezone fix. Not needed in jdbc1.
Bruce Momjian [Tue, 22 May 2001 17:24:58 +0000 (17:24 +0000)]
Fix for comments at top of functions.
Bruce Momjian [Tue, 22 May 2001 16:52:49 +0000 (16:52 +0000)]
I found the answer to this: the partition had filled up, and so the problem
was lack of disk space.
Oliver Elphick
Peter Eisentraut [Tue, 22 May 2001 16:37:17 +0000 (16:37 +0000)]
Make bit and bit varying types reject too long input. (They already tried
to do that, but inconsistently.) Make bit type reject too short input,
too, per SQL. Since it no longer zero pads, 'zpbit*' has been renamed to
'bit*' in the source, hence initdb.
Peter Eisentraut [Tue, 22 May 2001 16:00:00 +0000 (16:00 +0000)]
more indices -> indexes
Bruce Momjian [Tue, 22 May 2001 13:52:27 +0000 (13:52 +0000)]
ELSEIF PL/PgSQL doc patch.
Klaus Reger
Bruce Momjian [Tue, 22 May 2001 13:20:46 +0000 (13:20 +0000)]
Update TODO list.
Bruce Momjian [Tue, 22 May 2001 12:10:50 +0000 (12:10 +0000)]
Update TODO list.
Bruce Momjian [Tue, 22 May 2001 12:06:51 +0000 (12:06 +0000)]
The Watcom preprocessor adds a space at the start of each line. Therefore
the output of "egrep '^[0-9]' " is empty. Changing the pattern to
"egrep '^[ ]*[0-9]" generates the correct file.
Tegge, Bernd
Bruce Momjian [Tue, 22 May 2001 11:24:28 +0000 (11:24 +0000)]
Bump major libpq++ version after API changes, Patrick Welche
Bruce Momjian [Tue, 22 May 2001 01:35:25 +0000 (01:35 +0000)]
Update TODO list.
Bruce Momjian [Tue, 22 May 2001 01:28:16 +0000 (01:28 +0000)]
Pgindent fixes for Tom, mostly indenting problems.
Bruce Momjian [Mon, 21 May 2001 18:42:08 +0000 (18:42 +0000)]
Print error on SELECT tab FROM tab:
You can't use relation names alone in the target list, try relation.*
Bruce Momjian [Mon, 21 May 2001 18:36:58 +0000 (18:36 +0000)]
Update TODO list.
Peter Eisentraut [Mon, 21 May 2001 16:54:46 +0000 (16:54 +0000)]
Make char(n) and varchar(n) types raise an error if the inserted string is
too long. While I was adjusting the regression tests I moved the array
things all into array.sql, to make things more manageable.
Jan Wieck [Mon, 21 May 2001 14:22:19 +0000 (14:22 +0000)]
Enhancement of SPI to get access to portals
- New functions to create a portal using a prepared/saved
SPI plan or lookup an existing portal by name.
- Functions to fetch/move from/in portals. Results are placed
in the usual SPI_processed and SPI_tuptable, so the entire
set of utility functions can be used to gain attribute access.
- Prepared/saved SPI plans now use their own memory context
and SPI_freeplan(plan) can remove them.
- Tuple result sets (SPI_tuptable) now uses it's own memory
context and can be free'd by SPI_freetuptable(tuptab).
Enhancement of PL/pgSQL
- Uses generic named portals internally in FOR ... SELECT
loops to avoid running out of memory on huge result sets.
- Support for CURSOR and REFCURSOR syntax using the new SPI
functionality. Cursors used internally only need no explicit
transaction block. Refcursor variables can be used inside
of explicit transaction block to pass cursors between main
application and functions.
Jan
Tom Lane [Sun, 20 May 2001 20:28:20 +0000 (20:28 +0000)]
Modify optimizer data structures so that IndexOptInfo lists built for
create_index_paths are not immediately discarded, but are available for
subsequent planner work. This allows avoiding redundant syscache lookups
in several places. Change interface to operator selectivity estimation
procedures to allow faster and more flexible estimation.
Initdb forced due to change of pg_proc entries for selectivity functions!
Bruce Momjian [Sun, 20 May 2001 01:11:48 +0000 (01:11 +0000)]
Update TODO list.
Peter Eisentraut [Sat, 19 May 2001 09:28:08 +0000 (09:28 +0000)]
Make sure fmgr_info() fills in fn_oid last, so that no partially
initialized FmgrInfo structs linger after elog.
Peter Eisentraut [Sat, 19 May 2001 09:01:10 +0000 (09:01 +0000)]
Allow special '$libdir' macro to show up in object file path in CREATE
FUNCTION command. Guard against trying to load a directory. Update
documentation some.
Bruce Momjian [Sat, 19 May 2001 02:48:54 +0000 (02:48 +0000)]
Prevent ANT from recreating the JAR files just because the
errors.properties files were being copied.
Bruce Momjian [Sat, 19 May 2001 01:57:11 +0000 (01:57 +0000)]
Comment additions in parser.
Bruce Momjian [Sat, 19 May 2001 00:37:45 +0000 (00:37 +0000)]
Move ParserFuncOrColumn function higher in the file.
Bruce Momjian [Sat, 19 May 2001 00:33:20 +0000 (00:33 +0000)]
New comment. This func/column things has always confused me.
/*
* parse function
* This code is confusing because the database can accept
* relation.column, column.function, or relation.column.function.
* In these cases, funcname is the last parameter, and fargs are
* the rest.
*
* It can also be called as func(col) or func(col,col).
* In this case, Funcname is the part before parens, and fargs
* are the part in parens.
*
*/
Node *
ParseFuncOrColumn(ParseState *pstate, char *funcname, List *fargs,
bool agg_star, bool agg_distinct,
int precedence)
Bruce Momjian [Fri, 18 May 2001 22:54:23 +0000 (22:54 +0000)]
Undo \dT change. Not worth it.
Bruce Momjian [Fri, 18 May 2001 22:35:51 +0000 (22:35 +0000)]
Rename ParseFuncOrColumn() to ParseColumnOrFunc().
Bruce Momjian [Fri, 18 May 2001 21:24:20 +0000 (21:24 +0000)]
Small code cleanups,formatting.
Jan Wieck [Fri, 18 May 2001 21:16:59 +0000 (21:16 +0000)]
Adding ELSIF support contributed by Klaus Reger.
Jan
Tom Lane [Fri, 18 May 2001 17:49:52 +0000 (17:49 +0000)]
Suppress compiler warnings about pid_t vs int.
Bruce Momjian [Fri, 18 May 2001 16:28:12 +0000 (16:28 +0000)]
Update TODO list.
Tom Lane [Fri, 18 May 2001 16:02:01 +0000 (16:02 +0000)]
Add regression test to catch future breakage of avg(interval). This
aggregate seems uniquely fragile, because it's the only one with an
agginitval that's at all likely to change in format.
Tom Lane [Fri, 18 May 2001 15:59:04 +0000 (15:59 +0000)]
Correct recently-broken avg(interval) definition.
Bruce Momjian [Fri, 18 May 2001 15:18:55 +0000 (15:18 +0000)]
Update TODO list.
Bruce Momjian [Fri, 18 May 2001 14:39:54 +0000 (14:39 +0000)]
Update TODO list.
Bruce Momjian [Thu, 17 May 2001 22:07:21 +0000 (22:07 +0000)]
Update TODO list.
Peter Eisentraut [Thu, 17 May 2001 21:50:18 +0000 (21:50 +0000)]
Change "indices" to "indexes", per OED.