OSDN Git Service

kde/kde-workspace.git
19 months agoksmserver: drop custom logout effect
Ivailo Monev [Tue, 15 Nov 2022 23:36:58 +0000 (01:36 +0200)]
ksmserver: drop custom logout effect

the effect is very much bound to the window manager (KWin) because if
applications require attention (such as confirmation to cancel any
pending changes) their window or any dialog they pop may have to be
raised, will have to be focused and not be grayed out

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoksysguard: remove redundant QFontInfo header inclusion
Ivailo Monev [Tue, 15 Nov 2022 18:59:33 +0000 (20:59 +0200)]
ksysguard: remove redundant QFontInfo header inclusion

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: release selection after all components are deleted
Ivailo Monev [Tue, 15 Nov 2022 05:20:38 +0000 (07:20 +0200)]
kwin: release selection after all components are deleted

effects for example may have their own selection (the startupfeedback
effect used to claim _KDE_STARTUP_FEEDBACK for example) so if other
window manager wants to claim selection/atom owned by KWin effect effects
have to be deinitialized before disowning the window manager selection

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agogeneric: remove redundant QT_CLEAN_NAMESPACE definitions
Ivailo Monev [Tue, 15 Nov 2022 00:07:21 +0000 (02:07 +0200)]
generic: remove redundant QT_CLEAN_NAMESPACE definitions

Katie's namespace is always clean, if there is a namespace issue perhaps
it is not cause of it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoksmserver: kill window manager before cleanup
Ivailo Monev [Mon, 14 Nov 2022 23:54:19 +0000 (01:54 +0200)]
ksmserver: kill window manager before cleanup

the window manager itself may want to do something session management
related (KWin does) and as such ksmserver has to be in operational state
before the window manager is killed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoksmserver: move process launching code to startup source file
Ivailo Monev [Mon, 14 Nov 2022 23:28:27 +0000 (01:28 +0200)]
ksmserver: move process launching code to startup source file

note that connecting to signals after the process is started (which is also
auto-deleted) as was done in KSMServer::launchWM() could result in a race

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: make use of KGlobalSettings::isMultiHead()
Ivailo Monev [Mon, 14 Nov 2022 21:53:53 +0000 (23:53 +0200)]
kwin: make use of KGlobalSettings::isMultiHead()

the code in KGlobalSettings::isMultiHead() is exactly the same

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: use static_cast<T>() for the shadow pixmap handle
Ivailo Monev [Mon, 14 Nov 2022 18:10:52 +0000 (20:10 +0200)]
kwin: use static_cast<T>() for the shadow pixmap handle

clang cannot cope the Qt::HANDLE type constructor, fixes build on FreeBSD

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoplasma: remove deprecated krunnermodel import
Ivailo Monev [Mon, 14 Nov 2022 13:59:53 +0000 (15:59 +0200)]
plasma: remove deprecated krunnermodel import

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agogeneric: prepare for Katie changes
Ivailo Monev [Mon, 14 Nov 2022 13:56:01 +0000 (15:56 +0200)]
generic: prepare for Katie changes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokate: add Q_EXPORT_PLUGIN macro to cpp syntax data
Ivailo Monev [Mon, 14 Nov 2022 13:41:18 +0000 (15:41 +0200)]
kate: add Q_EXPORT_PLUGIN macro to cpp syntax data

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoplasma: pass the buffer data size to QString constructor in SupportInformation::gener...
Ivailo Monev [Sun, 13 Nov 2022 19:38:26 +0000 (21:38 +0200)]
plasma: pass the buffer data size to QString constructor in SupportInformation::generateSupportInformation()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: add new KWin::Compositor::starting() method and use it in during startup
Ivailo Monev [Sun, 13 Nov 2022 19:37:58 +0000 (21:37 +0200)]
kwin: add new KWin::Compositor::starting() method and use it in during startup

I have a feeling even that will not be enough

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoplasma: open the QDebug buffer in SupportInformation::generateSupportInformation()
Ivailo Monev [Sun, 13 Nov 2022 00:29:06 +0000 (02:29 +0200)]
plasma: open the QDebug buffer in SupportInformation::generateSupportInformation()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agogeneric: prepare for Katie changes
Ivailo Monev [Sat, 12 Nov 2022 23:41:49 +0000 (01:41 +0200)]
generic: prepare for Katie changes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: process events before resuming ksmserver startup
Ivailo Monev [Sat, 12 Nov 2022 19:18:48 +0000 (21:18 +0200)]
kwin: process events before resuming ksmserver startup

the 4sec delay removed in 4560049c4ac38642c966e2da7ea1641c77ac02c0 was
essentially fence for the setup, with that gone plasma (or any application
automatically started) initial checks for compositor (or anything window
manager related) could fail

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoplasma: remove KWin scripting support leftovers
Ivailo Monev [Sat, 12 Nov 2022 13:04:32 +0000 (15:04 +0200)]
plasma: remove KWin scripting support leftovers

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: oxygen client exception group name creator optimization
Ivailo Monev [Fri, 11 Nov 2022 23:27:19 +0000 (01:27 +0200)]
kwin: oxygen client exception group name creator optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: release compositor selection ownership instantly
Ivailo Monev [Fri, 11 Nov 2022 22:37:11 +0000 (00:37 +0200)]
kwin: release compositor selection ownership instantly

the compositor is global static with inter-dependancy on the workspace
global static which access the compositor - what could go wrong with
timers, signals global statics and X11 atom ownership?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: remove unused KWin::Scene member
Ivailo Monev [Fri, 11 Nov 2022 22:16:30 +0000 (00:16 +0200)]
kwin: remove unused KWin::Scene member

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokstyles: remove Qt::WA_PaintOnScreen overrides for QTipLabel and QMenu
Ivailo Monev [Wed, 9 Nov 2022 15:57:40 +0000 (17:57 +0200)]
kstyles: remove Qt::WA_PaintOnScreen overrides for QTipLabel and QMenu

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agolibs: paint KSignalPlotter on backing store
Ivailo Monev [Wed, 9 Nov 2022 15:32:34 +0000 (17:32 +0200)]
libs: paint KSignalPlotter on backing store

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: prepare for Katie changes
Ivailo Monev [Wed, 9 Nov 2022 03:17:49 +0000 (05:17 +0200)]
kwin: prepare for Katie changes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoplasma: port systemtray applet to KPixmap
Ivailo Monev [Tue, 8 Nov 2022 22:48:34 +0000 (00:48 +0200)]
plasma: port systemtray applet to KPixmap

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoplasma: partially port systemtray applet to KPixmap and plug a X11 Pixmap leak
Ivailo Monev [Tue, 8 Nov 2022 22:28:36 +0000 (00:28 +0200)]
plasma: partially port systemtray applet to KPixmap and plug a X11 Pixmap leak

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agogeneric: port to KPixmap
Ivailo Monev [Wed, 9 Nov 2022 00:13:13 +0000 (02:13 +0200)]
generic: port to KPixmap

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoplasma: remove shadows on hide
Ivailo Monev [Tue, 8 Nov 2022 17:13:18 +0000 (19:13 +0200)]
plasma: remove shadows on hide

fixes regression since 5c32f8c9e16e283fa36d60b112cd267e32c3f0f2

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: shadow optimization
Ivailo Monev [Tue, 8 Nov 2022 16:40:57 +0000 (18:40 +0200)]
kwin: shadow optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: deal with TODO related to XRenderPicture
Ivailo Monev [Tue, 8 Nov 2022 16:14:39 +0000 (18:14 +0200)]
kwin: deal with TODO related to XRenderPicture

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoplasma: remove unused systemray applet sources
Ivailo Monev [Tue, 8 Nov 2022 15:31:03 +0000 (17:31 +0200)]
plasma: remove unused systemray applet sources

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agolibs: avoid temporary in Oxygen::TileSet::initPixmap()
Ivailo Monev [Mon, 7 Nov 2022 19:29:20 +0000 (21:29 +0200)]
libs: avoid temporary in Oxygen::TileSet::initPixmap()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoplasma: generalize folderview scroll backbuffer
Ivailo Monev [Mon, 7 Nov 2022 16:34:25 +0000 (18:34 +0200)]
plasma: generalize folderview scroll backbuffer

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoplasma: use the now exported Plasma::DialogShadows class
Ivailo Monev [Mon, 7 Nov 2022 16:23:05 +0000 (18:23 +0200)]
plasma: use the now exported Plasma::DialogShadows class

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoksmserver: drop logout fade effect
Ivailo Monev [Mon, 7 Nov 2022 14:55:16 +0000 (16:55 +0200)]
ksmserver: drop logout fade effect

unless compositor is not active it is not even used (KWin has logout
effect for that) and there is a curtain effect as fallback

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: indent and format randr module source and header files
Ivailo Monev [Sun, 6 Nov 2022 10:59:52 +0000 (12:59 +0200)]
kcontrol: indent and format randr module source and header files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: indent and format randr module source and header files
Ivailo Monev [Sun, 6 Nov 2022 10:47:21 +0000 (12:47 +0200)]
kcontrol: indent and format randr module source and header files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: I am the maintainer of kdebug KCM since 2014
Ivailo Monev [Sun, 6 Nov 2022 09:52:18 +0000 (11:52 +0200)]
kcontrol: I am the maintainer of kdebug KCM since 2014

it has been that long?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: save kdebug KCM changes when the output file changes
Ivailo Monev [Sun, 6 Nov 2022 09:50:14 +0000 (11:50 +0200)]
kcontrol: save kdebug KCM changes when the output file changes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: save kdebug KCM settings when destination changes
Ivailo Monev [Sun, 6 Nov 2022 09:34:07 +0000 (11:34 +0200)]
kcontrol: save kdebug KCM settings when destination changes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoMerge branch 'master' of https://scm.osdn.net/gitroot/kde/kde-workspace
Ivailo Monev [Sun, 6 Nov 2022 03:59:13 +0000 (05:59 +0200)]
Merge branch 'master' of https://scm.osdn.net/gitroot/kde/kde-workspace

19 months agokwin: simplify compositor selection ownership check
Ivailo Monev [Sun, 6 Nov 2022 03:58:46 +0000 (05:58 +0200)]
kwin: simplify compositor selection ownership check

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: check if the Workspace pointer is null in Application::notify()
Ivailo Monev [Sat, 5 Nov 2022 18:48:18 +0000 (20:48 +0200)]
kwin: check if the Workspace pointer is null in Application::notify()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: do not queue the ownership events
Ivailo Monev [Sat, 5 Nov 2022 08:55:33 +0000 (10:55 +0200)]
kwin: do not queue the ownership events

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: fix runtime warning related to D-Bus connection
Ivailo Monev [Sat, 5 Nov 2022 06:45:04 +0000 (08:45 +0200)]
kwin: fix runtime warning related to D-Bus connection

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: resume ksmserver startup if setup fails
Ivailo Monev [Sat, 5 Nov 2022 06:43:11 +0000 (08:43 +0200)]
kwin: resume ksmserver startup if setup fails

note that application instance is required before D-Bus connection is made
but connection is made by creating ksmserver interface before the
application instance

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agogeneric: adjust to KSelectionOwner changes
Ivailo Monev [Sat, 5 Nov 2022 06:30:58 +0000 (08:30 +0200)]
generic: adjust to KSelectionOwner changes

had to rewrite KSelectionOwner to fix the issues with it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: check owner window before releasing selection
Ivailo Monev [Fri, 4 Nov 2022 15:09:08 +0000 (17:09 +0200)]
kwin: check owner window before releasing selection

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokstyles: remove hack for some unknown widget
Ivailo Monev [Fri, 4 Nov 2022 14:40:35 +0000 (16:40 +0200)]
kstyles: remove hack for some unknown widget

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: remove redundant selection owner in startupfeedback effect
Ivailo Monev [Fri, 4 Nov 2022 12:53:06 +0000 (14:53 +0200)]
kwin: remove redundant selection owner in startupfeedback effect

was previously either krunner or the effect

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokstyles: remove oxygen styles hacks for now non-existing widget classes
Ivailo Monev [Fri, 4 Nov 2022 11:17:30 +0000 (13:17 +0200)]
kstyles: remove oxygen styles hacks for now non-existing widget classes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: merge DesktopStartItem class into AutoStartItem
Ivailo Monev [Fri, 4 Nov 2022 10:47:53 +0000 (12:47 +0200)]
kcontrol: merge DesktopStartItem class into AutoStartItem

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: write Name entry for custom desktop files from autostart KCM
Ivailo Monev [Fri, 4 Nov 2022 09:48:13 +0000 (11:48 +0200)]
kcontrol: write Name entry for custom desktop files from autostart KCM

otherwise it is empty the next time autostart KCM loads the .desktop files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoksmserver: startup optimization
Ivailo Monev [Fri, 4 Nov 2022 08:56:54 +0000 (10:56 +0200)]
ksmserver: startup optimization

QProcess::waitForStarted() will wait up 4000s but may return before

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokate: remove run-tests-in-xvfb.sh script
Ivailo Monev [Fri, 4 Nov 2022 06:29:09 +0000 (08:29 +0200)]
kate: remove run-tests-in-xvfb.sh script

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: disable autostart items the filepath of which is not writable
Ivailo Monev [Fri, 4 Nov 2022 06:19:26 +0000 (08:19 +0200)]
kcontrol: disable autostart items the filepath of which is not writable

this is kinda not according to the spec (which allows user overrides) but
what is the outcome of having a local copy of system file?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: fix autostart add
Ivailo Monev [Fri, 4 Nov 2022 06:07:16 +0000 (08:07 +0200)]
kcontrol: fix autostart add

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: notify when error occurrs when attempting to remove program autostart
Ivailo Monev [Fri, 4 Nov 2022 05:44:58 +0000 (07:44 +0200)]
kcontrol: notify when error occurrs when attempting to remove program autostart

can happen if the .desktop file is in /usr/share/autostart/ for example and
the user cannot write there

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: skip non-existing directories in autostart KCM
Ivailo Monev [Fri, 4 Nov 2022 05:43:12 +0000 (07:43 +0200)]
kcontrol: skip non-existing directories in autostart KCM

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agogeneric: prepare for autostart changes
Ivailo Monev [Fri, 4 Nov 2022 07:40:47 +0000 (09:40 +0200)]
generic: prepare for autostart changes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: drop support for scripts in autostart KCM
Ivailo Monev [Fri, 4 Nov 2022 07:21:28 +0000 (09:21 +0200)]
kcontrol: drop support for scripts in autostart KCM

see the previous commit, also fixes detection of programs that are
automatically started by using KStandardDirs to find the autostart
directories

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agoksmserver: do not attempt to run programs from autostart directory
Ivailo Monev [Fri, 4 Nov 2022 07:07:50 +0000 (09:07 +0200)]
ksmserver: do not attempt to run programs from autostart directory

the spec does not mention that programs should be placed there, only
.desktop files (which klauncher already handles). for reference:
https://specifications.freedesktop.org/autostart-spec/autostart-spec-latest.html

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: remove checks for native paint engine
Ivailo Monev [Fri, 4 Nov 2022 02:51:01 +0000 (04:51 +0200)]
kwin: remove checks for native paint engine

in most cases the paint engine Katie uses is raster paint engine

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: set active to false when pointer grab fails in startup feedback effect
Ivailo Monev [Fri, 4 Nov 2022 02:31:58 +0000 (04:31 +0200)]
kwin: set active to false when pointer grab fails in startup feedback effect

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: release the selection from the application destructor
Ivailo Monev [Fri, 4 Nov 2022 02:13:23 +0000 (04:13 +0200)]
kwin: release the selection from the application destructor

note that lostSelection() slot calls KAapplication::quit()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: use mutable list iterator in RandRCrtc::modes()
Ivailo Monev [Thu, 3 Nov 2022 12:24:31 +0000 (14:24 +0200)]
kcontrol: use mutable list iterator in RandRCrtc::modes()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: formant and indent randr KCM files
Ivailo Monev [Thu, 3 Nov 2022 12:20:15 +0000 (14:20 +0200)]
kcontrol: formant and indent randr KCM files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: drop legacy configuration support in randr KCM
Ivailo Monev [Thu, 3 Nov 2022 14:35:42 +0000 (16:35 +0200)]
kcontrol: drop legacy configuration support in randr KCM

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agogeneric: rework startup to no create a shell script
Ivailo Monev [Thu, 3 Nov 2022 09:27:05 +0000 (11:27 +0200)]
generic: rework startup to no create a shell script

by the time ksplash gets the X11 events for startup phases the startup
process is (and should be) done, especially after the display
configuration is done and the monitor is ready to output thus ksplash
does not really indicate much

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agogeneric: default to Oxygen_White for cursor theme
Ivailo Monev [Thu, 3 Nov 2022 08:40:54 +0000 (10:40 +0200)]
generic: default to Oxygen_White for cursor theme

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agostartkde: adjust to kdeinit4 changes
Ivailo Monev [Thu, 3 Nov 2022 08:37:44 +0000 (10:37 +0200)]
startkde: adjust to kdeinit4 changes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: remove dummy Scene::blocksForRetrace() and Scene::syncsToVBlank() methods
Ivailo Monev [Thu, 3 Nov 2022 07:01:53 +0000 (09:01 +0200)]
kwin: remove dummy Scene::blocksForRetrace() and Scene::syncsToVBlank() methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: disconnect KSelectionOwner signals before deleting it
Ivailo Monev [Thu, 3 Nov 2022 06:20:49 +0000 (08:20 +0200)]
kwin: disconnect KSelectionOwner signals before deleting it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokwin: pass the screen number and parent to KSelectionOwner
Ivailo Monev [Thu, 3 Nov 2022 04:05:57 +0000 (06:05 +0200)]
kwin: pass the screen number and parent to KSelectionOwner

the X11 atom is for specifiec screen after all

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: apply input settings in phase zero
Ivailo Monev [Thu, 3 Nov 2022 02:48:49 +0000 (04:48 +0200)]
kcontrol: apply input settings in phase zero

it changes the cursor theme and it has to be done as soon as possible

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
19 months agokcontrol: replace tab with space in input KCM source file
Ivailo Monev [Thu, 3 Nov 2022 02:47:06 +0000 (04:47 +0200)]
kcontrol: replace tab with space in input KCM source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokwin: use KApplication::quitOnSignal() to setup signal handler for quit
Ivailo Monev [Tue, 1 Nov 2022 05:06:39 +0000 (07:06 +0200)]
kwin: use KApplication::quitOnSignal() to setup signal handler for quit

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokwin: mark configModules() function as static
Ivailo Monev [Tue, 1 Nov 2022 04:55:18 +0000 (06:55 +0200)]
kwin: mark configModules() function as static

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokwin: remove code for always false condition
Ivailo Monev [Tue, 1 Nov 2022 04:54:52 +0000 (06:54 +0200)]
kwin: remove code for always false condition

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokate: use QMutableListIterator<T> for iteration in KateCompletionWidget::startComplet...
Ivailo Monev [Tue, 1 Nov 2022 01:22:08 +0000 (03:22 +0200)]
kate: use QMutableListIterator<T> for iteration in KateCompletionWidget::startCompletion()

another iterator modified the wrong way, fixes possible crash

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agodolphin: use QMutableSetIterator<T> for iteration in KFileItemModel::slotCompleted()
Ivailo Monev [Mon, 31 Oct 2022 18:53:09 +0000 (20:53 +0200)]
dolphin: use QMutableSetIterator<T> for iteration in KFileItemModel::slotCompleted()

fixes possible crash

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agoplasma: include now required system limits header
Ivailo Monev [Mon, 31 Oct 2022 04:20:18 +0000 (06:20 +0200)]
plasma: include now required system limits header

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agoklipper: adjust to QDataStream change
Ivailo Monev [Mon, 31 Oct 2022 04:14:37 +0000 (06:14 +0200)]
klipper: adjust to QDataStream change

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agoklipper: stream the history version as qint8
Ivailo Monev [Mon, 31 Oct 2022 04:06:42 +0000 (06:06 +0200)]
klipper: stream the history version as qint8

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agogeneric: const-ify iterator values where possible
Ivailo Monev [Sun, 30 Oct 2022 02:46:13 +0000 (04:46 +0200)]
generic: const-ify iterator values where possible

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokwin: const-ify iterator values where possible
Ivailo Monev [Sat, 29 Oct 2022 04:22:07 +0000 (07:22 +0300)]
kwin: const-ify iterator values where possible

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokwin: use QMutableListIterator<T> for iteration in Compositor::performCompositing()
Ivailo Monev [Sat, 29 Oct 2022 04:15:00 +0000 (07:15 +0300)]
kwin: use QMutableListIterator<T> for iteration in Compositor::performCompositing()

the list is modified while being iterated over

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokwin: const-ify iterator values where possible
Ivailo Monev [Sat, 29 Oct 2022 04:11:05 +0000 (07:11 +0300)]
kwin: const-ify iterator values where possible

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokwin: zero-initialize the buffer in Compositor::setup()
Ivailo Monev [Sat, 29 Oct 2022 03:42:45 +0000 (06:42 +0300)]
kwin: zero-initialize the buffer in Compositor::setup()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokstyles: fix runtime warning about connection to non-existing slot
Ivailo Monev [Sat, 29 Oct 2022 03:29:54 +0000 (06:29 +0300)]
kstyles: fix runtime warning about connection to non-existing slot

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokstyles: remove forward declaration of non-existing AnimationConfigWidget class
Ivailo Monev [Sat, 29 Oct 2022 03:27:05 +0000 (06:27 +0300)]
kstyles: remove forward declaration of non-existing AnimationConfigWidget class

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokstyles: indent switch cases in oxygenstyleconfig source file
Ivailo Monev [Sat, 29 Oct 2022 03:26:38 +0000 (06:26 +0300)]
kstyles: indent switch cases in oxygenstyleconfig source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokstyles: parent the QLibrary pointers to ConfigDialog
Ivailo Monev [Sat, 29 Oct 2022 03:21:43 +0000 (06:21 +0300)]
kstyles: parent the QLibrary pointers to ConfigDialog

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokcontrol: iterate over a consant in loadPreview() function of icons KCM
Ivailo Monev [Sat, 29 Oct 2022 03:18:12 +0000 (06:18 +0300)]
kcontrol: iterate over a consant in loadPreview() function of icons KCM

fixes crash

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agodolphin: use QMutableSetIterator<T> for iteration in KFileItemModelRolesUpdater:...
Ivailo Monev [Sat, 29 Oct 2022 01:45:32 +0000 (04:45 +0300)]
dolphin: use QMutableSetIterator<T> for iteration in KFileItemModelRolesUpdater::updateChangedItems()

fixes possible crash

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agoMerge branch 'master' of https://scm.osdn.net/gitroot/kde/kde-workspace
Ivailo Monev [Sat, 29 Oct 2022 01:39:54 +0000 (04:39 +0300)]
Merge branch 'master' of https://scm.osdn.net/gitroot/kde/kde-workspace

20 months agokcontrol: iterate over a static list of possibilities in dateandtime KCM
Ivailo Monev [Sat, 29 Oct 2022 01:57:31 +0000 (04:57 +0300)]
kcontrol: iterate over a static list of possibilities in dateandtime KCM

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agodolphin: check if the URL index is not out-of-bounds in KFileItemModel::fileItem()
Ivailo Monev [Sat, 29 Oct 2022 01:39:40 +0000 (04:39 +0300)]
dolphin: check if the URL index is not out-of-bounds in KFileItemModel::fileItem()

fixes possible crash

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokglobalaccel: deep-copy the actions before iterating over them
Ivailo Monev [Fri, 28 Oct 2022 21:04:27 +0000 (00:04 +0300)]
kglobalaccel: deep-copy the actions before iterating over them

fixes crash

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agokglobalaccel: use QMutableListIterator<T>() for iteration in Component::loadSettings()
Ivailo Monev [Fri, 28 Oct 2022 20:30:50 +0000 (23:30 +0300)]
kglobalaccel: use QMutableListIterator<T>() for iteration in Component::loadSettings()

fixes possbile crash

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
20 months agogeneric: add open files widget feature information
Ivailo Monev [Fri, 28 Oct 2022 01:23:31 +0000 (04:23 +0300)]
generic: add open files widget feature information

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>