OSDN Git Service

Fix the C library initialization to avoid calling static C++ constructors twice.
authorDavid 'Digit' Turner <digit@google.com>
Thu, 28 May 2009 13:54:03 +0000 (15:54 +0200)
committerDavid 'Digit' Turner <digit@google.com>
Tue, 2 Jun 2009 21:27:44 +0000 (23:27 +0200)
commit03eabfe65e1e2c36f4d26c78a730fa19a3bdada3
treeb965ea27e54b0833639227c619f6e35647c92510
parent0353195f344666256dba474a15c9ba22cf0cccc9
Fix the C library initialization to avoid calling static C++ constructors twice.

The problem was due to the fact that, in the case of dynamic executables,
the dynamic linker calls the DT_PREINIT_ARRAY, DT_INIT and DT_INIT_ARRAY
constructors when loading shared libraries and dynamic executables,
*before* calling the executable's entry point (i.e. arch-$ARCH/bionic/crtbegin_dynamic.c)
which in turns call __libc_init() in libc.so, as defined by bionic/libc_init_dynamic.c

The latter did call these constructors array again, mistakenly.

The patch also updates the documentation of many related functions.

Also adds a new section to linker/README.TXT explaining restrictions on
C library usage.

The patch has been tested on a Dream for stability issues with
proprietary blobs:

- H264 decoding works
- Camera + Video recording works
- GPS works
- Sensors work

The tests in system/extra/tests/bionic/libc/common/test_static_cpp_mutex.cpp has been
run and shows the static C++ constructor being called only once.
libc/arch-arm/bionic/crtbegin_dynamic.S
libc/arch-arm/bionic/crtbegin_static.S
libc/arch-x86/bionic/crtbegin_dynamic.S
libc/arch-x86/bionic/crtbegin_static.S
libc/bionic/libc_init_common.c
libc/bionic/libc_init_dynamic.c
libc/bionic/libc_init_static.c
libc/private/bionic_preinit.h [new file with mode: 0644]
libc/private/pthread_internal.h [moved from libc/bionic/pthread_internal.h with 100% similarity]
linker/README.TXT
linker/linker.c