OSDN Git Service

powerpc/perf/hv-24x7: Fix incorrect comparison in memord
authorMichael Ellerman <mpe@ellerman.id.au>
Mon, 9 Oct 2017 10:52:44 +0000 (21:52 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Sun, 22 Oct 2017 10:08:31 +0000 (12:08 +0200)
commit05c14c03138532a3cb2aa29c2960445c8753343b
treee1050fde5da9e88b0390cfecb3f8234484966d4a
parent727f13616c45caa72e4325c5027c1a8f41e745a9
powerpc/perf/hv-24x7: Fix incorrect comparison in memord

In the hv-24x7 code there is a function memord() which tries to
implement a sort function return -1, 0, 1. However one of the
conditions is incorrect, such that it can never be true, because we
will have already returned.

I don't believe there is a bug in practice though, because the
comparisons are an optimisation prior to calling memcmp().

Fix it by swapping the second comparision, so it can be true.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/perf/hv-24x7.c