OSDN Git Service

Force FGS notifications to show for a minimum time
authorEvan Laird <evanlaird@google.com>
Mon, 5 Aug 2019 21:11:54 +0000 (17:11 -0400)
committerEvan Laird <evanlaird@google.com>
Wed, 11 Sep 2019 21:09:34 +0000 (21:09 +0000)
commit09843a687bc19f8e360b2f5b0493a1f378bb603b
tree4631b87c2ad321873e6c53bad34e2ccec7e724d1
parentc617be6fd6b6b7c3fbcce1e41abcb6f89219be45
Force FGS notifications to show for a minimum time

It's possible for a service to do a start/stop foreground and cause a
couple of things to happen:

NotificationManagerService will enqueue a EnqueueNotificationRunnable,
post a PostNotificationRunnable (for the startForeground), and then also
enqueue a CancelNotificationRunnable. There is some racy behavior here
in that the cancel runnable can get triggered in between enqueue and
post runnables. If the cancel happens first, then
NotificationListenerServices will never get the message.

This behavior is technically allowed, however for foreground services we
want to ensure that there is a minmum amount of time that notification
listeners are aware of the foreground service so that (for instance) the
FGS notification can be shown.

This CL does two things to mitigate this problem:

1. Introduce checking in the CancelNotificationRunnable such that it
will not cancel until after PostNotificationRunnable has finished
executing.

2. Introduce a NotificationLifetimeExtender method that will allow a
lifetime extender to manage the lifetime of a notification that has been
enqueued but not inflated yet.

Bug: 119041698
Test: atest NotificationManagerServiceTest
Test: atest ForegroundServiceNotificationListenerTest
Change-Id: I0680034ed9315aa2c05282524d48faaed066ebd0
Merged-In: I0680034ed9315aa2c05282524d48faaed066ebd0
packages/SystemUI/src/com/android/systemui/ForegroundServiceNotificationListener.java
packages/SystemUI/src/com/android/systemui/statusbar/NotificationLifetimeExtender.java
packages/SystemUI/src/com/android/systemui/statusbar/notification/NotificationEntryManager.java
packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarNotificationPresenter.java
packages/SystemUI/tests/src/com/android/systemui/ForegroundServiceNotificationListenerTest.java [new file with mode: 0644]
services/core/java/com/android/server/notification/NotificationManagerService.java
services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java