OSDN Git Service

netfilter: nf_queue: enqueue skbs with NULL dst
authorMarco Oliverio <marco.oliverio@tanaza.com>
Mon, 2 Dec 2019 18:54:30 +0000 (19:54 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Sat, 7 Dec 2019 18:53:00 +0000 (19:53 +0100)
commit0b9173f4688dfa7c5d723426be1d979c24ce3d51
treef2ce4b96d6ed153c586208c4e3f8500b2022e9d4
parent5a2e6af81807d4616f9839ad0ae7d1313b45c64d
netfilter: nf_queue: enqueue skbs with NULL dst

Bridge packets that are forwarded have skb->dst == NULL and get
dropped by the check introduced by
b60a77386b1d4868f72f6353d35dabe5fbe981f2 (net: make skb_dst_force
return true when dst is refcounted).

To fix this we check skb_dst() before skb_dst_force(), so we don't
drop skb packet with dst == NULL. This holds also for skb at the
PRE_ROUTING hook so we remove the second check.

Fixes: b60a77386b1d ("net: make skb_dst_force return true when dst is refcounted")
Signed-off-by: Marco Oliverio <marco.oliverio@tanaza.com>
Signed-off-by: Rocco Folino <rocco.folino@tanaza.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_queue.c