OSDN Git Service

scsi: ufs: core: Fix task management request completion timeout
authorCan Guo <cang@codeaurora.org>
Thu, 1 Apr 2021 07:39:08 +0000 (00:39 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 2 Apr 2021 03:14:18 +0000 (23:14 -0400)
commit1235fc569e0bf541ddda0a1224d4c6fa6d914890
treea7134a8c3671b130a4badc4451c5588a4f1c8b24
parente01a00ff62adca8ec464f3c8d82cfa0e8d8728dd
scsi: ufs: core: Fix task management request completion timeout

ufshcd_tmc_handler() calls blk_mq_tagset_busy_iter(fn = ufshcd_compl_tm()),
but since blk_mq_tagset_busy_iter() only iterates over all reserved tags
and requests which are not in IDLE state, ufshcd_compl_tm() never gets a
chance to run. Thus, TMR always ends up with completion timeout. Fix it by
calling blk_mq_start_request() in __ufshcd_issue_tm_cmd().

Link: https://lore.kernel.org/r/1617262750-4864-2-git-send-email-cang@codeaurora.org
Fixes: 69a6c269c097 ("scsi: ufs: Use blk_{get,put}_request() to allocate and free TMFs")
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c