OSDN Git Service

block/qed: bdrv_qed_do_open: deal with errp
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Tue, 2 Feb 2021 12:49:55 +0000 (15:49 +0300)
committerEric Blake <eblake@redhat.com>
Mon, 8 Mar 2021 22:03:32 +0000 (16:03 -0600)
commit15ce94a68ca6730466c565c3d29971aab3087bf1
tree823abc2a4f102ecbb4875513a9caf7493cee2242
parente6247c9c9f9e4d01b00036f017da53d130981727
block/qed: bdrv_qed_do_open: deal with errp

Always set errp on failure. The generic bdrv_open_driver supports
driver functions which can return a negative value but forget to set
errp.  That's a strange thing. Let's improve bdrv_qed_do_open to not
behave this way. This allows the simplification of code in
bdrv_qed_co_invalidate_cache().

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20210202124956.63146-14-vsementsov@virtuozzo.com>
[eblake: commit message grammar tweak]
Signed-off-by: Eric Blake <eblake@redhat.com>
block/qed.c