OSDN Git Service

xfs: add missing error check in xfs_prepare_shift()
authorBrian Foster <bfoster@redhat.com>
Fri, 26 Apr 2019 14:30:24 +0000 (07:30 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 26 Apr 2019 19:28:56 +0000 (12:28 -0700)
commit1749d1ea89bdf3181328b7d846e609d5a0e53e50
tree436747e75f979cde4c5191c91ebdca80c43de657
parent47cd97b5b239b82829f780fc99821ab1745abc82
xfs: add missing error check in xfs_prepare_shift()

xfs_prepare_shift() fails to check the error return from
xfs_flush_unmap_range(). If the latter fails, that could lead to an
insert/collapse range operation over a delalloc range, which is not
supported.

Add an error check and return appropriately. This is reproduced
rarely by generic/475.

Fixes: 7f9f71be84bc ("xfs: extent shifting doesn't fully invalidate page cache")
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
fs/xfs/xfs_bmap_util.c