OSDN Git Service

scsi: libsas: Drop SAS_TASK_AT_INITIATOR
authorJohn Garry <john.garry@huawei.com>
Thu, 10 Feb 2022 10:43:24 +0000 (18:43 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 11 Feb 2022 22:02:50 +0000 (17:02 -0500)
commit26fc0ea74fcb9b76b41f5e9b89728cd1c01559cd
treebe8fb5e6ebc63597c147c35729e90a1c0ba4b1a2
parentc39d5aa457f2472c710e9e4cadb207338c0d34af
scsi: libsas: Drop SAS_TASK_AT_INITIATOR

This flag is now only ever set, so delete it.

This also avoids a use-after-free in the pm8001 queue path, as reported in
the following:

https://lore.kernel.org/linux-scsi/c3cb7228-254e-9584-182b-007ac5e6fe0a@huawei.com/T/#m28c94c6d3ff582ec4a9fa54819180740e8bd4cfb

https://lore.kernel.org/linux-scsi/0cc0c435-b4f2-9c76-258d-865ba50a29dd@huawei.com/

[mkp: checkpatch + two SAS_TASK_AT_INITIATOR references]

Link: https://lore.kernel.org/r/1644489804-85730-3-git-send-email-john.garry@huawei.com
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
12 files changed:
drivers/scsi/aic94xx/aic94xx_task.c
drivers/scsi/hisi_sas/hisi_sas_main.c
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
drivers/scsi/isci/request.c
drivers/scsi/isci/task.c
drivers/scsi/mvsas/mv_sas.c
drivers/scsi/pm8001/pm8001_hwi.c
drivers/scsi/pm8001/pm8001_sas.c
drivers/scsi/pm8001/pm80xx_hwi.c
include/scsi/libsas.h