OSDN Git Service

USB: serial: digi_acceleport: fix OOB-event processing
authorJohan Hovold <johan@kernel.org>
Fri, 24 Feb 2017 18:11:28 +0000 (19:11 +0100)
committerJohan Hovold <johan@kernel.org>
Mon, 6 Mar 2017 08:18:40 +0000 (09:18 +0100)
commit2e46565cf622dd0534a9d8bffe152a577b48d7aa
treef78ba8c9ca46ebf8eac75c038c423eef59c9ba46
parentc1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201
USB: serial: digi_acceleport: fix OOB-event processing

A recent change claimed to fix an off-by-one error in the OOB-port
completion handler, but instead introduced such an error. This could
specifically led to modem-status changes going unnoticed, effectively
breaking TIOCMGET.

Note that the offending commit fixes a loop-condition underflow and is
marked for stable, but should not be backported without this fix.

Reported-by: Ben Hutchings <ben@decadent.org.uk>
Fixes: 2d380889215f ("USB: serial: digi_acceleport: fix OOB data sanity
check")
Cc: stable <stable@vger.kernel.org> # v2.6.30: 2d380889215f
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/digi_acceleport.c