OSDN Git Service

drm/i915/display/dg1: Correctly map DPLLs during state readout
authorJosé Roberto de Souza <jose.souza@intel.com>
Wed, 30 Jun 2021 21:05:22 +0000 (14:05 -0700)
committerJosé Roberto de Souza <jose.souza@intel.com>
Thu, 1 Jul 2021 17:20:25 +0000 (10:20 -0700)
commit3352d86dcd3336a117630f0c1cfbc6bb8c93e1cf
tree3dbf18abff8916e93c5efbe2226591b59c7bfadc
parente42c6c1bc8d5e70d7b2c8af534b0d33a2be48f0c
drm/i915/display/dg1: Correctly map DPLLs during state readout

_DG1_DPCLKA0_CFGCR0 maps between DPLL 0 and 1 with one bit for phy A
and B while _DG1_DPCLKA1_CFGCR0 maps between DPLL 2 and 3 with one
bit for phy C and D.

Reusing _cnl_ddi_get_pll() don't take that into cosideration returing
DPLL 0 and 1 for phy C and D.

That is a regression introduced in the refactor done in
commit 351221ffc5e5 ("drm/i915: Move DDI clock readout to
encoder->get_config()").
While at it also dropping the macros previously used, not reusing it
to improve readability.

BSpec: 50286
Fixes: 351221ffc5e5 ("drm/i915: Move DDI clock readout to encoder->get_config()")
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210630210522.162674-1-jose.souza@intel.com
drivers/gpu/drm/i915/display/intel_ddi.c
drivers/gpu/drm/i915/i915_reg.h