OSDN Git Service

selftests/bpf: Fix probe_user test failure with clang build kernel
authorYonghong Song <yhs@fb.com>
Wed, 29 Sep 2021 03:30:00 +0000 (20:30 -0700)
committerAndrii Nakryiko <andrii@kernel.org>
Wed, 29 Sep 2021 06:17:22 +0000 (23:17 -0700)
commit38261f369fb905552ebdd3feb9699c0788fd3371
treecde70ab5309104e14ee36baaabf5fabf3426ae01
parent72e1781a5de9e3ee804e24f7ce9a7dd85596fc51
selftests/bpf: Fix probe_user test failure with clang build kernel

clang build kernel failed the selftest probe_user.
  $ ./test_progs -t probe_user
  $ ...
  $ test_probe_user:PASS:get_kprobe_res 0 nsec
  $ test_probe_user:FAIL:check_kprobe_res wrong kprobe res from probe read: 0.0.0.0:0
  $ #94 probe_user:FAIL

The test attached to kernel function __sys_connect(). In net/socket.c, we have
  int __sys_connect(int fd, struct sockaddr __user *uservaddr, int addrlen)
  {
        ......
  }
  ...
  SYSCALL_DEFINE3(connect, int, fd, struct sockaddr __user *, uservaddr,
                  int, addrlen)
  {
        return __sys_connect(fd, uservaddr, addrlen);
  }

The gcc compiler (8.5.0) does not inline __sys_connect() in syscall entry
function. But latest clang trunk did the inlining. So the bpf program
is not triggered.

To make the test more reliable, let us kprobe the syscall entry function
instead. Note that x86_64, arm64 and s390 have syscall wrappers and they have
to be handled specially.

Signed-off-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20210929033000.3711921-1-yhs@fb.com
tools/testing/selftests/bpf/prog_tests/probe_user.c
tools/testing/selftests/bpf/progs/test_probe_user.c