OSDN Git Service

omap-serial: Fix the error handling in the omap_serial probe
authorShubhrajyoti D <shubhrajyoti@ti.com>
Wed, 21 Mar 2012 11:52:22 +0000 (17:22 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Apr 2012 17:30:38 +0000 (10:30 -0700)
commit388bc26226807fbcf4c626b81bb17a2e74aa4b1b
treeaaed42d866485f0abac7c5b27146cd9eaded694a
parentc3d8b76f61586714cdc5f219ba45592a54caaa55
omap-serial: Fix the error handling in the omap_serial probe

The patch does the following

- The pm_runtime_disable is called in the remove not in the error
  case of probe.The patch calls the pm_runtime_disable in the error
  case.
- Calls pm_runtime_put in the error case.
- The  up is not freed in the error path. Fix the memory leak by using
  devm_* so that the memory need not be freed in the driver.
- Also the iounmap is not called fix the same by calling using devm_ioremap.
- Make the name of the error tags more meaningful.

Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Govindraj.R <govindraj.raja@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/omap-serial.c