OSDN Git Service

ALSA: hda - reverse the setting value in the micmute_led_set
authorHui Wang <hui.wang@canonical.com>
Tue, 11 Aug 2020 12:24:30 +0000 (20:24 +0800)
committerTakashi Iwai <tiwai@suse.de>
Tue, 11 Aug 2020 12:47:24 +0000 (14:47 +0200)
commit404690649e6a52ee39817168f2d984726412e091
treec3e9d40c2de5264b4532f08b96de8c28919262af
parent85cb905d3c5ff6107f4948314731c1b55b689cfc
ALSA: hda - reverse the setting value in the micmute_led_set

Before the micmute_led_set() is introduced, the function of
alc_gpio_micmute_update() will set the gpio value with the
!micmute_led.led_value, and the machines have the correct micmute led
status. After the micmute_led_set() is introduced, it sets the gpio
value with !!micmute_led.led_value, so the led status is not correct
anymore, we need to set micmute_led_polarity = 1 to workaround it.

Now we fix the micmute_led_set() and remove micmute_led_polarity = 1.

Fixes: 87dc36482cab ("ALSA: hda/realtek - Add LED class support for micmute LED")
Reported-and-suggested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Link: https://lore.kernel.org/r/20200811122430.6546-1-hui.wang@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_realtek.c