OSDN Git Service

openvswitch: Fix push/pop ethernet validation
authorJaime Caamaño Ruiz <jcaamano@suse.com>
Wed, 31 Oct 2018 17:52:03 +0000 (18:52 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 1 Nov 2018 01:37:16 +0000 (18:37 -0700)
commit46ebe2834ba5b541f28ee72e556a3fed42c47570
tree9634139a14978a7a81ced6bbf11f4ad3b49baaa4
parent30549aab146ccb1275230c3b4b4bc6b4181fd54e
openvswitch: Fix push/pop ethernet validation

When there are both pop and push ethernet header actions among the
actions to be applied to a packet, an unexpected EINVAL (Invalid
argument) error is obtained. This is due to mac_proto not being reset
correctly when those actions are validated.

Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html
Fixes: 91820da6ae85 ("openvswitch: add Ethernet push and pop actions")
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Tested-by: Greg Rose <gvrose8192@gmail.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/flow_netlink.c