OSDN Git Service

can: fix ioctl function removal
authorOliver Hartkopp <socketcan@hartkopp.net>
Mon, 29 Jul 2019 20:40:56 +0000 (22:40 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Jul 2019 21:12:35 +0000 (14:12 -0700)
commit473d924d7d46cb57aa4c1863261d18366af345af
tree797f90f9d80608f7e7175511617de44ecdc7fbea
parent1cb9dfca39eb406960f8f84864ddd6ba329ec321
can: fix ioctl function removal

Commit 60649d4e0af ("can: remove obsolete empty ioctl() handler") replaced the
almost empty can_ioctl() function with sock_no_ioctl() which always returns
-EOPNOTSUPP.

Even though we don't have any ioctl() functions on socket/network layer we need
to return -ENOIOCTLCMD to be able to forward ioctl commands like SIOCGIFINDEX
to the network driver layer.

This patch fixes the wrong return codes in the CAN network layer protocols.

Reported-by: kernel test robot <rong.a.chen@intel.com>
Fixes: 60649d4e0af ("can: remove obsolete empty ioctl() handler")
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/can/bcm.c
net/can/raw.c