OSDN Git Service

media: atomisp: remove private acceleration ioctls
authorHans de Goede <hdegoede@redhat.com>
Wed, 15 Jun 2022 20:50:15 +0000 (21:50 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 8 Jul 2022 15:22:44 +0000 (16:22 +0100)
commit4bbca788b6eb8176c8a1ccfe3b3ead0feb71ae07
tree6a5c319cd3ff2a9c2cc2228124828a6f6d5fdb0a
parent5c9152945648034700ac7d9c7d7051ab53157174
media: atomisp: remove private acceleration ioctls

These ioctls allow userspace to load custom programs into the ISP, which:

a) Seems dangerous
b) Cannot be used by opensource userspace since there is no FOSS code to
   create such programs
b) These seem to be unused even by the Android closed source camera code
   (they don't show up in a strace of the camera app)

So removing these seems be a good idea. Another reason to remove these is
that atomisp_acc_map() is the only user of the userptr functionality in
hmm_alloc(), so it gets in the way of further cleanups / simplification
of the hmm code.

Link: https://lore.kernel.org/linux-media/20220615205037.16549-19-hdegoede@redhat.com
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/include/linux/atomisp.h
drivers/staging/media/atomisp/pci/atomisp_acc.c
drivers/staging/media/atomisp/pci/atomisp_acc.h
drivers/staging/media/atomisp/pci/atomisp_compat_ioctl32.h
drivers/staging/media/atomisp/pci/atomisp_ioctl.c