OSDN Git Service

RDMA/core: Fix use of logical OR in get_new_pps
authorNathan Chancellor <natechancellor@gmail.com>
Mon, 17 Feb 2020 20:43:18 +0000 (13:43 -0700)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 19 Feb 2020 20:42:12 +0000 (16:42 -0400)
commit4ca501d6aaf21de31541deac35128bbea8427aa6
tree51c612d6ee4c93623f198706c4161fdf5546a40f
parente4103312d7b7afb8a3a7a842a33ef2b1856b2c0f
RDMA/core: Fix use of logical OR in get_new_pps

Clang warns:

../drivers/infiniband/core/security.c:351:41: warning: converting the
enum constant to a boolean [-Wint-in-bool-context]
        if (!(qp_attr_mask & (IB_QP_PKEY_INDEX || IB_QP_PORT)) && qp_pps) {
                                               ^
1 warning generated.

A bitwise OR should have been used instead.

Fixes: 1dd017882e01 ("RDMA/core: Fix protection fault in get_pkey_idx_qp_list")
Link: https://lore.kernel.org/r/20200217204318.13609-1-natechancellor@gmail.com
Link: https://github.com/ClangBuiltLinux/linux/issues/889
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/security.c