OSDN Git Service

Revert 76c5f277f2 "Re-land [Debug][CodeView] Emit fully qualified names for globals"
authorHans Wennborg <hans@chromium.org>
Mon, 18 May 2020 09:20:42 +0000 (11:20 +0200)
committerHans Wennborg <hans@chromium.org>
Mon, 18 May 2020 09:26:30 +0000 (11:26 +0200)
commit525a591f0f48b9d54018bf5245f2abee09c9c1c8
tree08a83f5097874b290e3a20534d28c7f549fc59fe
parent4f0cc10bf5d0009a9d00565fedb34933c2adf8f6
Revert 76c5f277f2 "Re-land [Debug][CodeView] Emit fully qualified names for globals"

> Before this patch, S_[L|G][THREAD32|DATA32] records were emitted with a simple name, not the fully qualified name (namespace + class scope).
>
> Differential Revision: https://reviews.llvm.org/D79447

This causes asserts in Chromium builds:

CodeViewDebug.cpp:2997: void llvm::CodeViewDebug::emitDebugInfoForUDTs(const std::vector<std::pair<std::string, const DIType *>> &):
Assertion `OriginalSize == UDTs.size()' failed.

I will follow up on the Phabricator issue.
lldb/test/Shell/SymbolFile/PDB/variables.test
llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
llvm/test/DebugInfo/COFF/global-constants.ll
llvm/test/DebugInfo/COFF/global_visibility.ll
llvm/test/DebugInfo/COFF/globals.ll
llvm/test/DebugInfo/COFF/types-array-unsized.ll